Hi Dhruva,
On mer., mai 29, 2024 at 11:39, Dhruva Gole wrote:
> Hi Sjoerd,
>
> On Aug 21, 2023 at 14:20:26 -0400, Tom Rini wrote:
>> On Mon, Aug 21, 2023 at 04:13:32PM +, Marcel Ziswiler wrote:
>> > Hi Sjoerd
>> >
>> > On Thu, 2023-06-01 at 08:37 +0200, Sjoerd Simons wrote:
>> > > On Wed,
Hi Caleb,
Thank you for the patch.
On lun., mai 27, 2024 at 19:17, Caleb Connolly
wrote:
> This is extremely similar to the MMC backend, but there are some notable
> differences.
>
> Works with a DFU string like
>
> scsi 4=u-boot-bin part 11
>
> Where "4" is the SCSI dev number
request.dma before calling dwc3_flush_cache() and later
> the usb_gadget_unmap_request() functions since it means that
> usb_gadget_map_request() hasn't been called yet.
>
> Fixes: fd15b58c1a9 ("dwc3: flush cache only if there is a buffer attached to
> a request")
> Signed
Hi Roman,
Thank you for the patch.
On dim., mai 19, 2024 at 19:18, Roman Stratiienko
wrote:
> Load only part of the boot partition that contains valuable
> information, thus improving the boot time.
>
> Signed-off-by: Roman Stratiienko
> ---
> boot/image-android.c | 70
arting address of the partition
> + * @out_num_bytes_preloaded: amount of bytes pre-loaded in memory
> + *
> + * @return:
> + * AVB_IO_RESULT_OK, if partition was found or was not found
Add:
AVB_IO_RESULT_ERROR_IO, if partition size is smaller than requested
With both small remar
Hi Roman,
Thank you for the patch.
On dim., mai 19, 2024 at 19:18, Roman Stratiienko
wrote:
> What it does:
> 1. Allocates the memory in HEAP to fit the partition
> 2. Loads partition into memory. In the following patch of this series,
>loading will be optimized to avoid loading an empty
Fix a trivial typo in the bootmeth documentation.
Signed-off-by: Mattijs Korpershoek
---
doc/usage/cmd/bootmeth.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/usage/cmd/bootmeth.rst b/doc/usage/cmd/bootmeth.rst
index 2903977ee54d..bac9fdf85cdc 100644
--- a/doc/usage
age_decomp() logic to always report the decompressed size,
even when a partial decompression happened.
Signed-off-by: Mattijs Korpershoek
---
This has been tested on an AM62X SK EVM board with a big lz4 image and
the default CONFIG_SYS_BOOTM_LEN of 0x80.
This has also been tested on sandbox us
eaves the boot image with only the GKI kernel."
>
> While at it, update wrong error handling message when vendor_boot
> cannot be loaded.
>
> [1]: https://source.android.com/docs/core/architecture/partitions/generic-boot
> Signed-off-by: Roman Stratiienko
> Reviewed-by: Mattijs Ko
eaves the boot image with only the GKI kernel."
>
> While at it, update wrong error handling message when vendor_boot
> cannot be loaded.
>
> [1]: https://source.android.com/docs/core/architecture/partitions/generic-boot
> Signed-off-by: Roman Stratiienko
Reviewed-by: Mattij
Hi Roman,
On jeu., mai 23, 2024 at 00:35, Roman Stratiienko
wrote:
[...]
>> >
>> > static struct cmd_tbl cmd_abootimg_sub[] = {
>> > - U_BOOT_CMD_MKENT(addr, 3, 1, do_abootimg_addr, "", ""),
>> > + U_BOOT_CMD_MKENT(addr, 4, 1, do_abootimg_addr, "", ""),
>> >
Hi Roman,
Thank you for the patch.
On dim., mai 19, 2024 at 12:53, Roman Stratiienko
wrote:
> Quote from [1]:
>
> "For devices launching with Android 13, the generic ramdisk is removed
> from the boot image and placed in a separate init_boot image.
> This change leaves the boot image with
d root is missing some of the necessary tools
> to complete virtual AB OTA.
>
> Signed-off-by: Roman Stratiienko
Reviewed-by: Mattijs Korpershoek
[1]
https://lore.kernel.org/r/CAGphcdnC124V_D6x06P6apnE+L+PVJSp+88h0FFY449CBgY=p...@mail.gmail.com
> ---
> boot/image-android.c | 17 ++
urn points into a single one
usb: dwc3: gadget: clear SUSPHY bit before ep cmds
usb: dwc3: gadget: only resume USB2 PHY in <=HIGHSPEED
usb: dwc3: gadget: properly check ep cmd
Mattijs Korpershoek (2):
MAINTAINERS: add tree link for fastboot
MAINTAINERS: add USB gadg
Hi,
On Thu, 16 May 2024 11:15:40 +0200, Mattijs Korpershoek wrote:
> I've noticed that I'm missing quite some USB gadget patches such as [1]
> since I'm not always cc'ed.
>
> With Marek, we agreed on the following split:
> - I take care of USB gadget side
> - Mare
Hi Marek,
Thank you for the review.
On jeu., mai 16, 2024 at 12:23, Marek Vasut wrote:
> On 5/16/24 11:15 AM, Mattijs Korpershoek wrote:
>> We try to split work with Marek on USB as following:
>> - Mattijs handles USB gadget
>> - Marek handles the rest of USB
>>
We try to split work with Marek on USB as following:
- Mattijs handles USB gadget
- Marek handles the rest of USB
Add additional gadget patterns to the maintainers file so that I
get cc'ed more often on USB gadget patches.
Signed-off-by: Mattijs Korpershoek
---
MAINTAINERS | 3 +++
1 file
Fastboot patches go through the u-boot-dfu tree.
Add a link in the maintainers file for it.
Signed-off-by: Mattijs Korpershoek
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6853288975c0..05217db79f7e 100644
--- a/MAINTAINERS
+++ b
at it, also update FASTBOOT entry to point towards the u-boot-dfu
tree.
[1]
https://lore.kernel.org/all/20240412202611.3565052-1-alexander.sverd...@siemens.com/
Signed-off-by: Mattijs Korpershoek
---
Changes in v2:
- Updated commit message (s/usb/USB) for patch 2
- Added ch9 include to USB gadget
Hi,
On Fri, 12 Apr 2024 22:26:00 +0200, A. Sverdlin wrote:
> From: Alexander Sverdlin
>
> While there are happy users who successfully have been using DFU on TI
> AM62x [1][2], there are also others who were not so lucky up to now [3].
>
> I felt into latter category and was wondering why I
We try to split work with Marek on USB as following:
- Mattijs handles usb gadget
- Marek handles the rest of usb
Add additional gadget patterns to the maintainers file so that I
get cc'ed more often on USB gadget patches.
Signed-off-by: Mattijs Korpershoek
---
MAINTAINERS | 2 ++
1 file
Fastboot patches go through the u-boot-dfu tree.
Add a link in the maintainers file for it.
Signed-off-by: Mattijs Korpershoek
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6853288975c0..05217db79f7e 100644
--- a/MAINTAINERS
+++ b
at it, also update FASTBOOT entry to point towards the u-boot-dfu
tree.
[1]
https://lore.kernel.org/all/20240412202611.3565052-1-alexander.sverd...@siemens.com/
Signed-off-by: Mattijs Korpershoek
---
Mattijs Korpershoek (2):
MAINTAINERS: add tree link for fastboot
MAINTAINERS: add usb
Greg from the cc list as I understand by [1] that he
prefers to not receives responses on this.
Reviewed-by: Mattijs Korpershoek
[1] https://lore.kernel.org/r/all/2024041354-exciting-suggest-b896@gregkh/
> ---
> drivers/usb/dwc3/gadget.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 delet
When checking for StartTransfer
> command, we need to make sure to match only lower 4
> bits which contain the actual command and ignore the
> rest.
>
> Reported-by: Janusz Dziedzic
> Signed-off-by: Felipe Balbi
> [A. Sverdlin: cherry-picked only DWC3_DEPCMD_CMD() define]
> S
DWC_usb3 3.30a and DWC_usb31 1.90a programming guide section 3.2.2
>
> Signed-off-by: Thinh Nguyen
> Signed-off-by: Felipe Balbi
> Signed-off-by: Alexander Sverdlin
Reviewed-by: Mattijs Korpershoek
> ---
> drivers/usb/dwc3/gadget.c | 29 +++--
> 1 fil
e're
> gonna work on SUPERSPEED or SUPERSPEED+, there's no
> point in resuming the USB2 PHY.
>
> Fixes: 2b0f11df84bb ("usb: dwc3: gadget: clear SUSPHY bit before ep cmds")
> Signed-off-by: Felipe Balbi
> Signed-off-by: Alexander Sverdlin
Reviewed-by: Ma
gt; DWC3_GUSB2PHY(n).SUSPHY bit is cleared.
>
> This patch implements that particular detail.
>
> Signed-off-by: Felipe Balbi
> Signed-off-by: Alexander Sverdlin
Reviewed-by: Mattijs Korpershoek
> ---
> drivers/usb/dwc3/gadget.c | 23 +++
> 1 file
; debug something or if we need to add more code
> before returning.
>
> Let's combine all three return points into a single
> one just by introducing a local 'ret' variable.
>
> Signed-off-by: Felipe Balbi
> Signed-off-by: Alexander Sverdlin
Reviewed-by: Mattijs K
Hi,
On Fri, 03 May 2024 09:00:38 +0200, Benjamin Hahn wrote:
> Set CONFIG_USB_GADGET_MANUFACTURER to PHYTEC for all PHYTEC boards.
>
>
Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-dfu
(u-boot-dfu)
[1/1] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC
Hi Benjamin,
Thank you for the patch.
On ven., mai 03, 2024 at 09:00, Benjamin Hahn wrote:
> Set CONFIG_USB_GADGET_MANUFACTURER to PHYTEC for all PHYTEC boards.
>
> Signed-off-by: Benjamin Hahn
Reviewed-by: Mattijs Korpershoek
This is assigned to me on patchwork. I can pick it up
nts.
>
> Signed-off-by: Sjoerd Simons
> Signed-off-by: Martyn Welch
Reviewed-by: Mattijs Korpershoek
I've tested usb gadget on Beagle Play board using fastboot.
Also tested DFU mode via snagboot.
Tested-by: Mattijs Korpershoek
> ---
> Changes in v5:
> - Use existing config f
fig rather than the
> fragment as this is known not to be supported on all boards that can
> support DFU.
>
> Signed-off-by: Sjoerd Simons
> Signed-off-by: Martyn Welch
Reviewed-by: Mattijs Korpershoek
> ---
> Changes in v5:
> - Switch to config fragment for a53 most DFU c
Hi Martyn,
Thank you for the patch.
On lun., mai 06, 2024 at 15:38, Martyn Welch wrote:
> From: Sjoerd Simons
>
> Enable usb0 in all boot phases for use with DFU
>
> Signed-off-by: Sjoerd Simons
> Reviewed-by: Alexander Sverdlin
> Signed-off-by: Martyn Welch
Hi Tom,
On jeu., mai 02, 2024 at 08:51, Tom Rini wrote:
> On Thu, May 02, 2024 at 09:40:52AM +0200, Mattijs Korpershoek wrote:
>> Hi Tom,
>>
>> Thank you for the patch
>>
>> On mer., mai 01, 2024 at 19:31, Tom Rini wrote:
>>
>> > Remove fro
plicit-function-declaration]
464 | unsigned long ts = get_timer(0);
|^
|get_mem
Adding: "#include " fixes the warning.
With the above fix included:
Reviewed-by: Mattijs Korpershoek
> #include
> #include
> #include
> diff --git a/drivers/usb/ho
Hi Tom,
Thank you for the patch.
On mer., mai 01, 2024 at 19:30, Tom Rini wrote:
> Remove from this driver directory and when needed
> add missing include files directly.
>
> Signed-off-by: Tom Rini
Reviewed-by: Mattijs Korpershoek
> ---
> Cc: Mattijs Korpersho
Hi Tom,
Thank you for the patch.
On mer., mai 01, 2024 at 19:30, Tom Rini wrote:
> Remove from this driver directory and when needed
> add missing include files directly.
>
> Signed-off-by: Tom Rini
Reviewed-by: Mattijs Korpershoek
Since this is quite a big series, I'm
Hi Tom,
Thank you for the patch.
On mer., mai 01, 2024 at 19:30, Tom Rini wrote:
> Remove from this driver directory and when needed
> add missing include files directly.
>
> Signed-off-by: Tom Rini
Reviewed-by: Mattijs Korpershoek
> ---
> Cc: Tom Rini
> Cc: To
Hi Martyn,
On mer., mai 01, 2024 at 14:56, Martyn Welch wrote:
> On Tue, 2024-01-16 at 11:22 +0100, Mattijs Korpershoek wrote:
>> > + /* Program PHY PLL refclk by reading syscon property */
>> > + ret = regmap_update_bits(syscon, args.args[0],
>> >
Hi,
On Wed, 24 Apr 2024 13:09:11 +0530, Ravi Gunasekaran wrote:
> When the device port is in a low power state [U3/L2/Not Connected],
> accesses to usb device registers may take a long time. This could lead to
> potential core hang when the controller registers are accessed after the
> port is
6,7 @@ static int cdns3_gadget_udc_stop(struct usb_gadget
>> *gadget)
>>
>> /* disable interrupt for device */
>> writel(0, _dev->regs->usb_ien);
>> +writel(0, _dev->regs->usb_pwr);
>> writel(USB_CONF_DEVDS, _dev->regs->usb_conf);
>>
>> return ret;
>>
>> base-commit: bc39e06778168a34bb4e0a34fbee4edbde4414d8
>
> Since this is gadget stuff, +CC Mattijs , that should go through their tree.
>
> Thanks!
Thank you Marek for CC'ing me, I missed this patch.
Reviewed-by: Mattijs Korpershoek
Hi Greg,
On ven., avril 19, 2024 at 15:21, Greg Malysa wrote:
> Hi Mattijs,
>
>> Please avoid top-posting when replying, it makes following the
>> discussion more difficult:
>>
Hi Tom,
Here is a new development for master:
- new "fastboot oem board" command
This CI job is at
https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/20427
Thanks,
Mattijs
The following changes since commit 2c3fa4b8add3cb6a440184ab67debc6867d383c0:
sandbox: don't call
Hi,
On Thu, 18 Apr 2024 13:01:28 +0300, Alexey Romanov wrote:
> Changes V1 -> V2 [1]:
> - Added an example of using the command as requested
> by Sean Anderson [2].
>
> Changes V2 -> V3 [3]:
> - Rebase over uboot/master.
> - Add documentation.
> - Remove example added in V2 [1].
>
>
gt;
> $ fastboot stage bootloader.img
> $ fastboot oem board:write_bootloader
>
> - erasing:
>
> $ fastboot oem board:erase_env
>
> Signed-off-by: Alexey Romanov
> Reviewed-by: Mattijs Korpershoek
After applying this patch on master, it seems that the CI broke:
gt; Signed-off-by: Michal Simek
Reviewed-by: Mattijs Korpershoek
> ---
>
> boot/Kconfig | 1 -
> cmd/Kconfig | 2 --
> 2 files changed, 3 deletions(-)
>
> diff --git a/boot/Kconfig b/boot/Kconfig
> index 777e408e2438..bb61e8b24f1c 100644
> --- a/boot/Kconfig
> ++
Hi,
On ven., avril 12, 2024 at 18:54, Aren wrote:
> On Thu, Apr 11, 2024 at 04:46:17PM +1000, John Watts wrote:
>> On Sun, Dec 31, 2023 at 03:38:37PM -0500, Aren Moynihan wrote:
>> > Add support for building the sunxi-musb driver with DM_USB_GADGET
>> > including adding a separate IRQ handling
Hi Jon,
On jeu., avril 11, 2024 at 15:30, Jon Humphreys wrote:
> Mattijs Korpershoek writes:
>
>> Hi Jonathan,
>>
>> Thank you for the patch.
>>
>> On lun., avril 08, 2024 at 17:31, Jonathan Humphreys
>> wrote:
>>
>>> Signed-off-by:
Hi Caleb,;
Thank you for the patch.
On jeu., avril 11, 2024 at 18:05, Caleb Connolly
wrote:
> The revision is different for these, add the additional check as in
> xhci-dwc3 core_init code.
>
> Signed-off-by: Caleb Connolly
Reviewed-by: Mattijs Korpershoek
> ---
> drive
off-by: Caleb Connolly
Reviewed-by: Mattijs Korpershoek
> ---
> disk/part_efi.c | 1 +
> include/part.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/disk/part_efi.c b/disk/part_efi.c
> index 4ce9243ef25c..d3ce4dd01dcd 100644
> --- a/disk/par
Hi Caleb,
Thank you for the patch.
On mar., avril 09, 2024 at 15:55, Caleb Connolly
wrote:
> This is extremely similar to the MMC backend, but there are some notable
> differences.
>
> Works with a DFU string like
>
> scsi 4=u-boot-bin part 11
>
> Where "4" is the SCSI dev number
Hi Greg,
Thank you for the contribution.
On mar., mars 26, 2024 at 11:36, Greg Malysa wrote:
Please avoid top-posting when replying, it makes following the
discussion more difficult:
On mar., avril 16, 2024 at 10:50, Mattijs Korpershoek
wrote:
> Hi Kongyang,
>
> Thank you for the patch.
>
> On jeu., mars 28, 2024 at 21:14, Kongyang Liu
> wrote:
>
>> Starting from version 4.20a, there has been a change in the reset method.
>> A new bi
has been completed.
>
> Signed-off-by: Kongyang Liu
I've compared this with the equivalent Linux patch found here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=65dc2e725286106f99c6f6b78e3d9c52c15f3a9c
Reviewed-by: Mattijs Korpershoek
Also tested on VIM3 t
Hi,
On Mon, 08 Apr 2024 13:15:51 +0300, Alexey Romanov wrote:
> Changes V1 -> V2 [1]:
> - Added an example of using the command as requested
> by Sean Anderson [2].
>
> Changes V2 -> V3 [3]:
> - Rebase over uboot/master.
> - Add documentation.
> - Remove example added in V2 [1].
>
>
i-u-boot/commit/?h=ti-u-boot-2023.04=c5296d943c2c84dd6dcb3b91305d006ac46f3157
Before patch:
=> reset
resetting ...
System reset not supported on this platform
### ERROR ### Please RESET the board ###
With patch applied:
=> reset
resetting ...
Tested-by: Mattijs Korpershoek # on am62x sk ev
>$ fastboot stage bootloader.img
>> >$ fastboot oem board:write_bootloader
>> >
>> > - erasing:
>> >
>> >$ fastboot oem board:erase_env
>> >
>> > Signed-off-by: Alexey Romanov
>> > Reviewed-by: Mattijs Korper
Hi Tom,
Thank you for the review.
On lun., avril 08, 2024 at 14:11, Tom Rini wrote:
> On Fri, Apr 05, 2024 at 08:16:19AM +0200, Mattijs Korpershoek wrote:
>
>
>> commit cacc0b2678c0 ("CI: Move to latest container image") updated the
>> docker container i
t;
> - flashing:
>
> $ fastboot stage bootloader.img
> $ fastboot oem board:write_bootloader
>
> - erasing:
>
> $ fastboot oem board:erase_env
>
> Signed-off-by: Alexey Romanov
Reviewed-by: Mattijs Korpershoek
Thank you for being patient on this topic!
I'll be aw
Hi Alexey,
On lun., mars 04, 2024 at 14:03, Alexey Romanov
wrote:
> Hello Mattijs,
>
> On Thu, Feb 15, 2024 at 10:24:11AM +0100, Mattijs Korpershoek wrote:
>> On jeu., f'evr. 01, 2024 at 12:20, Alexey Romanov
>> wrote:
>>
>> > An example of how w
Hi Alexey,
On lun., mars 04, 2024 at 14:11, Alexey Romanov
wrote:
> Hello,
>
> On Thu, Feb 15, 2024 at 10:14:13AM +0100, Mattijs Korpershoek wrote:
>> Hi Alexey,
>>
>> Thank you for the patch.
>>
>> On jeu., f'evr. 01, 2024 at 12:20, Alexey Romanov
ers, I have re-considered this and I'm willing to pick it up.
Please rebase, as this no longer applies.
Also see some review comments below
>
> On Thu, Feb 15, 2024 at 10:14:13AM +0100, Mattijs Korpershoek wrote:
>> Hi Alexey,
>>
>> Thank you for the patch.
>>
>>
: Patrick Delaunay
> Cc: Simon Glass
> Cc: Mattijs Korpershoek
> Cc: Ying-Chun Liu (PaulLiu)
> ---
> drivers/fastboot/fb_command.c | 8
> drivers/fastboot/fb_common.c | 15 +++
> drivers/fastboot/fb_getvar.c | 8 +++-
> 3 files changed, 26 insert
ick Delaunay
> Cc: Simon Glass
> Cc: Mattijs Korpershoek
> Cc: Ying-Chun Liu (PaulLiu)
This change (when applied along with 1/4 and 2/4) introduces a build for
sandbox:
$ make sandbox_defconfig
$ make
[...]
drivers/fastboot/fb_mmc.c: In function 'fastboot_mmc_erase':
drivers/fastbo
Hi Dmitrii,
Thank you for the patch and sorry for the review delay.
On mer., mars 06, 2024 at 18:59, Dmitrii Merkurev wrote:
> Signed-off-by: Dmitrii Merkurev
> Cc: Patrick Delaunay
> Cc: Simon Glass
> Cc: Mattijs Korpershoek
> Cc: Ying-Chun Liu (PaulLiu)
> ---
> dri
, Dmitrii Merkurev wrote:
> Co-developed-by: Cody Schuffelen
> Signed-off-by: Cody Schuffelen
> Signed-off-by: Dmitrii Merkurev
> Cc: Tuomas Tynkkynen
> Cc: Simon Glass
> Cc: Mattijs Korpershoek
> Cc: Ying-Chun Liu (PaulLiu)
I'm not super familiar with virtio, so I've not re
".
This fixes the HTML rendering.
Signed-off-by: Mattijs Korpershoek
---
doc/build/gen_compile_commands.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/build/gen_compile_commands.rst
b/doc/build/gen_compile_commands.rst
index 50305cec4a83..d503764f9e3f 100644
--- a/
commit cacc0b2678c0 ("CI: Move to latest container image") updated the
docker container image.
Reflect the change in the documentation.
Signed-off-by: Mattijs Korpershoek
---
Note: maybe we can consider doing the doc change each time we update
.gitlab-ci.yml ?
---
doc/build/dock
implementation
> - Documentation, including device tree bindings
>
> Signed-off-by: Igor Opaniuk
Reviewed-by: Mattijs Korpershoek
> ---
>
> MAINTAINERS | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0462ade4ac6..0f7325d6045 1
Hi Tom,
Here are some fixes for master including:
- Fix #if logic in android_ab command
- Fix ANDROID_AB_BACKUP_OFFSET in android_ab
The CI job is at
https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/20142
Thanks,
Mattijs
The following changes since commit
Hi Tom,
Here are some developments for next including:
- Implement Qualcomm wrapper for dwc3
- Multiple sector size support for UMS
- CDC ACM gadget initialization fix
- Refactor board code from dwc3 to prepare better interrupt support
- Bugfix for for qcom-smmu when compiling with -DDEBUG
The
Hi,
On Sun, 17 Mar 2024 05:42:52 +0100, Marek Vasut wrote:
> The dm_usb_gadget_handle_interrupts() has no place in board code. Move
> this into DWC3 driver. The OMAP implementation is special, add new weak
> dwc3_uboot_interrupt_status() function to decide whether DWC3 interrupt
> handling should
[1] https://lore.kernel.org/r/87a5mqei67@baylibre.com
> ---
> Cc: Mattijs Korpershoek
> ---
> drivers/usb/gadget/f_mass_storage.c | 13 +++--
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/gadget/f_mass_storage.c
> b/d
lab.com/amlogic-foss/amlogic-u-boot-autotest/-/pipelines/1233461384
>
> Signed-off-by: Neil Armstrong
> ---
> Changes in v2:
> - add change to remove prefix in fdtfile
> - collected review tags
> - Link to v1:
> https://lore.kernel.org/r/20240319-u-boot-of-upstream-v1-0-f8
Hi,
On jeu., mars 28, 2024 at 09:21, Neil Armstrong
wrote:
> Hi Mattijs,
>
> On 19/03/2024 15:42, Neil Armstrong wrote:
>> Enable OF_UPSTREAM to use upstream DT and add amlogic/ prefix to the
>> DEFAULT_DEVICE_TREE. And thereby directly build DTB from dts/upstream/src/
>> including
On jeu., mars 21, 2024 at 20:38, Marek Vasut wrote:
> On 3/21/24 11:01 AM, Mattijs Korpershoek wrote:
>> Hi Marek,
>>
>> Thank you for the patch.
>>
>> On dim., mars 17, 2024 at 05:42, Marek Vasut
>> wrote:
>>
>>> The dm_usb_gadge
Hi Caleb,
On jeu., mars 21, 2024 at 17:01, Caleb Connolly
wrote:
> On 21/03/2024 16:48, Mattijs Korpershoek wrote:
>> Hi Caleb,
>>
>> Thank you for the patch.
>>
>> On jeu., mars 21, 2024 at 15:28, Caleb Connolly
>> wrote:
>>
>>>
Hi,
On Tue, 12 Mar 2024 07:57:27 -0500, Colin McAllister wrote:
> - Addresses compiler error due to missing semicolon
> - Removes use of preprocessor macros with ANDROID_AB_BACKUP_OFFSET
>
> Bug was found by noticing a semicolon was missing and not causing a
> compiler error when
. Replace these divisions with calls to
> lldiv() to handle this correctly.
>
> Fixes: 74e56e0c5065 ("usb: gadget: UMS: support multiple sector sizes")
> Signed-off-by: Caleb Connolly
Reviewed-by: Mattijs Korpershoek
Would it be okay if I squashed this into
commit 74e56e0c5065 (&quo
:
f_mass_storage.c:946:(.text.do_write.lto_priv.0+0x1de): undefined reference to
`__aeabi_ldivmod'
Could you have a look, please?
Thank you.
Mattijs
On jeu., mars 21, 2024 at 10:23, Mattijs Korpershoek
wrote:
> Hi,
>
> On Wed, 20 Mar 2024 14:30:46 +, Caleb Connolly wrote:
>&
On jeu., mars 21, 2024 at 11:34, Caleb Connolly
wrote:
> Hi,
>
> On 21/03/2024 09:25, Mattijs Korpershoek wrote:
>> Hi Caleb, Marek,
>>
>> On jeu., mars 21, 2024 at 06:34, Marek Vasut wrote:
>>
>>> On 3/13/24 7:22 PM, Caleb Connolly wrote:
&g
itialised in
> that case.
>
> CONFIG_BUTTON is now enabled automatically and was removed when running
> save_defconfig.
>
> Fixes: e761035b6423 ("boot: add support for button commands")
> Signed-off-by: Caleb Connolly
Reviewed-by: Mattijs Korpershoek
> ---
> Pipeline:
called from board code as well.
>
> Signed-off-by: Marek Vasut
> ---
> Cc: Angus Ainslie
> Cc: Caleb Connolly
> Cc: Eugen Hristev
> Cc: Igor Prusov
> Cc: Mattijs Korpershoek
> Cc: Nishanth Menon
> Cc: Patrice Chotard
> Cc: Simon Glass
> Cc: Stefan Bosch
&
e whether DWC3 interrupt
> handling should be called, and override it in OMAP DWC3 code, to repair
> the special OMAP interrupt handling code until OMAP gets switched over
> to DM UDC proper.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Mattijs Korpershoek
Tested that I could s
contributions!
Mattijs
On mer., mars 13, 2024 at 18:22, Igor Opaniuk wrote:
> Hi Colin,
>
> On Tue, Mar 12, 2024 at 4:19 PM Mattijs Korpershoek <
> mkorpersh...@baylibre.com> wrote:
>
>> Hi Colin,
>>
>> Thank you for the patch.
>>
>> On mar.,
Hi Caleb, Marek,
On jeu., mars 21, 2024 at 06:34, Marek Vasut wrote:
> On 3/13/24 7:22 PM, Caleb Connolly wrote:
>
> [...]
>
+static inline void dwc3_qcom_setbits(void __iomem *base, u32 offset,
u32 val)
+{
+ u32 reg;
+
+ reg = readl(base + offset);
+
Hi,
On Wed, 20 Mar 2024 14:30:46 +, Caleb Connolly wrote:
> This series enables support for Qualcomm platforms in the DWC3 driver,
> adds support for arbitrary sector sizes to the USB mass storage gadget,
> and fixes an issue with the CDC ACM driver where it wouldn't initialise
> the USB
* to the backup offset
> - */
> - if (memcmp(backup_abc, abc, sizeof(*abc)) != 0) {
> - ret = ab_control_store(dev_desc, part_info, abc,
> -ANDROID_AB_BACKUP_OFFSET);
> - if (ret < 0) {
> - fr
#if.
>
> Fixes: 3430f24bc6 ("android_ab: Try backup booloader_message")
> Signed-off-by: Colin McAllister
> Cc: Joshua Watt
> Cc: Simon Glass
> Signed-off-by: Colin McAllister
Reviewed-by: Mattijs Korpershoek
Since Sam gave his review in [1]:
https://lore.kernel.
d using my personal email, but that email isn’t subscribed
> to this ML so I think the patches are pending approval to be added to the ML.
Yep, seems they got approved. I will follow-up on the v4 series.
>
> Best,
> Colin
>
> From: Mattijs Korpershoek
> Sent: Tuesday, March 12,
On jeu., mars 07, 2024 at 16:54, Sam Protsenko
wrote:
> On Thu, Mar 7, 2024 at 4:11 PM Colin McAllister
> wrote:
>>
>> Found a missing semicolon in code protected by a #if that will never
>> evaluate to true due to a separate issue. Fixing this issue before
>> addressing the #if.
>>
>>
Hi Colin,
On ven., mars 08, 2024 at 15:59, Sam Protsenko
wrote:
> On Fri, Mar 8, 2024 at 1:24 PM McAllister, Colin
> wrote:
>>
>> > Ah, ok, I see you replied to my comment here.
>>
>> Yes, sorry. Outlook is terrible to send inline responses too. I figured
>> just adding responses in the patch
Hi Igor, Sam,
On mar., févr. 20, 2024 at 20:08, Igor Opaniuk
wrote:
> Hi Sam,
>
> On Tue, Feb 20, 2024 at 7:29 PM Sam Protsenko
> wrote:
>>
>> On Mon, Feb 19, 2024 at 4:16 AM Igor Opaniuk wrote:
>> >
>> > This takes the latest changes from AOSP from [1][2] (as this
>> > header was split on
niu Rosca
> CC: Simon Glass
> Signed-off-by: Igor Opaniuk
Tested on Khadas VIM3 that I could reboot into fastbootd (recovery)
and into fastboot(u-boot) from Android using:
$ adb reboot fastboot
$ adb reboot bootloader
Reviewed-by: Mattijs Korpershoek
Tested-by: Mattijs Korpershoek #
Hi Jonas, thank you for the patch.
On lun., févr. 26, 2024 at 13:36, Jonas Karlman wrote:
> On 2024-02-26 11:18, Marek Vasut wrote:
>> On 2/26/24 10:50 AM, Jonas Karlman wrote:
>>> On 2024-02-26 09:22, Marek Vasut wrote:
On 2/26/24 8:54 AM, Jonas Karlman wrote:
> On 2024-02-26 02:47,
Hi Tom,
Here are some developments for master including:
- Fix avb_verify command with SD cards
- Add u-boot-dfu maintainer tree for AB/AVB
- Avb: report verified boot state based on lock state
- Misc avb refactors improve code quality
The CI job is at
11 bytes
> => optee_rpmb read_pvalue test_variable 11
> Read 11 bytes, value = test_value
>
> Signed-off-by: Igor Opaniuk
Reviewed-by: Mattijs Korpershoek
Tested-by: Mattijs Korpershoek # on sandbox
> ---
>
> cmd/Kconfig | 4 +++-
> 1 file changed, 3 insertions(+), 1 del
On jeu., févr. 01, 2024 at 12:20, Alexey Romanov
wrote:
> An example of how we use fastboot oeam board subcommand
> for Sean Anderson.
>
> 1 - OEM_BOARD_WRITE_BOOTLOADER_CMD:
>
> We use it for custom Amlogic bootloader + tpl
> flashing protocol.
>
> 2 - OEM_BOARD_ERASE_CMD:
>
> Custom logic for
Hi Alexey,
Thank you for the patch.
On jeu., févr. 01, 2024 at 12:20, Alexey Romanov
wrote:
> Currently, fastboot protocol in U-Boot has no opportunity
> to execute vendor custom code with verifed boot. This patch
> introduce new fastboot subcommand fastboot oem board:,
> which allow to run
1 - 100 of 433 matches
Mail list logo
