Re: [PATCH 1/4] wdt: Add CONFIG_DESIGNWARE_WATCHDOG to Kconfig

2020-02-20 Thread Marek Vasut
On 2/19/20 10:37 PM, Sean Anderson wrote: > On 2/3/20 3:13 AM, Marek Vasut wrote: >> On 2/2/20 7:02 PM, Sean Anderson wrote: btw what's the motivation for this series, are you hitting some issues with the WDT on SoCFPGA ? >>> >>> This watchdog appears on the Kendryte K210 CPU, which I am

Re: [PATCH 1/4] wdt: Add CONFIG_DESIGNWARE_WATCHDOG to Kconfig

2020-02-19 Thread Sean Anderson
On 2/3/20 3:13 AM, Marek Vasut wrote: > On 2/2/20 7:02 PM, Sean Anderson wrote: >>> btw what's the motivation for this series, are you hitting some issues >>> with the WDT on SoCFPGA ? >> >> This watchdog appears on the Kendryte K210 CPU, which I am adding >> support for. The rest of the board

Re: [PATCH 1/4] wdt: Add CONFIG_DESIGNWARE_WATCHDOG to Kconfig

2020-02-03 Thread Marek Vasut
On 2/2/20 7:02 PM, Sean Anderson wrote: >> btw what's the motivation for this series, are you hitting some issues >> with the WDT on SoCFPGA ? > > This watchdog appears on the Kendryte K210 CPU, which I am adding > support for. The rest of the board uses devicetree to configure drivers, > so I

Re: [PATCH 1/4] wdt: Add CONFIG_DESIGNWARE_WATCHDOG to Kconfig

2020-02-02 Thread Sean Anderson
> btw what's the motivation for this series, are you hitting some issues > with the WDT on SoCFPGA ? This watchdog appears on the Kendryte K210 CPU, which I am adding support for. The rest of the board uses devicetree to configure drivers, so I wanted to add support for this watchdog as well.

Re: [PATCH 1/4] wdt: Add CONFIG_DESIGNWARE_WATCHDOG to Kconfig

2020-02-02 Thread Marek Vasut
On 2/2/20 6:48 PM, Sean Anderson wrote: > On 2/2/20 12:40 PM, Marek Vasut wrote: >> On 2/2/20 6:23 PM, Sean Anderson wrote: >>> CONFIG_DESIGNWARE_WATCHDOG is only defined if CONFIG_HW_WATCHDOG is >>> defined, and this is never defined in headers (or in the defconfigs). >> >> This is what I see in

Re: [PATCH 1/4] wdt: Add CONFIG_DESIGNWARE_WATCHDOG to Kconfig

2020-02-02 Thread Sean Anderson
On 2/2/20 12:40 PM, Marek Vasut wrote: > On 2/2/20 6:23 PM, Sean Anderson wrote: >> CONFIG_DESIGNWARE_WATCHDOG is only defined if CONFIG_HW_WATCHDOG is >> defined, and this is never defined in headers (or in the defconfigs). > > This is what I see in socfpga_soc64_common.h on u-boot/master: > 153

Re: [PATCH 1/4] wdt: Add CONFIG_DESIGNWARE_WATCHDOG to Kconfig

2020-02-02 Thread Marek Vasut
On 2/2/20 6:23 PM, Sean Anderson wrote: > On 2/2/20 12:15 PM, Marek Vasut wrote: >> On 2/2/20 6:10 PM, Sean Anderson wrote: >>> Currently this is set from headers. No board has this set by default >> >> Please check where socfpga_common.h and socfpga_soc64_common.h are >> included. This should

Re: [PATCH 1/4] wdt: Add CONFIG_DESIGNWARE_WATCHDOG to Kconfig

2020-02-02 Thread Sean Anderson
On 2/2/20 12:10 PM, Sean Anderson wrote: > Currently this is set from headers. No board has this set by default, so we > don't need to modify any configs. > --- > drivers/watchdog/Kconfig | 7 +++ > include/configs/socfpga_common.h | 1 - >

Re: [PATCH 1/4] wdt: Add CONFIG_DESIGNWARE_WATCHDOG to Kconfig

2020-02-02 Thread Sean Anderson
On 2/2/20 12:15 PM, Marek Vasut wrote: > On 2/2/20 6:10 PM, Sean Anderson wrote: >> Currently this is set from headers. No board has this set by default > > Please check where socfpga_common.h and socfpga_soc64_common.h are > included. This should then make it clear that this statement in not

Re: [PATCH 1/4] wdt: Add CONFIG_DESIGNWARE_WATCHDOG to Kconfig

2020-02-02 Thread Marek Vasut
On 2/2/20 6:10 PM, Sean Anderson wrote: > Currently this is set from headers. No board has this set by default Please check where socfpga_common.h and socfpga_soc64_common.h are included. This should then make it clear that this statement in not true. , so we > don't need to modify any configs.

[PATCH 1/4] wdt: Add CONFIG_DESIGNWARE_WATCHDOG to Kconfig

2020-02-02 Thread Sean Anderson
Currently this is set from headers. No board has this set by default, so we don't need to modify any configs. --- drivers/watchdog/Kconfig | 7 +++ include/configs/socfpga_common.h | 1 - include/configs/socfpga_soc64_common.h | 1 - 3 files changed, 7 insertions(+), 2