Re: [PATCH] efi_loader: Fix spec ID event creation

2021-09-14 Thread Ilias Apalodimas
On Tue, Sep 14, 2021 at 12:14:31PM +0530, Ruchika Gupta wrote: > TCG EFI Protocol Specification defines the number_of_algorithms > field in spec ID event to be equal to the number of active > algorithms supported by the TPM device. In current implementation, > this field is populated with the

Re: [PATCH v2] board: sifive: Fix a potential build warning in board_fdt_blob_setup()

2021-09-14 Thread Leo Liang
On Sat, Sep 11, 2021 at 10:31:23PM +0800, Bin Meng wrote: > Commit 47d73ba4f4a4 ("board: sifive: overwrite board_fdt_blob_setup in u-boot > proper") > added a board-specific implementation of board_fdt_blob_setup() which > takes a pointer as the return value, but it does not return anything > if

Re: [PATCH v2 2/4] k210: clk: Refactor out_of_spec tests

2021-09-14 Thread Leo Liang
On Sat, Sep 11, 2021 at 01:20:01PM -0400, Sean Anderson wrote: > Everything here sits in a while (true) loop. However, this introduces a > couple of layers of indentation. We can simplify the code by introducing a > single goto instead of using continue/break. This will also make adding > loops in

Re: [PATCH v2 1/4] clk: k210: Fix checking if ulongs are less than 0

2021-09-14 Thread Leo Liang
On Sat, Sep 11, 2021 at 01:20:00PM -0400, Sean Anderson wrote: > The PLL functions take ulong arguments for rate, but still check if that > rate is negative (which is never true). The correct way to handle this is > to use IS_ERR_VALUE (like is already done in k210_clk_set_rate). While > we're at

Re: [PATCH v2 3/4] test: dm: k210: Reduce duplication in test cases

2021-09-14 Thread Leo Liang
On Sat, Sep 11, 2021 at 01:20:02PM -0400, Sean Anderson wrote: > Having to copy-paste the same 3 lines makes adding new test cases > error-prone. Use a macro. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass > --- > > (no changes since v1) > > test/dm/k210_pll.c | 30

[PATCH] image: fit: fix byte order for crc32 hash check

2021-09-14 Thread Mathew McBride
In 92055e138f ("image: Drop if/elseif hash selection in calculate_hash()") the FIT image hash verification code was simplified to use the hash API. This broke verification of CRC32 hash FIT images (e.g NXP MC firmware) as the hash API crc32 calculates in big endian (refer commit 74a18ee8a563,

Re: [PATCH v6 4/4] configs: enable SYSRESET_SBI on qemu-riscvXX_smode_defconfig

2021-09-14 Thread Leo Liang
On Sun, Sep 12, 2021 at 09:11:47PM +0200, Heinrich Schuchardt wrote: > There should be a platform compiled with the new driver. > > Enable CONFIG_SYSRESET_SBI for all QEMU boards using SBI. > > If you want to test the SBI sysreset driver, disable > CONFIG_SYSRESET_SYSCON. > > Signed-off-by:

Re: [PATCH 5/6] arm: Remove edminiv2 board and orion5x support

2021-09-14 Thread Simon Guinot
Hi Stefan and Tom, I finally managed to find a Disk Mini v2 Ethernet card and I will be working on the DM conversion as soon as possible. Please, let me know what is my deadline to complete this job ? Simon On Fri, Sep 10, 2021 at 06:41:14AM +0200, Stefan Roese wrote: > Hi Simon, > > On

Re: [PATCH] Allow colon in PXE bootfile URLs

2021-09-14 Thread Ramon Fried
On Tue, Sep 14, 2021 at 12:13 PM Ramon Fried wrote: > > On Sun, Aug 15, 2021 at 5:09 PM Lyle Franklin wrote: > > > > From: Lyle Franklin > > Date: Sun, 15 Aug 2021 07:17:14 -0400 > > Subject: [PATCH] Allow colon in PXE bootfile URLs > > > > - U-boot's PXE flow supports prefixing your bootfile

Re: [PATCH v2 3/6] net: dsa: refactor the code to set the port MAC address into a dedicated function

2021-09-14 Thread Ramon Fried
On Tue, Aug 24, 2021 at 3:01 PM Vladimir Oltean wrote: > > This snippet of code has a bothering "if (...) return 0" in it which > assumes it is the last piece of code running in dsa_port_probe(). > > This makes it difficult to add further code at the end of dsa_port_probe() > which does not

Re: [PATCH v2 1/6] net: dsa: felix: felix_init() can be static

2021-09-14 Thread Ramon Fried
On Tue, Aug 24, 2021 at 3:01 PM Vladimir Oltean wrote: > > No one is calling this function from outside felix_switch.c. > > Signed-off-by: Vladimir Oltean > Reviewed-by: Ramon Fried > Tested-by: Michael Walle > --- > drivers/net/mscc_eswitch/felix_switch.c | 2 +- > 1 file changed, 1

Re: [PATCH v2 6/6] net: dsa: felix: propagate the error code from phy_startup()

2021-09-14 Thread Ramon Fried
On Tue, Aug 24, 2021 at 3:01 PM Vladimir Oltean wrote: > > Make sure that the link status returned by phy_startup() is propagated > to the .start() method of struct eth_ops. > > Signed-off-by: Vladimir Oltean > Reviewed-by: Ramon Fried > Tested-by: Michael Walle > --- >

Re: [PATCH v2 4/6] net: dsa: introduce a .port_probe() method in struct dsa_ops

2021-09-14 Thread Ramon Fried
On Tue, Aug 24, 2021 at 3:01 PM Vladimir Oltean wrote: > > Some drivers might want to execute code for each port at probe time, as > opposed to executing code just-in-time for the port selected for > networking. > > To cater to that use case, introduce a .port_probe() callback method > into the

Re: [PATCH v2 2/6] net: dsa: use "err" instead of "ret" in dsa_port_probe

2021-09-14 Thread Ramon Fried
On Tue, Aug 24, 2021 at 3:01 PM Vladimir Oltean wrote: > > DM DSA uses "err" for error code values, so use this consistently. > > Signed-off-by: Vladimir Oltean > Reviewed-by: Ramon Fried > Tested-by: Michael Walle > --- > net/dsa-uclass.c | 8 > 1 file changed, 4 insertions(+), 4

[PATCH 2/2] phy: stm32-usbphyc: stm32: usbphyc: add protection on phy sub-node

2021-09-14 Thread Patrick Delaunay
Add protection on presence and order of the phy node sub node by using the mandatory reg information. Signed-off-by: Patrick Delaunay --- drivers/phy/phy-stm32-usbphyc.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/phy/phy-stm32-usbphyc.c

[PATCH 1/2] phy: stm32-usbphyc: use connector for vbus-supply with phy-stm32-usbphyc

2021-09-14 Thread Patrick Delaunay
The vbus-supply is an optional property of sub-node connector node. and no more in the usb phyc node (in first proposed binding). This regulator for USB VBUS may be needed for host mode. See the latest kernel binding for details in Documentation/devicetree/bindings/phy/phy-stm32-usbphyc.yaml.

Re: [PATCH] dfu: dfu_sf: Add support for multiple flashes

2021-09-14 Thread Lukasz Majewski
On Tue, 14 Sep 2021 05:27:51 +0200 Marek Vasut wrote: > Add dfu_alt_info option which allows specifying multiple SPI flashes > as an alt info. The syntax is as follows: > > altname sf bus:cs[:speed[:mode]] > > Example: > dfu_alt_info=qspi0 sf 0:0;qspi1 sf 0:1 > > Signed-off-by: Marek Vasut >

Re: [PATCH 0/3] stm32mp: Attempt to resolve unintended breakage with v2021.10-rc2

2021-09-14 Thread Patrick DELAUNAY
Hi Alexandru, On 9/9/21 4:55 PM, Alexandru Gagniuc wrote: u-boot v2021.10-rc2 Introduced support for booting from FIP images (not to be confused with FIT) for stm32mp. I am also working on a different boot flow based on u-boot's falcon mode. The changes to accommodate the FIP mode inadvertently

Re: [PATCH] image: fit: fix byte order for crc32 hash check

2021-09-14 Thread Tom Rini
On Tue, Sep 14, 2021 at 06:31:41AM +, Mathew McBride wrote: > In 92055e138f ("image: Drop if/elseif hash selection in calculate_hash()") > the FIT image hash verification code was simplified to use the hash API. > > This broke verification of CRC32 hash FIT images (e.g NXP MC firmware) > as

Re: [PATCH] dfu: dfu_sf: Read the SPI flash in 16 MiB chunks

2021-09-14 Thread Lukasz Majewski
On Tue, 14 Sep 2021 05:26:51 +0200 Marek Vasut wrote: > Not all SPI flashes and controllers can do continuous transfer longer > than 16 MiB, so perform the DFU read in 16 MiB chunks. > > Signed-off-by: Marek Vasut > Cc: Lukasz Majewski > --- > drivers/dfu/dfu_sf.c | 14 -- > 1

Re: [PATCH 5/6] arm: Remove edminiv2 board and orion5x support

2021-09-14 Thread Tom Rini
On Tue, Sep 14, 2021 at 10:37:43AM +0200, Simon Guinot wrote: > Hi Stefan and Tom, > > I finally managed to find a Disk Mini v2 Ethernet card and I will be > working on the DM conversion as soon as possible. > > Please, let me know what is my deadline to complete this job ? Great. So, the

[PATCH] arm: dts: stm32mp1: use ssbl partition name for U-Boot

2021-09-14 Thread Patrick Delaunay
Continue to use the "ssbl" name for GPT partition of secondary boot stage = U-Boot for basic boot with SPL to avoid to disturb existing user. The "fip" partition name is only used for TFA_BOOT with FIP, it is a TF-A BL2 requirement; it the default configuration for STMicroelectronics boards.

[PATCHv2 2/2] arm: Remove aspenite board

2021-09-14 Thread Tom Rini
This board has not been converted to CONFIG_DM by the deadline. Remove it. As this is the last armada100 platform, remove that support as well. Cc: Prafulla Wadaskar Signed-off-by: Tom Rini --- Changes in v2: This is the last armada100 platform, remove all of that related code now too. ---

[PATCH] mtd: rawnand: Add Macronix raw NAND controller driver

2021-09-14 Thread Zhengxun Li
Add a driver for Macronix raw NAND controller. This patch referred from linux mxic_nand.c. The difference from the linux version is described here. 1. In order to adapt to the uboot nand framework, add function binding (cmdfunc, read_byte, read_buf, write_buf). 2. Added parsing command

[PATCH] efi_loader: Fix spec ID event creation

2021-09-14 Thread Ruchika Gupta
TCG EFI Protocol Specification defines the number_of_algorithms field in spec ID event to be equal to the number of active algorithms supported by the TPM device. In current implementation, this field is populated with the count of all algorithms supported by the TPM which leads to incorrect spec

ECC strength for device tree with imx6 processor

2021-09-14 Thread Torrelli, Maxime
Hello dear U-Boot members, We recently tried to add support for a nand Flash (Micron MT29F4G08ABAEAWP among others) from U-Boot 2020.04 on an iMX6DL processor. We try to configure the ECC strength to 16 bits through the DTSI but when the U-Boot is started, the command mtd list returns that the

Re: [PATCH] Allow colon in PXE bootfile URLs

2021-09-14 Thread Ramon Fried
On Sun, Aug 15, 2021 at 5:09 PM Lyle Franklin wrote: > > From: Lyle Franklin > Date: Sun, 15 Aug 2021 07:17:14 -0400 > Subject: [PATCH] Allow colon in PXE bootfile URLs > > - U-boot's PXE flow supports prefixing your bootfile name with an > IP address to fetch from a server other than the DHCP

Re: [PATCHv2 1/2] arm: Remove flea3 board

2021-09-14 Thread Stefano Babic
On 14.09.21 15:09, Tom Rini wrote: This board has not been converted to CONFIG_DM by the deadline. Remove it. As this is the last mx35 platform, remove that support as well. Cc: Stefano Babic Signed-off-by: Tom Rini --- Acked-by: Stefano Babic Best regards, Stefano Babic --

RFC: exclude partitions from efi_selftest

2021-09-14 Thread Michael Lawnick
Hi, in our environment we get error on efi_selftest if one of several SSD partitions isn't properly initialized (due to some other error, but that's a different topic). I tried to track down to where the partitions get registered for test but got a bit lost so I request advice from you.

Re: [PATCH] efi_loader: Set EFI_SIMPLE_NETWORK_RECEIVE_INTERRUPT again in efi_net_receive()

2021-09-14 Thread Heinrich Schuchardt
On 9/14/21 4:06 AM, Masami Hiramatsu wrote: From: Kazuhiko Sakamoto Since 'this->int_status' is cleared by efi_net_get_status(), if user Is it correct to clear int_status unconditionally in efi_net_get_status()? Shouldn't two consecutive calls to EFI_SIMPLE_NETWORK.GetStatus() return the

Re: RFC: exclude partitions from efi_selftest

2021-09-14 Thread Heinrich Schuchardt
On 9/14/21 4:56 PM, Michael Lawnick wrote: Hi, in our environment we get error on efi_selftest if one of several SSD partitions isn't properly initialized (due to some other error, but that's a different topic). I tried to track down to where the partitions get registered for test but got a bit

Re: [PATCH] riscv: image: Use the first DRAM bank for bootm_low

2021-09-14 Thread Leo Liang
On Sun, Sep 12, 2021 at 11:26:45AM -0500, Samuel Holland wrote: > bootm_low is used as a base address is used to allocate space for the > FDT blob, initrd, cmdline, etc. when booting Linux. Set the default > value for RISC-V to the start of the first DRAM bank, so platforms can > get their DRAM

[RFC][PATCH] mtd: spi: Set CONFIG_SF_DEFAULT_MODE default to 0

2021-09-14 Thread Marek Vasut
Before e2e95e5e254 ("spi: Update speed/mode on change") most systems silently defaulted to SF bus mode 0. Now the mode is always updated, which causes breakage. It seems most SF which are used as boot media operate in bus mode 0, so switch that as the default. This should fix booting at least on

Re: [RFC][PATCH] mtd: spi: Set CONFIG_SF_DEFAULT_MODE default to 0

2021-09-14 Thread Tom Rini
On Tue, Sep 14, 2021 at 08:28:24PM +0200, Marek Vasut wrote: > Before e2e95e5e254 ("spi: Update speed/mode on change") most systems > silently defaulted to SF bus mode 0. Now the mode is always updated, > which causes breakage. It seems most SF which are used as boot media > operate in bus mode

Re: [RFC][PATCH] mtd: spi: Set CONFIG_SF_DEFAULT_MODE default to 0

2021-09-14 Thread Marek Vasut
On 9/14/21 10:45 PM, Tom Rini wrote: On Tue, Sep 14, 2021 at 10:10:22PM +0200, Marek Vasut wrote: On 9/14/21 9:19 PM, Tom Rini wrote: On Tue, Sep 14, 2021 at 08:28:24PM +0200, Marek Vasut wrote: Before e2e95e5e254 ("spi: Update speed/mode on change") most systems silently defaulted to SF bus

Re: [PATCH v2] lib: fix typos in Kconfig

2021-09-14 Thread Tom Rini
On Wed, Sep 01, 2021 at 04:05:08PM +0300, Oleksandr Suvorov wrote: > There are trivial typos in the Kconfig file. Fixed them. > Also, fixed grammar in the descriptions with typos. > > Fixes: d56b4b1974 ("configs: Migrate RBTREE, LZO, CMD_MTDPARTS, CMD_UBI and > CMD_UBIFS") > Fixes: 7264f2928b

Re: [PATCH] image: rsa: Move padding_algos to linker lists

2021-09-14 Thread Tom Rini
On Wed, Aug 18, 2021 at 05:49:02PM -0500, Alexandru Gagniuc wrote: > We are not guaranteed to have the padding_pkcs_15_verify symbol since > commit 92c960bc1d ("lib: rsa: Remove #ifdefs from rsa.h"), and > commit 61416fe9df ("Kconfig: FIT_SIGNATURE should not select RSA_VERIFY") > > The

Re: [PATCH 1/1] lib/rsa: don't use NULL as key_id

2021-09-14 Thread Tom Rini
On Sat, Aug 28, 2021 at 12:13:05PM +0200, Heinrich Schuchardt wrote: > If keydir is not provided but name is we want to use name as key_id. > > But with the current coding name is only used on its own if it is NULL > and keydir is provided which never occurs. > > Fixes: 824ee745fbca ("lib/rsa:

[PATCH] image: Avoid erroneous double byte-swap in CRC value

2021-09-14 Thread Alexandru Gagniuc
The hash algorithm selection was streamlined in commit 92055e138f28 ("image: Drop if/elseif hash selection in calculate_hash()"). Said commit kept the call to cpu_to_uimage() to convert the CRC to big endian format. This would have been correct when calling crc32_wd(). However, the ->hash_func_ws

[ANN] U-Boot v2021.10-rc4 released

2021-09-14 Thread Tom Rini
Hey all, Alright, I'm a day late, but, here's v2021.10-rc4. We've had a few regressions pop up of late, unfortunately. I've pushed the fix for (what I believe are) existing FIT images showing a problem where we calculated the crc32 wrong. And we're just now starting to figure out the proper

Re: [RFC][PATCH] mtd: spi: Set CONFIG_SF_DEFAULT_MODE default to 0

2021-09-14 Thread Tom Rini
On Tue, Sep 14, 2021 at 10:10:22PM +0200, Marek Vasut wrote: > On 9/14/21 9:19 PM, Tom Rini wrote: > > On Tue, Sep 14, 2021 at 08:28:24PM +0200, Marek Vasut wrote: > > > > > Before e2e95e5e254 ("spi: Update speed/mode on change") most systems > > > silently defaulted to SF bus mode 0. Now the

Re: [RFC][PATCH] mtd: spi: Set CONFIG_SF_DEFAULT_MODE default to 0

2021-09-14 Thread Tom Rini
On Tue, Sep 14, 2021 at 11:30:01PM +0200, Marek Vasut wrote: > On 9/14/21 10:45 PM, Tom Rini wrote: > > On Tue, Sep 14, 2021 at 10:10:22PM +0200, Marek Vasut wrote: > > > On 9/14/21 9:19 PM, Tom Rini wrote: > > > > On Tue, Sep 14, 2021 at 08:28:24PM +0200, Marek Vasut wrote: > > > > > > > > >

Re: [PATCH] image: Avoid erroneous double byte-swap in CRC value

2021-09-14 Thread Tom Rini
On Tue, Sep 14, 2021 at 03:53:33PM -0500, Alexandru Gagniuc wrote: > The hash algorithm selection was streamlined in commit 92055e138f28 > ("image: Drop if/elseif hash selection in calculate_hash()"). Said > commit kept the call to cpu_to_uimage() to convert the CRC to big > endian format. > >

Re: [PATCH] pinctrl: fix typo

2021-09-14 Thread Tom Rini
On Wed, Sep 08, 2021 at 07:06:48PM +0800, Yuan Fang wrote: > From: Yuan Fang > > fix typo in pinctrl Kconfig file to avoid git commit failure on > some commit hooks check. > > Signed-off-by: Yuan Fang Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v3 03/29] arm: dts: ls1028a-{rdb, qds}: remove dm-pre-reloc property

2021-09-14 Thread Vladimir Oltean
On Thu, Sep 02, 2021 at 06:45:32PM +0200, Michael Walle wrote: > Nowadays, both boards boot using the TF-A BL1/BL2 and SPL isn't used at > all. The property is not needed, remove it. > > Signed-off-by: Michael Walle > --- Reviewed-by: Vladimir Oltean

Re: [PATCH v3 08/29] arm: dts: ls1028a: move the SPI and eSDHC controller nodes into /soc

2021-09-14 Thread Vladimir Oltean
On Thu, Sep 02, 2021 at 06:45:37PM +0200, Michael Walle wrote: > While inserting them into the new location, keep them sorted by the > register base offset just like in the linux kernel device tree. > > Signed-off-by: Michael Walle > --- Reviewed-by: Vladimir Oltean

boot using encrypted

2021-09-14 Thread Cedrick Kukela
Hello Guys, I am in the process of configuring u-boot so that I can boot an encrypted zImage. I was looking for a guide or documentation to make sure my understanding of what I need to do is correct. Could anyone point me in the correct direction? Thank you Cedrick

S25HS512 not functional with u-boot 2021.10.rc3

2021-09-14 Thread Harkirat Virk
I have a custom board using imx6ul and Spansion S25HS512T Flash. On the current version of u-boot (2021.10.rc3) and I am guessing even previous ones the Spansion flash is not functioning => sf probe drivers/core/uclass.c:325-uclass_find_device_by_seq() 0

Re: [PATCH 1/5] kgdb: Remove unused serial related options

2021-09-14 Thread Tom Rini
On Wed, Sep 15, 2021 at 10:07:23AM +0800, Peng Fan (OSS) wrote: > Just wonder anyone using kgdb in U-Boot? > And sharing the same uart with normal output? The KGDB code is also likely broken and could be removed in a follow-up patch. It is however in Kconfig currently. -- Tom signature.asc

Re: [PATCH v3 06/29] arm: dts: ls1028a: move I2C controller nodes into /soc

2021-09-14 Thread Vladimir Oltean
On Thu, Sep 02, 2021 at 06:45:35PM +0200, Michael Walle wrote: > While inserting them into the new location, keep them sorted by the > register base offset just like in the linux kernel device tree. > > Signed-off-by: Michael Walle > --- Reviewed-by: Vladimir Oltean

Re: [PATCH v3 07/29] arm: dts: ls1028a: move the FlexSPI controller node

2021-09-14 Thread Vladimir Oltean
On Thu, Sep 02, 2021 at 06:45:36PM +0200, Michael Walle wrote: > While inserting it into the new location, keep it sorted by the > register base offset just like in the linux kernel device tree. > > Signed-off-by: Michael Walle > --- Reviewed-by: Vladimir Oltean

Re: [PATCH v3 09/29] arm: dts: ls1028a: move the UART controller nodes into /soc

2021-09-14 Thread Vladimir Oltean
On Thu, Sep 02, 2021 at 06:45:38PM +0200, Michael Walle wrote: > While inserting them into the new location, keep them sorted by the > register base offset just like in the linux kernel device tree. > > Signed-off-by: Michael Walle > --- Reviewed-by: Vladimir Oltean

Re: [PATCH v3 11/29] arm: dts: ls1028a: move the GPIO controller nodes into /soc

2021-09-14 Thread Vladimir Oltean
On Thu, Sep 02, 2021 at 06:45:40PM +0200, Michael Walle wrote: > While inserting them into the new location, keep them sorted by the > register base offset just like in the linux kernel device tree. > > Signed-off-by: Michael Walle > --- Reviewed-by: Vladimir Oltean

Re: [PATCH v3 10/29] arm: dts: ls1028a: move the low-power UART nodes into /soc

2021-09-14 Thread Vladimir Oltean
On Thu, Sep 02, 2021 at 06:45:39PM +0200, Michael Walle wrote: > While inserting them into the new location, keep them sorted by the > register base offset just like in the linux kernel device tree. > > Signed-off-by: Michael Walle > --- Reviewed-by: Vladimir Oltean

Re: [PATCH v3 16/29] arm: dts: ls1028a: update the labels

2021-09-14 Thread Vladimir Oltean
On Thu, Sep 02, 2021 at 06:45:45PM +0200, Michael Walle wrote: > Update the labels of the nodes to match the kernel ones. > > Signed-off-by: Michael Walle > Reviewed-by: Vladimir Oltean > Tested-by: Vladimir Oltean > --- > - gpio0: gpio@230 { > + gpio1: gpio@230

Re: [PATCH v3 25/29] arm: dts: ls1028a: move the PCI I/O window to match

2021-09-14 Thread Vladimir Oltean
On Thu, Sep 02, 2021 at 06:45:54PM +0200, Michael Walle wrote: > To make the synchronization of the u-boot device tree with the one from > linux easier, move the I/O window to the one which is specified in the > linux device tree. The actual value shouldn't matter as long as it > mapped to the

Re: [PATCH v3 26/29] arm: dts: ls1028a: disable the PCIe controller by default

2021-09-14 Thread Vladimir Oltean
On Thu, Sep 02, 2021 at 06:45:55PM +0200, Michael Walle wrote: > Disable the PCIe controllers by default, just like in the linux device > tree. But there is one catch, for linux they are enabled in-place by the > bootloader. Obviously, this doesn't work for the bootloader. Thus we > explicitly

Re: [PATCH v3 28/29] arm: dts: ls1028a: sync the fsl-ls1028a.dtsi with linux

2021-09-14 Thread Vladimir Oltean
On Thu, Sep 02, 2021 at 06:45:57PM +0200, Michael Walle wrote: > Now that everything is prepared, copy the fsl-ls1028a.dtsi from the > linux kernel v5.14. > > Notable changes: > - second watchdog added > - the number of chip selects of the SPI controller is now correct and >reflects what

[PATCH 0/2] mmc: bcm2835_sdhost: use fallback clock rate

2021-09-14 Thread Vincent Fazio
Recent raspberry pi firmware has modified the behavior of GET_CLOCK_RATE to return zero (0) when there is no previous call to SET_CLOCK_RATE. This affects callers of bcm2835_get_mmc_clock and can lead to degraded MMC performance. Now, return the result of GET_MAX_CLOCK_RATE if GET_CLOCK_RATE is

[PATCH 2/2] mmc: bcm2835-host: let firmware manage the clock divisor

2021-09-14 Thread Vincent Fazio
Newer firmware can manage the SDCDIV clock divisor register, allowing the divisor to scale with the core as necessary. Leverage this ability if the firmware supports it. Adapted from the following raspberrypi Linux kernel commit: bcm2835-sdhost: Firmware manages the clock divisor

[PATCH 1/2] arm: rpi: fallback to max clock rate for MMC clock

2021-09-14 Thread Vincent Fazio
In rpi-firmware 25e2b597ebfb2495eab4816a276758dcc6ea21f1, the GET_CLOCK_RATE mailbox property was changed to return the last value set by SET_CLOCK_RATE. https://github.com/raspberrypi/firmware/issues/1619#issuecomment-917025502 Due to this change in firmware behavior, bcm2835_get_mmc_clock now

[PATCH 1/4] ARM: dts: sort Amlogic Makefile section

2021-09-14 Thread Christian Hewitt
Alpha sort the Amlogic dtb list (same as the kernel). Signed-off-by: Christian Hewitt --- arch/arm/dts/Makefile | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index f0160d2dc0..461448c579 100644 ---

[PATCH 0/4] ARM: amlogic: add Radxa Zero

2021-09-14 Thread Christian Hewitt
This series alpha sorts the Amlogic Makefile, then adds support for the Radxa Zero SBC using the device-tree queued in the Amlogic maintainer tree for Linux 5.16.y Patches are based on custodians/u-boot-amlogic-next Christian Hewitt (4): ARM: dts: sort Amlogic Makefile section ARM: dts: add

Re: [PATCH 1/9] cache: sifive: Fix -Wint-to-pointer-cast warning

2021-09-14 Thread Leo Liang
On Sun, Sep 12, 2021 at 11:15:08AM +0800, Bin Meng wrote: > The following warning is seen in cache-sifive-ccache.c in a 32-bit build: > > warning: cast to pointer from integer of different size > [-Wint-to-pointer-cast] > > Fix by casting it with uintptr_t. > > Signed-off-by: Bin Meng > --- >

Re: [PATCH v3 12/29] arm: dts: ls1028a: move SATA and USB controller nodes into /soc

2021-09-14 Thread Vladimir Oltean
On Thu, Sep 02, 2021 at 06:45:41PM +0200, Michael Walle wrote: > While inserting them into the new location, keep them sorted by the > register base offset just like in the linux kernel device tree. > > Signed-off-by: Michael Walle > --- Reviewed-by: Vladimir Oltean

Re: [PATCH v3 15/29] arm: dts: ls1028a: move the iRC node and its devices into /soc

2021-09-14 Thread Vladimir Oltean
On Thu, Sep 02, 2021 at 06:45:44PM +0200, Michael Walle wrote: > While inserting them into the new location, keep them sorted by the > register base offset just like in the linux kernel device tree. > > While at it fix the indentation. > > Signed-off-by: Michael Walle > --- Reviewed-by:

Re: [PATCH v3 24/29] arm: dts: ls1028a: remove num-lanes in the PCIe controller nodes

2021-09-14 Thread Vladimir Oltean
On Thu, Sep 02, 2021 at 06:45:53PM +0200, Michael Walle wrote: > This property is unused in the layerscape PCIe controller driver and not > present in the linux device tree. Remove it to be similarly. > > Signed-off-by: Michael Walle > --- Looks pretty much unused, indeed. Reviewed-by:

Re: [PATCH v3 27/29] arm: dts: ls1028a: drop non-removable property from esdhc controller node

2021-09-14 Thread Vladimir Oltean
On Thu, Sep 02, 2021 at 06:45:56PM +0200, Michael Walle wrote: > The linux device tree hasn't set this property. To be similarly we remove s/similarly/similar/ > it from the u-boot device tree, too. The second controller of the > LS1028A has indeed no card detect pin. Because it is an eMMC

Re: [PATCH] efi_loader: Set EFI_SIMPLE_NETWORK_RECEIVE_INTERRUPT again in efi_net_receive()

2021-09-14 Thread Masami Hiramatsu
Hi Heinrich, This is obscure in the specification (I can not see any detailed description about EFI_SIMPLE_NETWORK_RECEIVE_INTERRUPT). If EFI_SIMPLE_NETWORK.GetStatus() returns only the hardware interrupt state, it is an useless interface, because it doesn't sync to the status of the packet

[PATCH 4/4] doc: boards: amlogic: update for Radxa Zero

2021-09-14 Thread Christian Hewitt
Add documentation bits for the Radxa Zero Signed-off-by: Christian Hewitt --- doc/board/amlogic/index.rst | 3 +- doc/board/amlogic/radxa-zero.rst | 74 2 files changed, 76 insertions(+), 1 deletion(-) create mode 100644 doc/board/amlogic/radxa-zero.rst

[PATCH 2/4] ARM: dts: add support for Radxa Zero

2021-09-14 Thread Christian Hewitt
Import the initial dts queued for Linux 5.16.y Signed-off-by: Christian Hewitt --- arch/arm/dts/Makefile | 1 + .../arm/dts/meson-g12a-radxa-zero-u-boot.dtsi | 7 + arch/arm/dts/meson-g12a-radxa-zero.dts| 405 ++ 3 files changed, 413

[PATCH 3/4] boards: amlogic: add Radxa Zero defconfig

2021-09-14 Thread Christian Hewitt
Add a defconfig for the Radxa Zero SBC, using an Amlogic S905Y2 chip. Signed-off-by: Christian Hewitt --- configs/radxa-zero_defconfig | 70 1 file changed, 70 insertions(+) create mode 100644 configs/radxa-zero_defconfig diff --git

Re: [PATCH] apalis/colibri_imx6: move setting bootcmd to defconfig

2021-09-14 Thread Peng Fan (OSS)
On 2021/9/13 3:39, Oleksandr Suvorov wrote: Move setting the default boot command to the apalis/colibri_imx6_defconfig. It allows replacing the command without code modification. Signed-off-by: Oleksandr Suvorov --- configs/apalis_imx6_defconfig | 1 + configs/colibri_imx6_defconfig |

Re: [PATCH] imx8mn_beacon: Fix booting hang and switch to binman

2021-09-14 Thread Peng Fan (OSS)
On 2021/9/11 4:19, Adam Ford wrote: Somewhere along the line, the board stopped being able to boot. Rather than just fixing the issue, let's fix the issue and migrate to binman to eliminate a warning when using custom imx tools for generating the binary. Signed-off-by: Adam Ford diff --git

Re: imx: imx8mq: mxc_get_clock for MXC_I2C_CLK is missing

2021-09-14 Thread Peng Fan (OSS)
On 2021/9/8 21:08, Heiko Thiery wrote: Hi Peng, I faced an issue with the I2C bus speed in SPL for the imx8mq. I figured out that the bus frequency is set to about 1MHz. While digging into that I found that the clk ID for the I2C is not returned for the imx8mq correctly. Can you confirm

Re: [PATCH 3/3] imx8qm_mek: Increase CONFIG_SYS_BOOTM_LEN to 64MB

2021-09-14 Thread Peng Fan (OSS)
On 2021/8/30 19:11, Oleksandr Suvorov wrote: On Sun, Aug 29, 2021 at 10:55 PM Marek Vasut wrote: On 8/29/21 9:39 PM, Oleksandr Suvorov wrote: The BSP platform LmP supports the board NXP iMX8QM MEK. The kernel size in LmP exceeds 32Mb. Increase the maximum size of an uncompressed kernel to

[PATCH] mtd: spi-nor: Fix SF MTDIDS when registering multiple MTDs with DM enabled

2021-09-14 Thread Marek Vasut
The flash->mtd.name used to be nor%d before, now it is the type of the SPI NOR like e.g. mt25ql02g. It is possible to find plenty of examples of the former in U-Boot configs by searching for MTDIDS.*nor.*spi, while the later is ambiguous if there are multiple flashes of the same type in the system

Re: [PATCH v3 04/29] arm: dts: ls1028a: add an empty /soc

2021-09-14 Thread Vladimir Oltean
On Thu, Sep 02, 2021 at 06:45:33PM +0200, Michael Walle wrote: > To keep the device tree similar to the linux kernel one, we need to move > all CCSR related devices into the /soc node. To keep the patches easy to > review, we initially add an empty /soc node and populate it piece by > piece. > >

Re: [PATCH v3 05/29] arm: dts: ls1028a: move the clockgen node into /soc

2021-09-14 Thread Vladimir Oltean
On Thu, Sep 02, 2021 at 06:45:34PM +0200, Michael Walle wrote: > Populate the /soc node with the first device node. > > Signed-off-by: Michael Walle > --- Reviewed-by: Vladimir Oltean

Re: [PATCH v3 13/29] arm: dts: ls1028a: move the PCIe controller nodes into /soc

2021-09-14 Thread Vladimir Oltean
On Thu, Sep 02, 2021 at 06:45:42PM +0200, Michael Walle wrote: > While inserting them into the new location, keep them sorted by the > register base offset just like in the linux kernel device tree. > > While at it fix the indentation. > > Signed-off-by: Michael Walle > --- >

Re: [PATCH v3 14/29] arm: dts: ls1028a: move the watchdog node into /soc

2021-09-14 Thread Vladimir Oltean
On Thu, Sep 02, 2021 at 06:45:43PM +0200, Michael Walle wrote: > While inserting it into the new location, keep it sorted by the > register base offset just like in the linux kernel device tree. > > Signed-off-by: Michael Walle > --- Reviewed-by: Vladimir Oltean

Re: [PATCH v3 19/29] spi: fsl_dspi: rename num-cs to spi-num-chipselects

2021-09-14 Thread Vladimir Oltean
On Thu, Sep 02, 2021 at 06:45:48PM +0200, Michael Walle wrote: > The official devicetree bindings specifies spi-num-chipselects as the > name. Use it. > > Signed-off-by: Michael Walle > --- Reviewed-by: Vladimir Oltean

Re: [PATCH v3 21/29] scsi: ceva: rename the resource name to match the linux kernel one

2021-09-14 Thread Vladimir Oltean
On Thu, Sep 02, 2021 at 06:45:50PM +0200, Michael Walle wrote: > The driver will look for a named resource "ecc-addr", but this isn't the > official binding. In fact, the official device tree binding > documentation doesn't mention any resource names at all. But it is safe > to assume that it's

Re: [PATCH v3 29/29] arm: dts: sl28: sync dtbs

2021-09-14 Thread Vladimir Oltean
On Thu, Sep 02, 2021 at 06:45:58PM +0200, Michael Walle wrote: > Copy the board device tree files from linux v5.14. On top of the v5.14 > dtbs the changes of these two patches are included here which are needed > for u-boot: > >

Re: [PATCH 1/5] kgdb: Remove unused serial related options

2021-09-14 Thread Peng Fan (OSS)
Just wonder anyone using kgdb in U-Boot? And sharing the same uart with normal output? Thanks, Peng On 2021/9/14 5:24, Tom Rini wrote: We have a few CONFIG options for KGDB that are not referenced, remove them. Signed-off-by: Tom Rini --- README | 5 -

Re: [PATCH] cmd: mmc: Support mmc hwpartition user enh start -

2021-09-14 Thread Peng Fan (OSS)
On 2021/9/12 5:14, Marek Vasut wrote: Add option to extend the hardware partition to the maximum size by using the '-' dash sign instead of $cnt parameter. This is useful in case we want to switch the entire eMMC user area into pSLC mode, especially in case the device may be populated with

Re: [PATCH] arm: imx8mp-evk: CLOCK Enable SPI and QOS clock

2021-09-14 Thread Peng Fan (OSS)
Please resend with plain text. On 2021/9/8 13:26, Arendt, Steffen wrote: Enable clocks for SPI and QOS (Ethernet) for the imx8mp SoC diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c index c77500bcce..1ab5587e4e 100644 --- a/drivers/clk/imx/clk-imx8mp.c +++

Re: [PATCH] arm: imx: imx8mq: add support to get values for more clocks

2021-09-14 Thread Peng Fan (OSS)
On 2021/9/9 20:59, Heiko Thiery wrote: Return the root clock values for MXC_CSPI_CLK, MXC_I2C_CLK, MXC_UART_CLK and MXC_QSPI_CLK. At least for the I2C clock the missing support leads to a wrong configured I2C frequency. The expected value is 100kHz but the resulting value is about 1MHz.

Re: [PATCH] arm: dts: imx8mp: Delete default clocks for clock controller node

2021-09-14 Thread Peng Fan (OSS)
On 2021/8/17 14:32, Ye Li wrote: Since SPL has initialized clocks for bus and core. We don't need to set the default clocks for clock controller node. Signed-off-by: Ye Li --- arch/arm/dts/imx8mp-u-boot.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH] mtd: cqspi: Wait for transfer completion

2021-09-14 Thread Pratyush Yadav
On 14/09/21 05:22AM, Marek Vasut wrote: > Wait for the read/write transfer finish bit get actually cleared, > this does not happen immediately on at least SoCFPGA Gen5. > > Signed-off-by: Marek Vasut > Cc: Jagan Teki > Cc: Vignesh R > Cc: Pratyush Yadav > --- > drivers/spi/cadence_qspi_apb.c

Re: [PATCH] mtd: cqspi: Fix division by zero

2021-09-14 Thread Marek Vasut
On 9/14/21 7:46 PM, Pratyush Yadav wrote: On 14/09/21 05:21AM, Marek Vasut wrote: Both dummy.nbytes and dummy.buswidth may be zero. By not checking the later, it is possible to trigger division by zero and a crash. This does happen with tiny SPI NOR framework in SPL. Fix this by adding the

Re: [PATCH] mtd: cqspi: Wait for transfer completion

2021-09-14 Thread Marek Vasut
On 9/14/21 7:42 PM, Pratyush Yadav wrote: On 14/09/21 05:22AM, Marek Vasut wrote: Wait for the read/write transfer finish bit get actually cleared, this does not happen immediately on at least SoCFPGA Gen5. Signed-off-by: Marek Vasut Cc: Jagan Teki Cc: Vignesh R Cc: Pratyush Yadav ---

Re: [RFC][PATCH] mtd: spi: Set CONFIG_SF_DEFAULT_MODE default to 0

2021-09-14 Thread Marek Vasut
On 9/14/21 9:19 PM, Tom Rini wrote: On Tue, Sep 14, 2021 at 08:28:24PM +0200, Marek Vasut wrote: Before e2e95e5e254 ("spi: Update speed/mode on change") most systems silently defaulted to SF bus mode 0. Now the mode is always updated, which causes breakage. It seems most SF which are used as

Re: [PATCH] mtd: cqspi: Fix division by zero

2021-09-14 Thread Pratyush Yadav
On 14/09/21 05:21AM, Marek Vasut wrote: > Both dummy.nbytes and dummy.buswidth may be zero. By not checking > the later, it is possible to trigger division by zero and a crash. > This does happen with tiny SPI NOR framework in SPL. Fix this by > adding the check and returning zero dummy bytes in

Re: [PATCH 3/9] gpio: sifive: Fix -Wint-to-pointer-cast warning

2021-09-14 Thread Leo Liang
On Sun, Sep 12, 2021 at 11:15:10AM +0800, Bin Meng wrote: > dev_read_addr() returns a value of type fdt_addr_t which is a 64-bit > address and plat->base is a pointer. In a 32-bit build, this causes the > following warning seen when building sifive-gpio.c: > > warning: cast to pointer from

[PATCH] mtd: spi-nor-core: Add fixups for s25fs512s

2021-09-14 Thread tkuw584924
From: Takahiro Kuwano The current S25FS512S support has following issues that need to be fixed. - Non-uniform sectors by factory default. The setting needs to be checked and assign erase hook as needed. - Page size is wrongly advertised in SFDP. - READ_1_1_2 (3Bh/3Ch), READ_1_1_4

Re: [PATCH 4/9] i2c: ocores: Fix -Wint-to-pointer-cast warning

2021-09-14 Thread Leo Liang
On Sun, Sep 12, 2021 at 11:15:11AM +0800, Bin Meng wrote: > The following warning is seen in ocores_i2c.c in a 32-bit build: > > warning: cast to pointer from integer of different size > [-Wint-to-pointer-cast] > > Change to use dev_read_addr_ptr(). > > Signed-off-by: Bin Meng > --- > >

Re: [PATCH 2/9] clk: sifive: Fix -Wint-to-pointer-cast warning

2021-09-14 Thread Leo Liang
On Sun, Sep 12, 2021 at 11:15:09AM +0800, Bin Meng wrote: > dev_read_addr() returns a value of type fdt_addr_t which is a 64-bit > address and pd->va is a pointer. In a 32-bit build, this causes the > following warning seen when building sifive-prci.c: > > warning: cast to pointer from integer

Re: [PATCH] mtd: spi-nor: Fix SF MTDIDS when registering multiple MTDs with DM enabled

2021-09-14 Thread Heiko Schocher
Hi Marek, On 15.09.21 01:06, Marek Vasut wrote: > The flash->mtd.name used to be nor%d before, now it is the type of the > SPI NOR like e.g. mt25ql02g. It is possible to find plenty of examples > of the former in U-Boot configs by searching for MTDIDS.*nor.*spi, while > the later is ambiguous if

[PATCH 1/3] efi_loader: add SMBIOS table measurement

2021-09-14 Thread Masahisa Kojima
TCG PC Client spec requires to measure the SMBIOS table that contain static configuration information (e.g. Platform Manufacturer Enterprise Number assigned by IANA, platform model number, Vendor and Device IDs for each SMBIOS table). The device and environment dependent information such as

  1   2   >