Re: [PATCH 2/2] mtd: spi-nor-ids: Add Gigadevice GD25LQ64C

2021-02-25 Thread Jagan Teki
On Sat, Oct 31, 2020 at 9:50 PM Alper Nebi Yasak wrote: > > Add GD25LQ24C 64Mbit chip to spi-nor id table. This chip is used on > rk3399-gru-kevin: > > => sf probe > SF: Detected gd25lq64c with page size 256 Bytes, erase size 4 KiB, total > 8 MiB > => sf erase 0x60 0x20 >

Re: [PATCH] mtd: spi-nor.h: Change spaces to tabs

2021-02-25 Thread Bin Meng
On Mon, Feb 1, 2021 at 1:30 PM Bin Meng wrote: > > On Wed, Jan 6, 2021 at 8:59 PM Bin Meng wrote: > > > > U-Boot coding convention prefers tabs over spaces. > > > > Signed-off-by: Bin Meng > > --- > > > > include/linux/mtd/spi-nor.h | 20 ++-- > > 1 file changed, 10

Re: [PATCH V2] spi: imx: Implement set_speed

2021-02-25 Thread Jagan Teki
On Wed, Feb 3, 2021 at 10:24 PM Marek Vasut wrote: > > The set_speed() callback should configure the bus speed, make it so. > > Signed-off-by: Marek Vasut > Cc: Jagan Teki > Cc: Stefano Babic > --- > V2: Rename dev_get_platdata() to dev_get_plat() > --- Applied to u-boot-spi/master

Re: [PATCH] firmware: scmi: Replace memcpy_from/toio() by memcpy() in scmi_read/write_resp_from_smt()

2021-02-25 Thread Patrice CHOTARD
Hi Mark On 2/24/21 3:05 PM, Mark Kettenis wrote: >> From: Patrice Chotard >> Date: Wed, 24 Feb 2021 13:47:55 +0100 >> >> To avoid "synchronous abort" in AARCH64 in case the "from" address >> is not aligned, replace memcpy_toio() and memcpy_fromio() by memcpy(). >> >> Signed-off-by: Patrice

[PATCH v2] cfi_flash: Fix detection of 8-bit bus flash devices via address shift

2021-02-25 Thread Stefan Roese
From: Jagannadha Sutradharudu Teki We had a problem detecting 8/16bit flash devices connected only via 8bits to the SoC for quite a while. Commit 239cb9d9 [mtd: cfi_flash: Fix CFI flash driver for 8-bit bus support] finally fixed this 8-bit bus support. But also broke some other boards using

[PATCH 2/2] of: addr: Translate 'dma-ranges' for parent nodes missing 'dma-ranges'

2021-02-25 Thread Bin Meng
'dma-ranges' frequently exists without parent nodes having 'dma-ranges'. While this is an error for 'ranges', this is fine because DMA capable devices always have a translatable DMA address. Also, with no 'dma-ranges' at all, the assumption is that DMA addresses are 1:1 with no restrictions unless

[PATCH 1/2] of: addr: Abort address translation for parent nodes missing 'ranges'

2021-02-25 Thread Bin Meng
The implementation of of_translate_one() was taken from the one in Linux kernel drivers/of/address.c, and the Linux one added a quirk for Apple Macs that don't have the property in the parent node. Since U-Boot does not support Apple Macs, remove the comment block and adhere to the spec to abort

Re: [PATCH] serial: ns16550: Correct the base address type

2021-02-25 Thread Bin Meng
Hi Simon, On Sun, Feb 7, 2021 at 8:16 AM Simon Glass wrote: > > On Wed, 3 Feb 2021 at 06:22, Bin Meng wrote: > > > > Currently ns16550_serial_assign_base() treats the argument 'base' > > with type `ulong`. This is incorrect because the base address was > > obtained from device tree with type

Re: [EXT] [PATCH] ARM: imx: Add OCRAM_S into iMX8M MMU tables

2021-02-25 Thread Ye Li
Hi Marek, On Thu, 2021-02-25 at 21:52 +0100, Marek Vasut wrote: > Caution: EXT Email > > The OCRAM_S is regular memory, just like the OCRAM, add it to the MMU > tables so it can be used and cached. > > Signed-off-by: Marek Vasut > Cc: Fabio Estevam > Cc: Peng Fan > Cc: Stefano Babic > --- >

[PATCH] cmd: mmc: modify more readable about hwpartition usage

2021-02-25 Thread Jaehoon Chung
Modified more readable about hwpartition usage. Because it's difficult to understand how to use its command. The arguments didn't optional. mmc hwpartition needs to passas arguments. Description about each arguments what is required is the below: USER - <{on|off}> GP -

Re: imx8mq: phycore-imx8mp

2021-02-25 Thread Teresa Remmet
Hello Heiko, Am Donnerstag, den 25.02.2021, 14:46 +0100 schrieb Heiko Schocher: > Hello Peng, Teresa, > > I am just trying to get linux-stable 5.10.y kernel with current > mainline > U-Boot on the pyhcore imx8mp board up and running, and fail detecting > sd > card on usdhc2 in linux. > > With

Pull request: u-boot-samsung master

2021-02-25 Thread Minkyu Kang
Dear Tom, The following changes since commit 8f7a16aac36c2a38956bd04b53cb7b94b7a70180: Merge tag 'u-boot-amlogic-20210222' of https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic (2021-02-22 12:37:02 -0500) are available in the git repository at:

Re: [PATCH 1/1] efi_loader: fix documentation in efi_loader.h

2021-02-25 Thread AKASHI Takahiro
On Thu, Feb 25, 2021 at 12:03:48PM +0100, Heinrich Schuchardt wrote: > Correct missing descriptions and typos in efi_loader.h. > > Signed-off-by: Heinrich Schuchardt > --- > include/efi_loader.h | 20 +--- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git

Re: [PATCH v2 1/1] drivers: mmc: iproc_sdhci: enable HS200 mode

2021-02-25 Thread Jaehoon Chung
On 2/26/21 3:15 PM, Rayagonda Kokatanur wrote: > From: Bharat Gooty > > Add tuning functionality which is needed for HS200 mode. > For HS200, program the correct needed 1.8 voltage > > Signed-off-by: Bharat Gooty > Signed-off-by: Rayagonda Kokatanur Reviewed-by: Jaehoon Chung Best Regards,

[PATCH v2 1/1] drivers: mmc: iproc_sdhci: enable HS200 mode

2021-02-25 Thread Rayagonda Kokatanur
From: Bharat Gooty Add tuning functionality which is needed for HS200 mode. For HS200, program the correct needed 1.8 voltage Signed-off-by: Bharat Gooty Signed-off-by: Rayagonda Kokatanur --- Changes from v1: --Address review comments from Jaehoon Chung, Add comment for udelay Move

Re: [PATCH 1/6] samsung: goni: change maintainer

2021-02-25 Thread Minkyu Kang
Hi, On Fri, 19 Feb 2021 at 18:02, Minkyu Kang wrote: > change maintainer to Jaehoon > > Signed-off-by: Minkyu Kang > Signed-off-by: Jaehoon Chung > --- > board/samsung/goni/MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/samsung/goni/MAINTAINERS >

Re: [PATCH V2 0/2] power: remove non-DM max8997/8 files

2021-02-25 Thread Minkyu Kang
Hi, On Tue, 23 Feb 2021 at 07:28, Jaehoon Chung wrote: > Remove non-DM files about max8997 and mx8998. > There are already max8997/8 pmic driver to support driver-model. > But it didn't remove them because there was one place to use them. > > Now it's time to rmoeve non-DM max8997/8 files after

Re: [PATCH v2] serial: s5p: Allow independent selection

2021-02-25 Thread Minkyu Kang
Hi, On Sun, 14 Feb 2021 at 19:30, Patrick Wildt wrote: > Am Fri, Feb 12, 2021 at 11:22:18PM +0100 schrieb Mark Kettenis: > > Currently support for the Samsung serial port driver is part > > of CONFIG_S5P which controls selection of several drivers for > > the S5P family. Give it its own config

Re: [PATCH v1 1/1] drivers: mmc: iproc_sdhci: enable HS200 mode

2021-02-25 Thread Rayagonda Kokatanur
On Wed, Feb 10, 2021 at 3:12 AM Jaehoon Chung wrote: > > Hi Rayagonda, > > On 2/9/21 1:34 PM, Rayagonda Kokatanur wrote: > > From: Bharat Gooty > > > > Add tuning functionality which is needed for HS200 mode. > > For HS200, program the correct needed 1.8 voltage > > I didn't test with this on

Re: [PATCH v4 1/5] arm: x86: qemu: move qfw to DM uclass, add Arm support

2021-02-25 Thread Bin Meng
Hi Asherah, On Wed, Feb 24, 2021 at 11:23 AM Asherah Connor wrote: > > Updates the QFW driver to use the driver model, splitting the driver > into qfw_pio and qfw_mmio (for non-x86) in their own uclass. > > Signed-off-by: Asherah Connor > --- > > Changes in v4: > - PIO definitions are now

Re: [PATCH v4 1/5] arm: x86: qemu: move qfw to DM uclass, add Arm support

2021-02-25 Thread Asherah Connor
Hi Bin, On 21/02/26 10:02:p, Bin Meng wrote: > On Fri, Feb 26, 2021 at 10:14 AM Bin Meng wrote: > > This patch mixed two things together. The adding ARM support should > > not belong to this patch. > > So we need to split the patch like this: > > 1. Convert the existing QFW driver of x86 to

Re: [PATCH v4 5/5] qemu: add documentation to qfw.h

2021-02-25 Thread Asherah Connor
On 21/02/25 09:02:p, Heinrich Schuchardt wrote: > > -void qfw_read_entry(struct udevice *dev, u16 entry, u32 length, void > > *address); > > +/** > > + * Read a QEMU firmware config entry > > This will not generate documentation for qfw_read_entry() with Sphinx. > > See >

Re: [PATCH v4 5/5] qemu: add documentation to qfw.h

2021-02-25 Thread Asherah Connor
On 21/02/25 02:02:p, Simon Glass wrote: > On Tue, 23 Feb 2021 at 22:24, Asherah Connor wrote: > > > > Also rename a "length" to "size" for consistency with the rest of qfw. > > Here also you add comments so should mention that. I thought that may be considered redundant with the subject; will

Re: [PATCH] cmd: gpt: Add option to write GPT partitions to environment variable

2021-02-25 Thread Farhan Ali
Hi Heinrich, Thank you for your comments. I will add your recommendations and resubmit, I just want to clarify the use case here: -Right now we have commands to read the GPT table into an internal data structure, and from then on we can only rename or swap partitions -If a user wants to modify

Re: [PATCH v4 1/5] arm: x86: qemu: move qfw to DM uclass, add Arm support

2021-02-25 Thread Bin Meng
Hi Asherah, On Fri, Feb 26, 2021 at 10:14 AM Bin Meng wrote: > > Hi Asherah, > > On Wed, Feb 24, 2021 at 11:23 AM Asherah Connor wrote: > > > > Updates the QFW driver to use the driver model, splitting the driver > > into qfw_pio and qfw_mmio (for non-x86) in their own uclass. > > > >

Re: [PATCH v4 1/5] arm: x86: qemu: move qfw to DM uclass, add Arm support

2021-02-25 Thread Bin Meng
Hi Asherah, On Wed, Feb 24, 2021 at 11:23 AM Asherah Connor wrote: > > Updates the QFW driver to use the driver model, splitting the driver > into qfw_pio and qfw_mmio (for non-x86) in their own uclass. > > Signed-off-by: Asherah Connor > --- > > Changes in v4: > - PIO definitions are now

Re: [PATCH V2] spi: imx: Implement set_speed

2021-02-25 Thread Marek Vasut
On 2/4/21 1:23 AM, Bin Meng wrote: On Thu, Feb 4, 2021 at 12:54 AM Marek Vasut wrote: The set_speed() callback should configure the bus speed, make it so. Signed-off-by: Marek Vasut Cc: Jagan Teki Cc: Stefano Babic --- V2: Rename dev_get_platdata() to dev_get_plat() ---

Re: [PATCH] spi: imx: Implement set_speed

2021-02-25 Thread Marek Vasut
On 2/26/21 2:28 AM, Bin Meng wrote: Hi Marek, Hello Bin, On Fri, Feb 26, 2021 at 8:14 AM Marek Vasut wrote: On 2/26/21 12:41 AM, Bin Meng wrote: Hi Marek, Hello Bin, On Fri, Feb 26, 2021 at 4:52 AM Marek Vasut wrote: The set_speed() callback should configure the bus speed, make it

[GIT PULL] u-boot-riscv/master

2021-02-25 Thread Leo Liang
Hi Tom, Please pull some RISC-V updates. CI result: https://gitlab.denx.de/u-boot/custodians/u-boot-riscv/-/pipelines/6505 The following changes since commit cbe607b920bc0827d8fe379ed4f5ae4e2058513e: Merge tag 'xilinx-for-v2021.04-rc3' of

Re: [PATCH] spi: imx: Implement set_speed

2021-02-25 Thread Bin Meng
Hi Marek, On Fri, Feb 26, 2021 at 8:14 AM Marek Vasut wrote: > > On 2/26/21 12:41 AM, Bin Meng wrote: > > Hi Marek, > > Hello Bin, > > > On Fri, Feb 26, 2021 at 4:52 AM Marek Vasut wrote: > >> > >> The set_speed() callback should configure the bus speed, make it so. > >> > > > > This patch is

Re: [PATCH] spi: imx: Implement set_speed

2021-02-25 Thread Marek Vasut
On 2/26/21 12:41 AM, Bin Meng wrote: Hi Marek, Hello Bin, On Fri, Feb 26, 2021 at 4:52 AM Marek Vasut wrote: The set_speed() callback should configure the bus speed, make it so. This patch is not flagged as v3 since previously there were 2 versions already on the ML. Did you mistakenly

Re: [PATCH] spi: imx: Implement set_speed

2021-02-25 Thread Bin Meng
Hi Marek, On Fri, Feb 26, 2021 at 4:52 AM Marek Vasut wrote: > > The set_speed() callback should configure the bus speed, make it so. > This patch is not flagged as v3 since previously there were 2 versions already on the ML. Did you mistakenly send this? > Signed-off-by: Marek Vasut > Cc:

Re: [PATCH][RESEND] ARM: imx: Add missing FEC ethernet quirk for MX8M

2021-02-25 Thread Marek Vasut
On 2/26/21 12:29 AM, Fabio Estevam wrote: On Thu, Feb 25, 2021 at 8:21 PM Marek Vasut wrote: There is similar fix for the other IMX8Q/X by Oleksandr too. It should be applied as well. Yes, I reviewed that one too. I think Stefano will apply it for the upcoming 2021.04 release. Yes

Re: [PATCH][RESEND] ARM: imx: Add missing FEC ethernet quirk for MX8M

2021-02-25 Thread Fabio Estevam
On Thu, Feb 25, 2021 at 8:21 PM Marek Vasut wrote: > There is similar fix for the other IMX8Q/X by Oleksandr too. It should > be applied as well. Yes, I reviewed that one too. I think Stefano will apply it for the upcoming 2021.04 release. Thanks

Re: [PATCH] rk3399: Add basic support for helios64

2021-02-25 Thread Dennis Gilmore
Thanks for submitting, I have been meaning to do so myself, I have been meaning to go through and try get the dts files in a decent shape. I think that most of what is in arch/arm/dts/rk3399-kobol-helios64-u-boot.dtsi belongs in arch/arm/dts/rk3399-kobol-helios64.dts I also wonder if we shouldn't

Re: [PATCH][RESEND] ARM: imx: Add missing FEC ethernet quirk for MX8M

2021-02-25 Thread Marek Vasut
On 2/25/21 10:22 PM, Fabio Estevam wrote: Hi Marek, On Thu, Feb 25, 2021 at 6:02 PM Marek Vasut wrote: The MX8M also contains a gigabit MAC, so define FEC_QUIRK_ENET_MAC. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic Thanks for the fix: Reviewed-by:

Re: [PATCH][RESEND] ARM: imx: Add missing FEC ethernet quirk for MX8M

2021-02-25 Thread Fabio Estevam
Hi Marek, On Thu, Feb 25, 2021 at 6:02 PM Marek Vasut wrote: > > The MX8M also contains a gigabit MAC, so define FEC_QUIRK_ENET_MAC. > > Signed-off-by: Marek Vasut > Cc: Fabio Estevam > Cc: Peng Fan > Cc: Stefano Babic Thanks for the fix: Reviewed-by: Fabio Estevam

[PATCH] rk3399: Add basic support for helios64

2021-02-25 Thread Uwe Kleine-König
This is a stripped down version of the vendor U-Boot patch by Aditya Prayoga found in the armbian repository. This patch is enough to have the 1G ethernet port, the micro SD card, eMMC and UART operational and let it boot a Debian netboot installer. The device tree is contained in Linux

[PATCH][RESEND] ARM: imx: Add missing FEC ethernet quirk for MX8M

2021-02-25 Thread Marek Vasut
The MX8M also contains a gigabit MAC, so define FEC_QUIRK_ENET_MAC. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic --- arch/arm/include/asm/arch-imx8m/imx-regs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/include/asm/arch-imx8m/imx-regs.h

Re: [PATCH] ARM: imx: Add missing FEC ethernet quirk for MX8M

2021-02-25 Thread Marek Vasut
On 1/17/21 12:16 AM, Marek Vasut wrote: The MX8M also contains a gigabit MAC, so define FEC_QUIRK_ENET_MAC. This patch has been marked as "Changes requested" in patchwork and thus discarded, so FEC remains broken on MX8M. Zero feedback was given, so what changes are requested ?

Re: [PATCH 2/4] pinephone_defconfig: reduce boot delay

2021-02-25 Thread Maxime Ripard
On Thu, Feb 25, 2021 at 05:02:40PM +, André Przywara wrote: > On 20/02/2021 12:14, Nicolas Boulenguez wrote: > > From: Arnaud Ferraris > > > > On a cellular phone, the vast majority of users can be expected to > > have no serial console connected and prefer a short boot. > > It's a bit

[PATCH] ARM: imx: Add OCRAM_S into iMX8M MMU tables

2021-02-25 Thread Marek Vasut
The OCRAM_S is regular memory, just like the OCRAM, add it to the MMU tables so it can be used and cached. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic --- arch/arm/mach-imx/imx8m/soc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH] spi: Update speed/mode on change

2021-02-25 Thread Marek Vasut
The spi_get_bus_and_cs() may be called on the same bus and chipselect with different frequency or mode. This is valid usecase, but the code fails to notify the controller of such a configuration change. Call spi_set_speed_mode() in case bus frequency or bus mode changed to let the controller

[PATCH] spi: imx: Implement set_speed

2021-02-25 Thread Marek Vasut
The set_speed() callback should configure the bus speed, make it so. Signed-off-by: Marek Vasut Cc: Jagan Teki Cc: Stefano Babic --- drivers/spi/mxc_spi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c index

[PATCH] Makefile: Fix generation of flash.bin u-boot.itb with binman

2021-02-25 Thread Marek Vasut
In case binman is enabled, the u-boot.itb is generated using this tool and there is no direct u-boot.itb target, but instead the binman tool must be invoked. Add support for this case. Signed-off-by: Marek Vasut Cc: Peng Fan Cc: Stefano Babic --- Makefile | 6 ++ 1 file changed, 6

Re: [PATCH u-boot-dm + u-boot-spi v3 10/11] mtd: compare also with OF path and device name in get_mtd_device_nm()

2021-02-25 Thread Tom Rini
On Thu, Feb 25, 2021 at 09:35:13PM +0100, Marek Behun wrote: > On Thu, 25 Feb 2021 15:28:56 -0500 > Tom Rini wrote: > > > On Thu, Feb 25, 2021 at 09:07:40PM +0100, Marek Behun wrote: > > > On Thu, 25 Feb 2021 14:31:42 -0500 > > > Simon Glass wrote: > > > > > > > We should not need CONFIG_DM

Re: [PATCH u-boot-dm + u-boot-spi v3 10/11] mtd: compare also with OF path and device name in get_mtd_device_nm()

2021-02-25 Thread Marek Behun
On Thu, 25 Feb 2021 15:28:56 -0500 Tom Rini wrote: > On Thu, Feb 25, 2021 at 09:07:40PM +0100, Marek Behun wrote: > > On Thu, 25 Feb 2021 14:31:42 -0500 > > Simon Glass wrote: > > > > > We should not need CONFIG_DM here...it should be enabled for all > > > boards. You can always disable MTD

Re: [PATCH u-boot-dm + u-boot-spi v3 10/11] mtd: compare also with OF path and device name in get_mtd_device_nm()

2021-02-25 Thread Tom Rini
On Thu, Feb 25, 2021 at 09:07:40PM +0100, Marek Behun wrote: > On Thu, 25 Feb 2021 14:31:42 -0500 > Simon Glass wrote: > > > We should not need CONFIG_DM here...it should be enabled for all > > boards. You can always disable MTD for a board if not, or send a > > removable patch. > > > > If for

Re: [PATCH v4 5/5] qemu: add documentation to qfw.h

2021-02-25 Thread Heinrich Schuchardt
On 2/24/21 4:23 AM, Asherah Connor wrote: Also rename a "length" to "size" for consistency with the rest of qfw. Signed-off-by: Asherah Connor --- (no changes since v1) drivers/misc/qfw.c | 6 ++-- include/qfw.h | 86 +++--- 2 files changed,

Re: [PATCH u-boot-dm + u-boot-spi v3 10/11] mtd: compare also with OF path and device name in get_mtd_device_nm()

2021-02-25 Thread Marek Behun
On Thu, 25 Feb 2021 14:31:42 -0500 Simon Glass wrote: > We should not need CONFIG_DM here...it should be enabled for all > boards. You can always disable MTD for a board if not, or send a > removable patch. > > If for some reason you do, please use if (IS_ENABLED() so that 'dev' > can always be

Re: [PATCH] cmd: gpt: Add option to write GPT partitions to environment variable

2021-02-25 Thread Heinrich Schuchardt
On 2/25/21 7:56 PM, Farhan Ali wrote: This change would enhance the existing 'gpt read' command to allow (optionally) writing of the read GPT partitions to an environment variable. This would allow users to easily change the partition settings and then simply reuse the variable in the 'gpt

[PATCH] configs: stm32mp1: enable uefi related commands

2021-02-25 Thread Ilias Apalodimas
The board can boot with UEFI. With the latest changes in U-Boot's EFI subsystem we also have support for EFI runtime variables, without SetVariable support. We can also store the EFI variables in a file on the ESP partition and preserve them across reboots. The env and efidebug commands are

Re: [PATCH] net: add MMIO Register MDIO MUX driver

2021-02-25 Thread Ramon Fried
On Wed, Feb 24, 2021 at 4:02 PM Neil Armstrong wrote: > > Add support for MMIO register MDIO muxes based on the Linux mdio-mux-mmioreg > driver. > > Signed-off-by: Neil Armstrong > --- > drivers/net/Kconfig| 7 ++ > drivers/net/Makefile | 1 + >

Re: [PATCH v1] net: eth-uclass: Change uclass driver name to ethernet

2021-02-25 Thread Ramon Fried
On Thu, Feb 25, 2021 at 9:33 PM Simon Glass wrote: > > On Thu, 25 Feb 2021 at 10:55, Fabio Estevam wrote: > > > > On Thu, Feb 25, 2021 at 4:58 AM Michael Walle wrote: > > > > > This is how it looks in the linux tree: > > > > > > $ grep "ethernet[0-9].*=.*&" arch/**/*dts{,i}|wc -l > > > 633 > >

Re: [PATCH] net: designware: add DM_MDIO support

2021-02-25 Thread Ramon Fried
On Wed, Feb 24, 2021 at 4:02 PM Neil Armstrong wrote: > > Add support for DM_MDIO to connect to PHY and expose a MDIO device for the > internal MDIO bus in order to dynamically connect to MDIO PHYs with DT > with eventual MDIO muxes in between. > > Signed-off-by: Neil Armstrong > --- >

Re: [PATCH] net: add Amlogic Meson G12A MDIO MUX driver

2021-02-25 Thread Ramon Fried
On Wed, Feb 24, 2021 at 6:31 PM Neil Armstrong wrote: > > The Amlogic G12A & compatible SoCs embeds a mux to either communicate with > the external PHY or the internal 10/100 PHY. > > This adds support for this mux as a MDIO MUX device. > > Signed-off-by: Neil Armstrong > --- >

Re: [PATCH u-boot-dm + u-boot-spi v3 09/11] cmd: mtd: print device OF path in listing

2021-02-25 Thread Simon Glass
Hi Marek, On Thu, 25 Feb 2021 at 09:14, Marek Behún wrote: > > Print MTD's device OF path in the output of `mtd list` command. > > Signed-off-by: Marek Behún > Cc: Jagan Teki > Cc: Priyanka Jain > Cc: Simon Glass > Cc: Heiko Schocher > Cc: Jagan Teki > Cc: Patrick Delaunay > Cc: Patrice

Re: [PATCH v4 4/5] test: qemu: add simple test for cmd_qfw

2021-02-25 Thread Simon Glass
On Tue, 23 Feb 2021 at 22:24, Asherah Connor wrote: > > Signed-off-by: Asherah Connor > --- > > (no changes since v1) > > test/py/tests/test_qfw.py | 21 + > 1 file changed, 21 insertions(+) > create mode 100644 test/py/tests/test_qfw.py Reviewed-by: Simon Glass

Re: [PATCH] net: use the same alias stem for ethernet as linux

2021-02-25 Thread Ramon Fried
On Thu, Feb 25, 2021 at 5:58 PM Fabio Estevam wrote: > > Hi Michael, > > On Thu, Feb 25, 2021 at 12:51 PM Michael Walle wrote: > > > > Linux uses the prefix "ethernet" whereas u-boot uses "eth". This is from > > the linux tree: > > > > $ grep "eth[0-9].*=.*&" arch/**/*dts{,i}|wc -l > > 0 > > $

Re: Broken build on OpenBSD

2021-02-25 Thread Simon Glass
Hi Alex, On Tue, 23 Feb 2021 at 17:23, Alex G. wrote: > > On 2/23/21 3:18 PM, Simon Glass wrote: > > Hi Alex, > > > > On Tue, 23 Feb 2021 at 14:48, Alex G. wrote: > >> > >> On 2/23/21 1:07 PM, Mark Kettenis wrote: > >>> Hi Simon, > >>> > >>> Commit c5819701a3de61e2ba2ef7ad0b616565b32305e5 broke

Re: [PATCH v1] net: eth-uclass: Change uclass driver name to ethernet

2021-02-25 Thread Simon Glass
On Thu, 25 Feb 2021 at 10:55, Fabio Estevam wrote: > > On Thu, Feb 25, 2021 at 4:58 AM Michael Walle wrote: > > > This is how it looks in the linux tree: > > > > $ grep "ethernet[0-9].*=.*&" arch/**/*dts{,i}|wc -l > > 633 > > Yes, 'ethernet' is the recommended node name as per the Devicetree >

Re: [PATCH u-boot-dm + u-boot-spi v3 10/11] mtd: compare also with OF path and device name in get_mtd_device_nm()

2021-02-25 Thread Simon Glass
Hi Marek, On Thu, 25 Feb 2021 at 09:14, Marek Behún wrote: > > The get_mtd_device_nm() function (code imported from Linux) simply > iterates all registered MTD devices and compares the given name with > all MTDs' names. > > With SPI_FLASH_MTD enabled U-Boot registers a SPI-NOR as a MTD device >

Re: [PATCH u-boot-dm + u-boot-spi v3 03/11] dm: core: add ofnode_get_path()

2021-02-25 Thread Simon Glass
On Thu, 25 Feb 2021 at 09:14, Marek Behún wrote: > > Add function for retrieving full node path of a given ofnode. > This uses np->full_name if OF is live, otherwise a call to > fdt_get_path() is made. > > Signed-off-by: Marek Behún > Cc: Simon Glass > --- > drivers/core/ofnode.c | 25

Re: [PATCH 4/6] scmi: define LOG_CATEGORY

2021-02-25 Thread Simon Glass
On Wed, 24 Feb 2021 at 05:20, Patrick Delaunay wrote: > > Define LOG_CATEGORY to allow filtering with log command. > > Signed-off-by: Patrick Delaunay > --- > > drivers/firmware/scmi/mailbox_agent.c| 2 ++ > drivers/firmware/scmi/sandbox-scmi_agent.c | 2 ++ >

Re: [PATCH v4 1/5] arm: x86: qemu: move qfw to DM uclass, add Arm support

2021-02-25 Thread Simon Glass
On Tue, 23 Feb 2021 at 22:24, Asherah Connor wrote: > > Updates the QFW driver to use the driver model, splitting the driver > into qfw_pio and qfw_mmio (for non-x86) in their own uclass. > > Signed-off-by: Asherah Connor > --- > > Changes in v4: > - PIO definitions are now #defines > -

Re: [PATCH v4 5/5] qemu: add documentation to qfw.h

2021-02-25 Thread Simon Glass
Hi Asherah, On Tue, 23 Feb 2021 at 22:24, Asherah Connor wrote: > > Also rename a "length" to "size" for consistency with the rest of qfw. Here also you add comments so should mention that. > > Signed-off-by: Asherah Connor > --- > > (no changes since v1) > > drivers/misc/qfw.c | 6 ++-- >

Re: [PATCH v4 3/5] qemu: add sandbox driver and tests

2021-02-25 Thread Simon Glass
On Tue, 23 Feb 2021 at 22:24, Asherah Connor wrote: > > We minimally exercise the sandbox driver. > > Signed-off-by: Asherah Connor > --- > > (no changes since v1) > > arch/sandbox/dts/sandbox.dtsi | 4 ++ > arch/sandbox/dts/test.dts | 4 ++ > drivers/misc/Makefile | 1 + >

Re: [PATCH v4 2/5] arm: x86: qemu: unify qfw driver functions as qfw_

2021-02-25 Thread Simon Glass
On Tue, 23 Feb 2021 at 22:24, Asherah Connor wrote: > > There's a mixture of "qemu_fwcfg_"-prefixed functions and > "qfw_"-prefixed ones. Now that the qfw name is applied in multiple > places (i.e. the uclass itself, and each of its drivers), let's > consistently use the prefix "qfw_" for

[PATCH] RFC: spl: fit: Use libfdt functions to read stringlist

2021-02-25 Thread Simon Glass
At present the code here reimplements a few libfdt functions and does not always respect the property length. The !str check is unlikely to fire since 1 is added to the string address. If strchr() returns NULL then the code produces (void*)1 instead. Also it might extend beyond the property value

Re: [PATCH 3/4] net: dsa: remove NULL check for priv and platform data

2021-02-25 Thread Ramon Fried
On Thu, Feb 25, 2021 at 12:23 AM Vladimir Oltean wrote: > > On Wed, Feb 24, 2021 at 05:40:41PM +0100, Michael Walle wrote: > > Because the uclass has the "*_auto" properties set, the driver model > > will take care of allocating the private structures for us and they > > can't be NULL. Drop the

Re: [PATCH 2/4] net: dsa: probe master device

2021-02-25 Thread Ramon Fried
On Wed, Feb 24, 2021 at 6:40 PM Michael Walle wrote: > > DSA needs to have the master device probed first for MAC inheritance. > Until now, it only works by chance because the only user (LS1028A SoC) > will probe the master device first. The probe order is given by the PCI > device ordering, thus

Re: [PATCH 1/4] net: dsa: return early if there is no master

2021-02-25 Thread Ramon Fried
On Wed, Feb 24, 2021 at 6:40 PM Michael Walle wrote: > > It doesn't make sense to have DSA without a master port. Error out early > if there is no master port. > > Fixes: fc054d563bfb ("net: Introduce DSA class for Ethernet switches") > Signed-off-by: Michael Walle > Reviewed-by: Vladimir Oltean

[PATCH] cmd: gpt: Add option to write GPT partitions to environment variable

2021-02-25 Thread Farhan Ali
This change would enhance the existing 'gpt read' command to allow (optionally) writing of the read GPT partitions to an environment variable. This would allow users to easily change the partition settings and then simply reuse the variable in the 'gpt write' and 'gpt verify' commands.

Re: DM_MMC, BLK

2021-02-25 Thread Tom Rini
On Thu, Feb 25, 2021 at 06:47:55PM +0100, Heinrich Schuchardt wrote: > On 2/24/21 10:32 PM, Tom Rini wrote: > > On Wed, Feb 24, 2021 at 10:28:31PM +0100, Heinrich Schuchardt wrote: > > > > > Hello Tom, > > > > > > migrating to CONFIG_DM_MMC was scheduled for release v2019.04. But some > > >

Re: [PATCH 52/57] ppc: Remove MPC8569MDS board

2021-02-25 Thread Tom Rini
On Sat, Feb 20, 2021 at 08:06:29PM -0500, Tom Rini wrote: > This board has not been converted to CONFIG_DM_MMC by the deadline. > Remove it. As this is the last ARCH_MPC8569 board, remove that support > as well. > > Cc: Priyanka Jain > Signed-off-by: Tom Rini > Reviewed-by: Priyanka Jain

Re: [PATCH 51/57] ppc: configs: Remove a few non-updated build configurations

2021-02-25 Thread Tom Rini
On Sat, Feb 20, 2021 at 08:06:28PM -0500, Tom Rini wrote: > In the cases of T2080RDB_SECURE_BOOT, T2080RDB_SRIO_PCIE_BOOT, > P2041RDB_SECURE_BOOT, P2041RDB_SRIO_PCIE_BOOT, P3041DS_SRIO_PCIE_BOOT > and P4080DS_SRIO_PCIE_BOOT while some forms of the board have been > migrated more fully to current

Re: [PATCH 40/57] arm: Remove sksimx6 board

2021-02-25 Thread Tom Rini
On Sat, Feb 20, 2021 at 08:06:17PM -0500, Tom Rini wrote: > This board has not been converted to CONFIG_DM_MMC by the deadline. > Remove it. > > Cc: Stefano Babic > Signed-off-by: Tom Rini > Acked-by: Stefano Babic Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH 35/57] arm: Remove mx53smd board

2021-02-25 Thread Tom Rini
On Sat, Feb 20, 2021 at 08:06:12PM -0500, Tom Rini wrote: > This board has not been converted to CONFIG_DM_MMC by the deadline. > Remove it. > > Cc: Fabio Estevam > Signed-off-by: Tom Rini > Reviewed-by: Fabio Estevam Applied to u-boot/master, thanks! -- Tom signature.asc Description:

Re: [PATCH 33/57] arm: Remove mx53ard board

2021-02-25 Thread Tom Rini
On Sat, Feb 20, 2021 at 08:06:10PM -0500, Tom Rini wrote: > This board has not been converted to CONFIG_DM_MMC by the deadline. > Remove it. > > Cc: Fabio Estevam > Signed-off-by: Tom Rini > Reviewed-by: Fabio Estevam Applied to u-boot/master, thanks! -- Tom signature.asc Description:

Re: [PATCH 07/57] arm: Remove mx25pdk board

2021-02-25 Thread Tom Rini
On Sat, Feb 20, 2021 at 08:05:44PM -0500, Tom Rini wrote: > This board has not been converted to CONFIG_DM_MMC by the deadline. > Remove it. > > Cc: Fabio Estevam > Signed-off-by: Tom Rini > Reviewed-by: Fabio Estevam Applied to u-boot/master, thanks! -- Tom signature.asc Description:

Re: DM_MMC, BLK

2021-02-25 Thread Heinrich Schuchardt
On 2/24/21 10:32 PM, Tom Rini wrote: On Wed, Feb 24, 2021 at 10:28:31PM +0100, Heinrich Schuchardt wrote: Hello Tom, migrating to CONFIG_DM_MMC was scheduled for release v2019.04. But some board maintainers simply don't care. We have quite a lot of boards like cm_t335, draco, etamin,

Re: [PATCH 20/20] Enable led on boot to notify user of boot status

2021-02-25 Thread Peter Robinson
On Thu, Feb 25, 2021 at 3:17 PM André Przywara wrote: > > On 20/02/2021 12:14, Nicolas Boulenguez wrote: > > From: Marius Gripsgard > > Hi, > > This is not really Pinephone specific, actually not even sunxi specific. > I see two better ways of solving this: > > - We introduce some generic code

Re: [PATCH] sunxi: support asymmetric dual rank DRAM on A64/R40

2021-02-25 Thread André Przywara
On 20/02/2021 12:14, Nicolas Boulenguez wrote: Hi, > From: Icenowy Zheng > > Previously we have known that R40 has a configuration register for its > rank 1, which allows different configuration than rank 0. Reverse > engineering of newest libdram of A64 from Allwinner shows that A64 has >

Re: [PATCH 2/4] pinephone_defconfig: reduce boot delay

2021-02-25 Thread André Przywara
On 20/02/2021 12:14, Nicolas Boulenguez wrote: > From: Arnaud Ferraris > > On a cellular phone, the vast majority of users can be expected to > have no serial console connected and prefer a short boot. It's a bit tricky to break in with a delay of 0, but indeed most users won't care, so looks

[PATCH] avb: Fix error when partition not found

2021-02-25 Thread schspa
part_get_info_by_name will return -1 on error, and >0 on success. Signed-off-by: schspa Cc: Igor Opaniuk --- common/avb_verify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/avb_verify.c b/common/avb_verify.c index db10d0f21f..0520a71455 100644 ---

[PATCH 2/2] sunxi: enable dual rank memory on R40

2021-02-25 Thread Icenowy Zheng
Previously we do not have proper dual rank memory detection on R40 (because we omitted PIR_QSGATE, which does not work on R40 with our configuration), and dual rank memory is just simply disabled as early R40 boards available (Banana Pi M2 Ultra and Berry) have single rank memory. As a board with

[PATCH 1/2] sunxi: support asymmetric dual rank DRAM on A64/R40

2021-02-25 Thread Icenowy Zheng
Previously we have known that R40 has a configuration register for its rank 1, which allows different configuration than rank 0. Reverse engineering of newest libdram of A64 from Allwinner shows that A64 has this register too. It's bit 0 (which enables dual rank in rank 0 configuration register)

[PATCH 0/2] A64/R40 DRAM controller dual-rank-related changes

2021-02-25 Thread Icenowy Zheng
This patchset contains two patches. The first one enables asymmetric dual rank DRAM on A64. This is needed for 3GiB PinePhone, which has 2GiB rank 0 and 1GiB rank 1. This patch is already used by the firmware flashed to PinePhone by factory. The second one enables dual rank (and asymmetric dual

Re: [PATCH] fdt_support.c: Allow late kernel cmdline modification

2021-02-25 Thread Niko Mauno
On 2/24/21 3:51 PM, Tom Rini wrote: On Tue, Feb 23, 2021 at 08:33:36AM +0200, Niko Mauno wrote: On 2/22/21 10:21 PM, Tom Rini wrote: On Mon, Feb 22, 2021 at 07:18:51PM +, Niko Mauno wrote: By declaring board-specific board_fdt_chosen_bootargs() the kernel command line arguments can be

Re: [PATCH] net: use the same alias stem for ethernet as linux

2021-02-25 Thread Fabio Estevam
Hi Michael, On Thu, Feb 25, 2021 at 12:51 PM Michael Walle wrote: > > Linux uses the prefix "ethernet" whereas u-boot uses "eth". This is from > the linux tree: > > $ grep "eth[0-9].*=.*&" arch/**/*dts{,i}|wc -l > 0 > $ grep "ethernet[0-9].*=.*&" arch/**/*dts{,i}|wc -l > 633 > > In u-boot device

Re: [PATCH u-boot-dm + u-boot-spi v3 00/11] Support SPI NORs and OF partitions in `mtd list`

2021-02-25 Thread Miquel Raynal
Hi Marek, Marek Behún wrote on Thu, 25 Feb 2021 15:13:25 +0100: > Hello, > > this is v3 of patchset that adds support for U-Boot to parse MTD > partitions from device-tree, and also improves support for SPI NOR > access via the `mtd` command. Very nice contribution, I didn't reviewed in

Re: [PATCH v1] net: eth-uclass: Change uclass driver name to ethernet

2021-02-25 Thread Fabio Estevam
On Thu, Feb 25, 2021 at 4:58 AM Michael Walle wrote: > This is how it looks in the linux tree: > > $ grep "ethernet[0-9].*=.*&" arch/**/*dts{,i}|wc -l > 633 Yes, 'ethernet' is the recommended node name as per the Devicetree Specification doc item "2.2.2 Generic Names Recommendation".

Re: [PATCH] board: sl28: add DSA support for variant 2

2021-02-25 Thread Michael Walle
Am 2021-02-16 23:25, schrieb Michael Walle: Now that u-boot gained DSA support, and it is already enabled for the kontron_sl28 board, add the last missing piece and enable the corresponding devices it in the device tree. Signed-off-by: Michael Walle --- Please don't apply this patch. The

Re: [PATCH u-boot-dm + u-boot-spi v3 05/11] mtd: spi-nor: allow registering multiple MTDs when DM is enabled

2021-02-25 Thread Miquel Raynal
Hi Marek, Marek Behún wrote on Thu, 25 Feb 2021 15:13:30 +0100: > Currently when the SPI_FLASH_MTD config option is enabled, only one SPI > can be registered as MTD at any time - it is the last one probed (since > with old non-DM model only one SPI NOR could be probed at any time). > > When DM

[PATCH] net: use the same alias stem for ethernet as linux

2021-02-25 Thread Michael Walle
Linux uses the prefix "ethernet" whereas u-boot uses "eth". This is from the linux tree: $ grep "eth[0-9].*=.*&" arch/**/*dts{,i}|wc -l 0 $ grep "ethernet[0-9].*=.*&" arch/**/*dts{,i}|wc -l 633 In u-boot device trees both prefixes are used. Until recently the only user of the ethernet alias was

Re: [PATCH v1] net: eth-uclass: Change uclass driver name to ethernet

2021-02-25 Thread Tom Rini
On Thu, Feb 25, 2021 at 08:57:37AM +0100, Michael Walle wrote: > Hi Simon, > > Am 2021-02-25 03:31, schrieb Simon Glass: > > On Wed, 24 Feb 2021 at 17:51, Michael Walle wrote: > > > Am 2021-02-24 22:34, schrieb Vladimir Oltean: > > > > On Wed, Feb 24, 2021 at 08:26:14PM +0100, Michael Walle

Re: [PATCH] usb: dfu: Migrate CONFIG_SYS_DFU_DATA_BUF_SIZE and CONFIG_SYS_DFU_MAX_FILE_SIZE to Kconfig

2021-02-25 Thread Aswath Govindraju
Hi Oleksandr, Thank you for pointing these errors out. I used the tools/moveconfig.py script and I think this is error in the script while moving the configs. As you suggested, I will check all direct settings of CONFIG_SYS_DFU_MAX_FILE_SIZE and remove if it was not set previously. Thanks,

Re: [PATCH] tools: Remove #include

2021-02-25 Thread Tom Rini
On Thu, Feb 25, 2021 at 02:05:54AM +0100, Pali Rohár wrote: > On Wednesday 03 February 2021 12:10:13 Pali Rohár wrote: > > On Monday 01 February 2021 16:20:18 Tom Rini wrote: > > > On Wed, Jan 27, 2021 at 04:34:24PM +0100, Pali Rohár wrote: > > > > > > > Header file version.h includes also

Re: make O=directory parameter

2021-02-25 Thread Tom Rini
On Thu, Feb 25, 2021 at 12:50:47PM +1100, Fred 1 wrote: > like in the linux kernel build > > make O=builds/arm > > builds the result to the specified output directory > > > is this supposed to work for uboot also ? > > doesn't seem to work for me, i've fetched older tar files and same

Re: [PATCH] sunxi-common: support loading compressed kernel images on ARMv8

2021-02-25 Thread André Przywara
On 20/02/2021 12:14, Nicolas Boulenguez wrote: Hi, > From: Arnaud Ferraris This looks OK on the first glance, but is missing a commit message and a Signed-off-by: Cheers, Andre > > --- > include/configs/sunxi-common.h | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git

  1   2   3   >