Re: [PATCH v3 15/29] acpi: Add a simple sandbox test

2020-04-03 Thread Andy Shevchenko
PI, > + acpi_ops_ptr(_ops) I have noticed that this is not obvious why no comma here. Perhaps, since apci_ops_ptr is a macro, you should upper case it. > +}; -- With Best Regards, Andy Shevchenko

Re: [PATCH v3 14/29] acpi: Add a binding for ACPI settings in the device tree

2020-04-03 Thread Andy Shevchenko
IRQ_TYPE_EDGE_FALLING>; Can we have this on one line? > + acpi,probed; > +}; -- With Best Regards, Andy Shevchenko

Re: [PATCH v3 12/29] dm: core: Add basic ACPI support

2020-04-03 Thread Andy Shevchenko
+ strncpy(out_name, name, ACPI_NAME_MAX); memcpy()? > + out_name[ACPI_NAME_LEN] = '\0'; I dunno if compiler is clever enough to catch this and avoid any warnings. Also it seems above should also have _LEN, and not _MAX. > + return 0; > +} -- With Best Regards, Andy Shevchenko

Re: Antwort: [PATCH v3 11/29] x86: apl: Add Global NVS table header

2020-04-03 Thread Andy Shevchenko
s (small one) is what being used by U-Boot. I don't remember what ACPI spec dictates about this (i.o.w. if it depends to the ACPI version in use). > >+}; -- With Best Regards, Andy Shevchenko

Re: [PATCH v3 10/29] pci: Adjust dm_pci_read_bar32() to return errors correctly

2020-04-03 Thread Andy Shevchenko
return addr; > + else if (addr & PCI_BASE_ADDRESS_SPACE_IO) > return addr & PCI_BASE_ADDRESS_IO_MASK; > else > return addr & PCI_BASE_ADDRESS_MEM_MASK; > -- > 2.26.0.rc2.310.g2932bb562d-goog > -- With Best Regards, Andy Shevchenko

Re: [PATCH] serial: ns16550: Fix ordering of getting base address

2020-04-03 Thread Andy Shevchenko
On Fri, Apr 03, 2020 at 06:16:51PM +0800, Bin Meng wrote: > On Fri, Apr 3, 2020 at 6:05 PM Andy Shevchenko > wrote: > > On Fri, Apr 03, 2020 at 02:58:08AM -0700, Bin Meng wrote: ... > > > Fixes: 720f9e1fdb0c9 ("serial: ns16550: Move PCI access from > >

Re: [PATCH v3] serial: ns16550: Revert "Move PCI access from ofdata_to_platdata() to probe()"

2020-04-03 Thread Andy Shevchenko
On Fri, Apr 3, 2020 at 1:08 PM Bin Meng wrote: > On Fri, Apr 3, 2020 at 5:02 PM Wolfgang Wallner > wrote: > We can't revert as that will put PCI based ns16550 in a broken state again. > > I've sent a patch to fix it. Please have a try. Just did, thank you! -- With Bes

Re: [PATCH] serial: ns16550: Fix ordering of getting base address

2020-04-03 Thread Andy Shevchenko
al_probe(). > > This is still not perfect. Ideally if any PCI bus based ns16550 > wrapper driver tries to access plat->base before calling probe(), > it is subject to break. Thank you. I have tested it and it fixes my case. Tested-by: Andy Shevchenko > Fixes: 720f9

Re: [PATCH v3] serial: ns16550: Revert "Move PCI access from ofdata_to_platdata() to probe()"

2020-04-03 Thread Andy Shevchenko
On Fri, Apr 3, 2020 at 11:40 AM Andy Shevchenko wrote: > > The commit 720f9e1fdb0c ("Move PCI access from ofdata_to_platdata() to > probe()") while doing formally a right thing, actually brings a regression > to the drivers that would like to pre-initialize h

Re: Re: [PATCH v2 1/2] serial: ns16550: Revert "Move PCI access from ofdata_to_platdata() to probe()"

2020-04-03 Thread Andy Shevchenko
On Fri, Apr 3, 2020 at 11:35 AM Bin Meng wrote: > On Fri, Apr 3, 2020 at 4:26 PM Wolfgang Wallner > wrote: > > > -"Andy Shevchenko" schrieb: - > > > On Thu, Apr 2, 2020 at 7:55 AM Bin Meng wrote: ... > > > I think I understand what ha

[PATCH v3] serial: ns16550: Revert "Move PCI access from ofdata_to_platdata() to probe()"

2020-04-03 Thread Andy Shevchenko
: Wolfgang Wallner Signed-off-by: Andy Shevchenko --- v3: drop wrong patch, better explanation in the commit message drivers/serial/ns16550.c | 40 1 file changed, 12 insertions(+), 28 deletions(-) diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns165

Re: [PATCH v2 1/2] serial: ns16550: Revert "Move PCI access from ofdata_to_platdata() to probe()"

2020-04-03 Thread Andy Shevchenko
r 02, 2020 at 12:55:14PM +0800, Bin Meng wrote: > > > > > > > On Thu, Apr 2, 2020 at 1:55 AM Simon Glass > > wrote: > > > > > > > > On Wed, 1 Apr 2020 at 11:39, Andy Shevchenko > > > > > > > > > > > > > > &

Re: [PATCH v2 1/2] serial: ns16550: Revert "Move PCI access from ofdata_to_platdata() to probe()"

2020-04-03 Thread Andy Shevchenko
summarize what should have been done in order to fix this? > 1) Fix in the driver (broken by this commit: 82de42fa1468) by moving some > code from ofdata_to_platdata() to probe(). > 2) Fix the DM core. > Simon and Marek were discussing about these 2 options. > Perhaps Simon can help shed some light here. I have a question. Does revert of 720f9e1fdb0c92d3fd16e1bfc25bcbd35612675c makes any difference to SoCFPGA? -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 1/2] serial: ns16550: Revert "Move PCI access from ofdata_to_platdata() to probe()"

2020-04-03 Thread Andy Shevchenko
+Cc: Chee Hong On Thu, Apr 2, 2020 at 10:09 PM Andy Shevchenko wrote: > > On Thu, Apr 2, 2020 at 7:55 AM Bin Meng wrote: > > On Thu, Apr 2, 2020 at 1:55 AM Simon Glass wrote: > > > On Wed, 1 Apr 2020 at 11:39, Andy Shevchenko > > > wrote: > > > >

Re: [PATCH v2 1/2] serial: ns16550: Revert "Move PCI access from ofdata_to_platdata() to probe()"

2020-04-02 Thread Andy Shevchenko
On Thu, Apr 2, 2020 at 7:55 AM Bin Meng wrote: > On Thu, Apr 2, 2020 at 1:55 AM Simon Glass wrote: > > On Wed, 1 Apr 2020 at 11:39, Andy Shevchenko > > wrote: > > > On Wed, Apr 01, 2020 at 10:56:26AM -0600, Simon Glass wrote: > > > > On Wed, 1 Apr 2020 at 08

Re: [PATCH v2 1/2] serial: ns16550: Revert "Move PCI access from ofdata_to_platdata() to probe()"

2020-04-02 Thread Andy Shevchenko
On Thu, Apr 2, 2020 at 7:28 PM Ang, Chee Hong wrote: > > On Thu, Apr 02, 2020 at 12:55:14PM +0800, Bin Meng wrote: > > > On Thu, Apr 2, 2020 at 1:55 AM Simon Glass wrote: > > > > On Wed, 1 Apr 2020 at 11:39, Andy Shevchenko > > wrote: > > > > >

Re: [PATCH v2 1/2] serial: ns16550: Revert "Move PCI access from ofdata_to_platdata() to probe()"

2020-04-01 Thread Andy Shevchenko
On Wed, Apr 01, 2020 at 10:56:26AM -0600, Simon Glass wrote: > Hi Andy, > > On Wed, 1 Apr 2020 at 08:45, Andy Shevchenko > wrote: > > > > On Wed, Apr 1, 2020 at 5:32 PM Bin Meng wrote: > > > On Wed, Apr 1, 2020 at 9:58 PM Andy Shevchenko > > > wrote

Re: [PATCH v2 1/2] serial: ns16550: Revert "Move PCI access from ofdata_to_platdata() to probe()"

2020-04-01 Thread Andy Shevchenko
On Wed, Apr 1, 2020 at 5:32 PM Bin Meng wrote: > On Wed, Apr 1, 2020 at 9:58 PM Andy Shevchenko > wrote: > > > > The commit breaks serial console on the Intel Edison. > > > > This reverts commit 720f9e1fdb0c92d3fd16e1bfc25bcbd35612675c. > >

[PATCH v2 2/2] dm: core: Partial revert of "Allocate parent data separate from probing parent"

2020-04-01 Thread Andy Shevchenko
This reverts commit 82de42fa1468 ("dm: core: Allocate parent data separate from probing parent") as a being a culprit for Apollo Lake breakage. Suggested-by: Wolfgang Wallner Signed-off-by: Andy Shevchenko --- drivers/core/device.c | 8 1 file changed, 4 insertions(+), 4

[PATCH v2 1/2] serial: ns16550: Revert "Move PCI access from ofdata_to_platdata() to probe()"

2020-04-01 Thread Andy Shevchenko
The commit breaks serial console on the Intel Edison. This reverts commit 720f9e1fdb0c92d3fd16e1bfc25bcbd35612675c. Signed-off-by: Andy Shevchenko --- drivers/serial/ns16550.c | 40 1 file changed, 12 insertions(+), 28 deletions(-) diff --git a/drivers

Re: Re: [ANN] U-Boot v2020.04-rc4 released

2020-04-01 Thread Andy Shevchenko
On Wed, Apr 1, 2020 at 3:45 PM Wolfgang Wallner wrote: > > On Wed, Apr 1, 2020 at 2:54 PM Andy Shevchenko > > wrote: > > > > > > On Tue, Mar 31, 2020 at 2:31 AM Tom Rini wrote: > > > > > > > > Hey all, > > > > > > >

Re: Re: [ANN] U-Boot v2020.04-rc4 released

2020-04-01 Thread Andy Shevchenko
On Wed, Apr 1, 2020 at 3:45 PM Wolfgang Wallner wrote: > > On Wed, Apr 1, 2020 at 2:54 PM Andy Shevchenko > > wrote: > > > On Tue, Mar 31, 2020 at 2:31 AM Tom Rini wrote: ... > > > It becomes a tradition. Intel Edison is broken again (now serial drive

[PATCH v1] serial: ns16550: Revert "Move PCI access from ofdata_to_platdata() to probe()"

2020-04-01 Thread Andy Shevchenko
The commit breaks serial console on the Intel Edison. This reverts commit 720f9e1fdb0c92d3fd16e1bfc25bcbd35612675c. Signed-off-by: Andy Shevchenko --- drivers/serial/ns16550.c | 40 1 file changed, 12 insertions(+), 28 deletions(-) diff --git a/drivers

[PATCH v1] serial: ns16550: Revert "Move PCI access from ofdata_to_platdata() to probe()"

2020-04-01 Thread Andy Shevchenko
The commit breaks serial console on the Intel Edison. This reverts commit 720f9e1fdb0c92d3fd16e1bfc25bcbd35612675c. Signed-off-by: Andy Shevchenko --- drivers/serial/ns16550.c | 40 1 file changed, 12 insertions(+), 28 deletions(-) diff --git a/drivers

Re: [ANN] U-Boot v2020.04-rc4 released

2020-04-01 Thread Andy Shevchenko
On Wed, Apr 1, 2020 at 2:54 PM Andy Shevchenko wrote: > > On Tue, Mar 31, 2020 at 2:31 AM Tom Rini wrote: > > > > Hey all, > > > > So, I've gotten out of the habit of tagging rcs on cycle. This month I > > have been taking in changes sparingly and I'm not

Re: [ANN] U-Boot v2020.04-rc4 released

2020-04-01 Thread Andy Shevchenko
9e1fdb0c92d3fd16e1bfc25bcbd35612675c. -- With Best Regards, Andy Shevchenko

Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-03-29 Thread Andy Shevchenko
On Sun, Mar 29, 2020 at 5:13 AM Simon Glass wrote: > On Thu, 5 Mar 2020 at 05:17, Andy Shevchenko > wrote: > > On Tue, Mar 03, 2020 at 07:47:56PM -0700, Simon Glass wrote: > > > On Tue, 3 Mar 2020 at 02:23, Andy Shevchenko > > > wrote: > > > > On Tue,

[PATCH v2] x86: acpi: Describe USB 3 host controller found on Intel Tangier

2020-03-26 Thread Andy Shevchenko
USB 3 host controller may be described in ACPI to allow users alter the properties or other features. Describe it for Intel Tangier SoC. Signed-off-by: Andy Shevchenko Reviewed-by: Bin Meng --- v2: pick up tag, fix comment style (Bin) .../asm/arch-tangier/acpi/southcluster.asl| 47

[PATCH v1] x86: acpi: Describe USB 3 host controller found on Intel Tangier

2020-03-25 Thread Andy Shevchenko
USB 3 host controller may be described in ACPI to allow users alter the properties or other features. Describe it for Intel Tangier SoC. Signed-off-by: Andy Shevchenko --- .../asm/arch-tangier/acpi/southcluster.asl| 38 +++ 1 file changed, 38 insertions(+) diff --git a/arch

Re: [PATCH v1] x86: acpi: Add I²C timings to Intel Merrifield platform

2020-03-25 Thread Andy Shevchenko
On Wed, Mar 25, 2020 at 9:15 AM Bin Meng wrote: > > On Sat, Mar 21, 2020 at 1:46 AM Andy Shevchenko > wrote: > > > > There is established way to provide I²C timings, or actually counters, > > to the OS via ACPI. Fill them for Intel Merrifield platform. > > &

[PATCH v2] x86: acpi: Add I²C timings to Intel Merrifield platform

2020-03-20 Thread Andy Shevchenko
There is established way to provide I²C timings, or actually counters, to the OS via ACPI. Fill them for Intel Merrifield platform. Signed-off-by: Andy Shevchenko --- v2: added high speed mode counters .../asm/arch-tangier/acpi/southcluster.asl| 30 +++ 1 file changed, 30

[PATCH v1] x86: acpi: Add I²C timings to Intel Merrifield platform

2020-03-20 Thread Andy Shevchenko
There is established way to provide I²C timings, or actually counters, to the OS via ACPI. Fill them for Intel Merrifield platform. Signed-off-by: Andy Shevchenko --- .../asm/arch-tangier/acpi/southcluster.asl| 20 +++ 1 file changed, 20 insertions(+) diff --git a/arch/x86

Re: [PATCH v3 0/7] x86: Improve support for chain-loading U-Boot

2020-03-12 Thread Andy Shevchenko
On Wed, Mar 11, 2020 at 09:22:49PM -0600, Simon Glass wrote: > On Wed, 11 Mar 2020 at 07:04, Andy Shevchenko < > andriy.shevche...@linux.intel.com> wrote: > > On Wed, Mar 11, 2020 at 06:24:07AM -0600, Simon Glass wrote: > > > On Wed, 11 Mar 2020 at 06:09, A

Re: [PATCH v3 0/7] x86: Improve support for chain-loading U-Boot

2020-03-11 Thread Andy Shevchenko
On Wed, Mar 11, 2020 at 4:54 PM Igor Opaniuk wrote: > On Wed, Mar 11, 2020 at 3:04 PM Andy Shevchenko > wrote: > > On Wed, Mar 11, 2020 at 06:24:07AM -0600, Simon Glass wrote: > > > On Wed, 11 Mar 2020 at 06:09, Andy Shevchenko > > > wrote: > > > >

Re: [PATCH v2 09/39] x86: apl: Move p2sb ofdata reading to the correct method

2020-03-11 Thread Andy Shevchenko
On Wed, Mar 11, 2020 at 06:17:32AM -0600, Simon Glass wrote: > On Tue, 10 Mar 2020 at 08:39, Andy Shevchenko > wrote: > > On Sun, Mar 08, 2020 at 09:44:33PM -0600, Simon Glass wrote: > > > if (plat->bdf < 0) > > > ret

Re: [PATCH v3 0/7] x86: Improve support for chain-loading U-Boot

2020-03-11 Thread Andy Shevchenko
On Wed, Mar 11, 2020 at 06:24:07AM -0600, Simon Glass wrote: > On Wed, 11 Mar 2020 at 06:09, Andy Shevchenko > wrote: > > On Tue, Mar 10, 2020 at 08:28:29PM -0600, Simon Glass wrote: > > > On Tue, 10 Mar 2020 at 08:51, Andy Shevchenko > > > wrote: > > > >

Re: [PATCH v3 0/7] x86: Improve support for chain-loading U-Boot

2020-03-11 Thread Andy Shevchenko
On Tue, Mar 10, 2020 at 08:28:29PM -0600, Simon Glass wrote: > On Tue, 10 Mar 2020 at 08:51, Andy Shevchenko > wrote: > > > > On Sat, Mar 07, 2020 at 04:22:13PM -0700, Simon Glass wrote: > > > This little series adds a few checks into the code to allow better > >

Re: [PATCH] versal: watchdog: Add support for Xilinx window watchdog

2020-03-11 Thread Andy Shevchenko
macros but I have asked Ashok to change it to > structure based. I don't know how many wasted kbytes Xilinx can afford, but in general it's a bad example to waste memory as above. Any issues with regmap approach? -- With Best Regards, Andy Shevchenko

Re: [PATCH] versal: watchdog: Add support for Xilinx window watchdog

2020-03-11 Thread Andy Shevchenko
K, >regs->refresh); > + > + return 0; And taking above into consideration, I don't see any value of this helper. writel() can be used in-place. > +} -- With Best Regards, Andy Shevchenko

Re: [PATCH v3 0/7] x86: Improve support for chain-loading U-Boot

2020-03-10 Thread Andy Shevchenko
gt; > This series makes the most important changes to allow the same u-boot.bin > for coral to boot after coreboot (by itself) or bare metal (via TPL->SPL). I see only this and one patch out of 7 (seven?). Please, (re)send it correctly. -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 13/39] acpi: Add a binding for ACPI settings in the device tree

2020-03-10 Thread Andy Shevchenko
+ acpi,desc = "Synaptics Touchpad"; > + interrupts-extended = <_gpe GPIO_18_IRQ > + IRQ_TYPE_EDGE_FALLING>; > + acpi,probed; > + hid-descr-addr = <0x20>; > +}; -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 12/39] dm: core: Add basic ACPI support

2020-03-10 Thread Andy Shevchenko
*/ > +#define ACPI_NAME_LEN4 > + > +/* Length of an ACPI name string including nul terminator */ > +#define ACPI_NAME_MAX5 Do we really need two definitions? ... > + /* Intel Advanced Configuration and Power Interface (ACPI) */ Same as above for commit message. -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 09/39] x86: apl: Move p2sb ofdata reading to the correct method

2020-03-10 Thread Andy Shevchenko
return p2sb_early_init(dev); > + else if (spl_phase() == PHASE_SPL) Redundant 'else', but I think we already discussed that and you prefer this way. However, I think this is waste of compilation time. In any case, matter of taste. > + return p2sb_spl_init(dev); -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 08/39] x86: Correct wording of coreboot source code

2020-03-09 Thread Andy Shevchenko
- * This file is part of the coreboot project. > - * > * Copyright (C) 2015-2016 Intel Corp. > * Copyright 2019 Google LLC > * > -- > 2.25.1.481.gfbce0eb801-goog > -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 07/39] dm: pci: Allow disabling auto-config for a device

2020-03-09 Thread Andy Shevchenko
ers/pci/pci-uclass.c > @@ -536,6 +536,8 @@ int pci_auto_config_devices(struct udevice *bus) > int ret; > > debug("%s: device %s\n", __func__, dev->name); > + if (dev_read_bool(dev, "pci,no-autoconfig")) > + continue; > ret = dm_pciauto_config_device(dev); > if (ret < 0) > return ret; > -- > 2.25.1.481.gfbce0eb801-goog > -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 02/39] spi: Add SPI mode enums

2020-03-09 Thread Andy Shevchenko
tate > + * @SPI_POLARITY_HIGH: Clock is high in idle state > + */ > +enum spi_polarity { > + SPI_POLARITY_LOW, > + SPI_POLARITY_HIGH > +}; > + > /** > * struct spi_slave - Representation of a SPI slave > * > -- > 2.25.1.481.gfbce0eb801-goog > -- With Best Regards, Andy Shevchenko

Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-03-05 Thread Andy Shevchenko
On Tue, Mar 03, 2020 at 07:47:56PM -0700, Simon Glass wrote: > On Tue, 3 Mar 2020 at 02:23, Andy Shevchenko > wrote: > > On Tue, Mar 3, 2020 at 1:36 AM Simon Glass wrote: > > > On Mon, 2 Mar 2020 at 13:47, Andy Shevchenko > > > wrote: > > > > On Mon,

Re: Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-03-03 Thread Andy Shevchenko
set). Yes, that's what I'm implying above as well. I'm on the same page with you! -- With Best Regards, Andy Shevchenko

Re: [PATCH v2] lib: Improve _parse_integer_fixup_radix base 16 detection

2020-03-03 Thread Andy Shevchenko
On Tue, Mar 3, 2020 at 2:03 PM Michal Simek wrote: > On 03. 03. 20 10:37, Andy Shevchenko wrote: > > On Mon, Mar 2, 2020 at 10:36 AM Michal Simek > > wrote: > >> Base autodetection is failing for this case: > >> if test 257 -gt 3ae; then echo first; else echo s

Re: [PATCH v2] lib: Improve _parse_integer_fixup_radix base 16 detection

2020-03-03 Thread Andy Shevchenko
+ } > + } int i = 0; char var; do { var = tolower(s[i++]); if (...) { *base = 16; break; } } while (var); or alike? ... > } > + Is this relevant? > if (*base == 16 && s[0] == '0' && tolower(s[1]) == 'x') > s += 2; > return s; -- With Best Regards, Andy Shevchenko

Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-03-03 Thread Andy Shevchenko
On Tue, Mar 3, 2020 at 1:36 AM Simon Glass wrote: > On Mon, 2 Mar 2020 at 13:47, Andy Shevchenko > wrote: > > On Mon, Mar 2, 2020 at 9:47 PM Simon Glass wrote: > > > On Fri, 28 Feb 2020 at 01:47, Andy Shevchenko > > > wrote: > > > > On Fri,

Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-03-02 Thread Andy Shevchenko
On Mon, Mar 2, 2020 at 9:47 PM Simon Glass wrote: > On Fri, 28 Feb 2020 at 01:47, Andy Shevchenko > wrote: > > On Fri, Feb 28, 2020 at 1:41 AM Simon Glass wrote: > > > On Thu, 27 Feb 2020 at 06:00, Andy Shevchenko > > > wrote: > > > >

Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-02-28 Thread Andy Shevchenko
On Fri, Feb 28, 2020 at 1:41 AM Simon Glass wrote: > On Thu, 27 Feb 2020 at 06:00, Andy Shevchenko > wrote: > Could you take a look at the ACPI series? > > It was sent out about a month ago and has a refactor to this function. > > u-boot-dm/coral-working There are

[PATCH v1 3/3] x86: acpi: Let OS know that console already had been initialized

2020-02-27 Thread Andy Shevchenko
("ACPI: SPCR: Consider baud rate 0 as preconfigured state") for the details. Signed-off-by: Andy Shevchenko --- arch/x86/lib/acpi_table.c | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/x86/lib/acpi_table.c b/arch/x86/lib/acpi_table.c index 66e32f21bd..074987e

[PATCH v1 1/3] dm: serial: Add clock member to struct serial_device_info

2020-02-27 Thread Andy Shevchenko
Some callers of serial_getinfo() would like to know the UART base clock speed in order to make decision what to pass to OS in some cases. In particular, ACPI SPCR table expects only certain base clock speed and thus we have to act accordingly. Signed-off-by: Andy Shevchenko --- drivers/serial

[PATCH v1 2/3] serial: ns16550: Provide UART base clock speed in ->getinfo()

2020-02-27 Thread Andy Shevchenko
Some callers may need the UART base clock speed value. Provide it in the ->getinfo() callback. Signed-off-by: Andy Shevchenko --- drivers/serial/ns16550.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c index 1fcbc35015..386b5e04c8 100

[PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-02-27 Thread Andy Shevchenko
There is no need to have an assignment to NULL for XSDT pointer. Therefore, no need to assign it when rsdt_address is not set. Because of above changes we may decrease indentation level as well. While here, drop unnecessary parentheses. Signed-off-by: Andy Shevchenko --- arch/x86/lib

Re: [ANN] U-Boot v2020.04-rc3 released

2020-02-26 Thread Andy Shevchenko
On Wed, Feb 26, 2020 at 5:27 PM Bin Meng wrote: > On Wed, Feb 26, 2020 at 11:01 PM Andy Shevchenko > wrote: > > On Wed, Feb 26, 2020 at 2:59 PM Tom Rini wrote: ... > > Still Edison doesn't boot (IIRC I saw Bin's PR which by some reason > > has not been pulled). >

Re: [ANN] U-Boot v2020.04-rc3 released

2020-02-26 Thread Andy Shevchenko
On Wed, Feb 26, 2020 at 5:57 PM Lukasz Majewski wrote: > > On Wed, Feb 26, 2020 at 05:01:29PM +0200, Andy Shevchenko wrote: > > > On Wed, Feb 26, 2020 at 2:59 PM Tom Rini > > > wrote: ... > > > Still Edison doesn't boot (IIRC I saw Bin's PR which by some

Re: [ANN] U-Boot v2020.04-rc3 released

2020-02-26 Thread Andy Shevchenko
ranch on March 2nd. Thanks all! > > -- > Tom -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 0/4] x86: Improve support for chain-loading U-Boot

2020-02-19 Thread Andy Shevchenko
+- > arch/x86/lib/init_helpers.c | 3 +++ > drivers/pci/pci-uclass.c| 4 ++-- > 9 files changed, 36 insertions(+), 6 deletions(-) > > -- > 2.25.0.265.gbab2e86ba0-goog > -- With Best Regards, Andy Shevchenko

Re: use invd instead of wbinvd in real mode start code

2020-02-18 Thread Andy Shevchenko
On Tue, Feb 18, 2020 at 4:43 PM Tom Rini wrote: > On Tue, Feb 18, 2020 at 01:29:04PM +0200, Andy Shevchenko wrote: > > On Tue, Feb 18, 2020 at 1:06 PM Heiko Schocher wrote: > > > Am 18.02.2020 um 11:45 schrieb Andy Shevchenko: > > > > On Tue, Feb 18, 2020 at

Re: use invd instead of wbinvd in real mode start code

2020-02-18 Thread Andy Shevchenko
On Tue, Feb 18, 2020 at 1:06 PM Heiko Schocher wrote: > Am 18.02.2020 um 11:45 schrieb Andy Shevchenko: > > On Tue, Feb 18, 2020 at 7:48 AM Heiko Schocher wrote: ... > > How the feed back line is organized? I mean how host system will know that > > a) we done fla

Re: use invd instead of wbinvd in real mode start code

2020-02-18 Thread Andy Shevchenko
atever CI you use... > > If you want to get help setting up tbot, feel free to ask me or Harald > directly or on the tbot mailinglist: How the feed back line is organized? I mean how host system will know that a) we done flash correctly? b) the booted image is bad or good? -- With Best Regards, Andy Shevchenko

Re: [PATCH v1] Revert "x86: use invd instead of wbinvd in real mode start code"

2020-02-18 Thread Andy Shevchenko
On Tue, Feb 18, 2020 at 08:24:03AM +0800, Bin Meng wrote: > On Mon, Feb 17, 2020 at 11:30 PM Andy Shevchenko > wrote: > > > > This reverts commit 0d67fac29f3187e67f4fd3ef15f73e91be2fad12. > > > > As real hardware testing (*) shows the above mentioned commit &

Re: [PATCH v1] Revert "x86: use invd instead of wbinvd in real mode start code"

2020-02-18 Thread Andy Shevchenko
On Tue, Feb 18, 2020 at 09:45:34AM +0900, Masahiro Yamada wrote: > On Tue, Feb 18, 2020 at 12:30 AM Andy Shevchenko > wrote: > > > > This reverts commit 0d67fac29f3187e67f4fd3ef15f73e91be2fad12. > > > > As real hardware testing (*) shows the above mentioned commit &

Re: use invd instead of wbinvd in real mode start code

2020-02-17 Thread Andy Shevchenko
On Mon, Feb 17, 2020 at 5:32 PM Andy Shevchenko wrote: > On Mon, Feb 17, 2020 at 5:09 PM Wolfgang Denk wrote: > > In message > > you > > wrote: > > > > > > > > git bisect is the usual way to figure out the culprit. > > > > > >

Re: use invd instead of wbinvd in real mode start code

2020-02-17 Thread Andy Shevchenko
bly still do it > manually. Why don't you use tbot to automize such boring and time > consuming tasks? Bisection time something about 10%, while 90% is flashing the board and, given the result, triggering either bad or good next cycle. -- With Best Regards, Andy Shevchenko

Re: use invd instead of wbinvd in real mode start code

2020-02-17 Thread Andy Shevchenko
On Mon, Feb 17, 2020 at 4:49 PM Bin Meng wrote: > On Mon, Feb 17, 2020 at 10:00 PM Andy Shevchenko > wrote: ... > > > Is that because on Intel Edison U-Boot is not the first stage bootloader? > > > > I don't know for sure, but I may speculate that this is a prereq

[PATCH v1] Revert "x86: use invd instead of wbinvd in real mode start code"

2020-02-17 Thread Andy Shevchenko
-by: Andy Shevchenko --- arch/x86/cpu/start.S | 2 +- arch/x86/cpu/start16.S | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/cpu/start.S b/arch/x86/cpu/start.S index 26cf995db2..01524635e9 100644 --- a/arch/x86/cpu/start.S +++ b/arch/x86/cpu/start.S @@ -50,7 +50,7

Re: use invd instead of wbinvd in real mode start code

2020-02-17 Thread Andy Shevchenko
On Mon, Feb 17, 2020 at 3:52 PM Bin Meng wrote: > On Mon, Feb 17, 2020 at 9:47 PM Andy Shevchenko > wrote: > > On Mon, Feb 17, 2020 at 3:39 PM Andy Shevchenko > > wrote: > > > On Mon, Feb 17, 2020 at 2:41 PM Masahiro Yamada > > > wrote: > > > >

Re: use invd instead of wbinvd in real mode start code

2020-02-17 Thread Andy Shevchenko
(Cc'ing mailing list and Tom again, thus keep entire previous answer) On Mon, Feb 17, 2020 at 3:39 PM Andy Shevchenko wrote: > On Mon, Feb 17, 2020 at 2:41 PM Masahiro Yamada wrote: > > On Mon, Feb 17, 2020 at 9:31 PM Andy Shevchenko > > wrote: > > > > It seems Mas

Re: use invd instead of wbinvd in real mode start code

2020-02-17 Thread Andy Shevchenko
On Mon, Feb 17, 2020 at 2:31 PM Andy Shevchenko wrote: > > -- Forwarded message - > From: Andy Shevchenko > Date: Mon, Feb 17, 2020 at 2:31 PM > Subject: use invd instead of wbinvd in real mode start code > To: Masahiro Yamada , Simon Glass > , Bin Meng &

Fwd: use invd instead of wbinvd in real mode start code

2020-02-17 Thread Andy Shevchenko
-- Forwarded message - From: Andy Shevchenko Date: Mon, Feb 17, 2020 at 2:31 PM Subject: use invd instead of wbinvd in real mode start code To: Masahiro Yamada , Simon Glass , Bin Meng Hi! It seems Masahiro's patches (don't know yet which one out of two, probably invd one

Re: [PATCH v1] dfu: Reset timeout in case of DFU request

2020-02-17 Thread Andy Shevchenko
On Wed, Jan 29, 2020 at 05:23:14PM +0200, Andy Shevchenko wrote: > In case dfu command is being executed with timeout option, > the timer may expire in the middle of DFU operation. If there > is DFU request coming, we may simple reset timeout value > to prevent aborting of ongoing D

Re: [PATCH v1] dfu: Reset timeout in case of DFU request

2020-02-10 Thread Andy Shevchenko
On Thu, Jan 30, 2020 at 10:27:20AM +0100, Ferry Toth wrote: > Op 29-01-2020 om 16:23 schreef Andy Shevchenko: > > In case dfu command is being executed with timeout option, > > the timer may expire in the middle of DFU operation. If there > > is DFU request coming, we may

Re: Re: [PATCH v2 0/3] gpio: intel_gpio: Fix Intel gpio driver

2020-02-03 Thread Andy Shevchenko
On Mon, Feb 3, 2020 at 4:27 PM Bin Meng wrote: > On Mon, Feb 3, 2020 at 10:17 PM Andy Shevchenko > wrote: > > On Mon, Feb 3, 2020 at 3:19 PM Wolfgang Wallner > > wrote: ... > > > Does it look different for you? > > > > Yes, for example for this mail

Re: Re: [PATCH v2 0/3] gpio: intel_gpio: Fix Intel gpio driver

2020-02-03 Thread Andy Shevchenko
On Mon, Feb 3, 2020 at 3:19 PM Wolfgang Wallner wrote: > > Hi Andy, > > > -"Andy Shevchenko" schrieb: - > > On Mon, Feb 3, 2020 at 12:38 PM Wolfgang Wallner > > wrote: > > > > > > > > > This series fixes some issues in

Re: [PATCH v2 0/3] gpio: intel_gpio: Fix Intel gpio driver

2020-02-03 Thread Andy Shevchenko
- > 1 file changed, 5 insertions(+), 5 deletions(-) > > -- > 2.25.0 > > -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 3/3] gpio: intel_gpio: Fix register/bit offsets intel_gpio_get_value()

2020-02-03 Thread Andy Shevchenko
e return !!(...); will have same effect while consuming less characters. > else if (rx_tx == PAD_CFG0_RX_DISABLE) 'else' is redundant here > - return mode & PAD_CFG0_TX_STATE_BIT ? 1 : 0; > + return reg & PAD_CFG0_TX_STATE ? 1 : 0; > } -- With Best Regards, Andy Shevchenko

Re: [PATCH 0/5] x86: Improve support for chain-loading U-Boot

2020-02-03 Thread Andy Shevchenko
On Mon, Feb 3, 2020 at 1:02 PM Bin Meng wrote: > On Sun, Dec 22, 2019 at 1:00 AM Andy Shevchenko > wrote: > > > > On Sat, Dec 21, 2019 at 6:13 PM Simon Glass wrote: > > > > > > This little series adds a few checks into the code to allow better >

Re: [PATCH v1 2/2] x86: edison: Switch to ACPI mode

2020-02-03 Thread Andy Shevchenko
0.04 release. Thanks! -- With Best Regards, Andy Shevchenko

Re: [PATCH v1 2/2] x86: edison: Switch to ACPI mode

2020-01-29 Thread Andy Shevchenko
On Thu, Jan 09, 2020 at 11:12:35PM +0200, Andy Shevchenko wrote: > SFI is quite poor and useless resource provider. Moreover it makes hard > to develop and extend functionality in the Linux kernel. > > Enable a necessary minimum to use ACPI on Intel Edison. > > Linux kernel

[PATCH v1] dfu: Reset timeout in case of DFU request

2020-01-29 Thread Andy Shevchenko
In case dfu command is being executed with timeout option, the timer may expire in the middle of DFU operation. If there is DFU request coming, we may simple reset timeout value to prevent aborting of ongoing DFU operation. Signed-off-by: Andy Shevchenko --- drivers/usb/gadget/f_dfu.c | 5

Re: fat: handle Windows formatted partition (thru USB Mass Storage)

2020-01-21 Thread Andy Shevchenko
On Tue, Jan 21, 2020 at 2:39 AM AKASHI Takahiro wrote: > On Fri, Jan 17, 2020 at 11:47:03AM +0200, Andy Shevchenko wrote: > > On Fri, Jan 17, 2020 at 8:13 AM AKASHI Takahiro > > wrote: ... > Really? I've got messed up now. > - Why do you need to use g_multi to access th

Re: [PATCH 0/4] Add Cortina Access basic DM drivers

2020-01-20 Thread Andy Shevchenko
On Mon, Jan 20, 2020 at 04:16:53PM +0200, Igor Opaniuk wrote: > On Mon, Jan 20, 2020 at 4:07 PM Andy Shevchenko > wrote: > > On Mon, Jan 20, 2020 at 02:11:20PM +0200, Igor Opaniuk wrote: > > > On Mon, Jan 20, 2020 at 1:39 PM Andy Shevchenko > > > wrote: > > &g

Re: [PATCH 0/4] Add Cortina Access basic DM drivers

2020-01-20 Thread Andy Shevchenko
On Mon, Jan 20, 2020 at 02:11:20PM +0200, Igor Opaniuk wrote: > On Mon, Jan 20, 2020 at 1:39 PM Andy Shevchenko > wrote: > > > > On Mon, Jan 20, 2020 at 09:53:31AM +, Alex Nemirovsky wrote: > > > This series contains a set of basic DM drivers compatible > > &

Re: [PATCH 0/4] Add Cortina Access basic DM drivers

2020-01-20 Thread Andy Shevchenko
rial_cortina.c > create mode 100644 drivers/serial/serial_cortina.h > create mode 100644 drivers/watchdog/cortina_wdt.c > > -- > 2.7.4 > -- With Best Regards, Andy Shevchenko

[PATCH v1] doc: README.distro: Special case with Windows formatted disk

2020-01-17 Thread Andy Shevchenko
If someone wants to use shared (by installed OS) eMMC partition to the Windows to boot from, it's not possible due to U-Boot limitations. Describe this case and possible workaround. Signed-off-by: Andy Shevchenko --- doc/README.distro | 20 1 file changed, 20 insertions

Re: fat: handle Windows formatted partition (thru USB Mass Storage)

2020-01-17 Thread Andy Shevchenko
On Fri, Jan 17, 2020 at 8:13 AM AKASHI Takahiro wrote: > On Thu, Jan 16, 2020 at 10:31:49PM +0200, Andy Shevchenko wrote: ... > > Prerequisites: > > - the board with U-Boot and installed Linux OS on eMMC > > - g_multi module in Linux OS that shares *one of the eMMC

Re: fat: handle Windows formatted partition (thru USB Mass Storage)

2020-01-16 Thread Andy Shevchenko
On Thu, Jan 16, 2020 at 9:20 PM Heinrich Schuchardt wrote: > On 1/16/20 11:39 AM, Andy Shevchenko wrote: > > > >>> Obviously U-Boot's fat code cannot handle it. > >> > >> So precisely, U-Boot cannot handle nested partition( table)s? > > > > S

Re: fat: handle Windows formatted partition (thru USB Mass Storage)

2020-01-16 Thread Andy Shevchenko
On Thu, Jan 16, 2020 at 4:01 AM AKASHI Takahiro wrote: > On Wed, Jan 15, 2020 at 09:12:59AM +0900, AKASHI Takahiro wrote: > > On Tue, Jan 14, 2020 at 02:43:43PM +0200, Andy Shevchenko wrote: > > > On Tue, Jan 14, 2020 at 10:23 AM Andy Shevchenko > > > wrote: > >

Re: fat: handle Windows formatted partition (thru USB Mass Storage)

2020-01-14 Thread Andy Shevchenko
On Tue, Jan 14, 2020 at 2:43 PM Andy Shevchenko wrote: $ qemu-system-i386 -m 1G -bios u-boot.rom -nographic -drive if=none,file=/tmp/for- andy/image-file,format=raw,id=mydisk -no-reboot -device ich9-ahci,id=ahci -device ide-drive,drive=mydisk,bus=ahci. 0 qemu-system-i386: -device ide-drive,drive

Re: fat: handle Windows formatted partition (thru USB Mass Storage)

2020-01-14 Thread Andy Shevchenko
On Tue, Jan 14, 2020 at 10:23 AM Andy Shevchenko wrote: > On Tue, Jan 14, 2020 at 10:21 AM Andy Shevchenko > wrote: > > On Tue, Jan 14, 2020 at 1:14 AM Heinrich Schuchardt > > wrote: > > > On 1/13/20 10:52 PM, Andy Shevchenko wrote: > > ... > > > >

Re: fat: handle Windows formatted partition (thru USB Mass Storage)

2020-01-14 Thread Andy Shevchenko
On Tue, Jan 14, 2020 at 10:21 AM Andy Shevchenko wrote: > On Tue, Jan 14, 2020 at 1:14 AM Heinrich Schuchardt > wrote: > > On 1/13/20 10:52 PM, Andy Shevchenko wrote: ... > > This image loads fine on current U-Boot, see below. > > Of course it does *in the test ca

Re: fat: handle Windows formatted partition (thru USB Mass Storage)

2020-01-14 Thread Andy Shevchenko
On Tue, Jan 14, 2020 at 1:14 AM Heinrich Schuchardt wrote: > > On 1/13/20 10:52 PM, Andy Shevchenko wrote: > > On Mon, Jan 13, 2020 at 11:05 PM Heinrich Schuchardt > > wrote: > >> On 1/13/20 9:58 PM, Andy Shevchenko wrote: > >>> On Mon, Jan 13, 2020

Re: fat: handle Windows formatted partition (thru USB Mass Storage)

2020-01-13 Thread Andy Shevchenko
On Mon, Jan 13, 2020 at 11:05 PM Heinrich Schuchardt wrote: > On 1/13/20 9:58 PM, Andy Shevchenko wrote: > > On Mon, Jan 13, 2020 at 9:22 PM Andy Shevchenko > > wrote: > > https://paste.cathedral-networks.org/OverdoseSegment > > > > I dunno how long it will be

Re: fat: handle Windows formatted partition (thru USB Mass Storage)

2020-01-13 Thread Andy Shevchenko
On Mon, Jan 13, 2020 at 9:22 PM Andy Shevchenko wrote: > On Mon, Jan 13, 2020 at 9:15 PM Andy Shevchenko > wrote: > P.S. I'll prepare a compressed / sparse image later as promised. https://paste.cathedral-networks.org/OverdoseSegment I dunno how long it will be available. I created

Re: fat: handle Windows formatted partition (thru USB Mass Storage)

2020-01-13 Thread Andy Shevchenko
On Mon, Jan 13, 2020 at 9:15 PM Andy Shevchenko wrote: > On Mon, Jan 13, 2020 at 7:55 PM Heinrich Schuchardt > wrote: > > On 1/13/20 5:34 PM, Tom Rini wrote: > > > On Mon, Jan 13, 2020 at 12:52:48PM +0200, Andy Shevchenko wrote: ... > > But for me the U-Boot's

Re: fat: handle Windows formatted partition (thru USB Mass Storage)

2020-01-13 Thread Andy Shevchenko
On Mon, Jan 13, 2020 at 7:55 PM Heinrich Schuchardt wrote: > On 1/13/20 5:34 PM, Tom Rini wrote: > > On Mon, Jan 13, 2020 at 12:52:48PM +0200, Andy Shevchenko wrote: > >> Hi! > >> > >> I recently stumble over FAT partitioning issue. I have a device with >

<    1   2   3   4   5   6   7   8   9   10   >