Re: [U-Boot] [PATCH v3 0/3] Most rockchip platform based boards use a key to instruct

Andy, Thanks for the reminder. I had this on my list as one of the next ones to be merged. Cheers, Philipp. > On 17 Nov 2017, at 11:09, Andy Yan wrote: > > Hi Philipp: > > Please remember to take this series if they are looks ok for you. And if > you have

Re: [U-Boot] [PATCH 1/2] usb: xhci: implement FEAT_POWER hook for switching regulators for ports

Bin, > On 17 Nov 2017, at 10:27, Bin Meng wrote: > > Hi Philipp, > > On Tue, Nov 7, 2017 at 6:04 AM, Philipp Tomsich > > wrote: >> When the FEAT_POWER flag is set/cleared for a port,

[U-Boot] [PULL] Please pull u-boot-rockchip

Tom, as it turns out, we have some more fixes (for documentation and a board-specific header file) for 2017.11. Thanks, Philipp. The following changes since commit 1c4043e53236d94f217e98625ea201690e85f56d: Merge branch 'master' of git://git.denx.de/u-boot-sunxi (2017-11-09 08:11:40 -0500)

Re: [U-Boot] [U-Boot, 2/3] rockchip: doc: update U-Boot location info

> On 10 Nov 2017, at 12:30, Goldschmidt Simon > wrote: > >>> I just found this commit has calculated the size wrong. 16384 blocks should >>> be 8MB, not 4MB. >> >> Yes, 8MB is what expected here and even Kever[1] commented the same, what is >> 4MB here?

Re: [U-Boot] [U-Boot, 2/3] rockchip: doc: update U-Boot location info

> On 10 Nov 2017, at 12:26, Jagan Teki <jagannadh.t...@gmail.com> wrote: > > On Fri, Nov 10, 2017 at 4:48 PM, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: >> Jagan, >> >>> On 10 Nov 2017, at 12:12, Jagan Teki <ja...@amar

Re: [U-Boot] [U-Boot, 2/3] rockchip: doc: update U-Boot location info

Jagan, > On 10 Nov 2017, at 12:12, Jagan Teki <ja...@amarulasolutions.com> wrote: > > On Fri, Nov 10, 2017 at 3:53 PM, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: >> Kever, >> >>> On 10 Nov 2017, at 08:24, Goldschmidt Simon

Re: [U-Boot] [U-Boot, 2/3] rockchip: doc: update U-Boot location info

Kever, > On 10 Nov 2017, at 08:24, Goldschmidt Simon > wrote: > >>> Update rockchip U-Boot location to 0x4000/16384. At least the location given in the commit message is consistent: (gdb) p 0x4000 $1 = 16384 >>> Signed-off-by: Kever Yang

Re: [U-Boot] [PATCH v5 02/18] rockchip: boot0: align to 0x20 for armv7 '_start'

Andy, On 9 Nov 2017, at 13:59, Andy Yan wrote: > > Hi Phipipp, Kever: > > > On 2017年10月10日 22:21, Philipp Tomsich wrote: >> From: Kever Yang >> >> The '_start' is using as vector table base address, and will write >> to VBAR register, so

Re: [U-Boot] [PATCH 10/15] rockchip: dts: rk3399-puma: add /config/arm-trusted-firmware, reset-gpio property

> On 17 Sep 2017, at 19:54, Simon Glass wrote: > > On 13 September 2017 at 13:29, Philipp Tomsich > wrote: >> With the ATF capable of accessing the FDT passed to the next stage, >> we can specify configuration items for the ATF in the

Re: [U-Boot] [PATCH 07/15] spl: atf: introduce spl_invoke_atf and make bl31_entry private

> On 17 Sep 2017, at 19:53, Simon Glass wrote: > > Hi Philipp, > > On 13 September 2017 at 13:29, Philipp Tomsich > > wrote: >> This adds a new interface spl_invoke_atf() that takes a

[U-Boot] [PULL] Please pull u-boot-rockchip

Tom, Here’s another pull-request for u-boot-rockchip for some last-minute DTS-updates and config-changes for the upcoming release. Regards, Philipp. The following changes since commit 7a69604bce9a9a9476753af64e5a1870880c1333: Prepare v2017.11-rc4 (2017-11-06 18:25:37 -0500) are available

Re: [U-Boot] [PATCH v5 07/18] socfpga: boot0 hook: adjust to unified boot0 semantics

> On 6 Nov 2017, at 18:54, Marek Vasut <marek.va...@gmail.com> wrote: > > On 11/06/2017 06:26 PM, Dr. Philipp Tomsich wrote: >> Marek & Tien Fong, >> >> could either of you have a look at the below change (in the context of >> https://patchwork.ozlabs

Re: [U-Boot] [PATCH v5 07/18] socfpga: boot0 hook: adjust to unified boot0 semantics

Marek & Tien Fong, could either of you have a look at the below change (in the context of https://patchwork.ozlabs.org/patch/823872/, which is also contained in the same series) and give me an ok on this, so I can merge this series early in the upcoming merge window? Thanks, Philipp. > On 10

Re: [U-Boot] [PATCH 1/2] rockchip: config: sync the ENV offset from rockchip legacy U-Boot

> On 31 Oct 2017, at 08:52, Kever Yang wrote: > > Using the ENV offset from rockchip legacy U-Boot for all SoCs, > the offset is 4MB-32KB > > Signed-off-by: Kever Yang > --- > > include/configs/rockchip-common.h | 15 +++ > 1

Re: [U-Boot] [PATCH 2/3] rockchip: doc: update U-Boot location info

> On 2 Nov 2017, at 08:16, Kever Yang wrote: > > Update rockchip U-Boot location to 0x4000/16384. > > Signed-off-by: Kever Yang > --- > > doc/README.rockchip | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [U-Boot] [PATCH] armv8: update gd after relocate

> On 3 Nov 2017, at 03:10, Kever Yang wrote: > > We need to update gd in assamble code after relocate, > this is a fix to: > adc421e arm: move gd handling outside of C code > > Signed-off-by: Kever Yang Reviewed-by: Philipp Tomsich

[U-Boot] [PULL] Please pull u-boot-rockchip

Tom, The rockchip-tree has connected a few minor fixes and defconfig-changes. Please pull. Thanks, Philipp. The following changes since commit 3c1af17c5eebc3718095907c254ae3eb8a3412f8: Merge branch 'master' of git://www.denx.de/git/u-boot-imx (2017-10-31 08:14:53 -0400) are available in

Re: [U-Boot] [PATCH] dm: serial: Add .pre_probe() function to to wait for previous transmission end

Hi Lukasz, > On 27 Oct 2017, at 00:51, Lukasz Majewski wrote: >> >>> On 27 Oct 2017, at 00:13, Lukasz Majewski wrote: >>> >>> It may happen that the serial IP block is performing some ongoing >>> transmission (started at e.g. board_init()) when the serial "probe"

Re: [U-Boot] [PATCH] dm: serial: Add .pre_probe() function to to wait for previous transmission end

> On 27 Oct 2017, at 00:13, Lukasz Majewski wrote: > > It may happen that the serial IP block is performing some ongoing > transmission (started at e.g. board_init()) when the serial "probe" is > called. > > As a result the serial port IP block is reset, so transmitted data is >

Re: [U-Boot] Rockchip GRF/PMUGRF/CRU reg access in U-Boot

Kever, > On 20 Oct 2017, at 03:59, Kever Yang wrote: > > Hi Simon and Philipp. > > I would like to include Heiko who is maintainer of upstream kernel > Rockchip SoC for this topic. > > For the driver related to grf, which including pinctrl, usb phy, gmac and >

Re: [U-Boot] [PATCH v1] Document padding between GPT header and partition entries

> On 17 Oct 2017, at 19:55, Stefan Brüns wrote: > > Commit 02e43537b322 ("part_efi: support padding between the GPT > header and partition entries") added support for deviating from > the typical GPT layout. > > Explicitly state deviations are allowed/possible,

Re: [U-Boot] [PATCH v4 10/18] rockchip: boot0 hook: support early return for RK3188/RK3066-style BROM

> On 10 Oct 2017, at 11:22, Andy Yan wrote: > > Hi: > > > On 2017年10月10日 17:01, Andy Yan wrote: >> Hi Philipp: >> >> On 2017年10月07日 03:28, Philipp Tomsich wrote: >>> Some Rockchip BROM versions (e.g. the RK3188 and RK3066) first read 1KB data >>> from NAND into SRAM

Re: [U-Boot] [PATCH v4 10/18] rockchip: boot0 hook: support early return for RK3188/RK3066-style BROM

Andy, > On 10 Oct 2017, at 11:01, Andy Yan wrote: > > Hi Philipp: > > On 2017年10月07日 03:28, Philipp Tomsich wrote: >> Some Rockchip BROM versions (e.g. the RK3188 and RK3066) first read 1KB data >> from NAND into SRAM and executes it. Then, following a return to

Re: [U-Boot] U-Boot sunxi pinctrl

Joonas, > On 9 Oct 2017, at 17:49, Joonas Kylmälä wrote: > > I see you have been working on pinctrl for sunxi in U-Boot: > . > But I have no idea how old the patches

Re: [U-Boot] [PATCH 031/080] serial: ns16550: Fix address translation

> On 9 Oct 2017, at 14:45, Mario Six wrote: > > (adding Philipp since he converted lots of drivers to livetree recently) > > On Mon, Oct 9, 2017 at 6:48 AM, Simon Glass wrote: >> Hi Mario, >> >> On 29 September 2017 at 06:51, Mario Six

Re: [U-Boot] [PATCH 1/1] rockchip: provide installation instruction for Firefly-RK3399.

> On 9 Oct 2017, at 10:00, Mark Kettenis wrote: > >> From: Simon Glass >> Date: Sun, 8 Oct 2017 22:41:50 -0600 >> >> On 27 September 2017 at 21:35, Heinrich Schuchardt >> wrote: >>> Unfortunately installing U-Boot on an SD card

Re: [U-Boot] [PATCH v4 03/18] rockchip: enable boot0-hook for all Rockchip SoCs

> On 9 Oct 2017, at 11:37, Andy Yan wrote: > > Hi Philipp: > > > On 2017年10月07日 03:28, Philipp Tomsich wrote: >> Rockchip SoCs bootrom design is like this: >> - First 2KB or 4KB internal memory is for bootrom stack and heap; >> - Then the first 4-byte suppose to be a

Re: [U-Boot] [PATCH v2 1/2] rockchip: configs: only add available BOOT_TARGET_DEVICES

> On 6 Oct 2017, at 17:08, Klaus Goger > wrote: > > BOOT_TARGET_DEVICES should only be added if the corresponding u-boot > command is enabled. > > Signed-off-by: Klaus Goger Reviewed-by: Philipp Tomsich

Re: [U-Boot] [U-Boot,v3,04/19] dm: core: add dev_read_addr_ptr()

> On 6 Oct 2017, at 13:47, Heinrich Schuchardt wrote: > > On 09/11/2017 10:04 PM, Philipp Tomsich wrote: >> The dev_read_addr_ptr() mimics the behaviour of the devfdt_get_addr_ptr(), >> retrieving the first address of the node's reg-property and returning >> it as a pointer

Re: [U-Boot] [PATCH] rockchip: configs: use rockchip-common.h for rk3368

Klaus, > On 6 Oct 2017, at 10:12, Klaus Goger > wrote: > > rockchip-common.h already defines values that are missing from > rk3368_common.h > > For example BOOT_TARGET_DEVICES was defined empty and therefore > distroboot had no boot targets. > >

Re: [U-Boot] [PATCH] dwc: ep0: Allocate and flush dwc->ep0_trb in a cache aligned manner

Marek, > On 3 Oct 2017, at 14:04, Marek Vasut wrote: > > On 09/19/2017 01:15 PM, Faiz Abbas wrote: >> A flush of the cache is required before any DMA access can take place. > > You mean invalidation for inbound DMA, flush for outbound DMA, right ? > >> The minimum size that can

Re: [U-Boot] [U-Boot,V9,1/4] usb: rockchip: add the rockusb gadget

+Kever, +Eddie Kever & Eddie, > On 2 Oct 2017, at 12:41, Marek Vasut <ma...@denx.de> wrote: > > On 10/02/2017 12:40 PM, Dr. Philipp Tomsich wrote: >> Lukasz & Marek, >> >>> On 12 Sep 2017, at 10:43, Łukasz Majewski <lu...@denx.de> w

Re: [U-Boot] [U-Boot,V9,1/4] usb: rockchip: add the rockusb gadget

Lukasz & Marek, > On 12 Sep 2017, at 10:43, Łukasz Majewski wrote: > > Hi Dr. Philipp, > >> Hi Lukasz, >>> On 12 Sep 2017, at 10:14, Łukasz Majewski wrote: >>> >>> Hi Philipp, >>> >>> This patch series is waiting for opening new merge window. It is already >>>

[U-Boot] [PULL v2] Please pull u-boot-rockchip

Here’s v2 w/ Jagan’s "armv7: Move L2CTLR read/write to common” modified to not cause any breakage for Tegra. Travis result at https://travis-ci.org/ptomsich/u-boot-rockchip/builds/281769812 Thanks, Philipp. The following changes since commit 6ca43a58db61aea8ca2ebec4003bb6cfacf81d46:

Re: [U-Boot] [PATCH] dm: core: Correct address cast in dev_read_addr_ptr()

> On 30 Sep 2017, at 22:32, Tom Rini <tr...@konsulko.com> wrote: > > On Sat, Sep 30, 2017 at 06:08:02PM +0200, Dr. Philipp Tomsich wrote: >> Simon, >> >>> On 28 Sep 2017, at 18:14, Dr. Philipp Tomsich >>> <philipp.toms...@theobroma-systems.com

Re: [U-Boot] [PATCH] dm: core: Correct address cast in dev_read_addr_ptr()

Simon, > On 28 Sep 2017, at 18:14, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: > > >> On 28 Sep 2017, at 14:35, Simon Glass <s...@chromium.org> wrote: >> >> This currently causes a warning in sandbox and will not do the

[U-Boot] [PULL] Please pull u-boot-rockchip/master

The following changes since commit ec4e99a4a24c84069c710df3202ecb1e501ff60f: Merge git://git.denx.de/u-boot-mmc (2017-09-28 23:31:11 -0400) are available in the git repository at: git://git.denx.de/u-boot-rockchip.git master for you to fetch changes up to

Re: [U-Boot] [PATCH] dm: core: Correct address cast in dev_read_addr_ptr()

> On 28 Sep 2017, at 14:35, Simon Glass wrote: > > This currently causes a warning in sandbox and will not do the right > thing: > > drivers/core/read.c: In function ‘dev_read_addr_ptr’: > drivers/core/read.c:64:44: warning: cast to pointer from integer of > different

Re: [U-Boot] [PATCH 1/1] rockchip: rk3399: spl: implicit declaration back_to_bootrom

On 27 Sep 2017, at 21:05, Heinrich Schuchardt wrote: > > Without #include asm/arch-rockchip/bootrom.h we get: > > arch/arm/mach-rockchip/rk3399-board-spl.c:162:2: > warning: implicit declaration of function ‘back_to_bootrom’ > [-Wimplicit-function-declaration] > > for

Re: [U-Boot] [PATCH] rockchip: rk3188: ram: add support for 16bit row address

Kever, > On 25 Sep 2017, at 10:33, Kever Yang wrote: > > RK3188 using the same ddr_conf for both 15 bit and 16 bit row address. > > Signed-off-by: Kever Yang > --- > > drivers/ram/rockchip/sdram_rk3188.c | 9 - > 1 file changed, 8

Re: [U-Boot] [PATCH v4 1/2] rockchip: rk322x: add sdram driver

> On 27 Sep 2017, at 10:38, Kever Yang wrote: > > Add driver for rk322x to support sdram initialize in SPL. > > Signed-off-by: Kever Yang Acked-by: Philipp Tomsich Reviewed-by: Philipp Tomsich

Re: [U-Boot] [PATCH v3 0/6] rockchip: back-to-bootrom: replace assembly-implementation with C-code

> On 2017年09月21日 18:44, Heiko Stübner wrote: >> Am Donnerstag, 21. September 2017, 12:25:17 CEST schrieb Dr. Philipp Tomsich: >>>> On 21 Sep 2017, at 11:44, Heiko Stuebner <he...@sntech.de> wrote: >>>> >>>> Am Donnerstag, 21. September 2017, 11

Re: [U-Boot] [PATCH v3 0/6] rockchip: back-to-bootrom: replace assembly-implementation with C-code

> On 21 Sep 2017, at 12:25, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: > >> >> On 21 Sep 2017, at 11:44, Heiko Stuebner <he...@sntech.de >> <mailto:he...@sntech.de>> wrote: >> >> Am Donnerstag, 21. Sep

Re: [U-Boot] [PATCH v3 0/6] rockchip: back-to-bootrom: replace assembly-implementation with C-code

> On 21 Sep 2017, at 11:09, Heiko Stuebner wrote: > > Am Donnerstag, 21. September 2017, 10:19:23 CEST schrieb Philipp Tomsich: >> >> Recent discussions confirmed (what the code always assumed): the >> Rockchip BROM always enters U-Boot with the stack-pointer valid >> (i.e.

Re: [U-Boot] [PATCH v3 0/6] rockchip: back-to-bootrom: replace assembly-implementation with C-code

> On 21 Sep 2017, at 11:44, Heiko Stuebner wrote: > > Am Donnerstag, 21. September 2017, 11:09:49 CEST schrieb Heiko Stuebner: >> Am Donnerstag, 21. September 2017, 10:19:23 CEST schrieb Philipp Tomsich: >>> >>> Recent discussions confirmed (what the code always assumed): the

[U-Boot] setjmp/longjmp prototype in U-Boot

Simon & Alexander, It appears our setjmp/longjmp prototypes and implementations are in non-compliance with current C-standards (I checked against both C99 and C2011). U-Boot defines setjmp as: int setjmp(struct jmp_buf_data *jmp_buf) The standard however requires int setjmp(jmp_buf env)

Re: [U-Boot] [PATCH v2 0/5] rockchip: back-to-bootrom: replace assembly-implementation with C-code

Heiko, > On 19 Sep 2017, at 12:16, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: > >> >> On 19 Sep 2017, at 11:12, Heiko Stübner <he...@sntech.de> wrote: >> >> Am Dienstag, 19. September 2017, 11:10:29 CEST schrieb Dr. Philip

Re: [U-Boot] [PATCH 06/13] log: Add an implemention of logging

Masahiro, > On 20 Sep 2017, at 19:34, Masahiro Yamada <yamada.masah...@socionext.com> > wrote: > > 2017-09-20 23:37 GMT+09:00 Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com>: >> Masahiro & Simon, >> >>> On 20 Sep 2017, at 15:49

Re: [U-Boot] [PATCH 06/13] log: Add an implemention of logging

> On 20 Sep 2017, at 16:41, Bin Meng wrote: > > Hi Simon, > > On Wed, Sep 20, 2017 at 9:50 PM, Simon Glass wrote: >> Hi Bin, >> >> On 17 September 2017 at 21:45, Bin Meng wrote: >>> Hi Simon, >>> >>> On Sun, Sep 17, 2017 at 5:23

Re: [U-Boot] [PATCH 06/13] log: Add an implemention of logging

Masahiro & Simon, > On 20 Sep 2017, at 15:49, Simon Glass wrote: > > Hi Masahiro, > > On 19 September 2017 at 20:51, Masahiro Yamada > wrote: >> Hi Simon, >> >> >> 2017-09-17 6:23 GMT+09:00 Simon Glass : >> >>> >>> +menu

Re: [U-Boot] [PATCH] rockchip: imply ADC and SARADC_ROCKCHIP on supported SoCs

David, > On 20 Sep 2017, at 14:25, David.Wu wrote: > > Hi Philipp, > > 在 2017/9/20 19:54, Philipp Tomsich 写道: >> Enable the Rockchip SARADC driver on all supported SoCs (i.e. all >> except the RK3036 and RK3228, which don't have this peripheral): >> RK3188, RK3288,

Re: [U-Boot] [PATCH v2 0/5] rockchip: back-to-bootrom: replace assembly-implementation with C-code

Andy, > On 19 Sep 2017, at 11:10, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: > > Andy, > >> On 19 Sep 2017, at 09:19, Andy Yan <andy@rock-chips.com> wrote: >> >> Hi Philipp: >> >> >> On 2017年09月19日

Re: [U-Boot] [U-Boot,v2,00/14] Add rockchip SARADC support

David, > On 19 Sep 2017, at 12:53, David Wu wrote: > > The SARADC is used for adc keys and charging detect at uboot > loader. Except for the rk3036 and rk3228 Socs, the others > support the SARADC IP. I am hoping to apply this series later this week (and include in a

Re: [U-Boot] [PATCH v2 0/5] rockchip: back-to-bootrom: replace assembly-implementation with C-code

> On 19 Sep 2017, at 11:12, Heiko Stübner <he...@sntech.de> wrote: > > Am Dienstag, 19. September 2017, 11:10:29 CEST schrieb Dr. Philipp Tomsich: >> Andy, >> >>> On 19 Sep 2017, at 09:19, Andy Yan <andy@rock-chips.com> wrote: >>> >

Re: [U-Boot] [PATCH v2 0/5] rockchip: back-to-bootrom: replace assembly-implementation with C-code

Andy, > On 19 Sep 2017, at 09:19, Andy Yan wrote: > > Hi Philipp: > > > On 2017年09月19日 10:06, Andy Yan wrote: >> Hi Philipp: >> >> >> On 2017年09月19日 02:18, Philipp Tomsich wrote: >>> Recent discussions confirmed (what the code always assumed): the >>> Rockchip BROM

Re: [U-Boot] [PATCH 2/3] rockchip: back-to-bootrom: replace assembly-implementation with C-code

Andy, > This function works fine on ARM64 platform, But I got problems on ARMv7. > When trace the code flow with DS5 I found the core switch > to thumb state when jump to save_boot_params_ret[0], but this code can't only > execute in arm state as thumb instruction can't access > cpsr

[U-Boot] Please pull u-boot-rockchip/master

Hi Tom, The following changes since commit c07f38208a73bbe3efaa939d6742096c1cb7e0ce: Merge git://git.denx.de/u-boot-x86 (2017-09-17 11:46:51 -0400) are available in the git repository at: git://git.denx.de/u-boot-rockchip.git master for you to fetch changes up to

Re: [U-Boot] [PATCH 2/3] rockchip: back-to-bootrom: replace assembly-implementation with C-code

On 18 Sep 2017, at 10:17, Andy Yan wrote: > > Hi Philipp: > > > On 2017年09月15日 20:02, Philipp Tomsich wrote: >> The back-to-bootrom implementation for Rockchip has always relied on >> the stack-pointer being valid on entry, so there was little reason to >> have this as

Re: [U-Boot] [PATCH v2 0/3] support enter download mode on rockchip platform

Andy, > On 15 Sep 2017, at 15:23, Andy Yan <andys...@gmail.com> wrote: > > Hi Philipp: > > 2017-09-15 20:07 GMT+08:00 Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com > <mailto:philipp.toms...@theobroma-systems.com>>: > Andy, >

Re: [U-Boot] [PATCH v2 0/3] support enter download mode on rockchip platform

Andy, > On 14 Sep 2017, at 10:51, Andy Yan wrote: > > > Most rockchip platform based boards use a key to instruct > the board enter download firmware mode, some boards use a > adc to detect the key status, and some use a gpio. I just sent out a series that updates the

Re: [U-Boot] [U-Boot, 6/8] clk: rockchip: Add rk3368 Saradc clock support

> On 14 Sep 2017, at 13:17, David.Wu wrote: > > Hi Philipp, > > 在 2017/9/14 4:41, Philipp Tomsich 写道: >>> +static ulong rk3368_saradc_get_clk(struct rk3368_cru *cru) >>> +{ >>> +u32 div, val; >>> + >>> +val = readl(>clksel_con[25]); >>> +div =

Re: [U-Boot] [PATCH 04/15] spl: fit: simplify logic for FDT loading for non-OS boots

York, > On 13 Sep 2017, at 23:24, York Sun <york@nxp.com> wrote: > > On 09/13/2017 02:21 PM, Dr. Philipp Tomsich wrote: >> York, >> >>> On 13 Sep 2017, at 23:16, York Sun <york@nxp.com> wrote: >>> >>> On 09/13/2017 12:30 PM,

Re: [U-Boot] [U-Boot, 6/8] clk: rockchip: Add rk3368 Saradc clock support

> On 13 Sep 2017, at 22:41, Philipp Tomsich > wrote: > > > > On Wed, 13 Sep 2017, David Wu wrote: > >> The clk_saradc is dividing from the 24M, clk_saradc=24MHz/(saradc_div_con+1). >> Saradc integer divider control register is 8-bits width. >> >>

Re: [U-Boot] [PATCH 4/8] clk: rockchip: Add Saradc clock support for rk3288

> On 13 Sep 2017, at 12:09, David Wu wrote: > Commit message? > Signed-off-by: David Wu Reviewed-by: Philipp Tomsich See above and below for requested changes. > --- >

Re: [U-Boot] [PATCH 4/8] clk: rockchip: Add Saradc clock support for rk3288

> On 13 Sep 2017, at 12:09, David Wu wrote: > Please add a commit message. > Signed-off-by: David Wu Reviewed-by: Philipp Tomsich See above and below for requested changes. > --- >

Re: [U-Boot] [PATCH 2/8] configs: rockchip: Enable the ROCKCHIP_SARADC config

> On 13 Sep 2017, at 12:09, David Wu wrote: > > Except for 3036 and 3228 Socs, which don't support Saradc, > enable the ROCKCHIP_SARADC config at the other Socs' defconfig. Please use an ‘imply’ in the Kconfig for the various SoCs (or possibly even the entire

Re: [U-Boot] [RESEND PATCH 0/6] rockchip: enable live tree on the RK3399 and validate on the RK3399-Q7

> On 13 Sep 2017, at 11:49, Marek Vasut <ma...@denx.de> wrote: > > On 09/13/2017 11:47 AM, Dr. Philipp Tomsich wrote: >> >>> On 13 Sep 2017, at 11:42, Marek Vasut <ma...@denx.de> wrote: >>> >>> On 09/12/2017 05:32 PM, Philipp Tom

Re: [U-Boot] [RESEND PATCH 0/6] rockchip: enable live tree on the RK3399 and validate on the RK3399-Q7

> On 13 Sep 2017, at 11:47, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: > > >> On 13 Sep 2017, at 11:42, Marek Vasut <ma...@denx.de> wrote: >> >> On 09/12/2017 05:32 PM, Philipp Tomsich wrote: >>> This series repeats

Re: [U-Boot] [RESEND PATCH 0/6] rockchip: enable live tree on the RK3399 and validate on the RK3399-Q7

> On 13 Sep 2017, at 11:42, Marek Vasut wrote: > > On 09/12/2017 05:32 PM, Philipp Tomsich wrote: >> This series repeats the same exercise as for the RK3368 and adapts any >> lingering dependencies necessary to move the RK3399-based boards over >> to use a live tree. Validated

Re: [U-Boot] rockchip: add support for backing to bootrom download mode

> On 13 Sep 2017, at 10:50, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: > > >> On 13 Sep 2017, at 10:36, Andy Yan <andy@rock-chips.com> wrote: >> >>>>> >>>>> If you just always save the boot_par

Re: [U-Boot] rockchip: add support for backing to bootrom download mode

> On 13 Sep 2017, at 10:36, Andy Yan wrote: > If you just always save the boot_params and check the download flag later from C code, then you could have this implemented in C. This will remove the need to write two separate assembly functions (for

Re: [U-Boot] [RESEND PATCH 2/2] rockchip: dts: rk3399-puma: replace 'rockchip, vbus-gpio' with fixed regulator

> On 13 Sep 2017, at 06:26, Simon Glass wrote: > > On 12 September 2017 at 09:30, Philipp Tomsich > wrote: >> On the RK3399-Q7, we need to turn on the on-module USB hub before using the >> USB host interfaces (only the OTG interface is

Re: [U-Boot] [PATCH 09/10] power: spl: add SPL_DM_REGULATOR_FIXED in Kconfig

> On 13 Sep 2017, at 06:26, Simon Glass wrote: > > On 11 September 2017 at 05:59, Philipp Tomsich > wrote: >> The Makefile already tests for SPL_DM_REGULATOR_FIXED, but Kconfig >> does not provide it. This adds SPL_DM_REGULATOR_FIXED

Re: [U-Boot] [PATCH 04/10] rockchip: spl: support a 'same-as-spl'-specifier in the spl-boot-order

> On 13 Sep 2017, at 06:25, Simon Glass wrote: > > On 11 September 2017 at 05:59, Philipp Tomsich > > wrote: >> It is often desirable to configure the spl-boot-order (i.e. the order >>

Re: [U-Boot] [PATCH 05/10] rockchip: spl: rk3399: implement chip-specific board_spl_was_booted_from()

> On 13 Sep 2017, at 06:25, Simon Glass wrote: > > On 11 September 2017 at 05:59, Philipp Tomsich > wrote: >> To support the new "same-as-spl" specifier in the boot-order on the >> RK3399, this implements the chip-specific mapping from

Re: [U-Boot] rockchip: add support for backing to bootrom download mode

> On 13 Sep 2017, at 03:23, Andy Yan wrote: > > Hi Philipp: > > > On 2017年09月13日 03:30, Philipp Tomsich wrote: >> >> >> On Mon, 11 Sep 2017, Andy Yan wrote: >> >>> Rockchip bootrom will enter download mode if it returns from >>> spl/tpl with a none-zero value and

Re: [U-Boot] [PATCH] rockchip: rk3399: spl: remove hard-coded addresses for GRF and SGRF

> On 11 Sep 2017, at 12:47, Philipp Tomsich > wrote: > > On the RK3399, we will have either OF_PLATDATA or full OF_CONTROL > enabled: this allows the use of syscon to retrieve the addresses of > GRF and SGRF (except for the early debug UART setup, which

Re: [U-Boot] [U-Boot,v3] rk3288: Add Vyasa initial board support

> On 12 Sep 2017, at 13:08, Jagan Teki <jagannadh.t...@gmail.com> wrote: > > On Tue, Sep 12, 2017 at 2:23 PM, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com > <mailto:philipp.toms...@theobroma-systems.com>> wrote: >> Jagan, >>

Re: [U-Boot] [U-Boot,v3] rk3288: Add Vyasa initial board support

Jagan, please revise — after applying this patch, the build fails with: >arm: + vyasa-rk3288 > +cmd/built-in.o: In function `do_usb_mass_storage': > +cmd/usb_mass_storage.c:164: undefined reference to `board_usb_init' > +cmd/usb_mass_storage.c:170: undefined

Re: [U-Boot] [U-Boot,V9,1/4] usb: rockchip: add the rockusb gadget

Hi Lukasz, > On 12 Sep 2017, at 10:14, Łukasz Majewski wrote: > > Hi Philipp, > > This patch series is waiting for opening new merge window. It is already > applied to usb-next tree. Didn’t the new merge window just open yesterday? Regards, Philipp. > >>> this patch

Re: [U-Boot] [PATCH 1/1] spl: u-boot-spl-nodtb.bin: remove .got and .got.plt sections

> On 12 Sep 2017, at 00:40, Heinrich Schuchardt wrote: > > For qemu-x86_64_defconfig on Debian Stretch > ld 2.28 creates a .got and a .got.plt section in > u-boot-spl. > > If we do not ignore these sections objcopy generates an > u-boot-spl-nodtb.bin file of 4 GiB which

Re: [U-Boot] [PATCH v2 06/19] net: phy: micrel: Convert to livetree

> On 11 Sep 2017, at 21:34, Joe Hershberger wrote: > > On Mon, Sep 11, 2017 at 4:18 AM, Philipp Tomsich > > wrote: >> Update the Micrel KSZ90x1 driver for a live tree. >> >>

[U-Boot] [PULL] Please pull u-boot-rockchip/master

Tom, There’s two more bug-fixes for the Rockchip board available. Please pull. Thanks, Philipp. The following changes since commit 25f840d7ef440442f290e760459714a068487727: ARM: rmobile: Disable CONFIG_ARCH_FIXUP_FDT_MEMORY (2017-09-07 20:04:41 -0400) are available in the git repository

Re: [U-Boot] [PATCH] rockchip: enable SPL_SYSRESET config for all sockchip SoCs

Kever, Note that this patch applies neither to master nor to next cleanly. Given that it’s a single line change, I’ll patch this in by hand. Thanks, Philipp. > On 8 Sep 2017, at 05:00, Kever Yang wrote: > > After the patch below, we need to add SPL_SYSRESET for

Re: [U-Boot] [PATCH 2/2] rockchip: ram: rk3399: update reg map for of-platdata

> Thanks, > - Kever > On 09/07/2017 04:51 PM, Dr. Philipp Tomsich wrote: >> Kever, >> >> Thanks for the fix. >> >> Could we move all RK3399 boards to use OF_CONTROL (i.e. not OF_PLATDATA) >> in SPL? We have been using this for the RK3399-Q7 and th

Re: [U-Boot] [PATCH] rockchip: firefly-rk3399: enable SPL_SYSRESET config

Kever, I’ll try to get this in for the current release (i.e get it applied and send out a pull later this week), as it’s a defconfig-only bugfix for a regression introduced in the current release. Regards, Philipp. > On 7 Sep 2017, at 05:30, Kever Yang wrote: > >

Re: [U-Boot] [PATCH 2/2] rockchip: ram: rk3399: update reg map for of-platdata

Kever, Thanks for the fix. Could we move all RK3399 boards to use OF_CONTROL (i.e. not OF_PLATDATA) in SPL? We have been using this for the RK3399-Q7 and there is plenty of SRAM left for future code-growth, so this should be a safe choice. Regards, Philipp. > On 7 Sep 2017, at 05:20, Kever

Re: [U-Boot] [PATCH 1/3] spl: update bl31_entry() with new name and parameter

Kever, > On 7 Sep 2017, at 09:00, Kever Yang wrote: > > Rename the bl31_entry() function with 'spl_' prefix and add one > parameter for bl31 entry address since we can get it from spl_image header. Just as a heads-up, I also have a patch in my queue (i.e. to submit

Re: [U-Boot] [PATCH v2 1/5] rockchip: rk322x: update dram bank size

Kever, I don’t have a problem with the below patch, but the entire series is held up by patch #2 (adding the SDRAM driver): https://patchwork.ozlabs.org/patch/802385/ I generally don’t attempt to apply parts of a series (and always apply the entire series), as this just increases the

Re: [U-Boot] [PATCH] rockchip: pinctrl: use fdtdec_get_int_array() to get interrupt

> On 6 Sep 2017, at 10:36, Kever Yang wrote: > > Not all the udevice have a available DT node, eg. rksd...@ff50.blk > which add by mmc_bind(), if we use dev_read_u32_array(), the interface > will use the ofnode directly and end with: >

[U-Boot] [PULL] Please pull u-boot-rockchip/master

Tom, I have a few lingering fixes and config changes. Thanks, Philipp. The following changes since commit 0e88cdd17da393e7dd6040de6a3fda289c00a51e: Prepare v2017.09-rc4 (2017-09-04 09:02:48 -0400) are available in the git repository at: git://git.denx.de/u-boot-rockchip.git master for

Re: [U-Boot] [U-Boot, 3/3] rockchip: firefly-rk3399: enable ATF and dwmmc

Philipp Tomsich <philipp.toms...@theobroma-systems.com> >>> --- >>> >>> configs/firefly-rk3399_defconfig | 6 -- >>> 1 file changed, 4 insertions(+), 2 deletions(-) >>> >> Reviewed-by: Philipp Tomsich <philipp.toms...@theobroma-systems

Re: [U-Boot] rockchip: enable rk322x sysreset driver

gt; Reviewed-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com> >>> --- >>> >>> drivers/sysreset/Makefile | 1 + >>> 1 file changed, 1 insertion(+) >>> >> Acked-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com> &g

Re: [U-Boot] [PATCH v3] patman: add support for omitting bouncing addresses

> On 1 Sep 2017, at 10:57, Chris Packham wrote: > > Add support for reading a list of bouncing addresses from a in-tree file > (doc/bounces) and from the ~/.patman config file. These addresses are > stripped from the Cc list. > > Signed-off-by: Chris Packham

Re: [U-Boot] tpl build error "width suffixes are invalid in ARM mode"

confuse where the build option affects, eg. which Mackfile or > config.mk? > > Thanks, > - Kever > On 08/30/2017 06:16 PM, Dr. Philipp Tomsich wrote: >> I just realised that you are building TPL. >> For this you will need a TPL_SYS_THUMB_BUILD symbol now (with the >

Re: [U-Boot] tpl build error "width suffixes are invalid in ARM mode"

version 6.3.0’ built from source. > On 30 Aug 2017, at 11:27, Kever Yang <kever.y...@rock-chips.com> wrote: > > Philipp, > > On 08/30/2017 04:59 PM, Dr. Philipp Tomsich wrote: >> Kever, >> >> I took a quick look and this seems to be an issue with CONFIG m

Re: [U-Boot] [PATCH v2 00/16] dtoc: Add support for 64-bit addresses

> On 30 Aug 2017, at 11:37, Simon Glass <s...@chromium.org> wrote: > > Hi Philipp, > > On 30 August 2017 at 04:31, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: >> Simon, >> >> I should be able to give this a tes

Re: [U-Boot] tpl build error "width suffixes are invalid in ARM mode"

Kever, I took a quick look and this seems to be an issue with CONFIG macros. This is failing, because the assembly (after preprocessing) requests regular ARM mode and supplies Thumb mnemonics (e.g. nop.w). The trigger seems to be the following CONFIG_IS_ENABLED check in arch/arm/lib/memcpy.S:

Re: [U-Boot] [PATCH v2 00/16] dtoc: Add support for 64-bit addresses

Simon, I should be able to give this a test drive on the RK3368 by the end of the week. For the RK3399 our board uses full OF_CONTROL, so I won’t really exercise this there. Given that the RK3399 can always fall back to OF_CONTROL for SPL (as is the default on Puma) and this only blocks the

Re: [U-Boot] [PATCH v2 05/16] dtoc: Add support for 32 or 64-bit addresses

> On 29 Aug 2017, at 22:15, Simon Glass wrote: > > When using 32-bit addresses dtoc works correctly. For 64-bit addresses it > does not since it ignores the #address-cells and #size-cells properties. > > Update the tool to use fdt64_t as the element type for reg properties

<    1   2   3   4   5   >