Re: [PATCH v5 2/2] serial: mxc: have putc use the TXFIFO

2022-11-02 Thread Fabio Estevam
rting your change makes the issue disappear. Regards, Fabio Estevam -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-60 Fax: (+49)-8142-66989-80 Email: feste...@denx.de

Re: [PATCH v6] imx: imx8qm: cgtqmx8: switch to binman

2022-11-02 Thread Fabio Estevam
Hi Oliver, On Wed, Nov 2, 2022 at 6:12 AM Oliver Graute wrote: > #include "fsl-imx8qm.dtsi" > +#include "imx8qm-u-boot.dtsi" This file does not exist in U-Boot mainline. I know you added it as part of another patch, but please send a patch series so that all dependencies are available. What

Re: [PATCH v5 2/2] serial: mxc: have putc use the TXFIFO

2022-11-02 Thread Fabio Estevam
ted from linux > > i still would argue to keep the change, since both the linux kernel and > $other bootloaders make use of the TXFULL flag The problem is that your change is causing a regression as reported by Tim. It can be easily reproduced. Please help fix it, otherwise, we will need to revert your change. Thanks, Fabio Estevam

Re: [PATCH v5] imx: imx8qm: cgtqmx8: switch to binman

2022-11-01 Thread Fabio Estevam
Hi Oliver, On Tue, Oct 25, 2022 at 12:31 PM Oliver Graute wrote: > Now Running into this issue: > > MKIMAGE u-boot.img > MKIMAGE u-boot-dtb.img > LD u-boot.elf > make[1]: Für das Ziel „SPL“ ist nichts zu tun. > BINMAN all > binman: Section '/binman/u-boot-spl-ddr': Symbol >

Re: [PATCH v5 2/2] serial: mxc: have putc use the TXFIFO

2022-11-01 Thread Fabio Estevam
Johannes, On Wed, Oct 26, 2022 at 7:23 PM SCHNEIDER Johannes wrote: > > Hi > > the thing with only checking !TXEMPTY is that it limits the fifo to one byte > only; and as far as i understood, drivermodel code is supposed to return > immediately and t Why does it limit the FIFO to one byte

Re: Binman entry 'u-boot-any' not found in list

2022-10-28 Thread Fabio Estevam
[Adding Alper - binmam maintainer and Oliver, who faced the same issue on imx8] On Fri, Oct 28, 2022 at 7:56 AM Neha Malcom Francis wrote: > > Hi! > > U-Boot build for J721E with binman enabled on the latest tip of the > master branch throws an error when I try to use u-boot-spl-nodtb entry > in

Re: [PATCH v5 2/2] serial: mxc: have putc use the TXFIFO

2022-10-26 Thread Fabio Estevam
Hi Peng, On Wed, Oct 26, 2022 at 7:11 AM Peng Fan wrote: > This may bring the issue that Johannes met back It looks like Johannes met the problem in the FIFO full case. Johannes, Could you please test this change? Thanks

Re: [PATCH] arm: dts: ti: k3-am64-main: Add RTI watchdog nodes

2022-10-26 Thread Fabio Estevam
Hi Christian, On Wed, Oct 26, 2022 at 6:42 AM Christian Gmeiner wrote: > > Add the needed bus mappings for the two main RTI memory ranges and > the required device tree nodes in the main domain. > > Same as kernel commit 6dd8457dc20693e2ba9054c171499b22664fd4e7 You missed to add your

Re: [PATCH v2] serial: mxc: Keep the original FIFO empty check

2022-10-25 Thread Fabio Estevam
s are FIFO empty and FIFO full, which returns -EAGAIN to the serial core. Regards, Fabio Estevam -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-60 Fax: (+49)-8142-66989-80 Ema

[PATCH v2] serial: mxc: Keep the original FIFO empty check

2022-10-25 Thread Fabio Estevam
From: Fabio Estevam Tim Harvey reported that since commit c7878a0483c5 ("serial: mxc: have putc use the TXFIFO"), console messages put inside board_init() are no longer printed correctly. This change added a check to handle the UART FIFO full condition and removed the UART FIFO e

Re: [PATCH v5 2/2] serial: mxc: have putc use the TXFIFO

2022-10-25 Thread Fabio Estevam
Hi Tim, On 25/10/2022 18:37, Tim Harvey wrote: Fabio and Pali, Seems reasonable but this does not resolve the problem. Whatever I print in board_init gets cutoff by the print from dm_announce. Should we check for both TXFULL and TXEMPTY conditions? --- a/drivers/serial/serial_mxc.c +++

Re: [PATCH v5 2/2] serial: mxc: have putc use the TXFIFO

2022-10-25 Thread Fabio Estevam
Hi Tim, On 25/10/2022 18:37, Tim Harvey wrote: Fabio and Pali, Seems reasonable but this does not resolve the problem. Whatever I print in board_init gets cutoff by the print from dm_announce. You are right. I managed to reproduce it: --- a/board/warp7/warp7.c +++ b/board/warp7/warp7.c @@

[PATCH] serial: mxc: Wait until TX FIFO is not full

2022-10-25 Thread Fabio Estevam
From: Fabio Estevam Tim Harvey reported the console garbage on imx6 since commit c7878a0483c5 ("serial: mxc: have putc use the TXFIFO"). Do as suggested by Pali Rohár where the the driver should not return -EAGAIN when the TX FIFO is full. It should keep waiting until the TX FIFO is

Re: [PATCH v5 2/2] serial: mxc: have putc use the TXFIFO

2022-10-25 Thread Fabio Estevam
Hi Pali, On 25/10/2022 17:23, Pali Rohár wrote: Hello! I do not have any MXC hardware but I see there one issue. mxc_serial_putc() function probably should not return -EAGAIN when device is busy. But instead it should wait until it is ready. Could you try to change code to following?

Re: [PATCH v5] imx: imx8qm: cgtqmx8: switch to binman

2022-10-25 Thread Fabio Estevam
Hi Oliver, On Tue, Oct 25, 2022 at 12:31 PM Oliver Graute wrote: > Now Running into this issue: > > MKIMAGE u-boot.img > MKIMAGE u-boot-dtb.img > LD u-boot.elf > make[1]: Für das Ziel „SPL“ ist nichts zu tun. > BINMAN all > binman: Section '/binman/u-boot-spl-ddr': Symbol >

[PATCH] imx8m: Select BINMAN via SoC level

2022-10-25 Thread Fabio Estevam
From: Fabio Estevam Since all imx8m boards have been converted to use binman, select binman via SoC level rather than making the selection for each board. Signed-off-by: Fabio Estevam --- arch/arm/mach-imx/imx8m/Kconfig | 33 + 1 file changed, 1 insertion

Re: [PATCH v3] imx: imx8qm-rom7720: switch to binman

2022-10-25 Thread Fabio Estevam
Hi Oliver, On Fri, Oct 7, 2022 at 10:14 AM Oliver Graute wrote: > + fdt { > + filename = "imx8qm-rom7720-a1"; Please do not hardcode this dtb filename inside the common imx8qm-u-boot.dtsi file. You can look at

Re: [PATCH v3] imx: imx8qm: cgtqmx8: switch to binman

2022-10-24 Thread Fabio Estevam
Hi Stefano and Oliver, On Tue, May 3, 2022 at 7:49 AM Oliver Graute wrote: > > Switch to use binman to pack images > > Signed-off-by: Oliver Graute > Reviewed-by: Fabio Estevam > Reviewed-by: Simon Glass > --- > Changes for v3 > -added Reviewed-by > -rebas

Re: [PATCH] ARM: dts: imx8mq-kontron-pitx-imx8m: Remove off-on-delay-us property

2022-10-24 Thread Fabio Estevam
e linux dts file. I saw your equivalent patch to the Linux devicetree. When I saw it, it was unclear whether it fixed a bug. Reading the commit log of this patch, it becomes clear. I suggest you improve the commit log to the other patch to state that it fixes a real bug. Reviewed-by: Fabio Estevam

Re: [PATCH V2 4/4] imx: imx8mn-beacon: Fix out of spec voltage

2022-10-22 Thread Fabio Estevam
On Sat, Oct 22, 2022 at 10:44 AM Adam Ford wrote: > > The DDR is configured for LPDDR4 running at 1.6GHz which requires > the voltage on the PMIC to rise a bit before initializing LPDDR4 > or it will be running out of spec. > > Signed-off-by: Adam Ford Reviewed-by: Fabio Estevam

Re: [PATCH V2 3/4] configs: imx8mn_beacon: Enable SPL_DM_PMIC_BD71837

2022-10-22 Thread Fabio Estevam
On Sat, Oct 22, 2022 at 10:44 AM Adam Ford wrote: > > To properly operate the Nano with LPDDR4 at 1.6GHz, the > voltage needs to be adjusted before DDR is initialized. > Enable the PMIC in SPL to do this. > > Signed-off-by: Adam Ford Reviewed-by: Fabio Estevam

Re: [PATCH V2 2/4] regulator: bd718x7: Only bind children when PMIC_CHILDREN is enabled

2022-10-22 Thread Fabio Estevam
REN to be disabled in SPL saves some space and > still permits some read/write functions to access the PMIC in > early startup. Cool, that's a good hint. I was not aware of it. Reviewed-by: Fabio Estevam

Re: [PATCH V2 1/4] configs: imx8mn_beacon: Re-align memory to standard imx8mn settings

2022-10-22 Thread Fabio Estevam
ocations increases > the amount of available meory for the SPL stack. Doing this allows s/meory/memory > the board to no longer define CONFIG_MALLOC_F_ADDR. > > Since SYS_LOAD_ADDR also does not align with other boards, move it too. > > Signed-off-by: Adam Ford Reviewed-by: Fabio Estevam

Re: [PATCH 3/3] imx: imx8mm-beacon: Move Environment to eMMC partition 2

2022-10-22 Thread Fabio Estevam
On Sat, Oct 22, 2022 at 11:28 AM Adam Ford wrote: > > The downstream U-Boot distributed by Beacon stores the environment > in the eMMC and the end of partition 2. This allow the environment > to stay on the SOM regardless of the boot source. > > Signed-off-by: Adam Ford

Re: [PATCH 2/3] imx: imx8mm-beacon: Enable USB booting via SDP

2022-10-22 Thread Fabio Estevam
s a device when > booting and OTG is the default mode. Add USB boot support > to spl_board_boot_device and enable the corresponding config > options. > > Signed-off-by: Adam Ford Reviewed-by: Fabio Estevam

Re: [PATCH 1/3] imx: imx8mm_beacon: Eliminate a few extras to free up SPL space

2022-10-22 Thread Fabio Estevam
On Sat, Oct 22, 2022 at 11:28 AM Adam Ford wrote: > > There are a few functions which are not essential for use in > SPL, but they take up enough space to make other preferred > features not fit. Remove the extras. > > Signed-off-by: Adam Ford Reviewed-by: Fabio Estevam

Re: [PATCH] imx28-xea: Add missing imx28-lwe.dtsi

2022-10-22 Thread Fabio Estevam
On Sat, Oct 22, 2022 at 10:31 AM Michael Nazzareno Trimarchi wrote: > On my side the Continuous Integration using gitlab-ci, verify board > combinations > and test the build. I'm asking if this build breakage happen because > those boards > are not built. All boards are built by CI and the

Re: [PATCH] imx28-xea: Add missing imx28-lwe.dtsi

2022-10-22 Thread Fabio Estevam
Hi Michael, On Sat, Oct 22, 2022 at 10:19 AM Michael Nazzareno Trimarchi wrote: > I have seen patches that fix build issues but how they land in the > first place. I mean > CI is used to avoid build regression I am sorry, but I could not understand your message. Care to clarify? Thanks

Re: [PATCH] imx8mn-venice-u-boot: Fix broken boot

2022-10-22 Thread Fabio Estevam
("imx8mn: synchronise device tree with linux") > > Signed-off-by: Fabio Estevam > > Reviewed-by: Michael Trimarchi > Applied to u-boot-imx, master, thanks ! Thanks, but this one is already present in U-Boot 2022.10 final. Tom applied it directly to avoid the boot regression. It seems that the u-boot-imx base is not up to date.

[PATCH] imx8qm-cgtqmx8: Introduce imx8qm-cgtqmx8-u-boot.dtsi

2022-10-22 Thread Fabio Estevam
From: Fabio Estevam Since commit 02682bf82568 ("imx: imx8qm: cgtqmx8: switch to binman") the following build error is seen: arch/arm/dts/.imx8qm-cgtqmx8.dtb.pre.tmp:15:10: fatal error: imx8qm-u-boot.dtsi: No such file or directory This commit included "imx8qm-u-boot.dtsi"

[PATCH] imx28-xea: Add missing imx28-lwe.dtsi

2022-10-22 Thread Fabio Estevam
From: Fabio Estevam The following build error is seen when building imx28_xea_defconfig: arch/arm/dts/.imx28-xea.dtb.pre.tmp:8:10: fatal error: imx28-lwe.dtsi: No such file or directory This happens because commit ebcca534f557 ("imx28: synchronise device tree with linux") missed

Re: [PATCH 1/1] imx8m: ddr_init: fix reading of DDR4 MR registers

2022-10-19 Thread Fabio Estevam
Hi Paul, On 19/10/2022 23:33, Ying-Chun Liu (PaulLiu) wrote: Accorting to commit 290ffe57886271a6 we need to read more significant bytes to get a non-zero value. However commit 7e9bd84883aeb1e2 removes it by accident. Thus we add the changes back. This is needed to let imx8mm-cl-iot-gate to

Re: [PATCH 1/1] board: gateworks: gw_ventana: fix building with GCC 12.2

2022-10-17 Thread Fabio Estevam
L [-Werror=address] > 636 | } else if (hwconfig_subarg_cmp(arg, "mode", > "pwm") && > | > ^~ > > Remove the superfluous check. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Fabio Estevam

Re: [EXT] [REGRESSION]: v2022.07: SHA256 hash is broken on imx8m series with CAAM enabled

2022-10-16 Thread Fabio Estevam
pplied onto master. Correct. Hopefully, Stefano can apply it for 2023.01. Regards, Fabio Estevam

Re: [PATCH 0/6] broken CVE fix (b85d130ea0ca)

2022-10-15 Thread Fabio Estevam
of the others. Finally, 2 > and 3 are my attempts at actually fixing CVE-2022-{30790,30552}, with > 2 essentially lifting the "ensure the payload has non-negative size" > to the first place we can check that instead of relying on that check > to happen in several places. Thanks for the fix: Reviewed-by: Fabio Estevam

Re: [EXT] [REGRESSION]: v2022.07: SHA256 hash is broken on imx8m series with CAAM enabled

2022-10-14 Thread Fabio Estevam
Hi Andrey, On Fri, Oct 14, 2022 at 3:53 PM ZHIZHIKIN Andrey wrote: > `imx8mp.dtsi` however was not sync'd in, so the JR0 disabling is left out. :( > This does explain why the SHA calculation are not operable for that SoC. Marcel has submitted the dts sync patch:

Re: Bad Data CRC

2022-10-12 Thread Fabio Estevam
On Mon, Oct 10, 2022 at 6:31 PM momo aubin wrote: > > Hello Simon, > > My board boots well . When I added the second partition into my kernel I > got this message > *Verifying Checksum ... Bad Data CRC* > what could be the root cause ? Try to run "saveenv",

Re: [REGRESSION]: v2022.07: SHA256 hash is broken on imx8m series with CAAM enabled

2022-10-10 Thread Fabio Estevam
Hi Rasmus, On Mon, Oct 10, 2022 at 11:07 AM Rasmus Villemoes wrote: > This is still broken in v2022.10. Are there any plans to fix this? If I recall correctly the fix for this issue is to sync imx8m dts files with Linux so that the following commit can be in place:

[PATCH v2] mtd: Update the function name to 'rfree'

2022-10-07 Thread Fabio Estevam
Since commit 8d38a8459b0d ("mtd: Rename free() to rfree()") the function has been renamed to rfree(), so update the description inside the mtd_oob_region structure as well. Fixes: 8d38a8459b0d ("mtd: Rename free() to rfree()") Reported-by: Mikhail Kshevetskiy Signed-o

[PATCH] mtd.h: Update the function name to 'rfree'

2022-10-07 Thread Fabio Estevam
Since commit 8d38a8459b0d ("mtd: Rename free() to rfree()") the function has been renamed to rfree(), so update the description inside the mtd_oob_region structure as well. Fixes: 8d38a8459b0d ("mtd: Rename free() to rfree()") Reported-by: Mikhail Kshevetskiy Signed-o

Re: [PATCH 1/7] mtd: replace name of 'rfree' field with 'free' in struct mtd_ooblayout_ops to better match it's description

2022-10-07 Thread Fabio Estevam
On Fri, Oct 7, 2022 at 8:34 AM Michael Nazzareno Trimarchi wrote: > About this change, there was a commit from Simon 8d38a8459b0 > that was renamed. You ask basically to revert it Correct, what about fixing it like this? diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h index

Re: [PATCH] imx8m: fix reading of DDR4 MR registers [again]

2022-10-06 Thread Fabio Estevam
reads back the ID register and uses that for a sanity check. So apply the fix from 290ffe5788 once again. Fixes: 99c7cc58e1 (ddr: imx: Add i.MX9 DDR controller driver) Signed-off-by: Rasmus Villemoes Thanks for the fix: Reviewed-by: Fabio Estevam

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-04 Thread Fabio Estevam
Hi Tim, On 04/10/2022 13:50, Tim Harvey wrote: Fabio, I just sent a v5 before seeing this. I think all we are waiting for on this series is for Vladimir to ok the dt changes as I believe I have finally done the right thing there now. If I need to do a v6 I'll add this in, otherwise I'll send

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-04 Thread Fabio Estevam
Hi Tim, On Tue, Oct 4, 2022 at 1:25 PM Fabio Estevam wrote: > > Hi Tim, > > On Tue, Oct 4, 2022 at 12:26 PM Tim Harvey wrote: > > > Fabio, > > > > Thanks for testing this. I'll submit a v5 shortly with your rb tag and > > support for 6320:

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-04 Thread Fabio Estevam
Hi Tim, On Tue, Oct 4, 2022 at 12:26 PM Tim Harvey wrote: > Fabio, > > Thanks for testing this. I'll submit a v5 shortly with your rb tag and > support for 6320: Thanks for including the 6320 model! > Was there an error path you found in drivers/net/mv88e6xxx.c that > should print an error to

Re: [PATCH 1/7] arm: dts: imx8mn-u-boot: Create common imx8mn-u-boot.dtsi

2022-10-03 Thread Fabio Estevam
h moved the UART nodes under the SPBA node. Sorry for the delay. The series looks good, thanks: Reviewed-by: Fabio Estevam

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-03 Thread Fabio Estevam
commands are functional. Thanks a lot for your work on this and for your help! If you send a v5 with the CONFIG_MV88E6XXX=y typo fixed, feel free to add for the whole series: Reviewed-by: Fabio Estevam

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-03 Thread Fabio Estevam
On Mon, Oct 3, 2022 at 8:46 PM Fabio Estevam wrote: > The switch I am using is a mv88e6320. > > I instrumented the code a bit and I notice that I am not able to read > the switch ID. > > mv88e6xxx_get_switch_id() fails because mv88e6xxx_port_read() returns 0x. This was c

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-03 Thread Fabio Estevam
Hi Tim, On Mon, Oct 3, 2022 at 8:39 PM Tim Harvey wrote: > Fabio, > > I'm not sure why your configuration is behaving differently and think > you'll have to instrument code to help understand it. > > Here is the chain of events I see on my imx6q fec <-> mv88e6085 configuration: The switch I am

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-03 Thread Fabio Estevam
don't use that and if I recall that code never seemed right to me. CONFIG_DM_ETH_PHY is not enabled. Regards, Fabio Estevam -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-60 Fax

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-03 Thread Fabio Estevam
:00:00 eth4 : lan1 00:00:00:00:00:00 u-boot=> setenv ethact lan4 u-boot=> dhcp BOOTP broadcast 1 BOOTP broadcast 2 BOOTP broadcast 3 BOOTP broadcast 4 BOOTP broadcast 5 BOOTP broadcast 6 BOOTP broadcast 7 BOOTP broadcast 8 (IP is never retrieved) > What board are you using and what does its fec/mdio dt look like? I am using a custom imx8mn board. The FEC/MDIO nodes are like this: https://pastebin.com/raw/0SvLLzxj Thanks, Fabio Estevam

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-03 Thread Fabio Estevam
Hi Tim, On Wed, Sep 28, 2022 at 4:37 PM Tim Harvey wrote: > diff --git a/configs/gwventana_gw5904_defconfig > b/configs/gwventana_gw5904_defconfig > index 8c6baf0ae5e2..33b57c5a1c5d 100644 > --- a/configs/gwventana_gw5904_defconfig > +++ b/configs/gwventana_gw5904_defconfig > @@ -111,11

Re: [PATCH v4 0/8] Add MV88E6xxx DSA driver and use on gwventana

2022-10-03 Thread Fabio Estevam
On Mon, Oct 3, 2022 at 1:26 PM Fabio Estevam wrote: > And 'dm tree' shows that the Ethernet drivers have not been probed: > > => dm tree > > ethernet 0 [ ] fecmxc| | `-- ethernet@30be > ... > mdio 0 [ ] fec_mdio

Re: [PATCH v4 0/8] Add MV88E6xxx DSA driver and use on gwventana

2022-10-03 Thread Fabio Estevam
Hi Tim, On Wed, Sep 28, 2022 at 4:37 PM Tim Harvey wrote: > > This series adds a DSA driver for the MV88E6xxx based on > drivers/net/phy/mv88e61xx and uses it in the gwventana_gw5904_defconfig. > > The hope is that the other three boards that use the MV88E61xx driver > can move to this as well

Re: [PATCH v2] imx8mn-ddr4-evk-u-boot: Fix broken boot

2022-10-03 Thread Fabio Estevam
, we are in the release day for 2022.10. My goal is to avoid the boot regressions with the minimum changes, so that's why I have sent these patches. After 2022.10 is out, then imx8mn-u-boot.dtsi can be properly introduced. Regards, Fabio Estevam -- DENX Software Engineering GmbH, Managing Dire

Re: [PATCH v2] imx8mn-ddr4-evk-u-boot: Fix broken boot

2022-10-03 Thread Fabio Estevam
the imx8mn-u-boot.dtsi can be introduced. Regards, Fabio Estevam -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-60 Fax: (+49)-8142-66989-80 Email: feste...@denx.de

[PATCH v2] imx8mn-ddr4-evk-u-boot: Fix broken boot

2022-10-03 Thread Fabio Estevam
node to the spl device tree to restore normal booting. Based on the patch from Adam Ford for the imx8mn-beacon-kit-u-boot board. Fixes: 4e5114daf9eb ("imx8mn: synchronise device tree with linux") Signed-off-by: Fabio Estevam --- Changes since v1: - Fix typo in commit log: i

[PATCH v2] imx8mn-venice-u-boot: Fix broken boot

2022-10-03 Thread Fabio Estevam
node to the spl device tree to restore normal booting. Based on the patch from Adam Ford for the imx8mn-beacon-kit-u-boot board. Fixes: 4e5114daf9eb ("imx8mn: synchronise device tree with linux") Signed-off-by: Fabio Estevam --- Changes since v1: - Fix typo in commit log: i

[PATCH] imx8mn-venice-u-boot: Fix broken boot

2022-10-03 Thread Fabio Estevam
node to the spl device tree to restore normal booting. Based on the patch from Adam Ford for the imx8mn-beacon-kit-u-boot board. Fixes: 4e5114daf9eb ("imx8mn: synchronise device tree with linux") Signed-off-by: Fabio Estevam --- Hi Tim, Could you please test this patch? It

[PATCH] imx8mn-ddr4-evk-u-boot: Fix broken boot

2022-10-03 Thread Fabio Estevam
node to the spl device tree to restore normal booting. Based on the patch from Adam Ford for the imx8mn-beacon-kit-u-boot board. Fixes: 4e5114daf9eb ("imx8mn: synchronise device tree with linux") Signed-off-by: Fabio Estevam --- Hi Tom and Stefano, I know today is release day. Coul

Re: [PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-09-28 Thread Fabio Estevam
Hi Tim, On Wed, Sep 28, 2022 at 4:37 PM Tim Harvey wrote: > > Add MV88E61XX DSA support: > - update dt: U-Boot dsa driver requires different device-tree syntax >than the linux driver in order to link the dsa ports to the mdio bus. Shouldn't the U-Boot dts version

Re: [PATCH v1] gpio: adp5585: add gpio driver for ADP5585 I/O Expander Controller

2022-09-28 Thread Fabio Estevam
Hi Alice, On Wed, Sep 28, 2022 at 4:52 AM Alice Guo (OSS) wrote: > Hi Fabio, > > Thanks for your reply. When compiling without "#include ", the > following error will appear: > In file included from ./arch/arm/include/asm/gpio.h:2, > from drivers/gpio/adp5585_gpio.c:10: >

Re: [PATCH] imx6: Remove extra quotes in fdtfile environment variable

2022-09-27 Thread Fabio Estevam
Just a nit: in the Subject, it would be better to change it like this: nitrogen6x: Remove extra quotes in fdtfile Reviewed-by: Fabio Estevam Stefano/Tom, This is 2022.10 material IMHO.

Re: [PATCH 0/4] clk-imx8mm: Reduce SPL binary size

2022-09-27 Thread Fabio Estevam
Hi Michael, On Tue, Sep 27, 2022 at 10:38 AM Michael Nazzareno Trimarchi wrote: > When Dario wrote the Ti clock, he was using the dtsi. One idea can be > understand if this approch > cost less in term of space in the SPL Care to submit a patch series with your proposal?

Re: [PATCH 0/4] clk-imx8mm: Reduce SPL binary size

2022-09-27 Thread Fabio Estevam
Hi Michael, On 27/09/2022 09:24, Michael Nazzareno Trimarchi wrote: Fabio Estevam (4): clk-imx8mm: Only build PWM clocks in non-SPL code clk-imx8mm: Move CLK_ENET_AXI to the non-SPL section I'm not really convinced of those two. I mean with should maybe think about some different

Re: [PATCH] pico-imx7d: add baseboard SD card boot detect

2022-09-27 Thread Fabio Estevam
On Sun, Aug 21, 2022 at 7:31 PM wrote: > > Migrate SD card boot detection from Technexion u-boot for pico-imx7d SoM. > > From ecd4f6ecbec290c63504f7ec3a9b478425235d14 Mon Sep 17 00:00:00 2001 > From: "Benjamin Szőke" > > Date: Sun, 21 Aug 2022 21:08:55 +0200 > Subject: [PATCH] pico-imx7d: add

Re: [PATCH v2] configs: imx8m: Enable CONFIG_ARMV8_CRYPTO support

2022-09-27 Thread Fabio Estevam
-off-by: Loic Poulain Great improvement, thanks: Reviewed-by: Fabio Estevam

Re: [PATCH v1] gpio: adp5585: add gpio driver for ADP5585 I/O Expander Controller

2022-09-27 Thread Fabio Estevam
Hi Alice, On Tue, Sep 6, 2022 at 6:37 AM Alice Guo (OSS) wrote: > > From: Alice Guo Please add a commit log. > Signed-off-by: Alice Guo > --- a/arch/arm/include/asm/arch-imx9/gpio.h > +++ b/arch/arm/include/asm/arch-imx9/gpio.h > @@ -6,6 +6,8 @@ > #ifndef __ASM_ARCH_IMX9_GPIO_H > #define

Re: [PATCH 4/4] ARM: dts: imx8m: imx8mm-mx8menlo: Enable SPL SDP support

2022-09-26 Thread Fabio Estevam
Hi Adam, On Mon, Sep 26, 2022 at 2:07 PM Adam Ford wrote: > Tim, > > I have it building successfully now, and it loads over USB. I had to > disable BD718x7 PMIC children binding which required a small change to > the PMIC driver [1]. I then removed HS400, HS200 and UHS support in > SPL. Once

[PATCH 4/4] clk-imx8mm: Only build QSPI clocks when CONFIG_NXP_FSPI=y

2022-09-26 Thread Fabio Estevam
The QSPI clocks are only used when CONFIG_NXP_FSPI=y, so only build the QSPI clocks in this case to reduce the final SPL binary size. Signed-off-by: Fabio Estevam --- drivers/clk/imx/clk-imx8mm.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/clk/imx

[PATCH 3/4] clk-imx8mm: Only build ecspi clocks when CONFIG_DM_SPI=y

2022-09-26 Thread Fabio Estevam
The ecspi clocks are only used when CONFIG_DM_SPI=y, so only build the ecspi clocks in this case to reduce the final SPL binary size. Signed-off-by: Fabio Estevam --- drivers/clk/imx/clk-imx8mm.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git

[PATCH 2/4] clk-imx8mm: Move CLK_ENET_AXI to the non-SPL section

2022-09-26 Thread Fabio Estevam
Ethernet is not used inside SPL, so move the IMX8MM_CLK_ENET_AXI clock inside the non-SPL block to reduce the final SPL binary size. Signed-off-by: Fabio Estevam --- drivers/clk/imx/clk-imx8mm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/imx/clk

[PATCH 1/4] clk-imx8mm: Only build PWM clocks in non-SPL code

2022-09-26 Thread Fabio Estevam
PWM is not used inside SPL, so do not define the PWM clocks inside SPL to reduce the final SPL binary size. Signed-off-by: Fabio Estevam --- drivers/clk/imx/clk-imx8mm.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/drivers/clk/imx/clk

[PATCH 0/4] clk-imx8mm: Reduce SPL binary size

2022-09-26 Thread Fabio Estevam
DEFAULT1 imx8mm_clk_probe Total reduction: 4100 - 3316 = 784 bytes. Fabio Estevam (4): clk-imx8mm: Only build PWM clocks in non-SPL code clk-imx8mm: Move CLK_ENET_AXI to the non-SPL section clk-imx8mm: Only build ecspi clocks when CONFIG_DM_SPI=y clk-imx8mm: Only build QSPI clocks when

Re: [PATCH] dm: doc: Fix serial howto u-boot,dm-pre-reloc typo

2022-09-25 Thread Fabio Estevam
Hi Michal, On 25/09/2022 10:28, Michal Suchanek wrote: In a couple of places the document says u-boot,pre-reloc but all examples show u-boot,dm-pre-reloc, use the latter consistently. Signed-off-by: Michal Suchanek Reviewed-by: Fabio Estevam

Re: [PATCH 2/2] imx8mm_evk: Add Serial Download Protocol support

2022-09-21 Thread Fabio Estevam
Hi Peng, On Wed, Sep 21, 2022 at 2:25 AM Peng Fan wrote: > I am not sure, the master branch has this issue? Any specific config > option required? Yes, to reproduce this issue on U-Boot master, just need to apply this series plus Marek's fix:

Re: [PATCH v1] verdin-imx8mm: verdin-imx8mp: drop obsolete net/phy configs

2022-09-21 Thread Fabio Estevam
Hi Marcel, On Wed, Sep 21, 2022 at 8:34 AM Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > Drop obsolete networking/PHY related configuration defines. > > Signed-off-by: Marcel Ziswiler Reviewed-by: Fabio Estevam

Re: [PATCH] kontron-sl-mx8mm: Let CONFIG_SPL_FIT_IMAGE_TINY be selected

2022-09-20 Thread Fabio Estevam
Hi Stefano and Tom, On Wed, Aug 24, 2022 at 7:09 AM Frieder Schrempf wrote: > > Hi Fabio, > > Am 24.08.22 um 03:09 schrieb Fabio Estevam: > > When CONFIG_IMX_HAB is selected the 'hab_status' command reports several > > error events, indicating that the BootROM failed

Re: [PATCH] mx8m: csf.sh: Fix the calculation of fit_block_size

2022-09-20 Thread Fabio Estevam
Hi Stefano and Tom, On Sun, Aug 14, 2022 at 2:25 PM Marek Vasut wrote: > > On 8/13/22 14:03, Fabio Estevam wrote: > > From: Fabio Estevam > > > > When running the script to sign SPL/U-Boot on a kontron-sl-mx8mm board, > > the fit_block_size was calculat

Re: [PATCH 2/2] board: tbs2910: Add serial rx buffer in defconfig

2022-09-20 Thread Fabio Estevam
serial console processing. > > Signed-off-by: Soeren Moch Reviewed-by: Fabio Estevam

Re: [PATCH 1/2] board: tbs2910: Set all board dts files as maintained

2022-09-20 Thread Fabio Estevam
On Tue, Sep 20, 2022 at 1:05 PM Soeren Moch wrote: > > This also includes the imx6q-tbs2910-u-boot.dtsi file now. > > Signed-off-by: Soeren Moch Reviewed-by: Fabio Estevam

Re: [PATCH] gpio: uclass: Introduce gpio-hog-optional property

2022-09-20 Thread Fabio Estevam
Hi Nate, On Wed, Sep 14, 2022 at 11:31 AM Nate Drude wrote: > Thanks for the discussion and feedback. I prefer to avoid changing the > bindings in Linux if possible. > > Would it be acceptable if I rework gpio_hog_probe_all so that it prints > an error "Failed to probe device..." if any

Re: [PATCH 2/2] imx8mm_evk: Add Serial Download Protocol support

2022-09-20 Thread Fabio Estevam
hance to debug yet is that running 'ums 0 mmc 1' works only when issued for the first time. If I interrupt with CRLC+C and then launch 'ums 0 mmc 1' again, it does not work. This is unrelated to SDP and happens when I boot from SD card as well. If you have any ideas, please let me know. Thanks, Fabio Estevam

[PATCH 2/2] imx8mm_evk: Add Serial Download Protocol support

2022-09-19 Thread Fabio Estevam
-mx8menlo board. Also, to fit the SPL binary into the internal RAM, select CONFIG_LTO to reduce its size. Signed-off-by: Fabio Estevam --- arch/arm/dts/imx8mm-evk-u-boot.dtsi | 16 configs/imx8mm_evk_defconfig| 21 + 2 files changed, 37 insertions

[PATCH 1/2] imx8mm_evk: Add an entry for USB boot

2022-09-19 Thread Fabio Estevam
Add an entry for USB boot so that U-Boot could be loaded via the Serial Download Protocol. Signed-off-by: Fabio Estevam --- board/freescale/imx8mm_evk/spl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/board/freescale/imx8mm_evk/spl.c b/board/freescale/imx8mm_evk/spl.c index e2eb1426c8

Re: [PATCH] usb: Add missing guard around env_get() in usb_hub

2022-09-19 Thread Fabio Estevam
x8mm-evk SDP SPL support, thanks: Tested-by: Fabio Estevam

Re: [PATCH 4/4] ARM: dts: imx8m: imx8mm-mx8menlo: Enable SPL SDP support

2022-09-19 Thread Fabio Estevam
as follows: $ uuu -brun spl flash.bin Signed-off-by: Marek Vasut This is great, I was able to test SPL SDP on an imx8mm-evk after applying these same changes to imx8mm-evk and reducing the SPL size. For the series: Reviewed-by: Fabio Estevam

Re: [PATCH V5] bsh: imx6ulz_smm_m2: Add imx6ulz BSH SMM M2 boards

2022-09-18 Thread Fabio Estevam
BOTG1 peripheral - fastboot. > > Signed-off-by: Michael Trimarchi Reviewed-by: Fabio Estevam

[PATCH v2] usb: Kconfig: Fix typo in SPL_DM_USB text

2022-09-17 Thread Fabio Estevam
Change a typo in "USB host mode". Signed-off-by: Fabio Estevam --- Changes since v1: - most->mode (Marek). drivers/usb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig index fd13cf31b5..3afb45d5cc 100644 ---

Re: [PATCH V2] Kconfig: enlarge CONFIG_SYS_MALLOC_F_LEN

2022-09-15 Thread Fabio Estevam
_SYS_MALLOC_F_LEN as 0x2000. > > Reported-by: Heiko Thiery > Signed-off-by: Peng Fan Thanks for addressing this issue at an SoC level: Reviewed-by: Fabio Estevam

[PATCH] usb: Kconfig: Fix typo in SPL_DM_USB text

2022-09-14 Thread Fabio Estevam
From: Fabio Estevam There is an extra "most" word in the SPL_DM_USB text that makes it confusing. Remove it. Signed-off-by: Fabio Estevam --- drivers/usb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig index fd

Re: [PATCH] gpio: uclass: Introduce gpio-hog-optional property

2022-09-14 Thread Fabio Estevam
Hi Nate, On Wed, Sep 14, 2022 at 11:00 AM Nate Drude wrote: > An alternate approach is to modify the default behavior so that > gpio_hog_probe_all will not trigger a fatal error. Do you think this is > better? IMHO that would be better, as we could keep using the same devicetree files from

Re: [PATCH] imx8mq_evk: enlarge SYS_MALLOC_F_LEN

2022-09-14 Thread Fabio Estevam
On Wed, Sep 14, 2022 at 1:12 AM Heiko Thiery wrote: > When changing these values on the kontron_pitx_imx8m_defconfig this > board also works again. > Maybe it could be a good idea to change these values for all imx8mq boards. Yes, agreed. It would be great if someone could align these values

Re: [PATCH] kontron_pitx_imx8m: enlarge SYS_MALLOC_F_LEN

2022-09-14 Thread Fabio Estevam
K=2400 > > It is because CONFIG_SYS_MALLOC_F_LEN is too small, enlarge it. And set > CONFIG_SPL_STACK to 0x188000 to not waste the top 16bytes. > > Signed-off-by: Heiko Thiery Reviewed-by: Fabio Estevam

Re: [PATCH] gpio: uclass: Introduce gpio-hog-optional property

2022-09-12 Thread Fabio Estevam
Hi Nate and Simon, On Mon, Sep 12, 2022 at 2:55 PM Nate Drude wrote: > > gpio_hog_probe_all is invoked by init_sequence_r in board_r.c. > If device_probe fails for any gpio-hog, boot hangs with the following error: > > > initcall sequence fffc8e18 failed at call 4023b320 > >

Re: [PATCH] board: gateworks: venice: update GW74xx PMIC config

2022-09-08 Thread Fabio Estevam
Hi Tim, On Thu, Sep 8, 2022 at 5:40 PM Tim Harvey wrote: > > Update the GW74xx PMIC configuration. Please explain why you are doing this change.

Re: [PATCH v4 2/2] serial: mxc: have putc use the TXFIFO

2022-09-06 Thread Fabio Estevam
of UTS_TXEMPTY Signed-off-by: Johannes Schneider Reviewed-by: Peng Fan Reviewed-by: Fabio Estevam

Re: [PATCH v4 1/2] serial: mxc: enable the RX pipeline

2022-09-06 Thread Fabio Estevam
readl(>cr3) | UCR3_RXDMUXSEL, >cr3); + Nitpick: the recommended style for multi-line comments is: /* * Setting the baudrate triggers a reset, returning cr3 to its * reset value but UCR3_RXDMUXSEL "should always be set." * according to the imx8 reference-manual. */ Reviewed-by: Fabio Estevam

Re: [PATCH v2 1/2] serial: mxc: enable the RX pipeline

2022-09-05 Thread Fabio Estevam
On Mon, Sep 5, 2022 at 10:43 PM Tom Rini wrote: > We allow '//' style comments, just like the linux kernel does these > days. There should be a space before the "imx8" in the first hunk here. Yes, // style comments are allowed, but for consistency with the other comments in this file, it would

Re: [PATCH v1 0/2] serial_mxc: fixing reception

2022-09-05 Thread Fabio Estevam
Hi Andrey, On Mon, Sep 5, 2022 at 6:21 AM ZHIZHIKIN Andrey wrote: > I cannot modify this part since removing you from maintainer list would > require a transfer of maintainership of this component to another name, > which I do not know. > > I've Cc:'d Tom and people from imx world here so they

<    5   6   7   8   9   10   11   12   13   14   >