[u-boot][PATCH v3 1/4] dm: memory: Introduce new uclass

2022-10-20 Thread Roger Quadros
Introduce UCLASS_MEMORY for future Memory Controller device drivers. Signed-off-by: Roger Quadros Reviewed-by: Simon Glass --- arch/sandbox/dts/test.dts | 4 drivers/memory/Kconfig | 17 + drivers/memory/Makefile | 2 ++ drivers/memory/memory

[u-boot][PATCH v3 0/4] Introduce MEMORY uclass and TI GPMC driver

2022-10-20 Thread Roger Quadros
: - Introduce MEMORY uclass Roger Quadros (4): dm: memory: Introduce new uclass scripts: Makefile.spl: Enable memory drivers to be built for SPL dt/bindings: memory: Add bindings for TI GPMC driver memory: Add TI GPMC driver arch/sandbox/dts/test.dts |4 + common/spl/Kconfig

Re: [u-boot][PATCH v2 2/4] scripts: Makefile.spl: Enable memory drivers to be built for SPL

2022-10-20 Thread Roger Quadros
Hi Tom, On 19/10/2022 15:54, Tom Rini wrote: > On Wed, Oct 19, 2022 at 11:17:35AM +0300, Roger Quadros wrote: >> >> >> On 18/10/2022 20:40, Tom Rini wrote: >>> On Thu, Oct 06, 2022 at 04:23:58PM +0300, Roger Quadros wrote: >>>> We will need ti-gpmc dr

Re: [u-boot][PATCH v2 2/4] scripts: Makefile.spl: Enable memory drivers to be built for SPL

2022-10-19 Thread Roger Quadros
On 18/10/2022 20:40, Tom Rini wrote: > On Thu, Oct 06, 2022 at 04:23:58PM +0300, Roger Quadros wrote: >> We will need ti-gpmc driver for SPL. Allow memory drivers >> do be built for SPL. >> >> Signed-off-by: Roger Quadros >> --- >> scripts/Makefile.sp

Re: [u-boot][PATCH 04/14] mtd: rawnand: omap_gpmc: Optimize NAND reads

2022-10-17 Thread Roger Quadros
Hi Michael, On 17/10/2022 09:39, Michael Nazzareno Trimarchi wrote: > Hi Roger > > On Sat, Oct 15, 2022 at 3:29 PM Roger Quadros wrote: >> >> Hi Michael, >> >> On 15/10/2022 10:24, Michael Nazzareno Trimarchi wrote: >>> Hi >>> >&

Re: [u-boot][PATCH 04/14] mtd: rawnand: omap_gpmc: Optimize NAND reads

2022-10-15 Thread Roger Quadros
Hi Michael, On 15/10/2022 10:24, Michael Nazzareno Trimarchi wrote: > Hi > > On Tue, Oct 11, 2022 at 1:50 PM Roger Quadros wrote: >> >> Rename omap_nand_read() to omap_nand_read_buf() to reflect >> actual behaviour. >> >> Use FIFO read addres

Re: [u-boot][PATCH 10/14] mtd: rawnand: omap_gpmc: support u-boot driver model

2022-10-13 Thread Roger Quadros
On 13/10/2022 14:17, Adam Ford wrote: > On Wed, Oct 12, 2022 at 6:42 AM Adam Ford wrote: >> >> On Wed, Oct 12, 2022 at 1:22 AM Roger Quadros wrote: >>> >>> Hi Adam, >>> >>> On 11/10/2022 18:01, Adam Ford wrote: >>>> On Tue, Oct 11

Re: [u-boot][PATCH 10/14] mtd: rawnand: omap_gpmc: support u-boot driver model

2022-10-12 Thread Roger Quadros
Hi Adam, On 11/10/2022 18:01, Adam Ford wrote: > On Tue, Oct 11, 2022 at 6:52 AM Roger Quadros wrote: >> >> Adds driver model support. >> >> We need to be able to self initialize the NAND controller/chip >> at probe and so enable CONFIG_SYS_NAND_SELF_INIT. >

[u-boot][PATCH 14/14] mtd: rawnand: omap_elm: u-boot driver model support

2022-10-11 Thread Roger Quadros
Support u-boot driver model. We still retain support legacy way of doing things if ELM_BASE is defined in We could completely get rid of that if all platforms defining ELM_BASE get rid of that definition and enable CONFIG_SYS_NAND_SELF_INIT and are verified to work. Signed-off-by: Roger Quadros

[u-boot][PATCH 13/14] dt-bindings: mtd: Add ti, elm DT binding documentation

2022-10-11 Thread Roger Quadros
Adds DT binding documentation for the TI Error Location Module. This is picked up from the Linux Kernel. Signed-off-by: Roger Quadros --- doc/device-tree-bindings/mtd/ti,elm.yaml | 72 1 file changed, 72 insertions(+) create mode 100644 doc/device-tree-bindings/mtd/ti

[u-boot][PATCH 11/14] mtd: rawnand: omap_gpmc: Add SPL NAND support

2022-10-11 Thread Roger Quadros
Enables SPL NAND support for ARCH_K3 by enabling SPL_NAND_INIT and SPL_SYS_NAND_SELF_INIT. Legacy OMAP2plus platforms still rely on SPL_NAND_AM33XX_BCH instead. Signed-off-by: Roger Quadros --- drivers/mtd/nand/raw/Kconfig | 5 drivers/mtd/nand/raw/Makefile| 2 +- drivers/mtd

[u-boot][PATCH 12/14] mtd: rawnand: omap_gpmc: Enable SYS_NAND_PAGE_COUNT for OMAP_GPMC

2022-10-11 Thread Roger Quadros
The symbol is required for NAND support in SPL when using OMAP_GPMC driver. Signed-off-by: Roger Quadros --- drivers/mtd/nand/raw/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig index b803759166

[u-boot][PATCH 09/14] dt-bindings: mtd: Add ti, gpmc-nand DT binding documentation

2022-10-11 Thread Roger Quadros
Add DT binding documentation for the TI GPMC NAND controller. This is picked up from the Linux Kernel. Signed-off-by: Roger Quadros --- .../mtd/ti,gpmc-nand.yaml | 129 ++ 1 file changed, 129 insertions(+) create mode 100644 doc/device-tree-bindings/mtd/ti

[u-boot][PATCH 10/14] mtd: rawnand: omap_gpmc: support u-boot driver model

2022-10-11 Thread Roger Quadros
provides nand_init() so we need to get rid of nand_init() in omap_gpmc driver if CONFIG_SPL_NAND_INIT is set. Signed-off-by: Roger Quadros --- drivers/mtd/nand/raw/Kconfig | 1 + drivers/mtd/nand/raw/omap_gpmc.c | 55 +++- 2 files changed, 55 insertions(+), 1 deletion

[u-boot][PATCH 08/14] mtd: rawnand: omap_gpmc: Reduce .bss usage

2022-10-11 Thread Roger Quadros
Allocate omap_ecclayout on the heap as we have limited .bss space on AM64 R5 SPL configuration. Reduces .bss usage by 2984 bytes. Signed-off-by: Roger Quadros --- drivers/mtd/nand/raw/omap_gpmc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/raw

[u-boot][PATCH 05/14] mtd: rawnand: omap_gpmc: Fix BCH6/16 HW based correction

2022-10-11 Thread Roger Quadros
The BCH detection hardware can generate ECC bytes for multiple sectors in one go. Use that feature. correct() only corrects one sector at a time so we need to call it repeatedly for each sector. Signed-off-by: Roger Quadros --- drivers/mtd/nand/raw/omap_gpmc.c | 325

[u-boot][PATCH 07/14] mtd: rawnand: nand_spl_loaders: Fix cast type build warning

2022-10-11 Thread Roger Quadros
Fixes the below build warning on 64-bit platforms. drivers/mtd/nand/raw/nand_spl_loaders.c:26:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] dst = (void *)((int)dst - page_offset); Signed-off-by: Roger Quadros --- drivers/mtd/nand/raw

[u-boot][PATCH 06/14] mtd: rawnand: nand_base: Allow base driver to be used in SPL without nand_bbt

2022-10-11 Thread Roger Quadros
nand_bbt.c is not being built with the nand_base driver during SPL build. This results in build failures if we try to access any nand_bbt related functions. Don't use any nand_bbt functions for SPL build. Signed-off-by: Roger Quadros --- drivers/mtd/nand/raw/nand_base.c | 18

[u-boot][PATCH 04/14] mtd: rawnand: omap_gpmc: Optimize NAND reads

2022-10-11 Thread Roger Quadros
efficient reads. Signed-off-by: Roger Quadros --- drivers/mtd/nand/raw/omap_gpmc.c | 49 ++-- 1 file changed, 28 insertions(+), 21 deletions(-) diff --git a/drivers/mtd/nand/raw/omap_gpmc.c b/drivers/mtd/nand/raw/omap_gpmc.c index d62c3e6fce..b36fe762b3 100644 --- a/drivers

[u-boot][PATCH 03/14] mtd: rawnand: omap_gpmc: Fix build warning on 64-bit platforms

2022-10-11 Thread Roger Quadros
-off-by: Roger Quadros --- drivers/mtd/nand/raw/omap_gpmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/raw/omap_gpmc.c b/drivers/mtd/nand/raw/omap_gpmc.c index 7e9ccf7878..d62c3e6fce 100644 --- a/drivers/mtd/nand/raw/omap_gpmc.c +++ b/drivers/mtd/nand

[u-boot][PATCH 02/14] mtd: rawnand: omap_gpmc: Enable build for K2/K3 platforms

2022-10-11 Thread Roger Quadros
The GPMC module is present on some K2 and K3 SoCs. Enable building GPMC NAND driver for K2/K3 platforms. Signed-off-by: Roger Quadros --- drivers/mtd/nand/raw/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig

[u-boot][PATCH 01/14] mtd: rawnand: omap_gpmc: Deprecate asm/arch/mem.h

2022-10-11 Thread Roger Quadros
We want to get rid of so don't enforce it for new platforms. This also means GPMC_MAX CS doesn't have to be defined by platform code. Define it locally here for now. Signed-off-by: Roger Quadros --- drivers/mtd/nand/raw/omap_gpmc.c | 8 1 file changed, 8 insertions(+) diff --git

[u-boot][PATCH 00/14] rawnand: omap_gpmc: driver model support

2022-10-11 Thread Roger Quadros
Hi, This series adds driver model support for rawnand: omap_gpmc and omap_elm drivers. This will enable the driver to be used on K2/K3 platforms as well. cheers, -roger Roger Quadros (14): mtd: rawnand: omap_gpmc: Deprecate asm/arch/mem.h mtd: rawnand: omap_gpmc: Enable build for K2/K3

Re: [u-boot][PATCH] spl: spl_legacy: Fix NAND boot on OMAP3 BeagleBoard

2022-10-10 Thread Roger Quadros
+Dario On 29/09/2022 13:11, Roger Quadros wrote: > OMAP3 BeagleBoard NAND boot hangs when spl_load_legacy_img() tries > to read the header into 'struct hdr' which is allocated on the > stack. > > As the header has already been read once before by spl_nand.c, > we can avoid the

Re: [u-boot][PATCH] mtd: nand: Fix SPL build after migration of CONFIG_SYS_NAND_SELF_INIT to Kconfig

2022-10-06 Thread Roger Quadros
Hello Michael, On 29/09/2022 09:08, Michael Nazzareno Trimarchi wrote: > Hi > > Il mer 28 set 2022, 13:42 Roger Quadros <mailto:rog...@kernel.org>> ha scritto: > > This fixes the below build error if nand.c is included in > an SPL build. > >

[u-boot][PATCH v2 4/4] memory: Add TI GPMC driver

2022-10-06 Thread Roger Quadros
on the settings specified in the Device tree and then probe its children. Signed-off-by: Roger Quadros --- drivers/memory/Kconfig| 19 + drivers/memory/Makefile |1 + drivers/memory/ti-gpmc.c | 1240 + drivers/memory/ti-gpmc.h | 298

[u-boot][PATCH v2 3/4] dt/bindings: memory: Add bindings for TI GPMC driver

2022-10-06 Thread Roger Quadros
multiple devices on the bus, each device is represented as a child and the respective GPMC settings are situated there. (see ti,gpmc-child.yaml) These binding docs are picked up from the Linux kernel. Signed-off-by: Roger Quadros --- .../memory/ti,gpmc-child.yaml | 252

[u-boot][PATCH v2 1/4] dm: memory: Introduce new uclass

2022-10-06 Thread Roger Quadros
Introduce UCLASS_MEMORY for future Memory Controller device drivers. Signed-off-by: Roger Quadros --- arch/sandbox/dts/test.dts | 4 drivers/memory/Kconfig | 17 + drivers/memory/Makefile | 2 ++ drivers/memory/memory-sandbox.c | 18

[u-boot][PATCH v2 2/4] scripts: Makefile.spl: Enable memory drivers to be built for SPL

2022-10-06 Thread Roger Quadros
We will need ti-gpmc driver for SPL. Allow memory drivers do be built for SPL. Signed-off-by: Roger Quadros --- scripts/Makefile.spl | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl index 3bafeb4fe9..110076b22f 100644 --- a/scripts/Makefile.spl

[u-boot][PATCH v2 0/4] Introduce MEMORY uclass and TI GPMC driver

2022-10-06 Thread Roger Quadros
on the settings specified in the Device tree and then probe its children. Roger Quadros (4): dm: memory: Introduce new uclass scripts: Makefile.spl: Enable memory drivers to be built for SPL dt/bindings: memory: Add bindings for TI GPMC driver memory: Add TI GPMC driver arch/sandbox/dts/test.dts

Re: [u-boot][PATCH 1/3] scripts: Makefile.spl: Enable memory drivers to be built for SPL

2022-10-01 Thread Roger Quadros
Hi, On 01/10/2022 02:48, Simon Glass wrote: > Hi, > > On Fri, 30 Sept 2022 at 14:18, Roger Quadros wrote: >> >> On 30/09/2022 17:00, Tom Rini wrote: >>> On Fri, Sep 30, 2022 at 07:28:51AM -0600, Simon Glass wrote: >>>> Hi Roger, >>>> &g

Re: [u-boot][PATCH 1/3] scripts: Makefile.spl: Enable memory drivers to be built for SPL

2022-09-30 Thread Roger Quadros
On 30/09/2022 17:00, Tom Rini wrote: > On Fri, Sep 30, 2022 at 07:28:51AM -0600, Simon Glass wrote: >> Hi Roger, >> >> On Fri, 30 Sept 2022 at 06:47, Roger Quadros wrote: >>> >>> Simon, >>> >>> On 29/09/2022 21:06, Simon Glass wrote: >

Re: [u-boot][PATCH 1/3] scripts: Makefile.spl: Enable memory drivers to be built for SPL

2022-09-30 Thread Roger Quadros
Simon, On 29/09/2022 21:06, Simon Glass wrote: > Hi Roger, > > On Thu, 29 Sept 2022 at 01:03, Roger Quadros wrote: >> >> Hi Simon, >> >> On 28/09/2022 19:27, Simon Glass wrote: >>> Hi Roger, >>> >>> On Wed, 28 Sept 2022 at 06:12,

Re: [u-boot][PATCH 0/3] Introduce TI GPMC memory controller driver

2022-09-30 Thread Roger Quadros
Hi Tom, On 29/09/2022 20:51, Tom Rini wrote: > On Wed, Sep 28, 2022 at 03:11:46PM +0300, Roger Quadros wrote: > >> Hi, >> >> The GPMC is a unified memory controller dedicated for interfacing >> with external memory devices like >> - Asynchronous SRAM-like m

[u-boot][PATCH] spl: spl_legacy: Fix NAND boot on OMAP3 BeagleBoard

2022-09-29 Thread Roger Quadros
. This fixes NAND boot on OMAP3 BeagleBoard. Signed-off-by: Roger Quadros --- common/spl/spl_legacy.c | 19 --- common/spl/spl_nand.c | 2 +- common/spl/spl_nor.c| 6 +- include/spl.h | 7 +-- 4 files changed, 19 insertions(+), 15 deletions(-) diff --git

Re: [u-boot][PATCH 1/3] scripts: Makefile.spl: Enable memory drivers to be built for SPL

2022-09-29 Thread Roger Quadros
Hi Simon, On 28/09/2022 19:27, Simon Glass wrote: > Hi Roger, > > On Wed, 28 Sept 2022 at 06:12, Roger Quadros wrote: >> >> We will need ti-gpmc driver for SPL. Allow memory drivers >> do be built for SPL. >> >> Signed-off-by: Roger Quadros >>

[u-boot][PATCH 3/3] memory: Add TI GPMC driver

2022-09-28 Thread Roger Quadros
on the settings specified in the Device tree and then probe its children. Signed-off-by: Roger Quadros --- drivers/memory/Kconfig| 16 + drivers/memory/Makefile |1 + drivers/memory/ti-gpmc.c | 1237 + drivers/memory/ti-gpmc.h | 298

[u-boot][PATCH 2/3] dt/bindings: memory: Add bindings for TI GPMC driver

2022-09-28 Thread Roger Quadros
multiple devices on the bus, each device is represented as a child and the respective GPMC settings are situated there. (see ti,gpmc-child.yaml) These binding docs are picked up from the Linux kernel. Signed-off-by: Roger Quadros --- .../memory/ti,gpmc-child.yaml | 252

[u-boot][PATCH 1/3] scripts: Makefile.spl: Enable memory drivers to be built for SPL

2022-09-28 Thread Roger Quadros
We will need ti-gpmc driver for SPL. Allow memory drivers do be built for SPL. Signed-off-by: Roger Quadros --- scripts/Makefile.spl | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl index 3bafeb4fe9..110076b22f 100644 --- a/scripts/Makefile.spl

[u-boot][PATCH 0/3] Introduce TI GPMC memory controller driver

2022-09-28 Thread Roger Quadros
the GPMC based on the settings specified in the Device tree and then probe its children. cheers, -roger Roger Quadros (3): scripts: Makefile.spl: Enable memory drivers to be built for SPL dt/bindings: memory: Add bindings for TI GPMC driver memory: Add TI GPMC driver .../memory/ti,gpmc

[u-boot][PATCH] mtd: nand: Fix SPL build after migration of CONFIG_SYS_NAND_SELF_INIT to Kconfig

2022-09-28 Thread Roger Quadros
mean ‘base_addr’? 84 | ulong base_addr = base_address[i]; |^~~~ |base_addr Fixes: 068c41f1cc77 ("Finish conversion CONFIG_SYS_NAND_SELF_INIT to Kconfig") Signed-off-by: Roger Quadros --- drivers/mtd/nand/raw/nand.c | 2

Re: [PATCH RFC v3 10/11] ti: dtsi: j721e: Use binman to package tispl.bin

2022-06-15 Thread Roger Quadros
On 15/06/2022 09:48, Neha Malcom Francis wrote: > tispl.bin must be packaged (with ATF, OPTEE, DM and A72 SPL) for J721E. > Binman picks up and packages entries according to the > description given in the device tree. > > k3-j721e-a72-binman.dtsi has been introduced for A72 specific binman >

Re: [PATCH RFC v3 10/11] ti: dtsi: j721e: Use binman to package tispl.bin

2022-06-15 Thread Roger Quadros
Neha, On 15/06/2022 09:48, Neha Malcom Francis wrote: > tispl.bin must be packaged (with ATF, OPTEE, DM and A72 SPL) for J721E. > Binman picks up and packages entries according to the > description given in the device tree. > > k3-j721e-a72-binman.dtsi has been introduced for A72 specific binman

Re: [PATCH RFC v3 08/11] ti: j721e: Exclude makefile tispl.bin target for J721E

2022-06-15 Thread Roger Quadros
Hi Neha, On 15/06/2022 09:48, Neha Malcom Francis wrote: > tispl.bin is to be packaged (with ATF, OPTEE, DM and A72 SPL) using > binman. The tispl.bin target from the makefile is no longer needed for > J721E. > > Signed-off-by: Neha Malcom Francis > --- > arch/arm/mach-k3/config.mk | 5 + >

Re: [u-boot PATCH 2/3] tools/fdtgrep: Include __symbols__ table

2022-06-11 Thread Roger Quadros
On 10/06/2022 16:42, Tom Rini wrote: > On Mon, May 09, 2022 at 10:29:35AM +0300, Roger Quadros wrote: > >> This is required for overlays to work at SPL. >> >> Signed-off-by: Roger Quadros > > This breaks booting my dra7xx_evm and I get no output in SPL. >

Re: [PATCH RFC v2 11/11] ti: dtsi: j721e: Use binman to package tispl.bin

2022-06-03 Thread Roger Quadros
On 01/06/2022 15:47, Andrew Davis wrote: > On 6/1/22 5:55 AM, Roger Quadros wrote: >> >> >> On 01/06/2022 13:42, Neha Malcom Francis wrote: >>> Hi Roger, >>> >>> On 01/06/22 14:53, Roger Quadros wrote: >>>> Hi, >>>

Re: [PATCH RFC v2 11/11] ti: dtsi: j721e: Use binman to package tispl.bin

2022-06-01 Thread Roger Quadros
On 01/06/2022 13:42, Neha Malcom Francis wrote: > Hi Roger, > > On 01/06/22 14:53, Roger Quadros wrote: >> Hi, >> >> On 01/06/2022 09:08, Neha Malcom Francis wrote: >>> Hi Roger, >>> >>> On 31/05/22 16:32, Roger Quadros wrote: >>

Re: [PATCH RFC v2 05/11] ti: etype: x509: Add etype for x509 certificate for K3 devices

2022-06-01 Thread Roger Quadros
Neha, On 01/06/2022 12:48, Neha Malcom Francis wrote: > Hi Roger, > > On 01/06/22 14:54, Roger Quadros wrote: >> >> >> On 01/06/2022 09:02, Neha Malcom Francis wrote: >>> Hi Roger, >>> >>> On 31/05/22 14:50, Roger Quadros wrote: >>

Re: [PATCH RFC v2 03/11] ti: etype: sysfw: Add entry type for sysfw

2022-06-01 Thread Roger Quadros
On 01/06/2022 08:58, Neha Malcom Francis wrote: > Hi Roger, > > On 31/05/22 14:14, Roger Quadros wrote: >> >> >> On 06/05/2022 07:37, Neha Malcom Francis wrote: >>> For K3 devices that require a sysfw image, add entry for SYSFW. It can >> >> 'can

Re: [PATCH RFC v2 05/11] ti: etype: x509: Add etype for x509 certificate for K3 devices

2022-06-01 Thread Roger Quadros
On 01/06/2022 09:02, Neha Malcom Francis wrote: > Hi Roger, > > On 31/05/22 14:50, Roger Quadros wrote: >> >> >> On 06/05/2022 07:37, Neha Malcom Francis wrote: >>> K3 devices x509 certificate added to certain binaries that allows ROM to >> >&

Re: [PATCH RFC v2 11/11] ti: dtsi: j721e: Use binman to package tispl.bin

2022-06-01 Thread Roger Quadros
Hi, On 01/06/2022 09:08, Neha Malcom Francis wrote: > Hi Roger, > > On 31/05/22 16:32, Roger Quadros wrote: >> >> >> On 06/05/2022 07:37, Neha Malcom Francis wrote: >>> Explicit make commands were earlier used to generate tispl.bin image, >>> now it i

Re: [PATCH RFC v2 11/11] ti: dtsi: j721e: Use binman to package tispl.bin

2022-05-31 Thread Roger Quadros
On 06/05/2022 07:37, Neha Malcom Francis wrote: > Explicit make commands were earlier used to generate tispl.bin image, > now it is replaced using binman. > > Binman picks up and packages entries according to the description of > entries given in the binman node in the device tree. The make

Re: [PATCH RFC v2 09/11] ti: x509: Remove shell script used for signing

2022-05-31 Thread Roger Quadros
On 06/05/2022 07:37, Neha Malcom Francis wrote: > Earlier the k3_gen_x509_cert.sh was used for signing binaries with the > x509 certificate for Texas Instruments K3 architecture devices. Since > the signing process is handled by x509 etype now, there is no more > requirement for this script,

Re: [PATCH RFC v2 08/11] ti: tispl.bin: Removed script that packages tispl.bin

2022-05-31 Thread Roger Quadros
On 06/05/2022 07:37, Neha Malcom Francis wrote: > As tispl.bin is to be packaged (with ATF, OPTEE, DM and A72 SPL) using > binman, the shell script k3_fit_atf.sh is no longer needed. Removing This is not true until you have migrated all K3 platforms to use binman. So let's leave this script

Re: [PATCH RFC v2 07/11] ti: tiboot3.bin: Remove tiboot3.bin target from makefile

2022-05-31 Thread Roger Quadros
On 06/05/2022 07:37, Neha Malcom Francis wrote: > Intention of patch is to move the signing and packaging of tiboot3.bin > image to binman, thus removing target from makefile. > > Also deleting k3_gen_x509_cert.sh which was earlier used to sign a > binary associated with K3 devices with x509

Re: [PATCH RFC v2 05/11] ti: etype: x509: Add etype for x509 certificate for K3 devices

2022-05-31 Thread Roger Quadros
On 06/05/2022 07:37, Neha Malcom Francis wrote: > K3 devices x509 certificate added to certain binaries that allows ROM to what binaries? > validate the integrity of the image. Etype that generates an x509 > certificate depending on boot flow added. Could you please explain in more detail as

Re: [PATCH RFC v2 03/11] ti: etype: sysfw: Add entry type for sysfw

2022-05-31 Thread Roger Quadros
On 06/05/2022 07:37, Neha Malcom Francis wrote: > For K3 devices that require a sysfw image, add entry for SYSFW. It can 'can' or 'should'? For binman, 'sysfw' and 'dm' (added in patch 4) are just binary blobs. correct? Why can't you just use blob entry type? > contain system firmware image

Re: [PATCH RFC v2 00/11] Integration of sysfw, tispl and tiboot3

2022-05-31 Thread Roger Quadros
Hi, On 06/05/2022 07:37, Neha Malcom Francis wrote: > Devices that belong to the K3 architecture require SYSFW which is a FIT > image consisting of a signed system firmware image and board config > binaries. > > Board config binaries are needed to bring up SYSFW during U-Boot SPL > startup. The

Re: [u-boot PATCH 3/3] k3-am642-evm-u-boot: Use binman to generate u-boot.img and tispl.bin

2022-05-30 Thread Roger Quadros
Hi, On 27/05/2022 20:50, Alper Nebi Yasak wrote: > On 26/05/2022 17:15, Tom Rini wrote: >> On Thu, May 26, 2022 at 10:28:45AM +0300, Roger Quadros wrote: >>> Any thoughts on how to get the new ti-secure etype work with atf-bl31 and >>> tee-os etypes so that it can ta

Re: [u-boot PATCH 3/3] k3-am642-evm-u-boot: Use binman to generate u-boot.img and tispl.bin

2022-05-26 Thread Roger Quadros
On 25/05/2022 18:14, Andrew Davis wrote: > On 5/25/22 3:30 AM, Roger Quadros wrote: >> Hi Andrew, >> >> On 25/05/2022 01:03, Andrew Davis wrote: >>> On 5/9/22 2:29 AM, Roger Quadros wrote: >>>> Introduce k3-am642-evm-binman.dtsi to provide binman

Re: [u-boot PATCH 3/3] k3-am642-evm-u-boot: Use binman to generate u-boot.img and tispl.bin

2022-05-25 Thread Roger Quadros
Hi Andrew, On 25/05/2022 01:03, Andrew Davis wrote: > On 5/9/22 2:29 AM, Roger Quadros wrote: >> Introduce k3-am642-evm-binman.dtsi to provide binman configuration. >> >> R5 build is still not converted to use binman so restrict binman.dtsi >> to A53 builds only. >

[u-boot PATCH 3/3] k3-am642-evm-u-boot: Use binman to generate u-boot.img and tispl.bin

2022-05-09 Thread Roger Quadros
-by: Roger Quadros --- arch/arm/dts/k3-am642-evm-binman.dtsi | 230 ++ arch/arm/dts/k3-am642-evm-u-boot.dtsi | 3 + arch/arm/mach-k3/Kconfig | 1 + arch/arm/mach-k3/config.mk| 7 + 4 files changed, 241 insertions(+) create mode 100644 arch/arm

[u-boot PATCH 2/3] tools/fdtgrep: Include __symbols__ table

2022-05-09 Thread Roger Quadros
This is required for overlays to work at SPL. Signed-off-by: Roger Quadros --- tools/fdtgrep.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/fdtgrep.c b/tools/fdtgrep.c index 641d6a2e3e..d904f679ae 100644 --- a/tools/fdtgrep.c +++ b/tools/fdtgrep.c @@ -1230,6 +1230,10 @@ int

[u-boot PATCH 1/3] tools: binman: add ti-secure entry type

2022-05-09 Thread Roger Quadros
environment variable to secure the binaries. Signed-off-by: Roger Quadros --- Makefile| 1 + tools/binman/entries.rst| 15 tools/binman/etype/ti_secure.py | 59 + tools/binman/ftest.py | 7 tools

[u-boot PATCH 0/3] k3-am642-evm-u-boot: Use binman to generate u-boot.img and tispl.bin

2022-05-09 Thread Roger Quadros
Hi, This series introduces ti-secure entry type for binman. It switches from using custom tool tools/k3_fit_atf.sh to binman for generating boot images for AM64 for both HS and non-HS devices. cheers, -roger Roger Quadros (3): tools: binman: add ti-secure entry type tools/fdtgrep: Include

Re: [u-boot PATCH v2] binman: Add support for TEE BL32

2022-02-20 Thread Roger Quadros
On 20/02/2022 00:12, Simon Glass wrote: > On Sat, 19 Feb 2022 at 11:50, Roger Quadros wrote: >> >> Add an entry for OP-TEE Trusted OS 'BL32' payload. >> This is required by platforms using Cortex-A cores with TrustZone >> technology. >> >> Signed-off

[u-boot PATCH v2] binman: Add support for TEE BL32

2022-02-19 Thread Roger Quadros
Add an entry for OP-TEE Trusted OS 'BL32' payload. This is required by platforms using Cortex-A cores with TrustZone technology. Signed-off-by: Roger Quadros --- Changelog: v2: - use 'tee-os' for entry name instead of 'bl32' - use ${TEE} instead of ${BL32} for environment variable - Use next

Re: [u-boot][PATCH] binman: Add support for TEE BL32

2022-02-19 Thread Roger Quadros
Hi Simon, On 19/02/2022 17:24, Simon Glass wrote: > Hi Roger, > > On Sat, 5 Feb 2022 at 05:29, Roger Quadros wrote: >> >> Hi Simon, >> >> On 04/02/2022 19:17, Simon Glass wrote: >>> Hi Roger, >>> >>> On Fri, 4 Feb 2022 at 06:00, Roger

Re: [u-boot][PATCH] binman: Add support for TEE BL32

2022-02-05 Thread Roger Quadros
Hi Simon, On 04/02/2022 19:17, Simon Glass wrote: > Hi Roger, > > On Fri, 4 Feb 2022 at 06:00, Roger Quadros wrote: >> >> Add an entry for OP-TEE Trusted OS 'BL32' payload. >> This is required by platforms using Cortex-A cores with TrustZone >> technology. &

[u-boot][PATCH] binman: Add support for TEE BL32

2022-02-04 Thread Roger Quadros
Add an entry for OP-TEE Trusted OS 'BL32' payload. This is required by platforms using Cortex-A cores with TrustZone technology. Signed-off-by: Roger Quadros --- Makefile | 1 + tools/binman/entries.rst | 13 + tools/binman/etype/atf_bl32.py

[PATCH v2] ARM: dts: Fix node status to "okay" on TI boards

2021-08-24 Thread Roger Quadros
ee-org/devicetree-specification/releases/tag/v0.3 Signed-off-by: Roger Quadros --- Changelog: v2: - Updated commit message to refer to DT spec instead of schema. arch/arm/dts/am3517-evm-ui.dtsi | 4 ++-- arch/arm/dts/am3517-evm.dts | 2 +- arch/arm/dts/am437x-

Re: [PATCH] ARM: dts: Fix node status to "okay" on TI boards

2021-08-23 Thread Roger Quadros
Hi Lokesh, On 23/08/2021 09:23, Lokesh Vutla wrote: > Hi Roger, > > On 20/08/21 4:11 pm, Roger Quadros wrote: >> As per Device Tree core schema [1], status parameter of nodes can be either >> "okay" or "disabled". >> >> U-boot Driver Model

[PATCH] ARM: dts: Fix node status to "okay" on TI boards

2021-08-20 Thread Roger Quadros
As per Device Tree core schema [1], status parameter of nodes can be either "okay" or "disabled". U-boot Driver Model does not recognize status="ok" and treats the node as disabled. Signed-off-by: Roger Quadros --- arch/arm/dts/am3517-evm-ui.dtsi

Re: status="ok" treated as disabled by DM

2021-08-20 Thread Roger Quadros
On 19/08/2021 14:37, Nishanth Menon wrote: > On 14:03-20210819, Roger Quadros wrote: >> Hi, >> >> If the device tree node has status="ok" then the u-boot DM will treat the >> device as disabled. >> There are still quite many devices using "

status="ok" treated as disabled by DM

2021-08-19 Thread Roger Quadros
Hi, If the device tree node has status="ok" then the u-boot DM will treat the device as disabled. There are still quite many devices using "ok" instead of "okay" or no status and those devices will not be bound. What is the right fix? 1) make u-boot DM to treat satus="ok" as enabled. 2) fix

Re: [PATCH 0/3] usb: am654: Add support for host mode to the USB port on overlay board

2020-11-23 Thread Roger Quadros
to use USB 2.0 interface dts: am654-base-board-uboot: Set USB0 dr_mode to host dts: am654-base-board-uboot: Add aliases for USB subsystems For all patches, Acked-by: Roger Quadros arch/arm/dts/k3-am654-base-board-u-boot.dtsi | 4 +++- board/ti/am65x/evm.c

[u-boot PATCH] configs: am65/j72x: Set CONFIG_LOGLEVEL to 7

2020-10-30 Thread Roger Quadros
s_ver: 0x6BA00102 cpsw_ver: 0x6BA80102 ale_ver: 0x00293904 Ports:1 mdio_freq:100" Similar 8KB difference was seen on J721E. Signed-off-by: Roger Quadros Reviewed-by: Nishanth Menon --- configs/am65x_evm_a53_defconfig| 1 + configs/am65x_hs_evm_a53_defconfig | 1 + configs/j7200_evm_a72

Re: [PATCH v2 00/10] net: ti: icssg: Add prueth support

2020-10-26 Thread Roger Quadros
Hi Christian, On 26/10/2020 14:37, Christian Gmeiner wrote: Hi all Is there any update regarding this patch series? I am working on revising this driver. Once ready I will post the updated version upstream. cheers, -roger Am Do., 20. Feb. 2020 um 10:19 Uhr schrieb Keerthy : On

Re: [PATCH v5 04/10] usb: common: add define of usb_speed_string()

2020-08-17 Thread Roger Quadros
On 17/08/2020 10:51, Roger Quadros wrote: Hi, On 17/08/2020 10:40, Chunfeng Yun wrote: There is only declear of usb_speed_string(), but not define it. s/declear/declaration s/not define/no definition of/ Signed-off-by: Chunfeng Yun --- v5: no changes v4: new patch ---   drivers/usb

Re: [PATCH v5 04/10] usb: common: add define of usb_speed_string()

2020-08-17 Thread Roger Quadros
Hi, On 17/08/2020 10:40, Chunfeng Yun wrote: There is only declear of usb_speed_string(), but not define it. s/declear/declaration s/not define/no definition of/ Signed-off-by: Chunfeng Yun --- v5: no changes v4: new patch --- drivers/usb/common/common.c | 7 +++

[u-boot PATCH] phy: omap-usb2-phy: disable phy charger detect

2020-06-03 Thread Roger Quadros
to enable this workaround for AM654x PG1.0. Signed-off-by: Bin Liu Signed-off-by: Vignesh Raghavendra Signed-off-by: Roger Quadros --- drivers/phy/omap-usb2-phy.c | 33 - 1 file changed, 28 insertions(+), 5 deletions(-) diff --git a/drivers/phy/omap-usb2-phy.c b/d

[u-boot PATCH] board: ti: am57xx-idk: Prevent boot for invalid configuation

2020-02-10 Thread Roger Quadros
and was considered not worth the hassle. Signed-off-by: Roger Quadros Acked-by: Suman Anna --- board/ti/am57xx/board.c | 12 1 file changed, 12 insertions(+) diff --git a/board/ti/am57xx/board.c b/board/ti/am57xx/board.c index d70ab0c4d0..683d3aa8da 100644 --- a/board/ti/am57xx

[u-boot PATCH] arm: mach-k3: am6_init: Prioritize MSMC traffic over DDR in NAVSS Northbridge

2020-01-30 Thread Roger Quadros
to delays in MSMC transfers due to incorrect Northbridge configuration. Signed-off-by: Roger Quadros Acked-by: Andrew F. Davis Acked-by: Tomi Valkeinen Acked-by: Benoit Parrot --- arch/arm/mach-k3/am6_init.c | 14 ++ arch/arm/mach-k3/include/mach/am6_hardware.h | 7

[U-Boot] [uboot PATCH 1/4] phy: ti-pipe3: Use TRM recommended settings for SATA DPLL

2019-11-06 Thread Roger Quadros
setting. [1] - http://www.ti.com/lit/ug/spruhz6h/spruhz6h.pdf Signed-off-by: Roger Quadros --- drivers/phy/ti-pipe3-phy.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/phy/ti-pipe3-phy.c b/drivers/phy/ti-pipe3-phy.c index e7e78e3c56..f3b071399c 100644

[U-Boot] [uboot PATCH 2/4] phy: ti-pipe3: Introduce mode property in driver data

2019-11-06 Thread Roger Quadros
Introduce a mode property in the driver data so that we don't have to keep using "of_device_is_compatible()" throughtout the driver. No functional change. Signed-off-by: Roger Quadros --- drivers/phy/ti-pipe3-phy.c | 34 -- 1 file changed, 28 insert

[U-Boot] [uboot PATCH 3/4] phy: ti-pipe3: improve DPLL stability for SATA & USB

2019-11-06 Thread Roger Quadros
://www.ti.com/lit/ug/sprui30f/sprui30f.pdf Signed-off-by: Roger Quadros --- drivers/phy/ti-pipe3-phy.c | 193 + 1 file changed, 193 insertions(+) diff --git a/drivers/phy/ti-pipe3-phy.c b/drivers/phy/ti-pipe3-phy.c index 935dc7afb6..b9c8591470 100644

[U-Boot] [uboot PATCH 4/4] phy: ti-pipe3: Fix SATA & USB PHY power up sequence

2019-11-06 Thread Roger Quadros
As per "Table 26-7. SATA PHY Subsystem Low-Level Programming Sequence" in TRM [1] we need to turn on SATA_PHY_TX before SATA_PHY_RX. [1] DRA75x, DRA74x TRM - http://www.ti.com/lit/ug/sprui30f/sprui30f.pdf Signed-off-by: Roger Quadros --- drivers/phy/ti-pipe3-

[U-Boot] [uboot PATCH 0/4] phy: ti-pipe3: Match TRM sequence & settings

2019-11-06 Thread Roger Quadros
Hi, We need to follow the TRM sequence and settings to ensure that the DPLL & PHY operates correctly over the entire temperature range. Tested with SATA on dra7-evm. Since this is a bug fix, I will suggest to include it in current -rc. cheers, -roger Roger Quadros (4): phy: ti-pipe3:

Re: [U-Boot] [PATCH] usb: composite: add BOS descriptor support to composite framework

2019-10-25 Thread Roger Quadros
site framework. Signed-off-by: T Karthik Reddy Signed-off-by: Siva Durga Prasad Paladugu Signed-off-by: Michal Simek Reviewed-by: Roger Quadros ---   drivers/usb/gadget/composite.c | 61 ++   include/linux/usb/ch9.h    |  3 ++   include/linux/usb/gadg

Re: [U-Boot] [PATCH 00/14] net: ti: icssg: Add prueth support

2019-08-07 Thread Roger Quadros
On 07/08/2019 08:51, Roger Quadros wrote: > Andreas, > > On 06/08/2019 18:35, Andreas Dannenberg wrote: >> Keerthy, >> >> On Tue, Aug 06, 2019 at 04:08:30PM +0530, Keerthy wrote: >>> The series adds support for icssg_prueth functionality >>> on

Re: [U-Boot] [PATCH 00/14] net: ti: icssg: Add prueth support

2019-08-07 Thread Roger Quadros
Andreas, On 06/08/2019 18:35, Andreas Dannenberg wrote: > Keerthy, > > On Tue, Aug 06, 2019 at 04:08:30PM +0530, Keerthy wrote: >> The series adds support for icssg_prueth functionality >> on u-boot. This series is based on top of master branch. >> rproc init needs to be done from uboot command

Re: [U-Boot] U-Boot AM335x board.c `ethaddr` changes.

2017-11-28 Thread Roger Quadros
Duane, On 28/11/17 10:07, Duane Leslie wrote: > Roger, > > I’m not clear on the correct way to report bugs in U-Boot, but the change you > signed off in  > https://github.com/u-boot/u-boot/commit/f411b5cca48f0eee9443b85e7b75a46356bd2327 >  disabled the setting of the `ethaddr` environment

Re: [U-Boot] [PATCH] board: ks2: README: Update NAND wording

2017-08-10 Thread Roger Quadros
rather the GPMC for NAND. Therefore, > clarify some statements to indicate only certain devices have AEMIF and > in other places just say NAND instead of AEMIF NAND > > Signed-off-by: Franklin S Cooper Jr <fcoo...@ti.com> Acked-by: Roger Quadros <rog...@ti.com> > -

Re: [U-Boot] [u-boot PATCH v5 04/10] ti: common: board_detect: commodify ethaddr environment setting code

2017-03-15 Thread Roger Quadros
On 15/03/17 16:46, Felipe Balbi wrote: > > Hi, > > Roger Quadros <rog...@ti.com> writes: >>> On Tue, Mar 14, 2017 at 3:05 PM Roger Quadros <rog...@ti.com >>> <mailto:rog...@ti.com>> wrote: >>> >>> +void board_ti_se

Re: [U-Boot] [u-boot PATCH v5 04/10] ti: common: board_detect: commodify ethaddr environment setting code

2017-03-15 Thread Roger Quadros
Hi, On 14/03/17 17:54, Felipe Balbi wrote: > Hi, > > On Tue, Mar 14, 2017 at 3:05 PM Roger Quadros <rog...@ti.com > <mailto:rog...@ti.com>> wrote: > > +void board_ti_set_ethaddr(int index) > +{ > + uint8_t mac_addr[6]; > +

[U-Boot] [u-boot PATCH v5 04/10] ti: common: board_detect: commodify ethaddr environment setting code

2017-03-14 Thread Roger Quadros
Keystone and OMAP platforms will need this to set ethernet MAC addresses from board EEPROM. Signed-off-by: Roger Quadros <rog...@ti.com> Reviewed-by: Lokesh Vutla <lokeshvu...@ti.com> Reviewed-by: Tom Rini <tr...@konsulko.com> --- v5: - Set upto 50 MAC addresses if more th

Re: [U-Boot] [u-boot PATCH v4 04/10] ti: common: board_detect: commodify ethaddr environment setting code

2017-03-14 Thread Roger Quadros
On 13/03/17 15:15, Felipe Balbi wrote: > > Hi, > > Roger Quadros <rog...@ti.com> writes: >> +void board_ti_set_ethaddr(int index) >> +{ >> +uint8_t mac_addr[6]; >> +int i; >> +u64 mac1, mac2; >> +u8 mac_addr1[6], mac_addr2[

[U-Boot] [u-boot PATCH v4 00/10] am57xx-idk LCD and am571x-idk 6 port ethernet pinmux

2017-03-13 Thread Roger Quadros
Panel Roger Quadros (7): ARM: OMAP5+: GPIO: Add GPIO_TO_PIN() macro ti: common: board_detect: commodify ethaddr environment setting code board: ti: am571x-idk: Support 6 port Ethernet or 4 port Ethernet with LCD board: ti: am571x-idk: Update pinmux for ICSS2 Ethernet ARM: Use Kconfig

[U-Boot] [u-boot PATCH v4 05/10] board: ti: am571x-idk: Support 6 port Ethernet or 4 port Ethernet with LCD

2017-03-13 Thread Roger Quadros
ternal PHY's internall pull. - Do not use SLEW_CONTROLon any pin. Cc: Nishanth Menon <n...@ti.com> Signed-off-by: Roger Quadros <rog...@ti.com> Reviewed-by: Tom Rini <tr...@konsulko.com> Reviewed-by: Lokesh Vutla <lokeshvu...@ti.com> --- board/ti/am57xx/board.c| 4

[U-Boot] [u-boot PATCH v4 03/10] ti_armv7_keystone2: Define scratch space in SRAM

2017-03-13 Thread Roger Quadros
From: Franklin S Cooper Jr <fcoo...@ti.com> Scratch space can be used for features such as board detection. Define an area within SRAM that can be used for this purpose. [rog...@ti.com] Rename EEPROM macro Signed-off-by: Franklin S Cooper Jr <fcoo...@ti.com> Signed-off-by: Roger

<    1   2   3   4   5   6   >