[PATCH v2 14/32] bootm: Adjust position of unmap_sysmem() in boot_get_kernel()

2023-11-15 Thread Simon Glass
These unmaps should happen regardless of the return value. Move them before the 'return' statement. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to adjust position of unmap_sysmem() in boot_get_kernel() boot/bootm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH v2 13/32] bootm: Adjust boot_get_kernel() to return an error

2023-11-15 Thread Simon Glass
This function obtains lots of error codes and then throws them away. Update it to return the error, moving the image pointer to an argument. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- Changes in v2: - Use the command table to provide the command name, instead of "bootm&qu

[PATCH v2 12/32] image: Document error codes from fit_image_load()

2023-11-15 Thread Simon Glass
Put a list of these in the function documentation so it is easier to decode what went wrong. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- (no changes since v1) include/image.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/image.h b/include/image.h

[PATCH v2 11/32] bootm: Reduce arguments to boot_get_kernel()

2023-11-15 Thread Simon Glass
This function only uses one argument and just needs to know the name of the command which called it. Adjust the function to use only what it needs. This will make it easier to call from a non-command context. Tidy up the function comment while we are here. Signed-off-by: Simon Glass

[PATCH v2 10/32] image: Tidy up genimg_get_kernel_addr_fit()

2023-11-15 Thread Simon Glass
This function does not modify its first argument, so mark it const. Also move the comments to the header file and expand them to provide more useful information. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- (no changes since v1) boot/bootm.c | 3 +-- boot/image-board.c | 17

[PATCH v2 09/32] bootm: Move boot_get_kernel() higher in the file

2023-11-15 Thread Simon Glass
Move this code and image_get_kernel() higher in the file to avoid the need for a forward declaration. No attempt is made to remove #ifdefs or adjust the code in any other way. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- (no changes since v1) boot/bootm.c | 376

[PATCH v2 08/32] bootm: Simplify arguments for bootm_pre_load()

2023-11-15 Thread Simon Glass
Move the argument decoding to the caller, to avoid needing to pass the command-line arguments. Add a function comment while we are here. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- (no changes since v1) boot/bootm.c | 23 --- 1 file changed, 16 insertions(+), 7

[PATCH v2 07/32] bootm: Drop arguments from bootm_start()

2023-11-15 Thread Simon Glass
This function does not use its arguments. Drop them. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- (no changes since v1) boot/bootm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/boot/bootm.c b/boot/bootm.c index cb61485c226c..fda97706fc26 100644 --- a/boot

[PATCH v2 06/32] bootstd: Introduce programmable boot

2023-11-15 Thread Simon Glass
At present bootstd requires CONFIG_CMDLINE to operate. Add a new 'programmable' boot which can be used when no command line is available. For now it does almost nothing, since most bootmeths require the command line. Signed-off-by: Simon Glass --- (no changes since v1) boot/Kconfig | 11

[PATCH v2 05/32] bootstd: Add missing header file from bootdev.h

2023-11-15 Thread Simon Glass
Add a dm/uclass-id.h to the bootdev header file, since it uses enum uclass_id Signed-off-by: Simon Glass --- (no changes since v1) include/bootdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/bootdev.h b/include/bootdev.h index b079a91b5b7f..c1362673d418 100644 --- a/include

[PATCH v2 04/32] treewide: Tidy up semicolon after command macros

2023-11-15 Thread Simon Glass
The U_BOOT_CMD_COMPLETE() macro has a semicolon at the end, perhaps inadvertently. Some code has taken advantage of this. Tidy this up by dropping the semicolon from the macro and adding it to macro invocations as required. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- (no changes

[PATCH v2 03/32] mmc: env: Unify the U_BOOT_ENV_LOCATION conditions

2023-11-15 Thread Simon Glass
The declaration of U_BOOT_ENV_LOCATION() uses a different #ifdef condition from the code it calls. Use the same condition to avoid a build warning if CONFIG_CMD_SAVEENV is disabled. Signed-off-by: Simon Glass --- (no changes since v1) env/mmc.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 02/32] README: Correct docs for CONFIG_SPL_BUILD

2023-11-15 Thread Simon Glass
This option is defined in both SPL and TPL builds, so correct the docs related to this. Also point to spl_phase() which is normally a better option. Mention VPL as well. Signed-off-by: Simon Glass Reported-by: Heinrich Schuchardt --- (no changes since v1) README | 26

[PATCH v2 01/32] arm: x86: Drop discarding of command linker-lists

2023-11-15 Thread Simon Glass
Since we can now cleanly disable CMDLINE when needed, drop the rules which discard the command code. It will not be built in the first place. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- (no changes since v1) arch/arm/cpu/u-boot.lds | 3 --- arch/x86/cpu/u-boot-64.lds | 4

Re: [PATCH] bootstd: Avoid freeing a non-allocated buffer

2023-11-15 Thread Simon Glass
Hi Heinrich, On Wed, 15 Nov 2023 at 19:18, Heinrich Schuchardt wrote: > > On 11/16/23 02:35, Simon Glass wrote: > > EFI applications can be very large and thus used to cause boot failures > > when malloc() space was exhausted. > > > > A recent changed fixed t

Re: [PATCH v4 05/12] usb: Avoid unbinding devices in use by bootflows

2023-11-15 Thread Simon Glass
Hi Heinrich, On Wed, 15 Nov 2023 at 19:06, Heinrich Schuchardt wrote: > > On 11/16/23 02:42, Simon Glass wrote: > > Hi Heinrich, > > > > On Wed, 15 Nov 2023 at 18:34, Heinrich Schuchardt > > wrote: > >> > >> On 11/15/23 17:23, Heinrich Schuch

Re: [PATCH 27/29] bootm: Adjust the parameters of bootm_find_images()

2023-11-15 Thread Simon Glass
Hi Tom, On Wed, 15 Nov 2023 at 19:07, Tom Rini wrote: > > On Wed, Nov 15, 2023 at 06:56:33PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 15 Nov 2023 at 18:47, Tom Rini wrote: > > > > > > On Wed, Nov 15, 2023 at 06:42:19P

Re: [PATCH 27/29] bootm: Adjust the parameters of bootm_find_images()

2023-11-15 Thread Simon Glass
Hi Tom, On Wed, 15 Nov 2023 at 18:47, Tom Rini wrote: > > On Wed, Nov 15, 2023 at 06:42:19PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 15 Nov 2023 at 15:38, Tom Rini wrote: > > > > > > On Sat, Nov 11, 2023 at 05:09:12PM -0700, Simon Glas

Re: [PATCH 27/29] bootm: Adjust the parameters of bootm_find_images()

2023-11-15 Thread Simon Glass
Hi Tom, On Wed, 15 Nov 2023 at 15:38, Tom Rini wrote: > > On Sat, Nov 11, 2023 at 05:09:12PM -0700, Simon Glass wrote: > > > Rather than passing it all the command-line args, pass in the pieces > > that it needs. These are the image address, the ramdisk address/name > &g

Re: [BUG] usage of $kernel_addr_r in distro_efi_boot()

2023-11-15 Thread Simon Glass
Hi Heinrich, On Wed, 15 Nov 2023 at 18:07, Heinrich Schuchardt wrote: > > If $kernel_addr_r cannot be read, distro_efi_boot() falls back to > address 0. This will lead to a segmentation fault on many systems. > > distro_efi_read_bootflow_net() has a fallback to CONFIG_SYS_LOAD_ADDR > and may

Re: Bug in distro_efi_boot()

2023-11-15 Thread Simon Glass
Hi Heinrich, On Wed, 15 Nov 2023 at 17:54, Heinrich Schuchardt wrote: > > Hello Simon, > > In function distro_efi_boot() the bootefi command is called. The second > argument should only be passed if a device-tree has actually been > loaded. But this is not what the code does: > > For network

Re: [PATCH v4 05/12] usb: Avoid unbinding devices in use by bootflows

2023-11-15 Thread Simon Glass
Hi Heinrich, On Wed, 15 Nov 2023 at 18:34, Heinrich Schuchardt wrote: > > On 11/15/23 17:23, Heinrich Schuchardt wrote: > > On 11/15/23 16:50, Simon Glass wrote: > >> Hi Heinrich, > >> > >> On Sun, 12 Nov 2023 at 16:35, Heinrich Schuchardt > >>

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Simon Glass
Hi Heinrich, On Wed, 15 Nov 2023 at 18:25, Heinrich Schuchardt wrote: > > On 11/15/23 23:46, Heinrich Schuchardt wrote: > > > > > > Am 15. November 2023 23:15:46 MEZ schrieb Simon Glass : > >> Hi Shantur, > >> > >> On Wed, 15 Nov 2023 at

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Simon Glass
Hi Heinrich, On Wed, 15 Nov 2023 at 15:47, Heinrich Schuchardt wrote: > > > > Am 15. November 2023 23:15:46 MEZ schrieb Simon Glass : > >Hi Shantur, > > > >On Wed, 15 Nov 2023 at 15:13, Shantur Rathore wrote: > >> > >> Hi Simon, >

[PATCH] bootstd: Avoid freeing a non-allocated buffer

2023-11-15 Thread Simon Glass
for bootstd to do so too. Fixes: 6a8c2f9781c bootstd: Avoid allocating memory for the EFI file Signed-off-by: Simon Glass Reported by: Simon Glass Reported by: Shantur Rathore --- boot/bootflow.c | 3 ++- boot/bootmeth_efi.c | 1 + include/bootflow.h | 5 - 3 files changed, 7 insertions

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Simon Glass
and linux boots happily. > > Fixing this properly is above my pay grade as of now. Great, thank you! I will send a patch. Regards, Simon > > Kind regards, > Shantur > > On Wed, Nov 15, 2023 at 3:58 PM Simon Glass wrote: > > > > Hi Shantur, > > > > On

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Simon Glass
Hi Shantur, On Wed, 15 Nov 2023 at 08:23, Shantur Rathore wrote: > > Hi Simon, > > > > > Is this the blue port on top of the USB-C connector? > > > Yes, that's correct. > For my drive I needed - > https://patchwork.ozlabs.org/project/uboot/patch/20231110141311.512334-...@shantur.com/ > > > > >

Re: [PATCH v4 05/12] usb: Avoid unbinding devices in use by bootflows

2023-11-15 Thread Simon Glass
Hi Heinrich, On Sun, 12 Nov 2023 at 16:35, Heinrich Schuchardt wrote: > > > > Am 12. November 2023 22:20:50 MEZ schrieb Simon Glass : > >Hi Heinrich, > > > >On Sun, 12 Nov 2023 at 13:32, Heinrich Schuchardt wrote: > >> > >> > >> &

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Simon Glass
Hi Shantur, On Wed, 15 Nov 2023 at 07:50, Shantur Rathore wrote: > > Hi Simon, > > I did some testing on the USB 3.0 port and it seems like bootflow > causes something to happen to the USB. > It seems to be only reproducible on the USB3.0 port. > > I am using an AMicro AM8180 NVME to USB

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Simon Glass
on > the USB3.0 port but that might not be linked to bootflow. > > PS - Also tested with > https://patchwork.ozlabs.org/project/uboot/list/?series=382070 OK, good. Can you please reply on the patch(es) with a Tested-by tag? Regards, SImon > > Regards, > Shantur > > On

Re: u-boot fails to build on sparc64 due redefinition of 'struct termio'

2023-11-15 Thread Simon Glass
Hi Adrian, On Wed, 15 Nov 2023 at 00:27, John Paul Adrian Glaubitz wrote: > > Hello! > > On Linux sparc64, building u-boot fails with [1]: > > cc -o tools/mkenvimage tools/mkenvimage.o tools/os_support.o > tools/lib/crc32.o > In file included from /<>/tools/termios_linux.h:33, >

Re: [PATCH v5 11/20] efi: x86: Correct the condition for installing ACPI tables

2023-11-15 Thread Simon Glass
Hi Heinrich, On Wed, 15 Nov 2023 at 04:09, Heinrich Schuchardt wrote: > > On 9/20/23 05:00, Simon Glass wrote: > > It is not always the case that U-Boot builds the ACPI tables itself. For > > example, when booting from coreboot, the ACPI tables are built by > > c

Re: [PATCH 00/34] x86: expo: Add support for editing coreboot CMOS RAM settings

2023-11-15 Thread Simon Glass
Hi Bin, On Sun, 1 Oct 2023 at 19:16, Simon Glass wrote: > > U-Boot provides support for editing settings with an 'expo', as well as > reading and writing settings to CMOS RAM. > > This series integrates expo functionality with coreboot, using the > sysinfo table to get

Please pull u-boot-dm

2023-11-15 Thread Simon Glass
(1): sandbox: Close file after mmaping it Simon Glass (10): efi: Correct handling of frame buffer bootstd: Refactor mmc prep to allow a different scan bootstd: Add a return code to bootflow menu expo: Correct background colour patman: Split out arg parsing

Re: [PATCH v3 01/12] efi: Correct handling of frame buffer

2023-11-15 Thread Simon Glass
On Mon, Oct 2, 2023 at 10:23 AM Simon Glass wrote: > > The efi_gop driver uses private fields from the video uclass to obtain a > pointer to the frame buffer. Use the platform data instead. > > Check the VIDEO_COPY setting to determine which frame buffer to use. Once > the nex

Re: [PATCH v3 02/12] bootstd: Refactor mmc prep to allow a different scan

2023-11-15 Thread Simon Glass
Adjust scan_mmc4_bootdev() and related function so that the caller can do its own 'bootflow scan' command. This allows it to change the flags if needed. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to refactor mmc prep to allow a different scan test/boot/bootflow.c | 49

Re: [PATCH v3 03/12] bootstd: Add a return code to bootflow menu

2023-11-15 Thread Simon Glass
Return an error when the user does not select an OS, so we know whether to boot or not. Move calling of bootflow_menu_run() into a separate function so we can call it from other places. Expand the test to cover these cases. Add some documentation also, while we are here. Signed-off-by: Simon

Re: [PATCH v3 06/12] expo: Correct background colour

2023-11-15 Thread Simon Glass
On Mon, Oct 2, 2023 at 9:30 AM Simon Glass wrote: > > Use the correct background colour when using white-on-black. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > boot/expo.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Rev

Re: [PATCH 1/5] patman: Split out arg parsing into its own file

2023-11-15 Thread Simon Glass
Move this code into a separate cmdline module, as is done with the other tools. Use the same HAS_TESTS check as buildman Signed-off-by: Simon Glass --- tools/patman/__main__.py | 116 +- tools/patman/cmdline.py | 147 +++ 2

Re: [PATCH 2/5] patman: Move the main program into a function

2023-11-15 Thread Simon Glass
Add a new run_patman() function to hold the main logic. Signed-off-by: Simon Glass --- tools/patman/__main__.py | 127 +-- 1 file changed, 67 insertions(+), 60 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 3/5] patman: Correct easy pylint warnings in __main__

2023-11-15 Thread Simon Glass
Tidy up the code a little to reduce the number of pylint warnings. Signed-off-by: Simon Glass --- tools/patman/__main__.py | 32 1 file changed, 16 insertions(+), 16 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 4/5] patman: Avoid using func_test at top level

2023-11-15 Thread Simon Glass
Import this only when it is needed, since it is not present when installed via 'pip install'. Signed-off-by: Simon Glass Fixes: https://source.denx.de/u-boot/u-boot/-/issues/26 --- tools/patman/__main__.py | 1 - 1 file changed, 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [PATCH 5/5] patman: Correct Python 3.6 behaviour

2023-11-15 Thread Simon Glass
The importlib_resources import is not actually used. Fix this so that patman can run on Python 3.6 to some extent, once 'pip3 install importlib-resources' has been run. Signed-off-by: Simon Glass --- tools/patman/__main__.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Applied

Re: [PATCH 1/1] dm: Do not enable debug messages by default

2023-11-15 Thread Simon Glass
rzywara > Signed-off-by: Heinrich Schuchardt > --- > drivers/core/Kconfig | 1 - > include/dm/util.h| 4 +--- > 2 files changed, 1 insertion(+), 4 deletions(-) Reviewed-by: Simon Glass Applied to u-boot-dm, thanks!

Re: [PATCH] sandbox: Close file after mmaping it

2023-11-15 Thread Simon Glass
++- > 1 file changed, 10 insertions(+), 5 deletions(-) Reviewed-by: Simon Glass Applied to u-boot-dm, thanks!

Re: [PATCH] bootstage: Correct exhasuted typo

2023-11-15 Thread Simon Glass
On Tue, 7 Nov 2023 at 02:18, Patrick Delaunay wrote: > > From: Simon Glass > > Correct this typo in the warning message shown when no more bootstage > records can be added. > > Signed-off-by: Simon Glass > Signed-off-by: Patrick Delaunay > --- > I just

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Simon Glass
+Heinrich Schuchardt Hi Shantur, On Wed, 15 Nov 2023 at 05:59, Shantur Rathore wrote: > > Hi all, > > I am facing an issue with bootflow where grub efi crashes only when > bootflow is selected manually. > > Board - RockPro64 > OS - Armbian Bookworm CLI > U-boot : 2024.01-rc2 > Built and

Re: Booting an x86-64 BIOS Machine

2023-11-14 Thread Simon Glass
Hi Desone, On Tue, 14 Nov 2023 at 17:43, Desone Burns wrote: > > Hello, > > I have an application in which I need to boot an x86-64 machine with a > legacy BIOS. I've read about the U-Boot executable, the SPL, and the > TPL. I'm just having a bit of trouble figuring out which pieces are >

Re: [PATCH] riscv: binman: fix the load field format

2023-11-14 Thread Simon Glass
Hi Randolph, On Mon, 13 Nov 2023 at 23:26, Randolph Lin wrote: > > Hi Simon, > Thanks a lot. > On Fri, Nov 10, 2023 at 04:50:24AM -0700, Simon Glass wrote: > > Hi Randolph, > > > > On Wed, Nov 8, 2023, 20:15 Randolph wrote: > > > > > >

Re: [PATCH v4 09/12] x86: Enable SSE in 64-bit mode

2023-11-14 Thread Simon Glass
m Rini wrote: > > > > > > > > On Tue, Nov 14, 2023 at 07:46:36AM +0800, Bin Meng wrote: > > > > > Hi Tom, > > > > > > > > > > On Tue, Nov 14, 2023 at 6:59 AM Tom Rini wrote: > > > > > > > > > > >

Re: [PATCH v3 2/5] firmware: scmi: support protocols on sandbox only if enabled

2023-11-14 Thread Simon Glass
NABLED() > * remove goto by introducing a not_supported() function > --- > drivers/firmware/scmi/sandbox-scmi_agent.c | 30 ++-- > drivers/firmware/scmi/sandbox-scmi_devices.c | 78 > 2 files changed, 71 insertions(+), 37 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH] spl: fix TPL_SYS_MALLOC_F description

2023-11-14 Thread Simon Glass
f-by: John Keeping > --- > Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH v3 1/5] test: dm: skip scmi tests against disabled protocols

2023-11-14 Thread Simon Glass
kahiro > --- > v9 > * return -EAGAIN if we want to skip a test > * use CONFIG_IS_ENABLED() rather than IS_ENABLED() > --- > test/dm/scmi.c | 12 > 1 file changed, 12 insertions(+) Reviewed-by: Simon Glass

Re: [PATCH 5/5] test: dm: add scmi command test

2023-11-14 Thread Simon Glass
Hi, On Mon, 13 Nov 2023 at 18:41, AKASHI Takahiro wrote: > > On Mon, Nov 13, 2023 at 11:01:17AM -0700, Simon Glass wrote: > > Hi, > > > > On Sun, 12 Nov 2023 at 18:46, AKASHI Takahiro > > wrote: > > > > > > Hi Tom, > > > >

Re: [PATCH 01/13] sandbox: move asm-generic include to the end of file

2023-11-14 Thread Simon Glass
ndbox/include/asm/io.h | 28 ++-- > 1 file changed, 14 insertions(+), 14 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH v4 09/12] x86: Enable SSE in 64-bit mode

2023-11-13 Thread Simon Glass
Hi Bin, On Mon, 13 Nov 2023 at 15:08, Bin Meng wrote: > > Hi Simon, > > On Mon, Nov 13, 2023 at 4:03 AM Simon Glass wrote: > > > > This is needed to support Truetype fonts. In any case, the compiler > > expects SSE to be available in 64-bit mode. Provide

Re: U-Booters at LPC

2023-11-13 Thread Simon Glass
Hi Sean, On Mon, 13 Nov 2023 at 11:15, Sean Anderson wrote: > > Hi All, > > I'm at LPC this week, and I'd love to chat with anyone else who's there > in person. That would be good, but sadly I am not :-( Regards, Simon

Re: [PATCH 1/1] efi_loader: improve efi_var_from_file() description

2023-11-13 Thread Simon Glass
or a variable cannot be set > EFI_SUCCESS > - * is returned. > + * On first boot the file ubootefi.var does not exist yet. This is if why we s/if// Reviewed-by: Simon Glass > + * must return EFI_SUCCESS in this case. > + * > + * If the variable file is corrupted, e.g. incorrec

Re: [PATCH 5/5] test: dm: add scmi command test

2023-11-13 Thread Simon Glass
gainst different sub-commands. > > > Please note that scmi command is for debug purpose and is not intended > > > in production system. > > > > > > Signed-off-by: AKASHI Takahiro > > > Reviewed-by: Simon Glass > > > Reviewed-by: Etienne Carriere

Re: [PATCH v2 2/5] firmware: scmi: support protocols on sandbox only if enabled

2023-11-13 Thread Simon Glass
Hi AKASHI, On Sun, 12 Nov 2023 at 18:49, AKASHI Takahiro wrote: > > This change will be useful when we manually test SCMI on sandbox > by enabling/disabling a specific SCMI protocol. > > Signed-off-by: AKASHI Takahiro > --- > drivers/firmware/scmi/sandbox-scmi_agent.c | 27 ++- >

Re: [PATCH 2/4] serial: s5p: Use livetree API to get "id" property

2023-11-13 Thread Simon Glass
Hi Sam, On Fri, 10 Nov 2023 at 11:29, Sam Protsenko wrote: > > Hi Simon, > > On Tue, Nov 7, 2023 at 10:26 PM Simon Glass wrote: > > > > Hi Sam, > > > > On Tue, 7 Nov 2023 at 12:06, Sam Protsenko > > wrote: > > > > > > Use dev_r

Re: [PATCH v2 1/5] test: dm: skip scmi tests against disabled protocols

2023-11-13 Thread Simon Glass
Hi AKASHI, On Sun, 12 Nov 2023 at 18:49, AKASHI Takahiro wrote: > > This is a precautionary change to make scmi tests workable whether or not > a specific protocol be enabled. > > Signed-off-by: AKASHI Takahiro > --- > test/dm/scmi.c | 12 > 1 file changed, 12 insertions(+) > >

Re: [PATCH v3 09/12] x86: Enable SSE in 64-bit mode

2023-11-13 Thread Simon Glass
Hi Tom, On Mon, 13 Nov 2023 at 07:06, Tom Rini wrote: > > On Mon, Nov 13, 2023 at 09:01:02PM +0800, Bin Meng wrote: > > Hi Simon, > > > > On Mon, Nov 13, 2023 at 4:02 AM Simon Glass wrote: > > > > > > Hi Bin, > > > > > > On Mon, 6 Nov

Re: [PATCH v3 09/12] x86: Enable SSE in 64-bit mode

2023-11-13 Thread Simon Glass
Hi Bin, On Mon, 13 Nov 2023 at 06:01, Bin Meng wrote: > > Hi Simon, > > On Mon, Nov 13, 2023 at 4:02 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Mon, 6 Nov 2023 at 08:36, Tom Rini wrote: > > > > > > On Mon, Nov 06, 2

Re: [PATCH v2 1/1] acpi: cannot have RSDT above 4 GiB

2023-11-13 Thread Simon Glass
> Use constants form linux/sizes.h > --- > lib/acpi/base.c | 23 --- > 1 file changed, 16 insertions(+), 7 deletions(-) Reviewed-by: Simon Glass

[PATCH 8/9] sysinfo: Allow displaying more info on startup

2023-11-12 Thread Simon Glass
to display, it is easy to add it, now. Signed-off-by: Simon Glass --- common/board_info.c | 72 + drivers/sysinfo/Kconfig | 7 include/sysinfo.h | 3 ++ 3 files changed, 61 insertions(+), 21 deletions(-) diff --git a/common/board_info.c b

[PATCH 9/9] x86: coreboot: Add a sysinfo driver

2023-11-12 Thread Simon Glass
/11/2023 Signed-off-by: Simon Glass --- arch/x86/cpu/coreboot/Kconfig | 2 + arch/x86/dts/coreboot.dts | 4 ++ board/coreboot/coreboot/Makefile | 1 + board/coreboot/coreboot/coreboot.c | 44 --- board/coreboot/coreboot/sysinfo.c | 89

[PATCH 4/9] solidrun: Use checkboard() instead of show_board_info()

2023-11-12 Thread Simon Glass
Boards can use a sysinfo driver if a particular model name is needed. Update this board to use checkboard() directly, rather than having a weak function laid on top of a weak function. Signed-off-by: Simon Glass --- board/solidrun/mx6cuboxi/mx6cuboxi.c | 7 +-- 1 file changed, 1 insertion

[PATCH 5/9] toradex: Use checkboard() instead of show_board_info()

2023-11-12 Thread Simon Glass
. Signed-off-by: Simon Glass --- board/toradex/apalis-imx8/apalis-imx8.c | 2 +- board/toradex/apalis-tk1/apalis-tk1.c | 2 +- board/toradex/apalis_imx6/apalis_imx6.c | 3 ++- board/toradex/apalis_t30/apalis_t30.c | 2 +- board/toradex/colibri-imx6ull/colibri

[PATCH 7/9] Revert "generic-board: make show_board_info a weak function"

2023-11-12 Thread Simon Glass
on show_board_info() This reverts commit f7637cc01414b9c87b6b0f861f34d83c19bfaaaf. Signed-off-by: Simon Glass --- common/board_info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/board_info.c b/common/board_info.c index 3185793da4a7..a62c04794b90 100644 --- a/common

[PATCH 6/9] udoo: Use checkboard() instead of show_board_info()

2023-11-12 Thread Simon Glass
Boards can use a sysinfo driver if a particular model name is needed. Update this board to use checkboard() directly, rather than having a weak function laid on top of a weak function. Signed-off-by: Simon Glass --- board/udoo/neo/neo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 3/9] turris: Use checkboard() instead of show_board_info()

2023-11-12 Thread Simon Glass
Boards can use a sysinfo driver if a particular model name is needed. Update this board to use checkboard() directly, rather than having a weak function laid on top of a weak function. Signed-off-by: Simon Glass --- board/CZ.NIC/turris_mox/turris_mox.c | 2 +- board/CZ.NIC/turris_omnia

[PATCH 2/9] meson: Use checkboard() instead of show_board_info()

2023-11-12 Thread Simon Glass
Boards can use a sysinfo driver if a particular model name is needed. Update this board to use checkboard() directly, rather than having a weak function laid on top of a weak function. Signed-off-by: Simon Glass --- arch/arm/mach-meson/board-info.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 0/9] sysinfo: Expand sysinfo with some more banner information

2023-11-12 Thread Simon Glass
change in output, in that the model name will appear first, before any custom output. If that is a problem, then the solution is to implement a sysinfo driver for the board. Simon Glass (9): board: Move show_board_info() comment to header file meson: Use checkboard() instead of show_board_info

[PATCH 1/9] board: Move show_board_info() comment to header file

2023-11-12 Thread Simon Glass
Move this comment to its prototype and tidy it up a bit. Signed-off-by: Simon Glass --- common/board_info.c | 6 -- include/init.h | 11 +++ 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/common/board_info.c b/common/board_info.c index e0f2d9392204

Re: [PATCH 1/1] acpi: cannot have RSDT above 4 GiB

2023-11-12 Thread Simon Glass
Hi Heinrich, On Sun, 12 Nov 2023 at 13:16, Heinrich Schuchardt wrote: > > > > Simon Glass schrieb am So., 12. Nov. 2023, 21:03: >> >> Hi Heinrich, >> >> On Sat, 11 Nov 2023 at 07:28, Heinrich Schuchardt >> wrote: >> > >> > The field R

Re: [PATCH v4 05/12] usb: Avoid unbinding devices in use by bootflows

2023-11-12 Thread Simon Glass
Hi Heinrich, On Sun, 12 Nov 2023 at 13:32, Heinrich Schuchardt wrote: > > > > Am 12. November 2023 21:02:42 MEZ schrieb Simon Glass : > >When a USB device is unbound, it causes any bootflows attached to it to > >be removed, via a call to bootdev_clear_bootflows() fr

[PATCH v2 3/3] efi: Avoid using dm_scan_other()

2023-11-12 Thread Simon Glass
This function is defined by bootstd so using it precludes using that feature. Use the board_early_init_r() feature instead. This requires moving quite a lot of code into the board directory, butt this is the normal place for code called by board_early_init_r() Signed-off-by: Simon Glass

[PATCH v2 2/3] efi: Correct display of table GUIDs

2023-11-12 Thread Simon Glass
The printf() %pU option decodes GUIDs so it is not necessary to do this first. Drop the incorrect code. Signed-off-by: Simon Glass --- (no changes since v1) cmd/efi_common.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/cmd/efi_common.c b/cmd/efi_common.c index

[PATCH v2 1/3] efi: Collect the ACPI tables in the app

2023-11-12 Thread Simon Glass
Locate these so that they can be displayed using the 'acpi' command. Signed-off-by: Simon Glass --- (no changes since v1) lib/efi/efi_app.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/lib/efi/efi_app.c b/lib/efi/efi_app.c index 2209410f35b5

[PATCH v2 0/3] efi: Minor improvements for the EFI app

2023-11-12 Thread Simon Glass
This series collects a few fixes and improvements useful when booting U-Boot as an EFI app. Changes in v2: - Drop duplicate acpi_xsdt patch - Put the board_early_init_r code into board/ Simon Glass (3): efi: Collect the ACPI tables in the app efi: Correct display of table GUIDs efi: Avoid

Re: [PATCH v3 07/12] video: Correct setting of cursor position

2023-11-12 Thread Simon Glass
Hi Anatolij, On Sun, 1 Oct 2023 at 19:15, Simon Glass wrote: > > The ANSI codes are not correctly handled at present, in that the > requested X position is added to the current one. > > Correct this and also call vidconsole_entry_start() to start a new text > line. > > Si

Re: [PATCH v2 4/6] video: Skip framebuffer reservation if already reserved

2023-11-12 Thread Simon Glass
Hi Devarsh, On Fri, 10 Nov 2023 at 08:29, Devarsh Thakkar wrote: > > Skip framebufer reservation if it was already reserved > from previous stage and whose information was passed > using a bloblist. > > Signed-off-by: Devarsh Thakkar > Reviewed-by: Simon Glass > --- &g

Re: [PATCH] configs: rockpro64: Enable SPI command and full BOOTSTD

2023-11-12 Thread Simon Glass
Hi Jonas, On Sun, 12 Nov 2023 at 07:53, Jonas Karlman wrote: > > Hi Simon, > > On 2023-11-12 15:22, Simon Glass wrote: > > Hi Jonas, > > > > On Sun, 12 Nov 2023 at 05:50, Jonas Karlman wrote: > >> > >> Hi Shantur, > >> > &

Re: [PATCH v2 2/6] board: ti: am62x: evm: Remove video_setup from spl_board_init

2023-11-12 Thread Simon Glass
On Fri, 10 Nov 2023 at 08:29, Devarsh Thakkar wrote: > > Remove video_setup from evm_init sequence since video memory > is getting called at an earlier place to make sure > video memory is reserved at the end of RAM. > > Suggested-by: Simon Glass > Signed-off-by: Devars

Re: [PATCH v2 5/6] video: Fill video handoff in video post probe

2023-11-12 Thread Simon Glass
er and U-boot U-Boot > framework expects them to be filled for some of the > functionalities. Can you wrap your commit messages to closer to 72 chars? > > Reported-by: Simon Glass > Signed-off-by: Devarsh Thakkar > --- > V2: > - No change > > V3: > - Fix commi

Re: [PATCH v4 4/5] dm: core: Modify default for OFNODE_MULTI_TREE

2023-11-12 Thread Simon Glass
Hi Sean, On Fri, 3 Nov 2023 at 13:38, Simon Glass wrote: > > On Fri, 3 Nov 2023 at 12:38, wrote: > > > > From: Sean Edmond > > > > There is a preference to use the "ofnode" API for FDT fixups > > moving forward. The FDT fixup will usually be fo

Re: [PATCH v2 1/2] acpi: fix struct acpi_xsdt

2023-11-12 Thread Simon Glass
> > Signed-off-by: Heinrich Schuchardt > --- > v2: > add unit test > --- > include/acpi/acpi_table.h | 2 +- > test/dm/acpi.c| 10 ++ > 2 files changed, 11 insertions(+), 1 deletion(-) Reviewed-by: Simon Glass

[PATCH v3 2/2] blk: Drop reference to DM_SPL

2023-11-12 Thread Simon Glass
The intent here is to only allow SPL_LEGACY_BLK if !SPL_DM - i.e. that when driver model is enabled in SPL, legacy block cannot be used. However this combination is used by about 240 boards, so we cannot disallow it, at least not yet. So just drop the condition. Signed-off-by: Simon Glass

[PATCH v3 1/2] dm: core: Correct reference to DM_SPL in SPL_DM_STATS

2023-11-12 Thread Simon Glass
This does not existing anymore. Update SPL_DM_STATS to use the correct Kconfig option, which is SPL_DM Signed-off-by: Simon Glass --- Changes in v3: - Split the patch into two Changes in v2: - Add new patch to correct references to DM_SPL drivers/core/Kconfig | 2 +- 1 file changed, 1

Re: [PATCH v2 6/6] doc: spl: Add info regarding memory reservation and missing Kconfigs

2023-11-12 Thread Simon Glass
Hi Devarsh, On Fri, 10 Nov 2023 at 08:29, Devarsh Thakkar wrote: > > Add information regarding memory reservation scheme in SPL > and details regarding scheme which need to be followed while reserving > those areas which need to be preserved across bootstages. > > Also add missing CONFIG_SPL

Re: [PATCH v4 3/5] cmd: kaslrseed: Use common API to fixup FDT

2023-11-12 Thread Simon Glass
Hi Sean, On Fri, 3 Nov 2023 at 12:38, wrote: > > From: Sean Edmond > > Use the newly introduced common API fdt_fixup_kaslr_seed() in the > kaslrseed command. > > Signed-off-by: Sean Edmond > --- > cmd/kaslrseed.c | 22 -- > 1 file changed, 8 insertions(+), 14 deletions(-)

Re: [PATCH 1/4] acpi: Use __packed with struct acpi_xsdt

2023-11-12 Thread Simon Glass
Hi Heinrich, On Sun, 12 Nov 2023 at 09:46, Heinrich Schuchardt wrote: > > On 11/12/23 16:58, Simon Glass wrote: > > Since struct acpi_table_header is not a multiple of 64 bits, use the > > __packed option for struct acpi_xsdt > > > > This ensures that the entry

Re: [PATCH 3/4] efi: Correct display of table GUIDs

2023-11-12 Thread Simon Glass
Hi Heinrich, On Sun, 12 Nov 2023 at 09:58, Heinrich Schuchardt wrote: > > On 11/12/23 16:58, Simon Glass wrote: > > The printf() %pU option decodes GUIDs so it is not necessary to do this > > first. Drop the incorrect code. > > > > Signed-off-by: Simon Glass >

Re: [PATCH v4 1/5] fdt: common API to populate kaslr seed

2023-11-12 Thread Simon Glass
Hi Sean, On Fri, 3 Nov 2023 at 12:39, wrote: > > From: Dhananjay Phadke > > fdt_fixup_kaslr_seed() will update given ofnode with random seed value. > Source for random seed can be TPM or RNG driver in u-boot or sec > firmware (ARM). > > Signed-off-by: Dhananjay Phadke > Signed-off-by: Sean

Re: [PATCH v1 1/2] common: board_f: change calculation of gd->mon_len to fix s5p4418 reloc

2023-11-12 Thread Simon Glass
__image_copy_start instead of _start in order the hole whole > monitor code is relocated. > > Signed-off-by: Stefan Bosch Reviewed-by: Simon Glass > > --- > > common/board_f.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass > >

Re: [PATCH 1/1] acpi: cannot have RSDT above 4 GiB

2023-11-12 Thread Simon Glass
e changed, 19 insertions(+), 7 deletions(-) Reviewed-by: Simon Glass nits / question below > > diff --git a/lib/acpi/base.c b/lib/acpi/base.c > index 2057bd2bef..128a76ad39 100644 > --- a/lib/acpi/base.c > +++ b/lib/acpi/base.c > @@ -21,10 +21,17 @@ void acpi_write_rsdp(struct

Re: [PATCH v2 1/6] arm: mach-k3: common: Reserve video memory from end of the RAM

2023-11-12 Thread Simon Glass
p > the pre-reserved area from previous stage right from the end of RAM > without having to make any gaps/holes to accommodate those > regions which was the case before as previous stage > reserved region not from the end of RAM. > > Suggested-by: Simon Glass > Signed-off-

Re: [PATCH v2 2/2] cmd: acpi: fix acpi list command

2023-11-12 Thread Simon Glass
> test/dm/acpi.c | 18 +++++----- > 2 files changed, 38 insertions(+), 28 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH 4/4] efi: Avoid using dm_scan_other()

2023-11-12 Thread Simon Glass
Hi Tom, Heinrich, On Sun, 12 Nov 2023 at 12:20, Heinrich Schuchardt wrote: > > > > Am 12. November 2023 19:03:57 MEZ schrieb Tom Rini : > >On Sun, Nov 12, 2023 at 08:58:05AM -0700, Simon Glass wrote: > >> This function is defined by bootstd so using it precludes u

<    5   6   7   8   9   10   11   12   13   14   >