Re: [U-Boot] [PATCH] sf: ensure flash device is in 3-byte address mode

2018-05-14 Thread Simon Goldschmidt
+ Marek for the socfpga platform, see below On 07.12.2017 06:49, Jagan Teki wrote: On Tue, Dec 5, 2017 at 11:50 AM, Goldschmidt Simon wrote: + Lukasz (as a reviewer of my patch[1]) On Mon, Dec 4, 2017 at 8:20, Jagan Teki wrote: This is the patch[1] for

Re: [U-Boot] [PATCH] sf: ensure flash device is in 3-byte address mode

2018-05-14 Thread Simon Goldschmidt
On 14.05.2018 09:22, Jagan Teki wrote: On Mon, May 14, 2018 at 12:34 PM, Simon Goldschmidt <sgoldschm...@de.pepperl-fuchs.com> wrote: + Marek for the socfpga platform, see below On 07.12.2017 06:49, Jagan Teki wrote: On Tue, Dec 5, 2017 at 11:50 AM, Goldschmidt Simon <

Re: [U-Boot] [PATCH] ARM: socfpga: Put stack at the end of SRAM

2018-05-14 Thread Simon Goldschmidt
On 14.05.2018 10:17, Marek Vasut wrote: On 05/14/2018 10:03 AM, Simon Goldschmidt wrote: On 12.05.2018 22:27, Marek Vasut wrote: The global data are in the .data section, so there's no point in reserving any space for it above stack. Put stack at the end of SRAM. Signed-off-by: Marek Vasut

Re: [U-Boot] [PATCH] ARM: socfpga: Put stack at the end of SRAM

2018-05-14 Thread Simon Goldschmidt
On 12.05.2018 22:27, Marek Vasut wrote: The global data are in the .data section, so there's no point in reserving any space for it above stack. Put stack at the end of SRAM. Signed-off-by: Marek Vasut Cc: Chin Liang See Cc: Dinh Nguyen

Re: [U-Boot] [PATCH] ARM: socfpga: Put stack at the end of SRAM

2018-05-14 Thread Simon Goldschmidt
On 14.05.2018 17:51, Stefan Roese wrote: On 14.05.2018 11:06, Marek Vasut wrote: On 05/14/2018 11:01 AM, Simon Goldschmidt wrote: On 14.05.2018 10:17, Marek Vasut wrote: On 05/14/2018 10:03 AM, Simon Goldschmidt wrote: On 12.05.2018 22:27, Marek Vasut wrote: The global data

[U-Boot] [PATCH] arm: socfpga: fix CONFIG_SPL_MAX_SIZE (less than SRAM)

2018-05-14 Thread Simon Goldschmidt
less than CONFIG_SYS_INIT_RAM_SIZE. Signed-off-by: Simon Goldschmidt <sgoldschm...@de.pepperl-fuchs.com> --- include/configs/socfpga_common.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h

Re: [U-Boot] [PATCH] ARM: socfpga: Put stack at the end of SRAM

2018-05-14 Thread Simon Goldschmidt
On 14.05.2018 21:43, Simon Goldschmidt wrote: On 14.05.2018 17:51, Stefan Roese wrote: On 14.05.2018 11:06, Marek Vasut wrote: On 05/14/2018 11:01 AM, Simon Goldschmidt wrote: On 14.05.2018 10:17, Marek Vasut wrote: On 05/14/2018 10:03 AM, Simon Goldschmidt wrote: On 12.05.2018 22:27

Re: [U-Boot] [PATCH] arm: socfpga: fix CONFIG_SPL_MAX_SIZE (less than SRAM)

2018-05-15 Thread Simon Goldschmidt
On 14.05.2018 23:03, Marek Vasut wrote: On 05/14/2018 11:02 PM, Simon Goldschmidt wrote: The boot ROMs of the socfpga platform limit the size of the SPL to copy to less than the available SRAM. (See "Intel SoC FPGA Embedded Development Suite User Guide") According to this document,

Re: [U-Boot] [PATCH] ARM: socfpga: Put stack at the end of SRAM

2018-05-15 Thread Simon Goldschmidt
On 14.05.2018 22:43, Marek Vasut wrote: On 05/14/2018 09:43 PM, Simon Goldschmidt wrote: On 14.05.2018 17:51, Stefan Roese wrote: On 14.05.2018 11:06, Marek Vasut wrote: On 05/14/2018 11:01 AM, Simon Goldschmidt wrote: On 14.05.2018 10:17, Marek Vasut wrote: On 05/14/2018 10:03 AM

Re: [U-Boot] [PATCH] sf: ensure flash device is in 3-byte address mode

2018-05-18 Thread Simon Goldschmidt
On 14.05.2018 09:47, Simon Goldschmidt wrote: On 14.05.2018 09:22, Jagan Teki wrote: On Mon, May 14, 2018 at 12:34 PM, Simon Goldschmidt <sgoldschm...@de.pepperl-fuchs.com> wrote: + Marek for the socfpga platform, see below On 07.12.2017 06:49, Jagan Teki wrote: On Tue, Dec 5, 2017

Re: [U-Boot] [PATCH] arm: socfpga: fix CONFIG_SPL_MAX_SIZE (less than SRAM)

2018-05-15 Thread Simon Goldschmidt
On 15.05.2018 12:30, Marek Vasut wrote: On 05/15/2018 12:21 PM, Simon Goldschmidt wrote: On 15.05.2018 11:14, Marek Vasut wrote: On 05/15/2018 09:14 AM, Simon Goldschmidt wrote: On 14.05.2018 23:03, Marek Vasut wrote: On 05/14/2018 11:02 PM, Simon Goldschmidt wrote: The boot ROMs

Re: [U-Boot] [PATCH] arm: socfpga: fix CONFIG_SPL_MAX_SIZE (less than SRAM)

2018-05-15 Thread Simon Goldschmidt
On 15.05.2018 11:14, Marek Vasut wrote: On 05/15/2018 09:14 AM, Simon Goldschmidt wrote: On 14.05.2018 23:03, Marek Vasut wrote: On 05/14/2018 11:02 PM, Simon Goldschmidt wrote: The boot ROMs of the socfpga platform limit the size of the SPL to copy to less than the available SRAM. (See

Re: [U-Boot] [PATCH] sf: ensure flash device is in 3-byte address mode

2018-05-21 Thread Simon Goldschmidt
Hi Jagan, On 21.05.2018 17:09, Jagan Teki wrote: Hi Simon, On Fri, May 18, 2018 at 12:48 PM, Simon Goldschmidt <sgoldschm...@de.pepperl-fuchs.com> wrote: On 14.05.2018 09:47, Simon Goldschmidt wrote: On 14.05.2018 09:22, Jagan Teki wrote: On Mon, May 14, 2018 at 12:34 PM,

Re: [U-Boot] [PATCH] sf: ensure flash device is in 3-byte address mode

2018-05-30 Thread Simon Goldschmidt
On 30.05.2018 07:10, Jagan Teki wrote: On Tue, May 22, 2018 at 9:59 AM, Simon Goldschmidt wrote: Hi Jagan, On 21.05.2018 17:09, Jagan Teki wrote: Hi Simon, On Fri, May 18, 2018 at 12:48 PM, Simon Goldschmidt wrote: On 14.05.2018 09:47, Simon Goldschmidt wrote: On 14.05.2018 09

Re: [U-Boot] [PATCH] sf: ensure flash device is in 3-byte address mode

2018-05-30 Thread Simon Goldschmidt
On 30.05.2018 13:27, Marek Vasut wrote: On 05/30/2018 01:25 PM, Jagan Teki wrote: On Wed, May 30, 2018 at 1:42 PM, Simon Goldschmidt wrote: On 30.05.2018 07:10, Jagan Teki wrote: On Tue, May 22, 2018 at 9:59 AM, Simon Goldschmidt wrote: Hi Jagan, On 21.05.2018 17:09, Jagan Teki

Re: [U-Boot] [PATCH] sf: ensure flash device is in 3-byte address mode

2018-05-30 Thread Simon Goldschmidt
On 30.05.2018 11:56, Marek Vasut wrote: On 05/30/2018 07:10 AM, Jagan Teki wrote: On Tue, May 22, 2018 at 9:59 AM, Simon Goldschmidt wrote: Hi Jagan, On 21.05.2018 17:09, Jagan Teki wrote: Hi Simon, On Fri, May 18, 2018 at 12:48 PM, Simon Goldschmidt wrote: On 14.05.2018 09:47

Re: [U-Boot] [PATCH] sf: ensure flash device is in 3-byte address mode

2018-05-30 Thread Simon Goldschmidt
On 30.05.2018 13:25, Jagan Teki wrote: On Wed, May 30, 2018 at 1:42 PM, Simon Goldschmidt wrote: On 30.05.2018 07:10, Jagan Teki wrote: On Tue, May 22, 2018 at 9:59 AM, Simon Goldschmidt wrote: Hi Jagan, On 21.05.2018 17:09, Jagan Teki wrote: Hi Simon, On Fri, May 18, 2018

[U-Boot] [PATCH] arm: socfpga: allow configs without network support

2018-01-11 Thread Simon Goldschmidt
in BOOT_TARGET_DEVICES(func). Signed-off-by: Simon Goldschmidt <sgoldschm...@de.pepperl-fuchs.com> ---  configs/socfpga_arria10_defconfig   |  1 +  configs/socfpga_arria5_defconfig    |  1 +  configs/socfpga_cyclone5_defconfig  |  1 +  configs/socfpga_de0_nano_soc_defconfig

Re: [U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

2018-01-22 Thread Simon Goldschmidt
On 22.01.2018 09:08, Chee, Tien Fong wrote: On Thu, 2018-01-18 at 06:57 +0100, Simon Goldschmidt wrote: On 27.12.2017 06:04, tien.fong.c...@intel.com wrote: From: Tien Fong Chee <tien.fong.c...@intel.com> This is file system generic loader which can be used to load the file imag

Re: [U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

2018-01-22 Thread Simon Goldschmidt
On 23.01.2018 07:28, Chee, Tien Fong wrote: On Mon, 2018-01-22 at 12:41 +0100, Simon Goldschmidt wrote: On 22.01.2018 09:08, Chee, Tien Fong wrote: On Thu, 2018-01-18 at 06:57 +0100, Simon Goldschmidt wrote: On 27.12.2017 06:04, tien.fong.c...@intel.com wrote: From: Tien Fong Chee

Re: [U-Boot] [PATCH v5 0/5] spi: cadence_spi: Adopt Linux DT bindings

2018-01-23 Thread Simon Goldschmidt
On 15.01.2018 13:03, Simon Goldschmidt wrote: On 07.01.2018 12:41, Marek Vasut wrote: On 01/06/2018 07:17 PM, Jason Rush wrote: Adopt the Linux DT bindings. This also fixes an issue with the indaddrtrig register on the Cadence QSPI device being programmed with the wrong value for the socfpga

Re: [U-Boot] [PATCH v2 0/3] cadence-quadspi: Fix issues with non 32bit aligned accesses

2018-01-23 Thread Simon Goldschmidt
Jagan, the merge window is now less than 1 week for 2018.03 if I'm not mistaken. Can you apply this, please? Thanks, Simon On 15.01.2018 14:47, Jason Rush wrote: On 1/15/2018 6:01 AM, Simon Goldschmidt wrote: Pepperl+Fuchs GmbH, Mannheim Geschaeftsfuehrer/Managing Directors: Dr.-Ing

Re: [U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

2018-01-23 Thread Simon Goldschmidt
On 27.12.2017 06:04, tien.fong.c...@intel.com wrote: From: Tien Fong Chee This is file system generic loader which can be used to load the file image from the storage into target such as memory. The consumer driver would then use this loader to program whatever, ie.

Re: [U-Boot] [PATCH v2 0/3] cadence-quadspi: Fix issues with non 32bit aligned accesses

2018-01-23 Thread Simon Goldschmidt
On 23.01.2018 10:16, Vignesh R wrote: On Tuesday 23 January 2018 02:37 PM, Jagan Teki wrote: On Tue, Jan 23, 2018 at 2:32 PM, Vignesh R <vigne...@ti.com> wrote: On Tuesday 23 January 2018 02:15 PM, Jagan Teki wrote: On Tue, Jan 23, 2018 at 1:42 PM, Simon Goldschmidt <sgoldschm...@d

Re: [U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

2018-01-23 Thread Simon Goldschmidt
On 23.01.2018 09:31, Chee, Tien Fong wrote: On Tue, 2018-01-23 at 08:58 +0100, Simon Goldschmidt wrote: On 27.12.2017 06:04, tien.fong.c...@intel.com wrote: From: Tien Fong Chee <tien.fong.c...@intel.com> This is file system generic loader which can be used to load the file imag

[U-Boot] [PATCH] dm: spi: prevent setting a speed of 0 Hz

2018-01-18 Thread Simon Goldschmidt
'. Signed-off-by: Simon Goldschmidt <sgoldschm...@de.pepperl-fuchs.com> --- drivers/spi/spi-uclass.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-uclass.c b/drivers/spi/spi-uclass.c index e06a603ab1..41ecef77db 100644 --- a/drivers/spi/spi-uclass.c +++ b/drivers/s

Re: [U-Boot] [PATCH] dm: spi: prevent setting a speed of 0 Hz

2018-01-18 Thread Simon Goldschmidt
On 18.01.2018 09:23, Michael Nazzareno Trimarchi wrote: Hi On Thu, Jan 18, 2018 at 9:15 AM, Simon Goldschmidt <sgoldschm...@de.pepperl-fuchs.com> wrote: When the device tree is missing a correct spi slave description below the bus, the 'set_speed' callback can be called with 'speed' =

Re: [U-Boot] QSPI "sf probe ...", "sf read ..." on Altera SoC FPGA

2018-01-17 Thread Simon Goldschmidt
, and they didn't work as well. i also found these patches which i didn't try yet: https://lists.denx.de/pipermail/u-boot/2017-May/292230.html should i try those instead? 2018-01-17 15:09 GMT+02:00 Marek Vasut <ma...@denx.de>: On 01/17/2018 02:06 PM, Simon Goldschmidt wrote: On 17.01.2018 14:01, RB23

Re: [U-Boot] QSPI "sf probe ...", "sf read ..." on Altera SoC FPGA

2018-01-17 Thread Simon Goldschmidt
already applied them, and they didn't work as well. i also found these patches which i didn't try yet: https://lists.denx.de/pipermail/u-boot/2017-May/292230.html should i try those instead? 2018-01-17 15:09 GMT+02:00 Marek Vasut <ma...@denx.de>: On 01/17/2018 02:06 PM, Simon Goldschmidt

Re: [U-Boot] [PATCH v6 2/2] common: Generic firmware loader for file system

2018-01-17 Thread Simon Goldschmidt
On 27.12.2017 06:04, tien.fong.c...@intel.com wrote: From: Tien Fong Chee This is file system generic loader which can be used to load the file image from the storage into target such as memory. The consumer driver would then use this loader to program whatever, ie.

Re: [U-Boot] [PATCH v2 0/3] cadence-quadspi: Fix issues with non 32bit aligned accesses

2018-01-15 Thread Simon Goldschmidt
;ma...@denx.de> although you should get ack from Jason and Simon instead, those matter. Acked-by: Simon Goldschmidt <sgoldschm...@de.pepperl-fuchs.com> If that "Simon" above was me :-) I thought ack was sent by maintainers and TB by me, sorry. Simon Wichtiger Hinweis: Diese

Re: [U-Boot] [PATCH v5 0/5] spi: cadence_spi: Adopt Linux DT bindings

2018-01-15 Thread Simon Goldschmidt
-by: Vignesh R <vigne...@ti.com> Tested on a socfpga-cyclonev board: Tested-by: Simon Goldschmidt <sgoldschm...@de.pepperl-fuchs.com> Signed-off-by: Jason Rush <jar...@gmail.com> Jason Rush (5): spi: cadence_spi: Sync DT bindings with Linux dts: cadence_spi: Sync DT bindings wi

Re: [U-Boot] [PATCH] spl: unbreak CONFIG_SPL_MULTI_DTB_FIT after fixing CONFIG_OF_EMBED

2018-01-14 Thread Simon Goldschmidt
On 11.01.2018 17:20, Tom Rini wrote: On Thu, Jan 11, 2018 at 07:55:03AM -0800, Simon Glass wrote: Hi Lokesh, On 11 January 2018 at 00:33, Lokesh Vutla wrote: On Wednesday 10 January 2018 07:40 PM, Goldschmidt Simon wrote: On Wed, 10/01/18 09:48, Lokesh Vutla wrote: On

[U-Boot] [PATCH v2] arm: socfpga: allow configs without network support

2018-01-24 Thread Simon Goldschmidt
in BOOT_TARGET_DEVICES(func). Signed-off-by: Simon Goldschmidt <sgoldschm...@de.pepperl-fuchs.com> --- Changes in v2: Drop changes to private files accidentally included in v1 configs/socfpga_arria10_defconfig | 1 + configs/socfpga_arria5_defconfig | 1 + configs/socfpga_cyclone5_def

[U-Boot] [PATCH] cmd: nvedit: env_get_f must check for env_get_char error codes

2018-01-30 Thread Simon Goldschmidt
env_get_char over 8000 times with the default settings, just to return an error in the end. Fix this by checking if env_get_char returns < 0. Signed-off-by: Simon Goldschmidt <sgoldschm...@de.pepperl-fuchs.com> --- cmd/nvedit.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions

Re: [U-Boot] [PATCH v3 09/15] env: Support multiple environments

2018-01-30 Thread Simon Goldschmidt
On 31.01.2018 00:02, York Sun wrote: On 01/30/2018 12:16 PM, York Sun wrote: On 01/30/2018 11:40 AM, York Sun wrote: On 01/30/2018 12:19 AM, Simon Goldschmidt wrote: On 23.01.2018 21:16, Maxime Ripard wrote: Now that we have everything in place to support multiple environment, let's make

[U-Boot] [PATCH v2 4/4] env: sf: use env_import_redund to simplify env_sf_load

2018-01-31 Thread Simon Goldschmidt
For the redundant environment configuration, env_sf_load still contained duplicate code instead of using env_import_redund(). Simplify the code by only executing the load twice and delegating everything else to env_import_redund. Signed-off-by: Simon Goldschmidt <sgoldschm...@de.pepp

[U-Boot] [PATCH 2/4] env: move more common code to env_import_redund

2018-01-31 Thread Simon Goldschmidt
by the storage driver. This is the case for mmc, nand and ubi, so for this change, code deduplicated. Signed-off-by: Simon Goldschmidt <sgoldschm...@de.pepperl-fuchs.com> --- env/common.c | 21 - env/mmc.c | 23 ++- env/nand.c

[U-Boot] [PATCH 1/4] env: make env_import(_redund) return 0 on success, not 1

2018-01-31 Thread Simon Goldschmidt
for all users before). Users that cared for the return value are also updated. Funny enough, this only affects onenand.c and sf.c Signed-off-by: Simon Goldschmidt <sgoldschm...@de.pepperl-fuchs.com> --- env/common.c | 8 env/onenand.c | 4 ++-- env/sf.c | 4 ++-- 3 files chan

[U-Boot] [PATCH v2 2/4] env: move more common code to env_import_redund

2018-01-31 Thread Simon Goldschmidt
by the storage driver. This is the case for mmc, nand and ubi, so for this change, code deduplicated. Signed-off-by: Simon Goldschmidt <sgoldschm...@de.pepperl-fuchs.com> --- env/common.c | 21 - env/mmc.c | 23 ++- env/nand.c

Re: [U-Boot] [PATCH 0/4] env: cleanups after adding multiple envs

2018-01-31 Thread Simon Goldschmidt
Sorry for the mess with the footer. Unfortunately, leaving it away is a manual step I have to remember with every patch :-( Let me know if I should resend... Simon On 31.01.2018 14:33, Simon Goldschmidt wrote: With the new code to support multiple environment drivers and select

[U-Boot] [PATCH v2 3/4] env: make env drivers propagate env_import return value

2018-01-31 Thread Simon Goldschmidt
return 0 (success) and no other drivers are checked. Signed-off-by: Simon Goldschmidt <sgoldschm...@de.pepperl-fuchs.com> --- env/eeprom.c | 4 +--- env/ext4.c | 3 +-- env/fat.c| 3 +-- env/flash.c | 4 +--- env/mmc.c| 3 +-- env/nand.c | 2 +- env/nvram.c | 4 +--- env/remote

[U-Boot] [PATCH 0/4] env: cleanups after adding multiple envs

2018-01-31 Thread Simon Goldschmidt
some other cleanups, mainly to reduce duplicated code. Simon Goldschmidt (4): env: make env_import(_redund) return 0 on success, not 1 env: move more common code to env_import_redund env: make env drivers propagate env_import return value env: sf: use env_import_redund to simplify

[U-Boot] [PATCH v2 1/4] env: make env_import(_redund) return 0 on success, not 1

2018-01-31 Thread Simon Goldschmidt
for all users before). Users that cared for the return value are also updated. Funny enough, this only affects onenand.c and sf.c Signed-off-by: Simon Goldschmidt <sgoldschm...@de.pepperl-fuchs.com> --- env/common.c | 8 env/onenand.c | 4 ++-- env/sf.c | 4 ++-- 3 files chan

[U-Boot] [PATCH v2 0/4] env: cleanups after adding multiple envs

2018-01-31 Thread Simon Goldschmidt
some other cleanups, mainly to reduce duplicated code. Changes from v1: - fixed duplicated commit message for patch 3/4 - removed german company email footer Simon Goldschmidt (4): env: make env_import(_redund) return 0 on success, not 1 env: move more common code to env_import_redund

[U-Boot] [PATCH 3/4] env: make env drivers propagate env_import return value

2018-01-31 Thread Simon Goldschmidt
return 0 (success) and no other drivers are checked. Signed-off-by: Simon Goldschmidt <sgoldschm...@de.pepperl-fuchs.com>env: make env drivers propagate env_import return value For multiple env drivers to correctly implement fallback when one environment fails to load (e.g. crc error), the

[U-Boot] [PATCH 4/4] env: sf: use env_import_redund to simplify env_sf_load

2018-01-31 Thread Simon Goldschmidt
For the redundant environment configuration, env_sf_load still contained duplicate code instead of using env_import_redund(). Simplify the code by only executing the load twice and delegating everything else to env_import_redund. Signed-off-by: Simon Goldschmidt <sgoldschm...@de.pepp

[U-Boot] [PATCH 1/1] arm: socfpga: fix qspi flash compatible (add "spi-flash")

2018-01-28 Thread Simon Goldschmidt
f 0Hz is used (which results in a divide-by-zero on these boards). Signed-off-by: Simon Goldschmidt <sgoldschm...@de.pepperl-fuchs.com> --- arch/arm/dts/socfpga_arria5_socdk.dts | 2 +- arch/arm/dts/socfpga_cyclone5_is1.dts | 2 +- arch/arm/dts/socfpga_cyclone5_socdk.d

Re: [U-Boot] [PATCH 1/1] arm: socfpga: fix qspi flash compatible (add "spi-flash")

2018-01-29 Thread Simon Goldschmidt
On 29.01.2018 11:35, Marek Vasut wrote: On 01/29/2018 07:36 AM, Simon Goldschmidt wrote: This patch adds "spi-flash" to the compatible list of the qspi flash chip for all socfpga boards. This is required to make qspi work on these boards on top of the recent fixes. Without the

Re: [U-Boot] [PATCH 1/1] arm: socfpga: fix qspi flash compatible (add "spi-flash")

2018-01-29 Thread Simon Goldschmidt
, Marek Vasut wrote: On 01/29/2018 12:56 PM, Simon Goldschmidt wrote: On 29.01.2018 11:35, Marek Vasut wrote: On 01/29/2018 07:36 AM, Simon Goldschmidt wrote: This patch adds "spi-flash" to the compatible list of the qspi flash chip for all socfpga boards. This is required to make

Re: [U-Boot] [PATCH] cmd: nvedit: env_get_f must check for env_get_char error codes

2018-02-01 Thread Simon Goldschmidt
On 01.02.2018 00:00, York Sun wrote: On 01/30/2018 10:57 PM, Simon Goldschmidt wrote: env_get_f calls env_get_char to load single characters from the environment. However, the return value of env_get_char was not checked for errors. Now if the env driver does not support the .get_char call

Re: [U-Boot] [PATCH] fpga: Simplify error path in fpga_add

2018-02-01 Thread Simon Goldschmidt
On 01.02.2018 09:05, Michal Simek wrote: Check !desc earlier to simplify code. Signed-off-by: Michal Simek <michal.si...@xilinx.com> Acked-by: Simon Goldschmidt <sgoldschm...@de.pepperl-fuchs.com> Reviewed-by: Simon Goldschmidt <sgoldschm...@de.pepperl-fuchs.com> --- d

Re: [U-Boot] [PATCH v3 12/15] env: Allow to build multiple environments in Kconfig

2018-02-01 Thread Simon Goldschmidt
On 23.01.2018 21:17, Maxime Ripard wrote: Now that we have everything in place in the code, let's allow to build multiple environments backend through Kconfig. Reviewed-by: Andre Przywara Reviewed-by: Lukasz Majewski Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH v3 13/15] env: Mark env_get_location as weak

2018-01-30 Thread Simon Goldschmidt
On 23.01.2018 21:17, Maxime Ripard wrote: Allow boards and architectures to override the default environment lookup code by overriding env_get_location. Sorry for missing that conversation a bit, but is it really enough to override env_get_location? Overriding this function should make the

Re: [U-Boot] [PATCH] env: sf: fix return value of env_sf_load

2018-01-30 Thread Simon Goldschmidt
On 30.01.2018 08:55, Simon Goldschmidt wrote: With the recent changes to support multiple environments, I see a message "Failed (1)" when loading environment from sf. env_sf_load() returns the return value of env_import(). This must be 'inverted' to return the correct meaning. Thin

Re: [U-Boot] [PATCH v3 09/15] env: Support multiple environments

2018-01-30 Thread Simon Goldschmidt
On 23.01.2018 21:16, Maxime Ripard wrote: Now that we have everything in place to support multiple environment, let's make sure the current code can use it. The priority used between the various environment is the same one that was used in the code previously. At read / init times, the highest

[U-Boot] [PATCH] env: sf: fix return value of env_sf_load

2018-01-29 Thread Simon Goldschmidt
With the recent changes to support multiple environments, I see a message "Failed (1)" when loading environment from sf. env_sf_load() returns the return value of env_import(). This must be 'inverted' to return the correct meaning. Signed-off-by: Simon Goldschmidt <sgoldschm.

Re: [U-Boot] [PATCH v3 09/15] env: Support multiple environments

2018-02-07 Thread Simon Goldschmidt
AM, York Sun wrote: On 01/30/2018 12:19 AM, Simon Goldschmidt wrote: On 23.01.2018 21:16, Maxime Ripard wrote: Now that we have everything in place to support multiple environment, let's make sure the current code can use it. The priority used between the various environment is the same one

Re: [U-Boot] [PATCH 2/2] env: Add back default action of get_char in env_get_char()

2018-02-08 Thread Simon Goldschmidt
On 08.02.2018 09:47, Maxime Ripard wrote: On Wed, Feb 07, 2018 at 02:17:12PM -0800, York Sun wrote: Commit 8a3a7e2270b3 ("env: Pass additional parameters to the env lookup function") dropped the default action if driver doesn't have get_char() defined. This causes failure to get environmental

Re: [U-Boot] [PATCH 2/2] env: Add back default action of get_char in env_get_char()

2018-02-08 Thread Simon Goldschmidt
/Register Court: AG Mannheim HRB 4713 On 08.02.2018 10:42, Simon Goldschmidt wrote: ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot Wichtiger Hinweis: Diese E-Mail einschliesslich ihrer Anhaenge enthaelt vertrauliche und

Re: [U-Boot] [PATCH 2/2] env: Add back default action of get_char in env_get_char()

2018-02-08 Thread Simon Goldschmidt
[e-news abonnieren] [YouTube: Pepperl+Fuchs auf YouTube] [@PepperlFuchsDE folgen] [Pepperl+Fuchs auf XING]

Re: [U-Boot] [PATCH 1/2] env: Fix env_load_location

2018-02-08 Thread Simon Goldschmidt
On 08.02.2018 09:38, Maxime Ripard wrote: Hi, Thanks for your patch On Wed, Feb 07, 2018 at 02:17:11PM -0800, York Sun wrote: Commit 7d714a24d725 ("env: Support multiple environments") added static variable env_load_location. When saving environmental variables, this variable is presumed to

[U-Boot] [PATCH] arm: socfpga: use imply instead of select for spi/mmc

2018-02-12 Thread Simon Goldschmidt
partitions). Signed-off-by: Simon Goldschmidt <sgoldschm...@de.pepperl-fuchs.com> --- arch/arm/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 225f57e847..37bf3dd69f 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@

Re: [U-Boot] [PATCH] arm: socfpga: use imply instead of select for spi/mmc

2018-02-12 Thread Simon Goldschmidt
On 12.02.2018 15:54, Marek Vasut wrote: On 02/12/2018 03:52 PM, Simon Goldschmidt wrote: In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some thins for spi flash and mmc that are not required by the hw. things ? what hw, all supported boards you mean ? Give users more freedom of choice

Re: [U-Boot] [PATCH] arm: socfpga: use imply instead of select for spi/mmc

2018-02-13 Thread Simon Goldschmidt
On 12.02.2018 15:54, Marek Vasut wrote: On 02/12/2018 03:52 PM, Simon Goldschmidt wrote: In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some thins for spi flash and mmc that are not required by the hw. things ? what hw, all supported boards you mean ? Give users more freedom of choice

[U-Boot] [PATCH 2/2] fix spelling of 'functions' in 2 places (was 'funtcions')

2018-02-13 Thread Simon Goldschmidt
Signed-off-by: Simon Goldschmidt <sgoldschm...@de.pepperl-fuchs.com> --- arch/sandbox/cpu/state.c | 2 +- common/board_r.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/sandbox/cpu/state.c b/arch/sandbox/cpu/state.c index 07584486db..862a71ddce

[U-Boot] [PATCH] arm: update Kconfig help for ENABLE_ARM_SOC_BOOT0_HOOK

2018-02-13 Thread Simon Goldschmidt
When this config is enabled, is included, but the Kconfig help says this should be a define (ARM_SOC_BOOT0_HOOK). The code for this in arch/arm/lib/vectors.s was changed on 01/02/2017 with commit ce62e57fc571 ("ARM: boot0 hook: remove macro, include whole header file"). Signed-off

Re: [U-Boot] [PATCH] arm: socfpga: use imply instead of select for spi/mmc

2018-02-13 Thread Simon Goldschmidt
On 13.02.2018 13:37, Marek Vasut wrote: On 02/13/2018 01:33 PM, Simon Goldschmidt wrote: On 12.02.2018 15:54, Marek Vasut wrote: On 02/12/2018 03:52 PM, Simon Goldschmidt wrote: In arch/arm/Kconfig, ARCH_SOCFPGA currently selects some thins for spi flash and mmc that are not required

Re: [U-Boot] [PATCH] arm: socfpga: use imply instead of select for spi/mmc

2018-02-13 Thread Simon Goldschmidt
On 13.02.2018 13:44, Marek Vasut wrote: On 02/13/2018 01:41 PM, Simon Goldschmidt wrote: On 13.02.2018 13:37, Marek Vasut wrote: On 02/13/2018 01:33 PM, Simon Goldschmidt wrote: On 12.02.2018 15:54, Marek Vasut wrote: On 02/12/2018 03:52 PM, Simon Goldschmidt wrote: In arch/arm/Kconfig

[U-Boot] [PATCH v2] spl: unbreak CONFIG_SPL_MULTI_DTB_FIT after fixing CONFIG_OF_EMBED

2018-02-12 Thread Simon Goldschmidt
p from dts/Makefile to scripts/Makefile.lib and includes scripts/Makefile.lib in scripts/Makefile.spl. Fixes: 9bd76b807636 ("spl: make CONFIG_OF_EMBED pass dts through fdtgrep") Reported-by: Lokesh Vutla <lokeshvu...@ti.com> Signed-off-by: Simon Goldschmidt <sgoldschm...@de.p

[U-Boot] [PATCH 0/2] arm: socfpga: Kconfig cleanups

2018-02-12 Thread Simon Goldschmidt
This patchset moves CONFIG_HW_WATCHDOG from board config files to Kconfig and changes Kconfig items that are not strictly required from 'select' to 'imply'. Defconfigs are not affected. Lukasz Majewski (1): Convert socfpga: select CONFIG_HW_WATCHDOG support for ARCH_SOCFPGA Simon Goldschmidt

[U-Boot] [PATCH 1/2] Convert socfpga: select CONFIG_HW_WATCHDOG support for ARCH_SOCFPGA

2018-02-12 Thread Simon Goldschmidt
From: Lukasz Majewski <lu...@denx.de> All Socfpga boards from ./include/configs/socfpga_* define CONFIG_HW_WATCHDOG. To ease CONFIG_HW_WATCHDOG conversion to Kconfig select it in config ARCH_SOCFPGA (arch/arm/Kconfig) section. Signed-off-by: Lukasz Majewski <lu...@denx.de> Signed-o

[U-Boot] [PATCH 2/2] arm: socfpga: use imply instead of select where applicable

2018-02-12 Thread Simon Goldschmidt
port enabled - SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION: the boot rom supports a partitionless mode also, where SPL is located at address 0 - HW_WATCHDOG: while all mainline board defconfigs use it, U-Boot should still work without it. Signed-off-by: Simon Goldschmidt <sgoldschm...@de.

[U-Boot] [PATCH v3] spl: unbreak CONFIG_SPL_MULTI_DTB_FIT after fixing CONFIG_OF_EMBED

2018-02-13 Thread Simon Goldschmidt
p from dts/Makefile to scripts/Makefile.lib and includes scripts/Makefile.lib in scripts/Makefile.spl. Fixes: 9bd76b807636 ("spl: make CONFIG_OF_EMBED pass dts through fdtgrep") Reported-by: Lokesh Vutla <lokeshvu...@ti.com> Signed-off-by: Simon Goldschmidt <sgoldschm...@de.p

Re: [U-Boot] [PATCH v3 09/15] env: Support multiple environments

2018-02-06 Thread Simon Goldschmidt
On 23.01.2018 21:16, Maxime Ripard wrote: Now that we have everything in place to support multiple environment, let's make sure the current code can use it. I get more build errors testing this feature: there's a global variable 'env_ptr' declared in flash, nand, nvram and remote env drivers

Re: [U-Boot] [PATCH v3 12/15] env: Allow to build multiple environments in Kconfig

2018-02-06 Thread Simon Goldschmidt
On 05.02.2018 14:32, Maxime Ripard wrote: On Sat, Feb 03, 2018 at 10:23:12AM +, Goldschmidt Simon wrote: On 01.02.2018 20:47, Maxime Ripard wrote: On Thu, Feb 01, 2018 at 11:06:14AM +0100, Simon Goldschmidt wrote: On 23.01.2018 21:17, Maxime Ripard wrote: Now that we have everything

Re: [U-Boot] [PATCH v3 09/15] env: Support multiple environments

2018-02-07 Thread Simon Goldschmidt
On 07.02.2018 09:19, Maxime Ripard wrote: On Tue, Feb 06, 2018 at 09:09:07AM +0100, Simon Goldschmidt wrote: On 23.01.2018 21:16, Maxime Ripard wrote: Now that we have everything in place to support multiple environment, let's make sure the current code can use it. I get more build errors

Re: [U-Boot] [PATCH v3 09/15] env: Support multiple environments

2018-02-07 Thread Simon Goldschmidt
On 06.02.2018 09:20, Joakim Tjernlund wrote: On Thu, 1970-01-01 at 00:00 +, Simon Goldschmidt wrote: . Reviewed-by: Andre Przywara <andre.przyw...@arm.com> Reviewed-by: Simon Glass <s...@chromium.org> Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com> ---

Re: [U-Boot] [PATCH 2/2] arm: socfpga: cyclone5: Ensure spi-flash in the compatible string

2018-02-21 Thread Simon Goldschmidt
On 21.02.2018 08:40, chin.liang@intel.com wrote: From: Chin Liang See Ensure "spi-flash" is added into compatible string when there is NOR flash being instantiated in DTS. Discovered "sf probe" command without argument would hit error if spi-flash compatible

Re: [U-Boot] [RFC] Make U-Boot log great again

2018-02-21 Thread Simon Goldschmidt
On 21.02.2018 14:35, Tom Rini wrote: On Tue, Feb 20, 2018 at 10:59:33AM +0100, Lukasz Majewski wrote: On Tue, 20 Feb 2018 09:00:56 +0100 Maxime Ripard wrote: On Mon, Feb 19, 2018 at 07:47:52PM +0200, Sam Protsenko wrote: On 18 February 2018 at 23:22, Wolfgang Denk

Re: [U-Boot] [RFC] Make U-Boot log great again

2018-02-21 Thread Simon Goldschmidt
On 21.02.2018 15:54, Tom Rini wrote: On Wed, Feb 21, 2018 at 03:38:42PM +0100, Simon Goldschmidt wrote: On 21.02.2018 14:35, Tom Rini wrote: On Tue, Feb 20, 2018 at 10:59:33AM +0100, Lukasz Majewski wrote: On Tue, 20 Feb 2018 09:00:56 +0100 Maxime Ripard <maxime.rip...@bootlin.com>

Re: [U-Boot] [PATCH 1/2] arm: socfpga: cyclone5: Enable Macronix flash support

2018-02-21 Thread Simon Goldschmidt
On 22.02.2018 07:29, See, Chin Liang wrote: On Wed, 2018-02-21 at 20:23 +0100, Marek Vasut wrote: On 02/21/2018 08:39 AM, chin.liang@intel.com wrote: From: Chin Liang See Enable Macronix flash support for Cyclone5 SoC Do these boards actually have a macronix

Re: [U-Boot] [PATCH] ARM: socfpga: Convert to DM serial

2018-08-03 Thread Simon Goldschmidt
Marek Vasut schrieb am Fr., 3. Aug. 2018, 11:00: > On 08/03/2018 10:40 AM, Simon Goldschmidt wrote: > > > > > > On 01.08.2018 09:34, Marek Vasut wrote: > >> On 08/01/2018 09:29 AM, Goldschmidt Simon wrote: > >>> > >>> On 30.07.2018 16:04, M

Re: [U-Boot] [PATCH] ARM: socfpga: Convert to DM serial

2018-08-03 Thread Simon Goldschmidt
On 01.08.2018 09:34, Marek Vasut wrote: On 08/01/2018 09:29 AM, Goldschmidt Simon wrote: On 30.07.2018 16:04, Marek Vasut wrote: On 07/30/2018 04:03 PM, Simon Goldschmidt wrote: On 12.05.2018 22:28, Marek Vasut wrote: Pull the serial port configuration from DT and use DM serial instead

Re: [U-Boot] [PATCH] ARM: socfpga: Convert to DM serial

2018-08-03 Thread Simon Goldschmidt
Marek Vasut schrieb am Fr., 3. Aug. 2018, 11:22: > On 08/03/2018 11:10 AM, Simon Goldschmidt wrote: > > > > > > Marek Vasut mailto:ma...@denx.de>> schrieb am Fr., 3. > > Aug. 2018, 11:00: > > > > On 08/03/2018 10:40 AM, Simon Goldschmidt wrote: &

[U-Boot] [PATCH 2/2] FIT image: use compression = "none" for ramdisks

2018-07-30 Thread Simon Goldschmidt
To prepare supporting compression for all image types, change compression to "none" for ramdisks in all examples. Signed-off-by: Simon Goldschmidt --- arch/arm/cpu/armv8/fsl-layerscape/doc/README.falcon | 2 +- doc/README.bcm7xxx | 2 +- doc/

Re: [U-Boot] [PATCH 2/2] FIT image: use compression = "none" for ramdisks

2018-07-30 Thread Simon Goldschmidt
On 30.07.2018 15:25, Wolfgang Denk wrote: Dear Simon, In message <0787afb7-2da1-4eaa-437e-6f7c75828...@de.pepperl-fuchs.com> you wrote: I'd still argue that the standard example in 'multi.its' should have compression = "none" for the ramdisks. OK, this is your position then. I can only

[U-Boot] [PATCH 1/2] doc: FIT image: clarify usage of "compression" property

2018-07-30 Thread Simon Goldschmidt
Compressed images should have their compression property set to "none" if U-Boot should leave them compressed. This is especially the case for compressed ramdisks that should be uncompressed by the kernel only. Signed-off-by: Simon Goldschmidt --- doc/uImage.FIT/source_file_form

Re: [U-Boot] [PATCH 1/2] doc: FIT image: clarify usage of "compression" property

2018-07-30 Thread Simon Goldschmidt
On 30.07.2018 13:19, Wolfgang Denk wrote: Dear Simon, In message <20180730105319.79424-1-sgoldschm...@de.pepperl-fuchs.com> you wrote: Compressed images should have their compression property set to "none" if U-Boot should leave them compressed. This is especially the case for compressed

Re: [U-Boot] [PATCH 1/2] doc: FIT image: clarify usage of "compression" property

2018-07-30 Thread Simon Goldschmidt
Dear Wolfgang, On 30.07.2018 13:46, Wolfgang Denk wrote: Dear Simon, In message <6009778b-1c55-d67b-26a5-7d9039c85...@de.pepperl-fuchs.com> you wrote: It might seem obvious to you, but given the examples had both "none" and "gzip" for ramdisk, it seems it has not been obvious for everybody.

Re: [U-Boot] [PATCH 1/2] doc: FIT image: clarify usage of "compression" property

2018-07-30 Thread Simon Goldschmidt
On 30.07.2018 14:44, Wolfgang Denk wrote: Dear Simon, In message <642b8dae-f941-5255-42c7-3761e12d0...@de.pepperl-fuchs.com> you wrote: As I'm not that long with U-Boot, can you point me to a rough date of a release that I could check to see if it worked at that time? I can only

Re: [U-Boot] [PATCH] spl: fit: Enable GZIP compression also for no kernel partitions

2018-07-30 Thread Simon Goldschmidt
ctice of "-C none" on compressed ramdisks for legacy style images). And per Simon Goldschmidt's suggestion, after we've made the docs clearer, making it so that U-Boot does decompress things would be good, but we may also need to make that behavior configurable as I can see people having pu

Re: [U-Boot] [PATCH] ARM: socfpga: Convert to DM serial

2018-07-30 Thread Simon Goldschmidt
On 12.05.2018 22:28, Marek Vasut wrote: Pull the serial port configuration from DT and use DM serial instead of having the serial configuration in two places, DT and board config. Signed-off-by: Marek Vasut Cc: Chin Liang See Cc: Dinh Nguyen --- arch/arm/Kconfig

Re: [U-Boot] [PATCH 2/2] FIT image: use compression = "none" for ramdisks

2018-07-30 Thread Simon Goldschmidt
Dear Wolfgang, On 30.07.2018 13:45, Wolfgang Denk wrote: Dear Simon, In message <20180730105319.79424-2-sgoldschm...@de.pepperl-fuchs.com> you wrote: To prepare supporting compression for all image types, change compression to "none" for ramdisks in all examples. What makes you think this

Re: [U-Boot] [PATCH 2/2] FIT image: use compression = "none" for ramdisks

2018-07-30 Thread Simon Goldschmidt
On 30.07.2018 14:36, Wolfgang Denk wrote: Dear Simon, In message <6bce9049-a812-d8e4-cd2a-4b86dccae...@de.pepperl-fuchs.com> you wrote: However, uncompression currently is only implemented for kernels, not for other sub-images. This patch aims at updating the docs and the current .its

Re: [U-Boot] [PATCH 1/2] doc: FIT image: clarify usage of "compression" property

2018-07-30 Thread Simon Goldschmidt
On 30.07.2018 14:32, Wolfgang Denk wrote: Dear Simon, In message you wrote: These may be different examples, documenting different use cases which do exactly what they say? That might well be, but given that compression in FIT images only works for kernel sub-images up to now, I

Re: [U-Boot] [PATCH v5] u-boot: remove driver lookup loop from env_save()

2018-07-25 Thread Simon Goldschmidt
n list but it should save the environment into the location stored in gd->env_load_location by the last env_load() call. Signed-off-by: Nicholas Faustini Reviewed-by: Simon Goldschmidt --- Changes in v5: - Correction to 'Reviewed-by' tag Changes in v4: - Remove env_load_location from g

Re: [U-Boot] [PATCH] spl: fit: Enable GZIP compression also for no kernel partitions

2018-07-26 Thread Simon Goldschmidt
On 26.07.2018 08:52, Michal Simek wrote: On 25.7.2018 23:18, York Sun wrote: On 07/24/2018 10:58 PM, Michal Simek wrote: On 24.7.2018 18:26, York Sun wrote: On 07/24/2018 06:07 AM, Michal Simek wrote: There is no reason to limit gzip usage only for OS_BOOT and kernel image type.

Re: [U-Boot] [PATCH] ARM: socfpga: Convert to DM serial

2018-08-03 Thread Simon Goldschmidt
On 03.08.2018 13:01, Simon Goldschmidt wrote: Marek Vasut mailto:ma...@denx.de>> schrieb am Fr., 3. Aug. 2018, 11:22: On 08/03/2018 11:10 AM, Simon Goldschmidt wrote: > > > Marek Vasut mailto:ma...@denx.de> <mailto:ma...@denx.de <mailto:ma.

[U-Boot] [PATCH 1/5] arm: socfpga: fix SPL on gen5 after moving to DM serial

2018-08-05 Thread Simon Goldschmidt
There were some NULL pointers dereferenced because DM was used too early without correct initialization. This fixes commit 73172753f4f3 ("ARM: socfpga: Convert to DM serial") Signed-off-by: Simon Goldschmidt --- arch/arm/mach-socfpga/spl_gen5.c | 10 +++--- 1 file changed, 7

  1   2   3   4   5   6   7   8   9   10   >