U-Boot custodian workflow

2020-05-15 Thread Remy Bohmer
Hi, Regarding the Custodian workflow I have a general question: why do we follow a rebase flow for the custodian trees? If custodians merge master frequently into their own branches and merge that back on pull requests would technically work too right? But there are downsides to it why this is

Re: [U-Boot] [PATCH] eth: remove usb-ethernet devices before re-enumerating them

2012-01-15 Thread Remy Bohmer
Hi, 2012/1/9 Vincent Palatin vpala...@chromium.org: Fix the crash when running several times usb_init() with a USB ethernet device plugged. Signed-off-by: Vincent Palatin vpala...@chromium.org Tested-by: Wolfgang Grandegger w...@denx.de ---  drivers/usb/eth/usb_ether.c |    7 +--  

Re: [U-Boot] [PATCH] USB: relax usbcore reset timings

2012-01-15 Thread Remy Bohmer
high speed devices. Furthermore, the wait is only done once after power has been enabled on all ports. CC: Remy Bohmer li...@bohmer.net CC: Vincent Palatin vpala...@chromium.org Signed-off-by: Wolfgang Grandegger w...@denx.de ---  common/usb.c |    5 -  1 files changed, 4 insertions

Re: [U-Boot] [PATCH] USB: fix USB keyboard polling parameter

2012-01-15 Thread Remy Bohmer
Hi, 2012/1/9 Vincent Palatin vpala...@chromium.org: When doing a GET_REPORT request on the keyboard control endpoint, the report ID should 0 (ie report ID not used) rather than 1 as reports are not used in boot mode. Signed-off-by: Vincent Palatin vpala...@chromium.org --- Applied to

Re: [U-Boot] [PATCH] usb: add numeric keypad support to HID driver

2012-01-15 Thread Remy Bohmer
Hi, 2012/1/9 Vincent Palatin vpala...@chromium.org: When keys are pressed on the numeric keypad, emit key codes for the numbers, operators, dot and enter. Signed-off-by: Vincent Palatin vpala...@chromium.org ---  common/usb_kbd.c |   10 ++  1 files changed, 10 insertions(+), 0

Re: [U-Boot] [PATCH v4 14/20] usb: Add support for txfifo threshold

2012-01-15 Thread Remy Bohmer
+++  drivers/usb/host/ehci.h     |    6 +-  3 files changed, 15 insertions(+), 1 deletions(-) Acked-by: Remy Bohmer li...@bohmer.net ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] USB: reevaluate iomux stdin on USB kbd detect

2012-01-15 Thread Remy Bohmer
Hi, 2011/12/23 Allen Martin amar...@nvidia.com: If CONSOLE_MUX is enabled, reevaluate console stdin when USB keyboard device is detected. Signed-off-by: Allen Martin amar...@nvidia.com ---  common/usb_kbd.c |    6 ++  1 files changed, 6 insertions(+), 0 deletions(-) Applied to

Re: [U-Boot] [PATCH] USB: move keyboard polling into kbd driver

2012-01-15 Thread Remy Bohmer
Hi, 2011/12/21 Allen Martin amar...@nvidia.com: This moves keyboard polling logic from USB HCD drivers into USB keyboard driver.  Remove usb_event_poll() as keyboard polling was the only user of this API.  With this patch USB keyboard works with EHCI controllers again.  Tested on a tegra2

Re: [U-Boot] [PATCH v4 16/20] tegra: usb: Add support for Tegra USB peripheral

2012-01-15 Thread Remy Bohmer
{                /* This defines the order of our USB ports */                usb0 = /usb@0xc5008000;                usb1 = /usb@0xc500;        }; drivers/usb/host files ONLY: Acked-by: Remy Bohmer li...@bohmer.net Signed-off-by: Simon Glass s...@chromium.org --- Changes in v2: - Rename

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2012-01-15 Thread Remy Bohmer
Hi All, 2011/12/22 Ilya Yanok ya...@emcraft.com: Hi Govindraj, On 22.12.2011 10:55, Govindraj wrote: Signed-off-by: Ilya Yanok ya...@emcraft.com --- Changes from V3:  - None Changes from V2:  - None Changes from V1:  - CONFIG_OMAP_EHCI_PHYx_RESET changed to

Re: [U-Boot] [PATCH] ehci: speed up initialization

2011-12-19 Thread Remy Bohmer
Hi Wolfgang, 2011/12/19 Wolfgang Grandegger w...@grandegger.com: On 12/19/2011 01:51 PM, Vincent Palatin wrote: On Mon, Dec 19, 2011 at 04:07, Wolfgang Grandegger w...@grandegger.com wrote: I just realized that this patch breaks usb start on my mx53loco board: The device is not found at

Re: [U-Boot] [PATCH] USB: move keyboard polling from EHCI driver into kbd driver

2011-12-17 Thread Remy Bohmer
Hi, 2011/12/16 Allen Martin amar...@nvidia.com: This removes dependency on global variable new from EHCI driver with CONFIG_SYS_USB_EVENT_POLL turned on and gets USB keyboard working with EHCI driver again. Signed-off-by: Allen Martin amar...@nvidia.com ---  common/usb_kbd.c            |  

Re: [U-Boot] [PATCH v2 1/4] USB: ULPI: switch argument type from u8 to unsigned

2011-12-16 Thread Remy Bohmer
Hi, 2011/12/16 Simon Glass s...@chromium.org: On Tue, Dec 13, 2011 at 10:16 PM, Igor Grinberg grinb...@compulab.co.il wrote: There is no benefit in using u8, so switch to unsigned to reduce the binary image size (by 20 bytes). Signed-off-by: Igor Grinberg grinb...@compulab.co.il Acked-by:

Re: [U-Boot] [PATCH 2/4] USB: ULPI: clean a mixup of return types

2011-12-16 Thread Remy Bohmer
Hi, 2011/12/12 Igor Grinberg grinb...@compulab.co.il: Clean a mixup between u32 and int as a return type for functions returning error values. Use int as it is native (and widely used) return type. Signed-off-by: Igor Grinberg grinb...@compulab.co.il ---  drivers/usb/ulpi/ulpi-viewport.c |

Re: [U-Boot] [PATCH 3/4] USB: ULPI: increase error case verbosity

2011-12-16 Thread Remy Bohmer
Hi, 2011/12/12 Igor Grinberg grinb...@compulab.co.il: Add the argument value to the error message. Signed-off-by: Igor Grinberg grinb...@compulab.co.il ---  drivers/usb/ulpi/ulpi.c |   12 ++--  1 files changed, 6 insertions(+), 6 deletions(-) Applied to -u-boot-usb. Thanks. Kind

Re: [U-Boot] [PATCH v3 3/3] usb:gadget:s5p Enable the USB Gadget framework at Exynos4210 (C210 Universal)

2011-12-16 Thread Remy Bohmer
...@samsung.com CC: Remy Bohmer li...@bohmer.net --- Changes for v2:        - Rename the S5PC210_Universal to Exynos4210 Changes for v3:        - status check removed        - SAFEOUT1 LDO enabled for USB operation        - Reorder of USB LDOs Applied to u-boot-usb. Thanks. Kind regards, Remy

Re: [U-Boot] [PATCH v2 1/1] USB: Use (get|put)_unaligned for accessing wMaxPacketSize

2011-12-16 Thread Remy Bohmer
, a macro. Cc: Minkyu Kang mk7.k...@samsung.com Cc: Remy Bohmer li...@bohmer.net OpenRISC: Tested-by: Stefan Kristiansson stefan.kristians...@saunalahti.fi Beagleboard xM, Pandaboard run-tested, s5p_goni build-tested. Signed-off-by: Tom Rini tr...@ti.com ---  common/cmd_usb.c

Re: [U-Boot] [PATCH 4/4] README: add documentation for CONFIG_USB_ULPI*

2011-12-16 Thread Remy Bohmer
Hi, 2011/12/16 Simon Glass s...@chromium.org: Hi Remy, On Fri, Dec 16, 2011 at 12:10 PM, Remy Bohmer li...@bohmer.net wrote: Hi Igor, Here the configs are documented. I admit, it is not that brilliant documentation... Are you planning to post an update of this patch? The rest

[U-Boot] Pull request: u-boot-usb

2011-12-16 Thread Remy Bohmer
The following changes since commit 06e42c6e2ce269667daecd6229d0b7c813838203: Merge branch 'ag...@denx.de' of git://git.denx.de/u-boot-staging (2011-12-12 14:51:16 +0100) are available in the git repository at: git://git.denx.de/u-boot-usb.git master Igor Grinberg (4): USB: ULPI:

Re: [U-Boot] [PATCH v3] AT91: pio: Add PIO3 features

2011-12-15 Thread Remy Bohmer
-by: Hong Xu hong...@atmel.com Maybe this helps getting this patch rolling again: Acked-by: Remy Bohmer li...@bohmer.net Kind regards, Remy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v1 3/3] usb:gadget:s5p Enable the USB Gadget framework at C210 Universal

2011-12-11 Thread Remy Bohmer
Hi Lukasz, 2011/11/27 Remy Bohmer li...@bohmer.net: Hi, 2011/10/27 Lukasz Majewski l.majew...@samsung.com: This commit enables support for USB Gadgets on the C210 Universal reference target. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p

[U-Boot] Pull request: u-boot-usb

2011-12-11 Thread Remy Bohmer
The following changes since commit c90a4dd79cb17abb46689f27ff9f1c971362d6e2: post/post.c: Use lldiv for 64-bit divisions (2011-12-10 23:15:14 +0100) are available in the git repository at: git://git.denx.de/u-boot-usb.git master Jana Rapava (1): USB: Add generic ULPI layer and a

[U-Boot] Pull request: u-boot-usb

2011-12-10 Thread Remy Bohmer
The following changes since commit c4eba6ec5c58083b38340724c006294c7a4fe2eb: common/usb_kbd.c: fix bug introduced in commit 00b7d6e (2011-12-09 12:09:35 +0100) are available in the git repository at: git://git.denx.de/u-boot-usb.git master Lei Wen (1): USB: gadaget: add Marvell

Re: [U-Boot] [PATCH v2 11/17] usb: Add support for data alignment

2011-12-10 Thread Remy Bohmer
Hi Simon, 2011/12/6 Simon Glass s...@chromium.org: I do not really like this solution. Maybe we can introduce something like an usbbuf_alloc() function that takes care of the alignment. This saves the memcpy() for every transmit. I know it has more impact if we do it like that, but I think

Re: [U-Boot] [PATCH] ehci: speed up initialization

2011-12-10 Thread Remy Bohmer
Hi, 2011/12/5 Vincent Palatin vpala...@chromium.org: According to EHCI specification v1.0, the controller should stabilize the power on a port at most 20 ms after the port power bit transition. So, we put this setting in the virtual descriptor corresponding field, (bPwrOn2PwrGood = 10 = 10 x

Re: [U-Boot] [PATCH v3 11/16] usb: Add support for txfifo threshold

2011-12-10 Thread Remy Bohmer
+++  drivers/usb/host/ehci.h     |    6 +-  3 files changed, 15 insertions(+), 1 deletions(-) Since it is part of a bigger series: Acked-by: Remy Bohmer li...@bohmer.net Kind regards, Remy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de

Re: [U-Boot] [PATCH 0/9] MX5x USB support

2011-12-10 Thread Remy Bohmer
Hi Marek, 2011/12/7 Marek Vasut marek.va...@gmail.com: This patchset adds the USB support for MX5x. Most of the code is based on work of Wolfgang Grandegger with modifications done by various other authors. I also included version of ULPI support code cleaned up by Igor Grinberg. NOTE: I'd

Re: [U-Boot] [PATCH 0/9] MX5x USB support

2011-12-10 Thread Remy Bohmer
Hi Marek, If some of the patches didn't make it through gmail because of the different From:, please check git://git.denx.de/u-boot-marex.git, usb branch. Pulling it failed. Can you please rebase it on top of current u-boot-usb, then I will pull it from there. Kind regards, Remy

Re: [U-Boot] [PATCH 5/9] drivers/usb/gadget/core.c: Fix GCC 4.6 warning

2011-12-04 Thread Remy Bohmer
Hi, 2011/12/3 Anatolij Gustschin ag...@denx.de: Fix: core.c: In function 'usbd_device_event_irq': core.c:596:21: warning: variable 'state' set but not used [-Wunused-but-set-variable] Signed-off-by: Anatolij Gustschin ag...@denx.de Cc: Remy Bohmer li...@bohmer.net ---  drivers/usb/gadget

Re: [U-Boot] [PATCH 4/9] drivers/usb/musb/musb_udc.c: Fix GCC 4.6 warning

2011-12-04 Thread Remy Bohmer
] musb_udc.c:165:5: warning: variable 'intrusb' set but not used [-Wunused-but-set-variable] Signed-off-by: Anatolij Gustschin ag...@denx.de Cc: Remy Bohmer li...@bohmer.net ---  drivers/usb/musb/musb_udc.c |    8 +++-  1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/usb

Re: [U-Boot] [PATCH v2 13/17] tegra: usb: Add support for Tegra USB peripheral

2011-12-04 Thread Remy Bohmer
kernel fdt) - Improve debug() printouts in case of failure to init USB  drivers/usb/host/Makefile                 |    1 +  drivers/usb/host/ehci-tegra.c             |   63 + As for this USB part: Acked-by: Remy Bohmer li...@bohmer.net Kind regards, Remy

Re: [U-Boot] [PATCH v2 11/17] usb: Add support for data alignment

2011-12-04 Thread Remy Bohmer
Hi, 2011/12/3 Simon Glass s...@chromium.org: CONFIG_USB_EHCI_DATA_ALIGN sets the required alignment of data for USB packets (e.g. 4 means word-aligned). This is required for Tegra to operate. Signed-off-by: Simon Glass s...@chromium.org --- Changes in v2: - Tidy code style in USB buffer

Re: [U-Boot] [PATCH 6/9] drivers/usb/gadget/ep0.c: Fix GCC 4.6 warning

2011-12-04 Thread Remy Bohmer
Hi, 2011/12/3 Anatolij Gustschin ag...@denx.de: Fix: ep0.c: In function 'ep0_get_descriptor': ep0.c:187:8: warning: variable 'cp' set but not used [-Wunused-but-set-variable] Signed-off-by: Anatolij Gustschin ag...@denx.de Cc: Remy Bohmer li...@bohmer.net ---  drivers/usb/gadget/ep0.c

Re: [U-Boot] [PATCH 4/5] usbtty: init endpoints prior to startup events

2011-11-30 Thread Remy Bohmer
Hi Stefan, 2011/11/28 Stefan Herbrechtsmeier sherb...@cit-ec.uni-bielefeld.de: Am 26.11.2011 23:25, schrieb Remy Bohmer: 2011/10/17 Stefan Herbrechtsmeiersherb...@cit-ec.uni-bielefeld.de: On some usb device controllers (pxa) the endpoint configuration must be programmed prior to enable

Re: [U-Boot] [PATCH 0/3] USB keyboard driver rework (round 2)

2011-11-26 Thread Remy Bohmer
] USB: Add usb_event_poll() to get keyboards working with EHCI Message-Id: 1316977676-10284-1-git-send-email-marek.va...@gmail.com Cc: Mike Frysinger vap...@gentoo.org Cc: Remy Bohmer li...@bohmer.net Cc: Wolfgang Denk w...@denx.de Marek Vasut (3):  USB: Squash checkpatch warnings in usb_kbd.c

Re: [U-Boot] [PATCH] ehci-fsl: correct size of ehci caplength

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/18 Kumar Gala ga...@kernel.crashing.org: On Oct 17, 2011, at 1:16 PM, Wolfgang Grandegger wrote: According to the EHCI specification the Capability Register Length has a size of 8 bits. Signed-off-by: Wolfgang Grandegger w...@denx.de --- include/usb/ehci-fsl.h |   25

Re: [U-Boot] [PATCH 1/5] pxa: fix usb host register mismatch

2011-11-26 Thread Remy Bohmer
Hi 2011/10/17 Stefan Herbrechtsmeier sherb...@cit-ec.uni-bielefeld.de: Signed-off-by: Stefan Herbrechtsmeier sherb...@cit-ec.uni-bielefeld.de CC: Marek Vasut marek.va...@gmail.com CC: Remy Bohmer  li...@bohmer.net ---  arch/arm/cpu/pxa/usb.c                   |    2 +-  arch/arm/include/asm

Re: [U-Boot] [PATCH 2/5] pxa: activate the first usb host port on pxa27x by default

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/17 Stefan Herbrechtsmeier sherb...@cit-ec.uni-bielefeld.de: The pxa27x has 3 usb host ports. Activate all by default. Signed-off-by: Stefan Herbrechtsmeier sherb...@cit-ec.uni-bielefeld.de CC: Marek Vasut marek.va...@gmail.com CC: Remy Bohmer  li...@bohmer.net ---  arch/arm/cpu

Re: [U-Boot] [PATCH 3/5] pxa: convert pxa27x_udc to use read and write functions

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/17 Marek Vasut marek.va...@gmail.com: On Monday, October 17, 2011 05:22:48 PM Stefan Herbrechtsmeier wrote: Signed-off-by: Stefan Herbrechtsmeier sherb...@cit-ec.uni-bielefeld.de CC: Marek Vasut marek.va...@gmail.com CC: Remy Bohmer  li...@bohmer.net --- Hi Stefan, this patch

Re: [U-Boot] [PATCH 4/5] usbtty: init endpoints prior to startup events

2011-11-26 Thread Remy Bohmer
: Remy Bohmer  li...@bohmer.net ---  drivers/serial/usbtty.c |    4 ++--  1 files changed, 2 insertions(+), 2 deletions(-) Applied to u-boot-usb Kind regards, Remy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 5/5] pxa: fix relocation

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/17 Stefan Herbrechtsmeier sherb...@cit-ec.uni-bielefeld.de: The current relocation don't work correct, as it doesn't clear the initial ram (dcache) after relocation. This leads to missing bootargs during Linux boot. Additionally the current relocation use the sdram address for the

Re: [U-Boot] [PATCH] usb: align usb_endpoint_descriptor to 16-bit boundary

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/20 Stefan Kristiansson stefan.kristians...@saunalahti.fi: The usb_endpoint_descriptor struct is 7 bytes large and is defined as an array (ep_desc[USB_MAXENDPOINTS]) in the usb_interface struct in include/usb.h This fact will result in that every odd index in that array will

Re: [U-Boot] [PATCH v5 1/3] usb:gadget:s5p USB Device Controller (UDC) implementation

2011-11-26 Thread Remy Bohmer
...@samsung.com Cc: Minkyu Kang mk7.k...@samsung.com Cc: Remy Bohmer li...@bohmer.net --- Changes for v2:        - Coding cleanups and fixes        - s3c_udc* files history and origination added        - regs-otg.h rewritten to use structs instedad of          #defines Changes for v3:        - D

Re: [U-Boot] [PATCH v1 3/3] usb:gadget:s5p Enable the USB Gadget framework at C210 Universal

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/27 Lukasz Majewski l.majew...@samsung.com: This commit enables support for USB Gadgets on the C210 Universal reference target. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Minkyu Kang mk7.k...@samsung.com ---

Re: [U-Boot] [PATCH v2 3/3] usb:gadget:s5p Support for USB Mass Storage Gadget at GONI

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/18 Lukasz Majewski l.majew...@samsung.com: This patch adds support for USB Mass Storage Gadget on the Samsung's GONI reference target Signed-off-by: Lukasz Majewski l.majew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Remy Bohmer li...@bohmer.net Cc

Re: [U-Boot] [PATCH 2/2] usb: add help for missing start subcommand

2011-11-26 Thread Remy Bohmer
Hi, 2011/11/2 Veli-Pekka Peltola veli-pekka.pelt...@bluegiga.com: Signed-off-by: Veli-Pekka Peltola veli-pekka.pelt...@bluegiga.com Cc: Remy Bohmer li...@bohmer.net --- When I first time used USB framework it was not so obvious to start with usb reset to get everything going on. So lets add

Re: [U-Boot] [PATCH 1/2] cosmetic: remove excess whitespace from usb command help

2011-11-26 Thread Remy Bohmer
Hi, 2011/11/2 Veli-Pekka Peltola veli-pekka.pelt...@bluegiga.com: Signed-off-by: Veli-Pekka Peltola veli-pekka.pelt...@bluegiga.com Cc: Remy Bohmer li...@bohmer.net ---  common/cmd_usb.c |   10 +-  1 files changed, 5 insertions(+), 5 deletions(-) Applied to u-boot-usb. Thanks. Kind

Re: [U-Boot] [PATCH] drivers/usb/host/ehci-mxc.c: Fix GCC 4.6 warning

2011-11-26 Thread Remy Bohmer
Hi, 2011/11/19 Anatolij Gustschin ag...@denx.de: Fix: ehci-mxc.c: In function 'ehci_hcd_init': ehci-mxc.c:113:6: warning: variable 'tmp' set but not used [-Wunused-but-set-variable] Signed-off-by: Anatolij Gustschin ag...@denx.de ---  drivers/usb/host/ehci-mxc.c |    3 +--  1 files

Re: [U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver

2011-10-09 Thread Remy Bohmer
Hi Marek, it's hard to evaluate each piece by itself when it's just one patch smooshing it all together Well how would you rework crap code piece by piece? - fix style - abstract out stuff Not like there was so much abstraction it couldn't be squashed into this one. - add new

Re: [U-Boot] [PATCH 1/2 V3] USB: Fix complaints about strict aliasing in OHCI-HCD

2011-10-08 Thread Remy Bohmer
Hi, 2011/10/7 Marek Vasut marek.va...@gmail.com: Signed-off-by: Marek Vasut marek.va...@gmail.com ---  drivers/usb/host/ohci-hcd.c |   75 --  1 files changed, 43 insertions(+), 32 deletions(-) Applied to u-boot-usb. Thanks. V2: Fix comment, use union

Re: [U-Boot] [PATCH 5/7] common/cmd_usb.c: fix warning: variable ... set but not used

2011-10-08 Thread Remy Bohmer
Hi, 2011/10/5 Wolfgang Denk w...@denx.de: Fix: cmd_usb.c: In function 'usb_show_tree_graph': cmd_usb.c:284:29: warning: variable 'port' set but not used [-Wunused-but-set-variable] Signed-off-by: Wolfgang Denk w...@denx.de Cc: Remy Bohmer li...@bohmer.net ---  common/cmd_usb.c |    3

Re: [U-Boot] [PATCH 6/7] drivers/usb/host/ohci-hcd.c: fix warning: variable ... set but not used

2011-10-08 Thread Remy Bohmer
Hi, 2011/10/5 Wolfgang Denk w...@denx.de: Fix: ohci-hcd.c: In function 'dl_transfer_length': ohci-hcd.c:968:8: warning: variable 'tdINFO' set but not used [-Wunused-but-set-variable] Signed-off-by: Wolfgang Denk w...@denx.de Cc: Remy Bohmer li...@bohmer.net ---  drivers/usb/host/ohci

Re: [U-Boot] [PATCH 7/7] common/usb.c: fix warning: variable ... set but not used

2011-10-08 Thread Remy Bohmer
[-Wunused-but-set-variable] usb.c: In function 'usb_hub_configure': usb.c:1183:25: warning: variable 'hubsts' set but not used [-Wunused-but-set-variable] Signed-off-by: Wolfgang Denk w...@denx.de Cc: Remy Bohmer li...@bohmer.net ---  common/usb.c |   20 +---  1 files changed, 13

Re: [U-Boot] [PATCH] USB: gadaget: add Marvell controller support

2011-10-08 Thread Remy Bohmer
Hi, 2011/10/5 Lei Wen lei...@marvell.com: Signed-off-by: Lei Wen lei...@marvell.com ---  drivers/usb/gadget/Makefile       |    1 +  drivers/usb/gadget/gadget_chips.h |    7 +  drivers/usb/gadget/mv_udc.c       |  499 +  include/usb/mv_udc.h            

Re: [U-Boot] [PATCH V2] USB: Add usb_event_poll() to get keyboards working with EHCI

2011-10-08 Thread Remy Bohmer
Hi Marek, 2011/10/7 Marek Vasut marek.va...@gmail.com: On Friday, October 07, 2011 07:25:22 AM Wolfgang Denk wrote: Dear Marek Vasut, In message 201110070130.14881.marek.va...@gmail.com you wrote: Checkpatch says: total: 0 errors, 1 warnings, 43 lines checked Please clean up

Re: [U-Boot] [PATCH V2] USB: Add usb_event_poll() to get keyboards working with EHCI

2011-10-08 Thread Remy Bohmer
Hi, 2011/9/25 Marek Vasut marek.va...@gmail.com: Signed-off-by: Marek Vasut marek.va...@gmail.com Cc: Remy Bohmer li...@bohmer.net ---  drivers/usb/host/ehci-hcd.c |   33 -  1 files changed, 32 insertions(+), 1 deletions(-) V2: Drop redundant bogus header

Re: [U-Boot] [PATCH 2/2] USB: Drop dead code from usb_kbd.c

2011-10-08 Thread Remy Bohmer
Hi Marek, 2011/10/7 Marek Vasut marek.va...@gmail.com: Signed-off-by: Marek Vasut marek.va...@gmail.com Cc: Wolfgang Denk w...@denx.de Cc: Remy Bohmer li...@bohmer.net ---  common/usb_kbd.c |  369 --  1 files changed, 0 insertions

Re: [U-Boot] [PATCH V2] USB: Add functionality to poll the USB keyboard via control EP

2011-10-08 Thread Remy Bohmer
Hi, 2011/10/7 Wolfgang Denk w...@denx.de: Dear Marek Vasut, In message 201110070131.53775.marek.va...@gmail.com you wrote: Checkpatch says: total: 5 errors, 1 warnings, 97 lines checked ... Please see my previous comment about the state of usbkbd.c. The warnings are from original

Re: [U-Boot] [PATCH V2] USB: Add functionality to poll the USB keyboard via control EP

2011-10-08 Thread Remy Bohmer
. Signed-off-by: Marek Vasut marek.va...@gmail.com Cc: Remy Bohmer li...@bohmer.net ---  common/usb_kbd.c |   64 ++---  1 files changed, 50 insertions(+), 14 deletions(-) V2: Add missing condition to ignore repetitive events when polling via

Re: [U-Boot] [PATCH v3] Add USB support for Efika

2011-09-24 Thread Remy Bohmer
Hi Stefano, 2011/9/19 Stefano Babic sba...@denx.de: you change several files, some of them in the general USB support. You must then split your patch into a patchset, and each patch must address a single issue. Really with your patch you do not only add USB support to the EfikaMX board, but

Re: [U-Boot] [PATCH] arm, usb, davinci: make USBPHY_CTL register configurable

2011-09-24 Thread Remy Bohmer
post this patchset again with this patch in it! Can I add then your Acked-by for this patch? Acked-by: Remy Bohmer li...@bohmer.net Kind regards, Remy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] USB: Add usb_event_poll() to get keyboards working with EHCI

2011-09-24 Thread Remy Bohmer
Hi, 2011/9/23 Marek Vasut marek.va...@gmail.com: Signed-off-by: Marek Vasut marek.va...@gmail.com Cc: Remy Bohmer li...@bohmer.net ---  drivers/usb/host/ehci-hcd.c |   33 -  1 files changed, 32 insertions(+), 1 deletions(-) diff --git a/drivers/usb/host/ehci

Re: [U-Boot] [PATCH] USB: Add usb_event_poll() to get keyboards working with EHCI

2011-09-24 Thread Remy Bohmer
Hi, 2011/9/24 Marek Vasut marek.va...@gmail.com: On Saturday, September 24, 2011 06:41:58 PM Remy Bohmer wrote: Hi, 2011/9/23 Marek Vasut marek.va...@gmail.com: Signed-off-by: Marek Vasut marek.va...@gmail.com Cc: Remy Bohmer li...@bohmer.net ---  drivers/usb/host/ehci-hcd.c |   33

Re: [U-Boot] [PATCH] ASIX: Fix buffer access in asix_get_phy_addr()

2011-09-24 Thread Remy Bohmer
Hi, 2011/9/23 Marek Vasut marek.va...@gmail.com: Signed-off-by: Marek Vasut marek.va...@gmail.com ---  drivers/usb/eth/asix.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/eth/asix.c b/drivers/usb/eth/asix.c Applied to u-boot-usb. Thanks. Remy

Re: [U-Boot] [PATCH v3 0/2] usb:gadget:s5p USB Device Controller (UDC) implementation

2011-09-24 Thread Remy Bohmer
Hi, 2011/9/16 Lukasz Majewski l.majew...@samsung.com: Dear all, This patch series adds support for Samsung's USB Device Controller (UDC) on GONI reference target. --- Depend on: http://patchwork.ozlabs.org/patch/112847/ Lukasz Majewski (2):   usb:gadget:s5p USB Device Controller (UDC)

Re: [U-Boot] [PATCH 2/2] GCC4.6: Remove unused port variable in cmd_usb.c

2011-09-24 Thread Remy Bohmer
;                                while (i++ dev-parent-maxchild) {                                        if (dev-parent-children[i] != NULL) {                                                /* found a sister */ If it was not part of a patch-series, I would have pulled it in directly... Acked-by: Remy Bohmer li

Re: [U-Boot] [PATCH 3/6] USB: Fix complaints about strict aliasing in OHCI-HCD

2011-09-24 Thread Remy Bohmer
Hi Marek, 2011/8/28 Marek Vasut marek.va...@gmail.com: Signed-off-by: Marek Vasut marek.va...@gmail.com ---  drivers/usb/host/ohci-hcd.c |   69 +++---  1 files changed, 38 insertions(+), 31 deletions(-) I guess this is a v3 of this patch. Am I right?

[U-Boot] Pull request: u-boot-usb

2011-09-24 Thread Remy Bohmer
The following changes since commit 279bbbca12e71ae68278b756048194003a6d6e21: Merge branch 'master' of git://git.denx.de/u-boot-arm (2011-09-23 08:23:25 +0200) are available in the git repository at: git://git.denx.de/u-boot-usb.git master Marek Vasut (1): ASIX: Fix buffer access in

Re: [U-Boot] [RFC] fastboot gadget support

2011-08-24 Thread Remy Bohmer
Hi, 2011/8/10 Sebastian Andrzej Siewior bige...@linutronix.de: It was tested before it has been re-written. It is possible that it is broken. It is posted for reference only not for merging. Looking at this code, I can already say that the way it is written is not suitable for mainline

Re: [U-Boot] [PATCH 1/2][v2] powerpc/85xx: Add ULPI and UTMI USB Phy support for P1010/P1014

2011-08-13 Thread Remy Bohmer
- Use both getenv() and hwconfig to get USB phy type till getenv()   is depricated - Introduce CONFIG_SYS_FSL_USB_INTERNAL_UTMI_PHY to specify if soc   has internal UTMI phy Signed-off-by: Ramneek Mehresh ramneek.mehr...@freescale.com CC: Remy Bohmer li...@bohmer.net Signed-off-by: Kumar Gala

Re: [U-Boot] [RFC] fastboot gadget support

2011-08-13 Thread Remy Bohmer
Hi Sebastian, 2011/8/10 Sebastian Andrzej Siewior bige...@linutronix.de: This is the faastboot gadget code based on git://git.omapzoom.org/repo/u-boot.git as of commit 601ff71c8 including a few changes. Some of them are: - generic mmc framework - new gadget framework - different / easier

Re: [U-Boot] [PATCH v2] MUSB timeout broken

2011-08-08 Thread Remy Bohmer
Hi, 2011/7/4 Orjan Friberg o...@flatfrog.com: Use pre-decrement to leave timeout at 0 when the timeout happens (which is what the timeout detecting code expects). Signed-off-by: Orjan Friberg o...@flatfrog.com ---  drivers/usb/musb/musb_hcd.c |    2 +-  1 files changed, 1 insertions(+),

Re: [U-Boot] [PATCH v2] MUSB timeout broken

2011-08-08 Thread Remy Bohmer
Hi, 2011/7/4 Orjan Friberg o...@flatfrog.com: Use pre-decrement to leave timeout at 0 when the timeout happens (which is what the timeout detecting code expects). Signed-off-by: Orjan Friberg o...@flatfrog.com ---  drivers/usb/musb/musb_hcd.c |    2 +-  1 files changed, 1 insertions(+),

Re: [U-Boot] [PATCH] usb: r8a66597: Fix argument mistake of inl

2011-08-08 Thread Remy Bohmer
Hi, 2011/7/11 Nobuhiro Iwamatsu iwama...@nigauri.org: Fail in build, because argument of inl used in r8a66597_read_fifo is wrong. r8a66597.h:441:35: error: macro inl passed 2 arguments, but takes just 1 In file included from r8a66597-hcd.c:25: r8a66597.h: In function ‘r8a66597_read_fifo’:

Re: [U-Boot] [PATCH 5/5] USB: Set portnr so USB1.1 and 1.0 devices work on EHCI controllers

2011-08-08 Thread Remy Bohmer
Hi, 2011/7/12 Marek Vasut marek.va...@gmail.com: Signed-off-by: Marek Vasut marek.va...@gmail.com ---  common/usb.c |    1 +  1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/common/usb.c b/common/usb.c index 8e84266..a401c09 100644 --- a/common/usb.c +++ b/common/usb.c @@

Re: [U-Boot] [PATCH 4/5] USB: Move USB_PRINTF() out of ifdef in usb_scan_devices()

2011-08-08 Thread Remy Bohmer
.. It is a holiday season... ;-) Acked-by: Remy Bohmer li...@bohmer.net (It can go with the rest of the series) Kind regards, Remy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 4/5] USB: Move USB_PRINTF() out of ifdef in usb_scan_devices()

2011-08-08 Thread Remy Bohmer
Hi, Yea of course ... I sent this to Remy some time ago already, got no response so far ... Hey.. It is a holiday season... ;-) Acked-by: Remy Bohmer li...@bohmer.net (It can go with the rest of the series) Seems that it time to go again on a next vacation... I just pulled in 5/5

Re: [U-Boot] [PATCH 1/2] powerpc/85xx: Add ULPI and UTMI USB Phy support for P1010/P1014

2011-08-08 Thread Remy Bohmer
type till getenv()   is depricated  - Introduce CONFIG_SYS_FSL_USB_INTERNAL_UTMI_PHY to specify if soc   has internal UTMI phy Signed-off-by: Ramneek Mehresh ramneek.mehr...@freescale.com CC: Remy Bohmer li...@bohmer.net Signed-off-by: Kumar Gala ga...@kernel.crashing.org ---  arch/powerpc

Re: [U-Boot] [PATCH v2] usb: increase non-bulk timeout for slow chipsets.

2011-08-08 Thread Remy Bohmer
Hi, 2011/8/4 Jason u-b...@lakedaemon.net: Remy, I neglected to include you in my original submission, could you please take a look at this for u-boot-usb?  Original email is here [1].  And the commit I'm referring to is here [2]. No problem... I am subscribed to the list, and I have seen it

Re: [U-Boot] [PATCH] arm, usb, davinci: make USBPHY_CTL register configurable

2011-08-08 Thread Remy Bohmer
Hi, 2011/8/2 Heiko Schocher h...@denx.de: Define CONFIG_DV_USBPHY_CTL for setting the USB PHY control register. Signed-off-by: Heiko Schocher h...@denx.de cc: Sandeep Paulraj s-paul...@ti.com cc: Remy Bohmer li...@bohmer.net ---  drivers/usb/musb/davinci.c |    6 +-  1 files changed

[U-Boot] Pull request: u-boot-usb

2011-08-08 Thread Remy Bohmer
The following changes since commit fa82f871c8dbc9a15e8dc274b3f99dd5fa0da458: Convert ISO-8859 files to UTF-8 (2011-08-04 23:34:02 +0200) are available in the git repository at: git://git.denx.de/u-boot-usb.git master Jason Cooper (1): usb: increase non-bulk timeout for slow chipsets.

Re: [U-Boot] [PATCH v2] usb: increase non-bulk timeout for slow chipsets.

2011-08-08 Thread Remy Bohmer
Hi, 2011/7/31 Jason Cooper u-b...@lakedaemon.net: If you take a look at 96820a35, you'll see the original timeout was CONFIG_SYS_HZ.  Which is 1000.  After the mentioned change, non-bulk timeout was changed to 100.  This causes timeout failures on the dreamplug platform when trying to

Re: [U-Boot] [PATCH 1/2] powerpc/85xx: Add ULPI and UTMI USB Phy support for P1010/P1014

2011-08-08 Thread Remy Bohmer
Hi, The ifdef-ery makes the code somewhat messy as well. Can it be written somewhat else? Apart from that and the style issues, no remarks or concerns. Not really sure how to do that.  The patch is a bit more messy than the actual code. I was talking about the actual code, not the

Re: [U-Boot] status of patches in usb next branch

2011-07-30 Thread Remy Bohmer
Hi, 2011/7/11 John Rigby john.ri...@linaro.org: Remy, Are the patches in your next branch candidates for moving to master and doing a pull request or is there still work to be done? Things have been pushed to u-boot-usb master,and there will be a pull-request. Kind regards, Remy

Re: [U-Boot] [PATCH 0/2] usb:gadget: Linux USB Gadget framework

2011-07-05 Thread Remy Bohmer
Hi, 2011/7/5 Lukasz Majewski l.majew...@samsung.com: Included commits provide Linux USB gadget support for U-boot. The USB Gadget infrastructure is running on top of the Samsung's UDC OTG controller. The code has been tested on the GONI (S5PC110) reference target. Files:

[U-Boot] Pull request: u-boot-usb

2011-06-25 Thread Remy Bohmer
The following changes since commit 9623c158f6a5150a21c25026bfba79e7ff7912f5: Merge branch 'master' of git://git.denx.de/u-boot-arm (2011-06-23 15:37:33 +0200) are available in the git repository at: git://git.denx.de/u-boot-usb.git master Cliff Cai (1): musb: process control messages

Re: [U-Boot] [PATCH] usb: convert to partial linking

2011-06-25 Thread Remy Bohmer
Hi, 2011/6/25 Mike Frysinger vap...@gentoo.org: Looks like this was missed during the conversion to partial linking. Signed-off-by: Mike Frysinger vap...@gentoo.org ---  Makefile                 |    2 +-  drivers/usb/eth/Makefile |    4 ++--  2 files changed, 3 insertions(+), 3

Re: [U-Boot] [PATCH v8 2/4] Add Ethernet hardware MAC address framework to usbnet

2011-06-20 Thread Remy Bohmer
Hi, 2011/6/14 Simon Glass s...@chromium.org: Built-in Ethernet adapters support setting the mac address by means of a ethaddr environment variable for each interface (ethaddr, eth1addr, eth2addr). This adds similar support to the USB network side, using the names usbethaddr, usbeth1addr,

Re: [U-Boot] [PATCH v8 1/4] Add support for SMSC95XX USB 2.0 10/100MBit Ethernet Adapter

2011-06-20 Thread Remy Bohmer
Hi, 2011/6/14 Simon Glass s...@chromium.org: The SMSC95XX is a USB hub with a built-in Ethernet adapter. This adds support for this, using the USB host network framework. Changes for v2: - Coding style cleanup - Changed some comments as suggested Changes for v3: - Change turbo_mode to

Re: [U-Boot] [PATCH v8 3/4] Add documentation for USB Host Networking

2011-06-20 Thread Remy Bohmer
Hi, 2011/6/14 Simon Glass s...@chromium.org: This describes what it is for, devices supported, how to enable for your board in U-Boot, setting up the server, and notes about MAC addresses. Changes for v6: - Adjust documentation file according to Wolfgang's comments Signed-off-by: Simon

Re: [U-Boot] [PATCH v8 4/4] Put common autoload code into auto_load() function

2011-06-20 Thread Remy Bohmer
Hi, 2011/6/14 Simon Glass s...@chromium.org: This is a small clean-up patch. Changes for v8:  - Fix typo in auto_load Signed-off-by: Simon Glass s...@chromium.org Tested-by: Eric Bénard e...@eukrea.com --- Applied to u-boot-usb AFTER cleaning up commit message (Change history of the

Re: [U-Boot] [PATCH v2 6/7] Tegra2: Add USB support

2011-05-13 Thread Remy Bohmer
Hi Simon, This patch touches a lot of files in different subsystems. Please split it up. For example start with a patch series modifying the generic USB code in drivers/usb, followed by a series that modifies board files. Hi Remy, Thanks for the response. The series has 7 patches in all.

Re: [U-Boot] [PATCH v2 6/7] Tegra2: Add USB support

2011-05-12 Thread Remy Bohmer
Hi, 2011/5/5 Simon Glass s...@chromium.org: This adds basic USB support for port 0. The other port is not supported by this CL. Signed-off-by: Simon Glass s...@chromium.org ---  arch/arm/include/asm/arch-tegra2/tegra2.h |    2 +  arch/arm/include/asm/arch-tegra2/usb.h    |  217

Re: [U-Boot] [PATCH] musb: process control messages after roothub accepted it

2011-05-12 Thread Remy Bohmer
Hi, 2011/4/21 Mike Frysinger vap...@gentoo.org: From: Cliff Cai cliff@analog.com When dealing with non-multipoint devices, if the software root hub code accepted the message, then we still need to process it normally.  So only return quickly when the root hub skipped the message or is

Re: [U-Boot] [PATCH] ehci-pci: Fix PCI EHCI driver for 36-bit

2011-05-12 Thread Remy Bohmer
Hi, 2011/4/19 Zhao Chenhui b35...@freescale.com: Convert the PCI base address into a virtual address. Signed-off-by: Zhao Chenhui b35...@freescale.com Signed-off-by: Li Yang le...@freescale.com ---  drivers/usb/host/ehci-pci.c |    5 ++---  1 files changed, 2 insertions(+), 3 deletions(-)

Re: [U-Boot] [PATCH v4 2/5] Add Ethernet hardware MAC address framework to usbnet

2011-04-18 Thread Remy Bohmer
Hi, 2011/4/14 Simon Glass s...@chromium.org: Built-in Ethernet adapters support setting the mac address by means of a ethaddr environment variable for each interface (ethaddr, eth1addr, eth2addr). This adds similar support to the USB network side, using the names usbethaddr, usbeth1addr,

Re: [U-Boot] [PATCH] ehci-pci: Add PCI EHCI controller

2011-03-31 Thread Remy Bohmer
Hi, 2011/3/31 Trübenbach, Ralf ralf.truebenb...@men.de: This patch adds support for the PI7C9X442SL PCIe EHCI host controller from Pericom. Tested at P4080DS eval board from Freescale. Signed-off-by: Ralf Trübenbach ralf.truebenb...@men.de Cc: Remy Bohmer li...@bohmer.net --- Applied

[U-Boot] [PATCH-v2] fat32 root directory handling

2011-03-29 Thread Remy Bohmer
turn, the usb stick protested with a stall handshake. Both FAT32 and non-FAT32 (FAT16/FAT12) end or rootdir checks have been put in. Signed-off-by: Erik Hansen e...@makarta.com Signed-off-by: Remy Bohmer li...@bohmer.net --- V2: Removed added new line I pick this patch up from here since

Re: [U-Boot] musb: usb storage: USB device not accepting new address error

2011-03-26 Thread Remy Bohmer
Hi, 2011/3/26 Alper YILDIRIM yildirimal...@gmail.com: I am working on a custom OMAPL138 (DA8XX) based board. On 2010.12 release USB host mode is successfully working. But it is broken on 2011.03-rc1. I am taking USB device not accepting new address (errror=2) error when i issue usb start

Re: [U-Boot] [PATCH 2/2] usb: musb: blackfin: check anomaly workarounds at runtime too

2011-03-25 Thread Remy Bohmer
Hi, 2011/3/17 Mike Frysinger vap...@gentoo.org: The anomaly workarounds we need for older silicon might break things if used on newer versions where the anomalies don't exist.  So check the silicon rev at runtime too. Signed-off-by: Mike Frysinger vap...@gentoo.org ---  

  1   2   3   4   5   6   >