Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-11-03 Thread Stefan Roese
On 25.10.21 15:12, Marek Behún wrote: From: Marek Behún Hello Stefan, these are another improvements for kwboot, please apply only after series arm: mvebu: nandpagesize support for kwbimage v1 The main improvement is in patch 5, which changes where we inject the code for changing baudrate

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-28 Thread Stefan Roese
On 28.10.21 19:00, Pali Rohár wrote: On Thursday 28 October 2021 16:20:11 Stefan Roese wrote: On 28.10.21 13:04, Pali Rohár wrote: On Thursday 28 October 2021 08:16:24 Stefan Roese wrote: On 27.10.21 23:03, Pali Rohár wrote: On Wednesday 27 October 2021 17:27:41 Stefan Roese wrote: Still I

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-28 Thread Pali Rohár
On Thursday 28 October 2021 16:20:11 Stefan Roese wrote: > On 28.10.21 13:04, Pali Rohár wrote: > > On Thursday 28 October 2021 08:16:24 Stefan Roese wrote: > > > On 27.10.21 23:03, Pali Rohár wrote: > > > > On Wednesday 27 October 2021 17:27:41 Stefan Roese wrote: > > > > > Still I see no speed

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-28 Thread Stefan Roese
On 28.10.21 13:04, Pali Rohár wrote: On Thursday 28 October 2021 08:16:24 Stefan Roese wrote: On 27.10.21 23:03, Pali Rohár wrote: On Wednesday 27 October 2021 17:27:41 Stefan Roese wrote: Still I see no speed change. But this is a different story... Could you try to upload some file in

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-28 Thread Pali Rohár
On Thursday 28 October 2021 08:16:24 Stefan Roese wrote: > On 27.10.21 23:03, Pali Rohár wrote: > > On Wednesday 27 October 2021 17:27:41 Stefan Roese wrote: > > > Still I see no speed change. But this is a different story... > > > > Could you try to upload some file in u-boot via xmodem at

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-28 Thread Stefan Roese
On 27.10.21 23:03, Pali Rohár wrote: On Wednesday 27 October 2021 17:27:41 Stefan Roese wrote: Still I see no speed change. But this is a different story... Could you try to upload some file in u-boot via xmodem at different speeds? E.g. via loadx command: loadx 921600 and loadx 115200

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-27 Thread Pali Rohár
On Wednesday 27 October 2021 17:27:41 Stefan Roese wrote: > Still I see no speed change. But this is a different story... Could you try to upload some file in u-boot via xmodem at different speeds? E.g. via loadx command: loadx 921600 and loadx 115200 And compare if xmodem transfer is in

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-27 Thread Pali Rohár
On Wednesday 27 October 2021 17:27:41 Stefan Roese wrote: > On 27.10.21 16:10, Pali Rohár wrote: > > > > > > Perfect! So it really looks like that issue is in the code which resets > > > baudrate back to the value 115200. > > > > > > I have there another diff which removes usage of the stack

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-27 Thread Stefan Roese
On 27.10.21 16:10, Pali Rohár wrote: Perfect! So it really looks like that issue is in the code which resets baudrate back to the value 115200. I have there another diff which removes usage of the stack in code which resets baudrate back to default value: diff --git a/tools/kwboot.c

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-27 Thread Pali Rohár
On Wednesday 27 October 2021 17:08:35 Marek Behún wrote: > On Wed, 27 Oct 2021 16:10:21 +0200 > Pali Rohár wrote: > > > On Wednesday 27 October 2021 15:52:47 Pali Rohár wrote: > > > On Wednesday 27 October 2021 07:09:42 Stefan Roese wrote: > > > > On 26.10.21 20:48, Pali Rohár wrote: > > > >

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-27 Thread Marek Behún
On Wed, 27 Oct 2021 16:10:21 +0200 Pali Rohár wrote: > On Wednesday 27 October 2021 15:52:47 Pali Rohár wrote: > > On Wednesday 27 October 2021 07:09:42 Stefan Roese wrote: > > > On 26.10.21 20:48, Pali Rohár wrote: > > > > On Tuesday 26 October 2021 16:21:02 Stefan Roese wrote: > > > > >

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-27 Thread Pali Rohár
On Wednesday 27 October 2021 15:52:47 Pali Rohár wrote: > On Wednesday 27 October 2021 07:09:42 Stefan Roese wrote: > > On 26.10.21 20:48, Pali Rohár wrote: > > > On Tuesday 26 October 2021 16:21:02 Stefan Roese wrote: > > > > On 26.10.21 14:40, Pali Rohár wrote: > > > > > My another guess there

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-27 Thread Pali Rohár
On Wednesday 27 October 2021 07:09:42 Stefan Roese wrote: > On 26.10.21 20:48, Pali Rohár wrote: > > On Tuesday 26 October 2021 16:21:02 Stefan Roese wrote: > > > On 26.10.21 14:40, Pali Rohár wrote: > > > > My another guess there could be a problem is usage of stack. Maybe it is > > > > possible

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Stefan Roese
On 26.10.21 20:48, Pali Rohár wrote: On Tuesday 26 October 2021 16:21:02 Stefan Roese wrote: On 26.10.21 14:40, Pali Rohár wrote: My another guess there could be a problem is usage of stack. Maybe it is possible that register with stack pointer is not initialized after the full transfer when

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Pali Rohár
On Tuesday 26 October 2021 16:21:02 Stefan Roese wrote: > On 26.10.21 14:40, Pali Rohár wrote: > > My another guess there could be a problem is usage of stack. Maybe it is > > possible that register with stack pointer is not initialized after the > > full transfer when going to execute main image.

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Stefan Roese
On 26.10.21 17:34, Marek Behún wrote: On Tue, 26 Oct 2021 17:25:10 +0200 Stefan Roese wrote: On 26.10.21 17:20, Marek Behún wrote: On Tue, 26 Oct 2021 17:13:05 +0200 Stefan Roese wrote: Here is now just hangs forever. No output from main U-Boot proper at all. This happed every time,

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Marek Behún
On Tue, 26 Oct 2021 17:25:10 +0200 Stefan Roese wrote: > On 26.10.21 17:20, Marek Behún wrote: > > On Tue, 26 Oct 2021 17:13:05 +0200 > > Stefan Roese wrote: > > > >> Here is now just hangs forever. No output from main U-Boot proper at > >> all. This happed every time, when the baudrate is

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Stefan Roese
On 26.10.21 17:20, Marek Behún wrote: On Tue, 26 Oct 2021 17:13:05 +0200 Stefan Roese wrote: Here is now just hangs forever. No output from main U-Boot proper at all. This happed every time, when the baudrate is changed, meaning a non 115200 -B is passed to kwboot. I checked with 115201 and

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Marek Behún
On Tue, 26 Oct 2021 17:13:05 +0200 Stefan Roese wrote: > Here is now just hangs forever. No output from main U-Boot proper at > all. This happed every time, when the baudrate is changed, meaning a > non 115200 -B is passed to kwboot. I checked with 115201 and here no > U-Boot proper output is

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Stefan Roese
On 26.10.21 16:48, Pali Rohár wrote: On Tuesday 26 October 2021 16:21:02 Stefan Roese wrote: On 26.10.21 14:40, Pali Rohár wrote: On Tuesday 26 October 2021 13:09:42 Stefan Roese wrote: On 26.10.21 11:06, Pali Rohár wrote: Now I found logical error in kwboot code which handles

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Pali Rohár
On Tuesday 26 October 2021 16:21:02 Stefan Roese wrote: > On 26.10.21 14:40, Pali Rohár wrote: > > On Tuesday 26 October 2021 13:09:42 Stefan Roese wrote: > > > On 26.10.21 11:06, Pali Rohár wrote: > > > > > > > > > > > > > Now I found logical error in kwboot code which handles retransmission

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Stefan Roese
On 26.10.21 14:40, Pali Rohár wrote: On Tuesday 26 October 2021 13:09:42 Stefan Roese wrote: On 26.10.21 11:06, Pali Rohár wrote: Now I found logical error in kwboot code which handles retransmission of the last header packet. State of "baudrate change" is cleared on every retransmission.

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Stefan Roese
On 26.10.21 15:06, Marek Behún wrote: On Tue, 26 Oct 2021 14:40:48 +0200 Pali Rohár wrote: What is happening here? I do not know. But as Marek told me that observed same issue and replacing USB-UART cable by another decreased transfer time. So I think that issue is somewhere in USB-UART

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Marek Behún
On Tue, 26 Oct 2021 14:40:48 +0200 Pali Rohár wrote: > What is happening here? I do not know. But as Marek told me that > observed same issue and replacing USB-UART cable by another decreased > transfer time. So I think that issue is somewhere in USB-UART > transmitter. My guess is that USB-UART

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Pali Rohár
On Tuesday 26 October 2021 13:09:42 Stefan Roese wrote: > On 26.10.21 11:06, Pali Rohár wrote: > > > > > Now I found logical error in kwboot code which handles retransmission of > > the last header packet. State of "baudrate change" is cleared on every > > retransmission. Please apply following

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Stefan Roese
On 26.10.21 11:06, Pali Rohár wrote: Now I found logical error in kwboot code which handles retransmission of the last header packet. State of "baudrate change" is cleared on every retransmission. Please apply following diff, so state variables are initialized only once. diff --git

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Pali Rohár
On Tuesday 26 October 2021 10:45:09 Stefan Roese wrote: > On 26.10.21 10:33, Pali Rohár wrote: > > On Monday 25 October 2021 17:15:14 Stefan Roese wrote: > > > Hi Pali, > > > > > > On 25.10.21 16:42, Pali Rohár wrote: > > > > On Monday 25 October 2021 16:39:44 Stefan Roese wrote: > > > > > Hi

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Stefan Roese
On 26.10.21 10:33, Pali Rohár wrote: On Monday 25 October 2021 17:15:14 Stefan Roese wrote: Hi Pali, On 25.10.21 16:42, Pali Rohár wrote: On Monday 25 October 2021 16:39:44 Stefan Roese wrote: Hi Marek, On 25.10.21 15:12, Marek Behún wrote: From: Marek Behún Hello Stefan, these are

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-26 Thread Pali Rohár
On Monday 25 October 2021 17:15:14 Stefan Roese wrote: > Hi Pali, > > On 25.10.21 16:42, Pali Rohár wrote: > > On Monday 25 October 2021 16:39:44 Stefan Roese wrote: > > > Hi Marek, > > > > > > On 25.10.21 15:12, Marek Behún wrote: > > > > From: Marek Behún > > > > > > > > Hello Stefan, > > >

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-25 Thread Stefan Roese
Hi Pali, On 25.10.21 16:42, Pali Rohár wrote: On Monday 25 October 2021 16:39:44 Stefan Roese wrote: Hi Marek, On 25.10.21 15:12, Marek Behún wrote: From: Marek Behún Hello Stefan, these are another improvements for kwboot, please apply only after series arm: mvebu: nandpagesize

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-25 Thread Pali Rohár
On Monday 25 October 2021 16:39:44 Stefan Roese wrote: > Hi Marek, > > On 25.10.21 15:12, Marek Behún wrote: > > From: Marek Behún > > > > Hello Stefan, > > > > these are another improvements for kwboot, please apply only after series > >arm: mvebu: nandpagesize support for kwbimage v1 >

Re: [PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-25 Thread Stefan Roese
Hi Marek, On 25.10.21 15:12, Marek Behún wrote: From: Marek Behún Hello Stefan, these are another improvements for kwboot, please apply only after series arm: mvebu: nandpagesize support for kwbimage v1 I'm checking right now and have applied the 3 NAND patches on current master. But

[PATCH u-boot-marvell 00/13] Yet another kwboot improvements

2021-10-25 Thread Marek Behún
From: Marek Behún Hello Stefan, these are another improvements for kwboot, please apply only after series arm: mvebu: nandpagesize support for kwbimage v1 The main improvement is in patch 5, which changes where we inject the code for changing baudrate back to 115200 Baud after fast upload.