On Fri, Apr 24, 2009 at 02:57:52PM +0900, Kyungmin Park wrote:
Actually, I don't like the CONFIG_SYS_MONITOR_LEN approaches, now you
are consider the bad block at 1.
But we can also consider the bad block 2, if there two consecutive 2
bad block at block 1, 2, we should define the
apgmoorthy wrote:
Hi Scott,
On Tuesday, March 31, 2009 4:04 AM Scott Wood Wrote :
Note that there are a couple of board files (apollon and nmdk8815) that use
the OneNAND loader
that do not define CONFIG_SYS_MONITOR_LEN. I've added the maintainers to
the Cc: list.
Hi Kyungmin,
- Original Message -
From: Scott Wood scottw...@freescale.com
To: apgmoorthy moorthy@samsung.com
Cc: u-boot@lists.denx.de; rub...@unipv.it
Sent: Friday, April 24, 2009 4:09 AM
Subject: Re: [U-Boot] [PATCH 1/2] Fix OneNAND ipl to read
CONFIG_SYS_MONITOR_LEN
apgmoorthy
Hi,
On Fri, Apr 24, 2009 at 2:28 PM, AYYANARPONNUSAMY GANGHEYAMOORTHY
moorthy@samsung.com wrote:
Hi Scott,
On Apr 24, 2009 07:39 (GMT+09:00) Scott Woodscottw...@freescale.com wrote
apgmoorthy wrote:
This is done by the Post : [U-Boot] [PATCH 2/2] Fix OneNAND ipl to read
Hi Scott,
On Tuesday, March 31, 2009 4:04 AM Scott Wood Wrote :
Note that there are a couple of board files (apollon and nmdk8815) that use
the OneNAND loader
that do not define CONFIG_SYS_MONITOR_LEN. I've added the maintainers to the
Cc: list.
CONFIG_SYS_MONITOR_LEN is not defined in
Alessandro Rubini wrote:
Hello.
Note that there are a couple of board files (apollon and nmdk8815) that
use the OneNAND loader that do not define CONFIG_SYS_MONITOR_LEN. I've
added the maintainers to the Cc: list.
Sorry for the delay.
In the nomadik board the OneNAND driver is not
Hello.
Note that there are a couple of board files (apollon and nmdk8815) that
use the OneNAND loader that do not define CONFIG_SYS_MONITOR_LEN. I've
added the maintainers to the Cc: list.
Sorry for the delay.
In the nomadik board the OneNAND driver is not yet present, a few init
lines
.
Signed-off-by: Rohit Hagargundgi h.ro...@samsung.com
Signed-off-by: Gangheyamoorthy moorthy@samsung.com
Applied to u-boot-nand-flash, with the below whitespace errors fixed:
Applying RE: [U-Boot] [PATCH 1/2] Fix OneNAND ipl to read
CONFIG_SYS_MONITOR_LEN
.dotest/patch:128: trailing whitespace
@samsung.com
Cc: u-boot@lists.denx.de; rub...@unipv.it
Sent: Tuesday, March 31, 2009 4:03 AM
Subject: Re: [U-Boot] [PATCH 1/2] Fix OneNAND ipl to read
CONFIG_SYS_MONITOR_LEN
apgmoorthy wrote:
Currently OneNAND initial program loader (ipl) reads only
block 0 ie 128KB.
However, u-boot image for apollon
Currently OneNAND initial program loader (ipl) reads only block 0 ie 128KB.
However, u-boot image for apollon board is 195KB making the board
unbootable with OneNAND.
Fix ipl to read CONFIG_SYS_MONITOR_LEN.
CONFIG_SYS_MONITOR_LEN macro holds the U-Boot image size.
Signed-off-by: Rohit
Hi Scott,
On Tuesday, March 24, 2009 2:55 AM , Scott Wood wrote
Please do find the updated patch below.
It's easier if updated patches are sent separately from the reply (both to
avoid getting lost,
and to avoid having to manually strip discussion from the changelog).
Signed-off-by:
Hi Wolfgang,
- Original Message -
From: Wolfgang Denk w...@denx.de
To: Scott Wood scottw...@freescale.com
Cc: u-boot@lists.denx.de; apgmoorthy
moorthy@samsung.com
Sent: Tuesday, March 24, 2009 4:16 AM
Subject: Re: [U-Boot] [PATCH 1/2] Fix OneNAND ipl to read
CONFIG_SYS_MONITOR_LEN
Hi Scott,
+if (page 2 (onenand_readw(THIS_ONENAND(ONENAND_SPARERAM)) !=
0x))
Line length.
- Corrected.
int pagesize = ONENAND_PAGE_SIZE;
+int nblocks = CONFIG_SYS_MONITOR_LEN / ONENAND_BLOCK_SIZE;
Shouldn't nblocks be rounded up?
pagesize =
Dear Scott Wood,
In message 20090323212514.ga30...@ld0162-tx32.am.freescale.net you wrote:
+ /* Check for invalid block mark */
+ if (page 2 (onenand_readw(ONENAND_SPARERAM) != 0x))
+ return 1;
Unnecessary parens.
Where? I find them pretty useful. Please keep!
Best
Wolfgang Denk wrote:
Dear Scott Wood,
In message 20090323212514.ga30...@ld0162-tx32.am.freescale.net you wrote:
+ /* Check for invalid block mark */
+ if (page 2 (onenand_readw(ONENAND_SPARERAM) != 0x))
+ return 1;
Unnecessary parens.
Where? I find them pretty
Dear Scott,
In message 49c80b99.5010...@freescale.com you wrote:
+ if (page 2 (onenand_readw(ONENAND_SPARERAM) != 0x))
+ return 1;
Unnecessary parens.
Where? I find them pretty useful.
Around the second comparison. Why if (a b (c != d)) and not if
(a b c != d),
Currently OneNAND initial program loader (ipl) reads only block 0 ie 128KB.
However, u-boot image for apollon board is 195KB making the board
unbootable with OneNAND.
Fix ipl to read CONFIG_SYS_MONITOR_LEN.
CONFIG_SYS_MONITOR_LEN macro holds the U-Boot image size.
Signed-off-by: Rohit
On Mon, Mar 09, 2009 at 07:45:40PM +0530, Rohit Hagargundgi wrote:
+ /* Check for invalid block mark*/
+ if (page 2 (onenand_readw(THIS_ONENAND(ONENAND_SPARERAM)) !=
0x))
+ return 1;
Line length.
- int page, offset = 0;
+ int block = 0, page =
18 matches
Mail list logo
