Re: [U-Boot] [PATCH 15/28] net/memac_phy: reuse driver for little endian SoCs

-R58495 Cc: u-boot; Joe Hershberger; Xie Shaohui-B21989 Subject: Re: [U-Boot] [PATCH 15/28] net/memac_phy: reuse driver for little endian SoCs Hi Shaohui Xie, On Thu, Mar 19, 2015 at 11:45 AM, York Sun york...@freescale.com wrote: From: Shaohui Xie shaohui@freescale.com The memac

Re: [U-Boot] [PATCH 15/28] net/memac_phy: reuse driver for little endian SoCs

/* IFC */ #define CONFIG_SYS_FSL_IFC_LE +#define CONFIG_SYS_MEMAC_LITTLE_ENDIAN It seems tedious to have to define this. Can't you just use the functions available? [S.H] To use a define is based on a concern that we cannot assume the I/O access of an IP share same endianness as

Re: [U-Boot] [PATCH 15/28] net/memac_phy: reuse driver for little endian SoCs

On Thu, Mar 19, 2015 at 10:48 PM, Shaohui Xie shaohui@freescale.com wrote: /* IFC */ #define CONFIG_SYS_FSL_IFC_LE +#define CONFIG_SYS_MEMAC_LITTLE_ENDIAN It seems tedious to have to define this. Can't you just use the functions available? [S.H] To use a define is based on a

Re: [U-Boot] [PATCH 15/28] net/memac_phy: reuse driver for little endian SoCs

Hello Joe, Thank you for reviewing this patch! Please see inline. Best Regards, Shaohui Xie From: Joe Hershberger [mailto:joe.hershber...@gmail.com] Sent: Friday, March 20, 2015 2:04 AM To: Sun York-R58495 Cc: u-boot; Joe Hershberger; Xie Shaohui-B21989 Subject: Re: [U-Boot] [PATCH 15/28] net

Re: [U-Boot] [PATCH 15/28] net/memac_phy: reuse driver for little endian SoCs

Hi Shaohui Xie, On Thu, Mar 19, 2015 at 11:45 AM, York Sun york...@freescale.com wrote: From: Shaohui Xie shaohui@freescale.com The memac for PHY management on little endian SoCs is similar on big endian SoCs, so we modify the driver by using I/O accessor function to handle the

[U-Boot] [PATCH 15/28] net/memac_phy: reuse driver for little endian SoCs

From: Shaohui Xie shaohui@freescale.com The memac for PHY management on little endian SoCs is similar on big endian SoCs, so we modify the driver by using I/O accessor function to handle the endianness, so the driver can be reused on little endian SoCs, we introduce