Re: [U-Boot-Users] [PATCH 3/7 v6] ARM: Add arm1176 core with S3C6400 SoC

2008-08-11 Thread Guennadi Liakhovetski
On Sat, 9 Aug 2008, Jean-Christophe PLAGNIOL-VILLARD wrote: > > + > > +void dcache_disable (void) > > +{ > > + ulong reg; > > + > > + reg = read_p15_c1 (); > > + cp_delay (); > > + reg &= ~C1_DC; > > + write_p15_c1 (reg); > why not as the other implementation? ok > > + /*pri

Re: [U-Boot-Users] [PATCH 3/7 v6] ARM: Add arm1176 core with S3C6400 SoC

2008-08-09 Thread Jean-Christophe PLAGNIOL-VILLARD
> + > +void dcache_disable (void) > +{ > + ulong reg; > + > + reg = read_p15_c1 (); > + cp_delay (); > + reg &= ~C1_DC; > + write_p15_c1 (reg); why not as the other implementation? > + write_p15_c1 (reg & ~C1_DC); > +} > + > +int dcache_status (void) > +{ > + return (re

Re: [U-Boot-Users] [PATCH 3/7 v6] ARM: Add arm1176 core with S3C6400 SoC

2008-08-07 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:03 Thu 07 Aug , Jens Gehrlein wrote: > Wolfgang Denk schrieb: > > In message <[EMAIL PROTECTED]> you wrote: > >>> That's what we've been doing so far: > >>> > >>> -> ls -l include/s3c* > >>> -rw-rw-r-- 1 wd wd 21763 Dec 9 2007 include/s3c2400.h > >>> -rw-rw-r-- 1 wd wd 7629 Dec

Re: [U-Boot-Users] [PATCH 3/7 v6] ARM: Add arm1176 core with S3C6400 SoC

2008-08-07 Thread Jens Gehrlein
Hi Guennadi, Guennadi Liakhovetski schrieb: > On Thu, 7 Aug 2008, Jens Gehrlein wrote: > >> Hi Guennadi, >> >> Guennadi Liakhovetski schrieb: >> >>> diff --git a/cpu/arm1176/s3c64xx/interrupts.c >>> b/cpu/arm1176/s3c64xx/interrupts.c >> [snip] >>> +void udelay(unsigned long usec) >>> +{ >>> + u

Re: [U-Boot-Users] [PATCH 3/7 v6] ARM: Add arm1176 core with S3C6400 SoC

2008-08-07 Thread Jens Gehrlein
Wolfgang Denk schrieb: > In message <[EMAIL PROTECTED]> you wrote: >>> That's what we've been doing so far: >>> >>> -> ls -l include/s3c* >>> -rw-rw-r-- 1 wd wd 21763 Dec 9 2007 include/s3c2400.h >>> -rw-rw-r-- 1 wd wd 7629 Dec 9 2007 include/s3c2410.h >>> -rw-rw-r-- 1 wd wd 38

Re: [U-Boot-Users] [PATCH 3/7 v6] ARM: Add arm1176 core with S3C6400 SoC

2008-08-07 Thread Wolfgang Denk
In message <[EMAIL PROTECTED]> you wrote: > > > That's what we've been doing so far: > > > > -> ls -l include/s3c* > > -rw-rw-r-- 1 wd wd 21763 Dec 9 2007 include/s3c2400.h > > -rw-rw-r-- 1 wd wd 7629 Dec 9 2007 include/s3c2410.h > > -rw-rw-r-- 1 wd wd 38129 Oct 13 2007 inclu

Re: [U-Boot-Users] [PATCH 3/7 v6] ARM: Add arm1176 core with S3C6400 SoC

2008-08-07 Thread Guennadi Liakhovetski
On Thu, 7 Aug 2008, Jens Gehrlein wrote: > Hi Guennadi, > > Guennadi Liakhovetski schrieb: > > > diff --git a/cpu/arm1176/s3c64xx/interrupts.c > > b/cpu/arm1176/s3c64xx/interrupts.c > [snip] > > +void udelay(unsigned long usec) > > +{ > > + unsigned long long tmp; > > + ulong tmo; > > + > >

Re: [U-Boot-Users] [PATCH 3/7 v6] ARM: Add arm1176 core with S3C6400 SoC

2008-08-07 Thread Jens Gehrlein
Wolfgang Denk schrieb: > In message <[EMAIL PROTECTED]> you wrote: >> Is it intended to put the CPU specific header files directly into the >> include directory (s3c6400.h and s3c64x0.h)? > > That's what we've been doing so far: > > -> ls -l include/s3c* > -rw-rw-r-- 1 wd wd 21763 De

Re: [U-Boot-Users] [PATCH 3/7 v6] ARM: Add arm1176 core with S3C6400 SoC

2008-08-07 Thread Jens Gehrlein
Hi Guennadi, Guennadi Liakhovetski schrieb: > diff --git a/cpu/arm1176/s3c64xx/interrupts.c > b/cpu/arm1176/s3c64xx/interrupts.c [snip] > +void udelay(unsigned long usec) > +{ > + unsigned long long tmp; > + ulong tmo; > + > + tmo = (usec + 9) / 10; > + tmp = get_ticks() + tmo;

Re: [U-Boot-Users] [PATCH 3/7 v6] ARM: Add arm1176 core with S3C6400 SoC

2008-08-07 Thread Wolfgang Denk
In message <[EMAIL PROTECTED]> you wrote: > > Is it intended to put the CPU specific header files directly into the > include directory (s3c6400.h and s3c64x0.h)? That's what we've been doing so far: -> ls -l include/s3c* -rw-rw-r-- 1 wd wd 21763 Dec 9 2007 include/s3c2400.h

Re: [U-Boot-Users] [PATCH 3/7 v6] ARM: Add arm1176 core with S3C6400 SoC

2008-08-07 Thread Jens Gehrlein
Guennadi Liakhovetski schrieb: > Based on the original S3C64XX port by Samsung for U-Boot 1.1.6. > > Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> > --- > cpu/arm1176/Makefile| 50 ++ > cpu/arm1176/config.mk | 35 ++ > cpu/arm1176/cpu.c

Re: [U-Boot-Users] [PATCH 3/7 v6] ARM: Add arm1176 core with S3C6400 SoC

2008-08-06 Thread Guennadi Liakhovetski
On Thu, 7 Aug 2008, Andreas Engel wrote: > > diff --git a/cpu/arm1176/s3c64xx/interrupts.c > > b/cpu/arm1176/s3c64xx/interrupts.c > > new file mode 100644 > > index 000..4233e8c > > --- /dev/null > > +++ b/cpu/arm1176/s3c64xx/interrupts.c > > You can remove anything from enable_interrupts()

Re: [U-Boot-Users] [PATCH 3/7 v6] ARM: Add arm1176 core with S3C6400 SoC

2008-08-06 Thread Andreas Engel
> diff --git a/cpu/arm1176/s3c64xx/interrupts.c > b/cpu/arm1176/s3c64xx/interrupts.c > new file mode 100644 > index 000..4233e8c > --- /dev/null > +++ b/cpu/arm1176/s3c64xx/interrupts.c You can remove anything from enable_interrupts() to do_irq() here. It's already in lib_arm/interrupts.c. A