Re: [PATCH] riscv: Avoid io read/write cause wrong result

2021-10-19 Thread Leo Liang
On Mon, Oct 18, 2021 at 11:50:05AM +0800, Nick Hu wrote: > io read/write may cause wrong result because they may read/write data > from/to register instead of memory. Add 'volatile' to avoid it. > > Signed-off-by: Nick Hu > --- > arch/riscv/include/asm/io.h | 18 +- > 1 file

Re: [PATCH 1/1] board: sifive: unmatched: enlarge CONFIG_SYS_SPL_MALLOC_SIZE

2021-10-19 Thread Alexandre Ghiti
Hi, On Fri, Oct 1, 2021 at 5:35 PM Bin Meng wrote: > > Hi Heinrich, > > On Fri, Oct 1, 2021 at 7:37 PM Heinrich Schuchardt > wrote: > > > > Avoid an error like > > > > Could not get FIT buffer of 1725952 bytes > > check CONFIG_SYS_SPL_MALLOC_SIZE > > No device tree specified

RE: How to compile u-boot with debug option?

2021-10-19 Thread Chan Kim
Hello Jaehoon, I found 'u-boot' is the elf file containing the debug-info (while reading README.SPL) and found your email below while trying to send an update email. Yes, I don't have to make u-boot.elf but can just use 'u-boot' like you showed(I missed the generated file). The gdb now can

Re: License: embed u-boot binary in FPGA bitstream

2021-10-19 Thread François Ozog
Hi Did you get an answer I missed ? There’s active discussion on DTB lifecycle. >From the Xilinx boards I am aware of, there is a Xilinx primary boot loader that then loads u-boot SPL and then U-Boot proper. My understanding is that you can attach the hardware description DTB with the

RE: [EXT] Re: [PATCH v3 01/16] crypto/fsl: Add support for CAAM Job ring driver model

2021-10-19 Thread Gaurav Jain
Hi Simon > -Original Message- > From: Simon Glass > Sent: Thursday, October 14, 2021 8:40 PM > To: Gaurav Jain > Cc: U-Boot Mailing List ; Stefano Babic > ; Fabio Estevam ; Peng Fan > ; Priyanka Jain ; Ye Li > ; Horia Geanta ; Ji Luo > ; Franck Lenormand ; Silvano Di > Ninno ; Sahil

Re: How to compile u-boot with debug option?

2021-10-19 Thread Jaehoon Chung
Hi, On 10/19/21 2:01 PM, Chan Kim wrote: > > Hello, Jaehoon and all, > > I tried setting in menuconfig TOOLS_DEBUG but no change. It's strainge, when > I add "V=1" in the make command, I can see the commands run during the make. > The cc command has -g options, a typical command being like

Re: please help, "Ram disk image is corrupt or invalid" (qemu virt machine, arm64)

2021-10-19 Thread François Ozog
Hi If you use the second argument to indicate the location of the initrd then Linux will use device tree information to get the size of the initrd. That information is probably absent or incorrect. The initrd= in your command line is thus useless as you task U-boot to load it. You may want to

Re: [PATCH 3/3] treewide: Remove OF_PRIOR_STAGE

2021-10-19 Thread Tom Rini
On Tue, Oct 12, 2021 at 12:00:15AM +0300, Ilias Apalodimas wrote: > The previous patches removed OF_PRIOR_STAGE from the last consumers of the > Kconfig option. Cleanup any references to it in documentation, code and > configuration options. > > Signed-off-by: Ilias Apalodimas > Reviewed-by:

Re: [PATCH 2/3] board: arm: Remove OF_PRIOR_STAGE from the remaining Arm boards

2021-10-19 Thread Tom Rini
On Tue, Oct 12, 2021 at 12:00:14AM +0300, Ilias Apalodimas wrote: > At some point back in 2018 prior_stage_fdt_address and OF_PRIOR_STAGE got > introduced, in order to support a DTB handed over by an earlier stage boo > loader. However we have another option in the Kconfig (OF_BOARD) which has

[PATCH v4] sandbox: Remove OF_HOSTFILE

2021-10-19 Thread Ilias Apalodimas
OF_HOSTFILE is used on sandbox configs only. Although it's pretty unique and not causing any confusions, we are better of having simpler config options for the DTB. So let's replace that with the existing OF_BOARD. U-Boot would then have only three config options for the DTB origin. -

Re: License: embed u-boot binary in FPGA bitstream

2021-10-19 Thread Tom Rini
On Tue, Oct 19, 2021 at 09:13:07AM +0200, François Ozog wrote: > Hi > > Did you get an answer I missed ? > > There’s active discussion on DTB lifecycle. > > From the Xilinx boards I am aware of, there is a Xilinx primary boot loader > that then loads u-boot SPL and then U-Boot proper. > > My

Re: [PATCH 0/9] phyCORE-i.MX8MM Updates

2021-10-19 Thread Stefano Babic
On 06.10.21 11:56, Teresa Remmet wrote: This patchstack contains mainly cleanup for phyCORE-i.MX8MM but also adds: * SPI NOR flash support * clk command * binman support Teresa Teresa Remmet (9): board: phytec: phycore_imx8mm: Clean up spl include: configs: phycore_imx8mm: Remove hard

RE: please help, "Ram disk image is corrupt or invalid" (qemu virt machine, arm64)

2021-10-19 Thread Chan Kim
Hi, François Thank you for the response. I’m now studying u-boot so it’ll take some time to learn about SystemReady boot. BTW, inspired by your email, I tried this one. (after tftp of all three files) => fdt addr 0x4000 => fdt chosen 0x4200 0x4211e2a1 // the length of

Re: [PATCH v3 1/4] mkimage: add a flag to describe whether -A is specified

2021-10-19 Thread Andre Przywara
On Thu, 14 Oct 2021 20:53:04 -0500 Samuel Holland wrote: Hi, > From: Icenowy Zheng > > The sunxi_egon type used to take no -A argument (because we assume sunxi > targets are all ARM). However, as Allwinner D1 appears as the first > RISC-V sunxi target, we need to support -A; in addition, as

Re: please help, "Ram disk image is corrupt or invalid" (qemu virt machine, arm64)

2021-10-19 Thread Jaehoon Chung
Hi, On 10/19/21 6:59 PM, Chan Kim wrote: > Hi, François > > > > Thank you for the response. > > I’m now studying u-boot so it’ll take some time to learn about SystemReady > boot. > > BTW, inspired by your email, I tried this one. (after tftp of all three files) > > > > => fdt addr

Re: [PATCH v3 1/4] tools: Separate image types which depend on OpenSSL

2021-10-19 Thread Andre Przywara
On Mon, 18 Oct 2021 09:09:04 -0500 "Alex G." wrote: Hi, > On 10/14/21 10:19 PM, Samuel Holland wrote: > > Some image types (kwbimage and mxsimage) always depend on OpenSSL, so > > they can only be included in mkimage when TOOLS_LIBCRYPTO is selected. > > Use Makefile logic to conditionally link

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Wolfgang Denk
Dear Simon, In message <20211018121315.v8.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> you wrote: > > The environment variables should be of the form "var=value". Values can > extend to multiple lines. See the README under 'Environment Variables:' > for more information and an example.

Re: i.MX LPDDR4 Firmware

2021-10-19 Thread Heiko Thiery
Hi Marcel, Am Di., 19. Okt. 2021 um 11:47 Uhr schrieb Marcel Ziswiler : > > Hi Heiko > > On Mon, 2021-10-18 at 11:23 +0200, Heiko Thiery wrote: > > Hi all, > > > > I see that in the NXP firmware-imx package different versions of the > > LPDDR4 train firmware is included but I cannot find a

Re: [PATCH v3 1/4] mkimage: add a flag to describe whether -A is specified

2021-10-19 Thread Samuel Holland
On 10/19/21 5:49 AM, Andre Przywara wrote: > On Thu, 14 Oct 2021 20:53:04 -0500 > Samuel Holland wrote: > > Hi, > >> From: Icenowy Zheng >> >> The sunxi_egon type used to take no -A argument (because we assume sunxi >> targets are all ARM). However, as Allwinner D1 appears as the first >>

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > Can we just ban + ? Why? Just because your awk script is a lousy parser? > In the above, foo\+ gives an unknown escape sequence from the C > preprocessor, then the whole line is ignored by the script Really? -> cat foo.c #define A ampersand #define B

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Wolfgang Denk
Dear Tom, In message <20211018142404.GR7964@bill-the-cat> you wrote: > > > > Perhaps we should just make "+" an illegal character in the variable > > > name, for consistency? > > > > And break backward compatibility? I'd rather see a better > > definition of the syntax of the environment

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > Hm... I can't find it right now but did I not also read about other > > restrictions to variable names, like they must noch begin with '_' > > when using this new tool? > > Yes but I took that out (I think in v6). I'll update the commit message. Why

Re: [PATCH v8 0/8] env: Allow environment in text files

2021-10-19 Thread Wolfgang Denk
Dear Simon, In message <20211018181322.1181847-1-...@chromium.org> you wrote: > > Add a feature that brings in a .env file associated with the board > config, if present. To use it, create a file board/.env or > use CONFIG_ENV_SOURCE_FILE to set a filename. Again, slash missing. This should be

Re: [PATCH 1/3 v4] riscv: Remove OF_PRIOR_STAGE from RISC-V boards

2021-10-19 Thread Tom Rini
On Tue, Oct 12, 2021 at 12:00:13AM +0300, Ilias Apalodimas wrote: > At some point back in 2018 prior_stage_fdt_address and OF_PRIOR_STAGE got > introduced, in order to support a DTB handed over by an earlier stage boo > loader. However we have another option in the Kconfig (OF_BOARD) which has

Re: [PATCH] mtd: spi-nor-ids: Add SECT_4K to mt25qu512a

2021-10-19 Thread Pratyush Yadav
On 18/10/21 03:30AM, Kris Chaplin wrote: > The mt25qu512a supports 4K or 64K sectors, so adding SECT_4K to enable 4K > sector usage. > > Datasheet: > https://media-www.micron.com/-/media/client/global/documents/products/data-sheet/nor-flash/serial-nor/n25q/n25q_512mb_1ce_3v_65nm.pdf > > Tested

Re: buildman stops (crashed) on current master

2021-10-19 Thread Stefano Babic
Hi Simon, On 19.10.21 17:52, Simon Glass wrote: Hi Stefano, On Tue, 19 Oct 2021 at 09:39, Stefano Babic wrote: Hi Simon, On 07.10.21 15:43, Simon Glass wrote: Hi Stefano, On Thu, 7 Oct 2021 at 04:37, Stefano Babic wrote: Hi all, CI stops by building aarch64 without notice, for

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Simon Glass
Hi Tom, On Tue, 19 Oct 2021 at 10:44, Tom Rini wrote: > > On Tue, Oct 19, 2021 at 10:39:55AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 19 Oct 2021 at 10:30, Tom Rini wrote: > > > > > > On Tue, Oct 19, 2021 at 10:24:25AM -0600, Simon Glass wrote: > > > > Hi Wolfgang, > > > > > > > >

Re: [PATCH v8 6/8] doc: Mention CONFIG_DEFAULT_ENV_FILE

2021-10-19 Thread Simon Glass
Hi Marek, On Tue, 19 Oct 2021 at 10:07, Marek Behún wrote: > > On Tue, 19 Oct 2021 09:52:17 -0600 > Simon Glass wrote: > > > Hi Marek, > > > > On Tue, 19 Oct 2021 at 08:34, Marek Behún wrote: > > > > > > On Mon, 18 Oct 2021 12:13:20 -0600 > > > Simon Glass wrote: > > > > > > > Add mention of

Re: [PATCH] mtd: spi-nor-ids: Add is25lp512 and is25wp512 devices

2021-10-19 Thread Pratyush Yadav
On 18/10/21 03:26AM, Kris Chaplin wrote: > Add is25lp512 and is25wp512 devices to spi-nor id table > > Tested on Intel n5x hardware with QSPI carrier card > > Signed-off-by: Kris Chaplin > Tested-by: Kris Chaplin Same comment as before about the Tested-by trailer. Also adding SPI NOR

Re: [PATCH v3] sandbox: Remove OF_HOSTFILE

2021-10-19 Thread Ilias Apalodimas
On Mon, Oct 18, 2021 at 08:29:24PM -0400, Tom Rini wrote: > On Mon, Oct 18, 2021 at 04:50:33PM -0400, Tom Rini wrote: > > On Fri, Oct 15, 2021 at 11:42:40AM +0300, Ilias Apalodimas wrote: > > > > > OF_HOSTFILE is used on sandbox configs only. Although it's pretty > > > unique and rarely causes

[PATCH] doc: Remove obsolete README.440-DDR-performance file

2021-10-19 Thread Thomas Huth
The PPC 440 support has been removed in commit 98f705c9ce ("powerpc: remove 4xx support") already, so this file is certainly not required anymore. Signed-off-by: Thomas Huth --- doc/README.440-DDR-performance | 90 -- 1 file changed, 90 deletions(-) delete mode

Message to U-boot list

2021-10-19 Thread Matiukhin, Georgii
Hello. I would like to send my message to U-boot list. Hi folks. I am developing my own USB driver for RPI4 board and ran into a problem - the VL805 chip raises the HSE error when I'm trying to transfer it to the RUN state. I configure all the registers of the hardware exactly as the u-boot

Re: [PATCH v3] sandbox: Remove OF_HOSTFILE

2021-10-19 Thread Ilias Apalodimas
On Tue, Oct 19, 2021 at 10:56:26AM +0300, Ilias Apalodimas wrote: > On Mon, Oct 18, 2021 at 08:29:24PM -0400, Tom Rini wrote: > > On Mon, Oct 18, 2021 at 04:50:33PM -0400, Tom Rini wrote: > > > On Fri, Oct 15, 2021 at 11:42:40AM +0300, Ilias Apalodimas wrote: > > > > > > > OF_HOSTFILE is used on

[PATCH] part: return -ENOSYS when get_info not valid.

2021-10-19 Thread schspa
In some case, get_info() interface can be NULL, add this check to stop from crash. Signed-off-by: schspa --- disk/part.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/disk/part.c b/disk/part.c index a6a8f7052b..7af3240ec7 100644 --- a/disk/part.c +++ b/disk/part.c @@ -668,6 +668,13

RE: please help, "Ram disk image is corrupt or invalid" (qemu virt machine, arm64)

2021-10-19 Thread Chan Kim
Hi, Jaehoon, Thanks for the help. > You can check the debug message in common/image-board.c. > Did you create ramdisk image the correct format? To make ramdisk image (I made initramfs which I know is not a real disk image format

Re: [PATCH v3] sandbox: Remove OF_HOSTFILE

2021-10-19 Thread Tom Rini
On Tue, Oct 19, 2021 at 02:16:52PM +0300, Ilias Apalodimas wrote: > On Tue, Oct 19, 2021 at 10:56:26AM +0300, Ilias Apalodimas wrote: > > On Mon, Oct 18, 2021 at 08:29:24PM -0400, Tom Rini wrote: > > > On Mon, Oct 18, 2021 at 04:50:33PM -0400, Tom Rini wrote: > > > > On Fri, Oct 15, 2021 at

Re: [PATCH v3 1/4] tools: Separate image types which depend on OpenSSL

2021-10-19 Thread Samuel Holland
On 10/19/21 5:41 AM, Andre Przywara wrote: > On Mon, 18 Oct 2021 09:09:04 -0500 > "Alex G." wrote: > > Hi, > >> On 10/14/21 10:19 PM, Samuel Holland wrote: >>> Some image types (kwbimage and mxsimage) always depend on OpenSSL, so >>> they can only be included in mkimage when TOOLS_LIBCRYPTO is

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Tom Rini
On Mon, Oct 18, 2021 at 12:13:18PM -0600, Simon Glass wrote: > At present U-Boot environment variables, and thus scripts, are defined > by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text > to this file and dealing with quoting and newlines is harder than it > should be. It

Re: [PATCH v3 1/4] tools: Separate image types which depend on OpenSSL

2021-10-19 Thread Andre Przywara
On Tue, 19 Oct 2021 08:28:44 -0500 Samuel Holland wrote: Hi Samuel, > On 10/19/21 5:41 AM, Andre Przywara wrote: > > On Mon, 18 Oct 2021 09:09:04 -0500 > > "Alex G." wrote: > > > > Hi, > > > >> On 10/14/21 10:19 PM, Samuel Holland wrote: > >>> Some image types (kwbimage and mxsimage)

[PATCH v2] mmc: arm_pl180_mmci: Enable HWFC for specific versions of MCI

2021-10-19 Thread Usama Arif
There are 4 registers (PERIPHID{0-3}) that contain the ID of MCI. For MMCs' with peripheral id 0x02041180 and 0x03041180, H/W flow control needs to be enabled for multi block writes (MMC CMD 18). Signed-off-by: Usama Arif --- drivers/mmc/arm_pl180_mmci.c | 14 ++

Re: [PATCH v8 5/8] sandbox: Use a text-based environment

2021-10-19 Thread Marek Behún
On Tue, 19 Oct 2021 09:52:14 -0600 Simon Glass wrote: > Hi Marek, > > On Tue, 19 Oct 2021 at 08:32, Marek Behún wrote: > > > > On Mon, 18 Oct 2021 12:13:19 -0600 > > Simon Glass wrote: > > > > > --- /dev/null > > > +++ b/board/sandbox/sandbox.env > > > @@ -0,0 +1,25 @@ > > > +stdin=serial >

Re: [PATCH v1] driver: spi: add bcm iproc qspi support.

2021-10-19 Thread Roman Bacik
On Mon, Oct 11, 2021 at 12:03 AM Bharat Gooty wrote: > > + Roman > Thanks for the review Jagan. Will look and get back to you. > > Thanks, > -Bharat > > On Fri, Oct 8, 2021 at 5:57 PM Jagan Teki wrote: >> >> On Wed, Aug 25, 2021 at 6:55 PM Bharat Kumar Reddy Gooty >> wrote: >> > >> > From:

Re: [PATCH v8 3/8] doc: Move environment documentation to rST

2021-10-19 Thread Marek Behún
On Mon, 18 Oct 2021 12:13:17 -0600 Simon Glass wrote: > Move this from the README to rST format. > > Drop i2cfast since it is obviously obsolete and breaks the formatting. > Other changes and improvements are in a following patch. > > Signed-off-by: Simon Glass Acked-by: Marek Behún

Re: [PATCH v8 2/8] sandbox: Drop distro_boot

2021-10-19 Thread Marek Behún
On Mon, 18 Oct 2021 12:13:16 -0600 Simon Glass wrote: > This is a complicated set of #defines and it is painful to convert to a > text file. We can (once pending patches are applied) provide the same > functionality with bootmethod. Drop this for sandbox to allow conversion > to a text-file

Re: [PATCH v8 8/8] bootm: Tidy up use of autostart env var

2021-10-19 Thread Marek Behún
On Mon, 18 Oct 2021 12:13:22 -0600 Simon Glass wrote: > +bool env_get_autostart(void) > +{ > + const char *val = env_get("autostart"); > + > + return val && !strcmp(val, "yes"); > +} Why not use env_get_yesno() ?

Re: [PATCH v4] sandbox: Remove OF_HOSTFILE

2021-10-19 Thread Ilias Apalodimas
On Tue, 19 Oct 2021 at 18:36, Tom Rini wrote: > > On Tue, Oct 19, 2021 at 06:30:59PM +0300, Ilias Apalodimas wrote: > > On Tue, 19 Oct 2021 at 17:17, Tom Rini wrote: > > > > > > On Tue, Oct 19, 2021 at 08:03:07AM -0600, Simon Glass wrote: > > > > [...] > > > > > > > > > > For some reason this

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Wolfgang Denk
Dear Tom, In message <20211019140711.GC7964@bill-the-cat> you wrote: > > As much as I and others appreciate that you've written the parser here > in a classic UNIX tool, awk, since a lot of the problems also seem to > stem from having the parser be able to handle previously valid > environment

Re: [PATCH v8 6/8] doc: Mention CONFIG_DEFAULT_ENV_FILE

2021-10-19 Thread Marek Behún
On Tue, 19 Oct 2021 09:52:17 -0600 Simon Glass wrote: > Hi Marek, > > On Tue, 19 Oct 2021 at 08:34, Marek Behún wrote: > > > > On Mon, 18 Oct 2021 12:13:20 -0600 > > Simon Glass wrote: > > > > > Add mention of this option this it does a similar thing to the text > > > environment. > > > >

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Simon Glass
Hi Wolfgang, On Tue, 19 Oct 2021 at 10:05, Wolfgang Denk wrote: > > Dear Simon, > > In message > you > wrote: > > > > Well ideally I'd like to avoid Python in this case as it is in the > > compilation path. I am not sure yet what Wolfgang actually wants, > > apart from variable names ending

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Simon Glass
Hi Wolfgang, On Tue, 19 Oct 2021 at 10:09, Wolfgang Denk wrote: > > Dear Simon, > > In message > you > wrote: > > > > I thought you were trying to use + at the end of a variable. > > > > I used: > > > > fred\+=aaa > > > > and got > > > > cc1: warning: unknown escape sequence: '\='' > > > >

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Simon Glass
Hi Wolfgang, On Tue, 19 Oct 2021 at 10:20, Wolfgang Denk wrote: > > Dear Simon, > > In message > you > wrote: > > > > But how do we handle this? > > > > var+=fred > > > > Is this appending to var or assigning to var+ ? > > It is assigning to "var+". er... > > > > var++=fred > > > > is

Re: [PATCH v8 1/8] binman: Allow timeout to occur in the image or its section

2021-10-19 Thread Marek Behún
On Mon, 18 Oct 2021 12:13:15 -0600 Simon Glass wrote: > At present testThreadTimeout() assumes that the expected timeout happens > first when building the section, but it can just as easily happen at the > top-level image. Update the test to cope with both. > > Signed-off-by: Simon Glass

Re: [PATCH v8 5/8] sandbox: Use a text-based environment

2021-10-19 Thread Marek Behún
On Mon, 18 Oct 2021 12:13:19 -0600 Simon Glass wrote: > --- /dev/null > +++ b/board/sandbox/sandbox.env > @@ -0,0 +1,25 @@ > +stdin=serial > +#ifdef CONFIG_SANDBOX_SDL > +stdin+=,cros-ec-keyb,usbkbd this was CONFIG_KEYBOARD and now is CONFIG_SANDBOX_SDL, is this okay?

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Marek Behún
On Mon, 18 Oct 2021 12:13:18 -0600 Simon Glass wrote: > At present U-Boot environment variables, and thus scripts, are defined > by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text > to this file and dealing with quoting and newlines is harder than it > should be. It would

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Simon Glass
Hi Tom, On Tue, 19 Oct 2021 at 08:25, Tom Rini wrote: > > On Tue, Oct 19, 2021 at 08:11:08AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 19 Oct 2021 at 08:07, Tom Rini wrote: > > > > > > On Mon, Oct 18, 2021 at 12:13:18PM -0600, Simon Glass wrote: > > > > > > > At present U-Boot

Re: buildman stops (crashed) on current master

2021-10-19 Thread Simon Glass
Hi Stefano, On Tue, 19 Oct 2021 at 09:39, Stefano Babic wrote: > > Hi Simon, > > On 07.10.21 15:43, Simon Glass wrote: > > Hi Stefano, > > > > On Thu, 7 Oct 2021 at 04:37, Stefano Babic wrote: > >> > >> Hi all, > >> > >> CI stops by building aarch64 without notice, for reference: > >> > >>

Re: [EXT] Re: [PATCH v3 01/16] crypto/fsl: Add support for CAAM Job ring driver model

2021-10-19 Thread Simon Glass
Hi Gaurav, On Tue, 19 Oct 2021 at 00:40, Gaurav Jain wrote: > > Hi Simon > > > -Original Message- > > From: Simon Glass > > Sent: Thursday, October 14, 2021 8:40 PM > > To: Gaurav Jain > > Cc: U-Boot Mailing List ; Stefano Babic > > ; Fabio Estevam ; Peng Fan > > ; Priyanka Jain ; Ye

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Tom Rini
On Tue, Oct 19, 2021 at 10:39:55AM -0600, Simon Glass wrote: > Hi Tom, > > On Tue, 19 Oct 2021 at 10:30, Tom Rini wrote: > > > > On Tue, Oct 19, 2021 at 10:24:25AM -0600, Simon Glass wrote: > > > Hi Wolfgang, > > > > > > On Tue, 19 Oct 2021 at 10:20, Wolfgang Denk wrote: > > > > > > > > Dear

[PATCH] part: return -ENOSYS when get_info not valid.

2021-10-19 Thread zhaohui.shi
From: schspa In some case, get_info() interface can be NULL, add this check to stop from crash. Signed-off-by: schspa --- disk/part.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/disk/part.c b/disk/part.c index a6a8f7052b..7af3240ec7 100644 --- a/disk/part.c +++ b/disk/part.c @@

Re: [PATCH v4] sandbox: Remove OF_HOSTFILE

2021-10-19 Thread Simon Glass
Hi Ilias, On Tue, 19 Oct 2021 at 07:07, Ilias Apalodimas wrote: > > OF_HOSTFILE is used on sandbox configs only. Although it's pretty > unique and not causing any confusions, we are better of having simpler > config options for the DTB. > > So let's replace that with the existing OF_BOARD.

Re: [PATCH v8 6/8] doc: Mention CONFIG_DEFAULT_ENV_FILE

2021-10-19 Thread Marek Behún
On Mon, 18 Oct 2021 12:13:20 -0600 Simon Glass wrote: > Add mention of this option this it does a similar thing to the text > environment. Strange wording. > Suggested-by: Rasmus Villemoes > > Signed-off-by: Simon Glass Extra newline. Other than that Reviewed-by: Marek Behún

Re: [PATCH v4] sandbox: Remove OF_HOSTFILE

2021-10-19 Thread Tom Rini
On Tue, Oct 19, 2021 at 06:30:59PM +0300, Ilias Apalodimas wrote: > On Tue, 19 Oct 2021 at 17:17, Tom Rini wrote: > > > > On Tue, Oct 19, 2021 at 08:03:07AM -0600, Simon Glass wrote: > > [...] > > > > > > > For some reason this still does not apply for me on -master. Can you > > > please

Re: [PATCH v8 5/8] sandbox: Use a text-based environment

2021-10-19 Thread Simon Glass
Hi Marek, On Tue, 19 Oct 2021 at 08:32, Marek Behún wrote: > > On Mon, 18 Oct 2021 12:13:19 -0600 > Simon Glass wrote: > > > --- /dev/null > > +++ b/board/sandbox/sandbox.env > > @@ -0,0 +1,25 @@ > > +stdin=serial > > +#ifdef CONFIG_SANDBOX_SDL > > +stdin+=,cros-ec-keyb,usbkbd > > this was

Re: [PATCH v8 6/8] doc: Mention CONFIG_DEFAULT_ENV_FILE

2021-10-19 Thread Simon Glass
Hi Marek, On Tue, 19 Oct 2021 at 08:34, Marek Behún wrote: > > On Mon, 18 Oct 2021 12:13:20 -0600 > Simon Glass wrote: > > > Add mention of this option this it does a similar thing to the text > > environment. > > Strange wording. I say that a lot :-) https://ludwig.guru/s/add+mention

[PATCH] spl: fit: Skip attempting to load 0 length image

2021-10-19 Thread Nishanth Menon
When, for various reasons, a bad FIT image is used where a loadable image is marked as 0 length, attempt is made for a 0 length allocation and read of 0 byte read operation. Instead provide warning in log and skip attempting to do such a load. Signed-off-by: Nishanth Menon ---

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Simon Glass
Hi Tom, On Tue, 19 Oct 2021 at 08:07, Tom Rini wrote: > > On Mon, Oct 18, 2021 at 12:13:18PM -0600, Simon Glass wrote: > > > At present U-Boot environment variables, and thus scripts, are defined > > by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text > > to this file and

Re: [PATCH v4] sandbox: Remove OF_HOSTFILE

2021-10-19 Thread Tom Rini
On Tue, Oct 19, 2021 at 08:03:07AM -0600, Simon Glass wrote: > Hi Ilias, > > On Tue, 19 Oct 2021 at 07:07, Ilias Apalodimas > wrote: > > > > OF_HOSTFILE is used on sandbox configs only. Although it's pretty > > unique and not causing any confusions, we are better of having simpler > > config

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Tom Rini
On Tue, Oct 19, 2021 at 08:11:08AM -0600, Simon Glass wrote: > Hi Tom, > > On Tue, 19 Oct 2021 at 08:07, Tom Rini wrote: > > > > On Mon, Oct 18, 2021 at 12:13:18PM -0600, Simon Glass wrote: > > > > > At present U-Boot environment variables, and thus scripts, are defined > > > by

Re: [PATCH v8 7/8] doc: Improve environment documentation

2021-10-19 Thread Marek Behún
On Mon, 18 Oct 2021 12:13:21 -0600 Simon Glass wrote: > Make various updates suggested during review of the rST conversion. > > Signed-off-by: Simon Glass > Suggested-by: Wolfgang Denk Reviewed-by: Marek Behún

Re: buildman stops (crashed) on current master

2021-10-19 Thread Stefano Babic
Hi Simon, On 07.10.21 15:43, Simon Glass wrote: Hi Stefano, On Thu, 7 Oct 2021 at 04:37, Stefano Babic wrote: Hi all, CI stops by building aarch64 without notice, for reference: https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/332319 There is no error, just process is killed.

Re: [PATCH v4] sandbox: Remove OF_HOSTFILE

2021-10-19 Thread Simon Glass
Hi Ilias, Tom, On Tue, 19 Oct 2021 at 09:38, Ilias Apalodimas wrote: > > On Tue, 19 Oct 2021 at 18:36, Tom Rini wrote: > > > > On Tue, Oct 19, 2021 at 06:30:59PM +0300, Ilias Apalodimas wrote: > > > On Tue, 19 Oct 2021 at 17:17, Tom Rini wrote: > > > > > > > > On Tue, Oct 19, 2021 at

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > I thought you were trying to use + at the end of a variable. > > I used: > > fred\+=aaa > > and got > > cc1: warning: unknown escape sequence: '\='' > > You can try it yourself by editing sandbox.env in the > u-boot-dm/env-working tree. Hmmm... -> cat

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > But how do we handle this? > > var+=fred > > Is this appending to var or assigning to var+ ? It is assigning to "var+". > > var++=fred > > is unambiguous but very confusing. I think it would be better to disallow + It's neither unambiguous nor confusing.

Re: [PATCH v3 1/4] mkimage: add a flag to describe whether -A is specified

2021-10-19 Thread Simon Glass
Hi, On Tue, 19 Oct 2021 at 07:17, Samuel Holland wrote: > > On 10/19/21 5:49 AM, Andre Przywara wrote: > > On Thu, 14 Oct 2021 20:53:04 -0500 > > Samuel Holland wrote: > > > > Hi, > > > >> From: Icenowy Zheng > >> > >> The sunxi_egon type used to take no -A argument (because we assume sunxi >

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Simon Glass
Hi Wolfgang, On Tue, 19 Oct 2021 at 04:46, Wolfgang Denk wrote: > > Dear Simon, > > In message > you > wrote: > > > > Can we just ban + ? > > Why? Just because your awk script is a lousy parser? > > > In the above, foo\+ gives an unknown escape sequence from the C > > preprocessor, then the

Re: [PATCH] part: return -ENOSYS when get_info not valid.

2021-10-19 Thread Heinrich Schuchardt
On 10/19/21 15:35, zhaohui.shi wrote: From: schspa In some case, get_info() interface can be NULL, add this check to stop from crash. Thank you for reviewing the partition driver code. There seems to be no driver missing a get_info implementation. Where did you run into a problem? Why

Re: [PATCH v3 12/13] env: Simplify env_match() and inline into env_get_f()

2021-10-19 Thread Simon Glass
Hi Marek, On Mon, 18 Oct 2021 at 18:50, Marek Behún wrote: > > > Reviewed-by: Simon Glass > > Simon, thanks. Will you be taking this through your tree or should I > change delegate to Tom? I see it in my queue so I'll pick it up. Regards, Simon

[PATCH] spi: zynqmp_gqspi: Fix write issue at low frequencies

2021-10-19 Thread Ashok Reddy Soma
With current implementation we are seeing write issues at low frequencies below 15Mhz. Make below changes to fix the issue. 1. Remove dummy genfifo entry in zynqmp_qspi_chipselect() which was incorrectly added in the past 2. Enable and poll for TX_FIFO_Empty after Tx data is filled in FIFO in

Re: [PATCH v4] sandbox: Remove OF_HOSTFILE

2021-10-19 Thread Simon Glass
On Tue, 19 Oct 2021 at 08:17, Tom Rini wrote: > > On Tue, Oct 19, 2021 at 08:03:07AM -0600, Simon Glass wrote: > > Hi Ilias, > > > > On Tue, 19 Oct 2021 at 07:07, Ilias Apalodimas > > wrote: > > > > > > OF_HOSTFILE is used on sandbox configs only. Although it's pretty > > > unique and not

Re: [PATCH v4] sandbox: Remove OF_HOSTFILE

2021-10-19 Thread Ilias Apalodimas
On Tue, 19 Oct 2021 at 17:17, Tom Rini wrote: > > On Tue, Oct 19, 2021 at 08:03:07AM -0600, Simon Glass wrote: [...] > > > > For some reason this still does not apply for me on -master. Can you > > please confirm the hash you are using? > > The hunk for scripts/Makefile.spl still fails (it

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > Well ideally I'd like to avoid Python in this case as it is in the > compilation path. I am not sure yet what Wolfgang actually wants, > apart from variable names ending with + which I would like to > disallow. > > So if we can clearly understand the goal,

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Tom Rini
On Tue, Oct 19, 2021 at 10:24:25AM -0600, Simon Glass wrote: > Hi Wolfgang, > > On Tue, 19 Oct 2021 at 10:20, Wolfgang Denk wrote: > > > > Dear Simon, > > > > In message > > you > > wrote: > > > > > > But how do we handle this? > > > > > > var+=fred > > > > > > Is this appending to var or

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Simon Glass
Hi Tom, On Tue, 19 Oct 2021 at 10:30, Tom Rini wrote: > > On Tue, Oct 19, 2021 at 10:24:25AM -0600, Simon Glass wrote: > > Hi Wolfgang, > > > > On Tue, 19 Oct 2021 at 10:20, Wolfgang Denk wrote: > > > > > > Dear Simon, > > > > > > In message > > > you > > > wrote: > > > > > > > > But how do

Re: please help, "Ram disk image is corrupt or invalid" (qemu virt machine, arm64)

2021-10-19 Thread Jaehoon Chung
Hi, On 10/19/21 9:31 PM, Chan Kim wrote: > Hi, Jaehoon, > > Thanks for the help. > >> You can check the debug message in common/image-board.c. >> Did you create ramdisk image the correct format? > > To make ramdisk image (I made initramfs which I know is not a real disk image > format >

Re: [PATCH] clk: fixed_rate: add dummy disable() function

2021-10-19 Thread Tom Rini
On Tue, Oct 12, 2021 at 07:40:29PM -0500, Samuel Holland wrote: > commit 6bf6d81c1112 ("clk: fixed_rate: add dummy enable() function") > implemented .enable, so fixed rate clocks can be used where drivers > might call clk_enable(). Implement the .disable op for the same reason; > some drivers,

[PATCH] fs: yaffs2: Finish Kconfig migration

2021-10-19 Thread Tom Rini
For the symbols which are both hard-coded as enabled and used, move to Kconfig. The rest of the CONFIG_YAFFS namespace is unselected anywhere, so we leave it as is. Signed-off-by: Tom Rini --- fs/yaffs2/Kconfig | 12 fs/yaffs2/Makefile | 4 2 files changed, 12

[PATCH v4 2/4] tools: mkimage: Add Allwinner TOC0 support

2021-10-19 Thread Samuel Holland
Most Allwinner sunxi SoCs have separate boot ROMs in non-secure and secure mode. The "non-secure" or "normal" boot ROM (NBROM) uses the existing sunxi_egon image type. The secure boot ROM (SBROM) uses a completely different image type, known as TOC0. A TOC0 image is composed of a header and two

[PATCH v9 2/7] doc: Move environment documentation to rST

2021-10-19 Thread Simon Glass
Move this from the README to rST format. Drop i2cfast since it is obviously obsolete and breaks the formatting. Other changes and improvements are in a following patch. Signed-off-by: Simon Glass Acked-by: Marek Behún --- (no changes since v6) Changes in v6: - Move all updates to a separate

[PATCH v9 4/7] sandbox: Use a text-based environment

2021-10-19 Thread Simon Glass
Use a text file for the environment instead of the #define settings. Signed-off-by: Simon Glass Reviewed-by: Marek Behún --- (no changes since v3) Changes in v3: - Add new patch to use a text-based environment for sandbox board/sandbox/sandbox.env | 25 +

[PATCH v9 0/7] env: Allow environment in text files

2021-10-19 Thread Simon Glass
One barrier to completing the 7-year-long Kconfig migration is that the default environment is implemented using ad-hoc CONFIG options. At present U-Boot environment variables, and thus scripts, are defined by CONFIG_EXTRA_ENV_SETTINGS. It is not really feasible to move the environment to Kconfig

[PATCH v9 0/7] env: Allow environment in text files

2021-10-19 Thread Simon Glass
One barrier to completing the 7-year-long Kconfig migration is that the default environment is implemented using ad-hoc CONFIG options. At present U-Boot environment variables, and thus scripts, are defined by CONFIG_EXTRA_ENV_SETTINGS. It is not really feasible to move the environment to Kconfig

[PATCH v9 1/7] sandbox: Drop distro_boot

2021-10-19 Thread Simon Glass
This is a complicated set of #defines and it is painful to convert to a text file. We can (once pending patches are applied) provide the same functionality with bootmethod. Drop this for sandbox to allow conversion to a text-file environment. Signed-off-by: Simon Glass Reviewed-by: Marek Behún

[PATCH] sandbox: Migrate ARCH_MAP_SYSMEM to Kconfig

2021-10-19 Thread Tom Rini
Move this from a hard-coded define in config.mk to Kconfig. Signed-off-by: Tom Rini --- arch/sandbox/Kconfig | 3 +++ arch/sandbox/config.mk | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/sandbox/Kconfig b/arch/sandbox/Kconfig index f83282d9d56a..7606469c94ec 100644

[PATCH v4 4/4] sunxi: Support building a SPL as a TOC0 image

2021-10-19 Thread Samuel Holland
Now that mkimage can generate TOC0 images, and the SPL can interpret them, hook up the build infrastructure so the user can choose which image type to build. Since the absolute load address is stored in the TOC0 header, that information must be passed to mkimage. Signed-off-by: Samuel Holland

[PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-19 Thread Samuel Holland
Some image types (kwbimage and mxsimage) always depend on OpenSSL, so they can only be included in mkimage when TOOLS_LIBCRYPTO is selected. Use Makefile logic to conditionally link the files. Signed-off-by: Samuel Holland --- Changes in v4: - Do not select TOOLS_LIBCRYPTO anywhere Changes in

[PATCH v4 0/4] sunxi: TOC0 image type support

2021-10-19 Thread Samuel Holland
This series adds support for the TOC0 image format used by the Allwinner secure boot ROM (SBROM). This series has been tested on the following SoCs/boards, with the eFuse burnt to enable secure mode: - A50: Ainol Q88 Tablet - A64: Pine A64 Plus - H5: Orange Pi Zero Plus - H6: Pine H64 Model B

[PATCH v4 3/4] sunxi: Support SPL in both eGON and TOC0 images

2021-10-19 Thread Samuel Holland
SPL uses the image header to detect the boot device and to find the offset of the next U-Boot stage. Since this information is stored differently in the eGON and TOC0 image headers, add code to find the correct value based on the image type currently in use. Signed-off-by: Samuel Holland ---

[PATCH next v7 02/12] aspeed: ast2600: Enlarge SRAM size

2021-10-19 Thread Chia-Wei Wang
The AST2600 SRAM has been extended to 88KB since A1 chip revision. This patch updates the SRAM size to offer more space for early stack/heap use. Signed-off-by: Chia-Wei Wang --- arch/arm/include/asm/arch-aspeed/platform.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH next v7 00/12] aspeed: Support secure boot chain with FIT image verification

2021-10-19 Thread Chia-Wei Wang
This patch series intends to provide a secure boot chain from SPL to Linux kernel based on the hash and signature verification of FIT image paradigm. To improve the performance and save code size (SPL is limited to 64KB due to HW-RoT), the drviers of two HW crypto engine HACE and ACRY are also

[PATCH next v7 01/12] image: fit: Fix parameter name for hash algorithm

2021-10-19 Thread Chia-Wei Wang
Fix inconsistent function parameter name of the hash algorithm. Signed-off-by: Chia-Wei Wang Fixes: 92055e138f2 ("image: Drop if/elseif hash selection in calculate_hash()") --- common/image-fit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/image-fit.c

  1   2   >