Re: [U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
Hi Stefano, On Mon, Oct 24, 2016 at 7:51 PM, Jagan Teki wrote: > On Mon, Oct 24, 2016 at 7:31 PM, Stefano Babic wrote: >> On 24/10/2016 15:15, Jagan Teki wrote: >>> On Mon, Oct 24, 2016 at 6:04 PM, Stefano Babic wrote: Hi Jagan, >> Please wait, I am confused. You have sent a complete V8, but as far as I understand the oinly changes are reported above (Patch 14/15). However, even if I have not tested, this would break bisecting, because patch 4/23 introduces the board and building with that commit leads to the error. So changes should be respective in patch 4 for mmc and patch 21 for NAND taking as reference V8. >>> >>> Yes, I've added 14/23 and 15/23 for new changes so the previous 14/21 >>> becomes 16/23 now and the only missing one is 21/23. So I will update >>> this 21/23 for v9. Hope this make clear for you. >> >> It is ok if you feel better to send V9 - what I meant it is just that >> entries for CONFIG_DM_MM and CONFIG_DM_MMC_OPS should be done in the >> same patch where the defconfig is added to avoid breaking bisecting. > > OK, then I will send the 14/23 with squash of 14/23 and 15/23 to 16/23 > and 21/23 v9. > Does it fine? Sent these two patches with v9, please let me know for any issues. thanks! -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
On Mon, Oct 24, 2016 at 7:31 PM, Stefano Babic wrote: > On 24/10/2016 15:15, Jagan Teki wrote: >> On Mon, Oct 24, 2016 at 6:04 PM, Stefano Babic wrote: >>> Hi Jagan, > >>> >>> Please wait, I am confused. You have sent a complete V8, but as far as I >>> understand the oinly changes are reported above (Patch 14/15). >>> >>> However, even if I have not tested, this would break bisecting, because >>> patch 4/23 introduces the board and building with that commit leads to >>> the error. So changes should be respective in patch 4 for mmc and patch >>> 21 for NAND taking as reference V8. >> >> Yes, I've added 14/23 and 15/23 for new changes so the previous 14/21 >> becomes 16/23 now and the only missing one is 21/23. So I will update >> this 21/23 for v9. Hope this make clear for you. > > It is ok if you feel better to send V9 - what I meant it is just that > entries for CONFIG_DM_MM and CONFIG_DM_MMC_OPS should be done in the > same patch where the defconfig is added to avoid breaking bisecting. OK, then I will send the 14/23 with squash of 14/23 and 15/23 to 16/23 and 21/23 v9. Does it fine? thanks! -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
On 24/10/2016 15:15, Jagan Teki wrote: > On Mon, Oct 24, 2016 at 6:04 PM, Stefano Babic wrote: >> Hi Jagan, >> >> Please wait, I am confused. You have sent a complete V8, but as far as I >> understand the oinly changes are reported above (Patch 14/15). >> >> However, even if I have not tested, this would break bisecting, because >> patch 4/23 introduces the board and building with that commit leads to >> the error. So changes should be respective in patch 4 for mmc and patch >> 21 for NAND taking as reference V8. > > Yes, I've added 14/23 and 15/23 for new changes so the previous 14/21 > becomes 16/23 now and the only missing one is 21/23. So I will update > this 21/23 for v9. Hope this make clear for you. It is ok if you feel better to send V9 - what I meant it is just that entries for CONFIG_DM_MM and CONFIG_DM_MMC_OPS should be done in the same patch where the defconfig is added to avoid breaking bisecting. Regards, Stefano -- = DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
On Mon, Oct 24, 2016 at 6:04 PM, Stefano Babic wrote: > Hi Jagan, > > On 24/10/2016 14:09, Jagan Teki wrote: >> Hi Stefano, >> >> On Mon, Oct 24, 2016 at 5:31 PM, Stefano Babic wrote: >>> Hi Jagan, >>> >>> On 24/10/2016 13:46, Jagan Teki wrote: >>> > > No, this is not the correct way to do. We should stick with the patches > sent to ML and included in patchworks. They are documented and I cannot > (that means, all custodians are not allowed) to simply pick up patches > from somewhere else. True, but I am not saying you to just apply the branch. My intention was to check the new changes from your side so-that will send the series to ML again. >>> >>> ok >>> > > It is enough that we agree about issue and solution. I had already > tested with the following patch: > > diff --git a/configs/imx6qdl_icore_mmc_defconfig > b/configs/imx6qdl_icore_mmc_defconfig > index 221ea7e..c947e10 100644 > --- a/configs/imx6qdl_icore_mmc_defconfig > +++ b/configs/imx6qdl_icore_mmc_defconfig > @@ -6,6 +6,8 @@ CONFIG_DEFAULT_FDT_FILE="imx6dl-icore.dtb" > CONFIG_DEFAULT_DEVICE_TREE="imx6dl-icore" > CONFIG_SYS_PROMPT="icorem6qdl> " > CONFIG_SPL=y > +# CONFIG_BLK is not set > +# CONFIG_DM_MMC_OPS is not set > CONFIG_BOOTDELAY=3 > CONFIG_BOARD_EARLY_INIT_F=y > CONFIG_DISPLAY_CPUINFO=y > diff --git a/configs/imx6qdl_icore_nand_defconfig nand_defconfig doesn't require this change. >>> >>> It is what I had expected, but fsl_esdhc is built even in the NAND >>> configuration. There is omething else enabling (not in defconfig). >>> >>> In fact, dropping the two lines, I get the error again for >>> imx6qdl_icore_nand. >>> >>> The reason is that even if MMC is not set, as far I can see, these are >>> automatically set: >>> >>> CONFIG_DM_MMC=y >>> CONFIG_DM_MMC_OPS=y >> >> Ohh, Ok, This is because mx6_common.h by default enabling the MMC. > > Right. > >> So I will update these on nand support patch[1] and send the single >> patch, is that OK? >> >> [1] [PATCH v8 21/23] imx6: icorem6: Add NAND support >> > > Please wait, I am confused. You have sent a complete V8, but as far as I > understand the oinly changes are reported above (Patch 14/15). > > However, even if I have not tested, this would break bisecting, because > patch 4/23 introduces the board and building with that commit leads to > the error. So changes should be respective in patch 4 for mmc and patch > 21 for NAND taking as reference V8. Yes, I've added 14/23 and 15/23 for new changes so the previous 14/21 becomes 16/23 now and the only missing one is 21/23. So I will update this 21/23 for v9. Hope this make clear for you. thanks! -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
Hi Jagan, On 24/10/2016 14:09, Jagan Teki wrote: > Hi Stefano, > > On Mon, Oct 24, 2016 at 5:31 PM, Stefano Babic wrote: >> Hi Jagan, >> >> On 24/10/2016 13:46, Jagan Teki wrote: >> No, this is not the correct way to do. We should stick with the patches sent to ML and included in patchworks. They are documented and I cannot (that means, all custodians are not allowed) to simply pick up patches from somewhere else. >>> >>> True, but I am not saying you to just apply the branch. My intention >>> was to check the new changes from your side so-that will send the >>> series to ML again. >> >> ok >> >>> It is enough that we agree about issue and solution. I had already tested with the following patch: diff --git a/configs/imx6qdl_icore_mmc_defconfig b/configs/imx6qdl_icore_mmc_defconfig index 221ea7e..c947e10 100644 --- a/configs/imx6qdl_icore_mmc_defconfig +++ b/configs/imx6qdl_icore_mmc_defconfig @@ -6,6 +6,8 @@ CONFIG_DEFAULT_FDT_FILE="imx6dl-icore.dtb" CONFIG_DEFAULT_DEVICE_TREE="imx6dl-icore" CONFIG_SYS_PROMPT="icorem6qdl> " CONFIG_SPL=y +# CONFIG_BLK is not set +# CONFIG_DM_MMC_OPS is not set CONFIG_BOOTDELAY=3 CONFIG_BOARD_EARLY_INIT_F=y CONFIG_DISPLAY_CPUINFO=y diff --git a/configs/imx6qdl_icore_nand_defconfig >>> >>> nand_defconfig doesn't require this change. >>> >> >> It is what I had expected, but fsl_esdhc is built even in the NAND >> configuration. There is omething else enabling (not in defconfig). >> >> In fact, dropping the two lines, I get the error again for >> imx6qdl_icore_nand. >> >> The reason is that even if MMC is not set, as far I can see, these are >> automatically set: >> >> CONFIG_DM_MMC=y >> CONFIG_DM_MMC_OPS=y > > Ohh, Ok, This is because mx6_common.h by default enabling the MMC. Right. > So I will update these on nand support patch[1] and send the single > patch, is that OK? > > [1] [PATCH v8 21/23] imx6: icorem6: Add NAND support > Please wait, I am confused. You have sent a complete V8, but as far as I understand the oinly changes are reported above (Patch 14/15). However, even if I have not tested, this would break bisecting, because patch 4/23 introduces the board and building with that commit leads to the error. So changes should be respective in patch 4 for mmc and patch 21 for NAND taking as reference V8. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
Hi Stefano, On Mon, Oct 24, 2016 at 5:31 PM, Stefano Babic wrote: > Hi Jagan, > > On 24/10/2016 13:46, Jagan Teki wrote: > >>> >>> No, this is not the correct way to do. We should stick with the patches >>> sent to ML and included in patchworks. They are documented and I cannot >>> (that means, all custodians are not allowed) to simply pick up patches >>> from somewhere else. >> >> True, but I am not saying you to just apply the branch. My intention >> was to check the new changes from your side so-that will send the >> series to ML again. > > ok > >> >>> >>> It is enough that we agree about issue and solution. I had already >>> tested with the following patch: >>> >>> diff --git a/configs/imx6qdl_icore_mmc_defconfig >>> b/configs/imx6qdl_icore_mmc_defconfig >>> index 221ea7e..c947e10 100644 >>> --- a/configs/imx6qdl_icore_mmc_defconfig >>> +++ b/configs/imx6qdl_icore_mmc_defconfig >>> @@ -6,6 +6,8 @@ CONFIG_DEFAULT_FDT_FILE="imx6dl-icore.dtb" >>> CONFIG_DEFAULT_DEVICE_TREE="imx6dl-icore" >>> CONFIG_SYS_PROMPT="icorem6qdl> " >>> CONFIG_SPL=y >>> +# CONFIG_BLK is not set >>> +# CONFIG_DM_MMC_OPS is not set >>> CONFIG_BOOTDELAY=3 >>> CONFIG_BOARD_EARLY_INIT_F=y >>> CONFIG_DISPLAY_CPUINFO=y >>> diff --git a/configs/imx6qdl_icore_nand_defconfig >> >> nand_defconfig doesn't require this change. >> > > It is what I had expected, but fsl_esdhc is built even in the NAND > configuration. There is omething else enabling (not in defconfig). > > In fact, dropping the two lines, I get the error again for > imx6qdl_icore_nand. > > The reason is that even if MMC is not set, as far I can see, these are > automatically set: > > CONFIG_DM_MMC=y > CONFIG_DM_MMC_OPS=y Ohh, Ok, This is because mx6_common.h by default enabling the MMC. So I will update these on nand support patch[1] and send the single patch, is that OK? [1] [PATCH v8 21/23] imx6: icorem6: Add NAND support -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
Hi Jagan, On 24/10/2016 13:46, Jagan Teki wrote: >> >> No, this is not the correct way to do. We should stick with the patches >> sent to ML and included in patchworks. They are documented and I cannot >> (that means, all custodians are not allowed) to simply pick up patches >> from somewhere else. > > True, but I am not saying you to just apply the branch. My intention > was to check the new changes from your side so-that will send the > series to ML again. ok > >> >> It is enough that we agree about issue and solution. I had already >> tested with the following patch: >> >> diff --git a/configs/imx6qdl_icore_mmc_defconfig >> b/configs/imx6qdl_icore_mmc_defconfig >> index 221ea7e..c947e10 100644 >> --- a/configs/imx6qdl_icore_mmc_defconfig >> +++ b/configs/imx6qdl_icore_mmc_defconfig >> @@ -6,6 +6,8 @@ CONFIG_DEFAULT_FDT_FILE="imx6dl-icore.dtb" >> CONFIG_DEFAULT_DEVICE_TREE="imx6dl-icore" >> CONFIG_SYS_PROMPT="icorem6qdl> " >> CONFIG_SPL=y >> +# CONFIG_BLK is not set >> +# CONFIG_DM_MMC_OPS is not set >> CONFIG_BOOTDELAY=3 >> CONFIG_BOARD_EARLY_INIT_F=y >> CONFIG_DISPLAY_CPUINFO=y >> diff --git a/configs/imx6qdl_icore_nand_defconfig > > nand_defconfig doesn't require this change. > It is what I had expected, but fsl_esdhc is built even in the NAND configuration. There is omething else enabling (not in defconfig). In fact, dropping the two lines, I get the error again for imx6qdl_icore_nand. The reason is that even if MMC is not set, as far I can see, these are automatically set: CONFIG_DM_MMC=y CONFIG_DM_MMC_OPS=y >> b/configs/imx6qdl_icore_nand_defconfig >> index 8ac3099..55650bb 100644 >> --- a/configs/imx6qdl_icore_nand_defconfig >> +++ b/configs/imx6qdl_icore_nand_defconfig >> @@ -6,6 +6,8 @@ CONFIG_DEFAULT_FDT_FILE="imx6dl-icore.dtb" >> CONFIG_DEFAULT_DEVICE_TREE="imx6dl-icore" >> CONFIG_SYS_PROMPT="icorem6qdl> " >> CONFIG_SPL=y >> +# CONFIG_BLK is not set >> +# CONFIG_DM_MMC_OPS is not set >> CONFIG_BOOTDELAY=3 >> CONFIG_BOARD_EARLY_INIT_F=y >> CONFIG_DISPLAY_CPUINFO=y > > thanks! > -- = DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
Hi Stefano, On Mon, Oct 24, 2016 at 5:05 PM, Stefano Babic wrote: > Hi Jagan, > > On 24/10/2016 13:03, Jagan Teki wrote: >> Hi Stefano, >> >> On Mon, Oct 24, 2016 at 4:18 PM, Jagan Teki wrote: >>> On Mon, Oct 24, 2016 at 3:53 PM, Jagan Teki wrote: + Peng On Mon, Oct 24, 2016 at 3:46 PM, Stefano Babic wrote: > Hi Jagan, Peng, > > On 24/10/2016 11:05, Stefano Babic wrote: > >>> Did you take the v7 patches? I re-based on top of u-boot-imx/master >>> and it's compiled for me. >> >> I take the v7: >> >> http://patchwork.ozlabs.org/bundle/sbabic/jagan/ >> >> Applied on top of u-boot-imx master, I get the error. There are just a >> few of new patches on the tree, I doubt that are guilty for it. >> > > I got the same issue for mx6ull_14x14_evk_plugin after applying Peng's > patches for plugins. Issue is raised in fsl_esdhc.c driver, that should > be not yet prepared for DM_MMC_OPS. > > Is there a missing patch ? Could you take a look ? >>> >>> Got the issue, we need to update 2 recent changes from Simon >>> patches[1][2] I will fix and update. >>> >>> [1] >>> http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=896a74f615d6ffcbbcbec1505b19ed3280fe7873 >>> [2] >>> http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=252788b4eda852e0195e1903e55480b4bf4fea9d >> >> Please try this patches, I've updated the above changes. >> >> [1] >> http://git.denx.de/?p=u-boot-spi.git;a=shortlog;h=refs/heads/engicam-working >> > > No, this is not the correct way to do. We should stick with the patches > sent to ML and included in patchworks. They are documented and I cannot > (that means, all custodians are not allowed) to simply pick up patches > from somewhere else. True, but I am not saying you to just apply the branch. My intention was to check the new changes from your side so-that will send the series to ML again. > > It is enough that we agree about issue and solution. I had already > tested with the following patch: > > diff --git a/configs/imx6qdl_icore_mmc_defconfig > b/configs/imx6qdl_icore_mmc_defconfig > index 221ea7e..c947e10 100644 > --- a/configs/imx6qdl_icore_mmc_defconfig > +++ b/configs/imx6qdl_icore_mmc_defconfig > @@ -6,6 +6,8 @@ CONFIG_DEFAULT_FDT_FILE="imx6dl-icore.dtb" > CONFIG_DEFAULT_DEVICE_TREE="imx6dl-icore" > CONFIG_SYS_PROMPT="icorem6qdl> " > CONFIG_SPL=y > +# CONFIG_BLK is not set > +# CONFIG_DM_MMC_OPS is not set > CONFIG_BOOTDELAY=3 > CONFIG_BOARD_EARLY_INIT_F=y > CONFIG_DISPLAY_CPUINFO=y > diff --git a/configs/imx6qdl_icore_nand_defconfig nand_defconfig doesn't require this change. > b/configs/imx6qdl_icore_nand_defconfig > index 8ac3099..55650bb 100644 > --- a/configs/imx6qdl_icore_nand_defconfig > +++ b/configs/imx6qdl_icore_nand_defconfig > @@ -6,6 +6,8 @@ CONFIG_DEFAULT_FDT_FILE="imx6dl-icore.dtb" > CONFIG_DEFAULT_DEVICE_TREE="imx6dl-icore" > CONFIG_SYS_PROMPT="icorem6qdl> " > CONFIG_SPL=y > +# CONFIG_BLK is not set > +# CONFIG_DM_MMC_OPS is not set > CONFIG_BOOTDELAY=3 > CONFIG_BOARD_EARLY_INIT_F=y > CONFIG_DISPLAY_CPUINFO=y thanks! -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
Hi Jagan, On 24/10/2016 13:03, Jagan Teki wrote: > Hi Stefano, > > On Mon, Oct 24, 2016 at 4:18 PM, Jagan Teki wrote: >> On Mon, Oct 24, 2016 at 3:53 PM, Jagan Teki wrote: >>> + Peng >>> >>> On Mon, Oct 24, 2016 at 3:46 PM, Stefano Babic wrote: Hi Jagan, Peng, On 24/10/2016 11:05, Stefano Babic wrote: >> Did you take the v7 patches? I re-based on top of u-boot-imx/master >> and it's compiled for me. > > I take the v7: > > http://patchwork.ozlabs.org/bundle/sbabic/jagan/ > > Applied on top of u-boot-imx master, I get the error. There are just a > few of new patches on the tree, I doubt that are guilty for it. > I got the same issue for mx6ull_14x14_evk_plugin after applying Peng's patches for plugins. Issue is raised in fsl_esdhc.c driver, that should be not yet prepared for DM_MMC_OPS. Is there a missing patch ? Could you take a look ? >> >> Got the issue, we need to update 2 recent changes from Simon >> patches[1][2] I will fix and update. >> >> [1] >> http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=896a74f615d6ffcbbcbec1505b19ed3280fe7873 >> [2] >> http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=252788b4eda852e0195e1903e55480b4bf4fea9d > > Please try this patches, I've updated the above changes. > > [1] > http://git.denx.de/?p=u-boot-spi.git;a=shortlog;h=refs/heads/engicam-working > No, this is not the correct way to do. We should stick with the patches sent to ML and included in patchworks. They are documented and I cannot (that means, all custodians are not allowed) to simply pick up patches from somewhere else. It is enough that we agree about issue and solution. I had already tested with the following patch: diff --git a/configs/imx6qdl_icore_mmc_defconfig b/configs/imx6qdl_icore_mmc_defconfig index 221ea7e..c947e10 100644 --- a/configs/imx6qdl_icore_mmc_defconfig +++ b/configs/imx6qdl_icore_mmc_defconfig @@ -6,6 +6,8 @@ CONFIG_DEFAULT_FDT_FILE="imx6dl-icore.dtb" CONFIG_DEFAULT_DEVICE_TREE="imx6dl-icore" CONFIG_SYS_PROMPT="icorem6qdl> " CONFIG_SPL=y +# CONFIG_BLK is not set +# CONFIG_DM_MMC_OPS is not set CONFIG_BOOTDELAY=3 CONFIG_BOARD_EARLY_INIT_F=y CONFIG_DISPLAY_CPUINFO=y diff --git a/configs/imx6qdl_icore_nand_defconfig b/configs/imx6qdl_icore_nand_defconfig index 8ac3099..55650bb 100644 --- a/configs/imx6qdl_icore_nand_defconfig +++ b/configs/imx6qdl_icore_nand_defconfig @@ -6,6 +6,8 @@ CONFIG_DEFAULT_FDT_FILE="imx6dl-icore.dtb" CONFIG_DEFAULT_DEVICE_TREE="imx6dl-icore" CONFIG_SYS_PROMPT="icorem6qdl> " CONFIG_SPL=y +# CONFIG_BLK is not set +# CONFIG_DM_MMC_OPS is not set CONFIG_BOOTDELAY=3 CONFIG_BOARD_EARLY_INIT_F=y CONFIG_DISPLAY_CPUINFO=y This solves the issue and your boards are built, but I won't apply it without discussing with you. I could also apply this directly to patch 4/21 where it belongs, if you agree, without you have to post it again (of course you can post it again, but I am fine also if I fix by applying). What do you mean ? Best regards, Stefano -- = DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
Hi Stefano, On Mon, Oct 24, 2016 at 4:18 PM, Jagan Teki wrote: > On Mon, Oct 24, 2016 at 3:53 PM, Jagan Teki wrote: >> + Peng >> >> On Mon, Oct 24, 2016 at 3:46 PM, Stefano Babic wrote: >>> Hi Jagan, Peng, >>> >>> On 24/10/2016 11:05, Stefano Babic wrote: >>> > Did you take the v7 patches? I re-based on top of u-boot-imx/master > and it's compiled for me. I take the v7: http://patchwork.ozlabs.org/bundle/sbabic/jagan/ Applied on top of u-boot-imx master, I get the error. There are just a few of new patches on the tree, I doubt that are guilty for it. >>> >>> I got the same issue for mx6ull_14x14_evk_plugin after applying Peng's >>> patches for plugins. Issue is raised in fsl_esdhc.c driver, that should >>> be not yet prepared for DM_MMC_OPS. >>> >>> Is there a missing patch ? Could you take a look ? > > Got the issue, we need to update 2 recent changes from Simon > patches[1][2] I will fix and update. > > [1] > http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=896a74f615d6ffcbbcbec1505b19ed3280fe7873 > [2] > http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=252788b4eda852e0195e1903e55480b4bf4fea9d Please try this patches, I've updated the above changes. [1] http://git.denx.de/?p=u-boot-spi.git;a=shortlog;h=refs/heads/engicam-working thanks! -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
On Mon, Oct 24, 2016 at 3:53 PM, Jagan Teki wrote: > + Peng > > On Mon, Oct 24, 2016 at 3:46 PM, Stefano Babic wrote: >> Hi Jagan, Peng, >> >> On 24/10/2016 11:05, Stefano Babic wrote: >> Did you take the v7 patches? I re-based on top of u-boot-imx/master and it's compiled for me. >>> >>> I take the v7: >>> >>> http://patchwork.ozlabs.org/bundle/sbabic/jagan/ >>> >>> Applied on top of u-boot-imx master, I get the error. There are just a >>> few of new patches on the tree, I doubt that are guilty for it. >>> >> >> I got the same issue for mx6ull_14x14_evk_plugin after applying Peng's >> patches for plugins. Issue is raised in fsl_esdhc.c driver, that should >> be not yet prepared for DM_MMC_OPS. >> >> Is there a missing patch ? Could you take a look ? Got the issue, we need to update 2 recent changes from Simon patches[1][2] I will fix and update. [1] http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=896a74f615d6ffcbbcbec1505b19ed3280fe7873 [2] http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=252788b4eda852e0195e1903e55480b4bf4fea9d thanks! -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
+ Peng On Mon, Oct 24, 2016 at 3:46 PM, Stefano Babic wrote: > Hi Jagan, Peng, > > On 24/10/2016 11:05, Stefano Babic wrote: > >>> Did you take the v7 patches? I re-based on top of u-boot-imx/master >>> and it's compiled for me. >> >> I take the v7: >> >> http://patchwork.ozlabs.org/bundle/sbabic/jagan/ >> >> Applied on top of u-boot-imx master, I get the error. There are just a >> few of new patches on the tree, I doubt that are guilty for it. >> > > I got the same issue for mx6ull_14x14_evk_plugin after applying Peng's > patches for plugins. Issue is raised in fsl_esdhc.c driver, that should > be not yet prepared for DM_MMC_OPS. > > Is there a missing patch ? Could you take a look ? -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
Hi Jagan, Peng, On 24/10/2016 11:05, Stefano Babic wrote: >> Did you take the v7 patches? I re-based on top of u-boot-imx/master >> and it's compiled for me. > > I take the v7: > > http://patchwork.ozlabs.org/bundle/sbabic/jagan/ > > Applied on top of u-boot-imx master, I get the error. There are just a > few of new patches on the tree, I doubt that are guilty for it. > I got the same issue for mx6ull_14x14_evk_plugin after applying Peng's patches for plugins. Issue is raised in fsl_esdhc.c driver, that should be not yet prepared for DM_MMC_OPS. Is there a missing patch ? Could you take a look ? Best regards, Stefano Babic -- = DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
On 24/10/2016 10:54, Jagan Teki wrote:
> Hi Stefano,
>
> On Mon, Oct 24, 2016 at 2:06 PM, Stefano Babic wrote:
>> On 24/10/2016 09:53, Jagan Teki wrote:
>>> Hi Stefano,
>>>
>>> On Mon, Oct 17, 2016 at 11:26 AM, Stefano Babic wrote:
Hi Jagan,
On 17/10/2016 05:40, Jagan Teki wrote:
> Hi Stefano,
>
> On Tue, Oct 11, 2016 at 9:00 AM, Jagan Teki wrote:
>> Hi Stefano,
>>
>> On Sun, Oct 9, 2016 at 8:15 PM, Jagan Teki
>> wrote:
>>> Hi Stefano,
>>>
>>> On Sat, Oct 8, 2016 at 6:00 PM, Jagan Teki wrote:
From: Jagan Teki
This series supports Engicam i.CoreM6 QDL modules on top of
u-boot-imx/master
and test on the respective starter kits as well.
Tested both MMC and NAND boot.
Changes for v7:
- Add patch to CONFIG_DEFAULT_FDT_FILE to defconfigs
- Rebase on u-boot-imx/master
Changes for v6:
- Rebase to u-boot-imx/master
- Move few SPL configs to defconfigs
Changes for v5:
- Add NAND support
Changes for v4:
- Add 'net: Kconfig: Add FEC_MXC entry' patch
- Updated ENV configs along with comments
- Restructured configs for more readability
- Add CONFIG_ENV_OVERWRITE
- Rename icorem6qdl_defconfig with icorem6qdl_mmc_defconfig
Changes for v3:
- Remove "v2 01/17 imx: iomux-v3: Fix build error with snvs
base" patch
- Remove 'default n' on Kconfig DEFAULT_FDT_FILE patch
- Add minimal devicetree support for Engicam i.CoreM6 QDL
- Add is_mx6dl()
- Add is_mx6solo()
- Use is_mx6dq()
- Add last commit sha1 and header in pull devicetree files
from Linux
Changes for v2:
- Make static to local iomux structure in board file
- Corrected rowaddr in mx6_ddr3_cfg
- Used imx_ddr_size
- Add FEC support and tested the same
- Add DM_GPIO, DM_MMC support
- Add pinctrl support
- Add devicetree support
Jagan Teki (21):
serial: Kconfig: Add MXC_UART entry
thermal: Kconfig: Add IMX_THERMAL entry
config: Move CONFIG_DEFAULT_FDT_FILE to defconfigs
arm: imx: Add Engicam i.CoreM6 QDL Starter Kit initial support
net: Kconfig: Add FEC_MXC entry
imx6: icorem6: Add ENET support
imx: s/docs\/README.imximage/doc\/README.imximage/g
arm: dts: Add devicetree for i.MX6DL
arm: dts: Add devicetree for i.MX6DQL
arm: dts: imx6dl: Add pinctrl defines
dt-bindings: clock: imx6qdl: Add clock defines
arm: imx6q: Add devicetree support for Engicam i.CoreM6 DualLite/Solo
imx6q: icorem6: Enable pinctrl driver
engicam: icorem6: Add DM_GPIO, DM_MMC support
arm: dts: Add devicetree for i.MX6Q
arm: dts: imx6q: Add pinctrl defines
arm: imx6q: Add devicetree support for Engicam i.CoreM6 Quad/Dual
mtd: nand: Kconfig: Add NAND_MXS entry
imx6: icorem6: Add NAND support
imx6: icorem6: Enable MTD device support
imx6: icorem6: Add default mtd nand partition table
>>>
>>> All set now, please do apply.
>>
>> Let me know if you still find any issues, otherwise apply this.
>>
>
> Any help?
Sorry, I was last week at ELCE - I will go on with your patches (and the
other ones left pending) this week.
>>>
>>> Please apply this, I need to rebase on top of tom/master and send few
>>> more series.
>>>
>>
>>
>> Tried again, it does not compile clean.
>> drivers/mmc/fsl_esdhc.c:715:21: error: variable 'esdhc_ops' has
>> initializer but incomplete type
>> static const struct mmc_ops esdhc_ops = {
>> ^
>> drivers/mmc/fsl_esdhc.c:716:2: error: unknown field 'send_cmd' specified
>> in initializer
>> .send_cmd = esdhc_send_cmd,
>> ^
>> drivers/mmc/fsl_esdhc.c:716:14: warning: excess elements in struct
>> initializer
>> .send_cmd = esdhc_send_cmd,
>> ^
>> drivers/mmc/fsl_esdhc.c:716:14: note: (near initialization for 'esdhc_ops')
>> drivers/mmc/fsl_esdhc.c:717:2: error: unknown field 'set_ios' specified
>> in initializer
>> .set_ios = esdhc_set_ios,
>> ^
>> drivers/mmc/fsl_esdhc.c:717:13: warning: excess elements in struct
>> initializer
>> .set_ios = esdhc_set_ios,
>> ^
>> drivers/mmc/fsl_esdhc.c:717:13: note: (near initialization for 'esdhc_ops')
>> drivers/mmc/fsl_esdhc.c:718:2: error: unknown field 'init' specified in
>> initializer
>> .init = esdhc_init,
>> ^
>> drivers/mmc/fsl_esdhc.c:718:11: warning
Re: [U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
On Mon, Oct 24, 2016 at 2:24 PM, Jagan Teki wrote:
> Hi Stefano,
>
> On Mon, Oct 24, 2016 at 2:06 PM, Stefano Babic wrote:
>> On 24/10/2016 09:53, Jagan Teki wrote:
>>> Hi Stefano,
>>>
>>> On Mon, Oct 17, 2016 at 11:26 AM, Stefano Babic wrote:
Hi Jagan,
On 17/10/2016 05:40, Jagan Teki wrote:
> Hi Stefano,
>
> On Tue, Oct 11, 2016 at 9:00 AM, Jagan Teki wrote:
>> Hi Stefano,
>>
>> On Sun, Oct 9, 2016 at 8:15 PM, Jagan Teki
>> wrote:
>>> Hi Stefano,
>>>
>>> On Sat, Oct 8, 2016 at 6:00 PM, Jagan Teki wrote:
From: Jagan Teki
This series supports Engicam i.CoreM6 QDL modules on top of
u-boot-imx/master
and test on the respective starter kits as well.
Tested both MMC and NAND boot.
Changes for v7:
- Add patch to CONFIG_DEFAULT_FDT_FILE to defconfigs
- Rebase on u-boot-imx/master
Changes for v6:
- Rebase to u-boot-imx/master
- Move few SPL configs to defconfigs
Changes for v5:
- Add NAND support
Changes for v4:
- Add 'net: Kconfig: Add FEC_MXC entry' patch
- Updated ENV configs along with comments
- Restructured configs for more readability
- Add CONFIG_ENV_OVERWRITE
- Rename icorem6qdl_defconfig with icorem6qdl_mmc_defconfig
Changes for v3:
- Remove "v2 01/17 imx: iomux-v3: Fix build error with snvs
base" patch
- Remove 'default n' on Kconfig DEFAULT_FDT_FILE patch
- Add minimal devicetree support for Engicam i.CoreM6 QDL
- Add is_mx6dl()
- Add is_mx6solo()
- Use is_mx6dq()
- Add last commit sha1 and header in pull devicetree files
from Linux
Changes for v2:
- Make static to local iomux structure in board file
- Corrected rowaddr in mx6_ddr3_cfg
- Used imx_ddr_size
- Add FEC support and tested the same
- Add DM_GPIO, DM_MMC support
- Add pinctrl support
- Add devicetree support
Jagan Teki (21):
serial: Kconfig: Add MXC_UART entry
thermal: Kconfig: Add IMX_THERMAL entry
config: Move CONFIG_DEFAULT_FDT_FILE to defconfigs
arm: imx: Add Engicam i.CoreM6 QDL Starter Kit initial support
net: Kconfig: Add FEC_MXC entry
imx6: icorem6: Add ENET support
imx: s/docs\/README.imximage/doc\/README.imximage/g
arm: dts: Add devicetree for i.MX6DL
arm: dts: Add devicetree for i.MX6DQL
arm: dts: imx6dl: Add pinctrl defines
dt-bindings: clock: imx6qdl: Add clock defines
arm: imx6q: Add devicetree support for Engicam i.CoreM6 DualLite/Solo
imx6q: icorem6: Enable pinctrl driver
engicam: icorem6: Add DM_GPIO, DM_MMC support
arm: dts: Add devicetree for i.MX6Q
arm: dts: imx6q: Add pinctrl defines
arm: imx6q: Add devicetree support for Engicam i.CoreM6 Quad/Dual
mtd: nand: Kconfig: Add NAND_MXS entry
imx6: icorem6: Add NAND support
imx6: icorem6: Enable MTD device support
imx6: icorem6: Add default mtd nand partition table
>>>
>>> All set now, please do apply.
>>
>> Let me know if you still find any issues, otherwise apply this.
>>
>
> Any help?
Sorry, I was last week at ELCE - I will go on with your patches (and the
other ones left pending) this week.
>>>
>>> Please apply this, I need to rebase on top of tom/master and send few
>>> more series.
>>>
>>
>>
>> Tried again, it does not compile clean.
>> drivers/mmc/fsl_esdhc.c:715:21: error: variable 'esdhc_ops' has
>> initializer but incomplete type
>> static const struct mmc_ops esdhc_ops = {
>> ^
>> drivers/mmc/fsl_esdhc.c:716:2: error: unknown field 'send_cmd' specified
>> in initializer
>> .send_cmd = esdhc_send_cmd,
>> ^
>> drivers/mmc/fsl_esdhc.c:716:14: warning: excess elements in struct
>> initializer
>> .send_cmd = esdhc_send_cmd,
>> ^
>> drivers/mmc/fsl_esdhc.c:716:14: note: (near initialization for 'esdhc_ops')
>> drivers/mmc/fsl_esdhc.c:717:2: error: unknown field 'set_ios' specified
>> in initializer
>> .set_ios = esdhc_set_ios,
>> ^
>> drivers/mmc/fsl_esdhc.c:717:13: warning: excess elements in struct
>> initializer
>> .set_ios = esdhc_set_ios,
>> ^
>> drivers/mmc/fsl_esdhc.c:717:13: note: (near initialization for 'esdhc_ops')
>> drivers/mmc/fsl_esdhc.c:718:2: error: unknown field 'init' specified in
>> initializer
>> .init = esdhc_init,
>> ^
>> drivers/mmc/fsl_esdhc.c:718
Re: [U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
Hi Stefano,
On Mon, Oct 24, 2016 at 2:06 PM, Stefano Babic wrote:
> On 24/10/2016 09:53, Jagan Teki wrote:
>> Hi Stefano,
>>
>> On Mon, Oct 17, 2016 at 11:26 AM, Stefano Babic wrote:
>>> Hi Jagan,
>>>
>>> On 17/10/2016 05:40, Jagan Teki wrote:
Hi Stefano,
On Tue, Oct 11, 2016 at 9:00 AM, Jagan Teki wrote:
> Hi Stefano,
>
> On Sun, Oct 9, 2016 at 8:15 PM, Jagan Teki
> wrote:
>> Hi Stefano,
>>
>> On Sat, Oct 8, 2016 at 6:00 PM, Jagan Teki wrote:
>>> From: Jagan Teki
>>>
>>> This series supports Engicam i.CoreM6 QDL modules on top of
>>> u-boot-imx/master
>>> and test on the respective starter kits as well.
>>>
>>> Tested both MMC and NAND boot.
>>>
>>> Changes for v7:
>>> - Add patch to CONFIG_DEFAULT_FDT_FILE to defconfigs
>>> - Rebase on u-boot-imx/master
>>>
>>> Changes for v6:
>>> - Rebase to u-boot-imx/master
>>> - Move few SPL configs to defconfigs
>>>
>>> Changes for v5:
>>> - Add NAND support
>>>
>>> Changes for v4:
>>> - Add 'net: Kconfig: Add FEC_MXC entry' patch
>>> - Updated ENV configs along with comments
>>> - Restructured configs for more readability
>>> - Add CONFIG_ENV_OVERWRITE
>>> - Rename icorem6qdl_defconfig with icorem6qdl_mmc_defconfig
>>>
>>> Changes for v3:
>>> - Remove "v2 01/17 imx: iomux-v3: Fix build error with snvs
>>> base" patch
>>> - Remove 'default n' on Kconfig DEFAULT_FDT_FILE patch
>>> - Add minimal devicetree support for Engicam i.CoreM6 QDL
>>> - Add is_mx6dl()
>>> - Add is_mx6solo()
>>> - Use is_mx6dq()
>>> - Add last commit sha1 and header in pull devicetree files from
>>> Linux
>>>
>>> Changes for v2:
>>> - Make static to local iomux structure in board file
>>> - Corrected rowaddr in mx6_ddr3_cfg
>>> - Used imx_ddr_size
>>> - Add FEC support and tested the same
>>> - Add DM_GPIO, DM_MMC support
>>> - Add pinctrl support
>>> - Add devicetree support
>>>
>>> Jagan Teki (21):
>>> serial: Kconfig: Add MXC_UART entry
>>> thermal: Kconfig: Add IMX_THERMAL entry
>>> config: Move CONFIG_DEFAULT_FDT_FILE to defconfigs
>>> arm: imx: Add Engicam i.CoreM6 QDL Starter Kit initial support
>>> net: Kconfig: Add FEC_MXC entry
>>> imx6: icorem6: Add ENET support
>>> imx: s/docs\/README.imximage/doc\/README.imximage/g
>>> arm: dts: Add devicetree for i.MX6DL
>>> arm: dts: Add devicetree for i.MX6DQL
>>> arm: dts: imx6dl: Add pinctrl defines
>>> dt-bindings: clock: imx6qdl: Add clock defines
>>> arm: imx6q: Add devicetree support for Engicam i.CoreM6 DualLite/Solo
>>> imx6q: icorem6: Enable pinctrl driver
>>> engicam: icorem6: Add DM_GPIO, DM_MMC support
>>> arm: dts: Add devicetree for i.MX6Q
>>> arm: dts: imx6q: Add pinctrl defines
>>> arm: imx6q: Add devicetree support for Engicam i.CoreM6 Quad/Dual
>>> mtd: nand: Kconfig: Add NAND_MXS entry
>>> imx6: icorem6: Add NAND support
>>> imx6: icorem6: Enable MTD device support
>>> imx6: icorem6: Add default mtd nand partition table
>>
>> All set now, please do apply.
>
> Let me know if you still find any issues, otherwise apply this.
>
Any help?
>>>
>>> Sorry, I was last week at ELCE - I will go on with your patches (and the
>>> other ones left pending) this week.
>>
>> Please apply this, I need to rebase on top of tom/master and send few
>> more series.
>>
>
>
> Tried again, it does not compile clean.
> drivers/mmc/fsl_esdhc.c:715:21: error: variable 'esdhc_ops' has
> initializer but incomplete type
> static const struct mmc_ops esdhc_ops = {
> ^
> drivers/mmc/fsl_esdhc.c:716:2: error: unknown field 'send_cmd' specified
> in initializer
> .send_cmd = esdhc_send_cmd,
> ^
> drivers/mmc/fsl_esdhc.c:716:14: warning: excess elements in struct
> initializer
> .send_cmd = esdhc_send_cmd,
> ^
> drivers/mmc/fsl_esdhc.c:716:14: note: (near initialization for 'esdhc_ops')
> drivers/mmc/fsl_esdhc.c:717:2: error: unknown field 'set_ios' specified
> in initializer
> .set_ios = esdhc_set_ios,
> ^
> drivers/mmc/fsl_esdhc.c:717:13: warning: excess elements in struct
> initializer
> .set_ios = esdhc_set_ios,
> ^
> drivers/mmc/fsl_esdhc.c:717:13: note: (near initialization for 'esdhc_ops')
> drivers/mmc/fsl_esdhc.c:718:2: error: unknown field 'init' specified in
> initializer
> .init = esdhc_init,
> ^
> drivers/mmc/fsl_esdhc.c:718:11: warning: excess elements in struct
> initializer
> .init = esdhc_init,
>^
> drivers/mmc/fsl_esdhc.c:718:11: note: (near initialization for 'esdhc_ops')
> drivers/mmc/
Re: [U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
On 24/10/2016 09:53, Jagan Teki wrote:
> Hi Stefano,
>
> On Mon, Oct 17, 2016 at 11:26 AM, Stefano Babic wrote:
>> Hi Jagan,
>>
>> On 17/10/2016 05:40, Jagan Teki wrote:
>>> Hi Stefano,
>>>
>>> On Tue, Oct 11, 2016 at 9:00 AM, Jagan Teki wrote:
Hi Stefano,
On Sun, Oct 9, 2016 at 8:15 PM, Jagan Teki
wrote:
> Hi Stefano,
>
> On Sat, Oct 8, 2016 at 6:00 PM, Jagan Teki wrote:
>> From: Jagan Teki
>>
>> This series supports Engicam i.CoreM6 QDL modules on top of
>> u-boot-imx/master
>> and test on the respective starter kits as well.
>>
>> Tested both MMC and NAND boot.
>>
>> Changes for v7:
>> - Add patch to CONFIG_DEFAULT_FDT_FILE to defconfigs
>> - Rebase on u-boot-imx/master
>>
>> Changes for v6:
>> - Rebase to u-boot-imx/master
>> - Move few SPL configs to defconfigs
>>
>> Changes for v5:
>> - Add NAND support
>>
>> Changes for v4:
>> - Add 'net: Kconfig: Add FEC_MXC entry' patch
>> - Updated ENV configs along with comments
>> - Restructured configs for more readability
>> - Add CONFIG_ENV_OVERWRITE
>> - Rename icorem6qdl_defconfig with icorem6qdl_mmc_defconfig
>>
>> Changes for v3:
>> - Remove "v2 01/17 imx: iomux-v3: Fix build error with snvs
>> base" patch
>> - Remove 'default n' on Kconfig DEFAULT_FDT_FILE patch
>> - Add minimal devicetree support for Engicam i.CoreM6 QDL
>> - Add is_mx6dl()
>> - Add is_mx6solo()
>> - Use is_mx6dq()
>> - Add last commit sha1 and header in pull devicetree files from
>> Linux
>>
>> Changes for v2:
>> - Make static to local iomux structure in board file
>> - Corrected rowaddr in mx6_ddr3_cfg
>> - Used imx_ddr_size
>> - Add FEC support and tested the same
>> - Add DM_GPIO, DM_MMC support
>> - Add pinctrl support
>> - Add devicetree support
>>
>> Jagan Teki (21):
>> serial: Kconfig: Add MXC_UART entry
>> thermal: Kconfig: Add IMX_THERMAL entry
>> config: Move CONFIG_DEFAULT_FDT_FILE to defconfigs
>> arm: imx: Add Engicam i.CoreM6 QDL Starter Kit initial support
>> net: Kconfig: Add FEC_MXC entry
>> imx6: icorem6: Add ENET support
>> imx: s/docs\/README.imximage/doc\/README.imximage/g
>> arm: dts: Add devicetree for i.MX6DL
>> arm: dts: Add devicetree for i.MX6DQL
>> arm: dts: imx6dl: Add pinctrl defines
>> dt-bindings: clock: imx6qdl: Add clock defines
>> arm: imx6q: Add devicetree support for Engicam i.CoreM6 DualLite/Solo
>> imx6q: icorem6: Enable pinctrl driver
>> engicam: icorem6: Add DM_GPIO, DM_MMC support
>> arm: dts: Add devicetree for i.MX6Q
>> arm: dts: imx6q: Add pinctrl defines
>> arm: imx6q: Add devicetree support for Engicam i.CoreM6 Quad/Dual
>> mtd: nand: Kconfig: Add NAND_MXS entry
>> imx6: icorem6: Add NAND support
>> imx6: icorem6: Enable MTD device support
>> imx6: icorem6: Add default mtd nand partition table
>
> All set now, please do apply.
Let me know if you still find any issues, otherwise apply this.
>>>
>>> Any help?
>>
>> Sorry, I was last week at ELCE - I will go on with your patches (and the
>> other ones left pending) this week.
>
> Please apply this, I need to rebase on top of tom/master and send few
> more series.
>
Tried again, it does not compile clean.
drivers/mmc/fsl_esdhc.c:715:21: error: variable 'esdhc_ops' has
initializer but incomplete type
static const struct mmc_ops esdhc_ops = {
^
drivers/mmc/fsl_esdhc.c:716:2: error: unknown field 'send_cmd' specified
in initializer
.send_cmd = esdhc_send_cmd,
^
drivers/mmc/fsl_esdhc.c:716:14: warning: excess elements in struct
initializer
.send_cmd = esdhc_send_cmd,
^
drivers/mmc/fsl_esdhc.c:716:14: note: (near initialization for 'esdhc_ops')
drivers/mmc/fsl_esdhc.c:717:2: error: unknown field 'set_ios' specified
in initializer
.set_ios = esdhc_set_ios,
^
drivers/mmc/fsl_esdhc.c:717:13: warning: excess elements in struct
initializer
.set_ios = esdhc_set_ios,
^
drivers/mmc/fsl_esdhc.c:717:13: note: (near initialization for 'esdhc_ops')
drivers/mmc/fsl_esdhc.c:718:2: error: unknown field 'init' specified in
initializer
.init = esdhc_init,
^
drivers/mmc/fsl_esdhc.c:718:11: warning: excess elements in struct
initializer
.init = esdhc_init,
^
drivers/mmc/fsl_esdhc.c:718:11: note: (near initialization for 'esdhc_ops')
drivers/mmc/fsl_esdhc.c:719:2: error: unknown field 'getcd' specified in
initializer
.getcd = esdhc_getcd,
^
drivers/mmc/fsl_esdhc.c:719:12: warning: excess elements in struct
initializer
.getcd = esdhc_getcd,
^
drivers/mmc/f
Re: [U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
Hi Stefano, On Mon, Oct 17, 2016 at 11:26 AM, Stefano Babic wrote: > Hi Jagan, > > On 17/10/2016 05:40, Jagan Teki wrote: >> Hi Stefano, >> >> On Tue, Oct 11, 2016 at 9:00 AM, Jagan Teki wrote: >>> Hi Stefano, >>> >>> On Sun, Oct 9, 2016 at 8:15 PM, Jagan Teki wrote: Hi Stefano, On Sat, Oct 8, 2016 at 6:00 PM, Jagan Teki wrote: > From: Jagan Teki > > This series supports Engicam i.CoreM6 QDL modules on top of > u-boot-imx/master > and test on the respective starter kits as well. > > Tested both MMC and NAND boot. > > Changes for v7: > - Add patch to CONFIG_DEFAULT_FDT_FILE to defconfigs > - Rebase on u-boot-imx/master > > Changes for v6: > - Rebase to u-boot-imx/master > - Move few SPL configs to defconfigs > > Changes for v5: > - Add NAND support > > Changes for v4: > - Add 'net: Kconfig: Add FEC_MXC entry' patch > - Updated ENV configs along with comments > - Restructured configs for more readability > - Add CONFIG_ENV_OVERWRITE > - Rename icorem6qdl_defconfig with icorem6qdl_mmc_defconfig > > Changes for v3: > - Remove "v2 01/17 imx: iomux-v3: Fix build error with snvs base" > patch > - Remove 'default n' on Kconfig DEFAULT_FDT_FILE patch > - Add minimal devicetree support for Engicam i.CoreM6 QDL > - Add is_mx6dl() > - Add is_mx6solo() > - Use is_mx6dq() > - Add last commit sha1 and header in pull devicetree files from > Linux > > Changes for v2: > - Make static to local iomux structure in board file > - Corrected rowaddr in mx6_ddr3_cfg > - Used imx_ddr_size > - Add FEC support and tested the same > - Add DM_GPIO, DM_MMC support > - Add pinctrl support > - Add devicetree support > > Jagan Teki (21): > serial: Kconfig: Add MXC_UART entry > thermal: Kconfig: Add IMX_THERMAL entry > config: Move CONFIG_DEFAULT_FDT_FILE to defconfigs > arm: imx: Add Engicam i.CoreM6 QDL Starter Kit initial support > net: Kconfig: Add FEC_MXC entry > imx6: icorem6: Add ENET support > imx: s/docs\/README.imximage/doc\/README.imximage/g > arm: dts: Add devicetree for i.MX6DL > arm: dts: Add devicetree for i.MX6DQL > arm: dts: imx6dl: Add pinctrl defines > dt-bindings: clock: imx6qdl: Add clock defines > arm: imx6q: Add devicetree support for Engicam i.CoreM6 DualLite/Solo > imx6q: icorem6: Enable pinctrl driver > engicam: icorem6: Add DM_GPIO, DM_MMC support > arm: dts: Add devicetree for i.MX6Q > arm: dts: imx6q: Add pinctrl defines > arm: imx6q: Add devicetree support for Engicam i.CoreM6 Quad/Dual > mtd: nand: Kconfig: Add NAND_MXS entry > imx6: icorem6: Add NAND support > imx6: icorem6: Enable MTD device support > imx6: icorem6: Add default mtd nand partition table All set now, please do apply. >>> >>> Let me know if you still find any issues, otherwise apply this. >>> >> >> Any help? > > Sorry, I was last week at ELCE - I will go on with your patches (and the > other ones left pending) this week. Please apply this, I need to rebase on top of tom/master and send few more series. thanks! -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
Hi Jagan, On 17/10/2016 05:40, Jagan Teki wrote: > Hi Stefano, > > On Tue, Oct 11, 2016 at 9:00 AM, Jagan Teki wrote: >> Hi Stefano, >> >> On Sun, Oct 9, 2016 at 8:15 PM, Jagan Teki wrote: >>> Hi Stefano, >>> >>> On Sat, Oct 8, 2016 at 6:00 PM, Jagan Teki wrote: From: Jagan Teki This series supports Engicam i.CoreM6 QDL modules on top of u-boot-imx/master and test on the respective starter kits as well. Tested both MMC and NAND boot. Changes for v7: - Add patch to CONFIG_DEFAULT_FDT_FILE to defconfigs - Rebase on u-boot-imx/master Changes for v6: - Rebase to u-boot-imx/master - Move few SPL configs to defconfigs Changes for v5: - Add NAND support Changes for v4: - Add 'net: Kconfig: Add FEC_MXC entry' patch - Updated ENV configs along with comments - Restructured configs for more readability - Add CONFIG_ENV_OVERWRITE - Rename icorem6qdl_defconfig with icorem6qdl_mmc_defconfig Changes for v3: - Remove "v2 01/17 imx: iomux-v3: Fix build error with snvs base" patch - Remove 'default n' on Kconfig DEFAULT_FDT_FILE patch - Add minimal devicetree support for Engicam i.CoreM6 QDL - Add is_mx6dl() - Add is_mx6solo() - Use is_mx6dq() - Add last commit sha1 and header in pull devicetree files from Linux Changes for v2: - Make static to local iomux structure in board file - Corrected rowaddr in mx6_ddr3_cfg - Used imx_ddr_size - Add FEC support and tested the same - Add DM_GPIO, DM_MMC support - Add pinctrl support - Add devicetree support Jagan Teki (21): serial: Kconfig: Add MXC_UART entry thermal: Kconfig: Add IMX_THERMAL entry config: Move CONFIG_DEFAULT_FDT_FILE to defconfigs arm: imx: Add Engicam i.CoreM6 QDL Starter Kit initial support net: Kconfig: Add FEC_MXC entry imx6: icorem6: Add ENET support imx: s/docs\/README.imximage/doc\/README.imximage/g arm: dts: Add devicetree for i.MX6DL arm: dts: Add devicetree for i.MX6DQL arm: dts: imx6dl: Add pinctrl defines dt-bindings: clock: imx6qdl: Add clock defines arm: imx6q: Add devicetree support for Engicam i.CoreM6 DualLite/Solo imx6q: icorem6: Enable pinctrl driver engicam: icorem6: Add DM_GPIO, DM_MMC support arm: dts: Add devicetree for i.MX6Q arm: dts: imx6q: Add pinctrl defines arm: imx6q: Add devicetree support for Engicam i.CoreM6 Quad/Dual mtd: nand: Kconfig: Add NAND_MXS entry imx6: icorem6: Add NAND support imx6: icorem6: Enable MTD device support imx6: icorem6: Add default mtd nand partition table >>> >>> All set now, please do apply. >> >> Let me know if you still find any issues, otherwise apply this. >> > > Any help? Sorry, I was last week at ELCE - I will go on with your patches (and the other ones left pending) this week. Regards, Stefano -- = DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
Hi Stefano, On Tue, Oct 11, 2016 at 9:00 AM, Jagan Teki wrote: > Hi Stefano, > > On Sun, Oct 9, 2016 at 8:15 PM, Jagan Teki wrote: >> Hi Stefano, >> >> On Sat, Oct 8, 2016 at 6:00 PM, Jagan Teki wrote: >>> From: Jagan Teki >>> >>> This series supports Engicam i.CoreM6 QDL modules on top of >>> u-boot-imx/master >>> and test on the respective starter kits as well. >>> >>> Tested both MMC and NAND boot. >>> >>> Changes for v7: >>> - Add patch to CONFIG_DEFAULT_FDT_FILE to defconfigs >>> - Rebase on u-boot-imx/master >>> >>> Changes for v6: >>> - Rebase to u-boot-imx/master >>> - Move few SPL configs to defconfigs >>> >>> Changes for v5: >>> - Add NAND support >>> >>> Changes for v4: >>> - Add 'net: Kconfig: Add FEC_MXC entry' patch >>> - Updated ENV configs along with comments >>> - Restructured configs for more readability >>> - Add CONFIG_ENV_OVERWRITE >>> - Rename icorem6qdl_defconfig with icorem6qdl_mmc_defconfig >>> >>> Changes for v3: >>> - Remove "v2 01/17 imx: iomux-v3: Fix build error with snvs base" >>> patch >>> - Remove 'default n' on Kconfig DEFAULT_FDT_FILE patch >>> - Add minimal devicetree support for Engicam i.CoreM6 QDL >>> - Add is_mx6dl() >>> - Add is_mx6solo() >>> - Use is_mx6dq() >>> - Add last commit sha1 and header in pull devicetree files from >>> Linux >>> >>> Changes for v2: >>> - Make static to local iomux structure in board file >>> - Corrected rowaddr in mx6_ddr3_cfg >>> - Used imx_ddr_size >>> - Add FEC support and tested the same >>> - Add DM_GPIO, DM_MMC support >>> - Add pinctrl support >>> - Add devicetree support >>> >>> Jagan Teki (21): >>> serial: Kconfig: Add MXC_UART entry >>> thermal: Kconfig: Add IMX_THERMAL entry >>> config: Move CONFIG_DEFAULT_FDT_FILE to defconfigs >>> arm: imx: Add Engicam i.CoreM6 QDL Starter Kit initial support >>> net: Kconfig: Add FEC_MXC entry >>> imx6: icorem6: Add ENET support >>> imx: s/docs\/README.imximage/doc\/README.imximage/g >>> arm: dts: Add devicetree for i.MX6DL >>> arm: dts: Add devicetree for i.MX6DQL >>> arm: dts: imx6dl: Add pinctrl defines >>> dt-bindings: clock: imx6qdl: Add clock defines >>> arm: imx6q: Add devicetree support for Engicam i.CoreM6 DualLite/Solo >>> imx6q: icorem6: Enable pinctrl driver >>> engicam: icorem6: Add DM_GPIO, DM_MMC support >>> arm: dts: Add devicetree for i.MX6Q >>> arm: dts: imx6q: Add pinctrl defines >>> arm: imx6q: Add devicetree support for Engicam i.CoreM6 Quad/Dual >>> mtd: nand: Kconfig: Add NAND_MXS entry >>> imx6: icorem6: Add NAND support >>> imx6: icorem6: Enable MTD device support >>> imx6: icorem6: Add default mtd nand partition table >> >> All set now, please do apply. > > Let me know if you still find any issues, otherwise apply this. > Any help? thanks! -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
Hi Stefano, On Sun, Oct 9, 2016 at 8:15 PM, Jagan Teki wrote: > Hi Stefano, > > On Sat, Oct 8, 2016 at 6:00 PM, Jagan Teki wrote: >> From: Jagan Teki >> >> This series supports Engicam i.CoreM6 QDL modules on top of u-boot-imx/master >> and test on the respective starter kits as well. >> >> Tested both MMC and NAND boot. >> >> Changes for v7: >> - Add patch to CONFIG_DEFAULT_FDT_FILE to defconfigs >> - Rebase on u-boot-imx/master >> >> Changes for v6: >> - Rebase to u-boot-imx/master >> - Move few SPL configs to defconfigs >> >> Changes for v5: >> - Add NAND support >> >> Changes for v4: >> - Add 'net: Kconfig: Add FEC_MXC entry' patch >> - Updated ENV configs along with comments >> - Restructured configs for more readability >> - Add CONFIG_ENV_OVERWRITE >> - Rename icorem6qdl_defconfig with icorem6qdl_mmc_defconfig >> >> Changes for v3: >> - Remove "v2 01/17 imx: iomux-v3: Fix build error with snvs base" >> patch >> - Remove 'default n' on Kconfig DEFAULT_FDT_FILE patch >> - Add minimal devicetree support for Engicam i.CoreM6 QDL >> - Add is_mx6dl() >> - Add is_mx6solo() >> - Use is_mx6dq() >> - Add last commit sha1 and header in pull devicetree files from Linux >> >> Changes for v2: >> - Make static to local iomux structure in board file >> - Corrected rowaddr in mx6_ddr3_cfg >> - Used imx_ddr_size >> - Add FEC support and tested the same >> - Add DM_GPIO, DM_MMC support >> - Add pinctrl support >> - Add devicetree support >> >> Jagan Teki (21): >> serial: Kconfig: Add MXC_UART entry >> thermal: Kconfig: Add IMX_THERMAL entry >> config: Move CONFIG_DEFAULT_FDT_FILE to defconfigs >> arm: imx: Add Engicam i.CoreM6 QDL Starter Kit initial support >> net: Kconfig: Add FEC_MXC entry >> imx6: icorem6: Add ENET support >> imx: s/docs\/README.imximage/doc\/README.imximage/g >> arm: dts: Add devicetree for i.MX6DL >> arm: dts: Add devicetree for i.MX6DQL >> arm: dts: imx6dl: Add pinctrl defines >> dt-bindings: clock: imx6qdl: Add clock defines >> arm: imx6q: Add devicetree support for Engicam i.CoreM6 DualLite/Solo >> imx6q: icorem6: Enable pinctrl driver >> engicam: icorem6: Add DM_GPIO, DM_MMC support >> arm: dts: Add devicetree for i.MX6Q >> arm: dts: imx6q: Add pinctrl defines >> arm: imx6q: Add devicetree support for Engicam i.CoreM6 Quad/Dual >> mtd: nand: Kconfig: Add NAND_MXS entry >> imx6: icorem6: Add NAND support >> imx6: icorem6: Enable MTD device support >> imx6: icorem6: Add default mtd nand partition table > > All set now, please do apply. Let me know if you still find any issues, otherwise apply this. thanks! -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
Hi Stefano, On Sat, Oct 8, 2016 at 6:00 PM, Jagan Teki wrote: > From: Jagan Teki > > This series supports Engicam i.CoreM6 QDL modules on top of u-boot-imx/master > and test on the respective starter kits as well. > > Tested both MMC and NAND boot. > > Changes for v7: > - Add patch to CONFIG_DEFAULT_FDT_FILE to defconfigs > - Rebase on u-boot-imx/master > > Changes for v6: > - Rebase to u-boot-imx/master > - Move few SPL configs to defconfigs > > Changes for v5: > - Add NAND support > > Changes for v4: > - Add 'net: Kconfig: Add FEC_MXC entry' patch > - Updated ENV configs along with comments > - Restructured configs for more readability > - Add CONFIG_ENV_OVERWRITE > - Rename icorem6qdl_defconfig with icorem6qdl_mmc_defconfig > > Changes for v3: > - Remove "v2 01/17 imx: iomux-v3: Fix build error with snvs base" > patch > - Remove 'default n' on Kconfig DEFAULT_FDT_FILE patch > - Add minimal devicetree support for Engicam i.CoreM6 QDL > - Add is_mx6dl() > - Add is_mx6solo() > - Use is_mx6dq() > - Add last commit sha1 and header in pull devicetree files from Linux > > Changes for v2: > - Make static to local iomux structure in board file > - Corrected rowaddr in mx6_ddr3_cfg > - Used imx_ddr_size > - Add FEC support and tested the same > - Add DM_GPIO, DM_MMC support > - Add pinctrl support > - Add devicetree support > > Jagan Teki (21): > serial: Kconfig: Add MXC_UART entry > thermal: Kconfig: Add IMX_THERMAL entry > config: Move CONFIG_DEFAULT_FDT_FILE to defconfigs > arm: imx: Add Engicam i.CoreM6 QDL Starter Kit initial support > net: Kconfig: Add FEC_MXC entry > imx6: icorem6: Add ENET support > imx: s/docs\/README.imximage/doc\/README.imximage/g > arm: dts: Add devicetree for i.MX6DL > arm: dts: Add devicetree for i.MX6DQL > arm: dts: imx6dl: Add pinctrl defines > dt-bindings: clock: imx6qdl: Add clock defines > arm: imx6q: Add devicetree support for Engicam i.CoreM6 DualLite/Solo > imx6q: icorem6: Enable pinctrl driver > engicam: icorem6: Add DM_GPIO, DM_MMC support > arm: dts: Add devicetree for i.MX6Q > arm: dts: imx6q: Add pinctrl defines > arm: imx6q: Add devicetree support for Engicam i.CoreM6 Quad/Dual > mtd: nand: Kconfig: Add NAND_MXS entry > imx6: icorem6: Add NAND support > imx6: icorem6: Enable MTD device support > imx6: icorem6: Add default mtd nand partition table All set now, please do apply. thanks! -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
