[Bug 1512120]

2018-06-08 Thread Kev Bowring
Been running git thunar with 2 patches (9c6dbb1dae70.patch and fix_crash.patch) Hadn't up till now seen any problems previously noted. However doing the following I have had thunar crash 2 out of 3 times doing so - 2nd and 3rd times trying to get a backtrace (thunar hung AND gdb hung doing the

[Bug 36812]

2018-06-08 Thread Beaux-monde-s
(In reply to Oleg from comment #153) > (In reply to Serge Roussak from comment #152) > > (In reply to Oleg from comment #151) > > > Did the old patch work for you? I mean could you switch the layout > > > pressing > > > Ctrl while combos like Ctrl-S also worked as expected? > > > > Which patch

[Bug 1512120]

2018-06-08 Thread Kev Bowring
Sorry - my previous post might have read confusingly. The ppa version has your patch and 9c6dbb1dae in it. Since then I've had thunar crash on me moving 1 file. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1512120]

2018-06-08 Thread Kev Bowring
Had no luck getting a backtrace I'm afraid. This is what I've done today. sda - copying 26Gb to sdc and sdd sdc - copying 50Gb to sda sdd - copying 30Gb to sda sdd - running the txt to txt.txt from comment #32 with a sleep of 0.25 Detached tabs as soon as a task was in progress I ran this 3

[Bug 1512120]

2018-06-08 Thread Yuri Ribeiro Sucupira
"Comment 78 for bug 1512120 Kent Lion (klsu) wrote 50 minutes ago: #78 Thought this might help someone who knows Thunar better than I do figure out this bug. When I ran the Xubuntu Thunar test 1512120 on a desktop running XUbuntu 16.04 64 bit on a Dell GX620, not only does Thunar crash, but

[Bug 1512120]

2018-06-08 Thread Pgkos-bugzilla
Created attachment 6976 Fix crash and hang while renaming A new version of my patch. This fixes both: - the crash when renaming a file through the popup dialog - the hang when renaming many files at once (e.g. using mv) For the remaining crashes (while using mv command), please apply

[Bug 1512120]

2018-06-08 Thread Pgkos-bugzilla
Created attachment 6978 Fix crash and hang while renaming (2) @flocculant I have updated the patch - please test. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: [SRU] thunar crashes

[Bug 1512120]

2018-06-08 Thread Pgkos-bugzilla
The hangs may be caused by the multithreading bug from my previous comment. The problem is this: there is both a folder monitor and a file monitor. Usually, the file monitor is registered before the folder monitor. If that happens, when a file is renamed, the file monitor gets called and the

[Bug 1512120]

2018-06-08 Thread Simon Steinbeiß
(In reply to Simon Steinbeiss from comment #170) > (lt-thunar:7709): thunar-WARNING **: Content type loading failed for > 10.txt.txt: Error when getting information for file '/tmp/10.txt.txt': No > such file or directory Ignore the above comment, it's not relevant and was erroneously posted

[Bug 1512120]

2018-06-08 Thread Yves-Alexis Perez
(In reply to pgkos.bugzilla from comment #167) > Created attachment 6976 [details] > Fix crash and hang while renaming > > A new version of my patch. This fixes both: > - the crash when renaming a file through the popup dialog > - the hang when renaming many files at once (e.g. using mv) > > For

[Bug 1512120]

2018-06-08 Thread Pgkos-bugzilla
Unfortunately, I have spotted yet another multithreading bug (I have verified it in gdb). Basically, thunar_file_finalize function in thunar-file.c is not thread safe. The reason why this function is bad is that when gobject's reference count reaches 0 (inside Glib's g_object_unref, see

[Bug 1512120]

2018-06-08 Thread Pgkos-bugzilla
@x...@dirdi.name - thank you for the suggestions. Regarding the hangs, I'm pretty certain that the hanging is not caused by my mutex - thunar_folder_monitor is always called on the main thread (it is a slot function). Also, I have experienced the same hang without the mutex. -- You received this

[Bug 1512120]

2018-06-08 Thread Xfce-d
pgkos.bugzilla basically did, what I proposed at comment #95 half a year ago: He identified the critical sections and implemented synchronization to prevent the race condition. And that's exactly the right way to fix this bug! If pgkos.bugzilla determined the CS right, the rest should be a child's

[Bug 1512120]

2018-06-08 Thread Pgkos-bugzilla
@Simon Steinbeiss My patch only prevents the crash, it does not affect the hanging at all - Thunar also hangs during your test without my patch. The hanging is a distinct issue. If I have time I will try to fix that issue as well. -- You received this bug notification because you are a member

[Bug 1512120]

2018-06-08 Thread Pgkos-bugzilla
@Martin Dauskardt The patch is based on the git master. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: [SRU] thunar crashes on file renaming To manage notifications about this bug

[Bug 1512120]

2018-06-08 Thread Yomito
Mint 18 XFCE just updated to 18.1 here. Still with Thunar 1.6.10-3mint1. Still working like a charm. No problem moving files between folders. No problem renaming files. Mint team got the answer to your problems. -- You received this bug notification because you are a member of Ubuntu Bugs, which

[Bug 1512120]

2018-06-08 Thread Simon Steinbeiß
(In reply to pgkos.bugzilla from comment #155) > I am sending a simple patch which wraps the renaming code and the folder > monitor code in a mutex. > > I suppose that the main reason for the crash is that when we call in > thunar-file.c:1932: > > g_file_set_display_name (file->gfile, name,

[Bug 1512120]

2018-06-08 Thread Kip Warner
(In reply to Peter Feichtinger from comment #146) > Please file another bug for that issue and stop spamming the comments for > this one. Peter, please remember your manners. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1512120]

2018-06-08 Thread Yomito
Six boring minutes watching Simon Steinbeiss' test (comment 160) working on Thunar 1.6.10-3mint1 (Mint Xfce 18.1). During all the time the files changed their names with no problem at all. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 1512120]

2018-06-08 Thread Martin-dauskardt
@ pgkos: Which version of thunar was the base for this patch? -1.6.10 vanilla? -1.6.10 with patches from Distribution? (1.6.10 in Xubuntu 16.10 has for example some additional patches, including the Check-if-a-thunar-file-is-still-valid-before-reloading.patch from 17.02.2016 from Harald

[Bug 1512120]

2018-06-08 Thread Kip Warner
Ok gents, let's all just chill and return to focusing on the issue at hand. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: [SRU] thunar crashes on file renaming To manage

[Bug 1512120]

2018-06-08 Thread Z-spam-b
Mint applies 4 patches to Thunar in 1.6.10-3mint1: 0001-Don-t-copy-templates-but-create-them-bug-8312.patch (bug #8312) 01_support-non-multiarch-modules.patch (related to loading modules on different architectures, not related to this bug)

[Bug 1512120]

2018-06-08 Thread Slumbergod-n
Hey Peter why don't you remove yourself from all these bug reports and do the rest of us a favour. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: [SRU] thunar crashes on file renaming

[Bug 1512120]

2018-06-08 Thread Slumbergod-n
I am sick to death of a$$holes who contribute nothing useful coming on here and criticising others for making an effort to get this bug fixed. You guys have no manners and act like you own the world but I don't see any of your contributions. This is the problem with linux. It is infected with

[Bug 1512120]

2018-06-08 Thread Pgkos-bugzilla
Created attachment 6965 Fix race in thunar_file_rename and thunar_folder_monitor -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: [SRU] thunar crashes on file renaming To manage

[Bug 1512120]

2018-06-08 Thread Pgkos-bugzilla
I am sending a simple patch which wraps the renaming code and the folder monitor code in a mutex. I suppose that the main reason for the crash is that when we call in thunar-file.c:1932: g_file_set_display_name (file->gfile, name, cancellable, error); this call sends a signal which is connected

[Bug 1512120]

2018-06-08 Thread Patrice
I would like to confirm this bug which I noticed. xUbuntu 16.10 / AMD64 xfce 4.12.0-2 ubuntu Thunar crashes about every 3 or 4 file rename ! Error : Segmentation fault (core dumped) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1512120]

2018-06-08 Thread Martin-dauskardt
What slumbergod reported is absolutely on-topic. The problems he and Yuri were writing about are known side-effect of an earlier patch (which we all hoped that it could be a solution for the renaming/remove crash.) The side effects with this patch (when accessing USB drives and other file

[Bug 1512120]

2018-06-08 Thread Peter Feichtinger
Wow, I didn't expect that. I was not at all trying to be rude and I'm sorry if I offended anyone. It's just that commenting on this bug with another problem doesn't help anyone either. @slumbergod: Looking at your comment you are not allowed to talk about manners, at all. I mean come on,

[Bug 36812]

2018-06-08 Thread Ran Benita
Nikolay, First, background: I am not a xorg developer, but I develop the XKB library used by most Wayland compositors (xkbcommon). The behavior there is the same. IMO it is worth having a discussion about the behavior. A nice thing about XKB is that it has a specification. It is easier to

[Bug 1512120]

2018-06-08 Thread Yomito
My experience: I'm using Mint XFCE 18 x64 since a couple of months and Thunar is working correctly. This distro uses a version of Thunar called 1.6.10-3mint1. On any other modern distro that I tried and includes Thunar 1.6.10 (MX16, Xubuntu16.04, LinuxLite3, etc) the file manager is buggy. Mint

[Bug 1512120]

2018-06-08 Thread Peter Feichtinger
Please file another bug for that issue and stop spamming the comments for this one. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: [SRU] thunar crashes on file renaming To manage

[Bug 1512120]

2018-06-08 Thread Yomito
Addendum: Kernel on Mint 18 is 4.4.0-xx -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: [SRU] thunar crashes on file renaming To manage notifications about this bug go to:

[Bug 1512120]

2018-06-08 Thread Slumbergod-n
@yuri. Thanks Yuri, I appreciated the PPA. Much easier to test. After some additional testing: kernel 4.9.4 patched Thunar hangs when trying to view contents on newly inserted flash drive. kernel 4.7.10 same. Thunar hangs. Can't mount or view contents. BUT I have discovered that thunar only

[Bug 1512120]

2018-06-08 Thread Yuri Ribeiro Sucupira
(In reply to slumbergod from comment #141) > @Yuri. Thunar hangs for me trying to view the contents of a newly inserted > flash drive. This is weird. I mean: I'm running 64-bit XUbuntu 16.04.1 LTS with Thunar 1.6.10-2ubuntu1+patch1 installed from my PPA

[Bug 1512120]

2018-06-08 Thread Yuri Ribeiro Sucupira
(In reply to Kip from comment #132) > Hey Yuri. I just tried your Thunar packages for Yakkety and I can confirm > that I am unable to reproduce the crash we've all been having on file / > directory rename. Glad to hear that. I had only Xenial (*Ubuntu 16.04) packages on that PPA, but I've

[Bug 1512120]

2018-06-08 Thread Z-spam-b
I just tested patch #6779: It fixes the issue, but thunar becomes unresponsive for me when trying to access another filesystem like a USB drive. This does not happen with #6530 and #6778, which also seem to fix the problem (I didn't test extensively, though). -- You received this bug

[Bug 1512120]

2018-06-08 Thread Simon Steinbeiß
@poma: quoting from the only open issue at https://github.com/rgcjonas/thunar-gtk3: "Thunar-gtk3 is a personal research project which is kind of abandoned at this point and likely not going anywhere." This doesn't sound like something which you want to merge to master. -- You received this bug

[Bug 1512120]

2018-06-08 Thread John Carmack
Thunar 1.6.10-4 still crashes during moving files, drag-and-drop, cut- and-paste and renaming. This has been going on since 2015. It makes Thunar completely unusable, please fix this!!! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1512120]

2018-06-08 Thread Yves-Alexis Perez
(In reply to Andreas Böhler from comment #134) > I forgot to mention that I am on an x64 Arch Linux machine (current as of > today). an strace (with patch #6779 applied) gives: > > write(4, "\1\0\0\0\0\0\0\0", 8) = 8 > recvmsg(5, {msg_namelen=0}, MSG_CMSG_CLOEXEC) = -1 EAGAIN (Resource >

[Bug 1512120]

2018-06-08 Thread Yuri Ribeiro Sucupira
> After a LOT of pain (it took me some hours) I finally managed to sign my > sources and upload'em to a PPA. Here's the PPA: > > https://launchpad.net/~yuri-sucupira/+archive/ubuntu/thunar1.6.10-patched > > However, I noticed that APT is considering "1.6.10-2ubuntu1" as a newer > version than my

[Bug 1512120]

2018-06-08 Thread Slumbergod-n
@Yuri. Thunar hangs for me trying to view the contents of a newly inserted flash drive. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: [SRU] thunar crashes on file renaming To manage

[Bug 1512120]

2018-06-08 Thread Massimo-burcheri
I completely agree. Most things people do with a filemanager is moving and naming files. I looked out for other filemanagers like nautilus, xfe, spacefm, gentoo, pcmanfm, etc. I would like to stay with the Xfce default as I generally like it, but the importance or severity of this bug must be

[Bug 1512120]

2018-06-08 Thread Massimo-burcheri
Please check for duplicates: #12260, #10805 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: [SRU] thunar crashes on file renaming To manage notifications about this bug go to:

[Bug 1512120]

2018-06-08 Thread WebDawg
Archlinux Latestalways crashing. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: [SRU] thunar crashes on file renaming To manage notifications about this bug go to:

[Bug 1512120]

2018-06-08 Thread Z-spam-b
I forgot to mention that I am on an x64 Arch Linux machine (current as of today). an strace (with patch #6779 applied) gives: write(4, "\1\0\0\0\0\0\0\0", 8) = 8 recvmsg(5, {msg_namelen=0}, MSG_CMSG_CLOEXEC) = -1 EAGAIN (Resource temporarily unavailable) inotify_rm_watch(14, 5)

[Bug 1512120]

2018-06-08 Thread Yuri Ribeiro Sucupira
(In reply to Kip from comment #124) > (In reply to Yuri R. Sucupira from comment #123) > > After a LOT of pain (it took me some hours) I finally managed to sign my > > sources and upload'em to a PPA. Here's the PPA: > > > > https://launchpad.net/~yuri-sucupira/+archive/ubuntu/thunar1.6.10-patched

[Bug 1512120]

2018-06-08 Thread jEsuSdA
I can confirm the freezes when external USB pendrive is connected. :_( -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: [SRU] thunar crashes on file renaming To manage notifications

[Bug 1512120]

2018-06-08 Thread Kip Warner
Hey Yuri. I just tried your Thunar packages for Yakkety and I can confirm that I am unable to reproduce the crash we've all been having on file / directory rename. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1512120]

2018-06-08 Thread Ketetefid
I have applied the patch (in my Gentoo system) and have intensively tested it. Not even a single crash since 3 weeks ago. I do a lot of moving and renaming every day and I always try to do it differently to trigger any crash, but thunar has become really robust. It seems that we can close this

[Bug 1512120]

2018-06-08 Thread Yuri Ribeiro Sucupira
(In reply to haarp from comment #126) > Could we please keep the support and packaging stuff to a minimum here? > > I appreciate the work people do on getting these critical fixes packaged, > but this isn't a support forum. This section is for the bug itself. Ok, sorry. Well, if anyone doesn't

[Bug 1512120]

2018-06-08 Thread Main-haarp
Could we please keep the support and packaging stuff to a minimum here? I appreciate the work people do on getting these critical fixes packaged, but this isn't a support forum. This section is for the bug itself. -- You received this bug notification because you are a member of Ubuntu Bugs,

[Bug 1512120]

2018-06-08 Thread Kip Warner
(In reply to Yuri R. Sucupira from comment #123) > After a LOT of pain (it took me some hours) I finally managed to sign my > sources and upload'em to a PPA. Here's the PPA: > > https://launchpad.net/~yuri-sucupira/+archive/ubuntu/thunar1.6.10-patched > > However, I noticed that APT is

[Bug 1512120]

2018-06-08 Thread Yuri Ribeiro Sucupira
(In reply to Kip from comment #117) > (In reply to Yuri R. Sucupira from comment #116) > > I've managed to build and install the (actually five) "patched" DEB > > packages. Now Thunar seems to be back to normal, although I still have more > > testing to do. > > > > I've uploaded those packages to

[Bug 1512120]

2018-06-08 Thread Yuri Ribeiro Sucupira
(In reply to xb from comment #118) > (In reply to Yuri R. Sucupira from comment #116) > > (In reply to xb from comment #115) > > > (In reply to Roy Richardson from comment #114) > > > > Created attachment 6801 [details] > > > > Notes for patching Thunar on Ubuntu with patch #6779 > > > > > > > >

[Bug 1512120]

2018-06-08 Thread Yuri Ribeiro Sucupira
(In reply to Kip from comment #121) > (In reply to Yuri R. Sucupira from comment #120) > > And > > unfortunately I didn't succeed in uploading data to the PPA (I'm using dput, > > but something's going wrong). I thought I could push the DEB files to the > > PPA, but it's actually forbidden: one

[Bug 1512120]

2018-06-08 Thread Yuri Ribeiro Sucupira
(In reply to Roy Richardson from comment #114) > Created attachment 6801 [details] > Notes for patching Thunar on Ubuntu with patch #6779 > > > I've successfully tested patch #6779 on Debian Stretch i386, Debian Stretch > amd64, Xubuntu 16.04 amd64 and Arch x86_64. Here are my notes for patching

[Bug 1512120]

2018-06-08 Thread Kip Warner
(In reply to Yuri R. Sucupira from comment #120) > And > unfortunately I didn't succeed in uploading data to the PPA (I'm using dput, > but something's going wrong). I thought I could push the DEB files to the > PPA, but it's actually forbidden: one must push the sources, which I'm > failing to

[Bug 1512120]

2018-06-08 Thread WebDawg
Thread 1 "thunar" received signal SIGSEGV, Segmentation fault. 0x7466fd26 in __strcmp_ssse3 () from /usr/lib/libc.so.6 (gdb) bt #0 0x7466fd26 in __strcmp_ssse3 () from /usr/lib/libc.so.6 #1 0x004340ad in ?? () #2 0x004406cb in ?? () #3 0x74b645d4 in ??

[Bug 1512120]

2018-06-08 Thread Kip Warner
(In reply to Yuri R. Sucupira from comment #116) > I've managed to build and install the (actually five) "patched" DEB > packages. Now Thunar seems to be back to normal, although I still have more > testing to do. > > I've uploaded those packages to my OneDrive: > >

[Bug 1512120]

2018-06-08 Thread Xbarbie-4
(In reply to Yuri R. Sucupira from comment #116) > (In reply to xb from comment #115) > > (In reply to Roy Richardson from comment #114) > > > Created attachment 6801 [details] > > > Notes for patching Thunar on Ubuntu with patch #6779 > > > > > > > > > I've successfully tested patch #6779 on

[Bug 1512120]

2018-06-08 Thread Rocketx86
Created attachment 6801 Notes for patching Thunar on Ubuntu with patch #6779 I've successfully tested patch #6779 on Debian Stretch i386, Debian Stretch amd64, Xubuntu 16.04 amd64 and Arch x86_64. Here are my notes for patching and building Thunar on Ubuntu. I hope this works as well for you

[Bug 1512120]

2018-06-08 Thread Derk Willem te Bokkel
patch in attachment 6779 will not apply .. seems damaged?? incomplete lines? patch does not " find the file to patch .. incorrect -p or strip option .." the other patches 6778 and 6530 apply fine but I still had a crash on a file move for thunar-gtk3 with patches.. -- You received this bug

[Bug 1512120]

2018-06-08 Thread Xbarbie-4
(In reply to Roy Richardson from comment #114) > Created attachment 6801 [details] > Notes for patching Thunar on Ubuntu with patch #6779 > > > I've successfully tested patch #6779 on Debian Stretch i386, Debian Stretch > amd64, Xubuntu 16.04 amd64 and Arch x86_64. Here are my notes for patching

[Bug 1512120]

2018-06-08 Thread Yuri Ribeiro Sucupira
(In reply to xb from comment #115) > (In reply to Roy Richardson from comment #114) > > Created attachment 6801 [details] > > Notes for patching Thunar on Ubuntu with patch #6779 > > > > > > I've successfully tested patch #6779 on Debian Stretch i386, Debian Stretch > > amd64, Xubuntu 16.04

[Bug 1512120]

2018-06-08 Thread Derk Willem te Bokkel
ok manually edited files to match patch-attachment 6779 .. discovered another chunk of code (an if statement not in the source that 6779 was patched against) removed the extra if and the patched source compiled and built fine .. but crashed attempting the first file move .. this is just 6779 w/o

[Bug 1512120]

2018-06-08 Thread J-g-rennison+xfce4-bugzilla
Created attachment 6778 This changes tunar_file_rename/_thunar_io_jobs_rename so that thunar_file_monitor_moved is called in the main thread, instead of the IO job thread. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1512120]

2018-06-08 Thread Pomidorabelisima
(In reply to Jonathan Rennison from comment #108) > The patch in attachment 6778 [details] above moves the call to > thunar_file_monitor_moved which was previously done within > thunar_file_rename when called by _thunar_io_jobs_rename in an IO thread > job, to be instead called by a new function

[Bug 1512120]

2018-06-08 Thread J-g-rennison+xfce4-bugzilla
The patch in attachment 6778 above moves the call to thunar_file_monitor_moved which was previously done within thunar_file_rename when called by _thunar_io_jobs_rename in an IO thread job, to be instead called by a new function thunar_file_rename_notify by _thunar_io_jobs_rename_notify in the

[Bug 1512120]

2018-06-08 Thread Slumbergod-n
You could have been friendlier. Instead you show yourself to be an asshole. Adios. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: [SRU] thunar crashes on file renaming To manage

[Bug 1512120]

2018-06-08 Thread Rocketx86
Created attachment 6779 Handle folder change events with file info synchronization Here's the latest set of changes that I have been testing which handle folder change events and synchronize updates to file info by multiple threads. The patch contains the following changes to address the

[Bug 1512120]

2018-06-08 Thread Slumbergod-n
Yes, please add it to the mailing list and ask for Harald's thoughts. I'm not on any mailing lists because I got tired of the egos and flaming. Perhaps if Harald gives his thoughts and something is decided you can just post a small summary here for the benefit of those affected who simply want

[Bug 1512120]

2018-06-08 Thread Flo-xfce
Please stop the discussion about rewriting Thunar, Bountyhunting, switching to different file managers, etc. - it has nothing to do with the bug report and only adds clutter which makes it even harder to track progress. The mailing list is a good alternative, or start a new bug report for each

[Bug 1512120]

2018-06-08 Thread Rocketx86
(In reply to John Lindgren from comment #93) > This is most likely due to multiple threads clobbering the GFileInfo within > the same ThunarFile. At this point, I guess I would say that the basic > design of sharing the common hash table of ThunarFiles between multiple > threads is flawed.

[Bug 1512120]

2018-06-08 Thread Pomidorabelisima
(In reply to slumbergod from comment #94) > Perhaps it is time to fund a dedicated, professional software engineer to > fix this once and for all. It's clear that parts of the code base need a > complete rewrite and at the moment it feels like the patches are only > mitigating the symptoms rather

[Bug 1512120]

2018-06-08 Thread Htd-c
Well, Thunar is dead. Period. There are a bunch of other replacements like xfe, nautilus, whatever that just work. There is obviously sparse interest, if any, in developing thunar. And hey, that's ok, after all it is free software and times are changing. So let us all recognize that and move on,

[Bug 1512120]

2018-06-08 Thread Main-haarp
(In reply to slumbergod from comment #99) > Offering a bounty is a nice idea but I still think this requires something > bigger. We really need to crowdfund to hire a software engineer to re-write > a significant chunk of code rather than just work out a single fix. > > It might even lead to some

[Bug 1512120]

2018-06-08 Thread Slumbergod-n
Nothing can proceed forwards until we get some feedback from the main xfce developers. I'm not even sure if anyone is in charge of the thunar project and my attempts in the past to ask what the status of the project is with regard to fixing the bugs have gone unanswered. Perhaps they have a plan

[Bug 1512120]

2018-06-08 Thread Slumbergod-n
Offering a bounty is a nice idea but I still think this requires something bigger. We really need to crowdfund to hire a software engineer to re-write a significant chunk of code rather than just work out a single fix. It might even lead to some of the other papercut bugs getting sorted (I know

[Bug 1512120]

2018-06-08 Thread Main-haarp
(In reply to slumbergod from comment #101) > Nothing can proceed forwards until we get some feedback from the main xfce > developers. > > I'm not even sure if anyone is in charge of the thunar project and my > attempts in the past to ask what the status of the project is with regard to > fixing

[Bug 1512120]

2018-06-08 Thread Xbarbie-4
Firstly, I apologise for being such newbie in these things, if this post does not belong here, please ignore it. I am experiencing this same bug as many people reported, This looks like the best solution I have found. As I do not know where to ask, I ask here: Is there any guide / list of

[Bug 1512120]

2018-06-08 Thread Xfce-d
slumbergod is right: The bug has not been tracked down, yet. By now it seems pretty clear that the bug is caused by different threads that operate on the same data(structures). Unfortunately bugs, which are related to multithreading are hard to track down, since they are non- deterministic and

[Bug 1512120]

2018-06-08 Thread John Lindgren
(In reply to Roy Richardson from comment #92) > #4 0x74e23c7a in g_object_unref () from /usr/lib/libgobject-2.0.so.0 > #5 0x0043d862 in thunar_file_info_clear (file=0x7fffe00203b0) at > thunar-file.c:912 This is most likely due to multiple threads clobbering the GFileInfo within

[Bug 1512120]

2018-06-08 Thread Slumbergod-n
Perhaps it is time to fund a dedicated, professional software engineer to fix this once and for all. It's clear that parts of the code base need a complete rewrite and at the moment it feels like the patches are only mitigating the symptoms rather than addressing the real cause. Maybe this is

[Bug 1512120]

2018-06-08 Thread Slumbergod-n
@Roy, when you were testing did you also try to trigger a desktop crash? Most times when I use Extract Here from the right click context menu on the desktop, it extracts the archive but when the temporary directory is renamed > DESKTOP CRASH! Did it yesterday when I extracted the latest firefox

[Bug 1512120]

2018-06-08 Thread John Lindgren
(In reply to Emil Mikulic from comment #41) > The attached diff increments the refcount before creating the deferred > reload, then decrements it after the reload runs. I haven't been able to > repro the crash since. I pushed a slightly simplified version of this patch to my fork:

[Bug 1512120]

2018-06-08 Thread Rocketx86
(In reply to Roy Richardson from comment #71) > After quite a bit of debugging and testing I have produced the following > rename patch for Thunar. > > --- Thunar-1.6.10/thunar/thunar-io-jobs.c 2015-05-22 13:25:36.0 > + > +++ Thunar-1.6.10-fix/thunar/thunar-io-jobs.c 2016-08-01

[Bug 36812]

2018-06-08 Thread Wettstae
Created attachment 131147 Proposed extension of the XKB protocol. > Therefore, my proposal for you (or anyone else who is interested in changing > the behavior) is to provide a patch against the spec. That is a very good proposal. The patch formalises my proposal from comment #112. An

[Bug 1512120]

2018-06-08 Thread Yanpas
Thunar crash has happened to me when I was moving file from one folder to another. I've dragged a file from file-list and dropped to the side panel's bookmark and thunar has crashed. I guess it's the same issue cause moving and renaming is almost the same thing -- You received this bug

[Bug 1512120]

2018-06-08 Thread Rocketx86
(In reply to Roy Richardson from comment #76) > I'm suspicious of the following code fragment in thunar_folder_monitor which > I have now bypassed on "file monitor move" events with the above patch. > > /* tell others about the new file */ > list.data = file; list.next = list.prev =

[Bug 1512120]

2018-06-08 Thread Main-haarp
At this point it almost seems less work to strip everything remotely related to renaming and rewrite it. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: [SRU] thunar crashes on file

[Bug 1512120]

2018-06-08 Thread Rocketx86
After quite a bit of debugging and testing I have produced the following rename patch for Thunar. --- Thunar-1.6.10/thunar/thunar-io-jobs.c 2015-05-22 13:25:36.0 + +++ Thunar-1.6.10-fix/thunar/thunar-io-jobs.c 2016-08-01 11:07:09.01668 + @@ -1307,7 +1307,12 @@ {

[Bug 1512120]

2018-06-08 Thread Kip Warner
(In reply to Roy Richardson from comment #77) > This patch will keep thunar_file_compare_by_name() from crashing when the > collate keys are NULL. When using this patch, users may notice a random > occurance of 2 files appearing selected together with the same name. The > cause of this random

[Bug 1512120]

2018-06-08 Thread Ketetefid
*** Bug 12706 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512120 Title: [SRU] thunar crashes on file renaming To manage notifications about this

[Bug 1512120]

2018-06-08 Thread Kip Warner
(In reply to Roy Richardson from comment #72) > Unfortunately, further testing reveals that I am still able to crash Thunar. Man, this is quite elusive! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1512120]

2018-06-08 Thread Slumbergod-n
If anyone compiles a thunar binary compatible with xubuntu 16.04 I am happy to test it. I'd be happy to compile it myself but the last time I tried I made a mess of my system because the instructions I found for compiling it weren't accurate enough. But I am happy to help test binaries :) --

[Bug 1512120]

2018-06-08 Thread Rocketx86
@slumbergod I have never triggered an desktop crash, but I have seen a numerous seg faults from various types of move or rename operations. @Kip This bug is definately elusive and has traits of a stack corruption. With debugging symbols enabled and NDEBUG defined to bypass the debugging

[Bug 1512120]

2018-06-08 Thread Rocketx86
(In reply to Jan Havran from comment #0) > thunar_file_compare_by_name() function is called even for only one file in > working directory - both file_a->collate_key_nocase and > file_b->collate_key_nocase are NULL. I noticed that sometimes this function > is not called, but when it is (it is

[Bug 1512120]

2018-06-08 Thread Yanpas
You may write stack trace to the file on SIGSEGV https://stackoverflow.com/questions/77005/how-to-generate-a-stacktrace- when-my-gcc-c-app-crashes and then via objdump -d find line in assembler where app gets sigsegv (I guess it crashes due to sigsegv) -- You received this bug notification

[Bug 1512120]

2018-06-08 Thread B-frank-r
This bug definitely seems to be related to race conditions as has been suggested before. You can do the test by hitting F2, entering an new name immediately followed by [ENTER]. Thunar is likely to crash. The same happens when you click OK too fast after entering a new name (put the mouse cursor

<    1   2   3   4   5   6   7   8   9   >