[uml-devel] Re: [PATCH 4/9] UML - Export gcov symbol based on gcc version

2005-03-11 Thread Jeff Dike
[EMAIL PROTECTED] said: > No, my claim is that no sane gcc 3.3 defines __gcov_init. Ah, OK. Thanks for the clarification. Jeff --- SF email is sponsored by - The IT Product Guide Read honest & candid reviews

[uml-devel] Re: [PATCH 4/9] UML - Export gcov symbol based on gcc version

2005-03-11 Thread Adrian Bunk
On Fri, Mar 11, 2005 at 06:53:15PM -0500, Jeff Dike wrote: > [EMAIL PROTECTED] said: > > And therefore you added a patch that helps only those distros at the > > price of breaking other people and distros using sane compilers? > > Didn't you start this thread by pointing out that SuSE has a gcc 3

[uml-devel] Re: [PATCH 4/9] UML - Export gcov symbol based on gcc version

2005-03-11 Thread Jeff Dike
[EMAIL PROTECTED] said: > And therefore you added a patch that helps only those distros at the > price of breaking other people and distros using sane compilers? Didn't you start this thread by pointing out that SuSE has a gcc 3.3.4 which isn't? I would call that a compiler which lies about its

Re: [uml-devel] Re: [PATCH 4/9] UML - Export gcov symbol based on gcc version

2005-03-11 Thread Blaisorblade
On Friday 11 March 2005 00:21, Linus Torvalds wrote: > On Thu, 10 Mar 2005, Adrian Bunk wrote: > > This patch is still wrong. > > Can't we just fix it by havign an alias for both names? No, because the patch is wrong. It should export both symbols in the second case. > It seems stupid to > jump t

Re: [uml-devel] Re: [PATCH 4/9] UML - Export gcov symbol based on gcc version

2005-03-11 Thread Blaisorblade
On Thursday 10 March 2005 23:53, Adrian Bunk wrote: > On Wed, Mar 09, 2005 at 09:16:02PM -0500, Jeff Dike wrote: > > The init function called by gcc when gcov is enabled is __gcov_init or > > __bb_init_func, depending on the gcc version. Anton is using 3.3.4 and > > seeing __gcov_init. I'm using

Re: [uml-devel] Re: [PATCH 4/9] UML - Export gcov symbol based on gcc version

2005-03-11 Thread stian
>> > ( (__GNUC__ == 3 && __GNUC_MINOR__ == 3 && __GNUC_PATCHLEVEL__ >= 4) >> > && \ >> >HEAVILY_PATCHED_SUSE_GCC ) >> > I hope SuSE has added some #define to distinguish what they call "gcc >> > 3.3.4" from GNU gcc 3.3.4 >> It wasn't lost - I am just disinclined to cater to distros making thei

[uml-devel] Re: [PATCH 4/9] UML - Export gcov symbol based on gcc version

2005-03-11 Thread Adrian Bunk
On Fri, Mar 11, 2005 at 01:48:54PM -0500, Jeff Dike wrote: > [EMAIL PROTECTED] said: > > This patch is still wrong. > > It seems my comment on this [1] was lost: > > <-- snip --> > > This line has to be something like > > ( (__GNUC__ == 3 && __GNUC_MINOR__ == 3 && __GNUC_PATCHLEVEL__ >= 4) > > &&

[uml-devel] Re: [PATCH 4/9] UML - Export gcov symbol based on gcc version

2005-03-11 Thread Jeff Dike
[EMAIL PROTECTED] said: > This patch is still wrong. > It seems my comment on this [1] was lost: > <-- snip --> > This line has to be something like > ( (__GNUC__ == 3 && __GNUC_MINOR__ == 3 && __GNUC_PATCHLEVEL__ >= 4) > && \ >HEAVILY_PATCHED_SUSE_GCC ) > I hope SuSE has added some #define

[uml-devel] Re: [PATCH 4/9] UML - Export gcov symbol based on gcc version

2005-03-11 Thread Jeff Dike
[EMAIL PROTECTED] said: > Can't we just fix it by havign an alias for both names? It seems > stupid to jump through hoops and worry about compiler versions, when > afaik we could just do something like > extern (...) __attribute__((alias(""))); > instead. Exact details left to the

[uml-devel] Re: [PATCH 4/9] UML - Export gcov symbol based on gcc version

2005-03-10 Thread Linus Torvalds
On Thu, 10 Mar 2005, Adrian Bunk wrote: > > This patch is still wrong. Can't we just fix it by havign an alias for both names? It seems stupid to jump through hoops and worry about compiler versions, when afaik we could just do something like extern (...) __attribute__((alias("yy

[uml-devel] Re: [PATCH 4/9] UML - Export gcov symbol based on gcc version

2005-03-10 Thread Adrian Bunk
On Wed, Mar 09, 2005 at 09:16:02PM -0500, Jeff Dike wrote: > The init function called by gcc when gcov is enabled is __gcov_init or > __bb_init_func, depending on the gcc version. Anton is using 3.3.4 and > seeing __gcov_init. I'm using 3.3.2 and seeing __bb_init_func, so we need > to close that