Re: escaping single quote for Exec Maven Plugin `exc.args`

2023-10-14 Thread Alexander Kriegisch
It seems as if today is not my day. First, I wrote a message in another thread with tons of typos, making it look as if I am not just bad in typing but actually unable to speak proper English. Now, I sent an incomplete message not addressing the actual question. Sorry for that to everyone. Let

Re: escaping single quote for Exec Maven Plugin `exc.args`

2023-10-14 Thread Alexander Kriegisch
Escape hell, part 3: Powershell. Similar to Cmd.exe, but additionally, you need to use '--%' right after the 'mvn' command to stop PS from parsing the parameters any further as PS commands or whatever. The full command would be something like (my local testing example: mvn --% -pl some-app

Re: Feedback sought

2023-10-14 Thread Joseph Kesselman
... And I committed my own typo; it should of course have been "moving forward with", not living. Darned auto-correct; I really need to learn to proofread more carefully when typing on the phone. -- /_ Joe Kesselman (he/him/his) -/ _) My Alexa skill for New Music/New Sounds fans: /

Re: Feedback sought

2023-10-14 Thread Joseph Kesselman
Don't worry, we recognized your intent. I do appreciate the feedback I'm getting. I asked for it, and hopefully the parts that don't make sense to apply right now will be useful in the future. But, yes, let's focus on whether what I've done is worth living forward with rather than the details

Re: Feedback sought

2023-10-14 Thread Mark Derricutt
Tangential topic - a while ago there was a thread/discussion about adopting something like spotless/palantir-java-format for automated formatting. Whilst a massive change to the code base, which can (potentially) cause horrors for open branches/PRs unless rebased with care and also

Feedback sought

2023-10-14 Thread Joseph Kessselman
I've just issued a pull request proposing that the Apache Xalan-Java project cut over from Ant-based to Maven-based build. This is the first time I'm working with Maven, and I'm *sure* I have done things that are bad form. If anyone has time and energy to glance at it and sanity-check that I

escaping single quote for Exec Maven Plugin `exc.args`

2023-10-14 Thread Garret Wilson
Here's a fun one for your weekend. As you know from (almost) the beginning of time we could invoke a Java application using Maven using the Maven Exec Plugin, as in the following (although Maven's `--quiet` may be a recent addition): ```bash mvn exec:java

Re: Feedback sought

2023-10-14 Thread Greg Chabala
That's certainly an ambitious changeset, but it takes courage to do great work. I'd generally suggest trying to make smaller steps so it's easier on reviewers. For instance: - Could you make a basic Maven build that delegated most of the work to Ant with maven-antrun-plugin? - If so,

Re: Feedback sought

2023-10-14 Thread Joseph Kesselman
There didn't seem to be a good intermediate point. Maven wanted things organized differently, and I didn't know Maven well enough to argue with it. Switching from private binaries to Maven packages was a driving force behind the cut-over, and the need to move from jlec to jflex forced the one

Re: Feedback sought

2023-10-14 Thread Joseph Kesselman
Re "IDE droppings"... My experience is that they can actually be useful in expressing things like preferred code formatting style in importable/executable form. (I'd rather have a standard cross-editor way if representing that, but I don't know of one.) But I don't care that strongly; if

Re: Feedback sought

2023-10-14 Thread Joseph Kesselman
Taking out the META-INF: I'll look at that. NOTE that as long as this is basically an acceptable framework to replace the And build, and produces correct code, quibbles like editor configurations and unnecessary files can be cleaned up in subsequent edits; they shouldn't be considered blockers

Re: Feedback sought

2023-10-14 Thread Greg Chabala
On Sat, Oct 14, 2023 at 9:15 PM Joseph Kesselman wrote: > Taking out the META-INF: I'll look at that. ... quibbles like editor > configurations and unnecessary files can be cleaned up in subsequent edits; > they shouldn't be considered blockers now. > Sure. Just an opportunity to remove files

Re: Feedback sought

2023-10-14 Thread Alexander Kriegisch
I have not even looked at the changeset yet, since last time I tried to help with the taglet problem in the javadoc plugin. I was just following the conversation a bit and want to drop a few general comments about contributions and reviews in the OSS world: If any of us ends up in the role of a

Re: Feedback sought

2023-10-14 Thread Alexander Kriegisch
Alexander Kriegisch schrieb am 15.10.2023 10:36 (GMT +07:00): > -- Let us abuse reviews as a tool to micro-manage the contributor to OMG, of course I meant "let us NOT abuse". > change what we would have done differently, until it looks exactly > like a change we

Re: escaping single quote for Exec Maven Plugin `exc.args`

2023-10-14 Thread Alexander Kriegisch
Java CLI program arguments containing spaces are usually enclosed by double quotes, so I would recommend to use: -Dexec.args="one 'number two' three" This works in both UNIX-like shells (say, Git Bash on Windows) and in the Cmd.exe Windows shell, while -Dexec.args='one "number two" three'