Re: RewriteValve does not work on HTTPS

2020-02-14 Thread Hua Zhang
Thank you for the information and fix, Mark. On Fri, Feb 7, 2020 at 12:31 AM Mark Thomas wrote: > On 06/02/2020 23:00, Mark Thomas wrote: > > The issue appears to be that the following RewriteCond does not match > > when the request is served over HTTP/2 (with TLS) but it does if the > > request

Re: RewriteValve does not work on HTTPS

2020-02-06 Thread Mark Thomas
On 06/02/2020 23:00, Mark Thomas wrote: > The issue appears to be that the following RewriteCond does not match > when the request is served over HTTP/2 (with TLS) but it does if the > request is served over HTTP/1.1 with TLS. > > RewriteCond %{HTTP_HOST} localhost > > (Note the RewriteCond quote

Re: RewriteValve does not work on HTTPS

2020-02-06 Thread Mark Thomas
The issue appears to be that the following RewriteCond does not match when the request is served over HTTP/2 (with TLS) but it does if the request is served over HTTP/1.1 with TLS. RewriteCond %{HTTP_HOST} localhost (Note the RewriteCond quoted at the start of this thread is invalid) I'm wonderi

Re: RewriteValve does not work on HTTPS

2020-02-06 Thread Pierre Chiu
I just want to concur I have the same issue. Removing that one line upgradeprotocol and rewrite works again. On Thu, Feb 6, 2020 at 3:28 PM Hua Zhang wrote: > Nope, I also tested it with NIO instead of APR, same issues happen. > RewriteValve does not function as expected. Besides it, there are

Re: RewriteValve does not work on HTTPS

2020-02-06 Thread Hua Zhang
Nope, I also tested it with NIO instead of APR, same issues happen. RewriteValve does not function as expected. Besides it, there are also two https-443-exec executed by one request. There is definitely something wrong with Http2Protocol. And it results in this case a problem in RewriteValve. And

Re: RewriteValve does not work on HTTPS

2020-02-06 Thread Rémy Maucherat
On Thu, Feb 6, 2020 at 2:56 PM Hua Zhang wrote: > Thank you for the response. I am finally able to confirm the issue. > > When I put the following line in comment, everything works fine. I mean as > expected. > > ** > > > If the above line UpgradeProtocol is activated, I observe now at least two

Re: RewriteValve does not work on HTTPS

2020-02-06 Thread Hua Zhang
Thank you for the response. I am finally able to confirm the issue. When I put the following line in comment, everything works fine. I mean as expected. ** If the above line UpgradeProtocol is activated, I observe now at least two weird situations. 1) As mentioned before, RewriteValve does not

Re: RewriteValve does not work on HTTPS

2020-02-05 Thread Felix Schumacher
Am 04.02.2020 22:16, schrieb Hua Zhang: What I mean with word 'works' is: the RewriteRule has been executed. That is not the case by HTTPS. The rule has not been executed while the RewriteCond is fulfilled. Can you give us more information on your setup? Is there any Proxy/Loadbalancer in fro

Re: RewriteValve does not work on HTTPS

2020-02-04 Thread Hua Zhang
What I mean with word 'works' is: the RewriteRule has been executed. That is not the case by HTTPS. The rule has not been executed while the RewriteCond is fulfilled. Olaf Kock 于 2020年2月4日周二 下午9:06写道: > > On 04.02.20 20:31, Hua Zhang wrote: > > Best tomcat team, > > > > Hereby I have a question

Re: RewriteValve does not work on HTTPS

2020-02-04 Thread Olaf Kock
On 04.02.20 20:31, Hua Zhang wrote: > Best tomcat team, > > Hereby I have a question about an issue I found by using RewriteValve > on tomcat 9.30 > > The rewrite.config is very simple: > > /RewriteCond %{HTTP_HOST} =youkoop.com > RewriteRule ^.*$ https://www.youkoop.com [R=30

RewriteValve does not work on HTTPS

2020-02-04 Thread Hua Zhang
Best tomcat team, Hereby I have a question about an issue I found by using RewriteValve on tomcat 9.30 The rewrite.config is very simple: *RewriteCond %{HTTP_HOST} =youkoop.com RewriteRule ^.*$ https://www.youkoop.com [R=301,L]* All I want is just