>> I'm looking at the tests in the patch and I see things like:
>>
>> +
>> + //assertEquals("InlineEnclosure has traversed page x
>> times ", new
>> Integer(1), new
>> Integer(InlineEnclosure.inlineEnclosureTraversalCounter));
>> + //
>> InlineEnclosure.CALC
> I'm looking at the tests in the patch and I see things like:
>
> +
> + //assertEquals("InlineEnclosure has traversed page x times ",
> new
> Integer(1), new
> Integer(InlineEnclosure.inlineEnclosureTraversalCounter));
> + //
> InlineEnclosure.CALCULATE_I
On Sun, Sep 2, 2012 at 1:20 PM, Martin Makundi
wrote:
> Hi!
>
Wicket 1.4.x is frozen. Only security bug fixes can be committed.
1.4.21 is being voted and the vote ends tomorrow.
>>>
>>> This would be a good opportunity to get widespread experience of this
>>> bugfix, it will benefit also
Hi!
>>> Wicket 1.4.x is frozen. Only security bug fixes can be committed.
>>> 1.4.21 is being voted and the vote ends tomorrow.
>>
>> This would be a good opportunity to get widespread experience of this
>> bugfix, it will benefit also later versions.
>
> There is a chance to break something else
On Sun, Sep 2, 2012 at 1:03 PM, Martin Makundi
wrote:
> Hi!
>
>> Wicket 1.4.x is frozen. Only security bug fixes can be committed.
>> 1.4.21 is being voted and the vote ends tomorrow.
>
> This would be a good opportunity to get widespread experience of this
> bugfix, it will benefit also later ver
Hi!
> Wicket 1.4.x is frozen. Only security bug fixes can be committed.
> 1.4.21 is being voted and the vote ends tomorrow.
This would be a good opportunity to get widespread experience of this
bugfix, it will benefit also later versions.
> About the patch - I still don't like the leak that it a
Wicket 1.4.x is frozen. Only security bug fixes can be committed.
1.4.21 is being voted and the vote ends tomorrow.
About the patch - I still don't like the leak that it adds -
o.a.w.Component will know about InlineEnclosure (a specialization of
Component).
Why you don't like the workaround with
I propose that because this is a bugfix
(https://issues.apache.org/jira/browse/WICKET-3947) with thorough
junit tests, it should be added to 1.4.x
**
Martin
2012/8/21 Veikko Törmänen :
> Thank you for the information.
>
> I had missed the correct patch protocol and wasn't aware that the 1.4.x was
