On Sun, Sep 2, 2012 at 1:03 PM, Martin Makundi <[email protected]> wrote: > Hi! > >> Wicket 1.4.x is frozen. Only security bug fixes can be committed. >> 1.4.21 is being voted and the vote ends tomorrow. > > This would be a good opportunity to get widespread experience of this > bugfix, it will benefit also later versions.
There is a chance to break something else ... The risk is big. > >> About the patch - I still don't like the leak that it adds - >> o.a.w.Component will know about InlineEnclosure (a specialization of >> Component). > > We didn't find a way to do this in the current wicket architecture, > it's simply does not support autocomponents well enough. We know that. We will think how this can be improved for Wicket 7. In Wicket 1.5 there is EnclosureContainer which can be used as a replacement of (Inline)Enclosure. The difference is that it is not an auto component. > >> Why you don't like the workaround with the simple WebMarkupContainer >> as a parent of InlineEnclosure ? > > Well that was the original boilerplate code we wanted to get rid of in > first place. Ofcourse everything can be done the hard way but built in > support for such basic functionality is beneficial. I suggest you to spend some time to upgrade to 1.5.8 or 6.0.0. These are the versions we also use in production and it will be easy to catch any problems when applying patches by users. > > ** > Martin > > >> >> On Sun, Sep 2, 2012 at 12:53 PM, Martin Makundi >> <[email protected]> wrote: >>> I propose that because this is a bugfix >>> (https://issues.apache.org/jira/browse/WICKET-3947) with thorough >>> junit tests, it should be added to 1.4.x >>> >>> ** >>> Martin >>> >>> 2012/8/21 Veikko Törmänen <[email protected]>: >>>> Thank you for the information. >>>> >>>> I had missed the correct patch protocol and wasn't aware that the 1.4.x was >>>> frozen. >>>> >>>> Apologies. >>>> >>>> >>>> >>>> -- >>>> View this message in context: >>>> http://apache-wicket.1842946.n4.nabble.com/Fix-for-WICKET-3947-and-WICKET-4700-tp4651386p4651395.html >>>> Sent from the Users forum mailing list archive at Nabble.com. >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [email protected] >>>> For additional commands, e-mail: [email protected] >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >> >> >> >> -- >> Martin Grigorov >> jWeekend >> Training, Consulting, Development >> http://jWeekend.com >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
