RE: Is it a bug that Enclosure is not invoking component resolver to resolve its children?

2009-09-20 Thread Chris Colman
as far as i rememember there is a collection registered in setttings and then each component can also implement a resolver. the contract can be seen in markupcontainer#rendernext method 1) first walk over the component hierarchy and check if any are resolvers 2) walk over collection

RE: Is it a bug that Enclosure is not invoking component resolver to resolve its children?

2009-09-20 Thread Chris Colman
as far as i rememember there is a collection registered in setttings and then each component can also implement a resolver. the contract can be seen in markupcontainer#rendernext method 1) first walk over the component hierarchy and check if any are resolvers 2) walk over

Re: Is it a bug that Enclosure is not invoking component resolver to resolve its children?

2009-09-19 Thread Igor Vaynberg
to resolve the wicket:enclosure tag itself. the tag handler will assign a wicket:id to the wicket:enclosure tag. the component resolver then has to resolve that wicket:id to a component. -igor On Fri, Sep 18, 2009 at 8:35 PM, Chris Colman chr...@stepaheadsoftware.com wrote: to make the

RE: Is it a bug that Enclosure is not invoking component resolver to resolve its children?

2009-09-19 Thread Chris Colman
to resolve the wicket:enclosure tag itself. the tag handler will assign a wicket:id to the wicket:enclosure tag. the component resolver then has to resolve that wicket:id to a component. Ah, ok. At first it seemed strange to need an EnclosureResolver when wicket already knew that it was an

RE: Is it a bug that Enclosure is not invoking component resolver to resolve its children?

2009-09-19 Thread Chris Colman
this contract is not factored out anywhere, but maybe doing so may be worthwhile. can be part of your patch, something like ComponentResolvers.resolve(MarkupContainer parent, ) Yes looks like this code in MarkupContainer.renderNext would need to be factored out: // 3rd try: Try

RE: Is it a bug that Enclosure is not invoking component resolver to resolve its children?

2009-09-19 Thread Chris Colman
this contract is not factored out anywhere, but maybe doing so may be worthwhile. can be part of your patch, something like ComponentResolvers.resolve(MarkupContainer parent, ) I've tried invoking the application resolvers from many different places within the Enclosure class but

Re: Is it a bug that Enclosure is not invoking component resolver to resolve its children?

2009-09-18 Thread Igor Vaynberg
you are welcome to provide a patch. -igor On Thu, Sep 17, 2009 at 1:57 PM, Chris Colman chr...@stepaheadsoftware.com wrote: As can be seen by the Enclosure.getChildComponent method below the component resolver expects to find the 'child' within its own parent - i.e. it assumes that its

RE: Is it a bug that Enclosure is not invoking component resolver to resolve its children?

2009-09-18 Thread Chris Colman
you are welcome to provide a patch. -igor I would if I could get it working ;). At what point in the lifecycle of normal parent should the component resolver be invoked to instantiate the children? And... is there a convention for calling the component resolvers? There's obviously a

Re: Is it a bug that Enclosure is not invoking component resolver to resolve its children?

2009-09-18 Thread Igor Vaynberg
On Fri, Sep 18, 2009 at 3:02 PM, Chris Colman chr...@stepaheadsoftware.com wrote: you are welcome to provide a patch. -igor I would if I could get it working ;). At what point in the lifecycle of normal parent should the component resolver be invoked to instantiate the children? this

RE: Is it a bug that Enclosure is not invoking component resolver to resolve its children?

2009-09-18 Thread Chris Colman
At what point in the lifecycle of normal parent should the component resolver be invoked to instantiate the children? this happens during render time when wicket is trying to match up markup to a component I'm wondering if Enclosure, with its need to obtain knowledge of its 'child' (which

Re: Is it a bug that Enclosure is not invoking component resolver to resolve its children?

2009-09-18 Thread Igor Vaynberg
to make the component a direct child of enclosure you would have to have an Enclosure component that is explicitly added into the hierarchy, at which point you can simply use a WebMarkupContainer whose visibility is tied to that of the child to replicate the functionality. the whole point of

RE: Is it a bug that Enclosure is not invoking component resolver to resolve its children?

2009-09-18 Thread Chris Colman
to make the component a direct child of enclosure you would have to have an Enclosure component that is explicitly added into the hierarchy, at which point you can simply use a WebMarkupContainer whose visibility is tied to that of the child to replicate the functionality. the whole point of

Is it a bug that Enclosure is not invoking component resolver to resolve its children?

2009-09-17 Thread Chris Colman
As can be seen by the Enclosure.getChildComponent method below the component resolver expects to find the 'child' within its own parent - i.e. it assumes that its *child* is actually its sibling via: child = parent.get(childId.toString()); While all other children of the common parent are