RE: Re: Re: Re: Re: Inconsistent dependency resolution behaviour for concurrent multi-module build can cause failures

2024-02-28 Thread Joseph Leonard
Hi Tamás, Is there an Maven issue out there to track this issue (and your fix for it)? I haven’t been able to get access to the Maven Jira project so have not been able to raise the issue myself. Thanks, Joe On 2024/02/08 10:09:31 Tamás Cservenák wrote: > Seems we are on track with this. To

RE: Re: Re: Re: Re: Re: Inconsistent dependency resolution behaviour for concurrent multi-module build can cause failures

2024-02-08 Thread Joseph Leonard
Hey, Yeah, exactly: ideally we want module-b to be resolved in different ways within the same reactor. I noticed that this kind of already happens (albeit in a simpler way): In my reproducer testing if you play with the test timeouts to dictate the module build order then with the same modules

Re: Re: Re: Re: Re: Re: Inconsistent dependency resolution behaviour for concurrent multi-module build can cause failures

2024-02-08 Thread Tamás Cservenák
Howdy, Well, sadly, Maven currently has no means to make one module "this and that" at the same time. It is either in the reactor or is out of it. To me, it sounds like you want one reactor, but where module-b is "out" and 'in", at the same time (within same session) T On Thu, Feb 8, 2024 at

RE: Re: Re: Re: Re: Re: Inconsistent dependency resolution behaviour for concurrent multi-module build can cause failures

2024-02-08 Thread Joseph Leonard
Hey, We don't need the module-b jar built in the reactor to be included in the war if the changes made in module-b won't affect the war. Instead, in this scenario, we're fine with using a jar resolved from the local repository. The requisites for this scenario are: * Any change made to

Re: Re: Re: Re: Re: Inconsistent dependency resolution behaviour for concurrent multi-module build can cause failures

2024-02-08 Thread Tamás Cservenák
Hej, yes, basically the "hack" is well described by you: - it retains "full' reactor project - introduces "needs build" on project - when it comes to building, it skips the project if flag set This results that module-b -> app link is not lost. And as for your parallelization request: the truth

RE: Re: Re: Re: Re: Inconsistent dependency resolution behaviour for concurrent multi-module build can cause failures

2024-02-08 Thread Joseph Leonard
Hi Tamás, Thank you for hacking around this so rapidly. I am not familiar with the maven code base, so let me know if I have misinterpreted the change: Is your hack to: 1. Retain the full multi-module build dependency graph such that the build graph always remains consistent regardless of

Re: Re: Re: Re: Inconsistent dependency resolution behaviour for concurrent multi-module build can cause failures

2024-02-08 Thread Tamás Cservenák
Seems we are on track with this. To prove my last-night theory I created a "hack" (is really just that) and guess what? It makes reproducer behave "as expected": https://github.com/apache/maven/pull/1406 T On Wed, Feb 7, 2024 at 10:05 PM Tamás Cservenák wrote: > Howdy, > > Thank you very much,

Re: Re: Re: Re: Inconsistent dependency resolution behaviour for concurrent multi-module build can cause failures

2024-02-07 Thread Tamás Cservenák
Howdy, Thank you very much, the reproducer works. Did not dig thru it fully, but here are some related issues: https://issues.apache.org/jira/browse/MNG-8028 (funny thing, I created this few weeks ago) https://issues.apache.org/jira/browse/MNG-6300 Will report back tomorrow (EU TZ) T On Wed,

RE: Re: Re: Re: Inconsistent dependency resolution behaviour for concurrent multi-module build can cause failures

2024-02-07 Thread Joseph Leonard
Hi Tamás, I have created a simple example here: https://github.com/josple/mvn-multibuild-issue Hopefully the README is clear enough – let me know if I can clarify anything. Thanks, Joe On 2024/02/07 17:33:08 Tamás Cservenák wrote: > Howdy, > > In that case, there is something fishy with the

Re: Re: Re: Inconsistent dependency resolution behaviour for concurrent multi-module build can cause failures

2024-02-07 Thread Tamás Cservenák
Howdy, In that case, there is something fishy with the project, my blind guess would be some "hidden" inter-module dependency maybe? Can you provide access to source, or, if not feasible, could you provide some reproducer and publish it on Github/Gitlab/whatever (maybe even just send it

RE: Re: Re: Inconsistent dependency resolution behaviour for concurrent multi-module build can cause failures

2024-02-07 Thread Joseph Leonard
Hi Tamás, We have previously played around a bit with mvnd but not takari directly – I will have a play with it. With regards to this issue, using the takari smart builder unfortunately doesn’t resolve the issue. Joe On 2024/02/07 11:41:22 Tamás Cservenák wrote: > Can you please try smart

RE: Re: Inconsistent dependency resolution behaviour for concurrent multi-module build can cause failures

2024-02-07 Thread Joseph Leonard
Hi Nils, Ah I see. We actually already use ‘-pl …’ arguments in conjunction with the Develocity Build Cache implementation because we have found this to still generate very significant time savings. Primarily because even with hits on the build cache there is still fairly substantial time spent

Re: Re: Inconsistent dependency resolution behaviour for concurrent multi-module build can cause failures

2024-02-07 Thread Tamás Cservenák
Howdy, see here https://maven.apache.org/mailing-lists.html On Wed, Feb 7, 2024 at 12:55 PM Amn Ojee Uw wrote: > How can I unsubscribe from this mailing list? > Thanks in advance. > > *ArbolOne > Using Fire Fox and Thunderbird. > Developing for Android using Java, C/C++, HTM/CSS and SQLite as

Re: Re: Inconsistent dependency resolution behaviour for concurrent multi-module build can cause failures

2024-02-07 Thread Amn Ojee Uw
How can I unsubscribe from this mailing list? Thanks in advance. *ArbolOne Using Fire Fox and Thunderbird. Developing for Android using Java, C/C++, HTM/CSS and SQLite as our platform has been exciting and most rewarding. [ Ñ ]* On Wed, Feb 7, 2024 at 5:50 AM Joseph Leonard <

Re: Re: Inconsistent dependency resolution behaviour for concurrent multi-module build can cause failures

2024-02-07 Thread Tamás Cservenák
Can you please try smart builder instead? https://github.com/takari/takari-smart-builder (note: smart builder is used by mvnd as well) The difference between the two can be seen here: http://takari.io/book/30-team-maven.html#takari-smart-builder On Wed, Feb 7, 2024 at 11:50 AM Joseph Leonard <

RE: Re: Inconsistent dependency resolution behaviour for concurrent multi-module build can cause failures

2024-02-07 Thread Joseph Leonard
Hi Tamás, Yeah, this was unexpected to me initially as well. From what I can tell the Maven reactor only considers direct dependencies (i.e. not transitive dependencies) between the modules in the reactor when working out the build graph. For example if you have a simple linear dependency chain

RE: Re: Inconsistent dependency resolution behaviour for concurrent multi-module build can cause failures

2024-02-06 Thread Joseph Leonard
Thanks Nils, maven-build-cache-extension looks very interesting generally – I will have a play with it. With regards to this issue, the maven-build-cache-extension overview references “Subtree support for multimodule projects builds part of the codebase in isolation” which sounded similar to