Re: FeedbackPanel Empty on Wizard in 6.5
FYI, I couldn't resolve the issue. I had a couple of places with ListView and i made sure setReuseItems was (true) but that didn't resolve the issue. I tried removing various panels to track down the issue, but still nothing. However when i removed the .setRequired on some textboxes the form then processed and i was already throwing exceptions for invalid data, then catching exceptions and calling Error(exception.getmessage) -- Note calling error() at this point worked without referring to the sesssion as long as the form/submit was called. So i just updated the exceptions to check for null values in the model and set the error feedback that way. Fergal. On 25 March 2013 13:13, Martin Grigorov mgrigo...@apache.org wrote: Hi, Do you use ListView somewhere in the hierarchy by chance ? I remember a similar issue - the component with the feedback message was in a ListView with .setReuseItems(false). Changing it to .setReuseItems(true) fixed the problem. On Mon, Mar 25, 2013 at 3:06 PM, Fergal Keating fergal.keat...@directski.com wrote: The MywizardPage is being used as the Root component and its set in the FeedbackCollector constructor. So it should be a parent of all components under it. Adding session.error to my FinishButton#OnError get the feedback panel displayed correctly with that one message, however i'm relying on component#setRequired for some of my error messages. so i need to get to the bottom of the issue. I added a check in the feedbackPanel to findParent(MywizardPage.class) and its returning correctly... On 25 March 2013 09:45, Martin Grigorov mgrigo...@apache.org wrote: Hi, Check which component is used as root in FeedbackCollector. Is it the page or some other component which is not parent of the component on which you call .error() method ? As a workaround you can use session.error() instead but I think it will be better if you understand why the component-scoped feedback message is not used. On Mon, Mar 25, 2013 at 11:17 AM, Fergal Keating fergal.keat...@directski.com wrote: Hi, I'm using a wizard page on which there is some feedback panels. On the last step, (since i upgraded to version 6.5 wicket) the feedback messages are not displaying. (they are working fine on other steps). I can correctly see each component in the form adding its own error message.The FinishButton#On Error is being called because there are errors detectcted, but they seem to be cleared by the time i have to display the feedback panel. I have even called error() from the overwritten FinishButton#On Error method and it seems to disappear. I have placed Debug on orw.feedback class which shows that my feedback messages are being added. but when the feedback Collector Class gets called to display the feedback messages they somehow seem to have disappeared. The feedback panel is set to visible, and its onBeforeRender is being called, but messages arent displayed. I've tried to see where the messages are being cleared, but it just seem that the FeedbackMessages#clear methods only being called on Detach. can someone advise ? -- Fergal Keating IT Senior Engineer --- e. fergal.keat...@directski.com p. NA w. www.directski.com -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com http://jweekend.com/ -- Fergal Keating IT Senior Engineer --- e. fergal.keat...@directski.com p. NA w. www.directski.com -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com http://jweekend.com/ -- Fergal Keating IT Senior Engineer --- e. fergal.keat...@directski.com p. NA w. www.directski.com
Re: FeedbackPanel Empty on Wizard in 6.5
Hi, Check which component is used as root in FeedbackCollector. Is it the page or some other component which is not parent of the component on which you call .error() method ? As a workaround you can use session.error() instead but I think it will be better if you understand why the component-scoped feedback message is not used. On Mon, Mar 25, 2013 at 11:17 AM, Fergal Keating fergal.keat...@directski.com wrote: Hi, I'm using a wizard page on which there is some feedback panels. On the last step, (since i upgraded to version 6.5 wicket) the feedback messages are not displaying. (they are working fine on other steps). I can correctly see each component in the form adding its own error message.The FinishButton#On Error is being called because there are errors detectcted, but they seem to be cleared by the time i have to display the feedback panel. I have even called error() from the overwritten FinishButton#On Error method and it seems to disappear. I have placed Debug on orw.feedback class which shows that my feedback messages are being added. but when the feedback Collector Class gets called to display the feedback messages they somehow seem to have disappeared. The feedback panel is set to visible, and its onBeforeRender is being called, but messages arent displayed. I've tried to see where the messages are being cleared, but it just seem that the FeedbackMessages#clear methods only being called on Detach. can someone advise ? -- Fergal Keating IT Senior Engineer --- e. fergal.keat...@directski.com p. NA w. www.directski.com -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com http://jweekend.com/
Re: FeedbackPanel Empty on Wizard in 6.5
The MywizardPage is being used as the Root component and its set in the FeedbackCollector constructor. So it should be a parent of all components under it. Adding session.error to my FinishButton#OnError get the feedback panel displayed correctly with that one message, however i'm relying on component#setRequired for some of my error messages. so i need to get to the bottom of the issue. I added a check in the feedbackPanel to findParent(MywizardPage.class) and its returning correctly... On 25 March 2013 09:45, Martin Grigorov mgrigo...@apache.org wrote: Hi, Check which component is used as root in FeedbackCollector. Is it the page or some other component which is not parent of the component on which you call .error() method ? As a workaround you can use session.error() instead but I think it will be better if you understand why the component-scoped feedback message is not used. On Mon, Mar 25, 2013 at 11:17 AM, Fergal Keating fergal.keat...@directski.com wrote: Hi, I'm using a wizard page on which there is some feedback panels. On the last step, (since i upgraded to version 6.5 wicket) the feedback messages are not displaying. (they are working fine on other steps). I can correctly see each component in the form adding its own error message.The FinishButton#On Error is being called because there are errors detectcted, but they seem to be cleared by the time i have to display the feedback panel. I have even called error() from the overwritten FinishButton#On Error method and it seems to disappear. I have placed Debug on orw.feedback class which shows that my feedback messages are being added. but when the feedback Collector Class gets called to display the feedback messages they somehow seem to have disappeared. The feedback panel is set to visible, and its onBeforeRender is being called, but messages arent displayed. I've tried to see where the messages are being cleared, but it just seem that the FeedbackMessages#clear methods only being called on Detach. can someone advise ? -- Fergal Keating IT Senior Engineer --- e. fergal.keat...@directski.com p. NA w. www.directski.com -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com http://jweekend.com/ -- Fergal Keating IT Senior Engineer --- e. fergal.keat...@directski.com p. NA w. www.directski.com
Re: FeedbackPanel Empty on Wizard in 6.5
Hi, Do you use ListView somewhere in the hierarchy by chance ? I remember a similar issue - the component with the feedback message was in a ListView with .setReuseItems(false). Changing it to .setReuseItems(true) fixed the problem. On Mon, Mar 25, 2013 at 3:06 PM, Fergal Keating fergal.keat...@directski.com wrote: The MywizardPage is being used as the Root component and its set in the FeedbackCollector constructor. So it should be a parent of all components under it. Adding session.error to my FinishButton#OnError get the feedback panel displayed correctly with that one message, however i'm relying on component#setRequired for some of my error messages. so i need to get to the bottom of the issue. I added a check in the feedbackPanel to findParent(MywizardPage.class) and its returning correctly... On 25 March 2013 09:45, Martin Grigorov mgrigo...@apache.org wrote: Hi, Check which component is used as root in FeedbackCollector. Is it the page or some other component which is not parent of the component on which you call .error() method ? As a workaround you can use session.error() instead but I think it will be better if you understand why the component-scoped feedback message is not used. On Mon, Mar 25, 2013 at 11:17 AM, Fergal Keating fergal.keat...@directski.com wrote: Hi, I'm using a wizard page on which there is some feedback panels. On the last step, (since i upgraded to version 6.5 wicket) the feedback messages are not displaying. (they are working fine on other steps). I can correctly see each component in the form adding its own error message.The FinishButton#On Error is being called because there are errors detectcted, but they seem to be cleared by the time i have to display the feedback panel. I have even called error() from the overwritten FinishButton#On Error method and it seems to disappear. I have placed Debug on orw.feedback class which shows that my feedback messages are being added. but when the feedback Collector Class gets called to display the feedback messages they somehow seem to have disappeared. The feedback panel is set to visible, and its onBeforeRender is being called, but messages arent displayed. I've tried to see where the messages are being cleared, but it just seem that the FeedbackMessages#clear methods only being called on Detach. can someone advise ? -- Fergal Keating IT Senior Engineer --- e. fergal.keat...@directski.com p. NA w. www.directski.com -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com http://jweekend.com/ -- Fergal Keating IT Senior Engineer --- e. fergal.keat...@directski.com p. NA w. www.directski.com -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com http://jweekend.com/
