Comment #6 on issue 3683 by rossb...@google.com: C-style for-let can't
handle continue
https://code.google.com/p/v8/issues/detail?id=3683
Simpler is relative. That suggestions would require (a) extending the AST
to record the difference, and (b) implementing the logic to handle it in
all
On 2014/11/07 19:25:28, andrew_low wrote:
[...] Hah. One of the guys here looked at it, and it appears that this is
'dead' code
even on ARM. So it should be removed from PPC and ARM (along with the
associated
code).
Good catch. It seems to be dead for 1.5 years now, starting at the removal
LGTM. I'll land it for you. The concerns about #ifs are mainly that you
construct a rather non-trivial hypercube of configurations without even
trying
to compile most of them. Similar things have hit us in the past in several
other
places, so consider yourself warned... :-D
Comment #7 on issue 3683 by dslo...@chromium.org: C-style for-let can't
handle continue
https://code.google.com/p/v8/issues/detail?id=3683
I disagree; the desugaring is not simple:
1. it adds one extra loop
2. full codegen for loops is convoluted enough already and hard to debug;
this will
Reviewers: Jakob,
Description:
Version 3.29.88.17 (merged r25226)
X87: fix one GC issue caused by x87 crankshaft.
R=jkumme...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/712933002/
Base URL: https://v8.googlecode.com/svn/branches/3.29
Affected files (+4, -4
The code review tool sucks: I can't apply the CL because it's
considered too
big, so we'll have to revert to a 70's style workflow: Could you please
email
me a tar file containing the ppc subdirectory? :-/
https://codereview.chromium.org/571173003/
--
--
v8-dev mailing list
lgtm
https://codereview.chromium.org/712933002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Revision: 25231
Author: yang...@chromium.org
Date: Mon Nov 10 09:05:48 2014 UTC
Log: Fix stepping in for-loops.
R=u...@chromium.org
BUG=v8:3634
LOG=N
Review URL: https://codereview.chromium.org/682413004
https://code.google.com/p/v8/source/detail?r=25231
Added:
Committed patchset #1 (id:1) manually as 25231 (presubmit successful).
https://codereview.chromium.org/682413004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Comment #2 on issue 3634 by bugdro...@chromium.org: debugger 'next' command
doesn't stop at every for...in loop executed within a function
https://code.google.com/p/v8/issues/detail?id=3634#c2
The following revision refers to this bug:
Committed patchset #1 (id:1) manually as 25232.
https://codereview.chromium.org/712933002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
Revision: 25232
Author: weiliang@intel.com
Date: Mon Nov 10 09:08:28 2014 UTC
Log: Version 3.29.88.17 (merged r25226)
X87: fix one GC issue caused by x87 crankshaft.
R=jkumme...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/712933002
Comment #3 on issue 3634 by bugdro...@chromium.org: debugger 'next' command
doesn't stop at every for...in loop executed within a function
https://code.google.com/p/v8/issues/detail?id=3634#c3
The following revision refers to this bug:
Reviewers: Jakob,
Description:
Version 3.30.33.1 (merged r25226)
X87: fix one GC issue caused by x87 crankshaft.
R=jkumme...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/712953002/
Base URL: https://v8.googlecode.com/svn/branches/3.30
Affected files (+4, -4
lgtm
https://codereview.chromium.org/712953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: mvstanton,
Description:
Revert Fix stepping in for-loops.
R=mvstan...@chromium.org
Please review this at https://codereview.chromium.org/713813002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+333, -212 lines):
M src/arm/full-codegen-arm.cc
M
Revision: 25233
Author: yang...@chromium.org
Date: Mon Nov 10 09:35:28 2014 UTC
Log: Revert Fix stepping in for-loops.
TBR=mvstan...@chromium.org
Review URL: https://codereview.chromium.org/713813002
https://code.google.com/p/v8/source/detail?r=25233
Deleted:
Committed patchset #1 (id:1) manually as 25233 (presubmit successful).
https://codereview.chromium.org/713813002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 25234
Author: weiliang@intel.com
Date: Mon Nov 10 09:50:47 2014 UTC
Log: Version 3.30.33.1 (merged r25226)
X87: fix one GC issue caused by x87 crankshaft.
R=jkumme...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/712953002
Committed patchset #1 (id:1) manually as 25234.
https://codereview.chromium.org/712953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
Reviewers: jarin,
Message:
ptal
Description:
[turbofan] add register assignment verifier
R=ja...@chromium.org,
BUG=
Please review this at https://codereview.chromium.org/713803002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+266, -4 lines):
M BUILD.gn
lgtm
https://codereview.chromium.org/713813002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1) manually as 25235 (presubmit successful).
https://codereview.chromium.org/713463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 25235
Author: machenb...@chromium.org
Date: Mon Nov 10 10:26:20 2014 UTC
Log: Add expected outcomes to json test output.
BUG=
R=tand...@chromium.org
Review URL: https://codereview.chromium.org/713463002
https://code.google.com/p/v8/source/detail?r=25235
Modified:
lgtm (although we need to keep an eye on performance of this)
https://codereview.chromium.org/717473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 25236
Author: bmeu...@chromium.org
Date: Mon Nov 10 10:29:37 2014 UTC
Log: [turbofan] Fix select lowering.
Select lowering must not merge Select nodes that depend on each other,
because the resulting graph is not schedulable.
TEST=unittests
R=ja...@chromium.org
Review URL:
Committed patchset #2 (id:20001) manually as 25236 (presubmit successful).
https://codereview.chromium.org/717473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Reviewers: mvstanton,
Description:
Removed dead WriteInt32ToHeapNumberStub.
Please review this at https://codereview.chromium.org/686883003/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+9, -328 lines):
M src/arm/code-stubs-arm.h
M
Reviewers: Dmitry Lomov (chromium),
Description:
More tests for toplevel lexical scope
R=dslo...@chromium.org
BUG=v8:2198
LOG=N
Please review this at https://codereview.chromium.org/716523002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+157, -13 lines):
Reviewers: adamk, rossberg, Toon Verwaest,
Message:
This is done but depends on https://codereview.chromium.org/696783005/
(LoadICs).
Take a look at your leisure, after that lands, I'll re-upload for proper
review
Description:
harmony-scoping: Implement StoreIC handler for stores to global
lgtm
https://codereview.chromium.org/716523002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Jakob,
Message:
PTAL
Description:
Upgrade version and change log after branch.
TBR=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/681113011/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1198, -2 lines):
M
lgtm
https://codereview.chromium.org/681113011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1) manually as 25237 (presubmit successful).
https://codereview.chromium.org/681113011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 25237
Author: machenb...@chromium.org
Date: Mon Nov 10 10:40:59 2014 UTC
Log: Upgrade version and change log after branch.
R=jkumme...@chromium.org
TBR=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/681113011
Reviewers: jarin,
Description:
Revert [turbofan] Fix select lowering.
This reverts commit cf08e8d70ff0fa35dd315ddc430b743bb04c89cf for
breaking Embenchen bullet.
TBR=ja...@chromium.org
Please review this at https://codereview.chromium.org/684413003/
Base URL:
Committed patchset #1 (id:1) manually as 25238 (presubmit successful).
https://codereview.chromium.org/684413003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 25238
Author: bmeu...@chromium.org
Date: Mon Nov 10 10:43:03 2014 UTC
Log: Revert [turbofan] Fix select lowering.
This reverts commit cf08e8d70ff0fa35dd315ddc430b743bb04c89cf for
breaking Embenchen bullet.
TBR=ja...@chromium.org
Review URL:
Revision: 25240
Author: rossb...@chromium.org
Date: Mon Nov 10 10:46:37 2014 UTC
Log: More tests for toplevel lexical scope
R=dslo...@chromium.org
BUG=v8:2198
LOG=N
Review URL: https://codereview.chromium.org/716523002
https://code.google.com/p/v8/source/detail?r=25240
Modified:
Committed patchset #1 manually as 25240 (presubmit successful).
https://codereview.chromium.org/716523002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 25239
Author: machenb...@chromium.org
Date: Mon Nov 10 10:45:50 2014 UTC
Log: Version 3.31.0 (based on 50a829b3cfe8ec0b7ccd1b7e154e632c9a73e5f0)
Classes: Partial fix for constructor not calling super (issues 3661, 3672).
Performance and stability improvements on all
Nice catch :D.
LGTM.
https://codereview.chromium.org/686883003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Committed patchset #1 (id:1) manually as 25241 (presubmit successful).
https://codereview.chromium.org/686883003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Comment #8 on issue 2198 by bugdro...@chromium.org: Implement block scoping
https://code.google.com/p/v8/issues/detail?id=2198#c8
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/30b5371b4eedee5a6ca4b27752949ebd69cb7e80
commit
Comment #9 on issue 2198 by bugdro...@chromium.org: Implement block scoping
https://code.google.com/p/v8/issues/detail?id=2198#c9
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/5ec10fc997c77f13d35c52fd3a69d23f71da8527
commit
Revision: 25241
Author: svenpa...@chromium.org
Date: Mon Nov 10 10:48:38 2014 UTC
Log: Removed dead WriteInt32ToHeapNumberStub.
R=mvstan...@chromium.org
Review URL: https://codereview.chromium.org/686883003
https://code.google.com/p/v8/source/detail?r=25241
Modified:
Reviewers: rossberg,
Description:
Enable all tests in test-decls/CrossScriptReferencesHarmony.
R=rossb...@chromium.org
BUG=v8:2198
LOG=N
Please review this at https://codereview.chromium.org/714593003/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -12
lgtm.
https://codereview.chromium.org/713803002/diff/11/src/compiler/register-allocator-verifier.cc
File src/compiler/register-allocator-verifier.cc (right):
https://codereview.chromium.org/713803002/diff/11/src/compiler/register-allocator-verifier.cc#newcode103
Hm, still fails for me (and some of the build bots).
https://codereview.chromium.org/714593003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe
https://codereview.chromium.org/713803002/diff/11/src/compiler/register-allocator-verifier.cc
File src/compiler/register-allocator-verifier.cc (right):
https://codereview.chromium.org/713803002/diff/11/src/compiler/register-allocator-verifier.cc#newcode103
Reviewers: jarin,
Description:
Reland [turbofan] Fix select lowering with fix.
Select lowering must not merge Select nodes that depend on each other,
because the resulting graph is not schedulable.
TEST=unittests
R=ja...@chromium.org
Please review this at
Committed patchset #4 (id:11) manually as 25242 (presubmit successful).
https://codereview.chromium.org/713803002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Revision: 25242
Author: dcar...@chromium.org
Date: Mon Nov 10 11:28:54 2014 UTC
Log: [turbofan] add register assignment verifier
R=ja...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/713803002
https://code.google.com/p/v8/source/detail?r=25242
Added:
It seems to break with --always-opt, everything is fine when you remove that
flag.
https://codereview.chromium.org/714593003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
Reviewers: tandrii,
Message:
PTAL. The work-dir feature broke this. All commands, e.g. git, operate in
the
work dir checkout of v8, except the file manipulation of the change log.
Description:
Fix change log creation in push script.
BUG=chromium:408523
LOG=n
TBR=tand...@chromium.org
Revision: 25243
Author: dusan.milosavlje...@imgtec.com
Date: Mon Nov 10 11:47:54 2014 UTC
Log: MIPS: Resolve chromium and android webview build conflicts.
The mips related gyp variables and compiler flags for webview
and chromium builds are set externally. The CL ensures this
Committed patchset #1 (id:1) manually as 25244 (presubmit successful).
https://codereview.chromium.org/710593003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
lgtm.
https://codereview.chromium.org/709423003/diff/1/src/compiler/select-lowering.cc
File src/compiler/select-lowering.cc (right):
https://codereview.chromium.org/709423003/diff/1/src/compiler/select-lowering.cc#newcode67
src/compiler/select-lowering.cc:67: BoolVector
Revision: 25244
Author: machenb...@chromium.org
Date: Mon Nov 10 11:52:00 2014 UTC
Log: Fix change log creation in push script.
BUG=chromium:408523
LOG=n
TBR=tand...@chromium.org
TEST=script_test.py
Review URL: https://codereview.chromium.org/710593003
Committed patchset #1 (id:1) manually as 25245 (presubmit successful).
https://codereview.chromium.org/709423003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
https://codereview.chromium.org/709423003/diff/1/src/compiler/select-lowering.cc
File src/compiler/select-lowering.cc (right):
https://codereview.chromium.org/709423003/diff/1/src/compiler/select-lowering.cc#newcode67
src/compiler/select-lowering.cc:67: BoolVector
queued(graph()-NodeCount(),
Revision: 25245
Author: bmeu...@chromium.org
Date: Mon Nov 10 11:55:20 2014 UTC
Log: Reland [turbofan] Fix select lowering with fix.
Select lowering must not merge Select nodes that depend on each other,
because the resulting graph is not schedulable.
TEST=unittests
Reviewers: ,
Message:
Please take a look. The fix is in patch set 2.
As discussed offline, the issue here is that the implementation of for-in
is not
a pure stack-based, but uses registers. That's why a debug break cannot be
inserted. I also changed a few details to make things more
Reviewers: rossberg,
Message:
PTAL
Description:
Invalidate PropertyCell properly.
R=rossb...@chromium.org
BUG=v8:2198
LOG=N
Please review this at https://codereview.chromium.org/715583004/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+20, -14 lines):
M
On 2014/11/10 11:29:18, rossberg wrote:
It seems to break with --always-opt, everything is fine when you remove
that
flag.
Indeed. Fixing this in https://codereview.chromium.org/715583004/
https://codereview.chromium.org/714593003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: jarin,
Description:
Fix bugs in simplified lowering relating to int32/uint32 signs.
Lowering of NumberToUint32 and NumberToInt32 was not correctly accounting
for
the sign of the input and the sign of the output, emitting the wrong
representation changes.
Along the way, I've found
https://codereview.chromium.org/714613002/diff/1/src/compiler/typer.cc
File src/compiler/typer.cc (right):
https://codereview.chromium.org/714613002/diff/1/src/compiler/typer.cc#newcode1037
src/compiler/typer.cc:1037: if (FLAG_turbo_mod_range)
Why do we need a flag here? Maybe just enable this
On 2014/11/10 12:35:19, Dmitry Lomov (chromium) wrote:
PTAL
Nevermind :) Looking
https://codereview.chromium.org/715583004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
https://codereview.chromium.org/714613002/diff/1/src/compiler/typer.cc
File src/compiler/typer.cc (right):
https://codereview.chromium.org/714613002/diff/1/src/compiler/typer.cc#newcode1037
src/compiler/typer.cc:1037: if (FLAG_turbo_mod_range)
On 2014/11/10 12:54:47, Benedikt Meurer wrote:
Why
lgtm
https://codereview.chromium.org/714613002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/714613002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2014/11/10 12:56:25, Dmitry Lomov (chromium) wrote:
On 2014/11/10 12:35:19, Dmitry Lomov (chromium) wrote:
PTAL
Nevermind :) Looking
Ok, I figured it out. The property cell is invalidated correctly anyway, and
those tests fill be fixed after https://codereview.chromium.org/696783005/
lgtm
https://codereview.chromium.org/715583004/diff/20001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/715583004/diff/20001/src/objects.h#newcode9609
src/objects.h:9609: // Sets thev value of the cell to the hole, forgets
any type inferences
Typo
Reviewers: Toon Verwaest,
Message:
PTAL
Description:
MapCache now uses number of properties as a key instead of list of property
names.
Please review this at https://codereview.chromium.org/712943002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+74, -86
It looks okayish to me, except that I suppose there should be some minimal
tests
for GetRange now.
https://codereview.chromium.org/712623002/diff/20001/src/types.cc
File src/types.cc (right):
https://codereview.chromium.org/712623002/diff/20001/src/types.cc#newcode1024
src/types.cc:1024: os
Reviewers: jarin,
Description:
[WIP] Modulus on copy.js.
R=ja...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/713013003/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+228, -65 lines):
M src/compiler/basic-block-instrumentor.cc
Comment #5 on issue 3648 by ma...@chromium.org: ES6: unicode escape
extensions
https://code.google.com/p/v8/issues/detail?id=3648
You're right. As part of this implementation, I will likely not touch the
(mis)feature that escapes are always allowed in regexp bodies.
--
You received this
Reviewers: tandrii,
Message:
PTAL
Description:
Fix serialization of expected outcomes in test driver.
The outcomes are saved as a set and need to be converted into
a list to be json-serializable.
TBR=tand...@chromium.org
Please review this at https://codereview.chromium.org/710073002/
Base
Committed patchset #1 (id:1) manually as 25246 (presubmit successful).
https://codereview.chromium.org/710073002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 25246
Author: machenb...@chromium.org
Date: Mon Nov 10 14:17:50 2014 UTC
Log: Fix serialization of expected outcomes in test driver.
The outcomes are saved as a set and need to be converted into
a list to be json-serializable.
TBR=tand...@chromium.org
Review URL:
lgtm
https://codereview.chromium.org/710593003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Status: Accepted
Owner:
CC: rossb...@chromium.org, ad...@chromium.org
Labels: Type-Bug Priority-Medium HW-All OS-All
New issue 3684 by vego...@chromium.org: ElementsAccessor::SetLength does
not respect non-writeablity of length
https://code.google.com/p/v8/issues/detail?id=3684
var b =
Updates:
Owner: ad...@chromium.org
Cc: -ad...@chromium.org
Comment #1 on issue 3684 by rossb...@chromium.org:
ElementsAccessor::SetLength does not respect non-writeablity of length
https://code.google.com/p/v8/issues/detail?id=3684
(No comment was entered for this change.)
Revision: 25247
Author: tit...@chromium.org
Date: Mon Nov 10 14:28:09 2014 UTC
Log: Fix bugs in simplified lowering relating to int32/uint32 signs.
Lowering of NumberToUint32 and NumberToInt32 was not correctly accounting
for the sign of the input and the sign of the output,
Committed patchset #3 (id:40001) manually as 25247 (presubmit successful).
https://codereview.chromium.org/714613002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
lgtm
https://codereview.chromium.org/710073002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Yang,
Description:
Add optional max elements limit for Map/Set mirror iterator preview.
R=yang...@chromium.org
LOG=N
Please review this at https://codereview.chromium.org/712083002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+72, -32 lines):
M
Reviewers: jarin,
Message:
PTAL.
Description:
Fix has_constant_parameter_count() confusion in LReturn
BUG=chromium:431602
LOG=y
Please review this at https://codereview.chromium.org/714663002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+35, -0 lines):
M
On 2014/11/10 09:02:32, Sven Panne wrote:
The code review tool sucks: I can't apply the CL because it's
considered too
big, so we'll have to revert to a 70's style workflow: Could you please
email
me a tar file containing the ppc subdirectory? :-/
email'd a tgz file (tar + gzip) to your
lgtm
https://codereview.chromium.org/714663002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Addressed offline comments.
https://codereview.chromium.org/712943002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Reviewers: Jakob,
Description:
Disable handle zapping on V8 3.30 branch
BUG=chromium:318206
R=jkumme...@chromium.org
LOG=y
Please review this at https://codereview.chromium.org/716583002/
Base URL: https://v8.googlecode.com/svn/branches/3.30
Affected files (+2, -2 lines):
M
Committed patchset #1 (id:1) manually as 25248 (presubmit successful).
https://codereview.chromium.org/716583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
lgtm
https://codereview.chromium.org/716583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Revision: 25248
Author: joc...@chromium.org
Date: Mon Nov 10 15:24:31 2014 UTC
Log: Disable handle zapping on V8 3.30 branch
BUG=chromium:318206
R=jkumme...@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/716583002
https://code.google.com/p/v8/source/detail?r=25248
Committed patchset #1 (id:1) manually as 25249 (presubmit successful).
https://codereview.chromium.org/714663002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 25249
Author: jkumme...@chromium.org
Date: Mon Nov 10 15:24:58 2014 UTC
Log: Fix has_constant_parameter_count() confusion in LReturn
BUG=chromium:431602
LOG=y
R=ja...@chromium.org
Review URL: https://codereview.chromium.org/714663002
LGTM, with nits.
https://codereview.chromium.org/391693002/diff/160001/src/heap/objects-visiting.h
File src/heap/objects-visiting.h (right):
https://codereview.chromium.org/391693002/diff/160001/src/heap/objects-visiting.h#newcode238
src/heap/objects-visiting.h:238: IterateRawPointers(heap,
I started having a look, but then at some point my confusion exceeded a
threshold. Maybe you can use it as guidance on where to add comments /
clarifications. :)
https://codereview.chromium.org/663683006/diff/220001/src/preparser.h
File src/preparser.h (right):
lgtm, nice simplification!
https://codereview.chromium.org/712943002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
1 - 100 of 132 matches
Mail list logo
