[v8-dev] Re: Revert of Revert of Remove Scope::scope_uses_arguments_ flag (issue 1135463002 by machenb...@chromium.org)

2015-05-07 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135463002/1 https://codereview.chromium.org/1135463002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Revert of Revert of Remove Scope::scope_uses_arguments_ flag (issue 1135463002 by machenb...@chromium.org)

2015-05-07 Thread machenbach
Reviewers: arv, wingo, Message: Created Revert of Revert of Remove Scope::scope_uses_arguments_ flag Description: Revert of Revert of Remove Scope::scope_uses_arguments_ flag (patchset #1 id:1 of https://codereview.chromium.org/1134453002/) Reason for revert: [Sheriff] Speculative reland -

[v8-dev] Re: Revert of Remove Scope::scope_uses_arguments_ flag (issue 1134453002 by machenb...@chromium.org)

2015-05-07 Thread machenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1135463002/ by machenb...@chromium.org. The reason for reverting is: [Sheriff] Speculative reland - maybe this revert wasn't necessary https://codereview.chromium.org/1134453002/ -- -- v8-dev

[v8-dev] Re: Revert of Revert of Remove Scope::scope_uses_arguments_ flag (issue 1135463002 by machenb...@chromium.org)

2015-05-07 Thread commit-bot
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/174) https://codereview.chromium.org/1135463002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Add another test for accessing IdentityMap with SMI keys when it is _not_ empty. (issue 1127113002 by tit...@chromium.org)

2015-05-07 Thread erik . corry
Shouldn't you also fix the assert so it is before checking for emptiness? https://codereview.chromium.org/1127113002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev

[v8-dev] Re: Run test-heap/NoWeakHashTableLeakWithIncrementalMarking with a clean slate. (issue 1132493002 by yang...@chromium.org)

2015-05-07 Thread jkummerow
lgtm https://codereview.chromium.org/1132493002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Run test-heap/NoWeakHashTableLeakWithIncrementalMarking with a clean slate. (issue 1132493002 by yang...@chromium.org)

2015-05-07 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132493002/1 https://codereview.chromium.org/1132493002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Update V8 DEPS. (issue 1133463003 by v8-autor...@chromium.org)

2015-05-07 Thread commit-bot
Patchset 1 (id:??) landed as https://crrev.com/0d4fbfc00bbead3fad098ed6b90aaada83353523 Cr-Commit-Position: refs/heads/master@{#28289} https://codereview.chromium.org/1133463003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Update V8 DEPS. (issue 1133463003 by v8-autor...@chromium.org)

2015-05-07 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/1133463003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: Add aggregated memory histograms. (issue 1125683004 by u...@chromium.org)

2015-05-07 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125683004/80001 https://codereview.chromium.org/1125683004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Issue 4081 in v8: Make [[HomeObject]] a lexically scoped binding?

2015-05-07 Thread codesite-noreply via v8-dev
Comment #2 on issue 4081 by wi...@igalia.com: Make [[HomeObject]] a lexically scoped binding? https://code.google.com/p/v8/issues/detail?id=4081 That makes sense to me too FWIW. Then if the variable isn't used it can be removed. I guess you could make a new Variable::Kind for the home

[v8-dev] Re: Revert of Resolve references to this the same way as normal variables (issue 1129723003 by machenb...@chromium.org)

2015-05-07 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/1129723003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: Revert of Resolve references to this the same way as normal variables (issue 1129723003 by machenb...@chromium.org)

2015-05-07 Thread commit-bot
Patchset 1 (id:??) landed as https://crrev.com/5cab6be83a44567a3ee5747d728a399025d38411 Cr-Commit-Position: refs/heads/master@{#28283} https://codereview.chromium.org/1129723003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Revert of Remove Scope::scope_uses_arguments_ flag (issue 1134453002 by machenb...@chromium.org)

2015-05-07 Thread machenbach
Reviewers: arv, wingo, Message: Created Revert of Remove Scope::scope_uses_arguments_ flag Description: Revert of Remove Scope::scope_uses_arguments_ flag (patchset #1 id:1 of https://codereview.chromium.org/1124233002/) Reason for revert: [Sheriff] Need to fix compilation after this revert:

[v8-dev] Re: Revert of Remove Scope::scope_uses_arguments_ flag (issue 1134453002 by machenb...@chromium.org)

2015-05-07 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/1134453002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: Revert of Remove Scope::scope_uses_arguments_ flag (issue 1134453002 by machenb...@chromium.org)

2015-05-07 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134453002/1 https://codereview.chromium.org/1134453002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Remove Scope::scope_uses_arguments_ flag (issue 1124233002 by wi...@igalia.com)

2015-05-07 Thread machenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1134453002/ by machenb...@chromium.org. The reason for reverting is: [Sheriff] Need to fix compilation after this revert: https://chromium.googlesource.com/v8/v8/+/5cab6be83a44567a3ee5747d728a399025d38411.

[v8-dev] Run test-heap/NoWeakHashTableLeakWithIncrementalMarking with a clean slate. (issue 1132493002 by yang...@chromium.org)

2015-05-07 Thread reply
Reviewers: Jakob, Description: Run test-heap/NoWeakHashTableLeakWithIncrementalMarking with a clean slate. R=jkumme...@chromium.org Please review this at https://codereview.chromium.org/1132493002/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+5, -0 lines):

[v8-dev] Re: Revert of Remove Scope::scope_uses_arguments_ flag (issue 1134453002 by machenb...@chromium.org)

2015-05-07 Thread commit-bot
Patchset 1 (id:??) landed as https://crrev.com/b8ff13111a34553bf17961b9550dcbb7380273f3 Cr-Commit-Position: refs/heads/master@{#28284} https://codereview.chromium.org/1134453002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Revert of Wrap runtime.js in a function. (issue 1123353004 by machenb...@chromium.org)

2015-05-07 Thread yangguo
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1131843002/ by yang...@chromium.org. The reason for reverting is: Failing test has been fixed.. https://codereview.chromium.org/1123353004/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Revert of Revert of Wrap runtime.js in a function. (issue 1131843002 by yang...@chromium.org)

2015-05-07 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131843002/1 https://codereview.chromium.org/1131843002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Fix typo in test-heap/NoWeakHashTableLeakWithIncrementalMarking (issue 1130123002 by yang...@chromium.org)

2015-05-07 Thread mvstanton
haha! Fwunction. LGTM. https://codereview.chromium.org/1130123002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: Fix typo in test-heap/NoWeakHashTableLeakWithIncrementalMarking (issue 1130123002 by yang...@chromium.org)

2015-05-07 Thread mvstanton
haha! Fwunction. LGTM. https://codereview.chromium.org/1130123002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Issue 4084 in v8: cannot build ia32.debug shared_library on MacOSX

2015-05-07 Thread codesite-noreply via v8-dev
Status: Untriaged Owner: New issue 4084 by akad...@wizcorp.jp: cannot build ia32.debug shared_library on MacOSX https://code.google.com/p/v8/issues/detail?id=4084 Version(s): 4.4.56 4.3.61.17 4.2.77.19 OS: MacOSX Architecture: ia32.debug What steps will reproduce the problem? 1.

[v8-dev] Re: Add mode to reduce memory usage in idle notification. (issue 1105293004 by u...@chromium.org)

2015-05-07 Thread hpayer
https://codereview.chromium.org/1105293004/diff/11/src/heap/gc-idle-time-handler.h File src/heap/gc-idle-time-handler.h (right): https://codereview.chromium.org/1105293004/diff/11/src/heap/gc-idle-time-handler.h#newcode152 src/heap/gc-idle-time-handler.h:152: static const int

[v8-dev] Re: [strong] Check arity of functions (issue 1115263004 by a...@chromium.org)

2015-05-07 Thread rossberg
Yes, looks good, ready for ports. https://codereview.chromium.org/1115263004/diff/160001/test/mjsunit/strong/function-arity.js File test/mjsunit/strong/function-arity.js (right): https://codereview.chromium.org/1115263004/diff/160001/test/mjsunit/strong/function-arity.js#newcode5

[v8-dev] 不用请推广员外贸公司的业务员一样可以做国外信息推广

2015-05-07 Thread shendong016
随着国家经济增长放缓,外贸之路也越来越难走,如何找到目标客户信息是整个开 发关键核心所在。 您是否为了“寻找外贸订单”而发愁? 您是否在考虑“如何拓展海外营销渠道”? 您是否正面临“展会效果有限该怎么办”? 您是否在思考“B2B效果不好该如何结局”? 您是否需要“如何通过软件主动去开发海外的优质买家”? 如果对提升企业外贸业绩有兴趣,请及时与我取得联系。 如果您愿意花几分钟的时间了解外贸企业主动出击方式,可以随时加上q 咨询。 演示企鹅: 2376552952 {可利用贵司常用的产品关键词,免费在线演示软件功能和 效果} -

[v8-dev] Re: Update V8 DEPS. (issue 1133463003 by v8-autor...@chromium.org)

2015-05-07 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133463003/1 https://codereview.chromium.org/1133463003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Update V8 DEPS. (issue 1133463003 by v8-autor...@chromium.org)

2015-05-07 Thread reply
Reviewers: Michael Achenbach, Description: Update V8 DEPS. Rolling v8/tools/clang to 52a578929068131eb73e907fdd6e2600e0d3180c TBR=machenb...@chromium.org Please review this at https://codereview.chromium.org/1133463003/ Base URL: https://chromium.googlesource.com/v8/v8@master Affected files

[v8-dev] Re: Migrate error messages, part 9. (issue 1130783002 by yang...@chromium.org)

2015-05-07 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130783002/1 https://codereview.chromium.org/1130783002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: [V8] Reland https://codereview.chromium.org/1121833003/ (issue 1127363002 by kozyatins...@chromium.org)

2015-05-07 Thread yangguo
On 2015/05/07 09:59:57, kozyatinskiy wrote: Yang, ptal. I've added missed Test Expectation in https://codereview.chromium.org/1135493002/ I'll wait for successful runs of v8_linux_layout_dbg and v8_linux_arm_dbg bots before reland. lgtm. https://codereview.chromium.org/1127363002/ --

[v8-dev] Revert of Revert of Wrap runtime.js in a function. (issue 1131843002 by yang...@chromium.org)

2015-05-07 Thread yangguo
Reviewers: Jakob, Michael Achenbach, Message: Created Revert of Revert of Wrap runtime.js in a function. Description: Revert of Revert of Wrap runtime.js in a function. (patchset #1 id:1 of https://codereview.chromium.org/1123353004/) Reason for revert: Failing test has been fixed. Original

[v8-dev] Re: Revert of Revert of Wrap runtime.js in a function. (issue 1131843002 by yang...@chromium.org)

2015-05-07 Thread commit-bot
Patchset 1 (id:??) landed as https://crrev.com/2f9411df89db21af2fe50ad9721611d5c22bc023 Cr-Commit-Position: refs/heads/master@{#28287} https://codereview.chromium.org/1131843002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Revert of Revert of Wrap runtime.js in a function. (issue 1131843002 by yang...@chromium.org)

2015-05-07 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/1131843002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: Version 4.3.61.18 (cherry-pick) (issue 1128343002 by michael_daw...@ca.ibm.com)

2015-05-07 Thread machenbach
lgtm https://codereview.chromium.org/1128343002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Revert of Use CLOCK_REALTIME_COARSE when available. (issue 1130083003 by machenb...@chromium.org)

2015-05-07 Thread commit-bot
Patchset 1 (id:??) landed as https://crrev.com/e137650825fcea22c9e1f1085fc8a3c012f93836 Cr-Commit-Position: refs/heads/master@{#28288} https://codereview.chromium.org/1130083003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Skip test-heap/NoWeakHashTableLeakWithIncrementalMarking for no-snap builds. (issue 1130183002 by yang...@chromium.org)

2015-05-07 Thread reply
Reviewers: Michael Achenbach, Description: Skip test-heap/NoWeakHashTableLeakWithIncrementalMarking for no-snap builds. R=machenb...@chromium.org Please review this at https://codereview.chromium.org/1130183002/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+4,

[v8-dev] Re: Remove Scope::scope_uses_this_ flag (issue 1129823002 by wi...@igalia.com)

2015-05-07 Thread machenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1131713004/ by machenb...@chromium.org. The reason for reverting is: The reason for reverting is: [Sheriff] Need to fix compilation after this revert:

[v8-dev] Revert of Remove Scope::scope_uses_this_ flag (issue 1131713004 by machenb...@chromium.org)

2015-05-07 Thread machenbach
Reviewers: arv, wingo, Message: Created Revert of Remove Scope::scope_uses_this_ flag Description: Revert of Remove Scope::scope_uses_this_ flag (patchset #1 id:1 of https://codereview.chromium.org/1129823002/) Reason for revert: The reason for reverting is: [Sheriff] Need to fix compilation

[v8-dev] Re: Revert of Remove Scope::scope_uses_this_ flag (issue 1131713004 by machenb...@chromium.org)

2015-05-07 Thread commit-bot
Patchset 1 (id:??) landed as https://crrev.com/36f5f4007445c1c8092f2c755ab62bfc034a288c Cr-Commit-Position: refs/heads/master@{#28285} https://codereview.chromium.org/1131713004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Make V8 extras a separate type of native (issue 1129743003 by dome...@chromium.org)

2015-05-07 Thread jochen
https://codereview.chromium.org/1129743003/diff/40001/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/1129743003/diff/40001/src/bootstrapper.cc#newcode1464 src/bootstrapper.cc:1464: return CompileNative(isolate, name, source_code); CompileNative calls

[v8-dev] Re: Migrate error messages, part 9. (issue 1130783002 by yang...@chromium.org)

2015-05-07 Thread mvstanton
lgtm https://codereview.chromium.org/1130783002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Resolve references to this the same way as normal variables (issue 1130733003 by wi...@igalia.com)

2015-05-07 Thread machenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1129723003/ by machenb...@chromium.org. The reason for reverting is: [Sheriff] Breaks jetstream benchmark with errors like this: Running suite: JetStream/bigfib.cpp Stdout (#1): undefined:93:

[v8-dev] Revert of Resolve references to this the same way as normal variables (issue 1129723003 by machenb...@chromium.org)

2015-05-07 Thread machenbach
Reviewers: rossberg, arv, wingo, Message: Created Revert of Resolve references to this the same way as normal variables Description: Revert of Resolve references to this the same way as normal variables (patchset #2 id:20001 of https://codereview.chromium.org/1130733003/) Reason for revert:

[v8-dev] Re: Revert of Resolve references to this the same way as normal variables (issue 1129723003 by machenb...@chromium.org)

2015-05-07 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129723003/1 https://codereview.chromium.org/1129723003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] webmasterjp.com

2015-05-07 Thread webmasterjp.com
welcome to new world -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it, send an email to

[v8-dev] Re: Revert of Revert of Remove Scope::scope_uses_arguments_ flag (issue 1135463002 by machenb...@chromium.org)

2015-05-07 Thread machenbach
Looks like both reverts were necessary. Closing this. https://codereview.chromium.org/1135463002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe

[v8-dev] Re: Run test-heap/NoWeakHashTableLeakWithIncrementalMarking with a clean slate. (issue 1132493002 by yang...@chromium.org)

2015-05-07 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/1132493002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: Run test-heap/NoWeakHashTableLeakWithIncrementalMarking with a clean slate. (issue 1132493002 by yang...@chromium.org)

2015-05-07 Thread commit-bot
Patchset 1 (id:??) landed as https://crrev.com/47e1c276490b9accdd434037b167b4d4d0d53cfd Cr-Commit-Position: refs/heads/master@{#28286} https://codereview.chromium.org/1132493002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: [turbofan] Extract frame-states.h from common-operator.h (issue 1131853002 by tit...@chromium.org)

2015-05-07 Thread jarin
lgtm https://codereview.chromium.org/1131853002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Add aggregated memory histograms. (issue 1125683004 by u...@chromium.org)

2015-05-07 Thread commit-bot
Committed patchset #5 (id:80001) https://codereview.chromium.org/1125683004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: Add aggregated memory histograms. (issue 1125683004 by u...@chromium.org)

2015-05-07 Thread commit-bot
Patchset 5 (id:??) landed as https://crrev.com/d77839fd0182d01e6d7864f0312d2b194deea2f0 Cr-Commit-Position: refs/heads/master@{#28292} https://codereview.chromium.org/1125683004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Revert of Remove Scope::scope_uses_this_ flag (issue 1131713004 by machenb...@chromium.org)

2015-05-07 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131713004/1 https://codereview.chromium.org/1131713004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Revert of Remove Scope::scope_uses_this_ flag (issue 1131713004 by machenb...@chromium.org)

2015-05-07 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/1131713004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] [turbofan] Extract frame-states.h from common-operator.h (issue 1131853002 by tit...@chromium.org)

2015-05-07 Thread titzer
Reviewers: jarin, Description: [turbofan] Extract frame-states.h from common-operator.h R=ja...@chromium.org BUG= Please review this at https://codereview.chromium.org/1131853002/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+175, -138 lines): M BUILD.gn M

[v8-dev] Add the concept of a V8 extras exports object (issue 1128113006 by dome...@chromium.org)

2015-05-07 Thread domenic
Reviewers: jochen, Yang, Description: Add the concept of a V8 extras exports object Exposed to the extras as %GetExtrasExportsObject(), on which they can put things that should be accessible from C++. Exposed to C++ through the V8 API as v8::Context::GetExtrasExportsObject(). Adding a test (in

[v8-dev] Re: [strong] Check arity of functions (issue 1115263004 by a...@chromium.org)

2015-05-07 Thread rossberg
On 2015/05/07 09:33:11, rossberg wrote: Actually, we should have a few explicit tests for optimised functions. ...especially since assertThrows when passed a string will use eval, and eval disables most optimisations. https://codereview.chromium.org/1115263004/ -- -- v8-dev mailing list

[v8-dev] [V8] Reland https://codereview.chromium.org/1121833003/ (issue 1127363002 by kozyatins...@chromium.org)

2015-05-07 Thread kozyatinskiy
Reviewers: Yang, Message: Yang, ptal. I've added missed Test Expectation in https://codereview.chromium.org/1135493002/ I'll wait for successful runs of v8_linux_layout_dbg and v8_linux_arm_dbg bots before reland. Description: [V8] Reland https://codereview.chromium.org/1121833003/

[v8-dev] Re: Fix the build with snapshot=external (issue 1137473002 by dome...@chromium.org)

2015-05-07 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137473002/1 https://codereview.chromium.org/1137473002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Issue 4086 in v8: ES6 Map performance degrades dramatically once container is full enough

2015-05-07 Thread codesite-noreply via v8-dev
Updates: Owner: ad...@chromium.org Labels: Area-Language Comment #1 on issue 4086 by ad...@chromium.org: ES6 Map performance degrades dramatically once container is full enough https://code.google.com/p/v8/issues/detail?id=4086 Node.js 0.12.2 does use a very old version of

[v8-dev] Re: Issue 4086 in v8: ES6 Map performance degrades dramatically once container is full enough

2015-05-07 Thread codesite-noreply via v8-dev
Comment #3 on issue 4086 by ad...@chromium.org: ES6 Map performance degrades dramatically once container is full enough https://code.google.com/p/v8/issues/detail?id=4086 From the description this test case uses Objects as keys, which have not seen much optimization, actually. -- You

[v8-dev] Re: Issue 4086 in v8: ES6 Map performance degrades dramatically once container is full enough

2015-05-07 Thread codesite-noreply via v8-dev
Comment #2 on issue 4086 by a...@chromium.org: ES6 Map performance degrades dramatically once container is full enough https://code.google.com/p/v8/issues/detail?id=4086 Another thing to note is that if you use Smi (small ints) as your key then the Object.create(null) version will use

[v8-dev] Re: Reland: Make V8 extras a separate type of native (issue 1130993003 by dome...@chromium.org)

2015-05-07 Thread yangguo
On 2015/05/07 17:56:46, jochen wrote: lgtm lgtm. https://codereview.chromium.org/1130993003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe

[v8-dev] [turbofan] Use sbfx in ARM64 instruction selector (issue 1135543002 by martyn.capew...@arm.com)

2015-05-07 Thread martyn . capewell
Reviewers: Benedikt Meurer, ulan, Description: [turbofan] Use sbfx in ARM64 instruction selector Select sbfx for ((x k) k) in ARM64 instruction selector, and similarly for ubfx. This is a more generic version of the previous sxtb/h selector. BUG= Please review this at

[v8-dev] Re: Use an explicit base pointer + offset to access fixed typed arrays (issue 1131793003 by joc...@chromium.org)

2015-05-07 Thread yangguo
On 2015/05/07 15:14:01, jochen wrote: ptal as discussed with Yang, FixedTypedArrayBase now defines a visit method that makes it automatically work with serialization. as discussed with Benedikt, I've dropped the offset, and instead make the load of the backing store pointer depend on

[v8-dev] TypedArray.prototype.copyWithin method (issue 1131113002 by dehrenb...@chromium.org)

2015-05-07 Thread dehrenberg
Reviewers: adamk, arv, caitp, Message: This is based on https://codereview.chromium.org/1126313003/ so it includes that patch for now, until that one goes in. If needed, the order can be reversed. Description: TypedArray.prototype.copyWithin method BUG=v8:3578 LOG=Y R=ad...@chromium.org,

[v8-dev] Reland: Make V8 extras a separate type of native (issue 1130993003 by dome...@chromium.org)

2015-05-07 Thread domenic
Reviewers: jochen, Yang, Description: Re-land: Make V8 extras a separate type of native Instead of making them an extra option that gets passed in and compiled at the end of the natives file for a given run of js2c, we now make them a separate run of js2c with a separate natives file output.

[v8-dev] Re: Reland: Make V8 extras a separate type of native (issue 1130993003 by dome...@chromium.org)

2015-05-07 Thread jochen
lgtm https://codereview.chromium.org/1130993003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Fix the build with snapshot=external (issue 1137473002 by dome...@chromium.org)

2015-05-07 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/1137473002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: TypedArray.prototype.copyWithin method (issue 1131113002 by dehrenb...@chromium.org)

2015-05-07 Thread caitpotter88
From a quick glance it looks good, will look in more detail in a few hours https://codereview.chromium.org/1131113002/diff/1/src/harmony-typedarray.js File src/harmony-typedarray.js (right): https://codereview.chromium.org/1131113002/diff/1/src/harmony-typedarray.js#newcode71

[v8-dev] Re: Adding api to get last gc object statistics for chrome://tracing. (issue 1113233002 by s...@chromium.org)

2015-05-07 Thread hablich
On 2015/05/07 14:40:13, ulan wrote: lgtm if the comment below is addressed and if Michael approves. Michael, how does it look with the branch point? Is it ok to land API change now or should we wait until V8 branches? https://codereview.chromium.org/1113233002/diff/50001/include/v8.h

[v8-dev] Make one copy for all TypedArray methods (issue 1126313003 by dehrenb...@chromium.org)

2015-05-07 Thread adamk
Please add a test for this enforcing that there is but a single one of each of these functions on all TypedArray prototypes (could make this a data-driven test that exhaustively tests all TypedArray subtypes and each method). https://codereview.chromium.org/1126313003/ -- -- v8-dev mailing

[v8-dev] Re: Fix the build with snapshot=external (issue 1137473002 by dome...@chromium.org)

2015-05-07 Thread commit-bot
Patchset 1 (id:??) landed as https://crrev.com/0d1e35ab432505170d39846c42902cd7cfd08608 Cr-Commit-Position: refs/heads/master@{#28304} https://codereview.chromium.org/1137473002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Issue 4086 in v8: ES6 Map performance degrades dramatically once container is full enough

2015-05-07 Thread codesite-noreply via v8-dev
Status: Untriaged Owner: New issue 4086 by k...@luminance.org: ES6 Map performance degrades dramatically once container is full enough https://code.google.com/p/v8/issues/detail?id=4086 Version: node v0.12.2, chrome Version 42.0.2311.135 m OS: Windows 8.1 Architecture: x64 What steps

[v8-dev] Re: Use CLOCK_REALTIME_COARSE when available. (issue 1125003002 by b...@strongloop.com)

2015-05-07 Thread mdempsky
https://codereview.chromium.org/1125003002/diff/40001/src/base/platform/time.cc File src/base/platform/time.cc (right): https://codereview.chromium.org/1125003002/diff/40001/src/base/platform/time.cc#newcode262 src/base/platform/time.cc:262: // clockid_t is an int32_t; loads and stores are

[v8-dev] Re: TypedArray.prototype.copyWithin method (issue 1131113002 by dehrenb...@chromium.org)

2015-05-07 Thread adamk
https://codereview.chromium.org/1131113002/diff/1/src/harmony-typedarray.js File src/harmony-typedarray.js (right): https://codereview.chromium.org/1131113002/diff/1/src/harmony-typedarray.js#newcode71 src/harmony-typedarray.js:71: this[to] = this[from]; On 2015/05/07 20:13:20, caitp wrote:

[v8-dev] classes seem to report the wrong constructorname

2015-05-07 Thread tolmasky
class M extends Boolean { } -- thatObject-GetConstructorName() // returns Boolean -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this

[v8-dev] getconstructorname reports for Error.prototype d

2015-05-07 Thread tolmasky
If you pass in Error.prototype, GetConstructorName will give you d. I would expect Error', the same as how Object.prototype gives you Object. -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the

[v8-dev] Issue 4089 in v8: Error.prototype GetConstructorName returns d

2015-05-07 Thread codesite-noreply via v8-dev
Status: Untriaged Owner: New issue 4089 by tolma...@gmail.com: Error.prototype GetConstructorName returns d https://code.google.com/p/v8/issues/detail?id=4089 If you pass in Error.prototype, GetConstructorName will give you d. I would expect Error', the same as how Object.prototype

[v8-dev] Re: [strong] Check arity of functions (issue 1115263004 by a...@chromium.org)

2015-05-07 Thread arv
PTAL https://codereview.chromium.org/1115263004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Issue 4088 in v8: Error.prototype GetConstructorName returns d

2015-05-07 Thread codesite-noreply via v8-dev
Status: Untriaged Owner: New issue 4088 by tolma...@gmail.com: Error.prototype GetConstructorName returns d https://code.google.com/p/v8/issues/detail?id=4088 If you pass in Error.prototype, GetConstructorName will give you d. I would expect Error', the same as how Object.prototype

[v8-dev] Re: Make one copy for all TypedArray methods (issue 1126313003 by dehrenb...@chromium.org)

2015-05-07 Thread dehrenberg
Reviewers: adamk, arv, caitp, Dmitry Lomov (chromium), jochen, Message: Done Description: Make one copy for all TypedArray methods This is the first step of converting TypedArrays to the proper proto chain. There is one copy for each of the Harmony TypedArray methods, rather than a version for

[v8-dev] Re: Make one copy for all TypedArray methods (issue 1126313003 by dehrenb...@chromium.org)

2015-05-07 Thread adamk
https://codereview.chromium.org/1126313003/diff/40001/src/typedarray.js File src/typedarray.js (right): https://codereview.chromium.org/1126313003/diff/40001/src/typedarray.js#newcode158 src/typedarray.js:158: function TypedArraySubArray(begin, end) { We probably want to change this in the

[v8-dev] Re: TypedArray.prototype.copyWithin method (issue 1131113002 by dehrenb...@chromium.org)

2015-05-07 Thread dehrenberg
On 2015/05/07 20:28:07, adamk wrote: https://codereview.chromium.org/1131113002/diff/1/src/harmony-typedarray.js File src/harmony-typedarray.js (right): https://codereview.chromium.org/1131113002/diff/1/src/harmony-typedarray.js#newcode71 src/harmony-typedarray.js:71: this[to] = this[from];

[v8-dev] Re: Revert of Use CLOCK_REALTIME_COARSE when available. (issue 1130083003 by machenb...@chromium.org)

2015-05-07 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/1130083003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: Revert of Use CLOCK_REALTIME_COARSE when available. (issue 1130083003 by machenb...@chromium.org)

2015-05-07 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130083003/1 https://codereview.chromium.org/1130083003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Revert of Use CLOCK_REALTIME_COARSE when available. (issue 1130083003 by machenb...@chromium.org)

2015-05-07 Thread machenbach
Reviewers: jochen, Dean McNamee, Benedikt Meurer, bnoordhuis, Message: Created Revert of Use CLOCK_REALTIME_COARSE when available. Description: Revert of Use CLOCK_REALTIME_COARSE when available. (patchset #3 id:40001 of https://codereview.chromium.org/1125003002/) Reason for revert: [Sheriff]

[v8-dev] Re: Use CLOCK_REALTIME_COARSE when available. (issue 1125003002 by b...@strongloop.com)

2015-05-07 Thread machenbach
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1130083003/ by machenb...@chromium.org. The reason for reverting is: [Sheriff] This causes layout test crashes:

[v8-dev] Re: [strong] Check arity of functions (issue 1115263004 by a...@chromium.org)

2015-05-07 Thread rossberg
Actually, we should have a few explicit tests for optimised functions. https://codereview.chromium.org/1115263004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group.

[v8-dev] Re: Migrate error messages, part 9. (issue 1130783002 by yang...@chromium.org)

2015-05-07 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/1130783002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: Migrate error messages, part 9. (issue 1130783002 by yang...@chromium.org)

2015-05-07 Thread commit-bot
Patchset 1 (id:??) landed as https://crrev.com/f8db4327ade90715649d4571c5199f306fae4dff Cr-Commit-Position: refs/heads/master@{#28291} https://codereview.chromium.org/1130783002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Use an explicit base pointer + offset to access fixed typed arrays (issue 1131793003 by joc...@chromium.org)

2015-05-07 Thread jochen
Reviewers: Benedikt Meurer, Hannes Payer, Yang, Message: ptal Yang: src/snapshot Hannes: src/heap Benedikt: rest lithium ports for the other archs will come before landing Description: Use an explicit base pointer + offset to access fixed typed arrays BUG=v8:3996

[v8-dev] Re: Allow loading holes from holey smi arrays (issue 1134483002 by verwa...@chromium.org)

2015-05-07 Thread mvstanton
LGTM. https://codereview.chromium.org/1134483002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Use CLOCK_REALTIME_COARSE when available. (issue 1125003002 by b...@strongloop.com)

2015-05-07 Thread yurys
Yeah, this code doesn't work well with chrome sandbox. I see the following errors in the console and the renderer crashes on start. ../../sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc:**CRASHING**:seccomp-bpf failure in syscall 0229

[v8-dev] Re: [V8] Reland https://codereview.chromium.org/1121833003/ (issue 1127363002 by kozyatins...@chromium.org)

2015-05-07 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127363002/1 https://codereview.chromium.org/1127363002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Make V8 extras a separate type of native (issue 1129743003 by dome...@chromium.org)

2015-05-07 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129743003/60001 https://codereview.chromium.org/1129743003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Do not sample memory histograms in short idle notifications. (issue 1128363003 by u...@chromium.org)

2015-05-07 Thread commit-bot
Committed patchset #1 (id:1) https://codereview.chromium.org/1128363003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: TypedArray.prototype.every method (issue 1128273002 by dehrenb...@chromium.org)

2015-05-07 Thread arv
LGTM https://codereview.chromium.org/1128273002/diff/40001/test/mjsunit/harmony/typedarrays-every.js File test/mjsunit/harmony/typedarrays-every.js (right): https://codereview.chromium.org/1128273002/diff/40001/test/mjsunit/harmony/typedarrays-every.js#newcode33

[v8-dev] Re: Add the concept of a V8 extras exports object (issue 1128113006 by dome...@chromium.org)

2015-05-07 Thread domenic
Updated to put the exports object on the builtins object instead of using a %GetExtrasExportsObject() function. Can't quite figure out how to exclude the extras-test.js from release builds. Apparently gyp does not allow changing variable values between release and debug!?

[v8-dev] Re: [grokdump] Annoying line wrapping fixed. (issue 1136443002 by ish...@chromium.org)

2015-05-07 Thread jkummerow
lgtm https://codereview.chromium.org/1136443002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

  1   2   3   >