On 2015/05/07 14:40:13, ulan wrote:
lgtm if the comment below is addressed and if Michael approves.
Michael, how does it look with the branch point? Is it ok to land API
change
now
or should we wait until V8 branches?
https://codereview.chromium.org/1113233002/diff/50001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/1113233002/diff/50001/include/v8.h#newcode5222
include/v8.h:5222: size_t NumberOfTrackedGCObjectsTypes();
Let's name it NumberOfTrackedHeapObjectTypes();
As far as I can see this only adds new stuff to the API. So a potential
revert
from our POV should be simple. The thing is, when are the consumers of the
API
going to use the new functionality? If they are start using the new
functionality after we branch, there shouldn't be a problem. Is this
correct?
https://codereview.chromium.org/1113233002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
