lgtm
https://codereview.chromium.org/761093004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/779843002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Benedikt Meurer, titzer, dcarney, danno,
Message:
PTAL
Description:
[ia32] Introduce FMA3 instructions on scalar data elements.
port 83a635e0d70f144300ea83be0d7effc1eb1bf6ef
BUG=
Please review this at https://codereview.chromium.org/773783002/
Base URL:
Reviewers: Benedikt Meurer, titzer, dcarney, danno,
Message:
PTAL
Description:
[ia32] Introduce vex prefix version of float64 arithmetic binop
port 50c4d8826b838596cda892d76ec84eb7a0eab9c1
BUG=
Please review this at https://codereview.chromium.org/770183002/
Base URL:
On 2014/11/28 14:27:36, ulan wrote:
Akos, Weiliang, could you please take a look at mips and x87 ports?
Hi ulan,
The x87 port looks good to me. Thanks a lot for the change of x87 port.
Thanks
-Weiliang
https://codereview.chromium.org/753993003/
--
--
v8-dev mailing list
On 2014/11/28 06:20:59, Benedikt Meurer wrote:
https://codereview.chromium.org/764863002/diff/1/src/compiler/x64/instruction-codes-x64.h
File src/compiler/x64/instruction-codes-x64.h (right):
https://codereview.chromium.org/764863002/diff/1/src/compiler/x64/instruction-codes-x64.h#newcode65
Reviewers: Benedikt Meurer, titzer, danno, dcarney,
Message:
PTAL
Description:
[x64] introduce vex prefix version of float64 arithmetic binop
BUG=
Please review this at https://codereview.chromium.org/764863002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files
lgtm
https://codereview.chromium.org/763953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/763033002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: danno, titzer, Benedikt Meurer, dcarney,
Message:
PTAL
Description:
[x64]: introduce FMA3 instructions on scalar data elements
BUG=
Please review this at https://codereview.chromium.org/757503002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1201,
On 2014/11/25 17:32:42, Benedikt Meurer wrote:
We only need AVX 128bit support for now, so we don't really care whether
the
operating supports AVX 256bit or not. Please remove that AVX OS support
detection for now.
https://codereview.chromium.org/757503002/diff/120001/src/base/cpu.cc
File
lgtm
https://codereview.chromium.org/739823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/724643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/716973004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Jakob,
Description:
Version 3.30.33.3 (merged r25124)
X87: [turbofan] Add AllocateHeapNumberStub to avoid runtime call.
R=jkumme...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/713063003/
Base URL: https://v8.googlecode.com/svn/branches/3.30
Affected
Committed patchset #1 (id:1) manually as 25256.
https://codereview.chromium.org/713063003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
Reviewers: Jakob,
Description:
Version 3.29.88.17 (merged r25226)
X87: fix one GC issue caused by x87 crankshaft.
R=jkumme...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/712933002/
Base URL: https://v8.googlecode.com/svn/branches/3.29
Affected files (+4, -4
Committed patchset #1 (id:1) manually as 25232.
https://codereview.chromium.org/712933002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
Reviewers: Jakob,
Description:
Version 3.30.33.1 (merged r25226)
X87: fix one GC issue caused by x87 crankshaft.
R=jkumme...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/712953002/
Base URL: https://v8.googlecode.com/svn/branches/3.30
Affected files (+4, -4
Committed patchset #1 (id:1) manually as 25234.
https://codereview.chromium.org/712953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
lgtm
https://codereview.chromium.org/716463003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/714573003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/713743003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2014/11/06 07:51:41, Sven Panne wrote:
NOT LGTM
https://codereview.chromium.org/682143003/diff/60001/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
https://codereview.chromium.org/682143003/diff/60001/test/cctest/test-cpu-profiler.cc#newcode
On 2014/11/05 08:38:33, titzer wrote:
lgtm
Please help landing
https://codereview.chromium.org/697353003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Jakob,
Description:
Version 3.29.88.16 (merged r25125)
x87: Set the FPU precision control to double-precision.
R=jkumme...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/700943004/
Base URL: https://v8.googlecode.com/svn/branches/3.29
Affected files (+13,
Committed patchset #1 (id:1) manually as 25137 (tree was closed).
https://codereview.chromium.org/700943004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Thanks for review.
Please have a look at the patch set 4 and help landing.
https://codereview.chromium.org/682143003/diff/20001/src/profile-generator-inl.h
File src/profile-generator-inl.h (right):
https://codereview.chromium.org/682143003/diff/20001/src/profile-generator-inl.h#newcode42
On 2014/11/05 15:15:08, Weiliang wrote:
Thanks for review.
Please have a look at the patch set 4 and help landing.
https://codereview.chromium.org/682143003/diff/20001/src/profile-generator-inl.h
File src/profile-generator-inl.h (right):
Committed patchset #1 (id:1) manually as 25093.
https://codereview.chromium.org/699833003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
Reviewers: danno, titzer, haitao.feng,
Message:
PTAL
Description:
x32: disable turbofan for x32 port
BUG=
Please review this at https://codereview.chromium.org/697353003/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+12, -8 lines):
M
On 2014/11/04 17:24:35, yurys wrote:
Still waiting for OWNERS review.
@danno, @seven
Could you please do a OWNERS review?
Thanks
-Weiliang
https://codereview.chromium.org/682143003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received
lgtm
https://codereview.chromium.org/700053003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Jakob,
Description:
Version 3.29.88.13 (merged r24961, r25000)
X87: Use shared function info for eval cache key.
X87: EmitCreateIteratorResult loads map from function's context
R=jkumme...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/699833003/
Base
PTAL
https://codereview.chromium.org/699833003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
On 2014/10/30 08:35:55, yurys wrote:
Sven, can you do OWNERS review please. It is the same CL as
https://codereview.chromium.org/616963005 but without aforementioned
change in
src/full-codegen.cc.
Rebased.
There are two exceptions for v8_linux_layout_dgb.
But refer to
On 2014/10/29 14:52:56, yurys wrote:
On 2014/10/29 05:09:15, Weiliang wrote:
Hi yurys and all
Could you please take a look this relanding patch?
The failure reason of layout test (fast/events/window-onerror-02.html)
is
due
to
redundant/wrong position info.
It is introduced by the
lgtm
https://codereview.chromium.org/689543002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/682123004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/687273005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/674073004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Sven Panne, alph, yurys, danno,
Message:
Hi yurys and all
Could you please take a look this relanding patch?
The failure reason of layout test (fast/events/window-onerror-02.html) is
due to
redundant/wrong position info.
It is introduced by the change in full-codegen.cc as below
lgtm
https://codereview.chromium.org/663233003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/669823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/642603006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/662323002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/664973002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Benedikt Meurer, titzer, dcarney, danno,
Message:
PTAL
Seems asm.js leads to higher double register pressure.
Description:
IA: Double arithmetic binops support memory operand
BUG=
Please review this at https://codereview.chromium.org/662813002/
Base URL:
lgtm
https://codereview.chromium.org/657273002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2014/10/16 05:35:21, Benedikt Meurer wrote:
How about porting the MacroAssembler::Move(XMMRegister, intX_t) functions
to
X64
instead?
How about the patch set2?
I did not port the case of (nlz + cnt + ntz == 32 or nlz + cnt + ntz == 64)
eagerly, because X64 has a dedicated scratch
On 2014/10/16 08:20:28, Benedikt Meurer wrote:
Yeah, long-term plan is to use constant pool. Still, isn't it faster to
materialize inside SSE register?
OK, i did it.
Please see the patch set 3 and help land it.
https://codereview.chromium.org/658813003/
--
--
v8-dev mailing list
lgtm
https://codereview.chromium.org/643783005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Benedikt Meurer, titzer, dcarney, danno,
Message:
PTAL
Description:
[x64] simply tweak materialization of float/double constants
BUG=
Please review this at https://codereview.chromium.org/658813003/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files
Reviewers: Jakob,
Description:
Version 3.29.88.8 (merged r24189, r24226, r24271)
X87: fixed branch distances.
X87: fix the bug which is introduced by R24169.
X87: fix the Sqrt issue.
R=jkumme...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/653893002/
Base URL:
Hi Jakob,
sorry for another merge due to x87 debug test failure at 3.29 branch.
Could you please have a look?
Thanks~
https://codereview.chromium.org/653893002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you
Committed patchset #1 (id:1) manually as 24586.
https://codereview.chromium.org/653893002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
Hi Jakob,
The merge script fails as below. Do you know how to fix it?
$ tools/push-to-trunk/merge_to_branch.py -s 10 --branch 3.29 24189 24226
24271
Step 10: Determine svn commit revision.
Command: git svn fetch
in /home/user/work/v8-git-svn/v8.git
Traceback (most recent call last):
File
Reviewers: danno_chrmomium.org,
Description:
Version 3.29.88.6 (merged r24190)
X87: Refactor bailout reasons and disable optimization in more cases.
R=da...@chrmomium.org
BUG=
Please review this at https://codereview.chromium.org/654543002/
SVN Base:
PTAL
https://codereview.chromium.org/654543002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Reviewers: Jakob,
Description:
Version 3.29.88.6 (merged r24190)
X87: Refactor bailout reasons and disable optimization in more cases.
R=jkumme...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/654553002/
SVN Base: https://v8.googlecode.com/svn/branches/3.29
Committed patchset #1 (id:1) manually as 24556.
https://codereview.chromium.org/654553002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
lgtm
https://codereview.chromium.org/653823002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/645323002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/645273002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Benedikt Meurer, dcarney, titzer, danno,
Message:
PTAL
Description:
X64: replace explicit zero-extend with runtime assert
Since the input float64 is in the range of [0, 2^32-1], the upper 32 bits of
output register
should be zero.
BUG=
Please review this at
Reviewers: Benedikt Meurer, dcarney, titzer, danno,
Message:
PTAL
Description:
[turbofan] IA: TruncateFloat64ToFloat32 supports mem operand
BUG=
Please review this at https://codereview.chromium.org/639283003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files
lgtm
https://codereview.chromium.org/642843004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/649533002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/643793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/640523002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/635203002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/637193002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/637203002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/642603004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/612873003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed as r24304
https://codereview.chromium.org/612873003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
On 2014/09/29 07:15:58, Sven Panne wrote:
Hmmm, I think this is still fragile: On x87 deopts emit much more code
than on
other platforms, so is it really safe to do *any* near jump in
DoDoubleToI?
Agree. It is still fragile here. We'd better to use the far jump in
DoDoubleToI.
Thanks a
lgtm
https://codereview.chromium.org/606403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed as r24271
https://codereview.chromium.org/606403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
lgtm
https://codereview.chromium.org/614693003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed as r24280
https://codereview.chromium.org/614693003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
On 2014/09/18 16:09:30, yurys wrote:
On 2014/09/18 13:59:24, Weiliang wrote:
On 2014/09/17 13:48:21, I haz the power (commit-bot) wrote:
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a
lgtm
https://codereview.chromium.org/598353002/diff/1/src/x87/lithium-codegen-x87.cc
File src/x87/lithium-codegen-x87.cc (right):
https://codereview.chromium.org/598353002/diff/1/src/x87/lithium-codegen-x87.cc#newcode5308
src/x87/lithium-codegen-x87.cc:5308: __ jmp(done, Label::kFar);
The
Committed as r24226
https://codereview.chromium.org/598353002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
lgtm
https://codereview.chromium.org/607723003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed as r24235
https://codereview.chromium.org/607723003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
lgtm
https://codereview.chromium.org/597003003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed as r24169
https://codereview.chromium.org/597003003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Committed as r24189
https://codereview.chromium.org/595263002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
On 2014/09/24 11:04:43, Sven Panne wrote:
On 2014/09/24 08:35:15, Weiliang wrote:
Committed as r24169
Hmmm, how do you actually commit? The CLs from you are not closed
automatically.
git cl dcommit would do it...
Hi Sven,
Yes, I did it by git cl dcommit.
It is a known issue. The x87 CLs
lgtm
https://codereview.chromium.org/597913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed as r24190
https://codereview.chromium.org/597913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
lgtm
https://codereview.chromium.org/602003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed as r24196
https://codereview.chromium.org/602003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
lgtm
https://codereview.chromium.org/589383003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed as r24160
https://codereview.chromium.org/589383003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
lgtm
https://codereview.chromium.org/594773002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed as r24128
https://codereview.chromium.org/594773002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
lgtm
https://codereview.chromium.org/589313002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed as r24129
https://codereview.chromium.org/589313002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
201 - 300 of 591 matches
Mail list logo