On 2014/09/18 16:09:30, yurys wrote:
On 2014/09/18 13:59:24, Weiliang wrote:
> On 2014/09/17 13:48:21, I haz the power (commit-bot) wrote:
> > No LGTM from a valid reviewer yet. Only full committers are accepted.
> > Even if an LGTM may have been provided, it was from a non-committer or
> > a provisional committer, _not_ a full super star committer.
> > See http://www.chromium.org/getting-involved/become-a-committer
> > Note that this has nothing to do with OWNERS files.
>
> Kindly ping :)

Looks like a few tests are failing consistently on v8_linux_nosnap_dbg, can
you
take a look if it is related to the patch?

Hi Yurys,
Denis gave the patch set 16 to fix the v8_linux_nosnap_dbg failures. Could you
please have a look?

The idea of this fix is to avoid access Code object through a any given Address The Address may be fake and is unable to map to a Code object, just like what cctest/test-profile-generator/RecordTickSample does. The old buggy patch lowers
the access bar and leads to the failures.

Thanks
-Weiliang

https://codereview.chromium.org/424973004/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to