Re: [v8-dev] Re: Building with MSVC

#2 was already fixed. I mentioned that commit earlier in this thread. See https://chromium-review.googlesource.com/c/v8/v8/+/2042874 You could provide explicit members (I have a comment in that CL with a Gist to explain the problem which does exactly that - see

Re: [v8-dev] Re: Building with MSVC

On Tue, Mar 17, 2020 at 2:42 PM Chris Fischer wrote: > > > >1. Modify the third_party/zlib/BUILD.gn configuration to rename the >zlib.dll to something different (conflicted with other 3rd party >dependencies in our system). >2. Modify src/heap/memory-measurement.cc to provide

RE: [v8-dev] Re: Building with MSVC

, 2020 2:32 PM To: v8-dev Subject: Re: [v8-dev] Re: Building with MSVC I thought I'd posted before on why this is a problem currently, but can't find it. To summarize the major points: 1. Clang builds with flags MSVC doesn't support - specifically, /Zc:dllexportInlines- can caus

Re: [v8-dev] Re: Building with MSVC

> > Yes, but then you're doing a custom build anyway. I thought the goal was > to take a regular V8 build and integrate it to a MSVC project. > Oh, I thought the thread was about custom builds. (It's not like we're distributing *any* official builds -- one reason being that there are so many

Re: [v8-dev] Re: Building with MSVC

Yes, but then you're doing a custom build anyway. I thought the goal was to take a regular V8 build and integrate it to a MSVC project. Out of interest: How much test coverage does a "use_custom_libcxx = false" build have upstream? On Monday, March 16, 2020 at 11:37:28 AM UTC-7, Jakob Kummerow

Re: [v8-dev] Re: Building with MSVC

Is #2 not addressed by use_custom_libcxx = false in args.gn? At least on Linux, that causes the default system libstdc++ to be used. On Mon, Mar 16, 2020 at 7:32 PM 'Bill Ticehurst' via v8-dev < v8-dev@googlegroups.com> wrote: > I thought I'd posted before on why this is a problem currently,

Re: [v8-dev] Re: Building with MSVC

I thought I'd posted before on why this is a problem currently, but can't find it. To summarize the major points: 1. Clang builds with flags MSVC doesn't support - specifically, /Zc:dllexportInlines- can cause issues with component builds. (As Clang won't export __declspec(dllexport) functions

Re: [v8-dev] Re: Building with MSVC

That was my thought as well. However, when I successfully built V8 with CLANG and then tried to build our application with MSVC 2017 it failed in the link process with missing symbols. Rebuilding the same version of V8 with MSVC (and fixing a few compiler errors and warnings for that to work)

Re: [v8-dev] Re: Building with MSVC

On Sat, Mar 14, 2020 at 3:03 PM Chris Fischer wrote: > > I'd like to chime in for continued support of MSVC (with build regression > automated tests). We embed V8 in a large project with many third party code > components. Many of these components are not available as source so building >

[v8-dev] Re: Building with MSVC

I'd like to chime in for continued support of MSVC (with build regression automated tests). We embed V8 in a large project with many third party code components. Many of these components are not available as source so building with CLANG is not viable. We currently use V8 as a component

Re: [v8-dev] Re: Building with MSVC

There was another break for a while, which I fixed in early Feb, and matches the error below. You probably need this change: https://chromium-review.googlesource.com/c/v8/v8/+/2042874 - Bill On Tuesday, March 10, 2020 at 10:08:50 AM UTC-7, dim...@coherent-labs.com wrote: > > Hi Bill, > >

Re: [v8-dev] Re: Building with MSVC

Hi Bill, Thanks for the pointers, however I got this error: ninja -t msvc -e environment.x64 -- "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.24.28314\bin\HostX64\x64/cl.exe" /nologo /showIncludes -DUSE_AURA=1 -D_HAS_EXCEPTIONS=0 -DCOMPONENT_BUILD -D__STD_C

Re: [v8-dev] Re: Building with MSVC

Thank you Bill, I appreciate you pointing that out. - Ben On Tue, 3 Mar 2020 at 07:04, 'Bill Ticehurst' via v8-dev < v8-dev@googlegroups.com> wrote: > For what you describe, building a release DLL via MSVC should work fine > (however Debug builds still have issues). > > See

Re: [v8-dev] Re: Building with MSVC

For what you describe, building a release DLL via MSVC should work fine (however Debug builds still have issues). See https://groups.google.com/forum/#!topic/v8-users/cvFGONOg_BY and https://groups.google.com/forum/#!topic/v8-users/mmwWxpb64_I for prior discussions. - Bill On Tuesday,

Re: [v8-dev] Re: Building with MSVC

Clemens, Dimitar, This use case is very important to me also. I think there are a few threads in this group on the topic. For my part, I have complex application with many third party dependencies. Those dependencies do not support clang. So I can't compile my application with clang. I also

Re: [v8-dev] Re: Building with MSVC

On Tue, Feb 25, 2020 at 7:01 PM wrote: > Hi Clemens, > > I don't see any discussion in the bug https://crbug.com/v8/9555 about > the support for MSVC. > Is there a place, where we can vote or explain our use case for not > breaking the usage of v8 from MSVC? > You are right, the issue only

Re: [v8-dev] Re: Building with MSVC

Hi Clemens, I don't see any discussion in the bug https://crbug.com/v8/9555 about the support for MSVC. Is there a place, where we can vote or explain our use case for not breaking the usage of v8 from MSVC? Best regards, Dimitar On Monday, July 29, 2019 at 1:43:30 PM UTC+3, Clemens Backes

Re: [v8-dev] Re: Building with MSVC

Note: This is being tracked as https://crbug.com/v8/9555 now. I am just landing a fix for this , and on the bug we are discussing whether we care enough about MSVC debug to add a bot to the waterfall. On Mon, Jul 29, 2019 at 12:36 PM Jakob Kummerow wrote: > if

Re: [v8-dev] Re: Building with MSVC

> > if someone has the magic args.gn needed, I'd appreciate it. For the record, you can easily get any build bot's args.gn: click through to a specific build (in this case, e.g. https://ci.chromium.org/p/v8/builders/try/v8_win64_msvc_compile_rel/b8906608002392908144), and in the "Steps and Logs"

[v8-dev] Re: Building with MSVC

A colleague tracked it down to the CSA_ASSERT macro in code-stub-assembler.h failing in debug builds (looks like the tryjob only builds rel for MSVC). This change 16 days ago seems to have broken it: https://chromium-review.googlesource.com/c/v8/v8/+/1693002 . If I check out the parent commit