Committed patchset #1 (id:1) manually as 25276 (presubmit successful).
https://codereview.chromium.org/713223002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 25276
Author: yang...@chromium.org
Date: Wed Nov 12 08:04:41 2014 UTC
Log: Abstract string building in JSON-stringifier into
IncrementalStringBuilder.
R=ish...@chromium.org
Review URL: https://codereview.chromium.org/713223002
Reviewers: Igor Sheludko,
Description:
Fix gn build.
TBR=ish...@chromium.org
Please review this at https://codereview.chromium.org/723463002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M BUILD.gn
Index: BUILD.gn
diff --git a/BUILD.gn
Committed patchset #2 (id:20001) manually as 25277 (tree was closed).
https://codereview.chromium.org/723463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 25277
Author: yang...@chromium.org
Date: Wed Nov 12 08:11:57 2014 UTC
Log: Fix gn build.
TBR=ish...@chromium.org
Review URL: https://codereview.chromium.org/723463002
https://code.google.com/p/v8/source/detail?r=25277
Modified:
/branches/bleeding_edge/BUILD.gn
lgtm
https://codereview.chromium.org/710333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Very cool stuff.
I have bunch of comments and questions.
https://codereview.chromium.org/704193007/diff/260001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):
https://codereview.chromium.org/704193007/diff/260001/src/compiler/pipeline.cc#newcode579
Reviewers: Igor Sheludko,
Description:
Fix windows build (static_cast missing).
TBR=ish...@chromium.org
Please review this at https://codereview.chromium.org/714413005/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/string-builder.h
Revision: 25278
Author: yang...@chromium.org
Date: Wed Nov 12 08:15:30 2014 UTC
Log: Fix windows build (static_cast missing).
TBR=ish...@chromium.org
Review URL: https://codereview.chromium.org/714413005
https://code.google.com/p/v8/source/detail?r=25278
Modified:
Committed patchset #1 (id:1) manually as 25278 (presubmit successful).
https://codereview.chromium.org/714413005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
lgtm
https://codereview.chromium.org/709753002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Comment #29 on issue 2825 by yang...@chromium.org: breakpoint resolved to
incorrect location
https://code.google.com/p/v8/issues/detail?id=2825
Can you offer some sort of repro?
--
You received this message because this project is configured to send all
issue notifications to this
Committed patchset #2 (id:20001) manually as 25279 (presubmit successful).
https://codereview.chromium.org/688243005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Revision: 25279
Author: yang...@chromium.org
Date: Wed Nov 12 08:25:59 2014 UTC
Log: Reland Fix stepping in for-loops.
BUG=v8:3634
LOG=N
R=u...@chromium.org
Review URL: https://codereview.chromium.org/688243005
https://code.google.com/p/v8/source/detail?r=25279
Added:
Comment #5 on issue 3634 by bugdro...@chromium.org: debugger 'next' command
doesn't stop at every for...in loop executed within a function
https://code.google.com/p/v8/issues/detail?id=3634#c5
The following revision refers to this bug:
Comment #6 on issue 3634 by bugdro...@chromium.org: debugger 'next' command
doesn't stop at every for...in loop executed within a function
https://code.google.com/p/v8/issues/detail?id=3634#c6
The following revision refers to this bug:
lgtm
https://codereview.chromium.org/716973004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Revision: 25280
Author: weiliang@intel.com
Date: Wed Nov 12 08:32:50 2014 UTC
Log: X87: ES6: Add support for super in object literals
port 721ff07f5901a9bf9ccacf0356a2c10dc452f32d (r25271).
original commit message:
ES6: Add support for super in object literals
This only
Reviewers: Hannes Payer,
Message:
ptal
Description:
Increase the target new space size to the max new space size
Assuming a page creates a low of objects that however will soon die
after page load, delaying the first scavange will hopefully decrease the
amount of time spent during page load
Thanks for the review and sorry for the delay. The updated patch addresses
nits.
https://codereview.chromium.org/668143003/diff/80001/src/ast-numbering.cc
File src/ast-numbering.cc (right):
https://codereview.chromium.org/668143003/diff/80001/src/ast-numbering.cc#newcode48
https://codereview.chromium.org/704193007/diff/260001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):
https://codereview.chromium.org/704193007/diff/260001/src/compiler/pipeline.cc#newcode579
src/compiler/pipeline.cc:579: RegisterAllocatorVerifier* verifier =
NULL;
On 2014/11/12
lgtm
https://codereview.chromium.org/698483004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Comment #30 on issue 2825 by deve...@gmail.com: breakpoint resolved to
incorrect location
https://code.google.com/p/v8/issues/detail?id=2825
My example is not enough or outdated?
--
You received this message because this project is configured to send all
issue notifications to this
Thanks for the review and sorry for the delay. The updated patch addresses
nits.
https://codereview.chromium.org/668143003/diff/80001/src/ast-numbering.cc
File src/ast-numbering.cc (right):
https://codereview.chromium.org/668143003/diff/80001/src/ast-numbering.cc#newcode48
lgtm
https://codereview.chromium.org/717923003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
LGTM with some nits in the tests; please add an OWNER :)
https://codereview.chromium.org/660863003/diff/20001/test/mjsunit/harmony/typedarrays-of.js
File test/mjsunit/harmony/typedarrays-of.js (right):
Committed patchset #1 (id:1) manually as 25281 (presubmit successful).
https://codereview.chromium.org/710333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 25281
Author: mstarzin...@chromium.org
Date: Wed Nov 12 09:19:35 2014 UTC
Log: Scheduler checks that end block doesn't have successors.
R=ja...@chromium.org
TEST=cctest/test-scheduler/RPOLoop
Review URL: https://codereview.chromium.org/710333002
Updates:
Status: Accepted
Comment #2 on issue 3685 by rossb...@chromium.org: Figure out what to do
with counters
https://code.google.com/p/v8/issues/detail?id=3685
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
LG modulo these comments. There's one bug (missing setting the flag), and
the
rest is variable naming and style nits.
In general, the code looks very nice like arv@ said above, and IMO the
latest
patch set is a clear improvement over the previous versions.
Thanks for working on this!
Updates:
Cc: mvstan...@chromium.org
Comment #3 on issue 3685 by mvstan...@chromium.org: Figure out what to do
with counters
https://code.google.com/p/v8/issues/detail?id=3685
(No comment was entered for this change.)
--
You received this message because this project is configured to
Oh and pls change the description of the CL to something more descriptive
as a
preparation step for landing this soon!
https://codereview.chromium.org/663683006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you
LGTM, thanks!
https://codereview.chromium.org/717573006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
Reviewers: Jakob,
Description:
Reorder Error properties.
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/717573006/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/messages.js
Index: src/messages.js
diff
Revision: 25282
Author: yang...@chromium.org
Date: Wed Nov 12 09:28:17 2014 UTC
Log: Reorder Error properties.
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/717573006
https://code.google.com/p/v8/source/detail?r=25282
Modified:
Committed patchset #1 (id:1) manually as 25282 (presubmit successful).
https://codereview.chromium.org/717573006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
https://codereview.chromium.org/699953003/diff/1/src/harmony-typedarray.js
File src/harmony-typedarray.js (right):
https://codereview.chromium.org/699953003/diff/1/src/harmony-typedarray.js#newcode67
src/harmony-typedarray.js:67: var array = ToObject(this);
Need a check that the object is
Reviewers: marja,
Description:
Remove unique static RegExpEmpty instance.
R=ma...@chromium.org
BUG=chromium:430652
LOG=N
Please review this at https://codereview.chromium.org/716113002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -11 lines):
M
lgtm
https://codereview.chromium.org/716113002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #3 (id:40001) manually as 25283 (presubmit successful).
https://codereview.chromium.org/709753002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Revision: 25283
Author: mstarzin...@chromium.org
Date: Wed Nov 12 09:38:33 2014 UTC
Log: Fix scheduler for floating non-naked non-empty loops.
R=ja...@chromium.org
TEST=cctest/test-scheduler/NestedFloatingDiamondWithLoop
Review URL: https://codereview.chromium.org/709753002
Reviewers: ulan,
Message:
Could you a take a look please?
Any idea how to test this? The only repro I have is an html page that
ASSERTs in
release mode with heap verification (I am not even sure we run this
configuration on the waterfall).
Description:
Zap prototype transitions in release
Reviewers: Toon Verwaest,
Message:
PTAL
Description:
Double unboxing tests fixed.
Please review this at https://codereview.chromium.org/715263002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -1 lines):
M test/cctest/test-unboxed-doubles.cc
Index:
lgtm
https://codereview.chromium.org/715263002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Revision: 25284
Author: yang...@chromium.org
Date: Wed Nov 12 09:43:56 2014 UTC
Log: Remove unique static RegExpEmpty instance.
R=ma...@chromium.org
BUG=chromium:430652
LOG=N
Review URL: https://codereview.chromium.org/716113002
https://code.google.com/p/v8/source/detail?r=25284
Committed patchset #1 (id:1) manually as 25284 (presubmit successful).
https://codereview.chromium.org/716113002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Committed patchset #1 (id:1) manually as 25285 (presubmit successful).
https://codereview.chromium.org/712403003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Committed patchset #1 (id:1) manually as 25286 (presubmit successful).
https://codereview.chromium.org/715263002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 25285
Author: mstarzin...@chromium.org
Date: Wed Nov 12 09:46:51 2014 UTC
Log: Fix bug in graph copy while inlining loops.
R=tit...@chromium.org
TEST=cctest/test-run-inlining/InlineLoop
Review URL: https://codereview.chromium.org/712403003
Revision: 25286
Author: ish...@chromium.org
Date: Wed Nov 12 09:47:32 2014 UTC
Log: Double unboxing tests fixed.
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/715263002
https://code.google.com/p/v8/source/detail?r=25286
Modified:
lgtm
https://codereview.chromium.org/714413005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Like it, mostly nits.
https://codereview.chromium.org/716833002/diff/1/src/full-codegen.cc
File src/full-codegen.cc (right):
https://codereview.chromium.org/716833002/diff/1/src/full-codegen.cc#newcode647
src/full-codegen.cc:647: // (innermost) enclosing script scope. To deal
with recursion,
lgtm
https://codereview.chromium.org/715233002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Jakob,
Description:
Switch 'make builddeps' to use HTTPS everywhere.
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/722613002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -3 lines):
M Makefile
Index:
lgtm
https://codereview.chromium.org/722613002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Revision: 25287
Author: ja...@chromium.org
Date: Wed Nov 12 10:01:45 2014 UTC
Log: Zap prototype transitions in release mode, too.
R=u...@chromium.org
BUG=431559
LOG=n
Review URL: https://codereview.chromium.org/715233002
https://code.google.com/p/v8/source/detail?r=25287
Modified:
Committed patchset #1 (id:1) manually as 25287 (presubmit successful).
https://codereview.chromium.org/715233002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 25288
Author: baptiste.a...@arm.com
Date: Wed Nov 12 10:06:12 2014 UTC
Log: [turbofan] Use cbz/cbnz when possible on arm64.
R=bmeu...@chromium.org
Review URL: https://codereview.chromium.org/715433004
https://code.google.com/p/v8/source/detail?r=25288
Modified:
Committed patchset #1 (id:1) manually as 25288 (presubmit successful).
https://codereview.chromium.org/715433004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Committed patchset #5 (id:80001) manually as 25289 (presubmit successful).
https://codereview.chromium.org/701093003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Revision: 25289
Author: yang...@chromium.org
Date: Wed Nov 12 10:06:19 2014 UTC
Log: Correctly compute line numbers in functions from the function
constructor.
R=aand...@chromium.org
BUG=chromium:109362
LOG=Y
Review URL: https://codereview.chromium.org/701093003
Committed patchset #1 (id:1) manually as 25290 (presubmit successful).
https://codereview.chromium.org/722613002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 25290
Author: mstarzin...@chromium.org
Date: Wed Nov 12 10:11:53 2014 UTC
Log: Switch 'make builddeps' to use HTTPS everywhere.
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/722613002
https://code.google.com/p/v8/source/detail?r=25290
Modified:
Comment #4 on issue 3685 by joc...@chromium.org: Figure out what to do with
counters
https://code.google.com/p/v8/issues/detail?id=3685
you should circulate this idea on the team mailing list. I think some
regularly use counters for debugging.
i guess not having counters on background
PTAL
https://codereview.chromium.org/716833002/diff/1/src/full-codegen.cc
File src/full-codegen.cc (right):
https://codereview.chromium.org/716833002/diff/1/src/full-codegen.cc#newcode647
src/full-codegen.cc:647: // (innermost) enclosing script scope. To deal
with recursion, nested modules
On
Can somebody (arv@?) have a look at src/harmony-templates.js, I can't say
whether it's correct or not.
https://codereview.chromium.org/663683006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to
Comment #25 on issue 2935 by u...@chromium.org: Poor performance in Ember
app Discourse
https://code.google.com/p/v8/issues/detail?id=2935
I updated v8:3664 with a prototype fix, which reduces number of
deoptimizations caused by weak references. To see noticeable performance
improvement
Status: Accepted
Owner: ja...@chromium.org
CC: rossb...@chromium.org, tit...@chromium.org, mstarzin...@chromium.org
Labels: Type-FeatureRequest Priority-Medium TurboFan
New issue 3688 by rossb...@chromium.org: TODOs for TF types
https://code.google.com/p/v8/issues/detail?id=3688
Type
lgtm
https://codereview.chromium.org/716833002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: tandrii,
Message:
PTAL
https://codereview.chromium.org/716153002/diff/1/tools/push-to-trunk/common_includes.py
File tools/push-to-trunk/common_includes.py (left):
https://codereview.chromium.org/716153002/diff/1/tools/push-to-trunk/common_includes.py#oldcode452
https://codereview.chromium.org/716833002/diff/20001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/716833002/diff/20001/src/parser.cc#newcode911
src/parser.cc:911: DCHECK(!(*scope)-is_script_scope());
As discussed offline, I'll land without this assertion and figure
added second pass - cleaned some stuff up - ptal
https://codereview.chromium.org/704193007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
Reviewers: *Toon Verwaest, danno,
Message:
Toon: PTAL.
Danno: FYI.
Description:
Perform receiver patching for sloppy mode in high-level IR.
R=verwa...@chromium.org
TEST=cctest/test-run-jscalls/ReceiverPatching
Please review this at https://codereview.chromium.org/717093002/
Base URL:
Reviewers: danno, arv, paul.l..., gergely.kis.imgtec, akos.palfi.imgtec,
dusmil.imgtec,
Description:
MIPS: ES6: Add support for super in object literals.
Port 84741e76a346e34b018af129b0c15bd5d7b1af15
Port r25271
Original commit message:
This only available under --harmony-classes
Committed patchset #3 (id:40001) manually as 25291 (presubmit successful).
https://codereview.chromium.org/716833002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Revision: 25291
Author: dslo...@chromium.org
Date: Wed Nov 12 11:34:09 2014 UTC
Log: Various clean-ups after top-level lexical declarations are done.
1. Global{Context,Scope}=Script{Context,Scope}
2. Enable fixed tests
3. Update comments
R=rossb...@chromium.org
BUG=v8:2198
LOG=N
Comment #15 on issue 2198 by bugdro...@chromium.org: Implement block scoping
https://code.google.com/p/v8/issues/detail?id=2198#c15
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/eacdfa0b7a5c587755b89bf12adce1042e8f423f
commit
Comment #14 on issue 2198 by bugdro...@chromium.org: Implement block scoping
https://code.google.com/p/v8/issues/detail?id=2198#c14
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/bad0224c70db5539f35129a1e9deb78a21395e74
commit
Reviewers: rossberg,
Message:
I looked into doing this in assembly, if there were a faster way, but no.
We
just have to turbofan %_GeneratorResume it seems.
Description:
Leaving a generator via an exception causes it to close
R=rossb...@chromium.org
BUG=v8:3096
LOG=Y
Please review this at
https://codereview.chromium.org/717123002/diff/1/src/generator.js
File src/generator.js (right):
https://codereview.chromium.org/717123002/diff/1/src/generator.js#newcode40
src/generator.js:40: } catch (e) {
Wait, won't this catch the very throw above?
https://codereview.chromium.org/717123002/diff/1/src/generator.js
File src/generator.js (right):
https://codereview.chromium.org/717123002/diff/1/src/generator.js#newcode40
src/generator.js:40: } catch (e) {
On 2014/11/12 11:56:27, rossberg wrote:
Wait, won't this catch the very throw above?
On 2014/11/12 11:53:21, wingo wrote:
I looked into doing this in assembly, if there were a faster way, but
no. We
just have to turbofan %_GeneratorResume it seems.
FWIW I see no perf impact on a microbenchmark.
https://codereview.chromium.org/717123002/
--
--
v8-dev mailing list
lgtm
https://codereview.chromium.org/717123002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: dcarney,
Message:
PTAL
Description:
[arm] Remove code duplication in instruction selector. Refactoring.
TEST=unittests
Please review this at https://codereview.chromium.org/719713002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+75, -137 lines):
lgtm
https://codereview.chromium.org/719713002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1) manually as 25292 (presubmit successful).
https://codereview.chromium.org/719713002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
This patch is incorrect, as it could close a generator that is executing.
var g = (function* () { yield g.next() })();
g.next()
https://codereview.chromium.org/717123002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Revision: 25292
Author: bmeu...@chromium.org
Date: Wed Nov 12 12:07:48 2014 UTC
Log: [arm] Remove code duplication in instruction selector.
Refactoring.
TEST=unittests
R=dcar...@chromium.org
Review URL: https://codereview.chromium.org/719713002
Updates:
Status: Fixed
Comment #2 on issue 2201 by joc...@chromium.org: Expose more detailed
memory statistics
https://code.google.com/p/v8/issues/detail?id=2201
fixed ages ago :)
--
You received this message because this project is configured to send all
issue notifications to
Updates:
Status: Fixed
Comment #3 on issue 3188 by joc...@chromium.org: Support loading the ICU
data from an external icu data file via mmap
https://code.google.com/p/v8/issues/detail?id=3188
we don't mmap the file, but fread it
--
You received this message because this project is
Updates:
Owner: c...@chromium.org
Comment #9 on issue 3345 by joc...@chromium.org: i18n: Make break iterator
use optional
https://code.google.com/p/v8/issues/detail?id=3345
not sure, if we want to support it, it would require some work anyways
--
You received this message because
lgtm
https://codereview.chromium.org/721573003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Sven Panne,
Description:
Only use posix_memalign on Solaris if it's available
R=svenpa...@chromium.org
LOG=n
BUG=v8:3357
Please review this at https://codereview.chromium.org/719523003/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
Reviewers: Sven Panne,
Description:
Link against librt on solaris for semaphore and scheduler symbols
BUG=v8:3358
R=svenpa...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/722673002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1,
Updates:
Status: WorkingAsIntended
Comment #4 on issue 3376 by joc...@chromium.org: Presubmit lint check
triggers on unrelated changes
https://code.google.com/p/v8/issues/detail?id=3376
nope
--
You received this message because this project is configured to send all
issue
Reviewers: Yang,
Description:
Disable top level serialization under harmony_scoping. It has broken tests.
TBR=yang...@chromium.org
Please review this at https://codereview.chromium.org/717143002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -1 lines):
Committed patchset #1 (id:1) manually as 25293 (tree was closed).
https://codereview.chromium.org/717143002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 25293
Author: dslo...@chromium.org
Date: Wed Nov 12 12:23:13 2014 UTC
Log: Disable top level serialization under harmony_scoping. It has
broken tests.
TBR=yang...@chromium.org
Review URL: https://codereview.chromium.org/717143002
Updates:
Status: Fixed
Owner: svenpa...@chromium.org
Comment #6 on issue 3393 by joc...@chromium.org: Variable name conflict in
OS::LogSharedLibraryAddresses on FreeBSD introduced by r21819
https://code.google.com/p/v8/issues/detail?id=3393
(No comment was entered for this
https://codereview.chromium.org/719523003/diff/1/src/allocation.cc
File src/allocation.cc (right):
https://codereview.chromium.org/719523003/diff/1/src/allocation.cc#newcode92
src/allocation.cc:92: #elif V8_LIBC_BIONIC || (V8_OS_SOLARIS
!defined(HAS_POSIX_MEMALIGN))
Hmmm, where does
1 - 100 of 242 matches
Mail list logo
