Re: Final nestmates spec

On 19/12/2017 9:01 AM, Dan Smith wrote: On Dec 18, 2017, at 3:03 PM, David Holmes > wrote: On 19/12/2017 7:28 AM, Dan Smith wrote: But letting things "show through" is, I think, never what the end user will want. They will believe that anything in the array retur

Re: Final nestmates spec

> On Dec 18, 2017, at 3:03 PM, David Holmes wrote: > > On 19/12/2017 7:28 AM, Dan Smith wrote: >> But letting things "show through" is, I think, never what the end user will >> want. They will believe that anything in the array returned by >> 'getNestMembers' actually *is* a member of the nest.

Re: Final nestmates spec

On 19/12/2017 7:28 AM, Dan Smith wrote: On Dec 15, 2017, at 9:41 PM, David Holmes wrote: A good litmus test: should the result contain the current class or not? If it does, you're giving clients a polished list of actual nest members. If it does not, you're just repeating to clients what the

Re: Final nestmates spec

> On Dec 15, 2017, at 9:41 PM, David Holmes wrote: > >> A good litmus test: should the result contain the current class or not? If >> it does, you're giving clients a polished list of actual nest members. If it >> does not, you're just repeating to clients what the attribute says. > > The resu

Re: Final nestmates spec

Hi Dan, On 16/12/2017 4:44 AM, Dan Smith wrote: On Dec 12, 2017, at 12:52 AM, David Holmes wrote: Hi Dan, I have one query with regards to the processing of the NestMembers attribute. Originally when I wrote the draft I copied the InnerClasses text and that included prohibiting duplicate en

Re: Final nestmates spec

> On Dec 12, 2017, at 12:52 AM, David Holmes wrote: > > Hi Dan, > > I have one query with regards to the processing of the NestMembers attribute. > Originally when I wrote the draft I copied the InnerClasses text and that > included prohibiting duplicate entries in NestMembers. You dropped tha

Re: Final nestmates spec

On 15/12/2017 1:53 PM, John Rose wrote: On Dec 14, 2017, at 6:50 PM, David Holmes > wrote: If we encounter nestmate attributes in a classfile with a version that pre-dates the Nestmate release, do we ignore them completely (as an unknown attribute) or assume the

Re: Final nestmates spec

On Dec 14, 2017, at 6:50 PM, David Holmes wrote: > > If we encounter nestmate attributes in a classfile with a version that > pre-dates the Nestmate release, do we ignore them completely (as an unknown > attribute) or assume they are in fact our nestmate attributes? I think we need to ignore t

Re: Final nestmates spec

Hi Dan, Sorry, one further clarification. If we encounter nestmate attributes in a classfile with a version that pre-dates the Nestmate release, do we ignore them completely (as an unknown attribute) or assume they are in fact our nestmate attributes? Thanks, David On 2/12/2017 10:41 AM, Da

Re: Final nestmates spec

On Dec 12, 2017, at 1:55 PM, David Holmes wrote: > > Hi John, > > On 13/12/2017 7:22 AM, John Rose wrote: >> On Dec 11, 2017, at 11:52 PM, David Holmes > > wrote: >>> >>> I have one query with regards to the processing of the NestMembers >>> attribute. Originall

Re: Final nestmates spec

Hi John, On 13/12/2017 7:22 AM, John Rose wrote: On Dec 11, 2017, at 11:52 PM, David Holmes > wrote: I have one query with regards to the processing of the NestMembers attribute. Originally when I wrote the draft I copied the InnerClasses text and that included

Re: Final nestmates spec

On Dec 11, 2017, at 11:52 PM, David Holmes wrote: > > I have one query with regards to the processing of the NestMembers attribute. > Originally when I wrote the draft I copied the InnerClasses text and that > included prohibiting duplicate entries in NestMembers. You dropped that > restrictio

Re: Final nestmates spec

Hi Dan, I have one query with regards to the processing of the NestMembers attribute. Originally when I wrote the draft I copied the InnerClasses text and that included prohibiting duplicate entries in NestMembers. You dropped that restriction from the spec (though I haven't yet removed it fr

Re: Final nestmates spec

All fixed, thanks. > On Dec 5, 2017, at 4:01 PM, Karen Kinnear wrote: > > 1. Since we postponed this, and each release will change the ClassFile > Version: >- the new attributes will be in ClassFile Version 55 >- If we want to use the new versioning, that would be 18.9 (rather than 11)

Re: Final nestmates spec

On Dec 4, 2017, at 4:32 PM, Dan Smith wrote: > > Actioned. Notes on nontrivial suggestions below: > >> On Dec 1, 2017, at 8:21 PM, John Rose wrote: >> >> ++"The NestHost and NestMembers attributes of a class D are used >> to make symbolic references to classes and interfaces in the same >> run

Re: Final nestmates spec

Dan, Many thanks for the careful updates and working so closely with all of us with each iteration. Couple of minor comments: 1. Since we postponed this, and each release will change the ClassFile Version: - the new attributes will be in ClassFile Version 55 - If we want to use the new ve

Re: Final nestmates spec

Actioned. Notes on nontrivial suggestions below: > On Dec 1, 2017, at 8:21 PM, John Rose wrote: > > ++"The NestHost and NestMembers attributes of a class D are used > to make symbolic references to classes and interfaces in the same > run-time package as D. References to other types are ineffec

Re: Final nestmates spec

I read the whole thing with care. It's great; ship it. I do have some editorial comments and nitpicks. There's one substantive change, suggested tentatively. s/18.3/10/ +"It authorizes an enumerated set classes and interfaces to claim membership" s/ set / set of / I notice that we have minimize

Re: Final nestmates spec

On Dec 1, 2017, at 4:41 PM, Dan Smith wrote: > > I've uploaded what I believe could be a final spec for nestmates, here: > http://cr.openjdk.java.net/~dlsmith/nestmates.html > > Since October, changes include: > > - Tweaks to the explanatory material in 2.11.8 and 3.7 > > - Some restructuring