Re: [vdsm] /etc/sysctl.d/vdsm

2013-11-12 Thread Sandro Bonazzola
Il 12/11/2013 09:36, Dan Kenigsberg ha scritto: On Tue, Nov 12, 2013 at 08:00:44AM +0100, Sandro Bonazzola wrote: Hi On Fedora 19 I can see /etc/sysctl.d/vdsm but it seems that it's not read because it should be /etc/sysctl.d/vdsm.conf ( see sysctl --system output ) Is that file really

Re: [vdsm] /etc/sysctl.d/vdsm

2013-11-12 Thread Sandro Bonazzola
Il 12/11/2013 10:39, Yaniv Bronheim ha scritto: If you already in the fix scope, i think this part should move to lib/vdsm/tool/configurator.py and we can call it from spec if required the administrator might use it to check configurations and set them So, can you take the bug? If it was

Re: [vdsm] /etc/sysctl.d/vdsm

2013-11-12 Thread Yaniv Bronheim
You can submit a short fix if you have such and I'll try to get there soon and move it to the configurator - Original Message - From: Sandro Bonazzola sbona...@redhat.com To: Yaniv Bronheim ybron...@redhat.com Cc: Dan Kenigsberg dan...@redhat.com, dougsl...@redhat.com, vdsm-devel

Re: [vdsm] [Users] Low quality of el6 vdsm rpms

2013-11-12 Thread Yaniv Bronheim
Hey Patrick, For the pep8 issue, as mentioned you should check pep8 --version and use 1.4.6. If you use older version, just upgrade with python-pip (yum install python-pip , and then `pip-install install pep8 --upgrade`) Second, try to follow http://www.ovirt.org/Vdsm_Developers , it specifies

Re: [vdsm] [Users] Low quality of el6 vdsm rpms

2013-11-12 Thread Dan Kenigsberg
On Tue, Nov 12, 2013 at 11:31:04AM +0100, Sandro Bonazzola wrote: Il 12/11/2013 10:34, Patrick Hurrelmann ha scritto: Hi all, sorry for this rant, but... Thanks for ranting. Community testing and ranting are to be cherished. We must improve in the points you have raised. I now tried

Re: [vdsm] [Users] Low quality of el6 vdsm rpms

2013-11-12 Thread Ewoud Kohl van Wijngaarden
On Tue, Nov 12, 2013 at 02:33:44PM +, Dan Kenigsberg wrote: On Tue, Nov 12, 2013 at 11:31:04AM +0100, Sandro Bonazzola wrote: Il 12/11/2013 10:34, Patrick Hurrelmann ha scritto: - How can the quality of the vdsm builds be increased? It is frustrating to spend time on testing and then

Re: [vdsm] [Users] Low quality of el6 vdsm rpms

2013-11-12 Thread Eyal Edri
- Original Message - From: Dan Kenigsberg dan...@redhat.com To: Sandro Bonazzola sbona...@redhat.com, dc...@redhat.com Cc: vdsm-devel vdsm-de...@fedorahosted.org, oVirt Mailing List us...@ovirt.org Sent: Tuesday, November 12, 2013 4:33:44 PM Subject: Re: [Users] Low quality of el6

Re: [vdsm] [Users] Low quality of el6 vdsm rpms

2013-11-12 Thread Dan Kenigsberg
On Tue, Nov 12, 2013 at 10:31:24AM -0500, Eyal Edri wrote: snip - There's a Jenkins job to enforce the former requirement of spec requirement. David, Sandro, any idea why it is not running these days? it does run, but we can't enable it since it's still failing:

Re: [vdsm] [Users] Low quality of el6 vdsm rpms

2013-11-12 Thread Dan Kenigsberg
On Tue, Nov 12, 2013 at 04:41:53PM +, Dan Kenigsberg wrote: On Tue, Nov 12, 2013 at 10:31:24AM -0500, Eyal Edri wrote: snip - Keep the docs updated. Our Jenkins slaves have pep8-1.4.6, so we should update http://www.ovirt.org/Vdsm_Developers#Installing_required_packages

Re: [vdsm] [Users] Low quality of el6 vdsm rpms

2013-11-12 Thread Patrick Hurrelmann
On 12.11.2013 15:33, Dan Kenigsberg wrote: I suspect you are not interested in excuses for each of the failures, let us look forwards. My conclusions are: - Do not require non-yet-existing rpms. If we require a feature that is not yet in Fedora/Centos, we must wait. This is already in

Re: [vdsm] [Users] Low quality of el6 vdsm rpms

2013-11-12 Thread Dan Kenigsberg
On Tue, Nov 12, 2013 at 03:51:36PM -0500, Douglas Schilling Landgraf wrote: Indeed, that's bad. It has been included from a patch only on Fedora koji build rawhide. The others points here already have been answered by others developers. Anyway, we have updated the build. We would