Re: [vdsm] Need I set "Verified" when submitting a patch ?

2012-05-10 Thread Dan Kenigsberg
On Wed, May 09, 2012 at 05:25:23PM +0800, Mark Wu wrote: > Hi Guys, > I think people always test their patch before submitting, so > explicitly setting "verified" is not necessary. More importantly, > "verified" by the committer is not convincible //enough for code > quality assurance. Wha

Re: [vdsm] Need I set "Verified" when submitting a patch ?

2012-05-09 Thread Ryan Harper
* Mark Wu [2012-05-09 04:58]: > Hi Guys, > I think people always test their patch before submitting, so > explicitly setting "verified" is not necessary. More importantly, > "verified" by the committer is not convincible //enough for code > quality assurance. What's your opinion? I be

[vdsm] Need I set "Verified" when submitting a patch ?

2012-05-09 Thread Mark Wu
Hi Guys, I think people always test their patch before submitting, so explicitly setting "verified" is not necessary. More importantly, "verified" by the committer is not convincible //enough for code quality assurance. What's your opinion? Thanks! Mark. ___