gt; Sent: Monday, March 26, 2012 5:52:13 AM
> Subject: Re: [vdsm] PEP8 in VDSM code
>
> On 03/26/2012 11:26 AM, Ewoud Kohl van Wijngaarden wrote:
> > On Mon, Mar 26, 2012 at 04:57:24AM -0400, Ayal Baron wrote:
> >>> I'd rather avoid gerrit hooks if possible to use
On 03/26/2012 11:26 AM, Ewoud Kohl van Wijngaarden wrote:
On Mon, Mar 26, 2012 at 04:57:24AM -0400, Ayal Baron wrote:
I'd rather avoid gerrit hooks if possible to use a jenkins job to
validate this to keep the gerrit deployment as simple to
maintain/upgrade as possible.
But that's the wrong pl
On Mon, Mar 26, 2012 at 04:57:24AM -0400, Ayal Baron wrote:
> > I'd rather avoid gerrit hooks if possible to use a jenkins job to
> > validate this to keep the gerrit deployment as simple to
> > maintain/upgrade as possible.
>
> But that's the wrong place to be doing it.
> Jenkins periodically poll
- Original Message -
> On 03/22/2012 10:18 PM, Saggi Mizrahi wrote:
> > I suggest having pep8 a must for patch submission in VDSM.
> > http://www.python.org/dev/peps/pep-0008/
> >
> > Currently there are a few people policing these rules in reviews
> > but I suggest we make it automatic.
On 03/22/2012 10:18 PM, Saggi Mizrahi wrote:
I suggest having pep8 a must for patch submission in VDSM.
http://www.python.org/dev/peps/pep-0008/
Currently there are a few people policing these rules in reviews but I suggest
we make it automatic.
Unless someone objects I will put a gerrit hook
- Original Message -
> On Thu, Mar 22, 2012 at 04:18:10PM -0400, Saggi Mizrahi wrote:
> > I suggest having pep8 a must for patch submission in VDSM.
> > http://www.python.org/dev/peps/pep-0008/
> >
> > Currently there are a few people policing these rules in reviews
> > but I suggest we
On Thu, Mar 22, 2012 at 04:18:10PM -0400, Saggi Mizrahi wrote:
> I suggest having pep8 a must for patch submission in VDSM.
> http://www.python.org/dev/peps/pep-0008/
>
> Currently there are a few people policing these rules in reviews but I
> suggest we make it automatic.
>
> Unless someone obj
I suggest having pep8 a must for patch submission in VDSM.
http://www.python.org/dev/peps/pep-0008/
Currently there are a few people policing these rules in reviews but I suggest
we make it automatic.
Unless someone objects I will put a gerrit hook that complains about pep8
violations.
It will