Re: [vdsm] Error when running autobuild
On Sun, Mar 04, 2012 at 12:40:47AM +0200, Itamar Heim wrote: > On 03/04/2012 12:36 AM, Dan Kenigsberg wrote: > >On Fri, Mar 02, 2012 at 09:49:10AM +0200, Itamar Heim wrote: > >>On 03/01/2012 08:18 PM, Ewoud Kohl van Wijngaarden wrote: > >>>On Thu, Mar 01, 2012 at 03:18:59PM +, Itzik Brown wrote: > I have a problem building vdsm on RHEL 6.2 > > After running the following: > > # git clone http://gerrit.ovirt.org/p/vdsm.git > # cd vdsm > # git fetch http://gerrit.ovirt.org/p/vdsm refs/changes/93/1693/5&& git > checkout FETCH_HEAD > # ./autobuild.sh > >> > >>cc-ing eyal - lets make sure we have a jenkins job running > >>./autobuild.sh on master (if not already)? > > > >Just make sure *not* to automatically run any code posted to gerrit. > >You can run pyflakes *on* it, but blind 'make' before human review invites > >evil > >posters. > > that's true in general. > but would we want to pre-approve patch senders? > or maybe only run make (for engine as well) if submitter is in a > white-list of sorts in jenkins? I suppose we can trust anyone who already contributed to Vdsm, but there is still a chance of a lost laptop leading to our jenkins server running arbitrary code. Maybe we should forget about whitelisting, and use expendible network-less VMs to run whatever test jenkins runs on unreviewed code. ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] Error when running autobuild
- Original Message - > From: "Itamar Heim" > To: "Ewoud Kohl van Wijngaarden" > Cc: vdsm-devel@lists.fedorahosted.org, "Eyal Edri" > Sent: Friday, March 2, 2012 9:49:10 AM > Subject: Re: [vdsm] Error when running autobuild > > On 03/01/2012 08:18 PM, Ewoud Kohl van Wijngaarden wrote: > > On Thu, Mar 01, 2012 at 03:18:59PM +, Itzik Brown wrote: > >> I have a problem building vdsm on RHEL 6.2 > >> > >> After running the following: > >> > >> # git clone http://gerrit.ovirt.org/p/vdsm.git > >> # cd vdsm > >> # git fetch http://gerrit.ovirt.org/p/vdsm > >> refs/changes/93/1693/5&& git checkout FETCH_HEAD > >> # ./autobuild.sh > > cc-ing eyal - lets make sure we have a jenkins job running > ./autobuild.sh on master (if not already)? we have : http://jenkins.eng.lab.tlv.redhat.com/view/vdsm/job/ovirt_vdsm_build_latest_rpms > > > > > Already worked this out in #vdsm, but for the archives. > > > > Using git bisect you can find the commit that broke it. So we know > > HEAD > > is bad (because ./autobuild.sh fails) and we assume master is good, > > thus > > we start bisecting: > > > > git bisect start HEAD master > > > > Since we already have a script that can tell us if it's good or bad > > we > > can run: > > > > git bisect run ./autobuild.sh > > > > This will produce output and if you're lucky produce a line similar > > to: > > > > 57dbd4f19a953f07860d74d3c08d450e3e76701b is the first bad > > commit > > > > Next step is to look in gerrit. This leads us to a review > > (http://gerrit.ovirt.org/#change,1038) which is still in progress. > > In > > this case you can make a review to make sure it doesn't get pushed > > in > > this state. If it was merged already you've found a regression. > > Note > > that we assumed master was good, but that may be wrong so double > > check. > > ___ > > vdsm-devel mailing list > > vdsm-devel@lists.fedorahosted.org > > https://fedorahosted.org/mailman/listinfo/vdsm-devel > > ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] Error when running autobuild
- Original Message - > From: "Eyal Edri" > To: "Itamar Heim" > Cc: vdsm-devel@lists.fedorahosted.org, "Ewoud Kohl van Wijngaarden" > > Sent: Friday, March 2, 2012 1:30:16 PM > Subject: Re: [vdsm] Error when running autobuild > > > > - Original Message - > > From: "Itamar Heim" > > To: "Ewoud Kohl van Wijngaarden" > > > > Cc: vdsm-devel@lists.fedorahosted.org, "Eyal Edri" > > > > Sent: Friday, March 2, 2012 9:49:10 AM > > Subject: Re: [vdsm] Error when running autobuild > > > > On 03/01/2012 08:18 PM, Ewoud Kohl van Wijngaarden wrote: > > > On Thu, Mar 01, 2012 at 03:18:59PM +, Itzik Brown wrote: > > >> I have a problem building vdsm on RHEL 6.2 > > >> > > >> After running the following: > > >> > > >> # git clone http://gerrit.ovirt.org/p/vdsm.git > > >> # cd vdsm > > >> # git fetch http://gerrit.ovirt.org/p/vdsm > > >> refs/changes/93/1693/5&& git checkout FETCH_HEAD > > >> # ./autobuild.sh > > > > cc-ing eyal - lets make sure we have a jenkins job running > > ./autobuild.sh on master (if not already)? > > we have : > http://jenkins.eng.lab.tlv.redhat.com/view/vdsm/job/ovirt_vdsm_build_latest_rpms > > Just noticed this is still on internal jenkins. it will move soon to upstream jenkins on jenkins.ovirt.org. > > > > > > Already worked this out in #vdsm, but for the archives. > > > > > > Using git bisect you can find the commit that broke it. So we > > > know > > > HEAD > > > is bad (because ./autobuild.sh fails) and we assume master is > > > good, > > > thus > > > we start bisecting: > > > > > > git bisect start HEAD master > > > > > > Since we already have a script that can tell us if it's good or > > > bad > > > we > > > can run: > > > > > > git bisect run ./autobuild.sh > > > > > > This will produce output and if you're lucky produce a line > > > similar > > > to: > > > > > > 57dbd4f19a953f07860d74d3c08d450e3e76701b is the first > > > bad > > > commit > > > > > > Next step is to look in gerrit. This leads us to a review > > > (http://gerrit.ovirt.org/#change,1038) which is still in > > > progress. > > > In > > > this case you can make a review to make sure it doesn't get > > > pushed > > > in > > > this state. If it was merged already you've found a regression. > > > Note > > > that we assumed master was good, but that may be wrong so double > > > check. > > > ___ > > > vdsm-devel mailing list > > > vdsm-devel@lists.fedorahosted.org > > > https://fedorahosted.org/mailman/listinfo/vdsm-devel > > > > ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] Error when running autobuild
On 03/04/2012 12:36 AM, Dan Kenigsberg wrote: On Fri, Mar 02, 2012 at 09:49:10AM +0200, Itamar Heim wrote: On 03/01/2012 08:18 PM, Ewoud Kohl van Wijngaarden wrote: On Thu, Mar 01, 2012 at 03:18:59PM +, Itzik Brown wrote: I have a problem building vdsm on RHEL 6.2 After running the following: # git clone http://gerrit.ovirt.org/p/vdsm.git # cd vdsm # git fetch http://gerrit.ovirt.org/p/vdsm refs/changes/93/1693/5&& git checkout FETCH_HEAD # ./autobuild.sh cc-ing eyal - lets make sure we have a jenkins job running ./autobuild.sh on master (if not already)? Just make sure *not* to automatically run any code posted to gerrit. You can run pyflakes *on* it, but blind 'make' before human review invites evil posters. that's true in general. but would we want to pre-approve patch senders? or maybe only run make (for engine as well) if submitter is in a white-list of sorts in jenkins? ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] Error when running autobuild
On Fri, Mar 02, 2012 at 09:49:10AM +0200, Itamar Heim wrote: > On 03/01/2012 08:18 PM, Ewoud Kohl van Wijngaarden wrote: > >On Thu, Mar 01, 2012 at 03:18:59PM +, Itzik Brown wrote: > >>I have a problem building vdsm on RHEL 6.2 > >> > >>After running the following: > >> > >># git clone http://gerrit.ovirt.org/p/vdsm.git > >># cd vdsm > >># git fetch http://gerrit.ovirt.org/p/vdsm refs/changes/93/1693/5&& git > >>checkout FETCH_HEAD > >># ./autobuild.sh > > cc-ing eyal - lets make sure we have a jenkins job running > ./autobuild.sh on master (if not already)? Just make sure *not* to automatically run any code posted to gerrit. You can run pyflakes *on* it, but blind 'make' before human review invites evil posters. > > > > >Already worked this out in #vdsm, but for the archives. > > > >Using git bisect you can find the commit that broke it. So we know HEAD > >is bad (because ./autobuild.sh fails) and we assume master is good, thus > >we start bisecting: > > > > git bisect start HEAD master > > > >Since we already have a script that can tell us if it's good or bad we > >can run: > > > > git bisect run ./autobuild.sh > > > >This will produce output and if you're lucky produce a line similar to: > > > > 57dbd4f19a953f07860d74d3c08d450e3e76701b is the first bad commit > > > >Next step is to look in gerrit. This leads us to a review > >(http://gerrit.ovirt.org/#change,1038) which is still in progress. In > >this case you can make a review to make sure it doesn't get pushed in > >this state. If it was merged already you've found a regression. Note > >that we assumed master was good, but that may be wrong so double check. > >___ > >vdsm-devel mailing list > >vdsm-devel@lists.fedorahosted.org > >https://fedorahosted.org/mailman/listinfo/vdsm-devel > > ___ > vdsm-devel mailing list > vdsm-devel@lists.fedorahosted.org > https://fedorahosted.org/mailman/listinfo/vdsm-devel ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] Error when running autobuild
Hello Itzik, On 03/01/2012 10:18 AM, Itzik Brown wrote: Hi, I have a problem building vdsm on RHEL 6.2 Thanks for this email. However, it's not a problem between vdsm and RHEL 6.2, looks like a problem into the change that you are including to the build (git fech). Please, look my comment below. After running the following: # git clone http://gerrit.ovirt.org/p/vdsm.git # cd vdsm # git fetch http://gerrit.ovirt.org/p/vdsm refs/changes/93/1693/5&& git checkout FETCH_HEAD # ./autobuild.sh I get the following error: /usr/bin/pyflakes vdsm vdsm_cli vds_bootstrap vdsm_reg vdsm_hooks vdsm/storage/storageServer.py:25: 'Thread' imported but unused vdsm/storage/storageServer.py:25: 'RLock' imported but unused vdsm/storage/storageServer.py:25: 'Event' imported but unused vdsm/storage/storageServer.py:34: 'asyncmethod' imported but unused vdsm/storage/storageServer.py:34: 'AsyncCallStub' imported but unused make[2]: *** [check-local] Error 1 make[2]: Leaving directory `/tmp/vdsm' make[1]: *** [check-am] Error 2 make[1]: Leaving directory `/tmp/vdsm' make: *** [check-recursive] Error 1 exec 3<&- test "$st" = 0 I would recommend you to login into gerrit (openID system) and make your feedback/comments into the patch that you are including into the build (and generating this error), once you do it the developer that is creating this patch will be notified. Please let us know if you need any additional help. Thanks! -- Cheers Douglas ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] Error when running autobuild
On 03/01/2012 08:18 PM, Ewoud Kohl van Wijngaarden wrote: On Thu, Mar 01, 2012 at 03:18:59PM +, Itzik Brown wrote: I have a problem building vdsm on RHEL 6.2 After running the following: # git clone http://gerrit.ovirt.org/p/vdsm.git # cd vdsm # git fetch http://gerrit.ovirt.org/p/vdsm refs/changes/93/1693/5&& git checkout FETCH_HEAD # ./autobuild.sh cc-ing eyal - lets make sure we have a jenkins job running ./autobuild.sh on master (if not already)? Already worked this out in #vdsm, but for the archives. Using git bisect you can find the commit that broke it. So we know HEAD is bad (because ./autobuild.sh fails) and we assume master is good, thus we start bisecting: git bisect start HEAD master Since we already have a script that can tell us if it's good or bad we can run: git bisect run ./autobuild.sh This will produce output and if you're lucky produce a line similar to: 57dbd4f19a953f07860d74d3c08d450e3e76701b is the first bad commit Next step is to look in gerrit. This leads us to a review (http://gerrit.ovirt.org/#change,1038) which is still in progress. In this case you can make a review to make sure it doesn't get pushed in this state. If it was merged already you've found a regression. Note that we assumed master was good, but that may be wrong so double check. ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] Error when running autobuild
On Thu, Mar 01, 2012 at 03:18:59PM +, Itzik Brown wrote: > I have a problem building vdsm on RHEL 6.2 > > After running the following: > > # git clone http://gerrit.ovirt.org/p/vdsm.git > # cd vdsm > # git fetch http://gerrit.ovirt.org/p/vdsm refs/changes/93/1693/5 && git > checkout FETCH_HEAD > # ./autobuild.sh Already worked this out in #vdsm, but for the archives. Using git bisect you can find the commit that broke it. So we know HEAD is bad (because ./autobuild.sh fails) and we assume master is good, thus we start bisecting: git bisect start HEAD master Since we already have a script that can tell us if it's good or bad we can run: git bisect run ./autobuild.sh This will produce output and if you're lucky produce a line similar to: 57dbd4f19a953f07860d74d3c08d450e3e76701b is the first bad commit Next step is to look in gerrit. This leads us to a review (http://gerrit.ovirt.org/#change,1038) which is still in progress. In this case you can make a review to make sure it doesn't get pushed in this state. If it was merged already you've found a regression. Note that we assumed master was good, but that may be wrong so double check. ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
[vdsm] Error when running autobuild
Hi, I have a problem building vdsm on RHEL 6.2 After running the following: # git clone http://gerrit.ovirt.org/p/vdsm.git # cd vdsm # git fetch http://gerrit.ovirt.org/p/vdsm refs/changes/93/1693/5 && git checkout FETCH_HEAD # ./autobuild.sh I get the following error: /usr/bin/pyflakes vdsm vdsm_cli vds_bootstrap vdsm_reg vdsm_hooks vdsm/storage/storageServer.py:25: 'Thread' imported but unused vdsm/storage/storageServer.py:25: 'RLock' imported but unused vdsm/storage/storageServer.py:25: 'Event' imported but unused vdsm/storage/storageServer.py:34: 'asyncmethod' imported but unused vdsm/storage/storageServer.py:34: 'AsyncCallStub' imported but unused make[2]: *** [check-local] Error 1 make[2]: Leaving directory `/tmp/vdsm' make[1]: *** [check-am] Error 2 make[1]: Leaving directory `/tmp/vdsm' make: *** [check-recursive] Error 1 exec 3<&- test "$st" = 0 Please advise, Itzik ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
