Michal Skrivanek has posted comments on this change.
Change subject: converting some more RH strings to oVirt
..
Patch Set 6: (1 inline comment)
File vdsm/constants.py.in
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..
Patch Set 2: (1 inline comment)
File vdsm_reg/vdsm-upgrade
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..
Patch Set 2: (1 inline comment)
File vdsm_reg/vdsm-upgrade
Royce Lv has uploaded a new change for review.
Change subject: pep8 clean for vdsm/vdsm
..
pep8 clean for vdsm/vdsm
Change-Id: Ie1a4ce706d7f501de1637614e3b574aef209fab1
Signed-off-by: Royce Lvlvro...@linux.vnet.ibm.com
---
M
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add permutation feature to testing framework
..
Patch Set 13: Looks good to me, but someone else must approve
Do you have a plan on implementing multi-level
Juan Hernandez has posted comments on this change.
Change subject: BZ#856167 - Parse correctly the management_server parameter
..
Patch Set 2:
Replaced if [[ ... ]] with case ... in order to avoid bash dependency
(although
Royce Lv has uploaded a new change for review.
Change subject: [WIP]add mem cgroup support to vdsm
..
[WIP]add mem cgroup support to vdsm
add vdsm mem cgroup support,
New version libvirt memtune function has a bug,
tested
Juan Hernandez has posted comments on this change.
Change subject: BZ#856167 - Validate downloaded SSH public key
..
Patch Set 3:
Moved the validation of the SSH key to the method that downloads it.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: pep8 clean for vdsm/vdsm
..
Patch Set 1: Verified; Looks good to me, approved
oops, thanks! bad cherry-picking.
--
To view, visit http://gerrit.ovirt.org/8030
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pep8 clean for vdsm/vdsm
..
pep8 clean for vdsm/vdsm
Change-Id: Ie1a4ce706d7f501de1637614e3b574aef209fab1
Signed-off-by: Royce
Juan Hernandez has posted comments on this change.
Change subject: BZ#856167 - Parse correctly the management_server parameter
..
Patch Set 3:
Fixed a typo.
--
To view, visit http://gerrit.ovirt.org/8022
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: faqemu: remove the fake /dev/kvm after vdsmd stops
..
faqemu: remove the fake /dev/kvm after vdsmd stops
/usr/libexec/vdsm/vdsm-faqemu, the fake
Juan Hernandez has posted comments on this change.
Change subject: BZ#856167 - Validate downloaded CA certificate
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/8021
To unsubscribe, visit
Deepak C Shetty has uploaded a new change for review.
Change subject: Move gluster/{cli.py, exception.py} to vdsm rpm
..
Move gluster/{cli.py, exception.py} to vdsm rpm
This move is being done so that vdsm code using gluster
Deepak C Shetty has posted comments on this change.
Change subject: Move gluster/{cli.py, exception.py} to vdsm rpm
..
Patch Set 1:
Verified by installing VDSM rpm and ensuring the cli and exception.py files are
installed as
Deepak C Shetty has posted comments on this change.
Change subject: Move gluster/{cli.py, exception.py} to vdsm rpm
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit
Deepak C Shetty has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
..
Patch Set 7:
@Federico,
http://gerrit.ovirt.org/#/c/8033/ patch posted to move cli and exception.py
from vdsm-gluster to vdsm
Mark Wu has posted comments on this change.
Change subject: add verb for vdsm to tuneCpu params
..
Patch Set 6: I would prefer that you didn't submit this
(3 inline comments)
Shireesh Anjal has posted comments on this change.
Change subject: glusterHostsList verb returns local hostname as IP address or
FQDN
..
Patch Set 1: (1 inline comment)
Detailed response to Dan's question in-line.
Federico Simoncelli has posted comments on this change.
Change subject: Logging shouldn't reach the terminal console
..
Patch Set 1: I would prefer that you didn't submit this
I still get few sporadic logs to the console. I'm
Shu Ming has posted comments on this change.
Change subject: Move gluster/{cli.py, exception.py} to vdsm rpm
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Shu Ming has posted comments on this change.
Change subject: Add an option to create a watchdog device.
..
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Enable vdsm-reg service
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Alon Bar-Lev has posted comments on this change.
Change subject: BZ#856167 - Parse correctly the management_server parameter
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit
Alon Bar-Lev has posted comments on this change.
Change subject: BZ#856167 - Validate downloaded SSH public key
..
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
Alon Bar-Lev has posted comments on this change.
Change subject: BZ#856167 - Validate downloaded CA certificate
..
Patch Set 4:
Juan,
See[1].
In any update of production file, I prefer to to write it with $FILE.suffix,
then
ShaoHe Feng has posted comments on this change.
Change subject: [WIP] Initial live storage migration implementation
..
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
new APIs are added, and these
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#856167 - Parse correctly the management_server parameter
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..
Patch Set 2: (1 inline comment)
File vdsm_reg/vdsm-upgrade
Juan Hernandez has posted comments on this change.
Change subject: BZ#856167 - Validate downloaded CA certificate
..
Patch Set 4:
I understand, but this patch doesn't change how the file is written, so I think
that
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#856167 - Parse correctly the management_server parameter
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8022
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#856167 - Parse correctly the management_server parameter
..
BZ#856167 - Parse correctly the management_server parameter
When doing automatic
Alon Bar-Lev has posted comments on this change.
Change subject: BZ#856167 - Validate downloaded CA certificate
..
Patch Set 4: Looks good to me, but someone else must approve
Fair enough, although if you wrote a file, the
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#856167 - Validate downloaded SSH public key
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit
Juan Hernandez has uploaded a new change for review.
Change subject: BZ#856167 - Store engine CA cert in enginecacert.pem
..
BZ#856167 - Store engine CA cert in enginecacert.pem
Currently we store the CA certificate downloaded
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#856167 - Validate downloaded CA certificate
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Logging shouldn't reach the terminal console
..
Patch Set 1: I would prefer that you didn't submit this
Following federico -1... to avoid showing
ShaoHe Feng has posted comments on this change.
Change subject: add verb for vdsm to tuneCpu params
..
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
Alon Bar-Lev has posted comments on this change.
Change subject: BZ#856167 - Store engine CA cert in enginecacert.pem
..
Patch Set 2: Looks good to me, but someone else must approve
Minor note... I would have called this REGCA
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#856167 - Store engine CA cert in enginecacert.pem
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
ShaoHe Feng has posted comments on this change.
Change subject: [WIP]add mem cgroup support to vdsm
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
ShaoHe Feng has posted comments on this change.
Change subject: fix dataProgress of migration
..
Patch Set 3:
surely, Zhengsheng.
I use the libvirt dom coreDump API to do the migration without copy of disk.
then get job info
ShaoHe Feng has posted comments on this change.
Change subject: fix dataProgress of migration
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/7914
To unsubscribe, visit http://gerrit.ovirt.org/settings
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..
Patch Set 3: (2 inline comments)
Thanks!
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..
Patch Set 3: (2 inline comments)
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..
Patch Set 3: (1 inline comment)
File
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..
Patch Set 3: (1 inline comment)
File vdsm_reg/vdsm-upgrade
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/8029
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8029
To
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#856167 - Validate downloaded CA certificate
..
Patch Set 4: (4 inline comments)
minor comments, and one annoying assertion about fingerprints.
Alon Bar-Lev has posted comments on this change.
Change subject: BZ#856167 - Validate downloaded CA certificate
..
Patch Set 4: (1 inline comment)
Commit Message
Line 3:
Alon Bar-Lev has uploaded a new change for review.
Change subject: bootstrap: use yum API
..
bootstrap: use yum API
PREVIOUS IMPLEMENTATION
Use of yum command-line to automate package installation.
Install package almost one
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: use yum API
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8039
To unsubscribe, visit http://gerrit.ovirt.org/settings
Jarod.w has abandoned this change.
Change subject: add logrotate libvirt.qemu into vdsm-libvirt-logrotate
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/6267
To unsubscribe, visit
Mark Wu has posted comments on this change.
Change subject: Logging shouldn't reach the terminal console
..
Patch Set 1:
Federico,
Is it related to the python logging bug reported in
Zhou Zheng Sheng has posted comments on this change.
Change subject: Fix some PEP8 violations in vm.py so the pep8 tool would stop
complaining
..
Patch Set 3: I would prefer that you didn't submit this
(4 inline comments)
Mark Wu has posted comments on this change.
Change subject: Skip setting up network if no change is found.
..
Patch Set 3:
Antoni,
I have fixed all the problems you commented. Thank you very much for the review!
--
To view,
Zhou Zheng Sheng has posted comments on this change.
Change subject: move get-conf-item/set-conf-item to vdsm-tool
..
Patch Set 2: (3 inline comments)
Looks fine, but please explain my questions first.
Zhou Zheng Sheng has posted comments on this change.
Change subject: move get-conf-item/set-conf-item to vdsm-tool
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
Zhou Zheng Sheng has posted comments on this change.
Change subject: Remove REST bindings
..
Patch Set 1: I would prefer that you didn't submit this
Please also remove 'rest' from SUBDIRS in vdsm/Makefile.am.
--
To view,
61 matches
Mail list logo
