Change in vdsm[master]: gluster: raise suitable exception based on errno for peerDetach

2013-12-11 Thread barumuga
Bala.FA has posted comments on this change. Change subject: gluster: raise suitable exception based on errno for peerDetach .. Patch Set 3: Code-Review-1 (1 comment) File

Change in vdsm[master]: gluster: raise suitable exception based on errno for peerDetach

2013-12-11 Thread barumuga
Bala.FA has posted comments on this change. Change subject: gluster: raise suitable exception based on errno for peerDetach .. Patch Set 3: Sorry. I noticed it later -- To view, visit http://gerrit.ovirt.org/22284 To

Change in vdsm[master]: gluster: raise suitable exception based on errno for peerDetach

2013-12-11 Thread dnarayan
Darshan N has posted comments on this change. Change subject: gluster: raise suitable exception based on errno for peerDetach .. Patch Set 3: (1 comment) File

Change in vdsm[master]: gluster: raise suitable exception based on errno for peerDetach

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: raise suitable exception based on errno for peerDetach .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6021/

Change in vdsm[master]: gluster: raise suitable exception based on errno for peerDetach

2013-12-11 Thread dnarayan
Darshan N has posted comments on this change. Change subject: gluster: raise suitable exception based on errno for peerDetach .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/22284 To unsubscribe, visit

Change in vdsm[master]: gluster: raise suitable exception based on errno for peerDetach

2013-12-11 Thread barumuga
Bala.FA has posted comments on this change. Change subject: gluster: raise suitable exception based on errno for peerDetach .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22284 To unsubscribe, visit

Change in vdsm[master]: gluster: raise suitable exception based on errno for peerDetach

2013-12-11 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster: raise suitable exception based on errno for peerDetach .. gluster: raise suitable exception based on errno for peerDetach Raising suitable

Change in vdsm[master]: gluster: raise suitable exception based on errno for peerDetach

2013-12-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: gluster: raise suitable exception based on errno for peerDetach .. Patch Set 4: Code-Review+2 Escalating Gala's score. -- To view, visit

Change in vdsm[ovirt-3.3]: threadPool: Do not keep reference to tasks

2013-12-11 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: threadPool: Do not keep reference to tasks .. threadPool: Do not keep reference to tasks Worker thread was taking a task from the threadpool queue,

Change in vdsm[ovirt-3.3]: threadPool: Do not keep reference to tasks

2013-12-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: threadPool: Do not keep reference to tasks .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22208 To unsubscribe, visit

Change in vdsm[ovirt-3.3]: domainMonitor: Separate change detection from lastCheck value

2013-12-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: domainMonitor: Separate change detection from lastCheck value .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22209 To

Change in vdsm[ovirt-3.3]: domainMonitor: Separate change detection from lastCheck value

2013-12-11 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: domainMonitor: Separate change detection from lastCheck value .. domainMonitor: Separate change detection from lastCheck value Since commit

Change in vdsm[ovirt-3.3]: hsm: Log unhandled exceptions in storage refresh thread

2013-12-11 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: hsm: Log unhandled exceptions in storage refresh thread .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22213 To unsubscribe, visit

Change in vdsm[ovirt-3.3]: domainMonitor: Log unhandled exceptions in domain monitor th...

2013-12-11 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: domainMonitor: Log unhandled exceptions in domain monitor thread .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22214 To unsubscribe,

Change in vdsm[master]: Changed BrokerLink log level to prevent log flooding

2013-12-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Changed BrokerLink log level to prevent log flooding .. Patch Set 3: I still find it quite awkward that Vdsm needs to know about the particular logger of a

Change in vdsm[master]: netconfpersistence: add diffing method to Config

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconfpersistence: add diffing method to Config .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6022/ : SUCCESS

Change in vdsm[master]: netconf: provide a default rollback for configurators

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconf: provide a default rollback for configurators .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6024/ :

Change in vdsm[master]: netconf: define rollback contract at internal API

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconf: define rollback contract at internal API .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6023/ : SUCCESS

Change in vdsm[master]: netconf: Add config option for network configurator

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconf: Add config option for network configurator .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6025/ : SUCCESS

Change in vdsm[master]: Add iproute2 configurator

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add iproute2 configurator .. Patch Set 22: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6026/ : SUCCESS

Change in vdsm[master]: netconf: define rollback contract at internal API

2013-12-11 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: netconf: define rollback contract at internal API .. Patch Set 13: Verified+1 Functional tests pass for ifcf configurator and persistence. They also

Change in vdsm[master]: netconf: provide a default rollback for configurators

2013-12-11 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: netconf: provide a default rollback for configurators .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.ovirt.org/21739 To unsubscribe,

Change in vdsm[master]: netconfpersistence: add diffing method to Config

2013-12-11 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: netconfpersistence: add diffing method to Config .. Patch Set 13: Verified+1 Code-Review-1 Works, but should apply danken's comments. -- To view,

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-11 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: ifcfg: include HWADDR line only if NM is around .. ifcfg: include HWADDR line only if NM is around In prehistoric days, our ifcfg files included HWADDR lines

Change in vdsm[master]: Changed BrokerLink log level to prevent log flooding

2013-12-11 Thread jmoskovc
Jiří Moskovčák has posted comments on this change. Change subject: Changed BrokerLink log level to prevent log flooding .. Patch Set 3: Yes, being able to set the logging level for the whole module makes more sense, although

Change in vdsm[ovirt-3.3]: utils: Add unhandled exceptions logging decorator

2013-12-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: utils: Add unhandled exceptions logging decorator .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22212 To unsubscribe, visit

Change in vdsm[ovirt-3.3]: utils: Add unhandled exceptions logging decorator

2013-12-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: utils: Add unhandled exceptions logging decorator .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/22212 To unsubscribe, visit

Change in vdsm[ovirt-3.3]: utils: Add unhandled exceptions logging decorator

2013-12-11 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: utils: Add unhandled exceptions logging decorator .. utils: Add unhandled exceptions logging decorator We have at least two places where exceptions in

Change in vdsm[ovirt-3.3]: domainMonitor: Log unhandled exceptions in domain monitor th...

2013-12-11 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: domainMonitor: Log unhandled exceptions in domain monitor thread .. domainMonitor: Log unhandled exceptions in domain monitor thread

Change in vdsm[ovirt-3.3]: domainMonitor: Log unhandled exceptions in domain monitor th...

2013-12-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: domainMonitor: Log unhandled exceptions in domain monitor thread .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22214 To

Change in vdsm[ovirt-3.3]: hsm: Log unhandled exceptions in storage refresh thread

2013-12-11 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: hsm: Log unhandled exceptions in storage refresh thread .. hsm: Log unhandled exceptions in storage refresh thread hsm's storage refresh background

Change in vdsm[ovirt-3.3]: hsm: Log unhandled exceptions in storage refresh thread

2013-12-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: hsm: Log unhandled exceptions in storage refresh thread .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22213 To

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6027/ :

Change in vdsm[master]: tests: validate cdrom path sent to/received from vdsm

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: validate cdrom path sent to/received from vdsm .. Patch Set 1: -Verified Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6028/

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-11 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 1: (1 comment) File

Change in vdsm[master]: netconfpersistence: add diffing method to Config

2013-12-11 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: netconfpersistence: add diffing method to Config .. Patch Set 14: Verified+1 Passed the new unit tests. -- To view, visit

Change in vdsm[master]: netconfpersistence: add diffing method to Config

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconfpersistence: add diffing method to Config .. Patch Set 14: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: netconfpersistence: add diffing method to Config

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconfpersistence: add diffing method to Config .. Patch Set 15: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6030/ :

Change in vdsm[master]: netconfpersistence: add diffing method to Config

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconfpersistence: add diffing method to Config .. Patch Set 15: Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6030/ : SUCCESS

Change in vdsm[master]: vdsm: Report fake capabilities

2013-12-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: Report fake capabilities .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19396 To unsubscribe, visit

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-11 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 1: Code-Review-1 I think it belongs in the netconf package. -- To view, visit

Change in vdsm[master]: netconfpersistence: add diffing method to Config

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconfpersistence: add diffing method to Config .. Patch Set 15: -Verified Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6030/ :

Change in vdsm[master]: netconfpersistence: add diffing method to Config

2013-12-11 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: netconfpersistence: add diffing method to Config .. Patch Set 15: Verified+1 Passes the unit tests just fine. -- To view, visit

Change in vdsm[master]: syncproc: Add blocking mode.

2013-12-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: syncproc: Add blocking mode. .. Patch Set 9: Code-Review+1 please verify and add uts for the blocking variable if possible -- To view, visit

Change in vdsm[master]: asyncproc: Return None when no data could be read

2013-12-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: asyncproc: Return None when no data could be read .. Patch Set 2: Code-Review+1 uts? When I'll add more spare time I add myself. but if you want to push it

Change in vdsm[master]: Run pinger in separate process

2013-12-11 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: Run pinger in separate process .. Run pinger in separate process Running pinger in a separate process should be less fragile, as the pinger thread cannot be

Change in vdsm[master]: vm: Do not assume drive's iface attribute exists

2013-12-11 Thread ykaplan
Yeela Kaplan has abandoned this change. Change subject: vm: Do not assume drive's iface attribute exists .. Abandoned -- To view, visit http://gerrit.ovirt.org/21939 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: Run pinger in separate process

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Run pinger in separate process .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6031/ : SUCCESS

Change in vdsm[master]: netconf: define rollback contract at internal API

2013-12-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netconf: define rollback contract at internal API .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21702 To unsubscribe, visit

Change in vdsm[master]: netconf: define rollback contract at internal API

2013-12-11 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: netconf: define rollback contract at internal API .. netconf: define rollback contract at internal API This patch defines the contract Configurator

Change in vdsm[master]: netconfpersistence: add diffing method to Config

2013-12-11 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: netconfpersistence: add diffing method to Config .. netconfpersistence: add diffing method to Config This patch makes it easy to diff two network

Change in vdsm[master]: netconfpersistence: add diffing method to Config

2013-12-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netconfpersistence: add diffing method to Config .. Patch Set 15: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21728 To unsubscribe, visit

Change in vdsm[master]: netconf: provide a default rollback for configurators

2013-12-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netconf: provide a default rollback for configurators .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21739 To unsubscribe, visit

Change in vdsm[master]: netconf: provide a default rollback for configurators

2013-12-11 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: netconf: provide a default rollback for configurators .. netconf: provide a default rollback for configurators This patch adds a default rollback

Change in vdsm[master]: Run pinger in separate process

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Run pinger in separate process .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6032/ : SUCCESS

Change in vdsm[master]: Run pinger in separate process

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Run pinger in separate process .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6032/ : SUCCESS

Change in vdsm[master]: Run pinger in separate process

2013-12-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Run pinger in separate process .. Patch Set 2: (2 comments) File tests/functional/ping.py Line 1: import

Change in vdsm[master]: Run pinger in separate process

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Run pinger in separate process .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6033/ : SUCCESS

Change in vdsm[master]: vdsm: Create VMs for the POWER architecture

2013-12-11 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: vdsm: Create VMs for the POWER architecture .. Patch Set 7: Code-Review-1 (1 comment) Beside my comment to vm.py please add unit tests for the new

Change in vdsm[master]: vdsm: prepareVolumePath correct path handling for cdrom

2013-12-11 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: prepareVolumePath correct path handling for cdrom .. vdsm: prepareVolumePath correct path handling for cdrom prepareVolumePath looked for 'path'

Change in vdsm[master]: vdsm: prepareVolumePath correct path handling for cdrom

2013-12-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: prepareVolumePath correct path handling for cdrom .. Patch Set 6: Code-Review+2 thanks, I'll review the test later. -- To view, visit

Change in vdsm[master]: syncproc: Add blocking mode.

2013-12-11 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: syncproc: Add blocking mode. .. Patch Set 9: Verified+1 Code-Review+1 verified in ipython: In [1]: from vdsm.utils import execCmd In [2]: p =

Change in vdsm[master]: asyncproc: Return None when no data could be read

2013-12-11 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: asyncproc: Return None when no data could be read .. Patch Set 2: Verified+1 Verified the tip of the branch. -- To view, visit

Change in vdsm[master]: asyncproc: Removed the close count.

2013-12-11 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: asyncproc: Removed the close count. .. Patch Set 3: Verified+1 Verified the tip of the branch to work in the optional sync mode. -- To view, visit

Change in vdsm[master]: Run pinger in separate process

2013-12-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Run pinger in separate process .. Patch Set 2: (2 comments) File tests/functional/ping.py Line 1: import time

Change in vdsm[master]: Run pinger in separate process

2013-12-11 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Run pinger in separate process .. Patch Set 2: (1 comment) File tests/functional/ping.py Line 1:

Change in vdsm[master]: Run pinger in separate process

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Run pinger in separate process .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6034/ : SUCCESS

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 1: Toni, what belongs to netconf.__init__? _nm_around? What would is its usage for something

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-11 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 1: Not in netconf/__init__, just that vdsm/nm.py should be vdsm/netconf/nm.py as it is

Change in vdsm[master]: Testing pinger thread

2013-12-11 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: Testing pinger thread .. Testing pinger thread Add a comment to trigger networking functional tests. Change-Id: I0ef69ea9b125f0d0af2e46b94690950a14d4c4f9

Change in vdsm[master]: Testing pinger thread

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Testing pinger thread .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6035/ : SUCCESS

Change in vdsm[master]: asyncproc: Return None when no data could be read

2013-12-11 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: asyncproc: Return None when no data could be read .. asyncproc: Return None when no data could be read According to

Change in vdsm[master]: asyncproc: Removed the close count.

2013-12-11 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: asyncproc: Removed the close count. .. asyncproc: Removed the close count. When I originally wrote the class I assumed that since the process side FD

Change in vdsm[master]: syncproc: Add blocking mode.

2013-12-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: syncproc: Add blocking mode. .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21897 To unsubscribe, visit

Change in vdsm[master]: syncproc: Add blocking mode.

2013-12-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: syncproc: Add blocking mode. .. Patch Set 9: (1 comment) File lib/vdsm/utils.py Line 345:

Change in vdsm[master]: syncproc: Add blocking mode.

2013-12-11 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: syncproc: Add blocking mode. .. syncproc: Add blocking mode. By setting `proc.blocking = True` it will make reading and writing move to blocking mode.

Change in vdsm[master]: ksm: janitorial: with construct, file() to open()

2013-12-11 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: ksm: janitorial: with construct, file() to open() .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22084 To unsubscribe, visit

Change in vdsm[master]: utils: janitorial: refactor utils.readMemInfo

2013-12-11 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: utils: janitorial: refactor utils.readMemInfo .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22041 To unsubscribe, visit

Change in vdsm[master]: clientIF: Check device visibility on failed hotplugDisk

2013-12-11 Thread abaron
Ayal Baron has posted comments on this change. Change subject: clientIF: Check device visibility on failed hotplugDisk .. Patch Set 4: (1 comment) File vdsm/clientIF.py

Change in vdsm[master]: linkmonitor: fix reported device name of vlans and macvlans

2013-12-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: linkmonitor: fix reported device name of vlans and macvlans .. Patch Set 10: Code-Review-1 (4 comments)

Change in vdsm[master]: link monitor: Reuse Link parsing

2013-12-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: link monitor: Reuse Link parsing .. Patch Set 5: Code-Review+1 (1 comment) Commit Message Line 9: 'ip -d

Change in vdsm[master]: add createVm support of cputune

2013-12-11 Thread iheim
Itamar Heim has posted comments on this change. Change subject: add createVm support of cputune .. Patch Set 9: what's needed to get closure onthis? -- To view, visit http://gerrit.ovirt.org/8445 To unsubscribe, visit

Change in vdsm[master]: add emulator pin support to create vm

2013-12-11 Thread iheim
Itamar Heim has posted comments on this change. Change subject: add emulator pin support to create vm .. Patch Set 12: no comment for 30 days - should be abandoned? -- To view, visit http://gerrit.ovirt.org/8411 To

Change in vdsm[master]: add verb for vdsm to tuneCpu params

2013-12-11 Thread iheim
Itamar Heim has posted comments on this change. Change subject: add verb for vdsm to tuneCpu params .. Patch Set 8: no comment - should this be abandoned? -- To view, visit http://gerrit.ovirt.org/7492 To unsubscribe, visit

Change in vdsm[master]: add xmlrpcTests for cpu pinning

2013-12-11 Thread iheim
Itamar Heim has posted comments on this change. Change subject: add xmlrpcTests for cpu pinning .. Patch Set 6: so, should be abandoned? -- To view, visit http://gerrit.ovirt.org/8412 To unsubscribe, visit

Change in vdsm[master]: avoid race between load dev rules and trigger the rule

2013-12-11 Thread iheim
Itamar Heim has posted comments on this change. Change subject: avoid race between load dev rules and trigger the rule .. Patch Set 5: no reply for 30 days post last pojt -- To view, visit http://gerrit.ovirt.org/6780 To

Change in vdsm[master]: Encapsulate vdsm-unregister into vdsm-tool function

2013-12-11 Thread iheim
Itamar Heim has posted comments on this change. Change subject: Encapsulate vdsm-unregister into vdsm-tool function .. Patch Set 1: should this be abandoned? -- To view, visit http://gerrit.ovirt.org/4527 To unsubscribe,

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6036/ : SUCCESS

Change in vdsm[master]: add xmlrpcTests for cpu pinning

2013-12-11 Thread mpoledni
Martin Polednik has posted comments on this change. Change subject: add xmlrpcTests for cpu pinning .. Patch Set 6: This patch in its current form without rebase and a bit of work wouldn't test anything: we would only see if

Change in vdsm[master]: ifcfg: include HWADDR line only if NM is around

2013-12-11 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: ifcfg: include HWADDR line only if NM is around .. Patch Set 2: Code-Review+1 Thanks for the change Dan! -- To view, visit

Change in vdsm[master]: Don't reconfigure if configured when force is set

2013-12-11 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review. Change subject: Don't reconfigure if configured when force is set .. Don't reconfigure if configured when force is set There is no need for that. We kept the old --force way

Change in vdsm[master]: Don't reconfigure if configured when force is set

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Don't reconfigure if configured when force is set .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6037/ : SUCCESS

Change in vdsm[ovirt-3.3]: Fix syntax error

2013-12-11 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review. Change subject: Fix syntax error .. Fix syntax error Change-Id: Ib636c00a6b9670584b5a862ac4496e74915fbe04 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Bug-Url:

Change in vdsm[ovirt-3.3]: Fix syntax error

2013-12-11 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Fix syntax error .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/22310 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[ovirt-3.3]: Fix syntax error

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix syntax error .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/326/ : SUCCESS -- To view, visit

Change in vdsm[master]: Don't reconfigure if configured when force is set

2013-12-11 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Don't reconfigure if configured when force is set .. Patch Set 1: this is one confusing commit message! anyway, the reason to do --force and overwrite

Change in vdsm[ovirt-3.3]: Fix syntax error

2013-12-11 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Fix syntax error .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22310 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: linkmonitor: fix reported device name of vlans and macvlans

2013-12-11 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: linkmonitor: fix reported device name of vlans and macvlans .. Patch Set 10: (4 comments) File

Change in vdsm[master]: linkmonitor: fix reported device name of vlans and macvlans

2013-12-11 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: linkmonitor: fix reported device name of vlans and macvlans .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.ovirt.org/22061 To

Change in vdsm[master]: linkmonitor: fix reported device name of vlans and macvlans

2013-12-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: linkmonitor: fix reported device name of vlans and macvlans .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6038/ :

  1   2   >