Francesco Romani has posted comments on this change.
Change subject: pep8: silence several errors with no syntactical change
..
Patch Set 2: Code-Review+1
looks like only the commit message was changed, gitpydiff is happy and
Francesco Romani has posted comments on this change.
Change subject: vdsm: [wip] modeling graphics as a device
..
Patch Set 8:
(10 comments)
Initial review
http://gerrit.ovirt.org/#/c/23555/8/tests/vmTests.py
File
Francesco Romani has posted comments on this change.
Change subject: Refactor VM._guestSockCleanup into utils.rmFileAndLink
..
Patch Set 2:
Looks ok but please add an automated test for this.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 5: Code-Review-1
Inspection on the engine side confirms the need for more investigation to avoid
Dima Kuznetsov has uploaded a new change for review.
Change subject: hooks: Add convenience functions for JSON hooks
..
hooks: Add convenience functions for JSON hooks
Added read_json/write_json, similar in fashion to existing
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hooks: Add convenience functions for JSON hooks
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7885/ :
Dima Kuznetsov has abandoned this change.
Change subject: utils: Change cpopen import
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/26204
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType:
Francesco Romani has posted comments on this change.
Change subject: vm: handle missing domains on recovery
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/25275/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1935:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: handle missing domains on recovery
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7887/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: recovery: try to restore VMs from recovery files
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7888/ :
Dima Kuznetsov has posted comments on this change.
Change subject: hooks: Add convenience functions for JSON hooks
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/26521
To unsubscribe, visit
Saggi Mizrahi has abandoned this change.
Change subject: [WIP] Continue moving VM code to it's own module
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/7514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Saggi Mizrahi has abandoned this change.
Change subject: svdsm: Remove superfluous unlinks
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/11989
To unsubscribe, visit http://gerrit.ovirt.org/settings
Saggi Mizrahi has abandoned this change.
Change subject: [WIP] Add new repository management code
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/6247
To unsubscribe, visit http://gerrit.ovirt.org/settings
Saggi Mizrahi has abandoned this change.
Change subject: Add create operation to qemu-img
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/6245
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType:
Nir Soffer has posted comments on this change.
Change subject: profiling: Add an application wide profile
..
Patch Set 6:
After talking with Saggi, we agreed to:
- Move profiling logic to separate module under
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Refactor VM._guestSockCleanup into utils.rmFileAndLink
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7890/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: agent: number-of-cpus reporting support
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7891/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: Explicitly close libvirt connections at exist
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17192
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: agent: Add new command setNumberOfCPUs(count)
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7892/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fileSD: enable mailbox on file domains
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7893/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sd: improve metadata sizes definition
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7894/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fileSD: unify the metadata permissions definition
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7895/ :
Dan Kenigsberg has uploaded a new change for review.
Change subject: call stop_event_loop upon exit
..
call stop_event_loop upon exit
For cleanliness, whomever starts a thread should stop it when it is no
longer needed.
Dan Kenigsberg has posted comments on this change.
Change subject: Explicitly close libvirt connections at exist
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/17192/3/lib/vdsm/libvirtconnection.py
File
Federico Simoncelli has abandoned this change.
Change subject: vm: improve extension check in extendDrivesIfNeeded
..
Abandoned
Almost entirely replaced by http://gerrit.ovirt.org/21150
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: call stop_event_loop upon exit
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7896/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: pep8: silence several errors with no syntactical change
..
Patch Set 2:
Actually, I also dropped a piece of code change (vdsm/dmidecodeUtil.py) that
failed on
Vinzenz Feenstra has abandoned this change.
Change subject: guest: Add support for guest cpu topology
..
Abandoned
Superseded by http://gerrit.ovirt.org/26530
--
To view, visit http://gerrit.ovirt.org/23258
To unsubscribe,
Vinzenz Feenstra has abandoned this change.
Change subject: guestIF: Adding support for setting vcpus online/offline
..
Abandoned
Superseded by http://gerrit.ovirt.org/26531
--
To view, visit http://gerrit.ovirt.org/25377
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: agent: Add new command setNumberOfCPUs(count)
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7897/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: agent: number-of-cpus reporting support
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7898/ : SUCCESS
Francesco Romani has uploaded a new change for review.
Change subject: tests: virt: add infrastructure to test getStats
..
tests: virt: add infrastructure to test getStats
This patch adds the initial infrastructure and the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: virt: add infrastructure to test getStats
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7899/ :
Vinzenz Feenstra has posted comments on this change.
Change subject: tests: virt: add infrastructure to test getStats
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/26536/1/tests/vmTests.py
File
Vinzenz Feenstra has posted comments on this change.
Change subject: tests: virt: add infrastructure to test getStats
..
Patch Set 1:
Beside the wrong value type for the guestFQDN. It looks good to me
--
To view, visit
Michal Skrivanek has posted comments on this change.
Change subject: pad memory volume only when the storage domain is file based
..
Patch Set 3: -Code-Review
(1 comment)
http://gerrit.ovirt.org/#/c/26407/3/vdsm/virt/vm.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: User libnl-3 when available
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7900/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: netlink: User libnl-3 when available
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26514
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: netlink: User libnl-3 when available
..
Patch Set 2: -Code-Review Verified+1
I meant v+1, not r+1 :P
--
To view, visit http://gerrit.ovirt.org/26514
Francesco Romani has posted comments on this change.
Change subject: tests: virt: add infrastructure to test getStats
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26536/1/tests/vmTests.py
File tests/vmTests.py:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: virt: add infrastructure to test getStats
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7901/ :
Arik Hadas has uploaded a new change for review.
Change subject: do not use OOP for padding snapshot's memory volume
..
do not use OOP for padding snapshot's memory volume
Change-Id: I2a94354e188019f3afd209633979ec5a5b35293b
Francesco Romani has uploaded a new change for review.
Change subject: vm: fix _dom access when QEMU is dying
..
vm: fix _dom access when QEMU is dying
commit 8fedf8bde3c28edb07add23c3e9b72681cb48e49 introduced a tiny
window
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: [wip] modeling graphics as a device
..
Patch Set 8:
(11 comments)
http://gerrit.ovirt.org/#/c/23555/8/vdsm/API.py
File vdsm/API.py:
Line 253:
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: do not use OOP for padding snapshot's memory volume
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7902/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: fix _dom access when QEMU is dying
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7903/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 28:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7904/ :
Sandro Bonazzola has uploaded a new change for review.
Change subject: nit: remove duplicate command
..
nit: remove duplicate command
Change-Id: I29eda5849f37f9844df6d648c38a5b8049dd1b9a
Signed-off-by: Sandro Bonazzola
Sandro Bonazzola has uploaded a new change for review.
Change subject: packaging: add vdsm user to cdrom group
..
packaging: add vdsm user to cdrom group
Allow to boot VMs from host CD-ROM.
Change-Id:
Sandro Bonazzola has posted comments on this change.
Change subject: nit: remove duplicate command
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/26540
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: nit: remove duplicate command
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7905/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: nit: remove duplicate command
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26540
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: packaging: add vdsm user to cdrom group
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/26541/1/debian/vdsm.postinst
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: packaging: add vdsm user to cdrom group
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/26541/1/vdsm.spec.in
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: packaging: add vdsm user to cdrom group
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26541/1/vdsm.spec.in
File vdsm.spec.in:
Line 689:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: packaging: add vdsm user to cdrom group
..
Patch Set 1:
-1 from dan's comment only
--
To view, visit http://gerrit.ovirt.org/26541
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: nit: remove duplicate command
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26540
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
..
Patch Set 29:
Build Successful
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: add vdsm user to cdrom group
..
Patch Set 1: Verified-1
It fails anyway:
could not open disk image /dev/sr0: Permission denied
command executed
Francesco Romani has posted comments on this change.
Change subject: tests: virt: add infrastructure to test getStats
..
Patch Set 2: Verified+1
runs OK with current code
--
To view, visit http://gerrit.ovirt.org/26536
To
Arik Hadas has posted comments on this change.
Change subject: pad memory volume only when the storage domain is file based
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/26407/3/vdsm/virt/vm.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: always teardown snapshot's memory volume
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7908/ : SUCCESS
Allon Mureinik has posted comments on this change.
Change subject: hsm: refresh pool connection on connectStoragePool
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/26349/1//COMMIT_MSG
Commit Message:
Francesco Romani has posted comments on this change.
Change subject: caps: report if QEMU supports live snapshots
..
Patch Set 6:
support included in libvirt 1.2.3 which is available for fedora 20 through the
virt-preview
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: add vdsm user to cdrom group
..
Patch Set 2: Verified+1
Verified on F19.
--
To view, visit http://gerrit.ovirt.org/26541
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: packaging: allow to boot VMs from host CD-ROM
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26541
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: vm: fix _dom access when QEMU is dying
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26539
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: fix _dom access when QEMU is dying
..
Patch Set 1:
This is just a quick (and indeed, quite ugly) local fix until the statistics
handling is properly
Nir Soffer has posted comments on this change.
Change subject: netlink: User libnl-3 when available
..
Patch Set 2:
(7 comments)
http://gerrit.ovirt.org/#/c/26514/2//COMMIT_MSG
Commit Message:
Line 10: libnl3 while vdsm was
Federico Simoncelli has posted comments on this change.
Change subject: pad memory volume only when the storage domain is file based
..
Patch Set 3: Code-Review+1
Ok for me since we now have two other patches to address the
Dan Kenigsberg has posted comments on this change.
Change subject: sd: improve metadata sizes definition
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26412
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: fileSD: unify the metadata permissions definition
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26413
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: do not use OOP for padding snapshot's memory volume
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26538/1//COMMIT_MSG
Commit Message:
Line 3:
Michal Skrivanek has posted comments on this change.
Change subject: do not use OOP for padding snapshot's memory volume
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26538/1//COMMIT_MSG
Commit Message:
Line 3:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 11:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/460/ :
FAILURE
Francesco Romani has uploaded a new change for review.
Change subject: virt: stats: move last fields the static group
..
virt: stats: move last fields the static group
WRITEME
Change-Id:
Francesco Romani has uploaded a new change for review.
Change subject: virt: stats: move dynamic stats in a method
..
virt: stats: move dynamic stats in a method
this patch moves the handling of the stats coming
from the
Francesco Romani has uploaded a new change for review.
Change subject: virt: stats: move exited vm stats in a method
..
virt: stats: move exited vm stats in a method
this patch moves the ExitedVmStats handling in
a separate
Francesco Romani has uploaded a new change for review.
Change subject: virt: stats: move vm status detection in a method
..
virt: stats: move vm status detection in a method
this patch moves the detection of the status of a VM
Francesco Romani has uploaded a new change for review.
Change subject: virt: move stats fields in their method
..
virt: move stats fields in their method
this patch moves together the core basic VM stats in the appropriate
Francesco Romani has uploaded a new change for review.
Change subject: virt: stats: get rid of _getStatsInternal
..
virt: stats: get rid of _getStatsInternal
it was used on just one place anyway.
Change-Id:
Francesco Romani has uploaded a new change for review.
Change subject: virt: stats: move the guest stats in a method
..
virt: stats: move the guest stats in a method
this patch moves the guest statistics gathering in
a separate
Francesco Romani has uploaded a new change for review.
Change subject: virt: stats: simplify the exception flow
..
virt: stats: simplify the exception flow
with the content reporting in place, this patch
simplifies the
Francesco Romani has uploaded a new change for review.
Change subject: virt: stats: move core static stats in a method
..
virt: stats: move core static stats in a method
this patch moves the basic core VM statistics
in a
Francesco Romani has uploaded a new change for review.
Change subject: virt: stats: simplify the getStatsInternal flow
..
virt: stats: simplify the getStatsInternal flow
this patch simplifies the flow in getStatsInternal
to
Francesco Romani has uploaded a new change for review.
Change subject: virt: stats: move migration stats in a method
..
virt: stats: move migration stats in a method
this patch moves the migration statistics fields
in a
Francesco Romani has uploaded a new change for review.
Change subject: virt: stats: move balloon info in a method
..
virt: stats: move balloon info in a method
this patch moves the balloon info gathering
in a separate method,
Francesco Romani has uploaded a new change for review.
Change subject: virt: stats: report partial content in stats
..
virt: stats: report partial content in stats
this patch adds reporting for the actual content
in the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: move vm status detection in a method
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7912/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: move exited vm stats in a method
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7911/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: move core static stats in a method
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7914/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: move dynamic stats in a method
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7913/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: move migration stats in a method
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7915/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move stats fields in their method
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7916/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: move balloon info in a method
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7918/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: simplify the getStatsInternal flow
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7917/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: move the guest stats in a method
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7919/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: report partial content in stats
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7922/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: move last fields the static group
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7921/ : SUCCESS
1 - 100 of 189 matches
Mail list logo
