Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-infra: zombie-reaper refactor
..
Patch Set 1:
(1 comment)
I don't have anything too important to comment on. lets push new version of it,
without the
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 5:
(3 comments)
http://gerrit.ovirt.org/#/c/29953/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Dan Kenigsberg has submitted this change and it was merged.
Change subject: domainMonitor: Cleanup logging
..
domainMonitor: Cleanup logging
- Use INFO level for the important state change message, and uppercase
VALID and
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: make _calcDiskRate a function
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12778/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12779/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: sampling: extract disk latency calculation
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12780/ :
Dan Kenigsberg has posted comments on this change.
Change subject: netinfotests: Do not assume the existence of
/var/lib/vdsm/bonding-defaults.json
..
Patch Set 5:
It's backport time!
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netinfotests: Do not assume the existence of
/var/lib/vdsm/bonding-defaults.json
..
netinfotests: Do not assume the existence of
oVirt Jenkins CI Server has posted comments on this change.
Change subject: domainMonitor: Cleanup logging
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4051/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfotests: Do not assume the existence of
/var/lib/vdsm/bonding-defaults.json
..
Patch Set 6:
Build Successful
Francesco Romani has posted comments on this change.
Change subject: caps: Report online logical CPUs
..
Patch Set 1:
(3 comments)
missing schema (vdsm/rpc/vdsmapi-schema.json) update?
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net: source route: don't attempt to configure invalid values
..
Patch Set 5:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Functional test for Multiple Gateways source routing
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12782/
Ondřej Svoboda has posted comments on this change.
Change subject: netinfotests: Do not assume the existence of
/var/lib/vdsm/bonding-defaults.json
..
Patch Set 2: Verified+1
Verified with the same results as in master
Hello Nir Soffer, Federico Simoncelli, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/33833
to review the following change.
Change subject: mount: fix _loopFsSpecsTimestamp global definition
Ondřej Svoboda has posted comments on this change.
Change subject: mount: fix _loopFsSpecsTimestamp global definition
..
Patch Set 1: Verified+1
The warning does not appear anymore.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: tests: move more fakes into vmfakelib
..
Patch Set 2: Verified+1
since this patch just moves code around, verified by (succesfully) running
'make check' and
Allon Mureinik has posted comments on this change.
Change subject: utils: Move functionality from storage.misc
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31583
To unsubscribe, visit
Saggi Mizrahi has posted comments on this change.
Change subject: ioprocess: Move and reword rename() warning
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/32194/2/vdsm/storage/outOfProcess.py
File
Nir Soffer has posted comments on this change.
Change subject: sslutils: Support non-blocking accept_ssl
..
Patch Set 2: Verified+1
Version 2 cleans up the SSLSocket API and the code using it. No change in
behavior.
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sslutils: Support non-blocking accept_ssl
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12783/ :
Nir Soffer has posted comments on this change.
Change subject: ioprocess: Move and reword rename() warning
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/32194/2/vdsm/storage/outOfProcess.py
File
Nir Soffer has posted comments on this change.
Change subject: mount: fix _loopFsSpecsTimestamp global definition
..
Patch Set 1:
Ondřej, can you add a bug for this?
--
To view, visit http://gerrit.ovirt.org/33833
To
Nir Soffer has posted comments on this change.
Change subject: mount: fix _loopFsSpecsTimestamp global definition
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/33833
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: Functional test for Multiple Gateways source routing
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/33612
To unsubscribe,
Yoav Kleinberger has posted comments on this change.
Change subject: volume: Log the correct error when creating a volume fails
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/33301
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29953
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/29953/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 306:
Line
Antoni Segura Puimedon has posted comments on this change.
Change subject: net: source route: don't attempt to configure invalid values
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32416
To
Antoni Segura Puimedon has posted comments on this change.
Change subject: utils: Move functionality from storage.misc
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31583
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: volume: Log the correct error when creating a volume fails
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/33301
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: volume: Log the correct error when creating a volume fails
..
volume: Log the correct error when creating a volume fails
When a volume creation failed
Ido Barkan has posted comments on this change.
Change subject: Functional test for Multiple Gateways source routing
..
Patch Set 4:
(10 comments)
http://gerrit.ovirt.org/#/c/33612/4/tests/functional/dhcp.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: volume: Log the correct error when creating a volume fails
..
Patch Set 3:
Build Failed
Saggi Mizrahi has posted comments on this change.
Change subject: sslutils: Support non-blocking accept_ssl
..
Patch Set 2: Code-Review-1
The whole point of SSLSocket is to give a socket like interface.
This makes the
Dan Kenigsberg has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 16: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 16:
Build Failed
mooli tayer has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 15: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: getExternalVmList
..
Patch Set 3: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12785/ : FAILURE
Ondřej Svoboda has posted comments on this change.
Change subject: mount: fix _loopFsSpecsTimestamp global definition
..
Patch Set 1:
Nir, is that necessary? This is just a backport of a fix merged into master
long ago.
Yaniv Bronhaim has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 16: Verified+1
--
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe,
mooli tayer has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 16: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: vdsm: introduce hostdev module
..
Patch Set 13: Code-Review-1
(7 comments)
quite good, almost there. A few minor notes inside, nothing big.
-1 for
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults
offline
..
Patch Set 1:
This patch is pending for 3.5.1
--
To view, visit
Ondřej Svoboda has posted comments on this change.
Change subject: netinfotests: Do not assume the existence of
/var/lib/vdsm/bonding-defaults.json
..
Patch Set 2: Code-Review-1
This patch is pending for 3.5.1
CR -1 is here
Dan Kenigsberg has posted comments on this change.
Change subject: protocol_acceptor: Make SSL handshake asynchronous
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/33657
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: protocol_acceptor: Make SSL handshake asynchronous
..
protocol_acceptor: Make SSL handshake asynchronous
Change-Id:
Yaniv Bronhaim has posted comments on this change.
Change subject: ioprocess: Move and reword rename() warning
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/32194/2/vdsm/storage/outOfProcess.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 16: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Signs vdsm upgraded version for special treatment if required
In ovirt-3.2 (vdsm
Hello Dima Kuznetsov, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/33854
to review the following change.
Change subject: spec: Move /lib files to /usr/lib
..
spec: Move /lib
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: Move /lib files to /usr/lib
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/80/ : SUCCESS
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: protocol_acceptor: Make SSL handshake asynchronous
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4054/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 17:
Build Successful
Francesco Romani has posted comments on this change.
Change subject: PATCH: external VMs integration
..
Patch Set 4:
(11 comments)
good start. We can improve some things.
One of the biggest problems is the lack of unit tests,
Vitor de Lima has uploaded a new change for review.
Change subject: vdsm: Additional ppc64 hardware information
..
vdsm: Additional ppc64 hardware information
Includes extra information (manufacturer and product name) about
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Additional ppc64 hardware information
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12787/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: PATCH: external VMs integration
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12786/ : SUCCESS
Hello mooli tayer, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/33858
to review the following change.
Change subject: Signs vdsm upgraded version for special treatment if required
Yaniv Bronhaim has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/33858
To unsubscribe, visit
Yeela Kaplan has uploaded a new change for review.
Change subject: Change file() to open() continued
..
Change file() to open() continued
Update file calls to open calls due to file's deprecation,
and also use with statements
Nir Soffer has posted comments on this change.
Change subject: ioprocess: Move and reword rename() warning
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/32194/2/vdsm/storage/outOfProcess.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: open: Change file() to open()
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12788/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: sslutils: Support non-blocking accept_ssl
..
Patch Set 2:
Saggi, what is the correct solution? obviously doing blocking accept is not the
correct way for a
Nir Soffer has posted comments on this change.
Change subject: mount: fix _loopFsSpecsTimestamp global definition
..
Patch Set 1:
For 3.5 we need bugs, you cannot merge code without a bug, unless this code is
needed to fix
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: default args values in wrong order
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12791/ :
Nir Soffer has posted comments on this change.
Change subject: utils: remove return redundant parenthesis
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/33690
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: task: remove unused canAbortRecover
..
Patch Set 1: Code-Review+1
Looks good, if indeed nobody uses this :-)
--
To view, visit http://gerrit.ovirt.org/33688
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: expose hostdev via vdsClient
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12793/ : SUCCESS
Martin Polednik has posted comments on this change.
Change subject: vm: sampling: use collections.deque
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/33781
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: introduce hostdev module
..
Patch Set 14:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12792/ : SUCCESS
Yeela Kaplan has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 13:
It doesn't make sense to change the use of rotateFiles to copy in a different
following
Martin Polednik has posted comments on this change.
Change subject: virt: stats: make _calcDiskRate a function
..
Patch Set 2: Code-Review+1
+! for attention: please add reviewers in order to simplify reviewing
Martin Polednik has posted comments on this change.
Change subject: virt: sampling: consolidate disk statistics
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29953
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: virt: sampling: extract disk latency calculation
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29952
To unsubscribe, visit
Nir Soffer has abandoned this change.
Change subject: sslutils: Support non-blocking accept_ssl
..
Abandoned
An alternative patch was merged:
http://gerrit.ovirt.org/33657
--
To view, visit http://gerrit.ovirt.org/33815
To
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 13:
This is not the only way to go. If Dan has a problem with rotateFiles, we can
fix it.
We
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: Report online logical CPUs
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12794/ : SUCCESS
Vitor de Lima has posted comments on this change.
Change subject: caps: Report online logical CPUs
..
Patch Set 1:
(3 comments)
http://gerrit.ovirt.org/#/c/33789/1//COMMIT_MSG
Commit Message:
Line 7: caps: Report online
Francesco Romani has posted comments on this change.
Change subject: vm: per-attribute monitor response check
..
Patch Set 11:
(2 comments)
http://gerrit.ovirt.org/#/c/23138/11/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Francesco Romani has posted comments on this change.
Change subject: vdsm: Additional ppc64 hardware information
..
Patch Set 1: Code-Review+1
(2 comments)
minor comments, please address the nit in the commit message.
Other
Francesco Romani has posted comments on this change.
Change subject: vdsm: introduce hostdev module
..
Patch Set 14: Code-Review+1
seems ok assuming Bridge.py does not needs intervention.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: caps: Report online logical CPUs
..
Patch Set 2: Code-Review+1
looks ok
--
To view, visit http://gerrit.ovirt.org/33789
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: caps: Report online logical CPUs
..
Patch Set 2:
un-draft when you want more reviews.
--
To view, visit http://gerrit.ovirt.org/33789
To unsubscribe, visit
Francesco Romani has uploaded a new change for review.
Change subject: vm: log exceptional monitor unresponsive case
..
vm: log exceptional monitor unresponsive case
In past ages we added an explicit case to mark
monitor
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: per-attribute monitor response check
..
Patch Set 12: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: log exceptional monitor unresponsive case
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12796/ :
Vitor de Lima has uploaded a new change for review.
Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64
..
vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64
Recent libvirt versions already include a
Vitor de Lima has uploaded a new change for review.
Change subject: caps: Do not use lscpu on ppc64
..
caps: Do not use lscpu on ppc64
Recent libvirt versions correctly show the topology of ppc64 hosts, so
it is not required
Nir Soffer has uploaded a new change for review.
Change subject: lvm: Fix wrong selinux label for readonly images
..
lvm: Fix wrong selinux label for readonly images
Libvirt readonly images are labeled as virt_content_t, but
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64
..
Patch Set 1:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: Do not use lscpu on ppc64
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12798/ : FAILURE
Dan Kenigsberg has posted comments on this change.
Change subject: task: remove unused canAbortRecover
..
Patch Set 1: Code-Review+2
Seems to be added by Saggi by mistake while fixing
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Fix wrong selinux label for readonly images
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12799/
Nir Soffer has posted comments on this change.
Change subject: lvm: Fix wrong selinux label for readonly images
..
Patch Set 1: Verified+1
Verified that vdsm-chcon is generated now with virt_content_t.
--
To view, visit
Nir Soffer has uploaded a new change for review.
Change subject: lvm: Cleanup lvm udev rules
..
lvm: Cleanup lvm udev rules
Make the vdsm lvm rules suck less:
- Check the vg name once, instead repating the horrible uuid
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Cleanup lvm udev rules
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12800/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: lvm: Cleanup lvm udev rules
..
Patch Set 1: Verified+1
(3 comments)
Verified on rhel6.6 and 7 that rules cleanup did not cause any regressions in
devices
Nir Soffer has posted comments on this change.
Change subject: lvm: Cleanup lvm udev rules
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/33874/1/vdsm/storage/vdsm-lvm.rules.tpl.in
File
Nir Soffer has uploaded a new change for review.
Change subject: lvm: Do not use udev to set permissions on vdsm images
..
lvm: Do not use udev to set permissions on vdsm images
udev has changed the rules recently, so setting
1 - 100 of 103 matches
Mail list logo
