Change in vdsm[master]: net: Move netconfpersistence under vdsm.network

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Move netconfpersistence under vdsm.network .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: net: Move netconfpersistence under vdsm.network

2016-05-01 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Move netconfpersistence under vdsm.network .. Patch Set 2: (7 comments) https://gerrit.ovirt.org/#/c/56677/2/lib/vdsm/netinfo/cache.py File

Change in vdsm[master]: rpc: Make Bridge#_type_fixup more robust

2016-05-01 Thread mbetak
Martin Betak has posted comments on this change. Change subject: rpc: Make Bridge#_type_fixup more robust .. Patch Set 1: (1 comment) Added a test for this in https://gerrit.ovirt.org/#/c/56884/1 but because it depends on

Change in vdsm[master]: rpc: Add test for 'int' parameters in Bridge

2016-05-01 Thread mbetak
Martin Betak has posted comments on this change. Change subject: rpc: Add test for 'int' parameters in Bridge .. Patch Set 1: Verified+1 Verified by running tests. -- To view, visit https://gerrit.ovirt.org/56884 To

Change in vdsm[master]: rpc: Make Bridge#_type_fixup more robust

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: rpc: Make Bridge#_type_fixup more robust .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migration: Enable lazy setting of incoming/outgoing limits

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: Enable lazy setting of incoming/outgoing limits .. Patch Set 28: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: rpc: Add test for 'int' parameters in Bridge

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: rpc: Add test for 'int' parameters in Bridge .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: rpc: Add test for 'int' parameters in Bridge

2016-05-01 Thread mbetak
Martin Betak has uploaded a new change for review. Change subject: rpc: Add test for 'int' parameters in Bridge .. rpc: Add test for 'int' parameters in Bridge Change-Id: Ie8a2672c53411bed1ac711fffccb543bcfb16024 Signed-off-by:

Change in vdsm[master]: blockSD: Avoid stale lvs

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: blockSD: Avoid stale lvs .. Patch Set 3: * #1331978::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1331978::OK, public bug * Check

Change in vdsm[master]: blockSD: Avoid stale lvs

2016-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: blockSD: Avoid stale lvs .. Patch Set 2: This version refines the commit message. -- To view, visit https://gerrit.ovirt.org/56876 To unsubscribe, visit

Change in vdsm[master]: blockSD: Avoid stale lvs

2016-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: blockSD: Avoid stale lvs .. Patch Set 2: (4 comments) https://gerrit.ovirt.org/#/c/56876/2//COMMIT_MSG Commit Message: Line 5: CommitDate: 2016-05-01 13:26:32

Change in vdsm[master]: Adding reportStats

2016-05-01 Thread ykaul
Yaniv Kaul has posted comments on this change. Change subject: Adding reportStats .. Patch Set 1: How do we get all stats? Somehow in an automated manner, so when we add more stats we don't need to manually add more code? --

Change in vdsm[master]: blockSD: Avoid stale lvs

2016-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: blockSD: Avoid stale lvs .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/56876/2//COMMIT_MSG Commit Message: Line 6: Line 7: blockSD: Avoid stale lvs

Change in vdsm[master]: blockSD: Avoid stale lvs

2016-05-01 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: blockSD: Avoid stale lvs .. Patch Set 2: (11 comments) https://gerrit.ovirt.org/#/c/56876/2//COMMIT_MSG Commit Message: PS2, Line 9: activate activated

Change in vdsm[ovirt-3.6]: qemuimg: Validate qcow2_compat configuration

2016-05-01 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: qemuimg: Validate qcow2_compat configuration .. qemuimg: Validate qcow2_compat configuration Validate new qcow2_compat option against a list of

Change in vdsm[ovirt-3.6]: qemuimg: Validate qcow2_compat configuration

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Validate qcow2_compat configuration .. Patch Set 2: * #1317850::Update tracker: OK * Set MODIFIED::bug 1317850#1317850OK -- To view, visit

Change in vdsm[ovirt-3.6]: qemuimg: Validate qcow2_compat configuration

2016-05-01 Thread fromani
Francesco Romani has posted comments on this change. Change subject: qemuimg: Validate qcow2_compat configuration .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56523 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: qemuimg: Make QCOW2_COMPAT configurable

2016-05-01 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: qemuimg: Make QCOW2_COMPAT configurable .. qemuimg: Make QCOW2_COMPAT configurable It's worth to make QCOW2 compatibility version configurable. It

Change in vdsm[ovirt-3.6]: qemuimg: Make QCOW2_COMPAT configurable

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Make QCOW2_COMPAT configurable .. Patch Set 2: * #1317850::Update tracker: OK * Set MODIFIED::bug 1317850#1317850IGNORE, not all related patches

Change in vdsm[ovirt-3.6]: qemuimg: Make QCOW2_COMPAT configurable

2016-05-01 Thread fromani
Francesco Romani has posted comments on this change. Change subject: qemuimg: Make QCOW2_COMPAT configurable .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56522 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: qemuimg: Validate qcow2_compat configuration

2016-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Validate qcow2_compat configuration .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/56523 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: qemuimg: Make QCOW2_COMPAT configurable

2016-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Make QCOW2_COMPAT configurable .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/56522 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: Don't prepare image with illegal volumes

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Don't prepare image with illegal volumes .. Patch Set 3: * #1332038::Update tracker: OK * Set MODIFIED::bug 1332038#1332038IGNORE, not oVirt

Change in vdsm[ovirt-3.6]: Don't prepare image with illegal volumes

2016-05-01 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: Don't prepare image with illegal volumes .. Don't prepare image with illegal volumes The irs verb 'prepareImage' is used only by clientIF when

Change in vdsm[ovirt-3.6]: Don't prepare image with illegal volumes

2016-05-01 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Don't prepare image with illegal volumes .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56881 To unsubscribe, visit

Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

2016-05-01 Thread igoihman
Irit Goihman has posted comments on this change. Change subject: Makefile: use tox to run make pep8 and pyflakes .. Patch Set 8: -Verified -- To view, visit https://gerrit.ovirt.org/49952 To unsubscribe, visit

Change in vdsm[master]: net: get network switch type from libvirt

2016-05-01 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: get network switch type from libvirt .. Patch Set 1: I agree. -- To view, visit https://gerrit.ovirt.org/56838 To unsubscribe, visit

Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

2016-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Makefile: use tox to run make pep8 and pyflakes .. Patch Set 8: Note that jenkins fail with this error: 12:19:22 if [ "1" == "1" ]; then \ 12:19:22

Change in vdsm[ovirt-3.6]: Don't prepare image with illegal volumes

2016-05-01 Thread ahino
Ala Hino has posted comments on this change. Change subject: Don't prepare image with illegal volumes .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/56881 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: Don't prepare image with illegal volumes

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Don't prepare image with illegal volumes .. Patch Set 2: * #1332038::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1332038::OK, public bug * Check

Change in vdsm[ovirt-3.6]: Don't prepare image with illegal volumes

2016-05-01 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: Don't prepare image with illegal volumes .. Patch Set 1: -Code-Review Please use this bug in the Bug-Url: https://bugzilla.redhat.com/1332038 -- To view, visit

Change in vdsm[master]: configure: add support for nosetests/python 3.5

2016-05-01 Thread edwardh
Edward Haas has posted comments on this change. Change subject: configure: add support for nosetests/python 3.5 .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/56083/3/configure.ac File configure.ac: Line 289: fi

Change in vdsm[ovirt-3.6]: Don't prepare image with illegal volumes

2016-05-01 Thread ahino
Ala Hino has posted comments on this change. Change subject: Don't prepare image with illegal volumes .. Patch Set 1: Verified-1 -1 for visibility: The code is perfect but bug Id is incorrect -- To view, visit

Change in vdsm[master]: client: do not protect requests on client side

2016-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 2: (5 comments) https://gerrit.ovirt.org/#/c/56288/2/lib/yajsonrpc/__init__.py File

Change in vdsm[master]: storagetests: add a test for normalize_local_path

2016-05-01 Thread ishaby
Idan Shaby has posted comments on this change. Change subject: storagetests: add a test for normalize_local_path .. Patch Set 10: -Verified There've been too many rebases since the last time I verified. Marking as not verified

Change in vdsm[master]: client: do not protect requests on client side

2016-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/56288/2/lib/yajsonrpc/__init__.py File

Change in vdsm[master]: net: get network switch type from libvirt

2016-05-01 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: get network switch type from libvirt .. Patch Set 1: Code-Review-1 I am not clear why libvirt DB is considered 'actual' or real time info. To me, it is not

Change in vdsm[ovirt-3.6]: Don't prepare image with illegal volumes

2016-05-01 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: Don't prepare image with illegal volumes .. Patch Set 1: Code-Review-1 Wait with the merge, we need a different Bug-Url -- To view, visit

Change in vdsm[master]: storage: streamline getting domain mountpoint

2016-05-01 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: storage: streamline getting domain mountpoint .. storage: streamline getting domain mountpoint When checking if a domain's mountpoint is mounted, the code

Change in vdsm[master]: storage: streamline getting domain mountpoint

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: streamline getting domain mountpoint .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: storage: streamline getting domain mountpoint

2016-05-01 Thread ishaby
Idan Shaby has posted comments on this change. Change subject: storage: streamline getting domain mountpoint .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/56706 To unsubscribe, visit

Change in vdsm[master]: storage: fix spec normalization when mounting

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: fix spec normalization when mounting .. Patch Set 14: * #1305529::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1305529::OK, public bug *

Change in vdsm[master]: storagetests: add a test for normalize_local_path

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storagetests: add a test for normalize_local_path .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: storage: streamline getting domain mountpoint

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: streamline getting domain mountpoint .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: hostdev: use libvirt flags to select capability

2016-05-01 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: use libvirt flags to select capability .. hostdev: use libvirt flags to select capability hostdevListByCaps (or list_by_caps in hostdev

Change in vdsm[master]: hostdev: use libvirt flags to select capability

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: use libvirt flags to select capability .. Patch Set 9: * #1270581::Update tracker: OK * Set MODIFIED::bug 1270581#1270581IGNORE, not all related

Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

2016-05-01 Thread igoihman
Irit Goihman has posted comments on this change. Change subject: Makefile: use tox to run make pep8 and pyflakes .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/49952 To unsubscribe, visit

Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Makefile: use tox to run make pep8 and pyflakes .. Patch Set 8: * #1182088::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1182088::OK, public bug *

Change in vdsm[master]: net: add virtual port to libvirt network def

2016-05-01 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: add virtual port to libvirt network def .. Patch Set 3: Code-Review-1 (3 comments)

Change in vdsm[ovirt-3.6]: Don't prepare image with illegal volumes

2016-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Don't prepare image with illegal volumes .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56881 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: Don't prepare image with illegal volumes

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Don't prepare image with illegal volumes .. Patch Set 1: * #1331572::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1331572::OK, public bug * Check

Change in vdsm[master]: net: Move netconfpersistence under vdsm.network

2016-05-01 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: Move netconfpersistence under vdsm.network .. Patch Set 2: Code-Review-1 (8 comments) boring ordering nits

Change in vdsm[ovirt-3.6]: Don't prepare image with illegal volumes

2016-05-01 Thread ahino
Ala Hino has posted comments on this change. Change subject: Don't prepare image with illegal volumes .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/56881 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: Don't prepare image with illegal volumes

2016-05-01 Thread ahino
Hello Nir Soffer, Adam Litke, Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/56881 to review the following change. Change subject: Don't prepare image with illegal volumes ..

Change in vdsm[master]: Adding reportStats

2016-05-01 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review. Change subject: Adding reportStats .. Adding reportStats Adding function that uses statsd to report internal host info. This will be called after each sampling for now.

Change in vdsm[master]: Adding reportStats

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Adding reportStats .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and

Change in vdsm[master]: Move hoststats code to host module

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Move hoststats code to host module .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: macspoof hook: README: help adding the custom property

2016-05-01 Thread edwardh
Edward Haas has posted comments on this change. Change subject: macspoof hook: README: help adding the custom property .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56015 To unsubscribe, visit

Change in vdsm[master]: net tests: Clean netinfo_test from uneeded mocks

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net tests: Clean netinfo_test from uneeded mocks .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: net tests: Clean netinfo_test from uneeded mocks

2016-05-01 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net tests: Clean netinfo_test from uneeded mocks .. net tests: Clean netinfo_test from uneeded mocks Removing mockey patches that are no longer

Change in vdsm[master]: net tests: Clean netinfo_test from uneeded mocks

2016-05-01 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net tests: Clean netinfo_test from uneeded mocks .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55898 To unsubscribe, visit

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

2016-05-01 Thread edwardh
Edward Haas has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 13: (3 comments) https://gerrit.ovirt.org/#/c/53214/13/lib/vdsm/module_loader.py

Change in vdsm[master]: v2v: small test improvement

2016-05-01 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: v2v: small test improvement .. v2v: small test improvement Change-Id: I89c46efc9836fe0f0ef680084f1921ef3948055f Signed-off-by: Tomáš Golembiovský

Change in vdsm[master]: v2v: small test improvement

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: small test improvement .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: v2v: small test improvement

2016-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: small test improvement .. Patch Set 1: OK, we will improve this later. -- To view, visit https://gerrit.ovirt.org/56694 To unsubscribe, visit

Change in vdsm[master]: net tests: Clean netinfo_test from uneeded mocks

2016-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: net tests: Clean netinfo_test from uneeded mocks .. Patch Set 4: Dan, ping -- To view, visit https://gerrit.ovirt.org/55898 To unsubscribe, visit

Change in vdsm[master]: storage: streamline getting domain mountpoint

2016-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: streamline getting domain mountpoint .. Patch Set 3: Can you verify? I want to take this first. -- To view, visit https://gerrit.ovirt.org/56706 To

Change in vdsm[master]: Move hoststats code to host module

2016-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Move hoststats code to host module .. Patch Set 1: You move here lot of code, but I don't see the deleted code in the original module -- To view, visit

Change in vdsm[master]: kvm2ovirt: tool for copying images from libvirt

2016-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: kvm2ovirt: tool for copying images from libvirt .. Patch Set 6: (16 comments) https://gerrit.ovirt.org/#/c/55797/6/helpers/kvm2ovirt File helpers/kvm2ovirt: Line

Change in vdsm[master]: lvm: Fail loudly if called with unexpected input

2016-05-01 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: lvm: Fail loudly if called with unexpected input .. Patch Set 4: Code-Review+1 But I'd prefer that this kind of validation take place much higher up, at the

Change in vdsm[master]: net tests: take2: wait for a concurrent iptables call to finish

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net tests: take2: wait for a concurrent iptables call to finish .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url

Change in vdsm[master]: net tests: take2: wait for a concurrent iptables call to finish

2016-05-01 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net tests: take2: wait for a concurrent iptables call to finish .. net tests: take2: wait for a concurrent iptables call to finish commit 9f7685f

Change in vdsm[master]: net tests: take2: wait for a concurrent iptables call to finish

2016-05-01 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net tests: take2: wait for a concurrent iptables call to finish .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56871 To unsubscribe,

Change in vdsm[master]: vdsm: changed relative imports to absolute imports

2016-05-01 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: changed relative imports to absolute imports .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56607 To unsubscribe, visit

Change in vdsm[master]: Move hoststats code to host module

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Move hoststats code to host module .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

2016-05-01 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 13: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/53214 To

Change in vdsm[master]: Move hoststats code to host module

2016-05-01 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review. Change subject: Move hoststats code to host module .. Move hoststats code to host module The code shouldn't be under virt folder and we already have host module which should

Change in vdsm[master]: kvm2ovirt: tool for copying images from libvirt

2016-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: kvm2ovirt: tool for copying images from libvirt .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/55797/5/helpers/kvm2ovirt File helpers/kvm2ovirt: Line

Change in vdsm[master]: macspoof hook: README: help adding the custom property

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: macspoof hook: README: help adding the custom property .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: Move the host stats dict creation to host module

2016-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Move the host stats dict creation to host module .. Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/56874/2/lib/vdsm/host.py File lib/vdsm/host.py: Line

Change in vdsm[master]: vdsm: changed relative imports to absolute imports

2016-05-01 Thread igoihman
Irit Goihman has posted comments on this change. Change subject: vdsm: changed relative imports to absolute imports .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/56607/2//COMMIT_MSG Commit Message: PS2, Line 10:

Change in vdsm[master]: vdsm: changed relative imports to absolute imports

2016-05-01 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: changed relative imports to absolute imports .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/56607/2//COMMIT_MSG Commit Message: PS2, Line 10:

Change in vdsm[master]: Move the host stats dict creation to host module

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Move the host stats dict creation to host module .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: net tests: take2: wait for a concurrent iptables call to finish

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net tests: take2: wait for a concurrent iptables call to finish .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: blockSD: Avoid stale lvs

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: blockSD: Avoid stale lvs .. Patch Set 2: * #1331978::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1331978::OK, public bug * Check

Change in vdsm[ovirt-3.6]: blockSD: Avoid stale lvs

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: blockSD: Avoid stale lvs .. Patch Set 2: * #1331978::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1331978::OK, public bug * Check

Change in vdsm[ovirt-3.6]: blockSD: Avoid stale lvs

2016-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: blockSD: Avoid stale lvs .. Patch Set 1: Verified+1 Tested: - start vdsm - stop vdsm - deactivate storage domain - activate storage domain - put host to

Change in vdsm[master]: blockSD: Avoid stale lvs

2016-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: blockSD: Avoid stale lvs .. Patch Set 1: Verified+1 Tested: - start vdsm - stop vdsm - deactivate storage domain - activate storage domain - put host to

Change in vdsm[master]: vdsm: changed relative imports to absolute imports

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vdsm: changed relative imports to absolute imports .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[ovirt-3.6]: blockSD: Avoid stale lvs

2016-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: blockSD: Avoid stale lvs .. Patch Set 1: This is not merge on master yet, but I want to get this tested by the community. -- To view, visit

Change in vdsm[ovirt-3.6]: blockSD: Avoid stale lvs

2016-05-01 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: blockSD: Avoid stale lvs .. blockSD: Avoid stale lvs When connecting to iSCSI storage, all lvs are automatically activate - this seems to be new behavior

Change in vdsm[ovirt-3.6]: blockSD: Avoid stale lvs

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: blockSD: Avoid stale lvs .. Patch Set 1: Verified-1 * #1331978::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1331978::OK, public bug * Check

Change in vdsm[master]: blockSD: Avoid stale lvs

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: blockSD: Avoid stale lvs .. Patch Set 1: * #1331978::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1331978::OK, public bug * Check

Change in vdsm[master]: blockSD: Avoid stale lvs

2016-05-01 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: blockSD: Avoid stale lvs .. blockSD: Avoid stale lvs When connecting to iSCSI storage, all lvs are automatically activate - this seems to be new behavior

Change in vdsm[master]: storage: add tests for Mount.isMounted in mount.py

2016-05-01 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: storage: add tests for Mount.isMounted in mount.py .. storage: add tests for Mount.isMounted in mount.py Change-Id:

Change in vdsm[master]: storage: add tests for Mount.isMounted in mount.py

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: add tests for Mount.isMounted in mount.py .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: storage: add tests for Mount.isMounted in mount.py

2016-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: add tests for Mount.isMounted in mount.py .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56704 To unsubscribe, visit

Change in vdsm[master]: kvm2ovirt: tool for copying images from libvirt

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: kvm2ovirt: tool for copying images from libvirt .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: v2v: add support for importing kvm based vms from libvirt

2016-05-01 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: add support for importing kvm based vms from libvirt .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: kvm2ovirt: tool for copying images from libvirt

2016-05-01 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: kvm2ovirt: tool for copying images from libvirt .. Patch Set 5: (5 comments) https://gerrit.ovirt.org/#/c/55797/5/configure.ac File configure.ac: Line 376:

  1   2   >