gerrit-hooks has posted comments on this change.
Change subject: net: Move netconfpersistence under vdsm.network
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Edward Haas has posted comments on this change.
Change subject: net: Move netconfpersistence under vdsm.network
..
Patch Set 2:
(7 comments)
https://gerrit.ovirt.org/#/c/56677/2/lib/vdsm/netinfo/cache.py
File
Martin Betak has posted comments on this change.
Change subject: rpc: Make Bridge#_type_fixup more robust
..
Patch Set 1:
(1 comment)
Added a test for this in https://gerrit.ovirt.org/#/c/56884/1 but because it
depends on
Martin Betak has posted comments on this change.
Change subject: rpc: Add test for 'int' parameters in Bridge
..
Patch Set 1: Verified+1
Verified by running tests.
--
To view, visit https://gerrit.ovirt.org/56884
To
gerrit-hooks has posted comments on this change.
Change subject: rpc: Make Bridge#_type_fixup more robust
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 28:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: rpc: Add test for 'int' parameters in Bridge
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Betak has uploaded a new change for review.
Change subject: rpc: Add test for 'int' parameters in Bridge
..
rpc: Add test for 'int' parameters in Bridge
Change-Id: Ie8a2672c53411bed1ac711fffccb543bcfb16024
Signed-off-by:
gerrit-hooks has posted comments on this change.
Change subject: blockSD: Avoid stale lvs
..
Patch Set 3:
* #1331978::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1331978::OK, public bug
* Check
Nir Soffer has posted comments on this change.
Change subject: blockSD: Avoid stale lvs
..
Patch Set 2:
This version refines the commit message.
--
To view, visit https://gerrit.ovirt.org/56876
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: blockSD: Avoid stale lvs
..
Patch Set 2:
(4 comments)
https://gerrit.ovirt.org/#/c/56876/2//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2016-05-01 13:26:32
Yaniv Kaul has posted comments on this change.
Change subject: Adding reportStats
..
Patch Set 1:
How do we get all stats? Somehow in an automated manner, so when we add more
stats we don't need to manually add more code?
--
Nir Soffer has posted comments on this change.
Change subject: blockSD: Avoid stale lvs
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/56876/2//COMMIT_MSG
Commit Message:
Line 6:
Line 7: blockSD: Avoid stale lvs
Allon Mureinik has posted comments on this change.
Change subject: blockSD: Avoid stale lvs
..
Patch Set 2:
(11 comments)
https://gerrit.ovirt.org/#/c/56876/2//COMMIT_MSG
Commit Message:
PS2, Line 9: activate
activated
Francesco Romani has submitted this change and it was merged.
Change subject: qemuimg: Validate qcow2_compat configuration
..
qemuimg: Validate qcow2_compat configuration
Validate new qcow2_compat option against a list of
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Validate qcow2_compat configuration
..
Patch Set 2:
* #1317850::Update tracker: OK
* Set MODIFIED::bug 1317850#1317850OK
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: qemuimg: Validate qcow2_compat configuration
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56523
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: qemuimg: Make QCOW2_COMPAT configurable
..
qemuimg: Make QCOW2_COMPAT configurable
It's worth to make QCOW2 compatibility version configurable. It
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Make QCOW2_COMPAT configurable
..
Patch Set 2:
* #1317850::Update tracker: OK
* Set MODIFIED::bug 1317850#1317850IGNORE, not all related patches
Francesco Romani has posted comments on this change.
Change subject: qemuimg: Make QCOW2_COMPAT configurable
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56522
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Validate qcow2_compat configuration
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/56523
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Make QCOW2_COMPAT configurable
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/56522
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: Don't prepare image with illegal volumes
..
Patch Set 3:
* #1332038::Update tracker: OK
* Set MODIFIED::bug 1332038#1332038IGNORE, not oVirt
Francesco Romani has submitted this change and it was merged.
Change subject: Don't prepare image with illegal volumes
..
Don't prepare image with illegal volumes
The irs verb 'prepareImage' is used only by clientIF when
Francesco Romani has posted comments on this change.
Change subject: Don't prepare image with illegal volumes
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56881
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 8: -Verified
--
To view, visit https://gerrit.ovirt.org/49952
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: net: get network switch type from libvirt
..
Patch Set 1:
I agree.
--
To view, visit https://gerrit.ovirt.org/56838
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 8:
Note that jenkins fail with this error:
12:19:22 if [ "1" == "1" ]; then \
12:19:22
Ala Hino has posted comments on this change.
Change subject: Don't prepare image with illegal volumes
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/56881
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: Don't prepare image with illegal volumes
..
Patch Set 2:
* #1332038::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1332038::OK, public bug
* Check
Tal Nisan has posted comments on this change.
Change subject: Don't prepare image with illegal volumes
..
Patch Set 1: -Code-Review
Please use this bug in the Bug-Url:
https://bugzilla.redhat.com/1332038
--
To view, visit
Edward Haas has posted comments on this change.
Change subject: configure: add support for nosetests/python 3.5
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/56083/3/configure.ac
File configure.ac:
Line 289: fi
Ala Hino has posted comments on this change.
Change subject: Don't prepare image with illegal volumes
..
Patch Set 1: Verified-1
-1 for visibility:
The code is perfect but bug Id is incorrect
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: client: do not protect requests on client side
..
Patch Set 2:
(5 comments)
https://gerrit.ovirt.org/#/c/56288/2/lib/yajsonrpc/__init__.py
File
Idan Shaby has posted comments on this change.
Change subject: storagetests: add a test for normalize_local_path
..
Patch Set 10: -Verified
There've been too many rebases since the last time I verified.
Marking as not verified
Nir Soffer has posted comments on this change.
Change subject: client: do not protect requests on client side
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56288/2/lib/yajsonrpc/__init__.py
File
Edward Haas has posted comments on this change.
Change subject: net: get network switch type from libvirt
..
Patch Set 1: Code-Review-1
I am not clear why libvirt DB is considered 'actual' or real time info.
To me, it is not
Tal Nisan has posted comments on this change.
Change subject: Don't prepare image with illegal volumes
..
Patch Set 1: Code-Review-1
Wait with the merge, we need a different Bug-Url
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: storage: streamline getting domain mountpoint
..
storage: streamline getting domain mountpoint
When checking if a domain's mountpoint is mounted, the code
gerrit-hooks has posted comments on this change.
Change subject: storage: streamline getting domain mountpoint
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Idan Shaby has posted comments on this change.
Change subject: storage: streamline getting domain mountpoint
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/56706
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: storage: fix spec normalization when mounting
..
Patch Set 14:
* #1305529::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1305529::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: storagetests: add a test for normalize_local_path
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: streamline getting domain mountpoint
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: use libvirt flags to select capability
..
hostdev: use libvirt flags to select capability
hostdevListByCaps (or list_by_caps in hostdev
gerrit-hooks has posted comments on this change.
Change subject: hostdev: use libvirt flags to select capability
..
Patch Set 9:
* #1270581::Update tracker: OK
* Set MODIFIED::bug 1270581#1270581IGNORE, not all related
Irit Goihman has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/49952
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 8:
* #1182088::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1182088::OK, public bug
*
Edward Haas has posted comments on this change.
Change subject: net: add virtual port to libvirt network def
..
Patch Set 3: Code-Review-1
(3 comments)
Nir Soffer has posted comments on this change.
Change subject: Don't prepare image with illegal volumes
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56881
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: Don't prepare image with illegal volumes
..
Patch Set 1:
* #1331572::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1331572::OK, public bug
* Check
Dan Kenigsberg has posted comments on this change.
Change subject: net: Move netconfpersistence under vdsm.network
..
Patch Set 2: Code-Review-1
(8 comments)
boring ordering nits
Ala Hino has posted comments on this change.
Change subject: Don't prepare image with illegal volumes
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/56881
To unsubscribe, visit
Hello Nir Soffer, Adam Litke, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/56881
to review the following change.
Change subject: Don't prepare image with illegal volumes
..
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Adding reportStats
..
Adding reportStats
Adding function that uses statsd to report internal host info. This will
be called after each sampling for now.
gerrit-hooks has posted comments on this change.
Change subject: Adding reportStats
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: Move hoststats code to host module
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Edward Haas has posted comments on this change.
Change subject: macspoof hook: README: help adding the custom property
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56015
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net tests: Clean netinfo_test from uneeded mocks
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: Clean netinfo_test from uneeded mocks
..
net tests: Clean netinfo_test from uneeded mocks
Removing mockey patches that are no longer
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: Clean netinfo_test from uneeded mocks
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55898
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 13:
(3 comments)
https://gerrit.ovirt.org/#/c/53214/13/lib/vdsm/module_loader.py
Nir Soffer has submitted this change and it was merged.
Change subject: v2v: small test improvement
..
v2v: small test improvement
Change-Id: I89c46efc9836fe0f0ef680084f1921ef3948055f
Signed-off-by: Tomáš Golembiovský
gerrit-hooks has posted comments on this change.
Change subject: v2v: small test improvement
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: v2v: small test improvement
..
Patch Set 1:
OK, we will improve this later.
--
To view, visit https://gerrit.ovirt.org/56694
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: net tests: Clean netinfo_test from uneeded mocks
..
Patch Set 4:
Dan, ping
--
To view, visit https://gerrit.ovirt.org/55898
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: storage: streamline getting domain mountpoint
..
Patch Set 3:
Can you verify? I want to take this first.
--
To view, visit https://gerrit.ovirt.org/56706
To
Nir Soffer has posted comments on this change.
Change subject: Move hoststats code to host module
..
Patch Set 1:
You move here lot of code, but I don't see the deleted code in the original
module
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: kvm2ovirt: tool for copying images from libvirt
..
Patch Set 6:
(16 comments)
https://gerrit.ovirt.org/#/c/55797/6/helpers/kvm2ovirt
File helpers/kvm2ovirt:
Line
Dan Kenigsberg has posted comments on this change.
Change subject: lvm: Fail loudly if called with unexpected input
..
Patch Set 4: Code-Review+1
But I'd prefer that this kind of validation take place much higher up, at the
gerrit-hooks has posted comments on this change.
Change subject: net tests: take2: wait for a concurrent iptables call to finish
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: take2: wait for a concurrent iptables call to finish
..
net tests: take2: wait for a concurrent iptables call to finish
commit 9f7685f
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: take2: wait for a concurrent iptables call to finish
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56871
To unsubscribe,
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: changed relative imports to absolute imports
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56607
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: Move hoststats code to host module
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Yaniv Bronhaim has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 13: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53214
To
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Move hoststats code to host module
..
Move hoststats code to host module
The code shouldn't be under virt folder and we already have host module
which should
Nir Soffer has posted comments on this change.
Change subject: kvm2ovirt: tool for copying images from libvirt
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/55797/5/helpers/kvm2ovirt
File helpers/kvm2ovirt:
Line
gerrit-hooks has posted comments on this change.
Change subject: macspoof hook: README: help adding the custom property
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Nir Soffer has posted comments on this change.
Change subject: Move the host stats dict creation to host module
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/56874/2/lib/vdsm/host.py
File lib/vdsm/host.py:
Line
Irit Goihman has posted comments on this change.
Change subject: vdsm: changed relative imports to absolute imports
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56607/2//COMMIT_MSG
Commit Message:
PS2, Line 10:
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: changed relative imports to absolute imports
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56607/2//COMMIT_MSG
Commit Message:
PS2, Line 10:
gerrit-hooks has posted comments on this change.
Change subject: Move the host stats dict creation to host module
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: net tests: take2: wait for a concurrent iptables call to finish
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
gerrit-hooks has posted comments on this change.
Change subject: blockSD: Avoid stale lvs
..
Patch Set 2:
* #1331978::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1331978::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: blockSD: Avoid stale lvs
..
Patch Set 2:
* #1331978::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1331978::OK, public bug
* Check
Nir Soffer has posted comments on this change.
Change subject: blockSD: Avoid stale lvs
..
Patch Set 1: Verified+1
Tested:
- start vdsm
- stop vdsm
- deactivate storage domain
- activate storage domain
- put host to
Nir Soffer has posted comments on this change.
Change subject: blockSD: Avoid stale lvs
..
Patch Set 1: Verified+1
Tested:
- start vdsm
- stop vdsm
- deactivate storage domain
- activate storage domain
- put host to
gerrit-hooks has posted comments on this change.
Change subject: vdsm: changed relative imports to absolute imports
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: blockSD: Avoid stale lvs
..
Patch Set 1:
This is not merge on master yet, but I want to get this tested by the community.
--
To view, visit
Nir Soffer has uploaded a new change for review.
Change subject: blockSD: Avoid stale lvs
..
blockSD: Avoid stale lvs
When connecting to iSCSI storage, all lvs are automatically activate -
this seems to be new behavior
gerrit-hooks has posted comments on this change.
Change subject: blockSD: Avoid stale lvs
..
Patch Set 1: Verified-1
* #1331978::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1331978::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: blockSD: Avoid stale lvs
..
Patch Set 1:
* #1331978::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1331978::OK, public bug
* Check
Nir Soffer has uploaded a new change for review.
Change subject: blockSD: Avoid stale lvs
..
blockSD: Avoid stale lvs
When connecting to iSCSI storage, all lvs are automatically activate -
this seems to be new behavior
Nir Soffer has submitted this change and it was merged.
Change subject: storage: add tests for Mount.isMounted in mount.py
..
storage: add tests for Mount.isMounted in mount.py
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: storage: add tests for Mount.isMounted in mount.py
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Nir Soffer has posted comments on this change.
Change subject: storage: add tests for Mount.isMounted in mount.py
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56704
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: kvm2ovirt: tool for copying images from libvirt
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: v2v: add support for importing kvm based vms from libvirt
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Shahar Havivi has posted comments on this change.
Change subject: kvm2ovirt: tool for copying images from libvirt
..
Patch Set 5:
(5 comments)
https://gerrit.ovirt.org/#/c/55797/5/configure.ac
File configure.ac:
Line 376:
1 - 100 of 136 matches
Mail list logo