Edward Haas has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator ......................................................................
Patch Set 13: (3 comments) https://gerrit.ovirt.org/#/c/53214/13/lib/vdsm/module_loader.py File lib/vdsm/module_loader.py: PS13, Line 34: if not hasattr(modules[module_name], 'name'): : setattr(modules[module_name], 'name', module_name) Can we please control this with a flag? https://gerrit.ovirt.org/#/c/53214/13/tests/module_loader_test.py File tests/module_loader_test.py: PS13, Line 40: with namedTemporaryDir() as path: : for f in files: : utils.touchFile(os.path.join(path, f)) : utils.touchFile(os.path.join(path, '__init__.py')) What about moving this to a separated contextmanager? So we can use it like this: with _setup_test_modules as path: result = module_loader.load_modules(path) https://gerrit.ovirt.org/#/c/53214/13/vdsm.spec.in File vdsm.spec.in: Line 1191 Line 1192 Line 1193 Line 1194 Line 1195 Please do not fix this here, it will cause uneeded conflicts with other changes currently in progress. -- To view, visit https://gerrit.ovirt.org/53214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
