Change in vdsm[master]: utils: build cert paths in single place

2016-09-22 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: utils: build cert paths in single place .. Patch Set 12: Code-Review-1 (1 comment) -1 for visibility

Change in vdsm[master]: gluster: set selinux labels while creating bricks

2016-09-22 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster: set selinux labels while creating bricks .. gluster: set selinux labels while creating bricks brick should have correct selinux labels on the

Change in vdsm[master]: gluster: set selinux labels while creating bricks

2016-09-22 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: gluster: set selinux labels while creating bricks .. Patch Set 5: Code-Review+2 raising score -- To view, visit https://gerrit.ovirt.org/62773 To

Change in vdsm[master]: gluster: set selinux labels while creating bricks

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: gluster: set selinux labels while creating bricks .. Patch Set 6: * #1368474::Update tracker: OK * Set MODIFIED::bug 1368474#1368474IGNORE, not all

Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter for.

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add qcow_compat optional parameter for. .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter for.

2016-09-22 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: qemuimg: Add qcow_compat optional parameter for. .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/64169/7//COMMIT_MSG Commit Message: Line 9: Add

Change in vdsm[master]: qemuimg: Add qcow_compat optional parameter for.

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add qcow_compat optional parameter for. .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: contrib: Simple jsonrpc client

2016-09-22 Thread igoihman
Irit Goihman has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 20: Verified+1 -- To view, visit https://gerrit.ovirt.org/35181 To unsubscribe, visit

Change in vdsm[master]: contrib: Simple jsonrpc client

2016-09-22 Thread Jenkins CI
Jenkins CI has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 20: Propagate review hook: Continuous Integration value inherited from patch 19 -- To view, visit

Change in vdsm[master]: contrib: Simple jsonrpc client

2016-09-22 Thread igoihman
Irit Goihman has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 20: (2 comments) https://gerrit.ovirt.org/#/c/35181/18//COMMIT_MSG Commit Message: Line 27: # jsonrpc

Change in vdsm[master]: contrib: Simple jsonrpc client

2016-09-22 Thread Jenkins CI
Jenkins CI has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 20: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 18 -- To view,

Change in vdsm[master]: contrib: Simple jsonrpc client

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 20: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: contrib: Simple jsonrpc client

2016-09-22 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 18: (3 comments) https://gerrit.ovirt.org/#/c/35181/18//COMMIT_MSG Commit Message: Line 27: # jsonrpc

Change in vdsm[master]: contrib: Simple jsonrpc client

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: contrib: Simple jsonrpc client

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: net: Setup validation for OVS - Check nics usage

2016-09-22 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: Setup validation for OVS - Check nics usage .. Patch Set 5: Code-Review+1 (1 comment)

Change in vdsm[master]: stomp: simplified client

2016-09-22 Thread igoihman
Irit Goihman has posted comments on this change. Change subject: stomp: simplified client .. Patch Set 10: I rebased the patch, please verify the changes -- To view, visit https://gerrit.ovirt.org/59151 To unsubscribe, visit

Change in vdsm[master]: utils: build cert paths in single place

2016-09-22 Thread igoihman
Irit Goihman has posted comments on this change. Change subject: utils: build cert paths in single place .. Patch Set 12: I rebased the patch, please verify the changes -- To view, visit https://gerrit.ovirt.org/52354 To

Change in vdsm[master]: stomp: simplified client

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: stomp: simplified client .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: contrib: Simple jsonrpc client

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 17: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: utils: build cert paths in single place

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: build cert paths in single place .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net: test ovs info with southbound nic

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: test ovs info with southbound nic .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: net: remove default route before adding a new one

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: remove default route before adding a new one .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: net: test ovs info with southbound nic

2016-09-22 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: test ovs info with southbound nic .. Patch Set 3: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/63999 To unsubscribe, visit

Change in vdsm[master]: net: test ovs info with southbound nic

2016-09-22 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: test ovs info with southbound nic .. net: test ovs info with southbound nic We will remove OVS bonding support in a following patch. This patch

Change in vdsm[master]: net: Disable IPv6 on OVS southbound iface (nic or bonding)

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Disable IPv6 on OVS southbound iface (nic or bonding) .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.

Change in vdsm[master]: net: Disable IPv6 on OVS southbound iface (nic or bonding)

2016-09-22 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: Disable IPv6 on OVS southbound iface (nic or bonding) .. net: Disable IPv6 on OVS southbound iface (nic or bonding) Only northbound iface may

Change in vdsm[master]: net: Disable IPv6 on OVS southbound iface (nic or bonding)

2016-09-22 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: Disable IPv6 on OVS southbound iface (nic or bonding) .. Patch Set 1: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/63826 To

Change in vdsm[master]: net: remove default route before adding a new one

2016-09-22 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: remove default route before adding a new one .. net: remove default route before adding a new one Change-Id:

Change in vdsm[master]: net: remove default route before adding a new one

2016-09-22 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: remove default route before adding a new one .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63220 To unsubscribe, visit

Change in vdsm[master]: Live Merge: teardown volume on HSM after live merge

2016-09-22 Thread ahino
Ala Hino has posted comments on this change. Change subject: Live Merge: teardown volume on HSM after live merge .. Patch Set 4: Verified-1 -- To view, visit https://gerrit.ovirt.org/59725 To unsubscribe, visit

Change in vdsm[master]: net test: test_ip_info - wait for IP settings with address

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net test: test_ip_info - wait for IP settings with address .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.

Change in vdsm[master]: net test: test_ip_info - wait for IP settings with address

2016-09-22 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net test: test_ip_info - wait for IP settings with address .. Patch Set 4: Code-Review+2 rasing -- To view, visit https://gerrit.ovirt.org/63660 To

Change in vdsm[master]: net test: test_ip_info - wait for IP settings with address

2016-09-22 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net test: test_ip_info - wait for IP settings with address .. net test: test_ip_info - wait for IP settings with address This is a second attempt to

Change in vdsm[master]: yml: generate api doc from the schema

2016-09-22 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: yml: generate api doc from the schema .. Patch Set 25: ping -- To view, visit https://gerrit.ovirt.org/56387 To unsubscribe, visit

Change in vdsm[master]: utils: build cert paths in single place

2016-09-22 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: utils: build cert paths in single place .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/52354/11/vdsm/sos/vdsm.py.in File vdsm/sos/vdsm.py.in:

Change in vdsm[master]: vdsm: drop the warnings module configuration

2016-09-22 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: vdsm: drop the warnings module configuration .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62212 To unsubscribe, visit

Change in vdsm[master]: logging: Improve log level alignment

2016-09-22 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: logging: Improve log level alignment .. Patch Set 2: Looks good to me but please add example to commit message as Milan suggests -- To view, visit

Change in vdsm[master]: alignmentScan: Use proper environment

2016-09-22 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: alignmentScan: Use proper environment .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64123 To unsubscribe, visit

Change in vdsm[master]: logging: Use same log format in the tests

2016-09-22 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: logging: Use same log format in the tests .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64216 To unsubscribe, visit

Change in vdsm[master]: qemuimg: Add kwargs optional parameter for qcow.

2016-09-22 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Add kwargs optional parameter for qcow. .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/64169/7//COMMIT_MSG Commit Message: Line 9: Add kwargs

Change in vdsm[master]: Live Merge: teardown volume on HSM after live merge

2016-09-22 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Live Merge: teardown volume on HSM after live merge .. Patch Set 4: Code-Review-1 Did we agree that this is not the right approach? -- To view, visit

Change in vdsm[master]: Live Merge: teardown volume on HSM after live merge

2016-09-22 Thread ahino
Ala Hino has posted comments on this change. Change subject: Live Merge: teardown volume on HSM after live merge .. Patch Set 4: Verified+1 Need to verify wipe after delete logic when deactivating the LV before deleting the

Change in vdsm[master]: qemuimg: Add kwargs optional parameter for qcow.

2016-09-22 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: qemuimg: Add kwargs optional parameter for qcow. .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/64169/7/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py:

Change in vdsm[master]: qemuimg: Add kwargs optional parameter for qcow.

2016-09-22 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: qemuimg: Add kwargs optional parameter for qcow. .. Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/64169/7/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py:

Change in vdsm[master]: net: Setup validation for OVS - Check nics usage

2016-09-22 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Setup validation for OVS - Check nics usage .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/64212 To unsubscribe, visit

Change in vdsm[master]: gluster: set selinux labels while creating bricks

2016-09-22 Thread fromani
Francesco Romani has posted comments on this change. Change subject: gluster: set selinux labels while creating bricks .. Patch Set 5: Code-Review+1 ok, so let's go this route -- To view, visit https://gerrit.ovirt.org/62773

Change in vdsm[master]: net: Setup validation for OVS - Check nics usage

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Setup validation for OVS - Check nics usage .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: net: Log a setup networks transaction failure when using ovs...

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Log a setup networks transaction failure when using ovs switch .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: net: Setup validation for OVS - Check nics usage

2016-09-22 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Setup validation for OVS - Check nics usage .. Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/64212/4/lib/vdsm/network/netswitch.py File

Change in vdsm[master]: virt: enable glusterfs access through libgfapi interface

2016-09-22 Thread sabose
Sahina Bose has posted comments on this change. Change subject: virt: enable glusterfs access through libgfapi interface .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/44061/8//COMMIT_MSG Commit Message: Line 18: a

Change in vdsm[master]: v2v: support for block devices

2016-09-22 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: support for block devices .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/64272 To unsubscribe, visit

Change in vdsm[master]: v2v: support for block devices

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: support for block devices .. Patch Set 1: * #1378340::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1378340::OK, public bug * Check

Change in vdsm[master]: v2v: support for block devices

2016-09-22 Thread shavivi
Shahar Havivi has uploaded a new change for review. Change subject: v2v: support for block devices .. v2v: support for block devices extended support for block devices for KVM and VMWare. currently we do support block devices

Change in vdsm[master]: net: Log a setup networks transaction failure when using ovs...

2016-09-22 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: Log a setup networks transaction failure when using ovs switch .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64242 To

Change in vdsm[master]: net: Setup validation for OVS - Check nics usage

2016-09-22 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: Setup validation for OVS - Check nics usage .. Patch Set 4: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/64212/4/lib/vdsm/network/netswitch.py

Change in vdsm[master]: net: Delete an OVS bridge when the last SB is detached.

2016-09-22 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: Delete an OVS bridge when the last SB is detached. .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64192 To unsubscribe, visit

Change in vdsm[master]: net: Split OVS setup transaction to adjust for bond setup

2016-09-22 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: Split OVS setup transaction to adjust for bond setup .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64118 To unsubscribe, visit

Change in vdsm[master]: storage: add more info to NFS SD getInfo

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: add more info to NFS SD getInfo .. Patch Set 2: * #1373930::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/63636 To unsubscribe, visit

Change in vdsm[master]: storage: add more info to NFS SD getInfo

2016-09-22 Thread frolland
Freddy Rolland has abandoned this change. Change subject: storage: add more info to NFS SD getInfo .. Abandoned Not the right solution -- To view, visit https://gerrit.ovirt.org/63636 To unsubscribe, visit

Change in vdsm[master]: gluster: set selinux labels while creating bricks

2016-09-22 Thread sabose
Sahina Bose has posted comments on this change. Change subject: gluster: set selinux labels while creating bricks .. Patch Set 5: > (1 comment) Adding to what Ramesh said - /rhgs is a recommended mount point and not

Change in vdsm[master]: gluster: add support for arbiter volumes

2016-09-22 Thread rnachimu
Ramesh N has restored this change. Change subject: gluster: add support for arbiter volumes .. Restored -- To view, visit https://gerrit.ovirt.org/52559 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[ovirt-4.0]: net: Consume ifcfg files that have a non vdsm standard name

2016-09-22 Thread gerrit2
Anonymous Coward #1001177 has posted comments on this change. Change subject: net: Consume ifcfg files that have a non vdsm standard name .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/64096 To

Change in vdsm[ovirt-4.0]: net: Expose owned_device method through the configurator

2016-09-22 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Expose owned_device method through the configurator .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/64095 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: net: Consume ifcfg files that have a non vdsm standard name

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Consume ifcfg files that have a non vdsm standard name .. Patch Set 3: * #1367378::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1367378::OK,

Change in vdsm[ovirt-4.0]: net: Expose owned_device method through the configurator

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Expose owned_device method through the configurator .. Patch Set 2: -Verified * #1367378::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[ovirt-4.0]: net: Consume ifcfg files that have a non vdsm standard name

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Consume ifcfg files that have a non vdsm standard name .. Patch Set 2: * #1367378::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1367378::OK,

Change in vdsm[master]: net: Consume ifcfg files that have a non vdsm standard name

2016-09-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Consume ifcfg files that have a non vdsm standard name .. Patch Set 4: * #1367378::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1367378::OK,

<    1   2