Alon Bar-Lev has posted comments on this change.
Change subject: presets: Disable firewalld.service by default
..
Patch Set 1:
> There is actually some code which handles the firewall.
>
> However, I'm fine if s
Alon Bar-Lev has posted comments on this change.
Change subject: presets: Disable firewalld.service by default
..
Patch Set 1:
vdsm should not care what firewall solution one uses.
--
To view, visit https://gerrit.ovirt.org
Alon Bar-Lev has posted comments on this change.
Change subject: presets: Disable firewalld.service by default
..
Patch Set 1:
> In the end vdsm already cares about services. firewalld is in this
> case just yet a
Alon Bar-Lev has posted comments on this change.
Change subject: vdsClient: parse no value arguments
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/46133/1/client/vdsClient.py
File client/vdsClient.py:
Line 163
Alon Bar-Lev has posted comments on this change.
Change subject: vdsClient: parse no value arguments
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46133
To unsubscribe, visit https
Alon Bar-Lev has posted comments on this change.
Change subject: Revert api: compat: fix api breakage of 'config' and 'netinfo'
used by bootstrap
..
Patch Set 6:
not sure what input you expect of me... please direct me
Alon Bar-Lev has posted comments on this change.
Change subject: Revised the format of output from the vdsm-tool vdsm-id command.
..
Patch Set 1:
guys, this is just adding new line.
--
To view, visit https://gerrit.ovirt.org
Alon Bar-Lev has posted comments on this change.
Change subject: serial console: add code to prepare the path
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/41896/6/lib/vdsm/config.py.in
File lib/vdsm/config.py.in
Alon Bar-Lev has posted comments on this change.
Change subject: serial console: add code to prepare the path
..
Patch Set 3:
if permissions are incorrect it means that the host had been tempered.
I would have printed
Alon Bar-Lev has posted comments on this change.
Change subject: serial console: add code to prepare the path
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/41896/4/vdsm/vmconsole.py
File vdsm/vmconsole.py:
Line
Alon Bar-Lev has posted comments on this change.
Change subject: serial console: add code to prepare the path
..
Patch Set 5: Code-Review+1
(1 comment)
+1 for concept, /me not vdsm developer.
https://gerrit.ovirt.org/#/c
Alon Bar-Lev has posted comments on this change.
Change subject: serial console: add code to prepare the path
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/41896/2/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 127
Alon Bar-Lev has posted comments on this change.
Change subject: serial console: add code to prepare the path
..
Patch Set 3:
you cannot destroy this on startup as far as I know vdsm restart keeps vms up,
you cannot destroy
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-imaged: Support random io to oVirt disks
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/41824/2/vdsm-imaged/README
File vdsm-imaged/README
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-imaged: Support random io to oVirt disks
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/41824/2/vdsm-imaged/README
File vdsm-imaged/README:
Line
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-imaged: Support random io to oVirt disks
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/41824/2/vdsm-imaged/README
File vdsm-imaged/README:
Line
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-imaged: Support random io to oVirt disks
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/41824/2/vdsm-imaged/README
File vdsm-imaged/README:
Line
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-imaged: Support random io to oVirt disks
..
Patch Set 2:
(10 comments)
it is so far from the methods I use to write software, so I won't be able to
help
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-imaged: Support random io to oVirt disks
..
Patch Set 2:
(7 comments)
https://gerrit.ovirt.org/#/c/41824/2/vdsm-imaged/README
File vdsm-imaged/README
Alon Bar-Lev has posted comments on this change.
Change subject: drop vds_bootstrap
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41527
To unsubscribe, visit https://gerrit.ovirt.org/settings
Alon Bar-Lev has posted comments on this change.
Change subject: ssl: m2crypto removal
..
Patch Set 1:
in the past there were multiple issues with python2 ssl implementation, as far
as I remember especially with the session
Alon Bar-Lev has posted comments on this change.
Change subject: ssl: m2crypto removal
..
Patch Set 2:
again, in large scale there is a must to disconnect/connect due to resource
limitations, it is incorrect to assume engine
Alon Bar-Lev has posted comments on this change.
Change subject: utils: Add systemd_run command modifier
..
Patch Set 1:
in principal I do not like the a systemd dependency of core functionality,
systemd becomes a monster
Alon Bar-Lev has posted comments on this change.
Change subject: ssl: Force client to use TLSv1 when using secure connection.
..
Patch Set 3:
the problem is that we probably do not renegotiate, we start at sslv3 and then
fail
Alon Bar-Lev has abandoned this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
..
Abandoned
vdsm old stuff, still required but someone from vdsm should take
--
To view, visit https
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: debian: making code compatible with upstream M2Crypto
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/37746/4/lib/vdsm/sslutils.py
File lib
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: debian: making code compatible with upstream M2Crypto
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/37746/4/lib/vdsm/sslutils.py
File lib
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: debian: making code compatible with upstream M2Crypto
..
Patch Set 8:
you cannot expect that even if you fix this debian will be supported
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: debian: making code compatible with upstream M2Crypto
..
Patch Set 7:
(1 comment)
good, this is simple enough, thanks.
http://gerrit.ovirt.org/#/c
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: debian: making code compatible with upstream M2Crypto
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/37746/4/lib/vdsm/sslutils.py
File lib
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: debian: making code compatible with upstream M2Crypto
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/37746/1/lib/vdsm/sslutils.py
File lib
Alon Bar-Lev has posted comments on this change.
Change subject: spec: Require tar
..
Patch Set 1:
host-deploy installs vdsm, so this is irrelevant to vdsm.
also, vdsm should not care how engine configure host.
having tar
Alon Bar-Lev has posted comments on this change.
Change subject: spec: Require tar
..
Patch Set 1:
this is egg and chicken... unrelated to vdsm.
if this is required for ovirt-node, please send this to
ovirt-host-deploy
Alon Bar-Lev has posted comments on this change.
Change subject: Changing persisted value to libvirt logrotate configure
..
Patch Set 1:
not sure I follow... but we do want to make sure this file is intact and valid
Alon Bar-Lev has posted comments on this change.
Change subject: Adding --with-local-version flag to configure
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/35202/1/configure.ac
File configure.ac:
Line 80
Alon Bar-Lev has posted comments on this change.
Change subject: Revised the format of output from the vdsm-tool vdsm-id command.
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34583
To unsubscribe
Alon Bar-Lev has posted comments on this change.
Change subject: ssl: ssl protocol configurable
..
Patch Set 5:
when set to sslv23 it start handshake.
and? working?
--
To view, visit http://gerrit.ovirt.org/34345
Alon Bar-Lev has posted comments on this change.
Change subject: ssl: ssl protocol configurable
..
Patch Set 5:
I also wants the result of having sslv23 and engine using TLSv1.
And please remember that this class is new, so
Alon Bar-Lev has posted comments on this change.
Change subject: ssl: setting default ssl protocol to tlsv1
..
Patch Set 1:
(1 comment)
just for you to confirm that after you modify engine to use tlsv1 and this to
tlsv1 all
Alon Bar-Lev has posted comments on this change.
Change subject: ssl: setting default ssl protocol to tlsv1
..
Patch Set 2:
have you verified it against working engine or something else?
--
To view, visit http
Alon Bar-Lev has posted comments on this change.
Change subject: ssl: setting default ssl protocol to tlsv1
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/34345/3//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2014
Alon Bar-Lev has posted comments on this change.
Change subject: ssl: setting default ssl protocol to tlsv1
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/34345/4//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2014
Alon Bar-Lev has posted comments on this change.
Change subject: tool: avoid swallowing errors in seboolsetup calls.
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/33737/2/vdsm.spec.in
File vdsm.spec.in:
Line 820
Alon Bar-Lev has posted comments on this change.
Change subject: tool: avoid swallowing errors in seboolsetup calls.
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/33737/2/vdsm.spec.in
File vdsm.spec.in:
Line 752
Alon Bar-Lev has posted comments on this change.
Change subject: tool: avoid swallowing errors in seboolsetup calls.
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/33737/2/vdsm.spec.in
File vdsm.spec.in:
Line 752
Alon Bar-Lev has posted comments on this change.
Change subject: multipath: Configure iscsi_session recovery_tmo
..
Patch Set 3:
(3 comments)
http://gerrit.ovirt.org/#/c/32582/3/vdsm/storage/Makefile.am
File vdsm/storage
Alon Bar-Lev has posted comments on this change.
Change subject: multipath: Configure iscsi_session recovery_tmo
..
Patch Set 3:
(6 comments)
http://gerrit.ovirt.org/#/c/32582/3/vdsm/storage/Makefile.am
File vdsm/storage
Alon Bar-Lev has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/31561/7/vdsm.spec.in
File vdsm.spec.in
Alon Bar-Lev has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 10:
(1 comment)
http://gerrit.ovirt.org/#/c/31561/10/init/vdsmd_init_common.sh.in
Alon Bar-Lev has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 9:
(3 comments)
http://gerrit.ovirt.org/#/c/31561/9/init/vdsmd_init_common.sh.in
File
Alon Bar-Lev has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/31561/9/init/vdsmd_init_common.sh.in
File
Alon Bar-Lev has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 10:
(1 comment)
http://gerrit.ovirt.org/#/c/31561/10/init/vdsmd_init_common.sh.in
Alon Bar-Lev has posted comments on this change.
Change subject: Deprecated string.join() replaced
..
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/31897/2/vds_bootstrap/setup
File vds_bootstrap/setup
Alon Bar-Lev has posted comments on this change.
Change subject: Hack upgrading ovirt-3.2 vdsm to newer
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/31561/7/vdsm.spec.in
File vdsm.spec.in:
Line 720: # When
Alon Bar-Lev has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 3: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/31741/3/lib/vdsm/tool/configurators/__init__.py
Alon Bar-Lev has posted comments on this change.
Change subject: tool: Remove duplicate names
..
Patch Set 2:
this should be resolved differently by scanning the module and extract all
objects that are instance of our base
Alon Bar-Lev has posted comments on this change.
Change subject: tool: Remove pointless __init__ methods
..
Patch Set 2:
the reason for keeping these is that one day one might add some initialization
at base, and at that day
Alon Bar-Lev has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31741/3/lib/vdsm/tool/configurators/__init__.py
File lib/vdsm
Alon Bar-Lev has posted comments on this change.
Change subject: tool: Make configurators more Pythonic
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31741
To unsubscribe, visit http
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: reorgenize module configurers.
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/31400/2/lib/vdsm/tool/configurators/libvirt.py
File lib/vdsm
Alon Bar-Lev has posted comments on this change.
Change subject: Hack upgrading ovirt-3.2 vdsm to newer
..
Patch Set 5: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/31561/5/vdsm.spec.in
File vdsm.spec.in:
Line 724
Alon Bar-Lev has posted comments on this change.
Change subject: Hack upgrading ovirt-3.2 vdsm to newer
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/31561/2/vdsm.spec.in
File vdsm.spec.in:
Line 721: %{_bindir
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: roll out self signed certificates in vdsm-tool.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/31562/1/lib/vdsm/tool/configurators
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: roll out self signed certificates in vdsm-tool.
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31562
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: Hack upgrading ovirt-3.2 vdsm to newer
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/31561/3/init/vdsmd_init_common.sh.in
File init
Alon Bar-Lev has posted comments on this change.
Change subject: Hack upgrading ovirt-3.2 vdsm to newer
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/31561/4/init/vdsmd_init_common.sh.in
File init
Alon Bar-Lev has posted comments on this change.
Change subject: Hack upgrading ovirt-3.2 vdsm to newer
..
Patch Set 1:
(2 comments)
I truly do not understand the uninstall thing... why can't we properly detect
this state
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: reorgenize module configurers.
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31400
To unsubscribe, visit http
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: simplify getting modules by names.
..
Patch Set 1: Code-Review+1
(1 comment)
still waiting for dynamic scan of modules :)
http://gerrit.ovirt.org
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: roll out self signed certificates in vdsm-tool.
..
Patch Set 1:
(4 comments)
http://gerrit.ovirt.org/#/c/31562/1/lib/vdsm/tool/configurators
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: roll out self signed certificates in vdsm-tool.
..
Patch Set 1:
(5 comments)
http://gerrit.ovirt.org/#/c/31562/1/lib/vdsm/tool/configurators
Alon Bar-Lev has posted comments on this change.
Change subject: Hack upgrading ovirt-3.2 vdsm to newer
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/31561/2/init/vdsmd_init_common.sh.in
File init
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: simplify getting modules by names.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/31464/1/lib/vdsm/tool/configurator.py
File lib/vdsm/tool
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: suppoort dependencies between ModuleConfigure
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/31423/2/lib/vdsm/tool/configurator.py
File lib
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: suppoort dependencies between ModuleConfigure
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/31423/2/lib/vdsm/tool/configurator.py
File lib
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: suppoort dependencies between ModuleConfigure
..
Patch Set 3: Code-Review+1
(1 comment)
thanks, that's simple enough.
http://gerrit.ovirt.org/#/c
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: suppoort dependencies between ModuleConfigure
..
Patch Set 2:
(5 comments)
http://gerrit.ovirt.org/#/c/31423/2/lib/vdsm/tool/configurator.py
File lib
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: always configures files as if certificates exist.
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/31466/1/lib/vdsm/tool
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: reorgenize module configurers.
..
Patch Set 1:
(3 comments)
http://gerrit.ovirt.org/#/c/31400/1/lib/vdsm/tool/configurator.py
File lib/vdsm/tool
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: suppoort dependencies between ModuleConfigure
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/31423/1/lib/vdsm/tool/configurator.py
File lib
Alon Bar-Lev has posted comments on this change.
Change subject: vdsClient: alternative ways to provide password
..
Patch Set 18:
(5 comments)
http://gerrit.ovirt.org/#/c/24733/18//COMMIT_MSG
Commit Message:
Line 14:
Line
Alon Bar-Lev has posted comments on this change.
Change subject: vdsClient: alternative ways to provide password
..
Patch Set 19: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/24733/19/client/vdsClient.py
File client
Alon Bar-Lev has posted comments on this change.
Change subject: vdsClient: alternative ways to provide password
..
Patch Set 20: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/24733/20/client/vdsClient.py
File client
Alon Bar-Lev has posted comments on this change.
Change subject: vdsClient: alternative ways to provide password
..
Patch Set 21: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24733
To unsubscribe, visit http
Alon Bar-Lev has posted comments on this change.
Change subject: rpm: make vdsm-python package noarch
..
Patch Set 1:
there was a problem once to mix python libs of arch and noarch while having the
same vdsm namespace
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Changes for official builds
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/30747/5/configure.ac
File configure.ac:
Line 191: AC_ARG_WITH
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Make vdms_reg bridge configurable
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/30818
To unsubscribe, visit http
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Changes for official builds
..
Patch Set 6: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/30747/6/configure.ac
File configure.ac:
Line 190
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Changes for official builds
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/30747/6/configure.ac
File configure.ac:
Line 190:
Line 191
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Changes for official builds
..
Patch Set 5: Code-Review+1
(1 comment)
+1 for autotools
http://gerrit.ovirt.org/#/c/30747/5/configure.ac
File
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Make vdms_reg bridge configurable
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/30818/3/configure.ac
File configure.ac:
Line 147:
Line
Alon Bar-Lev has posted comments on this change.
Change subject: build: add missing root folder files into tarball
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/29756/2/Makefile.am
File Makefile.am:
Line 39:
Line
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Changes for official builds
..
Patch Set 3:
(1 comment)
looks good! one minor comment, not sure.
http://gerrit.ovirt.org/#/c/30747/3/configure.ac
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Make vdms_reg bridge configurable
..
Patch Set 1:
not sure why this is separate patch, please squash with previous.
--
To view, visit http
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Changes for official builds
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/30747/3/configure.ac
File configure.ac:
Line 151
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Changes for official builds
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/30747/3/configure.ac
File configure.ac:
Line 151
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Changes for official builds
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/30747/4/configure.ac
File configure.ac:
Line 166: AC_ARG_WITH
Alon Bar-Lev has posted comments on this change.
Change subject: RHEL7 works with systemd and requires systemd macros and
tmpfiles.d conf
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/30820/1/vdsm.spec.in
File
Alon Bar-Lev has posted comments on this change.
Change subject: RHEL7 works with systemd and requires systemd macros and
tmpfiles.d conf
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/30820/1/vdsm.spec.in
File
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Changes for official builds
..
Patch Set 2:
(3 comments)
http://gerrit.ovirt.org/#/c/30747/2/configure.ac
File configure.ac:
Line 166: # SMBIOS
1 - 100 of 1088 matches
Mail list logo
