Change in vdsm[master]: move vdsm.config to common

2017-08-19 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move vdsm.config to common .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/79980 To unsubscribe, visit https://ger

Change in vdsm[master]: tool.service: avoid execCmd(raw=False)

2017-08-19 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: tool.service: avoid execCmd(raw=False) .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/80213 To unsubscribe, visit

Change in vdsm[master]: net: import config from vdsm.common.config

2017-08-17 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: import config from vdsm.common.config .. Patch Set 7: http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_ma

Change in vdsm[master]: net: import config from vdsm.common.config

2017-08-17 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: import config from vdsm.common.config .. Patch Set 7: ci please build -- To view, visit https://gerrit.ovirt.org/79981 To unsubscr

Change in vdsm[master]: checkimages hook: split line for readability

2017-08-17 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80394 ) Change subject: checkimages hook: split line for readability .. checkimages hook: split line for readability

Change in vdsm[master]: checkimages hook: avoid using execCmd(sync=False)

2017-08-17 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: checkimages hook: avoid using execCmd(sync=False) .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/80212/2/vdsm_hooks/checkimage

Change in vdsm[master]: dpdk: call flush ip only on non dpdk devices

2017-08-17 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: dpdk: call flush ip only on non dpdk devices .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/80688/1/lib/vdsm/network/ifacquire

Change in vdsm[master]: net: Remove unused function: ifaceUsed

2017-08-17 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Remove unused function: ifaceUsed .. Patch Set 1: Code-Review+2 heh, last user dropped in commit 8eeedf1 -- To view, visit https

Change in vdsm[master]: net: Remove unused function: ifaceUsed

2017-08-17 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80738 ) Change subject: net: Remove unused function: ifaceUsed .. net: Remove unused function: ifaceUsed Change-Id:

Change in vdsm[master]: vdsm tool configurators: bond_defaults - do not depend on time

2017-08-17 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80750 ) Change subject: vdsm tool configurators: bond_defaults - do not depend on time .. vdsm tool configurators: bo

Change in vdsm[master]: vdsm tool configurators: bond_defaults - do not depend on time

2017-08-17 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: vdsm tool configurators: bond_defaults - do not depend on time .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org

Change in vdsm[ovirt-4.1]: vm: Log changes in drive extension info

2017-08-17 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: vm: Log changes in drive extension info .. Patch Set 3: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/80428 To uns

Change in vdsm[ovirt-4.1]: vm: Log changes in drive extension info

2017-08-17 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/80428 ) Change subject: vm: Log changes in drive extension info .. vm: Log changes in drive extension info Each time

Change in vdsm[ovirt-4.1]: vm: Log changes in drive extension info

2017-08-17 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: vm: Log changes in drive extension info .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/80428 To unsubscribe

Change in vdsm[ovirt-4.1]: vm: Use time.Clock for timing extend flow

2017-08-17 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/80427 ) Change subject: vm: Use time.Clock for timing extend flow .. vm: Use time.Clock for timing extend flow Use t

Change in vdsm[ovirt-4.1]: vm: Use time.Clock for timing extend flow

2017-08-17 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: vm: Use time.Clock for timing extend flow .. Patch Set 3: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/80427 To u

Change in vdsm[ovirt-4.1]: time: Add a Clock utility for timing complex flows

2017-08-17 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/80426 ) Change subject: time: Add a Clock utility for timing complex flows .. time: Add a Clock utility for timing co

Change in vdsm[ovirt-4.1]: time: Add a Clock utility for timing complex flows

2017-08-17 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: time: Add a Clock utility for timing complex flows .. Patch Set 2: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/8

Change in vdsm[ovirt-4.1]: vm: Use time.Clock for timing extend flow

2017-08-17 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: vm: Use time.Clock for timing extend flow .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/80427 To unsubscribe

Change in vdsm[ovirt-4.1]: time: Add a Clock utility for timing complex flows

2017-08-17 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: time: Add a Clock utility for timing complex flows .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/80426 To

Change in vdsm[ovirt-4.1]: vm: Log the time took to extend a volume

2017-08-17 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/79969 ) Change subject: vm: Log the time took to extend a volume .. vm: Log the time took to extend a volume Measure

Change in vdsm[ovirt-4.1]: vm: Log the time took to extend a volume

2017-08-17 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: vm: Log the time took to extend a volume .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/79969 To unsubscribe

Change in vdsm[master]: virt: metadata: support network storage

2017-08-17 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: virt: metadata: support network storage .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/80699 To unsubscribe

Change in vdsm[master]: move exec_sync_bytes to common.cmdutils.exec_cmd

2017-08-17 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79693 ) Change subject: move exec_sync_bytes to common.cmdutils.exec_cmd .. move exec_sync_bytes to common.cmdutils.e

Change in vdsm[master]: cmdutils: add env to exec_cmd()'s args

2017-08-17 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79694 ) Change subject: cmdutils: add env to exec_cmd()'s args .. cmdutils: add env to exec_cmd()'s args Expose Pope

Change in vdsm[master]: virt net: vhost custom property with a wrong net name

2017-08-16 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: virt net: vhost custom property with a wrong net name .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/80672 To

Change in vdsm[master]: virt net: vhost custom property with a wrong net name

2017-08-16 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80672 ) Change subject: virt net: vhost custom property with a wrong net name .. virt net: vhost custom property with

Change in vdsm[master]: net: Introduce iface interface driver

2017-08-16 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80169 ) Change subject: net: Introduce iface interface driver .. net: Introduce iface interface driver The iface int

Change in vdsm[master]: net: Introduce iface interface driver

2017-08-16 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Introduce iface interface driver .. Patch Set 10: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/80169/10/lib/vdsm/network

Change in vdsm[master]: net: tests: Migrate testFailWithInvalidBridgeName to the new...

2017-08-15 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80547 ) Change subject: net: tests: Migrate testFailWithInvalidBridgeName to the new func tests. .. net: tests: Migr

Change in vdsm[master]: net: tests: Relocate a test to the public methods.

2017-08-15 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80216 ) Change subject: net: tests: Relocate a test to the public methods. .. net: tests: Relocate a test to the publ

Change in vdsm[master]: net: netinfo: Detect early that an iface is missing

2017-08-15 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80185 ) Change subject: net: netinfo: Detect early that an iface is missing .. net: netinfo: Detect early that an ifa

Change in vdsm[master]: net: Extract ethtool to its own module

2017-08-15 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80068 ) Change subject: net: Extract ethtool to its own module .. net: Extract ethtool to its own module ethtool is

Change in vdsm[master]: net: Extract ethtool to its own module

2017-08-15 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Extract ethtool to its own module .. Patch Set 5: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/80068 To

Change in vdsm[master]: net: netinfo: Detect early that an iface is missing

2017-08-15 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: netinfo: Detect early that an iface is missing .. Patch Set 5: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: net tests: Define switch type parametrize at netfunctestlib

2017-08-14 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80457 ) Change subject: net tests: Define switch type parametrize at netfunctestlib .. net tests: Define switch type

Change in vdsm[master]: net tests: Relocate network (new) functional tests to its ow...

2017-08-14 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79725 ) Change subject: net tests: Relocate network (new) functional tests to its own folder .. net tests: Relocate

Change in vdsm[master]: net tests: Run functional tests using pytest

2017-08-14 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79727 ) Change subject: net tests: Run functional tests using pytest .. net tests: Run functional tests using pytest

Change in vdsm[master]: net tests: Define switch type parametrize at netfunctestlib

2017-08-14 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net tests: Define switch type parametrize at netfunctestlib .. Patch Set 3: Code-Review+2 raising -- To view, visit https

Change in vdsm[master]: net tests: Run functional tests using pytest

2017-08-14 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net tests: Run functional tests using pytest .. Patch Set 12: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/79727

Change in vdsm[master]: net tests: Relocate network (new) functional tests to its ow...

2017-08-14 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net tests: Relocate network (new) functional tests to its own folder .. Patch Set 7: Code-Review+2 raising -- To view, visit https

Change in vdsm[master]: virt: Make sure all hotunplug calls update domain descriptor

2017-08-14 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: virt: Make sure all hotunplug calls update domain descriptor .. Patch Set 1: Code-Review+2 Sounds legit, raising scores. -- To view

Change in vdsm[master]: virt: Make sure all hotunplug calls update domain descriptor

2017-08-14 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80609 ) Change subject: virt: Make sure all hotunplug calls update domain descriptor .. virt: Make sure all hotunplug

Change in vdsm[ovirt-4.1]: net: Wait for vlan link creation when bond-vlan-dhcp is used

2017-08-14 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80607 ) Change subject: net: Wait for vlan link creation when bond-vlan-dhcp is used .. net: Wait for vlan link creat

Change in vdsm[ovirt-4.1]: net: Wait for vlan link creation when bond-vlan-dhcp is used

2017-08-14 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Wait for vlan link creation when bond-vlan-dhcp is used .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: net: Wait for vlan link creation when bond-vlan-dhcp is used

2017-08-14 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Wait for vlan link creation when bond-vlan-dhcp is used .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: net: Wait for vlan link creation when bond-vlan-dhcp is used

2017-08-14 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80505 ) Change subject: net: Wait for vlan link creation when bond-vlan-dhcp is used .. net: Wait for vlan link creat

Change in vdsm[ovirt-4.1]: m2cutils: fix a typo in SSL_OP_NO_TLSv1_1 constant

2017-08-14 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/80586 ) Change subject: m2cutils: fix a typo in SSL_OP_NO_TLSv1_1 constant .. m2cutils: fix a typo in SSL_OP_NO_TLSv1

Change in vdsm[ovirt-4.1]: m2cutils: fix a typo in SSL_OP_NO_TLSv1_1 constant

2017-08-14 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has removed a vote on this change. Change subject: m2cutils: fix a typo in SSL_OP_NO_TLSv1_1 constant .. Removed Verified-1 by gerrit-hooks -- To view, visit https://gerrit.ovirt.org/8058

Change in vdsm[ovirt-4.1]: m2cutils: fix a typo in SSL_OP_NO_TLSv1_1 constant

2017-08-14 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: m2cutils: fix a typo in SSL_OP_NO_TLSv1_1 constant .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/80586 To

Change in vdsm[master]: net: Wait for vlan link creation when bond-vlan-dhcp is used

2017-08-13 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Wait for vlan link creation when bond-vlan-dhcp is used .. Patch Set 4: which process would you like to wait for? the vdsm-requested

Change in vdsm[master]: net: Remove redundant hasattr calls.

2017-08-13 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80217 ) Change subject: net: Remove redundant hasattr calls. .. net: Remove redundant hasattr calls. IPAddressData _

Change in vdsm[master]: net: don't use properties internally.

2017-08-13 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80218 ) Change subject: net: don't use properties internally. .. net: don't use properties internally. IPAddressData

Change in vdsm[master]: net: Wait for vlan link creation when bond-vlan-dhcp is used

2017-08-13 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Wait for vlan link creation when bond-vlan-dhcp is used .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/80505/4//COMMIT_MS

Change in vdsm[master]: net: tests: Remove testSetupNetworksNiclessBridgeless

2017-08-13 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80549 ) Change subject: net: tests: Remove testSetupNetworksNiclessBridgeless .. net: tests: Remove testSetupNetworks

Change in vdsm[master]: net: Wait for vlan link creation when bond-vlan-dhcp is used

2017-08-13 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Wait for vlan link creation when bond-vlan-dhcp is used .. Patch Set 4: Code-Review+1 (2 comments) waiting for Petr and reply

Change in vdsm[ovirt-4.1]: net: Hide zero-mac nics only if they are identified as vmfex

2017-08-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Hide zero-mac nics only if they are identified as vmfex .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org

Change in vdsm[ovirt-4.1]: net: Hide zero-mac nics only if they are identified as vmfex

2017-08-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80372 ) Change subject: net: Hide zero-mac nics only if they are identified as vmfex .. net: Hide zero-mac nics only

Change in vdsm[master]: Revert "hooking: move to lib"

2017-08-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Revert "hooking: move to lib" .. Patch Set 3: Code-Review+2 disappointing, but we cannot keep master broken. -- To view, v

Change in vdsm[master]: Revert "hooking: move to lib"

2017-08-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80444 ) Change subject: Revert "hooking: move to lib" .. Revert "hooking: move to lib" This reverts commit 6687ba74e

Change in vdsm[master]: net: Wait for vlan link creation when bond-vlan-dhcp is used

2017-08-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Wait for vlan link creation when bond-vlan-dhcp is used .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/80505/2/lib/vdsm/n

Change in vdsm[master]: gluster: Fix error when brick is on a btrfs subvolume

2017-08-09 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: gluster: Fix error when brick is on a btrfs subvolume .. Patch Set 3: please add yourself to https://gerrit.ovirt.org/#/q/project:jenkins

Change in vdsm[master]: hooking: change vdsm hooks imports

2017-08-09 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: hooking: change vdsm hooks imports .. Patch Set 3: Code-Review-1 we need to understand and fix the current breakage before fixing it

Change in vdsm[master]: Revert "hooking: move to lib"

2017-08-09 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Revert "hooking: move to lib" .. Patch Set 3: (though I would surely prefer a proper fix) -- To view, visit https://gerrit.ovirt.org/80

Change in vdsm[master]: Revert "hooking: move to lib"

2017-08-09 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Revert "hooking: move to lib" .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/80444 To unsubscr

Change in vdsm[master]: virt net: Avoid removing the display network when not defined

2017-08-09 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: virt net: Avoid removing the display network when not defined .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c

Change in vdsm[master]: Revert "hooking: move to lib"

2017-08-09 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: Revert "hooking: move to lib" .. Patch Set 2: I don't know the reason. only the bug-url for the regression -- To view, visit https://ge

Change in vdsm[master]: Revert "hooking: move to lib"

2017-08-09 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: Revert "hooking: move to lib" .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/80444 To unsubscribe, visit https://

Change in vdsm[master]: Revert "hooking: move to lib"

2017-08-09 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has uploaded a new change for review. Change subject: Revert "hooking: move to lib" .. Revert "hooking: move to lib" This reverts commit 6687ba74e74fcd18d20fcce00349aca5adf38a30. Change-Id:

Change in vdsm[master]: Openstacknet hooks must check provider type to run

2017-08-09 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Openstacknet hooks must check provider type to run .. Patch Set 2: Havn't we agreed to solve this in Engine? -- To view, visit https://

Change in vdsm[master]: virt net: Avoid removing the display network when not defined

2017-08-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: virt net: Avoid removing the display network when not defined .. Patch Set 1: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c

Change in vdsm[master]: checkimages hook: split line for readability

2017-08-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: checkimages hook: split line for readability .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/80394 To unsubscribe,

Change in vdsm[master]: checkimages hook: avoid using execCmd(sync=False)

2017-08-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: checkimages hook: avoid using execCmd(sync=False) .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/80212 To unsubsc

Change in vdsm[master]: checkimages hook: split line for readability

2017-08-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: checkimages hook: split line for readability .. checkimages hook: split line for readability Change-Id: Ic7ae180c3386ed7991150cff4ce5e0d

Change in vdsm[ovirt-4.1]: ssl: handle handshake errors

2017-08-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/80373 ) Change subject: ssl: handle handshake errors .. ssl: handle handshake errors A previous patch that handled t

Change in vdsm[ovirt-4.1]: ssl: handle handshake errors

2017-08-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: ssl: handle handshake errors .. Patch Set 1: backport from https://gerrit.ovirt.org/#/c/79668/ -- To view, visit https://gerrit.ovirt.o

Change in vdsm[ovirt-4.1]: ssl: handle handshake errors

2017-08-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has removed a vote on this change. Change subject: ssl: handle handshake errors .. Removed Verified-1 by gerrit-hooks -- To view, visit https://gerrit.ovirt.org/80373 To unsubscribe, visi

Change in vdsm[ovirt-4.1]: ssl: handle handshake errors

2017-08-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: ssl: handle handshake errors .. Patch Set 1: you didn't use the right change-id I99cfa35e608f429640455c35495be1783854e3da :\ -- To view

Change in vdsm[ovirt-4.1]: ssl: handle handshake errors

2017-08-08 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: ssl: handle handshake errors .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/80373 To unsubscribe, visit https

Change in vdsm[master]: net: Report empty LLDP TLV lists for operationally-down inte...

2017-08-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80339 ) Change subject: net: Report empty LLDP TLV lists for operationally-down interfaces .. net: Report empty LLDP

Change in vdsm[master]: net: Report empty LLDP TLV lists for operationally-down inte...

2017-08-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Report empty LLDP TLV lists for operationally-down interfaces .. Patch Set 7: Code-Review+2 -- To view, visit https

Change in vdsm[master]: net: Report empty LLDP TLV lists for operationally-down inte...

2017-08-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Report empty LLDP TLV lists for operationally-down interfaces .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/80339/6//CO

Change in vdsm[ovirt-4.1]: m2cutils: support excluding OP_NO_TLSv1_2

2017-08-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80363 ) Change subject: m2cutils: support excluding OP_NO_TLSv1_2 .. m2cutils: support excluding OP_NO_TLSv1_2 OP_NO

Change in vdsm[ovirt-4.1]: m2cutils: support excluding OP_NO_TLSv1_2

2017-08-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: m2cutils: support excluding OP_NO_TLSv1_2 .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/80363 To unsubscribe

Change in vdsm[master]: net: Report empty LLDP TLV lists for operational down interf...

2017-08-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Report empty LLDP TLV lists for operational down interfaces .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/80339/4//COMMI

Change in vdsm[master]: ssl: handle handshake errors

2017-08-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: ssl: handle handshake errors .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/79668 To unsubscribe, visit https

Change in vdsm[master]: ssl: handle handshake errors

2017-08-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79668 ) Change subject: ssl: handle handshake errors .. ssl: handle handshake errors There are two possible errors (

Change in vdsm[master]: net: Hide zero-mac nics only if they are identified as vmfex

2017-08-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80362 ) Change subject: net: Hide zero-mac nics only if they are identified as vmfex .. net: Hide zero-mac nics only

Change in vdsm[master]: net: Hide zero-mac nics only if they are identified as vmfex

2017-08-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Hide zero-mac nics only if they are identified as vmfex .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org

Change in vdsm[ovirt-4.1]: m2cutils: support excluding OP_NO_TLSv1_2

2017-08-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: m2cutils: support excluding OP_NO_TLSv1_2 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/80363 To unsubscribe

Change in vdsm[ovirt-4.1]: m2cutils: support excluding OP_NO_TLSv1_2

2017-08-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has removed a vote on this change. Change subject: m2cutils: support excluding OP_NO_TLSv1_2 .. Removed Verified-1 by gerrit-hooks -- To view, visit https://gerrit.ovirt.org/80363 To unsu

Change in vdsm[master]: build: remove constants.py from dist package

2017-08-07 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79925 ) Change subject: build: remove constants.py from dist package .. build: remove constants.py from dist package

Change in vdsm[master]: ssl: handle handshake errors

2017-08-07 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: ssl: handle handshake errors .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/79668 To unsubscribe, visit https

Change in vdsm[master]: build: remove constants.py from dist package

2017-08-07 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: build: remove constants.py from dist package .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/79925/3/automation/check-patch.sh

Change in vdsm[master]: api: ping2 and confirmConnectivity

2017-08-07 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: api: ping2 and confirmConnectivity .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/80119/5/tests/functional/utils.py File tests

Change in vdsm[ovirt-4.1]: net: Report lldp through new getLldp command

2017-08-07 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Report lldp through new getLldp command .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/80194/1/lib/vdsm/api/vdsm-api.yml

Change in vdsm[master]: net: Introduce link vlan validations.

2017-08-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80170 ) Change subject: net: Introduce link vlan validations. .. net: Introduce link vlan validations. This patch in

Change in vdsm[master]: lvs-stats: Analyze sosreport lvm commands output

2017-08-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: lvs-stats: Analyze sosreport lvm commands output .. Patch Set 2: -Code-Review -- To view, visit https://gerrit.ovirt.org/79698 To

Change in vdsm[master]: lvs-stats: Analyze sosreport lvm commands output

2017-08-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: lvs-stats: Analyze sosreport lvm commands output .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/79698/2//COMMIT_MSG Commit Mes

Change in vdsm[master]: net: Introducing validate_bond_configuration.

2017-08-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79967 ) Change subject: net: Introducing validate_bond_configuration. .. net: Introducing validate_bond_configuration

<    1   2   3   4   5   6   7   8   9   10   >