Change in vdsm[master]: net: eliminate LEGACY_MANAGEMENT_NETWORKS

2017-07-11 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79243 ) Change subject: net: eliminate LEGACY_MANAGEMENT_NETWORKS .. net: eliminate LEGACY_MANAGEMENT_NETWORKS LEGAC

Change in vdsm[master]: net: eliminate LEGACY_MANAGEMENT_NETWORKS

2017-07-11 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: eliminate LEGACY_MANAGEMENT_NETWORKS .. Patch Set 2: Verified+1 too simple to bother with anything beyond unit tests. -- To view,

Change in vdsm[master]: net: eliminate LEGACY_MANAGEMENT_NETWORKS

2017-07-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: net: eliminate LEGACY_MANAGEMENT_NETWORKS .. net: eliminate LEGACY_MANAGEMENT_NETWORKS LEGACY_MANAGEMENT_NETWORKS are used only once in

Change in vdsm[master]: concurrent: Log BaseException when threads finish

2017-07-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: concurrent: Log BaseException when threads finish .. Patch Set 1: Code-Review+1 did someone raise a string somewhere?! -- To view

Change in vdsm[master]: spec: Conditionally use gluster version

2017-07-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: Conditionally use gluster version .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/79128 To unsubscribe

Change in vdsm[master]: spec: Conditionally use gluster version

2017-07-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79128 ) Change subject: spec: Conditionally use gluster version .. spec: Conditionally use gluster version Use glust

Change in vdsm[master]: [WIP] iscsi: netIfaceName: expect network name

2017-07-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: [WIP] iscsi: netIfaceName: expect network name .. [WIP] iscsi: netIfaceName: expect network name This is pseudo code for letting Engine

Change in vdsm[master]: net: Report lldp through new getLldp command

2017-07-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Report lldp through new getLldp command .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/79093/5/lib/vdsm/network/api.py Fi

Change in vdsm[master]: spec: install tmpfiles.d/vdsm.conf and libvirtd.service.d/un...

2017-07-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: install tmpfiles.d/vdsm.conf and libvirtd.service.d/unlimited-core.conf in Makefile .. Patch Set 1: Verified+1 no real change in

Change in vdsm[master]: spec: install 85-vdsm-hook-fcoe.preset in Makefile

2017-07-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: install 85-vdsm-hook-fcoe.preset in Makefile .. Patch Set 1: Verified+1 no real change in rpmdiff vdsm-4.20.1-165.git1cbc288.fc25

Change in vdsm[master]: spec: install 85-vdsmd.preset in Makefile

2017-07-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: install 85-vdsmd.preset in Makefile .. Patch Set 1: Verified+1 no real change in rpmdiff vdsm-4.20.1-165.git1cbc288.fc25.x86_64.r

Change in vdsm[ovirt-4.1]: ssl: wrong protocol used by the client

2017-07-10 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: ssl: wrong protocol used by the client .. Patch Set 7: Code-Review+2 I prefer that. more clear to me -- To view, visit https

Change in vdsm[ovirt-4.1]: ssl: wrong protocol used by the client

2017-07-10 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: ssl: wrong protocol used by the client .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/79194/6/lib/yajsonrpc/stompreactor.py Fi

Change in vdsm[ovirt-4.1]: ssl: wrong protocol used by the client

2017-07-10 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: ssl: wrong protocol used by the client .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/79194/6/lib/yajsonrpc/stompreactor.py Fi

Change in vdsm[ovirt-4.1]: ssl: wrong protocol used by the client

2017-07-10 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: ssl: wrong protocol used by the client .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/79194/5//COMMIT_MSG Commit Message: Lin

Change in vdsm[ovirt-4.1]: ssl: wrong protocol used by the client

2017-07-10 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: ssl: wrong protocol used by the client .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/79194/5/lib/yajsonrpc/stompreactor.py F

Change in vdsm[ovirt-4.1]: ssl: wrong protocol used by the client

2017-07-10 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: ssl: wrong protocol used by the client .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/79194/4/lib/yajsonrpc/stompreactor.py Fi

Change in vdsm[ovirt-4.1]: ssl: wrong protocol used by the client

2017-07-10 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: ssl: wrong protocol used by the client .. Patch Set 4: (3 comments) sorry, im not sure I understand the fix. added comments https://ger

Change in vdsm[master]: spec: install 85-vdsm-hook-fcoe.preset in Makefile

2017-07-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: install 85-vdsm-hook-fcoe.preset in Makefile .. Patch Set 1: ci please build -- To view, visit https://gerrit.ovirt.org/79218 To

Change in vdsm[master]: spec: install 85-vdsmd.preset in Makefile

2017-07-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: spec: install 85-vdsmd.preset in Makefile .. spec: install 85-vdsmd.preset in Makefile Change-Id: I6b6aabe75cfc00d90fdeb1ae79c72ef7fcec0

Change in vdsm[master]: spec: install tmpfiles.d/vdsm.conf and libvirtd.service.d/un...

2017-07-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: spec: install tmpfiles.d/vdsm.conf and libvirtd.service.d/unlimited-core.conf in Makefile .. spec: install tmpfiles.d/vdsm.conf and libv

Change in vdsm[master]: spec: install 85-vdsm-hook-fcoe.preset in Makefile

2017-07-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: spec: install 85-vdsm-hook-fcoe.preset in Makefile .. spec: install 85-vdsm-hook-fcoe.preset in Makefile Change-Id: I004f15bdf34c5d6f671

Change in vdsm[master]: network: make sure to pass bytes to io.BytesIO

2017-07-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78862 ) Change subject: network: make sure to pass bytes to io.BytesIO .. network: make sure to pass bytes to io.Byte

Change in vdsm[master]: network: make sure to pass bytes to io.BytesIO

2017-07-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: network: make sure to pass bytes to io.BytesIO .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/78862 To

Change in vdsm[master]: spec: install udev-rules in Makefile

2017-07-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79154 ) Change subject: spec: install udev-rules in Makefile .. spec: install udev-rules in Makefile The %install se

Change in vdsm[ovirt-3.6]: net: Generate dump bonding options on boot and upgrade

2017-07-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78780 ) Change subject: net: Generate dump bonding options on boot and upgrade .. net: Generate dump bonding options

Change in vdsm[ovirt-3.6]: net: Generate dump bonding options on boot and upgrade

2017-07-10 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Generate dump bonding options on boot and upgrade .. Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/78780

Change in vdsm[ovirt-3.6]: ifcfg: ad_actor_system can not be reset to its default value

2017-07-09 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78898 ) Change subject: ifcfg: ad_actor_system can not be reset to its default value .. ifcfg: ad_actor_system can no

Change in vdsm[ovirt-3.6]: ifcfg: ad_actor_system can not be reset to its default value

2017-07-09 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: ad_actor_system can not be reset to its default value .. Patch Set 6: Code-Review+2 taking this harmless, non-controversial patch

Change in vdsm[ovirt-3.6]: ifcfg: ad_actor_system can not be reset to its default value

2017-07-09 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has removed gerrit-hooks from this change. ( https://gerrit.ovirt.org/78898 ) Change subject: ifcfg: ad_actor_system can not be reset to its default value .. Removed reviewer gerrit-hooks w

Change in vdsm[ovirt-3.6]: net: Generate dump bonding options on boot and upgrade

2017-07-09 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has removed a vote on this change. Change subject: net: Generate dump bonding options on boot and upgrade .. Removed Verified-1 by gerrit-hooks -- To view, visit https://gerrit.ovirt.org/

Change in vdsm[ovirt-4.1]: net: On MTU change to the default value update the ifcfg file

2017-07-09 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/79162 ) Change subject: net: On MTU change to the default value update the ifcfg file .. net: On MTU change to the de

Change in vdsm[ovirt-4.1]: net: Relocate DEFAULT_MTU costant to link.iface module

2017-07-09 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/79161 ) Change subject: net: Relocate DEFAULT_MTU costant to link.iface module .. net: Relocate DEFAULT_MTU costant t

Change in vdsm[master]: Move fencing code to host/fencing.py

2017-07-09 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: Move fencing code to host/fencing.py .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/78927/2/lib/vdsm/host/fencing.py File lib/

Change in vdsm[ovirt-4.1]: net: On MTU change to the default value update the ifcfg file

2017-07-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has removed a vote on this change. Change subject: net: On MTU change to the default value update the ifcfg file .. Removed Verified-1 by gerrit-hooks -- To view, visit https://gerrit.ovi

Change in vdsm[ovirt-4.1]: net: On MTU change to the default value update the ifcfg file

2017-07-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: On MTU change to the default value update the ifcfg file .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org

Change in vdsm[ovirt-4.1]: net: Relocate DEFAULT_MTU costant to link.iface module

2017-07-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has removed gerrit-hooks from this change. ( https://gerrit.ovirt.org/79161 ) Change subject: net: Relocate DEFAULT_MTU costant to link.iface module .. Removed reviewer gerrit-hooks with th

Change in vdsm[ovirt-4.1]: net: Relocate DEFAULT_MTU costant to link.iface module

2017-07-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Relocate DEFAULT_MTU costant to link.iface module .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/79161

Change in vdsm[master]: spec: install udev-rules in Makefile

2017-07-08 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: install udev-rules in Makefile .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/79154/1/lib/vdsm/storage/Makefile.am File

Change in vdsm[master]: spec: install udev-rules in Makefile

2017-07-07 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: install udev-rules in Makefile .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/79154 To unsubscribe, visit h

Change in vdsm[master]: packaging: eliminate /usr/lib/systemd/systemd-vdsmd

2017-07-07 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: packaging: eliminate /usr/lib/systemd/systemd-vdsmd .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/79153 To unsub

Change in vdsm[master]: network: todo py3 nettestlib Tap

2017-07-07 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: network: todo py3 nettestlib Tap .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/78863/3/tests/network/nettestlib.py File tests

Change in vdsm[master]: spec: install udev-rules in Makefile

2017-07-07 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: install udev-rules in Makefile .. Patch Set 1: OST: http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_ma

Change in vdsm[master]: spec: install udev-rules in Makefile

2017-07-07 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: install udev-rules in Makefile .. Patch Set 1: ci please build -- To view, visit https://gerrit.ovirt.org/79154 To unsubscribe, v

Change in vdsm[master]: spec: install udev-rules in Makefile

2017-07-07 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: spec: install udev-rules in Makefile .. spec: install udev-rules in Makefile The %install section of the spec file should be much cleane

Change in vdsm[master]: packaging: eliminate /usr/lib/systemd/systemd-vdsmd

2017-07-07 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: packaging: eliminate /usr/lib/systemd/systemd-vdsmd .. packaging: eliminate /usr/lib/systemd/systemd-vdsmd This script was introduced ma

Change in vdsm[master]: spec: drop VDSMRPCPYLIBDIR

2017-07-07 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78910 ) Change subject: spec: drop VDSMRPCPYLIBDIR .. spec: drop VDSMRPCPYLIBDIR The spec file always replaces @VDSM

Change in vdsm[ovirt-3.6]: net: Generate dump bonding options on boot and upgrade

2017-07-07 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Generate dump bonding options on boot and upgrade .. Patch Set 8: Code-Review-1 -1 for visibility -- To view, visit https

Change in vdsm[ovirt-3.6]: ifcfg: ad_actor_system can not be reset to its default value

2017-07-07 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has removed Jenkins CI from this change. ( https://gerrit.ovirt.org/78898 ) Change subject: ifcfg: ad_actor_system can not be reset to its default value .. Removed reviewer Jenkins CI with

Change in vdsm[master]: spec: drop VDSMRPCPYLIBDIR

2017-07-07 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: drop VDSMRPCPYLIBDIR .. Patch Set 4: Verified+1 finally, unrealted OST failures do not fail this. -- To view, visit https://gerri

Change in vdsm[master]: spec: drop VDSMRPCPYLIBDIR

2017-07-07 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: drop VDSMRPCPYLIBDIR .. Patch Set 4: -Verified -- To view, visit https://gerrit.ovirt.org/78910 To unsubscribe, visit https://gerr

Change in vdsm[master]: spec: drop VDSMRPCPYLIBDIR

2017-07-07 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: drop VDSMRPCPYLIBDIR .. Patch Set 4: OST: http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/768/

Change in vdsm[master]: net: On MTU change to the default value update the ifcfg file

2017-07-07 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: On MTU change to the default value update the ifcfg file .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: net: On MTU change to the default value update the ifcfg file

2017-07-07 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79110 ) Change subject: net: On MTU change to the default value update the ifcfg file .. net: On MTU change to the de

Change in vdsm[master]: net: Relocate DEFAULT_MTU costant to link.iface module

2017-07-07 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Relocate DEFAULT_MTU costant to link.iface module .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/79109

Change in vdsm[master]: net: Relocate DEFAULT_MTU costant to link.iface module

2017-07-07 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79109 ) Change subject: net: Relocate DEFAULT_MTU costant to link.iface module .. net: Relocate DEFAULT_MTU costant t

Change in vdsm[master]: net: Relocate DEFAULT_MTU costant to link.iface module

2017-07-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Relocate DEFAULT_MTU costant to link.iface module .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/79109

Change in vdsm[master]: Move fencing code to host/fencing.py

2017-07-06 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: Move fencing code to host/fencing.py .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/78927/2/lib/vdsm/host/fencing.py File lib/

Change in vdsm[master]: spec: drop VDSMRPCPYLIBDIR

2017-07-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: drop VDSMRPCPYLIBDIR .. Patch Set 3: ci please build -- To view, visit https://gerrit.ovirt.org/78910 To unsubscribe, visit https

Change in vdsm[master]: net: Increase netlink socket buffer size to 512KB

2017-07-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Increase netlink socket buffer size to 512KB .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/78928/2//COMMIT_MSG Commit Me

Change in vdsm[master]: virt: move the libvirt migration hook under lib/

2017-07-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: virt: move the libvirt migration hook under lib/ .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/78569 To

Change in vdsm[master]: network: make sure to pass bytes to io.BytesIO

2017-07-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: network: make sure to pass bytes to io.BytesIO .. Patch Set 4: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/78862/4/tests

Change in vdsm[master]: mimicking and error, please ingnore

2017-07-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: mimicking and error, please ingnore .. Patch Set 2: ci please build -- To view, visit https://gerrit.ovirt.org/79021 To unsubscribe, vi

Change in vdsm[master]: mimicking and error, please ingnore

2017-07-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: mimicking and error, please ingnore .. Patch Set 1: to verify https://gerrit.ovirt.org/78921 -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: mimicking and error, please ingnore

2017-07-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: mimicking and error, please ingnore .. Patch Set 1: ci please build -- To view, visit https://gerrit.ovirt.org/79021 To unsubscribe, vi

Change in vdsm[master]: mimicking and error, please ingnore

2017-07-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: mimicking and error, please ingnore .. mimicking and error, please ingnore Change-Id: I25597b866e25f3d74f1fa96f549b6f86a4bde831 Signed-o

Change in vdsm[ovirt-3.6]: ifcfg: ad_actor_system can not be reset to its default value

2017-07-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: ad_actor_system can not be reset to its default value .. Patch Set 3: ci please build -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: network: to_str and to_binary

2017-07-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78389 ) Change subject: network: to_str and to_binary .. network: to_str and to_binary Move to_str and to_binary fun

Change in vdsm[master]: network: replace Popen calls with exec_sync

2017-07-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/77946 ) Change subject: network: replace Popen calls with exec_sync .. network: replace Popen calls with exec_sync I

Change in vdsm[master]: network: make ipwrapper.drv_name Python 3 compatible

2017-07-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/77940 ) Change subject: network: make ipwrapper.drv_name Python 3 compatible .. network: make ipwrapper.drv_name Pyth

Change in vdsm[master]: network: use bytes explicitly in netinfo.IPv4toMapped

2017-07-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78861 ) Change subject: network: use bytes explicitly in netinfo.IPv4toMapped .. network: use bytes explicitly in net

Change in vdsm[master]: Revert stomp client reconect patches

2017-07-04 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Revert stomp client reconect patches .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/79006 To unsubscribe

Change in vdsm[master]: Revert stomp client reconect patches

2017-07-04 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79006 ) Change subject: Revert stomp client reconect patches .. Revert stomp client reconect patches This reverts al

Change in vdsm[master]: network: make ipwrapper.drv_name Python 3 compatible

2017-07-04 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: network: make ipwrapper.drv_name Python 3 compatible .. Patch Set 17: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/77940 To

Change in vdsm[master]: stomp: add integration tests for client reconnect

2017-07-04 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78713 ) Change subject: stomp: add integration tests for client reconnect .. stomp: add integration tests for client

Change in vdsm[master]: stomp: set default heartbeat values and add grace period

2017-07-04 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78925 ) Change subject: stomp: set default heartbeat values and add grace period .. stomp: set default heartbeat valu

Change in vdsm[master]: stomp: set default heartbeat values and add grace period

2017-07-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: stomp: set default heartbeat values and add grace period .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/78925

Change in vdsm[ovirt-3.6]: ifcfg: ad_actor_system can not be reset to its default value

2017-07-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: ad_actor_system can not be reset to its default value .. Patch Set 2: ci please build -- To view, visit https://gerrit.ovirt.org

Change in vdsm[ovirt-4.1]: net: Unneeded newline is added when updating only the mtu

2017-07-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Unneeded newline is added when updating only the mtu .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: net: Unneeded newline is added when updating only the mtu

2017-07-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78890 ) Change subject: net: Unneeded newline is added when updating only the mtu .. net: Unneeded newline is added w

Change in vdsm[master]: net: Unneeded newline is added when updating only the mtu

2017-07-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Unneeded newline is added when updating only the mtu .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: spec: drop VDSMRPCPYLIBDIR

2017-07-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: drop VDSMRPCPYLIBDIR .. Patch Set 2: Verified-1 -- To view, visit https://gerrit.ovirt.org/78910 To unsubscribe, visit https://ger

Change in vdsm[master]: spec: drop VDSMRPCPYLIBDIR

2017-07-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: drop VDSMRPCPYLIBDIR .. Patch Set 2: Verified+1 ost fails -- To view, visit https://gerrit.ovirt.org/78910 To unsubscribe, visit

Change in vdsm[master]: Move fencing code to host/fencing.py

2017-07-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has uploaded a new change for review. Change subject: Move fencing code to host/fencing.py .. Move fencing code to host/fencing.py The intention is to split the fence code to be in generic l

Change in vdsm[master]: spec: drop VDSMRPCPYLIBDIR

2017-07-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: drop VDSMRPCPYLIBDIR .. Patch Set 2: maybe this one: http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_m

Change in vdsm[master]: spec: drop VDSMRPCPYLIBDIR

2017-07-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: drop VDSMRPCPYLIBDIR .. Patch Set 2: ci please build -- To view, visit https://gerrit.ovirt.org/78910 To unsubscribe, visit https

Change in vdsm[master]: python3: Fix UUID packing/unpacking on python 3

2017-07-02 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: python3: Fix UUID packing/unpacking on python 3 .. Patch Set 14: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/78632 To

Change in vdsm[master]: spec: drop VDSMRPCPYLIBDIR

2017-07-02 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: drop VDSMRPCPYLIBDIR .. Patch Set 1: ost: http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/740/

Change in vdsm[master]: move vm.py to lib/vdsm/virt

2017-07-02 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move vm.py to lib/vdsm/virt .. Patch Set 4: ci please build -- To view, visit https://gerrit.ovirt.org/78797 To unsubscribe, visit http

Change in vdsm[master]: spec: drop VDSMRPCPYLIBDIR

2017-07-02 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: drop VDSMRPCPYLIBDIR .. Patch Set 1: ci please build -- To view, visit https://gerrit.ovirt.org/78910 To unsubscribe, visit https

Change in vdsm[master]: spec: drop VDSMRPCPYLIBDIR

2017-07-02 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: spec: drop VDSMRPCPYLIBDIR .. spec: drop VDSMRPCPYLIBDIR The spec file always replaces @VDSMRPCPYLIBDIR@ with the path of vdsm.rpc packa

Change in vdsm[master]: net: Unneeded newline is added when updating only the mtu

2017-07-02 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Unneeded newline is added when updating only the mtu .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: tests: Add thread leak check for pytest based tests

2017-07-02 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: tests: Add thread leak check for pytest based tests .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/78881/1//COMMIT_MSG Commit

Change in vdsm[master]: stomp: implement client reconnect

2017-07-02 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78536 ) Change subject: stomp: implement client reconnect .. stomp: implement client reconnect After enabling incomi

Change in vdsm[ovirt-4.1]: net: Generate dump bonding options on boot and upgrade

2017-07-02 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Generate dump bonding options on boot and upgrade .. Patch Set 13: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/78804

Change in vdsm[ovirt-3.6]: ifcfg: ad_actor_system can not be reset to its default value

2017-07-02 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: ifcfg: ad_actor_system can not be reset to its default value .. ifcfg: ad_actor_system can not be reset to its default value _restore_de

Change in vdsm[master]: spec: move polkit rules location logic to automake

2017-07-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78551 ) Change subject: spec: move polkit rules location logic to automake .. spec: move polkit rules location logic

Change in vdsm[master]: spec: move polkit rules location logic to automake

2017-06-30 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: move polkit rules location logic to automake .. Patch Set 6: Verified+1 no change in /usr/share/polkit-1/rules.d/10-vdsm-libvirt-ac

Change in vdsm[master]: tests: Remove global panic mocking

2017-06-30 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78592 ) Change subject: tests: Remove global panic mocking .. tests: Remove global panic mocking Global mocking of t

Change in vdsm[master]: move vdsm-gencerts.sh to static

2017-06-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78806 ) Change subject: move vdsm-gencerts.sh to static .. move vdsm-gencerts.sh to static Change-Id: I6e7b573a2eff3

<    1   2   3   4   5   6   7   8   9   10   >