Francesco Romani has submitted this change and it was merged.
Change subject: vm: rename statsAge parameter
..
vm: rename statsAge parameter
rename `statsAge' to `stats_age'.
Now it is pep8 friendlier, and it is easier to
Francesco Romani has submitted this change and it was merged.
Change subject: vm: reformat setUnresponsiveIfTimeout
..
vm: reformat setUnresponsiveIfTimeout
Reformat the order of operations to make clear
on which cases we
Francesco Romani has posted comments on this change.
Change subject: vm: reformat setUnresponsiveIfTimeout
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65812
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: rename statsAge parameter
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65813
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: reformat setUnresponsiveIfTimeout
..
Patch Set 1: Verified+1
verified on branch, same way as master
--
To view, visit https://gerrit.ovirt.org/65812
To
Francesco Romani has posted comments on this change.
Change subject: vm: rename statsAge parameter
..
Patch Set 1: Verified+1
verified on branch, same way as master
--
To view, visit https://gerrit.ovirt.org/65813
To
Francesco Romani has posted comments on this change.
Change subject: migration: use system thread names
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/65503/3/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Hello Dan Kenigsberg, Milan Zamazal, Martin Polednik,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/65812
to review the following change.
Change subject: vm: reformat setUnresponsiveIfTimeout
..
Hello Dan Kenigsberg, Milan Zamazal, Martin Polednik,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/65813
to review the following change.
Change subject: vm: rename statsAge parameter
..
vm:
Hello Dan Kenigsberg, Milan Zamazal,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/65814
to review the following change.
Change subject: vm: introduce a `monitorable' attribute
..
vm: introduce
Francesco Romani has posted comments on this change.
Change subject: caps: return kernelArgs
..
Patch Set 1: Code-Review+2
this means we should improve our automated tests to catch those errors.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: Add new api to get the IO tune policies for all vms
..
Patch Set 11:
let's start from there.
--
To view, visit https://gerrit.ovirt.org/63748
To
Francesco Romani has posted comments on this change.
Change subject: Add new api to get the IO tune policies for all vms
..
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63748
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Refuse to cancel post-copy migrations
..
Patch Set 10:
Right, let's ask libvirt devs if we can and should rely on this behaviour.
After their answer
Francesco Romani has posted comments on this change.
Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes.
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65565
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: osinfo: memoize runtime_kernel_flags
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65716
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: caps: report realtime kernel status
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65715
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes.
..
Patch Set 6: Code-Review+1
(2 comments)
we need to sort out one implementation detail and we are good
Francesco Romani has submitted this change and it was merged.
Change subject: Fix API schema to align with runtime schema
..
Fix API schema to align with runtime schema
Change-Id: Ia1b5e90831fd0e4d9e897baaae4afb68f22e3877
Francesco Romani has posted comments on this change.
Change subject: Fix API schema to align with runtime schema
..
Patch Set 3: Code-Review+2
AFAIK no more builds for oVirt 4.0.5 are planned, so backport to the branch
Francesco Romani has posted comments on this change.
Change subject: vm: ignore more errors in isDomainReadyForCommands
..
Patch Set 13: Verified+1
copied score
--
To view, visit https://gerrit.ovirt.org/65131
To
Francesco Romani has posted comments on this change.
Change subject: vm: introduce a `monitorable' attribute
..
Patch Set 10: Verified+1
The purpose of this patch is
1. make sure VM is not misreported (actually: overzelously
Francesco Romani has uploaded a new change for review.
Change subject: vmstats: user proper way to detect host devices
..
vmstats: user proper way to detect host devices
Lacking better ways, back in time we detected host
Francesco Romani has uploaded a new change for review.
Change subject: network: devices: properly initialize attributes
..
network: devices: properly initialize attributes
The `name' attribute used to be added to devices only
Francesco Romani has posted comments on this change.
Change subject: Add new api to get the IO tune policies for all vms
..
Patch Set 11: Code-Review+1
partial review
--
To view, visit https://gerrit.ovirt.org/63748
To
Francesco Romani has submitted this change and it was merged.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
net: edit nic detached from bridge but still attached to a vlan
Change-Id:
Francesco Romani has posted comments on this change.
Change subject: vm: introduce a `monitorable' attribute
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/65590/8/tests/periodicTests.py
File tests/periodicTests.py:
Francesco Romani has posted comments on this change.
Change subject: caps: report nested virtualization capabilities
..
Patch Set 3: Code-Review+1
looks good to me. Please get ACK(s) from infra devs about the schema change.
Francesco Romani has posted comments on this change.
Change subject: caps: report realtime kernel status
..
Patch Set 2: Code-Review+1
(1 comment)
Looks good to me. Let's have someone from infra approving the schema change.
Francesco Romani has posted comments on this change.
Change subject: caps: report realtime kernel status
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65715/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
PS1,
Francesco Romani has abandoned this change.
Change subject: vm: check stats timeout only for monitorable VMs
..
Abandoned
squashed into 65590
--
To view, visit https://gerrit.ovirt.org/65727
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: check stats timeout only for monitorable VMs
..
Patch Set 4: Code-Review-1
After the changes made to address the race pointed out by Milan, this patche
Francesco Romani has posted comments on this change.
Change subject: tests: improve periodicTests.py
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/65753/1/tests/periodicTests.py
File
Francesco Romani has posted comments on this change.
Change subject: vm: introduce a `monitorable' attribute
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/65590/7/tests/periodicTests.py
File tests/periodicTests.py:
Francesco Romani has posted comments on this change.
Change subject: vm: check stats timeout only for monitorable VMs
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/65727/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Francesco Romani has posted comments on this change.
Change subject: vm: introduce a `monitorable' attribute
..
Patch Set 7: Verified+1
changes since last verification: fixed tests (now they are simpler, and works
OK)
--
To
Francesco Romani has posted comments on this change.
Change subject: vm: rename statsAge parameter
..
Patch Set 9: Verified+1
rebased + commit message updated = lost score
--
To view, visit https://gerrit.ovirt.org/65508
To
Francesco Romani has posted comments on this change.
Change subject: vm: reformat setUnresponsiveIfTimeout
..
Patch Set 9: Verified+1
fixed comment, if jenkins is happy so we are
--
To view, visit
Francesco Romani has uploaded a new change for review.
Change subject: tests: improve periodicTests.py
..
tests: improve periodicTests.py
document a bit better the code and make it easier to understand
the test failures.
Francesco Romani has posted comments on this change.
Change subject: vm: check stats timeout only for monitorable VMs
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/65727/3//COMMIT_MSG
Commit Message:
PS3, Line 21:
Francesco Romani has posted comments on this change.
Change subject: vm: rename statsAge parameter
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/65508/8//COMMIT_MSG
Commit Message:
PS8, Line 10: and it is easier
Francesco Romani has posted comments on this change.
Change subject: vm: reformat setUnresponsiveIfTimeout
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/65504/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS8, Line
Francesco Romani has posted comments on this change.
Change subject: caps: report nested virtualization capabilities
..
Patch Set 2: Code-Review+1
(1 comment)
nice improvement, +2 pending because inline comment
Francesco Romani has posted comments on this change.
Change subject: caps: report realtime kernel status
..
Patch Set 1: Code-Review+1
(3 comments)
https://gerrit.ovirt.org/#/c/65715/1/lib/api/vdsm-api.yml
File
Francesco Romani has posted comments on this change.
Change subject: osinfo: memoize runtime_kernel_flags
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65716
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Report paused VM status in post-copy
..
Patch Set 10: Code-Review+1
please add one test to document this behaviour
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Prevent monitoring of VMs in post-copy
..
Patch Set 10: Code-Review+1
(1 comment)
minor comment inside
Francesco Romani has posted comments on this change.
Change subject: virt: Stop guest agent before switching to post-copy
..
Patch Set 9: Code-Review+1
(1 comment)
minor comment, not worth delaying a +1
Francesco Romani has posted comments on this change.
Change subject: virt: Distinguish between switching to and entering post-copy
migration
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/64143/8/vdsm/virt/vm.py
Francesco Romani has posted comments on this change.
Change subject: virt: Distinguish between switching to and entering post-copy
migration
..
Patch Set 8: Code-Review-1
(1 comment)
minor comment, it should be easy to fix
Francesco Romani has posted comments on this change.
Change subject: virt: Refuse to cancel post-copy migrations
..
Patch Set 10:
Sorry for the delay, let's address the most important question:
- does libvirt guarantee that
Francesco Romani has posted comments on this change.
Change subject: virt: Use a variable for self._vm in MonitorThread action
handling
..
Patch Set 9: Code-Review+2
I usually avoid temporaries unless they are justified. Here
Francesco Romani has posted comments on this change.
Change subject: virt: Destroy VM after post-copy migration failure
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64142
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Fetch only minimum VM stats during post-copy migration
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63552
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: virt: Start all VM related stuff after switching to post-copy
migration
..
Patch Set 9: Code-Review+1
(1 comment)
changing score - it was -1 for visibility
Francesco Romani has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 12: Code-Review+1
(1 comment)
we just need the packages.
Francesco Romani has posted comments on this change.
Change subject: Fix API schema to align with runtime schema
..
Patch Set 3:
fine for me, but for the stable branch we need a 4.0.z bug
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: virt: vm: migration: introduce virt subloggers
..
Patch Set 16: Verified-1
not yet ready
--
To view, visit https://gerrit.ovirt.org/61993
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: migration: coalesce join() into stop()
..
Patch Set 8: Code-Review-1 Verified-1
controversial, needs more work
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: tests: bootstrap the livemerge tests
..
Patch Set 11: Verified-1
not yet ready
--
To view, visit https://gerrit.ovirt.org/62253
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: migration: use system thread names
..
Patch Set 3: Verified+1
verified staring ad htop while migrating VMs.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
..
Patch Set 3: Code-Review+2
a test would be a great addition to help this bug not resurface.
Francesco Romani has posted comments on this change.
Change subject: clientIF: rename recovery thread
..
Patch Set 2: Verified+1
verified running patched vdsm, checking thread (and their names) using htop
during recovery.
--
Francesco Romani has posted comments on this change.
Change subject: Fix API schema to align with runtime schema
..
Patch Set 3:
the bug is targeted 4.1.0-alpha, do we need this in the stable branch?
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: lib: shorten name of libvirt event thread
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/65501
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: lib: shorten name of libvirt event thread
..
Patch Set 2:
verified running Vdsm and using 'htop'
--
To view, visit https://gerrit.ovirt.org/65501
To
Francesco Romani has abandoned this change.
Change subject: vm: a Down domain is not ready for commands
..
Abandoned
so let's stick with 65131 for the time being
--
To view, visit https://gerrit.ovirt.org/65130
To
Francesco Romani has abandoned this change.
Change subject: vm: refactor the monitorResponse handling
..
Abandoned
overkill, we may want to use the new constants - but not now
--
To view, visit https://gerrit.ovirt.org/65539
Francesco Romani has abandoned this change.
Change subject: virt: move valid states list in vmstatus.py
..
Abandoned
not now
--
To view, visit https://gerrit.ovirt.org/65538
To unsubscribe, visit
Francesco Romani has abandoned this change.
Change subject: vm: check commands timeout only on steady state
..
Abandoned
https://gerrit.ovirt.org/65727 is a better fix.
--
To view, visit https://gerrit.ovirt.org/65505
To
Francesco Romani has posted comments on this change.
Change subject: vm: check stats timeout only for monitorable VMs
..
Patch Set 3: Verified+1
verified injecting sleep() in the domDependentInit method, and checked that
Francesco Romani has posted comments on this change.
Change subject: vm: rename statsAge parameter
..
Patch Set 7: Verified+1
verified with 65590
--
To view, visit https://gerrit.ovirt.org/65508
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: reformat setUnresponsiveIfTimeout
..
Patch Set 7: Verified+1
verified with 65590
--
To view, visit https://gerrit.ovirt.org/65504
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: introduce a `monitorable' attribute
..
Patch Set 5: Verified+1
works, but it is not enough to fix the bugs.
--
To view, visit
Francesco Romani has uploaded a new change for review.
Change subject: vm: check stats timeout only for monitorable VMs
..
vm: check stats timeout only for monitorable VMs
We should adjust responsiveness for stats too old
only
Francesco Romani has posted comments on this change.
Change subject: vm: ignore more errors in isDomainReadyForCommands
..
Patch Set 7:
The test failure is interesting but unrelated
00:15:56.269
Francesco Romani has posted comments on this change.
Change subject: virt: Inform Engine about switching to post-copy
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/64149/10/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Francesco Romani has posted comments on this change.
Change subject: virt: Inform Engine about switching to post-copy
..
Patch Set 10: Code-Review+2
bah, we still need confLock :( Not this patch's fault, obviously.
--
To
Francesco Romani has posted comments on this change.
Change subject: virt: Distinguish between switching to and entering post-copy
migration
..
Patch Set 7: Code-Review-1
(3 comments)
-1 for discussion
Francesco Romani has posted comments on this change.
Change subject: virt: Report paused VM status in post-copy
..
Patch Set 9: Code-Review+2
I see no issues here, and if it makes Engine's life easier, let it be.
--
To view,
Francesco Romani has posted comments on this change.
Change subject: virt: Distinguish between switching to and entering post-copy
migration
..
Patch Set 7:
the basic idea of distinguishing post copy phases is fine for me.
Francesco Romani has posted comments on this change.
Change subject: virt: Prevent monitoring of VMs in post-copy
..
Patch Set 9: Code-Review+1
Most likely https://gerrit.ovirt.org/#/c/65590/ will be merged earlier than
this
Francesco Romani has posted comments on this change.
Change subject: virt: Start all VM related stuff after switching to post-copy
migration
..
Patch Set 8: Code-Review-1
(1 comment)
-1 because inline questions
Francesco Romani has posted comments on this change.
Change subject: virt: Stop guest agent before switching to post-copy
..
Patch Set 8: Code-Review+1
(1 comment)
overall, minor comments, hence +1
Francesco Romani has posted comments on this change.
Change subject: vm: rename statsAge parameter
..
Patch Set 6: Verified+1
covered and verified by tests
--
To view, visit https://gerrit.ovirt.org/65508
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: vm: rename statsAge parameter
..
Patch Set 5: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/65508/5//COMMIT_MSG
Commit Message:
PS5, Line 11: onyl
Francesco Romani has posted comments on this change.
Change subject: Add new api to get the IO tune policies for all vms
..
Patch Set 10: Code-Review-1
...but my comments in vm.py still holds, so please check them. -1 for
Francesco Romani has posted comments on this change.
Change subject: Add new api to get the IO tune policies for all vms
..
Patch Set 10: -Code-Review
changed my score as per discussion in comments
--
To view, visit
Francesco Romani has uploaded a new change for review.
Change subject: vm: introduce a `monitorable' attribute
..
vm: introduce a `monitorable' attribute
In the change I3e61626625a2e0517d55dc61e361f3f5eb690c00
we fixed the
Francesco Romani has uploaded a new change for review.
Change subject: virt: move valid states list in vmstatus.py
..
virt: move valid states list in vmstatus.py
It is a more fitting place.
Only code movement.
Change-Id:
Francesco Romani has uploaded a new change for review.
Change subject: vm: refactor the monitorResponse handling
..
vm: refactor the monitorResponse handling
Move everything in a single method, to make the flow
easier to
Francesco Romani has posted comments on this change.
Change subject: py3: let bulk_sampling_test pass under py3
..
Patch Set 2: Code-Review+2
I need to improve the documentation of the methods, to explain where it is safe
to
Francesco Romani has submitted this change and it was merged.
Change subject: api: Speed up schema loading
..
api: Speed up schema loading
Use yaml.CLoader for 13x speedup in vdsm schema loading.
Here is a comparison with
Francesco Romani has posted comments on this change.
Change subject: virt: Initial support for post-copy migration
..
Patch Set 11: Code-Review+1
(1 comment)
ok once the packages are available
Francesco Romani has posted comments on this change.
Change subject: virt: Fetch only minimum VM stats during post-copy migration
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63552
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: virt: Destroy VM after post-copy migration failure
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64142
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Try to detect non guest iniated shutdowns
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64991
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: a Down domain is not ready for commands
..
Patch Set 3: Code-Review-1
not sure anymore. 65131 could be good enough, and surely is less controversial.
--
Francesco Romani has posted comments on this change.
Change subject: vm: ignore more errors in isDomainReadyForCommands
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/65131/2//COMMIT_MSG
Commit Message:
PS2, Line
Francesco Romani has posted comments on this change.
Change subject: vm: reformat setUnresponsiveIfTimeout
..
Patch Set 2: Verified+1
verified using the existing and the new tests (see followup patches)
--
To view, visit
1 - 100 of 9835 matches
Mail list logo
