Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: build cert paths in single place
..
utils: build cert paths in single place
We make sure that all the references to certificates location are
Dan Kenigsberg has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 14: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 15:
* update_tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Irit Goihman has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 14: Verified+1
--
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/52354/13/lib/vdsm/constants.py.in
File
Dan Kenigsberg has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 14: -Code-Review
--
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 14: Code-Review+1
lets monitor the sos paths collection in separate bugzilla and add it after
splitting
Francesco Romani has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/52354/13/lib/vdsm/constants.py.in
File
Nir Soffer has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/52354/13/lib/vdsm/constants.py.in
File lib/vdsm/constants.py.in:
gerrit-hooks has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 14:
* update_tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
Irit Goihman has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/52354/13/lib/vdsm/constants.py.in
File
Piotr Kliczewski has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/52354/13/lib/vdsm/constants.py.in
File
Dan Kenigsberg has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/52354/13/lib/vdsm/constants.py.in
File
Irit Goihman has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 13: Verified+1
no errors in vdsm, created a new vm and sos report shows the wanted data
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 13: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit
Irit Goihman has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/52354/12/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
Line
gerrit-hooks has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Irit Goihman has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/52354/12/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
Line
Dan Kenigsberg has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 12: Code-Review-1
(1 comment)
-1 for visibility
Irit Goihman has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 12:
I rebased the patch, please verify the changes
--
To view, visit https://gerrit.ovirt.org/52354
To
gerrit-hooks has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/52354/11/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
Dan Kenigsberg has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 11: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/52354/11/vdsm/sos/vdsm.py.in
File
Nir Soffer has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/52354/11/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
Line 85
Francesco Romani has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 11: Code-Review+1
nice improvement.
--
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe,
Piotr Kliczewski has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 11: Verified+1
Verified by updating vdsm and checking that communication works. One vm was
started to
gerrit-hooks has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/52354/10/build-aux/Makefile.subs
File
Piotr Kliczewski has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 10:
(4 comments)
https://gerrit.ovirt.org/#/c/52354/10//COMMIT_MSG
Commit Message:
Line 4: Commit:
Nir Soffer has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 10:
(4 comments)
Looks mostly good
https://gerrit.ovirt.org/#/c/52354/10//COMMIT_MSG
Commit Message:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 10: Verified+1
Verified by updating vdsm and starting new vm.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/constants.py.in
File
Dan Kenigsberg has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 7:
(2 comments)
(very partial review)
https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/constants.py.in
File
Piotr Kliczewski has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 7:
OK, let me check hard coding the path. It should simplify bunch of code we have.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
Line 103
Nir Soffer has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 7:
(4 comments)
https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/constants.py.in
File
Nir Soffer has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 7:
(3 comments)
I think that the issue is trying to support dynamic pki dir, while some of the
code is using
Nir Soffer has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/constants.py.in
File lib/vdsm/constants.py.in:
Piotr Kliczewski has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 7: Verified+1
Verified by updating vdsm and running a vm.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/52354/4/lib/vdsm/certutils.py
File lib/vdsm/certutils.py:
Nir Soffer has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/52354/4/lib/vdsm/tool/configurators/certificates.py
File
Nir Soffer has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 6:
Please address my comments from version 4:
gerrit-hooks has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/52354/1/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
Francesco Romani has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 1: Code-Review-1
-1 for visibility only
--
To view, visit https://gerrit.ovirt.org/52354
To
Francesco Romani has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 1:
(2 comments)
concept is fine IMO, but I'd polish a bit the implementation.
Piotr Kliczewski has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 1:
ping
--
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 1: Verified+1
Verified while running jsonrpc client
--
To view, visit https://gerrit.ovirt.org/52354
gerrit-hooks has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has uploaded a new change for review.
Change subject: utils: build cert paths in single place
..
utils: build cert paths in single place
Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Signed-off-by:
53 matches
Mail list logo
